Commit graph

7470 commits

Author SHA1 Message Date
Joseph Callen
2fc15c5d2b Resolves issue with vmware_vswitch module for v2.0
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing.

Playbook
```yaml
   - name: Add a temporary vSwitch
      local_action:
        module: vmware_vswitch
        hostname: "{{ inventory_hostname }}"
        username: "{{ esxi_username }}"
        password: "{{ site_passwd }}"
        switch_name: temp_vswitch
        nic_name: "{{ vss_vmnic }}"
        mtu: 1500
```

Module Testing
```bash
TASK [Add a temporary vSwitch] *************************************************
task path: /opt/autodeploy/projects/emmet/tasks/deploy/esxi_network.yml:13
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.37-180776062017566 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.37-180776062017566 )" )
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.41-201974997737598 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.41-201974997737598 )" )
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.44-148446986849801 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454342817.44-148446986849801 )" )
localhost PUT /tmp/tmpLLExSG TO /root/.ansible/tmp/ansible-tmp-1454342817.37-180776062017566/vmware_vswitch
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454342817.37-180776062017566/vmware_vswitch; rm -rf "/root/.ansible/tmp/ansible-tmp-1454342817.37-180776062017566/" > /dev/null 2>&1
localhost PUT /tmp/tmpyoAaHt TO /root/.ansible/tmp/ansible-tmp-1454342817.41-201974997737598/vmware_vswitch
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454342817.41-201974997737598/vmware_vswitch; rm -rf "/root/.ansible/tmp/ansible-tmp-1454342817.41-201974997737598/" > /dev/null 2>&1
localhost PUT /tmp/tmpPcmaMZ TO /root/.ansible/tmp/ansible-tmp-1454342817.44-148446986849801/vmware_vswitch
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454342817.44-148446986849801/vmware_vswitch; rm -rf "/root/.ansible/tmp/ansible-tmp-1454342817.44-148446986849801/" > /dev/null 2>&1
changed: [foundation-esxi-01 -> localhost] => {"changed": true, "invocation": {"module_args": {"hostname": "foundation-esxi-01", "mtu": 1500, "nic_name": "vmnic1", "number_of_ports": 128, "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "switch_name": "temp_vswitch", "username": "root"}, "module_name": "vmware_vswitch"}}
changed: [foundation-esxi-02 -> localhost] => {"changed": true, "invocation": {"module_args": {"hostname": "foundation-esxi-02", "mtu": 1500, "nic_name": "vmnic1", "number_of_ports": 128, "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "switch_name": "temp_vswitch", "username": "root"}, "module_name": "vmware_vswitch"}}
changed: [foundation-esxi-03 -> localhost] => {"changed": true, "invocation": {"module_args": {"hostname": "foundation-esxi-03", "mtu": 1500, "nic_name": "vmnic1", "number_of_ports": 128, "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "switch_name": "temp_vswitch", "username": "root"}, "module_name": "vmware_vswitch"}}

```

Documentation fix
2016-02-01 11:21:38 -05:00
Brian Coca
bec32094ae Merge pull request #1577 from bmillemathias/patch-2
fix typo
2016-02-01 10:25:16 -05:00
Baptiste Mille-Mathias
a11220228c fix typo
conainerization => containerization
2016-01-31 20:05:45 +01:00
Brian Coca
fff5ae6994 Merge pull request #1567 from danieljakots/devel
fix the spelling of vim's flavor in the example
2016-01-28 15:59:40 -05:00
Daniel Jakots
d24721f651 fix the spelling of vim's flavor in the example 2016-01-28 21:54:25 +01:00
Toshio Kuratomi
36be779888 Remove duplicate documentation fields 2016-01-28 09:20:55 -08:00
Brian Coca
eaec3cb45f Merge pull request #1564 from dalees/devel
Fix regression of #821 in puppet of show_diff
2016-01-28 12:05:22 -05:00
Dale Smith
27cd172900 Fix regression of #821 in puppet of show_diff
Issue #821 fix: 1382576100
Regressed since: 6912ca0aca

Issue: #821
2016-01-28 15:48:18 +00:00
Brian Coca
7eb3d6e15b Merge pull request #1559 from apenney/more-fixes
DOCS: Fix package list for nmcli module.
2016-01-26 14:17:20 -05:00
Ashley Penney
25262c2238 Fix package list for nmcli module.
There was a missing package that causes this to fail.
2016-01-26 13:38:44 -05:00
Brian Coca
3ed8a2ff67 Merge pull request #1558 from apenney/fix-mtu-docs
Change example to include ethernet as the type.
2016-01-26 11:28:23 -05:00
Ashley Penney
f5bfc4f9e9 Change example to include ethernet as the type. 2016-01-26 11:18:43 -05:00
Brian Coca
cecff17de3 Merge pull request #1513 from AbletonDevTools/devel
Fix #1512 add missing property in win_firewall_rule
2016-01-26 00:01:32 -05:00
Brian Coca
33213dbc24 Merge pull request #1508 from RajeevNambiar/devel
Update sts_assume_role.py for showing the correct example syntax role…
2016-01-26 00:00:49 -05:00
Brian Coca
ffefe5dde8 Merge pull request #1505 from Yannig/devel_fix_pvcreate
Use -f when pvcreate to avoid interactive input.
2016-01-26 00:00:00 -05:00
Brian Coca
98eeb689ce Merge pull request #1514 from doalitic/iptables-fix-append_csv
iptables: fix param check in append_csv function
2016-01-25 23:58:54 -05:00
Brian Coca
a7ad0bc7be Merge pull request #1499 from specnazzz/fix-seport-ports
seport module fails when the `ports` argument is a integer
2016-01-25 23:57:54 -05:00
Brian Coca
ec8bf56448 Merge pull request #1493 from abulimov/filesystem_recreate_with_force
Allow recreation of same FS with force=yes in filesystem module
2016-01-25 23:57:04 -05:00
Brian Coca
1f2b6bf3fd Merge pull request #1492 from alxgu/filesystem_idemponent
Make fileystem module idemponent. Compare devicesize and filesystemsize.
2016-01-25 23:55:34 -05:00
Brian Coca
65686221af Merge pull request #1488 from robbwagoner/ec2-elb-facts-with-instance-health
Include instance states (InService or OutOfService) as ELB facts
2016-01-25 23:54:29 -05:00
Brian Coca
6dfad7d157 Merge pull request #923 from mliudev/fix-rabbitmq_user-list_users
Check that the current output from 'list_users' command contains a '\t'.
2016-01-25 23:47:27 -05:00
Brian Coca
7286ff5024 Merge pull request #1546 from wimnat/feature/missing-doc-fragment
Add missing doc fragments
2016-01-25 23:03:54 -05:00
Matt Martz
e13942f9c5 Merge pull request #1522 from sivel/expect-repetition
Add functionality to give multiple iterative responses for a question
2016-01-25 12:02:30 -06:00
Rob White
0d86bc8d6b Add missing doc fragments 2016-01-24 11:11:49 +11:00
Brian Coca
d02e26c38f Merge pull request #1544 from colynn/devel
fixed python 2.4 compatibility
2016-01-22 12:01:49 -05:00
colynn.liu
9b981cecc6 fixed python 2.4 compatibility
nf=tempfile.NamedTemporaryFile(delete=False)
TypeError: NamedTemporaryFile() got an unexpected keyword argument 'delete'
2016-01-22 18:05:48 +08:00
Matt Martz
9476366d4e Add functionality to give multiple iterative responses for a question in expect 2016-01-19 14:33:05 -06:00
Matt Martz
e8427cb32a Merge pull request #1521 from Shrews/os_keystone_domain
Fix exception output for os_keystone_domain.
2016-01-19 11:29:40 -06:00
David Shrewsbury
46b4622eba Fix exception output for os_keystone_domain.
The message attribute of a shade exception is not very helpful.
Converting to a full string will contain many more details.
2016-01-19 12:17:36 -05:00
Brian Coca
ad2208c7b5 Merge pull request #1201 from bonds/devel
add ports support to openbsd_pkg
2016-01-19 09:11:41 -05:00
Brian Coca
e9450df878 Merge pull request #1486 from resmo/for-ansible
[2.0.1] cloudstack: fixes and improvements
2016-01-18 21:05:11 -05:00
Brian Coca
174bef08ae Merge pull request #1133 from lightblu/devel
Check to make sure the firewalld client is connected before proceeding
2016-01-18 20:51:58 -05:00
David Shrewsbury
f798240f43 Update Keystone Domain module for latest shade 2016-01-18 14:35:08 -06:00
Monty Taylor
02e91f8897 Extract module for keystone domain management 2016-01-18 14:35:08 -06:00
Haneef Ali
b65bd39615 Ansible module for Keystone V3 API
Change-Id: I9db323cc9e5a42353cab5cf4be6e22449cef8542
2016-01-18 14:35:07 -06:00
Scott Bonds
2b69a2b14c add python 2.5 requirement and ansible 2.1 version_added 2016-01-18 12:20:14 -08:00
Daniel Vigueras
16d17d287f iptables: fix param check in append_csv function 2016-01-18 16:11:13 +01:00
tcr
263774ea7d Fix #1512 add missing property in win_firewall_rule 2016-01-18 15:27:36 +01:00
RajeevNambiar
57a6a98cd9 Update sts_assume_role.py for showing the correct example syntax role_session_name instead of session_name
Update sts_assume_role.py for showing the correct example syntax role_session_name instead of session_name. session_name is not a valid property.
2016-01-16 09:13:18 -05:00
Chrrrles Paul
570869ef48 Merge pull request #1487 from chrrrles/vmware_doc_fragments
use doc fragments
2016-01-15 15:42:25 -06:00
Scott Bonds
5b555b9347 add ports support in openbsd_pkg 2016-01-15 13:19:54 -08:00
Alexander Gubin
8d7b1b0bd6 Make fileystem module idemponent. Compare devicesize and filesystemsize. 2016-01-15 18:35:45 +01:00
Yannig Perré
c276d9f621 Use -f when pvcreate to avoid interactive input.
Fix https://github.com/ansible/ansible-modules-extras/issues/1504
2016-01-15 16:33:42 +01:00
Brian Coca
90db7af7a7 Merge pull request #1501 from tomxtobin/fix-709-boolean-values
osx_defaults: Fix boolean value parsing
2016-01-14 18:15:31 -05:00
Tom X. Tobin
4c4a58e77b osx_defaults: Fix boolean value parsing
Values for boolean types were being unconditionally treated as strings
(by calling `.lower()`), thus breaking value parsing for actual boolean
and integer objects.

It looks like the bug was introduced in:

- 130bd670d8

Fixes #709.
2016-01-14 12:54:48 -05:00
Brian Coca
e5982ba5e3 Merge pull request #1500 from lipanski/fix_bundler_gem_path_option
Fix: Rename gem_install_path to gem_path - as specified in the docs
2016-01-14 12:37:59 -05:00
lipanski
bc66ba103f Fix: Rename gem_install_path to gem_path - as specified in the docs 2016-01-14 18:26:39 +01:00
Brian Coca
aae5847064 Merge pull request #1403 from LinusU/linusu-iptables-cleanup
iptables: cleanup
2016-01-14 11:04:37 -05:00
Michal Mach
ee2c730b7e Fix seport module issue when ports argument is interpolated from a variable and is a int 2016-01-14 11:47:19 +01:00
Brian Coca
38dfe23336 Merge pull request #1497 from jgeusebroek/devel
Fix documentation default value for gluster_volume start_on_create
2016-01-13 17:17:19 -05:00