Matt Clay
7714dcd04e
Enable more pylint rules and fix reported issues. ( #30539 )
...
* Enable pylint unreachable test.
* Enable pylint suppressed-message test.
* Enable pylint redundant-unittest-assert test.
* Enable pylint bad-open-mode test.
* Enable pylint signature-differs test.
* Enable pylint unnecessary-pass test.
* Enable pylint unnecessary-lambda test.
* Enable pylint raising-bad-type test.
* Enable pylint logging-not-lazy test.
* Enable pylint logging-format-interpolation test.
* Enable pylint useless-else-on-loop test.
2017-09-18 23:20:32 -07:00
Mike Wiebe
173c41aefe
Rel240/fix nxos pim interface ( #29885 )
...
* fix nxos_pim_interface
* Add integration test coverage and fix unit test
* Add clarifying comments
* Make ansibot happy
2017-09-14 13:36:32 -07:00
Ganesh Nalawade
3ff527b1d2
Fixes #30281 eos_banner integration test failure ( #30283 )
...
* Fixes #30281 Configure login prompt for eos_banner
* Fix unit test
* Fix pep8 issue
2017-09-14 13:56:32 +05:30
Matt Clay
442af3744e
Miscellaneous pylint fixes.
...
The following rules are no longer disabled:
- bad-format-string
- duplicate-key
- lost-exception
- trailing-newlines
- unexpected-keyword-arg
- useless-suppression
- using-constant-test
2017-09-13 01:53:08 -07:00
Matt Clay
68aeaa58a8
Fix dangerous default args. ( #29839 )
2017-09-12 00:11:13 -07:00
Tim Rupp
74ace093b8
Renames the bigip_configsync_actions module ( #29747 )
...
Retains the old name by making a symlink. We can remove it in a later
release.
2017-09-12 05:53:44 +01:00
Nathaniel Case
f84ff216b6
Generalize nxos_bgp event-history detection ( #28890 )
...
* More general handling of event-history
* Update unit tests
2017-09-06 17:37:44 -04:00
Nathaniel Case
8bfdbd0f73
nxos_bgp_neighbor: Fix regex &report warnings ( #28888 )
...
* Fix over-detection of log-neighbor-as
* Report nxos warnings
* Update nxos_bgp_neighbor unit tests to test remove-private-as
2017-09-01 15:17:42 -04:00
Trishna Guha
252efcebf5
module should fail if eos_user is added without configured_password or nopassword or sshkey ( #28780 )
...
* module should fail if eos_user is added without configured_password or nopassword or sshkey
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix eos_user unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix eos_user integration test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-31 15:29:57 -04:00
Mike Wiebe
d9fc3def94
Fixes #28779 eth_mode key error ( #28782 )
...
* Fixes #28779 eth_mode key error
* Remove unused get_config references
* Addressed PR comment
2017-08-29 17:07:46 -04:00
Nathaniel Case
64dac346c9
Fix nxos_pim_interface dr-priority handling ( #28472 )
...
* Fix nxos_pim_interface dr-priority handling
* Prefer execute_show over `| json`
* Mock get_config
* Fix sparse-mode detection
2017-08-29 14:42:09 -04:00
Jacob McGill
1c4fe510d0
IOS Ping: Add new module to support ping tests from IOS devices ( #28557 )
...
* IOS Ping: Add new module to support ping tests from IOS devices
* Add tests
* Add fixtures for ios_ping
2017-08-29 11:21:49 -04:00
Mike Wiebe
3d46258cff
Refactor/fix nxos_nxapi to use show run ( #28675 )
...
* Refactor/fix nxos_nxapi to use show run
* Fix unit tests
* Python 3 compatibility
2017-08-28 15:00:56 -04:00
George Nikolopoulos
c01dd6470c
Add disable operation for netscaler_servicegroup ( #28327 )
2017-08-25 17:03:21 +01:00
George Nikolopoulos
2281a6676b
Add enable, disable operation in netscaler_service ( #28321 )
2017-08-25 16:58:51 +01:00
Evgeny Fedoruk
71313ce04d
Module for uploading templates into vDirect server ( #27570 )
...
* Module for uploading templates into vDirect server
Module for uploading configuration and workflow templates
into Radware vDirect server
* Module for uploading templates into vDirect server
Module for uploading configuration and workflow templates
into Radware vDirect server
2017-08-25 16:23:36 +01:00
Peter Sprygada
75293d83ca
configures address-families when vrf is created ( #28615 )
...
* configures address-families when vrf is created
fixes #26725
* fix up unit test cases
2017-08-25 07:51:20 -04:00
Mike Wiebe
ec11cd2696
nxos_bgp_neighbor_af fix problem with advertise-map properties ( #28413 )
...
* Fix problem with advertise-map properties
* Change limit_to back to run all tests
* Fix unit tests
* Move advertise_map out of get_custom_value
2017-08-21 15:28:02 -04:00
David Newswanger
b818e986b6
Change network *_user modules to use configured_password to set a users password ( #28187 )
...
* WIP, update eos_user args
* refactor password for ios_user
* add eos tests, fix ios tests
* fixed password check
* refactor iosxr_user password
* fixed password arg for nxos
* [WIP] fix vyos_user password
* fix vyos tests
* update docs for net_user
* fix typo
* fix eos tests
* add warning when attempting to use password arg
* fix sanity/unit tests
* fix eos unit tests
* fix vyos_user aggregate
* fix typo in eos documentation string
* re add configured_password to vyos tests after rebase
2017-08-17 19:06:44 +05:30
George Nikolopoulos
b339f23485
Various small fixes ( #27766 )
2017-08-16 14:14:21 -04:00
Peter Sprygada
6886153b54
refactors nxos_vrf_af module ( #28208 )
...
* refactors nxos_vrf_af module
fixes #27595
* fix up unit test cases
* add commands to result dict
* add route-target on afi create
* adds deprecation note to safi argument
2017-08-16 10:11:12 -04:00
David Newswanger
a37c5e53e6
fix prompt error when deleting ios user ( #28175 )
...
* fix prompt error when deleting ios user
* placate pep8
* wrap delete user command in function
* fix python 3 unit tests
2017-08-16 15:15:41 +05:30
Trishna Guha
ce3d1c6ba0
eos_user fix username param ( #28114 )
...
* eos_user fix username param
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add setup eos_user test and rename username for consistency
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* update unit test and pep8 fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* pep8 fix
2017-08-16 12:08:59 +05:30
saichint
d69440c4ef
Fix nxos_vpc issues ( #28188 )
...
* fix for nxos_vpc issues
* fix unit tests
* clean documentation
2017-08-15 12:08:55 -04:00
saichint
9d84a4e530
fix for nxos_ospf_vrf invalid cmd and ntp errors ( #27977 )
...
* fix for nxos_ospf_vrf invalid cmd
* fix for nxos_ntp issues
2017-08-14 16:09:16 -04:00
Trishna Guha
60ce6438e3
fix nxos_overlay_global idempotence ( #28150 )
...
* fix nxos_overlay_global idempotence
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* modify nxos_overlay_global unittest
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-08-14 16:09:53 +05:30
David Newswanger
a01aa6e9df
Fix structured output not supported in nxos_pim_interface ( #28125 )
...
* fixed unstructured error
* fix unit tests so they accept commands in dictionary form
2017-08-14 12:34:05 +05:30
Trishna Guha
12460dd713
Add ios_vrf declarative intent config check ( #28001 )
...
* Add ios_vrf declarative intent config check
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* add version for delay param
* modify ios_vrf unit test
2017-08-14 12:27:03 +05:30
Nathaniel Case
a78f3faa6c
nxos_bgp_neighbor_af does not want required_together ( #26370 )
...
* nxos_bgp_neighbor_af does not want required_together
* fixup tests
* Fix max_prefix_* issues
* Require address-family
* Fix idempotency for next_hop_third_party
* Fix idempotency for allowas_in*
* Fix idempotency for *_in and *_out
* Reorder command generation again
`default` is first, then `max-prefix`, then booleans
2017-08-09 15:54:34 -04:00
Nathaniel Case
c1bf74283e
Network load_config: Capture configuration output and display as warnings ( #27851 )
...
* Capture configuration output and display as warnings
* Don't break on nxapi
nxapi errors very loudly instead, so no need to muck about with warnings
2017-08-09 09:43:04 -04:00
George Nikolopoulos
31b4ae2e6a
New module: manage Citrix Netscaler GSLB site configuration (network/netscaler/netscaler_gslb_site) ( #27639 )
...
* Add netscaler_gslb_site
* Lowercase enabled, disabled option values
* Add fixes in netscaler module utils needed for unit test success
2017-08-03 15:26:17 +01:00
George Nikolopoulos
d88c07a037
New module: manage Citrix Netscaler GSLB service configuration (network/netscaler/netscaler_gslb_service)) ( #27638 )
...
* Add netscaler_gslb_service
* Lowercase enabled, disabled option values
* Add fixes in netscaler module utils needed for unit test success
2017-08-03 15:26:05 +01:00
George Nikolopoulos
cd865be987
New module: manage Citrix Netscaler SSL certificate keys (network/netscaler/netscaler_ssl_certkey)) ( #27641 )
...
* Add netscaler_ssl_certkey
* Fix options
* Lowercase enabled, disabled option values
* Add fixes in netscaler module utils needed for unit test success
2017-08-03 15:24:56 +01:00
George Nikolopoulos
e2f907ae3e
Add netscaler_gslb_vserver ( #27640 )
2017-08-03 12:32:10 +01:00
mharista
c85f363aaa
Add module cv_server_provision for integration with Arista CloudVision Portal. ( #25450 )
...
* Add module cv_server_provision for integration with Arista CloudVision Portal.
* Doc update.
* Remove shebang from test file. Update short description with company and product name.
* Update exception syntax to Python3 style.
* Remove blank line between imports.
* Remove newlines from RETURN documentation.
* Add cvprac to unittest requirements.
* Update unittest format. Add a few additional tests.
* Mock exceptions from cvprac so the library is not needed for unittests.
* Mock cvprac imports.
* Update unit tests to support python 3.5.
* Mock full cvprac library for unittests.
* Update Jinja2 import to pass updated CI checks.
* Update cvprac imports format for new CI tests.
* Add __metaclass__ and __future__.
2017-08-02 15:24:52 +01:00
James Mighion
4dd8f281d6
Adding aruba_config module ( #27130 )
...
* Adding aruba_config module.
* Fixing documentation.
* Forgot action plugin.
2017-08-01 11:44:26 -06:00
George Nikolopoulos
f204e7cb33
New module: manage Citrix Netscaler content switching virtual server configuration (network/netscaler/netscaler_cs_vserver) ( #26245 )
...
* Add netscaler_cs_vserver
* Correct version_added
2017-08-01 18:43:59 +01:00
George Nikolopoulos
36537186e3
New module: manage Citrix Netscaler content switching policy configuration (network/netscaler/netscaler_cs_policy) ( #26189 )
...
* Add netscaler_cs_policy
* Correct version_added
2017-08-01 18:35:29 +01:00
George Nikolopoulos
e329c9da8c
New module: manage Citrix Netscaler servicegroup configuration (network/netscaler/netscaler_servicegroup)) ( #26183 )
...
* Add netscaler_servicegroup
* Correct version_added
2017-08-01 18:34:28 +01:00
George Nikolopoulos
7df14bd2b0
New module: manage Citrix Netscaler load balancer virtual servers configuration (network/netscaler/netscaler_lb_vserver) ( #26144 )
...
* Add netscaler_lb_vserver
* Correct version_added
2017-08-01 18:33:35 +01:00
George Nikolopoulos
ac0c5dec2f
Add netscaler_lb_monitor ( #26143 )
2017-08-01 11:30:47 -06:00
Dag Wieers
97aaf103e8
ACI module_utils library for ACI modules ( #27070 )
...
* ACI module_utils library for ACI modules
This PR includes:
- the ACI argument_spec
- an aci_login function
- an experimental aci_request function
- an aci_response function
- included the ACI team
* New prototype using ACIModule
This PR includes:
- A new ACIModule object with various useful methods
2017-07-31 12:44:27 +01:00
James Mighion
a328e96455
Adding aireos_config module ( #27408 )
...
* Adding aireos_config module.
* Fixing pep8 W291.
2017-07-29 00:36:04 +05:30
Trishna Guha
6d1bd33aa5
fix iosxr_banner ( #27378 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-07-28 17:09:04 +05:30
Trishna Guha
a49c419651
fix nxos_vrf_af nxapi & cli ( #27307 )
...
* fix nxapi failure #27142
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix nxos_vrf_af nxapi and cli
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-07-28 09:02:02 +05:30
David Newswanger
81151ef02c
Remove Deprecated Template network modules ( #27076 )
...
* removed deprecated networking template modules
* update changelog
* update changelog
2017-07-27 19:40:11 +01:00
saichint
9b9a8749da
Add integration tests and fix nxos providers ( #26913 )
...
* fix issues with python3.x
* Add integration testa and fix for nxos_evpn_vni
* add nxos_evpn_vni to nxos.yaml
* fix get_vtp_config()
* add new integration tests
* fix rollback
* add integration test files
2017-07-27 09:32:35 -04:00
Trishna Guha
41ce724801
fix nxos_hsrp ( #27306 )
...
* fix nxos_hsrp
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* modify nxos_hsrp test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-07-26 11:38:55 +05:30
Ricardo Carrillo Cruz
3a3bdde869
Fix multiple code and test issues on iosxr ( #27267 )
...
* Fix multiple code and test issues on iosxr
It passes the integration tests now.
Fixes #27123
* Fix pep8 issue
* Fix unit tests
2017-07-25 17:21:53 +02:00
Philippe Dellaert
c00554735f
New module: management of the Nuage Networks VSP SDN solution (network/nuage/nuage_vspk) ( #24895 )
...
* Nuage module and unit tests with requested changes
* Cleanup of imports
* Adding check on python version
* Adding import try and catch wrappers
* Cleanup of requirements and adding integration tests
* Using pypi package for simulator
* Cleanup of requirements and adding integration tests
* Adding aliases for integration tests
* Adding module to import sanity test skip list
* Revert "Adding module to import sanity test skip list"
This reverts commit eab23af8c5
.
* Adding check for importlib and cleanup of requirements
2017-07-25 12:35:03 +01:00