cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
4030 commits 47 branches 390 tags 440 MiB
Commit graph

467 commits

Author SHA1 Message Date
nextus
f0ea92cc75 Fix: absent state removing whole cron.d file instead of specific job 2013-11-13 23:58:37 +04:00
James Tanner
73d36f84b1 Merge pull request #4282 from cristobalrosa/ansible 
Add a fact for checking if interface is in promiscuous mode.
 2013-11-13 10:33:57 -05:00
Sergey Sudakovich
ae9fd2172e fix when the system does not have lsb_release script, but has /etc/lsb_release file 2013-11-12 15:25:39 -08:00
James Tanner
36c4f05891 Add more error detail to the service module for FreeBSD 2013-11-12 00:02:30 -05:00
jctanner
fc51fb8853 Merge pull request #4304 from ferringb/fixes/cron-permissions 
Enforce umask for cron module, so cron_file generated files are 0644.
 2013-11-11 14:23:39 -08:00
Hiroaki Nakamura
cc17a0ac7d Apply the same change as https://github.com/hnakamur/ansible-playbooks/pull/2 2013-11-10 08:28:33 +09:00
James Tanner
44014d6800 Set the correct version added for the hostname module 2013-11-07 22:01:02 -05:00
jctanner
9083258fa7 Merge pull request #3940 from hnakamur/hostname_module 
Add a hostname module, which sets system's hostname.
 2013-11-07 15:11:06 -08:00
James Tanner
e62cbba1fc Address #4573 Check interface keys and return gracefully on solaris zones 2013-11-06 18:11:22 -05:00
Jim Richardson
71bf839121 return True/False from remove_job_file() 
revised fix for https://github.com/ansible/ansible/issues/4795
 2013-11-04 14:14:53 -08:00
Jim Richardson
dd313b1b8f fix for https://github.com/ansible/ansible/issues/4795 
Incorrect changed result in cron module.
Report changed=False if no cron is removed:wq
 2013-11-03 17:43:51 -08:00
Hiroaki Nakamura
7aa728a32f Fix for RHEL6. 2013-11-01 23:32:14 +09:00
Michael DeHaan
99a8213be1 Merge pull request #4754 from mscherer/fix_4648 
Fix 4648, cron module is not working on solaris
 2013-10-31 14:49:25 -07:00
Michael DeHaan
0e7069d7c1 Undo an inadvertant revert from template changes so we still allow pythonic imports in module land. 2013-10-31 16:53:05 -04:00
Michael Scherer
2a3ee8dbf4 make cron module work on solaris 
Cron on solaris do not take the same
set of option than vixie cron on linux, and
among the biggest difference, root cannot set
the crontab of a user directly from a file. Thus the
use of su to run the crontab command. Fix issue #4648
 2013-10-31 19:58:26 +01:00
Michael Scherer
5547cc9c29 remove unused function 2013-10-31 19:58:26 +01:00
Scott Dunlop
be6e2c9097 add "zle" as a supported ZFS compression type 
ZFS supports "zle" compression, which compresses runs of null bytes efficiently.
 2013-10-31 10:48:41 -07:00
James Tanner
8036e6ee23 Revert templating enhancements from 73dbab70 e6c28658 d409352c 9858b1f2 4587528b 9b1fe455 214b0b05 8d3db803 7f9504d1 5031104c 35cb9dc2 2bd8cb57 1e85c754 2013-10-30 10:50:16 -04:00
jctanner
63b1c47881 Merge pull request #4715 from mscherer/fix_4702 
Fix #4702, make setup work on windows
 2013-10-29 06:03:49 -07:00
Michael Scherer
2865a1b074 Fix #4702, make setup work on windows 2013-10-28 23:41:18 +01:00
James Cammarata
4c80cf411c Fixing authorized_keys module to make the key part detection better 
Fixes #4677
Fixes #4657
Fixes #4599
 2013-10-28 13:52:45 -05:00
Christian Berendt
8672ce9769 changing permissions of modules to 0644 2013-10-28 14:50:35 +01:00
Michael DeHaan
8bcd697816 Merge pull request #4424 from localvoid/firewalld-rich_rules 
Add support for Rich Rules in firewalld module
 2013-10-27 08:55:22 -07:00
Michael DeHaan
dcc1beab37 Merge pull request #4600 from earchibald/devel 
Added ['date_time']['tz_offset'] using %z to get the time offset rather ...
 2013-10-27 08:30:28 -07:00
Michael DeHaan
a6aeb12c8c Merge pull request #4560 from tronner/issue4461 
Fix illegal set operation in FreeBSD section of user module.
 2013-10-26 11:31:20 -07:00
Michael DeHaan
bc6d454b5e Enable imports to work on a snippet based system, allowing for instance a library of common EC2 functions 
to be reused between modules.  See library/system/service and library/system/ping for initial examples.  Can
work the old way to just import 'basic', or can import the new way to import multiple pieces of code from
module_utils/.
 2013-10-26 11:09:30 -04:00
James Tanner
f27e2fd285 Fixes #4448 reloaded services should be started if not running 2013-10-25 15:30:02 -04:00
James Cammarata
a220d7c18c Merge branch 'fix_autorized_keys' of https://github.com/mscherer/ansible into mscherer-fix_autorized_keys 2013-10-24 20:13:38 -05:00
James Cammarata
8fc62a1fb0 Fixing up authorized_keys to accept comments with spaces 2013-10-24 20:12:56 -05:00
Michael Scherer
d53abc2d5e make sure that options are quoted, as people can add a shell 
script there with a comma that would produce invalid configuration
upon being wrote again
 2013-10-24 23:51:55 +02:00
Michael Scherer
2ad3a46e13 sort the option_key to have a constant predictable line 2013-10-24 23:47:34 +02:00
Michael Scherer
7afaeea131 adding a single comma at the end of the options list confuse the module 
it start to duplicate line, because this create
a empty option in the list, and so the module add a new line along the previous
one. See

>>> ' a,b, '.strip().split(',')
['a', 'b', '']
 2013-10-24 23:46:49 +02:00
Scott Sturdivant
037dcbb4da If the output of rcvar isn't a key=value pair, ignore it. 2013-10-21 14:20:54 -06:00
Eugene Archibald
6599feac47 Fixed (broken) tab to (correct) spaces for indentation 2013-10-19 17:04:37 -07:00
Michael DeHaan
ce8b0944a9 Misc pep8 fixes 2013-10-19 13:03:15 -04:00
Michael DeHaan
c981999975 Merge pull request #4592 from mscherer/fix_4586 
setup module, replace ':' by '_' in interface name, fix #4586
 2013-10-19 09:07:56 -07:00
Eugene Archibald
70c78eade0 Added ['date_time']['tz_offset'] using %z to get the time offset rather than time zone. 2013-10-18 20:32:35 -07:00
Michael Scherer
4fb753997f fix logic in module host to add aliases even if none exist already, fix #4563 
self._has_aliases is used to know if a alias already exist, but
the test we want is to know if we need to add a new alias, which
is stored in self.aliases
 2013-10-19 01:51:42 +02:00
Michael Scherer
fa0d869ddd setup module, replace ':' by '_' in interface name, fix #4586 2013-10-19 00:24:07 +02:00
James Tanner
54781bdfe1 Fixes #4554 Enumerate user homedir if not passed as an argument 2013-10-17 13:15:32 -04:00
Thomas Ronner
3b45cb366f Fix illegal set operation in FreeBSD section of user module. 2013-10-17 15:02:23 +00:00
jctanner
6dedb68bde Merge pull request #4517 from adfinis-sygroup/devel 
Remove keys regardless of the options
 2013-10-16 17:40:43 -07:00
James Tanner
798dba436a Fixes #4350 Create homedirectory if create=yes and directory is missing 2013-10-16 20:08:41 -04:00
Hiroaki Nakamura
744b758633 Add support for Fedora, OpenSUSE and ArchLinux. 
Tested under Fedora 19 and OpenSUSE 12.3. Not tested on ArchLinux.
 2013-10-16 01:15:47 +09:00
Hiroaki Nakamura
7bd59c4b23 Do not use shortcut conditional operator which is not supported in Python 2.4. 2013-10-15 23:41:49 +09:00
James Cammarata
57cec2a88b Handle ssh key files that may only have a type/key specified 
If a specified key did not have a comment, it would be ignored as
an invalid key.

Fixes #4513
 2013-10-15 09:05:50 -05:00
Stefan Heinemann
576f5813a2 Set the options of an authorized key comma separated 
According to the sshd man page, no spaces are permitted between the
options of an authorized ssh key
 2013-10-15 15:29:52 +02:00
Stefan Heinemann
948713db5e Don't mind the options of a key when removing it 
This allows to remove a key without knowing the options in the
authorized_key file
 2013-10-15 15:29:47 +02:00
Michael DeHaan
377b3f4b6f Merge branch 'devel' of git://github.com/shirou/ansible into devel 2013-10-14 11:50:25 -04:00
Keith Buck
5397f90f0c Improve the formatting and content for the sysctl module's description. 2013-10-14 07:16:47 +00:00
James Cammarata
2753a40d5a Adding 'unique' option to authorized_key module and cleanup 
A small refactoring of the authorized_key module to accomodate these
changes, plus fixing some things like not rewriting the file on every
new key. These changes bring the original feature for ssh options in-
line with the comments in #3798

Fixes #3785
 2013-10-11 16:22:37 -05:00
David Minor
0828d3a316 Add ssh key options parameter to authorized_key module 2013-10-11 16:22:37 -05:00
James Tanner
74833f730b Fixes #4312 for older versions of usermod which do not have --append 2013-10-11 09:10:46 -04:00
Michael DeHaan
beae21dd40 Remove examples of module antipattern of setting the choices array for boolean types. 2013-10-11 08:45:13 -04:00
Boris Kaul
82a89b79d6 Add support for Rich Rules in firewalld module 2013-10-10 20:09:52 +07:00
Boris Kaul
3e85f39ba7 Fix timeout bug in firewalld module 2013-10-10 13:41:42 +07:00
James Tanner
4ce2a5f8df Second attempt at preventing ipv6 route enumeration on EL4 machines 2013-10-08 18:40:15 -04:00
James Tanner
bee6b544f5 Revert "Do not enumerate ipv6 routes in CentOS 4" 
This reverts commit 5186c408f7.
 2013-10-08 15:51:12 -04:00
James Tanner
879d20cac3 Do not enumerate ipv6 routes in CentOS 4 2013-10-08 15:12:38 -04:00
Michael DeHaan
d1b9ca4427 Add documentation about how passwords are generated. 2013-10-08 08:36:48 -04:00
James Cammarata
85cd7f7500 Better detection/categorization of ipv4 secondaries/virtual IPs 
Fixes #3916
Fixes #3478
 2013-10-07 15:18:33 -05:00
Michael DeHaan
9771032885 Merge pull request #4389 from MattTheRat/devel 
addresses #4371 - adds -m to usermod commands
 2013-10-07 12:15:20 -07:00
Matt Warren
f40a1e0eae addresses https://github.com/ansible/ansible/issues/4371 - adding -m to home directory modification 2013-10-07 10:47:12 -04:00
Michael DeHaan
c405a61505 Merge pull request #4336 from orkaa/devel 
Fixes service update-rc.d functionality on debian
 2013-10-07 05:56:43 -07:00
Martijn Lina
3d16b75096 replace dashes in rc.conf keys (which are based on freebsd rc.d filenames) to underscores 2013-10-04 16:30:39 +02:00
Skylar Saveland
db378d4515 fixes 4365 - Mac with cisco vpn client, GenericBsdIfconfigNetwork get_default_interfaces fails with index out of range 2013-10-03 18:58:11 -07:00
Adam Miller
8b5bb43958 fixed firewalld get_service_enabled 2013-10-02 18:52:53 -05:00
Nace Oroz
1f39663a97 Fixes service update-rc.d functionality on debian 2013-10-02 14:27:38 +02:00
cdigiovanni
6720d0cf70 Added support to disable and enable upstart jobs 2013-09-30 14:50:47 -05:00
Brian Harring
487aa9a1ec Enforce umask for cron module, so cron_file generated files are 0644. 
Certain cron implementations get cranky if files in cron.* are group
writable.
 2013-09-30 13:21:07 -04:00
Nils Pascal Illenseer
e1ff809d1a Add option 'lz4' for compression 2013-09-30 14:20:21 +02:00
Cristobal Rosa
0cbb97bddc Added an space between code and comments in order to follow the coding standars 2013-09-28 00:02:43 +02:00
Cristobal Rosa
0b10e1d019 Added a new check to check whether an network interface is in promiscuous mode 2013-09-28 00:02:06 +02:00
James Cammarata
38487ea464 Merge pull request #4222 from lessmian/devel 
Module lvol fails when decimal point is a colon
 2013-09-25 14:54:58 -07:00
James Cammarata
a774f686f7 Merge branch 'obsd-fix-release' of https://github.com/johanwiren/ansible into johanwiren-obsd-fix-release 2013-09-25 14:49:57 -05:00
James Cammarata
6dbb1ff878 Fixing up some open_iscsi docs and CHANGELOG update 2013-09-25 14:37:56 -05:00
James Cammarata
d920cbc25f Merge branch 'open_iscsi_bis' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-open_iscsi_bis 2013-09-25 14:35:01 -05:00
Tomasz Lesniewski
0eb92ac852 Module lvol fails when decimal point is a colon 2013-09-24 16:19:07 +02:00
Rene Moser
9f969cd3ec host: minor doc style improvements 2013-09-24 15:47:39 +02:00
Tomasz Lesniewski
75ca71bf2c Module lvol fails when decimal point is a colon 2013-09-24 15:06:18 +02:00
Michael DeHaan
eca73d3c82 Merge pull request #4220 from dagwieers/setup-dmidecode-fix 
Fix for commented dmidecode output
 2013-09-24 05:04:33 -07:00
Dag Wieers
b4cdd15843 Fix for commented dmidecode output 
This patch fixes the problem that on some system dmidecode prints out warning information as commented text. For example:

    [user@system ~]# dmidecode -s system-manufacturer
    # SMBIOS implementations newer than version 2.6 are not
    # fully supported by this version of dmidecode.
    HP

So we remove all commented lines from the output.
 2013-09-24 12:46:48 +02:00
Rene Moser
497b742935 host: added another example 2013-09-24 09:15:16 +02:00
James Cammarata
28592ed64f Minor pep8 cleanup 2013-09-23 16:37:42 -05:00
James Cammarata
d4ba1f9ded Fixing some bugs found during testing in the host module 2013-09-23 16:05:43 -05:00
James Cammarata
339f17d560 Merge branch 'feature/host' of https://github.com/resmo/ansible into resmo-feature/host 2013-09-23 15:42:30 -05:00
James Cammarata
104535ac48 Merge branch 'devel' of https://github.com/drybjed/ansible into drybjed-devel 2013-09-23 15:10:40 -05:00
James Cammarata
65180fa530 Added version_added string to new modprobe module and CHANGELOG update 2013-09-23 15:02:02 -05:00
James Cammarata
04683f554b Merge branch 'modprobe-module' of https://github.com/stygstra/ansible into stygstra-modprobe-module 2013-09-23 15:00:50 -05:00
James Cammarata
aadf8175c6 Modified env fact gathering to use the native python method 
Also updated CHANGELOG for this feature
 2013-09-23 14:17:40 -05:00
James Cammarata
d16a382935 Merge branch 'env_facts' of https://github.com/bcoca/ansible into bcoca-env_facts 2013-09-23 13:46:11 -05:00
Maciej Delmanowski
669b345937 Made re.search string shorter 2013-09-23 12:27:14 +02:00
Maciej Delmanowski
fa879a63a1 Add Linux Container identification 2013-09-23 12:15:33 +02:00
Johan Wirén
9120303446 Fixed setup module to no longer break on OpenBSD release versions. 2013-09-22 14:05:22 +02:00
James Cammarata
6eec6f776e More housekeeping 
* Modified version_added strings in recent modules
* Added firewalld inclusion to the CHANGELOG
 2013-09-21 01:06:34 -05:00
James Cammarata
6b5b004232 Moving firewalld module from net_infra to system 2013-09-21 01:02:19 -05:00
René Moser
d2d6b20d99 host: code cleanup 2013-09-20 22:50:03 +02:00
James Cammarata
3511687dad Minor tweak to service changed logic from the previous commit 2013-09-19 15:00:25 -05:00
James Cammarata
8bdb95a014 Merge branch 'service-enable-fix' of https://github.com/gottwald/ansible into gottwald-service-enable-fix 2013-09-19 14:59:53 -05:00
Petr Svoboda
f82d3f7fa9 Fix traceback in service module when svc_cmd is None (2nd fix) 
When service module is used on unsupported Linux system where init
script is used directly, LinuxService.svc_cmd is None so .endswith()
fails.

This extends fix from e2f20db534 also
for state=restarted.

Fixes issue #3533
 2013-09-19 14:36:02 -05:00
René Moser
9f5d8f8482 host: updated version_added 2013-09-19 20:09:38 +02:00
Rene Moser
318c956a22 added module host 
Add or remove entries in /etc/hosts using tasks:
- host: ip=127.0.0.1 hostname=localhost aliases=foobar.com,localhost.foobar.com
- host: ip=127.0.0.1 hostname=localhost state=present
- host: ip=192.168.1.1 state=absent
- host: hostname=localhost state=absent
- host: ip=::1 hostname=localhost aliases=ip6-localhost,ip6-loopback
 2013-09-19 20:09:38 +02:00
David Stygstra
86d4331e3b Add Python 2.4 support to modprobe module 2013-09-19 00:04:20 -04:00
David Stygstra
d6a5e05a21 Module to manage kernel modules 2013-09-19 00:02:44 -04:00
James Cammarata
7a52ad498d Merge branch 'issue_3417_systemd_stuff' into devel 2013-09-16 09:30:39 -05:00
James Cammarata
3d09c6441e Merge branch 'archlinux-fact' of https://github.com/Schnouki/ansible into Schnouki-archlinux-fact 2013-09-16 07:45:38 -05:00
r-p-e
df746b4fb7 Add some more OpenBSD facts 
added:
 * ansible_distribution
 * ansible_distribution_release
 * ansible_distribution_version
 2013-09-15 17:58:29 +02:00
Ingo Gottwald
08af5f833f Bugfix service module: Only change service state when needed 2013-09-13 22:04:37 +02:00
Thomas Jost
725dd43fca Add Archlinux "distribution" fact 2013-09-12 11:55:08 +02:00
James Cammarata
0449470f21 Allow service module to manage services not ending in .service 
Fixes #3417
 2013-09-11 15:48:36 -05:00
James Cammarata
3e7511609e Slight refactorization of the sysctl module 
* Added in support for freebsd-style sysctl commands
* Replaced some functionality that was provided by module_common
* Simplified some logic in a couple of places (ie, not checking
  a split with len() but instead limiting the split to 1)

Fixes #3380
 2013-09-11 13:15:17 -05:00
James Cammarata
8d6e302cf8 Compare exploded values in the sysctl module to avoid whitespace errors 
Fixes #3931
 2013-09-10 23:24:24 -05:00
James Cammarata
5fe192e5e7 Fixes to the service module for Ubuntu 12.04 (LTS) 
Fixes #3615
Fixes #3572
 2013-09-10 22:19:15 -05:00
James Cammarata
5e8918cb2c Check for systemd ownership of a service even if an init.d script exists 
Also slight modification to the error message in the earlier commit that
modified the update-rc.d detection portion of the code

Fixes #3474
 2013-09-10 19:37:51 -05:00
James Cammarata
ef02c6107a Minor fix to account for template service names in systemctl 2013-09-10 11:31:13 -05:00
James Cammarata
f22ffab259 Fix for update-rc.d based systems that also have systemd installed 
By default, the service module had assumed that if the system had the
update-rc.d binary, the service was either managed via upstart or standard
sysV init-style scripts. This patch adds a check for systemctl ahead
of the other methods when update-rc.d is detected, and also simplifies
the logic around the detection of systemctl-managed services
 2013-09-10 11:15:30 -05:00
James Laska
5dc830c279 The required package for selinux is libselinux-python 2013-09-06 16:26:48 -04:00
Brian Coca
849d7b282b Added collection of user's env 
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
 2013-09-06 08:55:37 -04:00
James Cammarata
21ae255fb3 Merge branch 'aix_wpar_facts' of https://github.com/mplonka/ansible into mplonka-aix_wpar_facts 2013-09-05 23:49:29 -05:00
James Cammarata
17f683aad7 Added 'reloaded' state to list of states checked for bounced services 
Fixes #3556
 2013-09-03 09:49:19 -05:00
Serge van Ginderachter
129fa6689f Introduce open-iscsi module to manage targets on the initiator. 2013-09-03 13:31:28 +02:00
Raul Melo
b0ffba472f Fix issue 3908. There was some ilegal operations over the sets 2013-08-27 17:07:42 +02:00
James Cammarata
b4306920ce Fix for the cron module on FreeBSD 
Apparently crontab on freebsd does not like the file path coming before
the "-u username" portion of the command to install the crontab
 2013-08-24 21:37:10 -05:00
Hiroaki Nakamura
2bef08705f Fix a bug in DebianStrategy.get_permanent_hostname(). Use strip, not split! 2013-08-25 07:46:23 +09:00
Hiroaki Nakamura
bf21ba1521 Rewrite with "try ... finally" instead of "with" statement to support Python 2.4. 2013-08-25 07:44:18 +09:00
Hiroaki Nakamura
860cf75fdc Remove extra sysloggings. 2013-08-25 07:35:20 +09:00
Hiroaki Nakamura
14fde81ad5 Raise an error on unsupported platform/distributions. 2013-08-25 07:32:37 +09:00
Hiroaki Nakamura
557c25a794 Add a hostname module, which sets system's hostname. 2013-08-25 00:49:15 +09:00
Marcin Płonka
4a43bb3b00 Skipping facts not available on AIX WPARs 2013-08-24 07:24:05 +02:00
shirou
26e6ac4340 supports nested values of ohai. 2013-08-23 17:00:56 +09:00
Michael DeHaan
003c86e250 Merge branch 'fix_service_with_initscript' of git://github.com/psvo/ansible into devel 2013-08-10 18:05:35 -04:00
Andy Wilson
85e34cc107 docfix: grammar in docstring for sysctl module 2013-08-08 12:23:30 -05:00
Petr Svoboda
48b064b55b Fix traceback in service module when svc_cmd is None 
When service module is used on unsupported Linux system where init
script is used directly, LinuxService.svc_cmd is None so .endswith()
fails.

Fixes issue #3533
 2013-08-08 14:24:20 +02:00
Michael Scherer
bb9d0a9493 Add urpmi as a package manager for mandriva-based distribution 2013-08-04 00:03:50 +02:00
James Cammarata
494030aa6c Removing skipped=True so the task is just marked as not-changed 2013-08-03 12:15:09 -05:00
James Cammarata
f3384374b9 Set result to skipped when vol group is missing and lv state=absent 
Fixes issue #3714 - lvol module state=absent fails (with error) if
the volume group doesn't exist
 2013-08-02 20:32:56 -05:00
rishid
fea38f44ac Verify groups string is not empty before trying add user to groups 2013-08-01 21:19:11 -04:00
Brian Coca
e8e8779dfa fixed bug from prev update 
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
 2013-08-01 00:24:34 -04:00
Brian Coca
2c06418f6d whitespace updates on new lines 
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
 2013-07-31 23:26:28 -04:00
Brian Coca
fe57037f84 now uses get_bin_path for lvg executables 
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
 2013-07-31 22:32:41 -04:00
Michael DeHaan
5b80299231 Make exceptions handling python 2.4 compatible. 2013-07-29 13:27:16 -04:00
Michael DeHaan
ecf074865f Continue on mount errors, don't fail the setup module. 2013-07-22 13:57:35 -04:00
Brian Coca
220fe24d39 use global to fail as its not in self 
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
 2013-07-22 10:54:20 -04:00
Michael DeHaan
3f4c6affa3 Update CHANGELOG 2013-07-21 10:12:28 -04:00
Michael DeHaan
9ebde16e3a Merge branch 'iss_cron' of git://github.com/dirtyharrycallahan/ansible into dh_cron 2013-07-21 10:00:11 -04:00
Michael DeHaan
4281f773bb Merge pull request #3602 from bcoca/fine_tune_stat_exception 
narrowed down exception
 2013-07-20 09:45:31 -07:00
Michael DeHaan
517c318989 Merge pull request #3470 from langemeijer/devel 
Only append non_unique parameter if a uid is provided as well to user module
 2013-07-20 09:11:52 -07:00
Brian Coca
7132f7e792 narrowed down exception we ignore and fail if any other unexpected one 
crops up.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
 2013-07-20 11:51:52 -04:00
Florian Tham
865a663d05 fix fatal error when removing logical volumes 2013-07-19 10:59:11 +02:00
Antti Rasinen
f9e9286b2c Make zfs set_property accept values with embedded spaces 
Converting the argument list to a string with ' '.join causes
the shell interpreter to misparse spaces in property values.
Since the zfs command does not need shell anywhere, using
a list instead of a string works just as well with run_command. 

Fixes #3545.
 2013-07-16 14:01:14 +03:00
Antti Rasinen
8bfe9f6942 Fix zfs property parsing 
Current property parser breaks when values contain spaces. Since
zfs get -H returns tab separated lines,  it is better to explicitly
split on tabs than on whitespace.
 2013-07-16 13:49:19 +03:00
trbs
98b284159f fix missing json module for issue #3363 print JSON error as string instead 2013-07-15 16:50:31 +02:00
Brian Coca
dd1ffce0a0 now won't throw exception if we don't have permission to stat a mtab 
entry on linux (weird chromebook issue)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
 2013-07-14 22:59:24 -04:00
Michael DeHaan
b22428d87e Merge pull request #3426 from trbs/services_sleep_option 
sleep option for service module which adds a pauze between stopping and ...
 2013-07-12 08:18:22 -07:00
Michael DeHaan
7dfafc6ec4 Merge pull request #3496 from johanwiren/bsd-ipv6-facts 
Fix for populating default_ipv6 on BSD systems
 2013-07-11 05:55:53 -07:00
Michael DeHaan
38ac6c9abd Merge pull request #3497 from johanwiren/bsd-gateway 
Updated setup module to collect gateway fact for BSD systems
 2013-07-11 05:55:26 -07:00
Michael DeHaan
03605484f8 Merge pull request #3388 from bcoca/fixed_user_create_doc 
updated module docs to reflect 'correct' on_create vs on_creation
 2013-07-11 05:34:37 -07:00
Johan Wirén
3e765f7775 Updated GenericBsdIfconfigNetwork to collect gateway 2013-07-11 00:05:53 +02:00
Johan Wirén
a03125e0cf Fix for populating default_ipv6 on BSD systems 2013-07-10 22:54:33 +02:00
Joshua Lund
d75f73fffe Added a new with_file example to the authorized_key documentation 2013-07-10 14:09:03 -06:00
Patrick Callahan
f37becb94a Bug fixes and enhancements. 
Bugs:
(1) no longer allow empty jobs
(2) strip the header added by crontab package used in openSuSE and SuSE
(3) try not to leak temp files when things go wrong
(4) issue returning job names under certain conditions

Enhancements:
(1) Allow all special times not just reboot.
(2) Fail earlier by performing more input validation
(3) Add feature to allow removing cron file under /etc/cron.d

ToDo:
(1) Validate times (minute, hour, ...)
(2) Strip white space from fields such as name and job such that name=foo equals name=' foo'.
(3) More testing
 2013-07-09 03:21:40 +00:00
Brian Coca
e0e50b5936 fixed check mode 
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
 2013-07-08 15:41:39 -04:00
Casper Langemeijer
8727f0ce11 Only append non_unique parameter if a uid is provided as well 2013-07-08 11:46:38 +02:00
Aaron Brady
34617476d0 Make the CPU facts Hyperthreading aware 2013-07-03 16:25:35 +01:00
trbs
0d8da6eeb0 sleep option for service module which adds a pauze between stopping and starting a service using state=restarted. This helps for bad scripts that exist immediatly after signaling a process to stop. 2013-07-03 17:08:07 +02:00
Antti Rasinen
c2a4645349 Fix service enable on FreeBSD 
Some services have a knob (i.e. rc.conf setting) whose name
differs from that of the script. For example, lockd process
is controlled with a script called lockd, but the rc.conf
value is rpc_lockd_enable.

Fixes issue #3382.
 2013-07-03 14:52:23 +03:00
Brian Coca
b494d6d2ae updated module docs to reflect 'correct' on_create vs on_creation 
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
 2013-06-30 20:32:05 -04:00
Michael DeHaan
8d23df3576 Merge pull request #3315 from madduck/fix-service-updatercd-changed 
Let update-rc.d set changed flag properly
 2013-06-30 16:09:39 -07:00
Michael DeHaan
da0e718698 Styling: semicolon 2013-06-30 18:56:03 -04:00
Michael DeHaan
936ad65726 Styling: blank lines 2013-06-30 18:52:33 -04:00
Serge van Ginderachter
fc01f88228 add more support for different size formats 2013-06-24 22:37:31 +02:00
martin f. krafft
3b7b061b07 Expand usage of Python 2.6 if statement 
Syntax like "'foo' if bar else 'baz'" is not supported by all Python
versions targetted by Ansible. Hence we break it up.

Signed-off-by: martin f. krafft <madduck@madduck.net>
 2013-06-23 09:19:27 +02:00
martin f. krafft
22b30b9281 Let update-rc.d set changed flag properly 
When update-rc.d is used to enable/disable service, the changed flag was
always true (see #2189). This commit fixes that.

Signed-off-by: martin f. krafft <madduck@madduck.net>
 2013-06-22 20:04:37 +02:00
Michael DeHaan
997bf64f3f Fix up some module docs formatting errors. 2013-06-19 22:37:09 -04:00
Patrick Callahan
d76151d47b bug fix: modify get_device_facts to handle servers with multiple pci domains 
On machines with multiple pci domains get_device_facts would fail to
find a matching pci device causing setup to fail. Also on some platforms
there is additional information between the pci information and 'host'.
Modified get_device_facts to call lspci with the -D option and modified
the regex to account for the pci domain and to be more selective.
 2013-06-18 22:48:05 -04:00
Michael DeHaan
0596f474cf Merge pull request #3147 from toshywoshy/setup_mtab_without_bind 
changed get_mount_facts to ignore mount types 'none'
 2013-06-18 17:56:49 -07:00
Michael DeHaan
e4f3c4e286 Clarify module docs 2013-06-18 20:19:29 -04:00
Michael DeHaan
f53bc323a5 Merge pull request #3230 from sayap/openrc 
Add OpenRC support to the service module.
 2013-06-18 17:13:06 -07:00
Brian Coca
930e524df1 now mount/unmount are searched for instead of hardcoded 
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
 2013-06-17 17:01:35 -04:00
Yap Sok Ann
ec265a98e0 Add OpenRC support to the service module. 2013-06-17 11:29:48 +08:00
Michael DeHaan
709d2aaa0d Merge pull request #3120 from chrisgardner/solaris-os-facts 
Add Solaris O/S distribution facts
 2013-06-16 20:18:43 -07:00
Michael DeHaan
3840c608da Resolve docs conflict. 2013-06-16 22:48:11 -04:00
Michael DeHaan
4a7f0eeccc Fix merge conflict. 2013-06-16 22:47:29 -04:00
Michael DeHaan
1ea46e814d Merge pull request #3228 from skvidal/facts.d 
first cut and docs for facts.d mechanism for setup module
 2013-06-16 19:46:02 -07:00
Michael DeHaan
ae223ae10f Merge pull request #3181 from melodous/devel 
HP-UX virtualization facts
 2013-06-16 19:26:07 -07:00
trbs
e711145ba4 fixed x-bits in git 2013-06-16 22:22:16 -04:00
Michael DeHaan
152db00ed9 Merge remote branch 'origin' into devel 
Conflicts:
	library/web_infrastructure/django_manage
 2013-06-16 22:15:30 -04:00
Michael DeHaan
9017919f16 Merge pull request #3176 from jpmens/sol-epoch 
setup epoch time doesn't have tics on Python 2.6.4 (Solaris).
 2013-06-16 19:06:19 -07:00
Seth Vidal
38b055143a cut and docs for facts.d mechanism for setup module 2013-06-15 18:31:31 -04:00
Jan-Piet Mens
3404a0fc16 DOCS: standardize on EXAMPLES (a.k.a. Docs-JumboPatch JetLag Edition) 
Migrated all examples: in DOCUMENTATION=''' string to standalone EXAMPLES=''' string
  Added deprecation warning to moduledev.rst and remove deprecated example from it
  Fixed up a few typos and uppercased some acronyms.
  add consistency to how EXAMPLES are formatted
 2013-06-15 20:54:25 +02:00
Raul Melo
866903ebbc HP-UX virtualization facts 2013-06-12 18:59:20 +02:00
Jan-Piet Mens
8bce89a616 setup epoch time doesn't have tics on Python 2.6.4 (Solaris). 2013-06-11 09:13:32 +02:00
Jan-Piet Mens
846b48655b Protect None value in setup module 2013-06-11 07:08:55 +02:00
Michael DeHaan
30cab814e8 Use get_bin_path for blkid and add some aliases to the filesystem module. 2013-06-10 10:39:19 -04:00
Joshua Lund
dcad99ca6b Updates to the authorized_key documentation 
* Clarified the meaning of 'user'
* Changed 'sshdir' to 'path' in the example
  * 'sshdir' is used internally in the module, but the argument is 'path'
* Made the capitalization consistent in the descriptions
 2013-06-07 15:43:42 -06:00
Toshaan Bharvani
bf6bd10797 changed get_mount_facts to ignore mount types 'none' 2013-06-07 16:55:33 +02:00
Raul Melo
4c5d32f958 Facts for HP-UX 2013-06-05 14:01:18 +02:00
Chris Gardner
28cc0119a1 Use first line from /etc/release in "distribution_release" for consistency across Solaris and derivatives. 2013-06-03 22:33:01 +01:00
Michael DeHaan
e5b14d7170 Merge branch 'devel' of git://github.com/trbs/ansible into more_users 2013-06-03 11:50:17 -04:00
Michael DeHaan
9de5ecbdfc These options to bypass the check code seem to need to occur before said checks. 2013-06-01 18:32:02 -04:00
Chris Gardner
3bdf742d50 Add Solaris O/S facts "distribution" and "distribution_*" 2013-06-01 20:32:28 +01:00
Michael DeHaan
3012d269ff pep8 fixes 2013-06-01 12:29:03 -04:00
Michael DeHaan
fa2d027e33 Fix module labelled incorrectly. 2013-06-01 12:25:24 -04:00
Michael DeHaan
6503aea5fe Docs standardization 2013-06-01 12:20:45 -04:00
Michael DeHaan
64320fc662 Docs standardization 2013-06-01 12:16:24 -04:00
Michael DeHaan
7efe74d151 Warn when there is a space in the mount module opts parameter. 2013-06-01 11:33:17 -04:00
trbs
a31ba582b4 Add support for Open and NetBSD platforms for user and group modules, including a new login_class parameter for FreeBSD, OpenBSD and NetBSD. 2013-05-31 20:53:37 -04:00
Michael DeHaan
373e4ee7d4 Merge pull request #3083 from mvo5/feature/facts-add-statvfs 
add "size_{total,free}" to the "mount" facts
 2013-05-31 14:22:58 -07:00
Michael DeHaan
3765f4e400 Merge pull request #3076 from mmoya/userspace-arch-facts 
Provide userspace_{architecture,bits} facts
 2013-05-31 14:20:38 -07:00
Michael DeHaan
82f319d717 Merge branch 'solaris-network-facts' of git://github.com/chrisgardner/ansible into devel 2013-05-31 17:16:13 -04:00
Michael DeHaan
10c905e3e2 Remove debug statement in previous patch. 2013-05-31 17:13:54 -04:00
Michael DeHaan
dc1242d7eb Merge branch 'devel' of git://github.com/trbs/ansible into groups 2013-05-31 17:13:41 -04:00
Stephen Fromm
44cdd2dc0f cleanup to dmi fact discovery 
When invoking dmidecode, first use module.get_bin_path() and secondly
use module.run_command.
Remove sub function execute() from get_dmi_facts().
Simplify get_dmi_facts() by only using two mechanisms to determine dmi
facts:  first try /sys/devices/virtual/dmi and if not available, use
dmidecode executable.
 2013-05-31 17:10:34 -04:00
Michael DeHaan
f8f4eb8e9b Merge pull request #3068 from lorin/authkey-default 
authorized_key: Set manage_dir default value
 2013-05-31 13:16:44 -07:00
Michael DeHaan
291cd0b0c4 Merge pull request #3044 from chrisgardner/solaris_facts 
Solaris facts
 2013-05-31 13:15:58 -07:00
Michael DeHaan
e6620cdb9a Refine error message. 2013-05-31 15:23:24 -04:00
Michael DeHaan
da1738723a Merge branch 'rc.d-systemd' of git://github.com/glensc/ansible into sysd 2013-05-31 15:20:48 -04:00
Michael Vogt
fcfc9f5194 use statvfs.f_bavail to match the output of "df -B1" 2013-05-31 21:20:40 +02:00
Michael Vogt
fc3631b684 add "size_{total,free}" to the "mount" facts 2013-05-31 21:01:45 +02:00
Maykel Moya
e9a4741e36 Provide userspace_{architecture,bits} facts 
When running inside a chroot userspace architecture might not
match that of the actual host.

This patch provides userspace_bits as reported by python's
platform.architecture(). Also provides userspace_architecture fact
if host is an x86 machine.
 2013-05-31 12:24:43 +02:00
Chris Gardner
2d423ece52 Add Solaris network facts. IPv4 and IPv6 both working. 2013-05-31 00:57:23 +01:00
trbs
1f673450cd Fix for #3062 additional groups should only be added once. 
Also consolidated duplicate groups code into one get_groups_set() method.
Removed unused call to user_group_membership.
Removed sorting operations on set functions cause sets are inherently unordered.
Minor style improvements to match the rest of the code.

The new function will make the order of group names passed to the system command less determistic.
Which was already the case for modify_user_usermod() but not for other methods.
It will also strip out duplicate group names automatically which was not always the case previously.
 2013-05-30 19:18:18 -04:00
Lorin Hochstein
ec2fc7c983 authorized_key: Set manage_dir default value 
This commit fixes a bug where the authorized_key module causes
the ~user/.ssh directory to be owned by root instead of the user,
when the manage_dir argument is not specified.

If the manage_dir argument was not specified, the module behaved as if
manage_dir was set to false, even though it's supposed to default to
true.

This module assumed that an optional argument, with no default
specified, will not be present in the module.params dictionary.

What actually seems to happen is that the argument does appear in
the module.params dictionary with a value of None.

The upside is that this line was evaluating to None instead of
true:

    manage_dir = params.get("manage_dir", True)

I fixed the problem in this particular module by explicitly specifying
the default value for the manage_dir arugment. But if this bug
occurred because of a change in behavior in AnsibleModule, then other
modules may be broken as well.
 2013-05-30 16:16:14 -04:00
Michael DeHaan
94c35df69c Merge pull request #3064 from sfromm/issue2990 
Verify /proc/modules is readable (issue #2990)
 2013-05-30 11:12:30 -07:00
Stephen Fromm
c23ce83375 Verify /proc/modules is readable (issue #2990) 2013-05-30 10:25:48 -07:00
Stephen Fromm
44025024e9 Use get_bin_path to find mkfs command (issue #2983) 2013-05-30 10:25:35 -07:00
Chris Gardner
972545407c Fix typo. Solaris 9 should now correctly ignore 'brand' and use 'implementation'. 2013-05-30 08:51:03 +01:00
Chris Gardner
3cf243ec3e TODO: Separate IPv4 and IPv6 2013-05-30 08:39:11 +01:00
Jiří Kubíček
626cbc4e8b Add some FreeBSD facts 
added:
 * ansible_distribution
 * ansible_distribution_release 
 * ansible_distribution_version
 * ansible_os_family
 * ansible_pkg_mgr
 * ansible_ssh_host_key_ecdsa_public

Also adds ECDSA public key for all plaforms.
 2013-05-30 01:34:33 +02:00
Chris Gardner
d5bb7188f0 Add Solaris network facts. IPv6 details overwrite IPv4 per interface, needs further work. 2013-05-30 00:06:57 +01:00
Chris Gardner
f05540cb48 Add clock speed to processor description for SPARC CPU. 2013-05-29 21:00:21 +01:00
Chris Gardner
35ee8a16de Use 'implementation' if 'brand' not available (Solaris 9). Add CPU socket/core counting. 2013-05-29 18:54:43 +01:00
Michael DeHaan
da348cf079 Merge branch 'facter-fix' of git://github.com/flyapen/ansible into devel 2013-05-29 10:00:20 -04:00
Guillaume Lasmayous
fe484e5fd7 Implement NetBSD-specific subclass of Hardware in the setup module. 
Defines memory and CPU facts:
- memfree_mb
- memtotal_mb
- swapfree_mb
- swaptotal_mb
- processor (a list)
- processor_cores
- processor_count
- devices

As a matter of fact, on NetBSD, it is possible to get memory, swap and
processor facts exactly as on Linux. Tested on NetBSD-5, NetBSD-6 and
NetBSD-6.1 (without Linux emulation).
 2013-05-29 09:37:46 -04:00
Chris Gardner
7d61180034 Use kstat for Solaris CPU info 2013-05-28 22:44:06 +01:00
Chris Gardner
50c3cf302c Use kstat for Solaris CPU info 2013-05-28 22:36:49 +01:00
Kristof Keppens
f607ba09a4 change fix to lookup path with get_bin_path 2013-05-27 07:38:17 +02:00
Michael DeHaan
b0f62209c6 Merge pull request #2992 from SirScott/service_pattern 
Fixes #2991: Service module pattern argument ignored.
 2013-05-24 19:58:42 -07:00
Scott Sturdivant
ffb50dfb34 Fixes #2924: User creation always reports 'changed' 2013-05-23 13:43:23 -06:00
Scott Sturdivant
0110b616cb Fixes #2991: Service module pattern argument ignored. 2013-05-23 09:39:26 -06:00
Kristof Keppens
dc20d63919 fix for facter being installed in a different location 2013-05-23 11:21:01 +02:00
Elan Ruusamäe
52643e2a4d no need to init None to None 2013-05-19 00:20:10 +03:00
Michael DeHaan
3ad9866124 Merge pull request #2941 from bcoca/setup_bin 
no uses get_bin_path for 2nd use of ip tool
 2013-05-18 13:22:24 -07:00
Michael DeHaan
fc36695e7a Merge pull request #2940 from madema/patch-3 
-o and -r option don't exist on AIX
 2013-05-18 13:21:48 -07:00
Ton Kersten
438ab750c3 Fix issue 2906 2013-05-18 15:57:10 -04:00
Brian Coca
af745d0f9a no uses get_bin_path for 2nd use of ip tool (fixes reported issue with openwrt) 
module needs this added to many tool invokations, but his is a start
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
 2013-05-16 08:32:49 -04:00
madema
973eb69911 -o and -r option don't exist on AIX 2013-05-16 14:30:42 +02:00
Michael DeHaan
911213f8d7 Style fix. 2013-05-11 17:21:49 -04:00
Michael DeHaan
4ef987736a Merge pull request #2866 from madema/patch-2 
Fixed an error in the get_cpu_facts of the AIX class
 2013-05-11 11:10:17 -07:00
Michael DeHaan
05fb9876d3 Merge pull request #2865 from madema/patch-1 
Added AIX class in the service module to control AIX SRC processes.
 2013-05-11 11:09:41 -07:00