Commit graph

3771 commits

Author SHA1 Message Date
Michael DeHaan
14df804545 Merge pull request #6158 from risaacson/issues_5165
If you try to resize a lvol to the current size return a changed=False and don't fail.
2014-02-24 19:17:43 -05:00
Richard C Isaacson
eb2762bc5b If you try to resize a lvol to the current size return a changed=False and don't fail.
This addresses GH-5165 and adds the ability to check if a lvol exists.

The tests for this don't fit nicely into the current integration tests so they are below.

```
---

- name: remove any existing lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: remove any existing lv=two of vg=main
  lvol: lv=two vg=main state=absent

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  ignore_errors: true
  register: lvol_result0

- name: Assert that we will get a "No size given."
  assert:
    that:
      - "'No size given.' in lvol_result0.msg"

- name: create lv=one of vg=main sized 30g
  lvol: lv=one size=30g vg=main state=present
  register: lvol_result1

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result1.changed == True"

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  register: lvol_result2

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result2.changed == False"

- name: remove lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: create lv=two of vg=main sized 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result3

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result3.changed == True"

- name: reduce lv=two of vg=main to 15G
  lvol: lv=two size=15G vg=main state=present
  register: lvol_result4

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result4.changed == True"

- name: increase lv=two of vg=main to 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result5

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result5.changed == True"

- name: create lv=two of vg=main sized 30G when already exists at 30G
  lvol: lv=two size=30g vg=main state=present
  register: lvol_result6

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result6.changed == False"

- name: remove lv=two of vg=main
  lvol: lv=two vg=main state=absent
```
2014-02-24 16:56:08 -06:00
Kyle Kelley
70d8be5cc2 Fix expires 2014-02-24 15:54:55 -06:00
James Cammarata
4ab996621d Merge branch '5853-python-2.5-apt_repository-fix' of https://github.com/timurbatyrshin/ansible into timurbatyrshin-5853-python-2.5-apt_repository-fix 2014-02-24 15:20:29 -06:00
James Cammarata
6283754340 Fixing several bugs in assemble and updating tests
Bugfixes:
* the remote_src param was not being converted to a boolean correctly,
  resulting in it never being used by the module as the default behavior
  was remote_src=True (issue #5581)
* the remote_src param was not listed in the generic file params, leading
  to a failure when the above bug regarding remote_src was fixed
* the delimiter should always end with a newline to ensure that the file
  fragments do not run together on one line

Fixes #5581
2014-02-24 14:27:23 -06:00
James Cammarata
33d9a662ee Adding new tests for assemble role 2014-02-24 14:27:23 -06:00
Richard C Isaacson
106a0fc8fd Merge remote-tracking branch 'jeromew/ansible_script_creates' into issues_4986 2014-02-24 10:16:39 -06:00
Lukáš Lalinský
a71cabdb50 Don't require pycurl in apt_repository when it's not actually needed 2014-02-22 15:33:54 +01:00
Scott Patten
505fde72b0 In the route53 module, documenting that TXT and SPF requests
must be surrounded by quotes.

Otherwise you get a cryptic error message from Route 53.
2014-02-21 19:36:22 -08:00
Gianluca Borello
0ebbd6e754 Make sure droplet deletion works even when idempotency is achieved using 'name' and 'unique_name' rather than 'id' 2014-02-20 22:17:55 -08:00
James Cammarata
d80b9ac137 Adding the backup destination to the resut dictionary for lineinfile 2014-02-20 13:31:54 -05:00
Matt Jeffery
6cfa724472 Normalise the module name when comparing against the module names in /proc/modules. 2014-02-20 16:54:33 +00:00
Daniel Jaouen
9e8e510667 Update homebrew documentation. 2014-02-19 19:07:43 -05:00
Daniel Jaouen
1b2d63e33c Add back homebrew install_options parameter. 2014-02-19 19:07:43 -05:00
Daniel Jaouen
d49602a9f8 Update homebrew documentation. 2014-02-19 19:07:43 -05:00
Daniel Jaouen
9c2530545f Fix homebrew linked/unlinked output. 2014-02-19 19:07:42 -05:00
Daniel Jaouen
4d1a94eb18 Fix linked/unlinked states. 2014-02-19 19:07:42 -05:00
Daniel Jaouen
bea496b47c Update homebrew module. 2014-02-19 19:07:42 -05:00
Daniel Jaouen
fe362b79fd homebrew_cask: check err instead of out for "nothing to list". 2014-02-19 19:07:00 -05:00
Daniel Jaouen
fb526e1afb homebrew_cask: return False instead of True when nothing to list. 2014-02-19 19:07:00 -05:00
Daniel Jaouen
c9b8877cc6 Handle homebrew_cask "nothing to list" corner case. 2014-02-19 19:07:00 -05:00
Daniel Jaouen
fe5b96a432 Add module homebrew_cask 2014-02-19 19:07:00 -05:00
Michael DeHaan
54eeac3696 Merge pull request #6066 from jsmartin/riak_module_fix
Properly fetching the riak version
2014-02-19 16:51:04 -05:00
James Laska
306255d808 Resolves issue#6067 by allowing exact_count=0 2014-02-19 16:29:15 -05:00
muffl0n
68bef304c8 already call expanduser in action_plugin 2014-02-19 21:41:57 +01:00
James Martin
e312b0e5bf Properly fetching the riak version, and properly setting the python interpreter. 2014-02-19 12:12:02 -05:00
Jan-Piet Mens
0226e98dbf module update: mqtt notification now uses Paho as mosquitto.py being deprecated 2014-02-19 14:53:45 +01:00
Michael DeHaan
62f8ebe51e Merge pull request #6036 from mxxcon/patch-1
docs_pull_request: Add parameters highlighting
2014-02-18 13:58:44 -05:00
Michael DeHaan
a1c2712d8e Merge pull request #6045 from garaden/pypi_mirrors_gone
Set use_mirrors default to "no" for the pip module
2014-02-18 13:58:11 -05:00
Michael DeHaan
de6bc2f83b Merge pull request #6051 from illenseer/devel
Fix zfs create command for properties with spaces
2014-02-18 13:54:47 -05:00
Brian Coca
7873591ea0 removed with
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2014-02-18 12:33:48 -05:00
James Cammarata
5cb6b24546 Merge branch 'devel' of https://github.com/mtpereira/ansible into mtpereira-devel 2014-02-18 10:33:30 -06:00
Matthew Phipps
14fd8ec570 Remove use_mirrors from pip module
PyPI moved to a CDN on 2013-05-26, so mirrors are now largely
unnecessary and pip removed the functionality in 1.5. More importantly
(and why I wrote this request): on 2014-02-15 the mirror directory was
taken offline, so mirrors may not work anymore even for pip versions
that support them.
2014-02-18 10:49:22 -05:00
Matthew Phipps
fc4c685d26 pip module wasn't adding -e when using VCS 2014-02-18 10:39:51 -05:00
jeromew
2fcce7e225 Add creates= and removes= to the script: action 2014-02-18 12:52:09 +00:00
Nils Pascal Illenseer
7f40790fc1 Fix zfs create command for properties with spaces
If a property value contains one or more spaces, the zfs command will fail.
With value quoted this behavior is fixed.
2014-02-18 11:30:17 +01:00
James Cammarata
a6d92bf4b7 Merge branch 'devel' of https://github.com/calebbrown/ansible into calebbrown-devel 2014-02-17 15:38:56 -06:00
James Cammarata
f1ba67e547 Merge branch 'fix-5679' of https://github.com/jirutka/ansible into jirutka-fix-5679 2014-02-17 14:54:29 -06:00
Richard C Isaacson
cb8c462880 Merge remote-tracking branch 'berendt/fixing_permissions' into pull_4703 2014-02-17 11:46:23 -06:00
James Cammarata
c85b7d868b Merge branch 'fix-postgres_user_to_understand_pg_namespaces' of https://github.com/alanfairless/ansible into alanfairless-fix-postgres_user_to_understand_pg_namespaces 2014-02-17 10:04:12 -06:00
James Cammarata
a570280b81 Merge branch 'postgres_alter_role' of https://github.com/jinnko/ansible into jinnko-postgres_alter_role
Conflicts:
	library/database/postgresql_user
2014-02-17 09:57:31 -06:00
mxxcon
544c08a211 docs_pull_request: Add parameters highlighting
Added highlighting to parameter references in docs so that they standout a bit better.
2014-02-15 23:26:21 -05:00
Michael DeHaan
77ac23cc26 Document ansible_managed changing the template. 2014-02-15 14:13:42 -05:00
Michael DeHaan
b1e442639f Some minor docs corrections. 2014-02-15 14:05:42 -05:00
James Cammarata
c1e9b76089 Merge branch 'mohangk-fix_rds_modify_security_group' into devel 2014-02-15 09:34:46 -06:00
James Cammarata
ec5295a515 Merge branch 'fix_rds_modify_security_group' of https://github.com/mohangk/ansible into mohangk-fix_rds_modify_security_group 2014-02-14 14:43:42 -06:00
Bruce Pennypacker
ff41cee78b Added wait_timeout parameter 2014-02-14 20:16:58 +00:00
Richard Isaacson
f70dcedaed Merge pull request #6015 from angstwad/docfix
Spelling correction.
2014-02-14 11:04:44 -06:00
Richard Isaacson
da1cef71f8 Merge pull request #5645 from resmo/fix/apt_pkg_version
apt: fixed pkg=<name>=<version> fails if package is not yet installed.

Tested and it fixes the problem on more recent versions of apt.
2014-02-14 11:01:35 -06:00
Paul Durivage
ae43f8d874 Spelling correction 2014-02-14 10:47:27 -06:00