Commit graph

200 commits

Author SHA1 Message Date
Brian Coca
35703caf6f Merge pull request #1101 from willthames/postgresql_reduce_alter_role
Update postgresql users only when necessary
2015-05-05 08:49:45 -04:00
Pascal Borreli
f29a6ec54d Fixed typos 2015-05-04 12:54:03 +01:00
Toshio Kuratomi
58c8696fc5 Allow playbook specified login_user and login_password to override config file settings 2015-04-30 12:49:32 -07:00
Julia Kreger
35bcd6a965 Set default for mysql_user config_file
The default value set by the module was a value of None for the
config_file parameter, which propogates into the connect method
call overriding the stated default in the method.

Instead, the default should be set with-in the parameter
specification so the file check is not requested to check None.
2015-04-30 11:40:04 -04:00
Brian Coca
8023c60863 minor doc fixes 2015-04-22 15:58:56 -04:00
Sven Schliesing
c53ca2f776 use default value for parameter config_file in connect() 2015-04-22 20:32:39 +02:00
muffl0n
616ac905ff Use MySQLdbs read_default_file 2015-04-22 20:29:21 +02:00
Will Thames
c956c65731 Usage is not a valid database or table privilege
Remove `USAGE` from the `VALID_PRIVS` dict for both database and
table because it is not a valid privilege for either (and
breaks the implementation of `has_table_privilege` and
`has_database_privilege`

See http://www.postgresql.org/docs/9.0/static/sql-grant.html
2015-04-08 13:00:50 +10:00
Will Thames
7d66da35a7 Perform privilege grants/revokes only when required
Use `has_table_privileges` and `has_database_privileges`
to test whether a user already has a privilege before
granting it, or whether a user doesn't have  a privilege
before revoking it.
2015-04-08 12:48:45 +10:00
Will Thames
b4515c8909 Update postgresql users only when necessary
For read-only databases, users should not change when no changes
are required.

Don't issue ALTER ROLE when role attribute flags, users password
or expiry time is not changing.

In certain cases (hashed passwords in the DB, but the password
argument is not hashed) passlib.hash is required to avoid
running ALTER ROLE.
2015-04-08 11:17:11 +10:00
Brian Coca
6e373ace86 corrected version added 2015-03-31 15:31:54 -04:00
Brian Coca
c4a22478c4 Merge pull request #830 from BlackMesh/devel
mysql_user #829: add update_password to mysql_user
2015-03-31 15:28:31 -04:00
tedder
bffd137edd code review fixes per #957 2015-03-30 15:51:54 -07:00
tedder
472331a53b skip password changes so pg_authid isn't needed
Some places ([AWS RDS](https://forums.aws.amazon.com/thread.jspa?threadID=151248)) don't have, or don't allow, access to the `pg_authid` table. The only reason that is necessary is to check for a password change.

This flag is a workaround so passwords can only be set at creation time. It isn't as elegant as changing the password down the line, but it fixes the longstanding issue #297 that prevented this from being useful on AWS RDS.
2015-03-30 13:35:54 -07:00
Toshio Kuratomi
b0bc6f1379 Merge pull request #888 from ansible/mysql-port
Fix for int port assignment in a playbook failing
2015-03-04 18:57:32 -08:00
Toshio Kuratomi
ec6304d5a0 Merge pull request #824 from Jmainguy/mysql_db_616
Now correctly gzip/bzips file back up in case of import failure
2015-03-04 06:45:16 -08:00
Jonathan Mainguy
ee8039ef09 Now correctly gzip/bzips file back up in case of import failure
Removed gunzip and bunzip2 dependency
2015-03-04 09:07:24 -05:00
Toshio Kuratomi
a1135f803d Fix for int port assignment in a playbook failing
Ports are integer values but the old code was assuming they were
strings.  When login_port is put into playbook complex_args as an
integer the code would fail.  This update should make the argument
validating make sure we have an integer and then we can send that value
directly to the relevant APIs.

Fixes #818
2015-03-03 14:23:07 -08:00
Toshio Kuratomi
addca40604 Fix documentation to have correct param name 2015-02-25 06:49:24 -08:00
Solomon Gifford
35434f9672 mysql_user #829: add update_password to mysql_user 2015-02-20 12:30:27 -05:00
David Hummel
1d92dd31a6 Fix issue #793: mysql_db: for state={absent,present} connections to database mysql fail for users other than root 2015-02-14 17:16:35 -05:00
Brian Coca
02af66d232 Merge pull request #559 from mjschultz/postgres-db-fix
Build the db connection on `"postgres"` instead of `"template1"`
2015-02-11 17:38:34 -05:00
Brian Coca
1394920cd3 Merge pull request #44 from Jmainguy/mysql_db_6860
adds error message if socket does not exist
2015-01-30 14:04:48 -05:00
Johannes Steger
34aa98a99c Fix function identifier quoting 2015-01-26 17:47:03 +01:00
Toshio Kuratomi
fbb9dcc69a Also catch mysql errors so we can give the error message back through json rather than tracebacking 2015-01-12 14:37:44 -08:00
Bruce Pennypacker
272bb1fa63 requested changes 2015-01-08 21:41:15 +00:00
Bruce Pennypacker
a07873d6a3 Added support for 'REQUIRE SSL' grant option 2015-01-08 16:26:22 +00:00
Michael J. Schultz
b894bc2b77 Build the db connection on "postgres" instead of "template1"
According to the postgresql docs[1], you should not have a connection with
`"template1"` when copying multiple databases.

[1]: http://www.postgresql.org/docs/9.1/static/manage-ag-templatedbs.html
2014-12-23 14:16:29 -06:00
Toshio Kuratomi
b0c94cd6f6 Merge pull request #281 from kustodian/postgresql_db_fix_for_python_24_checkmode
Fixed postgresql_db failing on Python 2.4 with --check
2014-12-14 13:43:44 -08:00
kustodian
07b98c45df Fixed postgresql_db failing on Python 2.4 with --check
This reverts commit 81cbdb6c8c and adds ignoring of the SystemExit exception because of Python 2.4.
2014-12-13 17:24:10 +01:00
Petros Moisiadis
bd7c6dbd3a mysql_user: Added missing privileges
Added missing privileges 'CREATE TABLESPACE' and 'PROXY' (see: http://dev.mysql.com/doc/refman/5.5/en/privileges-provided.html).
2014-12-10 18:53:55 +02:00
Andrew Shults
8396c063a3 Strip white space to support multiline permissions in YAML 2014-12-09 17:14:16 -05:00
Toshio Kuratomi
e8edee4166 Fix typo 2014-12-04 13:35:07 -08:00
Toshio Kuratomi
b766390ae2 Add USAGE as a valid privilege 2014-12-03 14:43:20 -08:00
Toshio Kuratomi
5af4463823 Gixes to doc formatting 2014-12-03 08:17:15 -08:00
Toshio Kuratomi
dda6d89060 Fix typo so docs will build 2014-12-03 07:09:10 -08:00
Toshio Kuratomi
3a80b734e6 Escape % in db+table names before adding to a format string being passed into db.execute()
Fixes #416
2014-12-01 10:40:53 -08:00
Dan
084ccf5a64 Adds a login_unix_socket option to the postgresql_privs module. 2014-12-01 12:27:12 -05:00
Dan
3a3ff1f0e4 Adds a unix_socket/login_unix_socket option to the postgresql_user module. 2014-12-01 12:23:33 -05:00
Dan
bf36697a55 Adds a login_unix_socket option to the postgresql_db module. 2014-12-01 12:23:33 -05:00
Toshio Kuratomi
1cab307649 Fix module traceback instead of returning an error 2014-12-01 07:15:27 -08:00
Toshio Kuratomi
2a794fa776 Fix for single role_attr 2014-11-26 14:43:56 -08:00
Toshio Kuratomi
7dd2859f9b Add a bare grant to the list of allowed privileges 2014-11-26 08:26:53 -08:00
Devin Christensen
06f1c1a97e Fix user_alter in postgresql_user 2014-11-25 12:04:47 -07:00
Devin Christensen
c77ab67274 Fix user_add in postgresql_user 2014-11-25 11:46:41 -07:00
Devin Christensen
4a3d7473fd Fix syntax error 2014-11-25 10:44:04 -07:00
Toshio Kuratomi
10ebcccedb Escape mysql identifiers 2014-11-25 01:46:09 -08:00
Toshio Kuratomi
06ac459fc5 Correct new function name 2014-11-25 01:42:33 -08:00
Toshio Kuratomi
c84ae54294 Normalize privs and flags to uppercase so comparisons against allowed names will work 2014-11-25 00:44:18 -08:00
Toshio Kuratomi
fbc4ed7a88 Make sure we quote or confirm good all user provided identifiers 2014-11-24 22:56:51 -08:00