Commit graph

48309 commits

Author SHA1 Message Date
Xu Yuandong
2ccdf29b5b Doc notes 4 (#64927)
* addd

* all  update

* add/update notes.

* revert and exclubde new in 2.10
2019-11-15 22:57:04 -05:00
Mossroy
cf4882e0c0 Fix argument name in example of documentation (#64891)
##### SUMMARY
The second example of the documentation uses an argument "hostname" that does not exist in this module.
It should be replaced by argument "name"


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-11-16 08:55:13 +05:30
sky-joker
8301ad47c3 VMware: new module vmware_host_auto_start (#64605)
Fixes: #63905

* Add return parameters to return after module execution https://github.com/ansible/ansible/pull/64605#discussion_r344430717
* Add moid and use_instance_uuid parameters https://github.com/ansible/ansible/pull/64605#discussion_r344431003
* Add reset playbook for test case
* Delete HAS_PYVMOMI variable https://github.com/ansible/ansible/pull/64605#discussion_r344430877
* Fix because the default value of stop_action was wrong
* Fix multiple sanity test error for document related
* Fix remove unnecessary line break
2019-11-16 08:46:38 +05:30
Xu Yuandong
9a8d0cf006 Revert "Doc notes 5 (#64350)" (#64921)
This reverts commit 1d40d429a0.
2019-11-15 21:21:06 -05:00
Xu Yuandong
6dff4f43d3 Revert "Doc notes 4 (#64349)" (#64922)
This reverts commit 703f7a149a.
2019-11-15 21:08:16 -05:00
Sam Doran
4291f09a68
Fix lookup_passwordstore integration test for CentOS 8 (#64869)
pass is no longer packaged in EPEL
https://lists.zx2c4.com/pipermail/password-store/2019-July/003689.html
2019-11-15 17:37:43 -05:00
Sam Doran
f2e605c856
Fix iso_extract tests for CentOS 8 (#64861)
- use setup_epel role rather than task which contains correct URL now since it has changed for EL8
- add conditional to setup_epel to prevent attempted installation on non-RHEL distros
2019-11-15 17:37:13 -05:00
Sam Doran
dd8a3ebb72
Fix paramiko_ssh test (#64857) 2019-11-15 17:08:26 -05:00
Sam Doran
5d2a3ecbc4
Fix setup_rpm integration tests for CentOS 8 (#64862) 2019-11-15 17:07:48 -05:00
Sam Doran
5e3b6c84c7
Fix group integration test for CentOS 8 (#64858) 2019-11-15 17:07:02 -05:00
Sam Doran
3902c6dd9d
Fix MariaDB integration tests for CentOS 8 (#64859)
* Fix setup_mariadb for CentOS 8
Switch to using systemd for multiple instances on CentOS 7 and 8
2019-11-15 17:06:27 -05:00
Sam Doran
05a7ce798d
Fix yum_repository tests for CentOS 8 (#64863)
Refactor tests to run the same tasks with CentOS and Fedora using different variables.
2019-11-15 17:05:23 -05:00
Sam Doran
477fa63f68
Fix setup_mysql_db for CentOS 8 (#64864) 2019-11-15 17:04:35 -05:00
Sam Doran
16f070f318
Fix mariadb_replication tests for CentOS 8 (#64865) 2019-11-15 17:03:59 -05:00
Sam Doran
082b1b6cca
Fix filesystem integration test for CentOS 8 (#64866) 2019-11-15 17:03:27 -05:00
Sam Doran
41f301fe1b
Fix setup_mysql8 tests for CentOS 8 (#64868)
# Conflicts:
#	test/integration/targets/firewalld/tasks/main.yml
2019-11-15 17:02:20 -05:00
Sam Doran
73a2ee7318
Fix mysql_replication integration test for CentOS 8 (#64870) 2019-11-15 17:01:23 -05:00
Sam Doran
f8c741894a
Fix setup_postgresql integration test for CestOS 8 (#64871) 2019-11-15 17:00:27 -05:00
Sam Doran
79a38c8a3a
Fix firewalld integration tests for CentOS 8 (#64873) 2019-11-15 16:59:39 -05:00
Sandra McCann
a01376a493 update configuring ansible-galaxy client (#64796)
* update configuring ansible-galaxy client, deduplicate, clarify tokens, AH procedures, etc.
2019-11-15 09:49:51 -06:00
Gonéri Le Bouder
64595a7d6a module_defaults: add tree missing vmware modules (#64877)
The following modules a new, and were not yet in `module_defaults.yml`:

- vmware_guest_register_operation
- vmware_guest_serial_port
- vmware_guest_tools_info
2019-11-15 17:10:11 +05:30
Andrey Klychkov
f45fdc7c9b postgresql_subscription: fix the module can return incorect changed value when owner is passed (#64885) 2019-11-15 17:04:58 +05:30
anupamaloke
96fc1a1b80 Add support for multiple manager attributes configuration (#60201)
* Add support for multiple manager attributes configuration

* Updated version_added to 2.10

* Added support for modifying LC and system attributes

* Added support for LC and system attributes

* Pylint fixes

* Add support for multiple manager attributes

* Add support for multiple manager attributes

* Add support for multiple manager attributes
2019-11-15 10:53:36 +00:00
Jesus Alvarez
069c7959da Add timeout to jenkins_script csrf requests (#62850) 2019-11-15 10:49:01 +00:00
Satyajit Bulage
864a597a3e Improved message for unarchive. (#64594)
Signed-off-by: Satyajit Bulage <sbulage@redhat.com>
2019-11-15 12:52:51 +05:30
Andrey Klychkov
01e4e1bb42 postgres.py: add query_params (#64661)
* postgres.py: add query_params

* postgres.py: add query_params, add changelog
2019-11-15 07:07:56 +00:00
Micah Hunsberger
8ff6e4c68e win_iis_webapplication: add authentication parameters (#56033)
* add connect_as, username, password parameters
add tests

* fixed reference to undefined variable.
added version added to new options.

* add changelog fragment

* fix line endings

* use ansible facts to determine os version
remove unused iis version check
test checksum of iis configuration after backup

* correct assertion

* added more cleanup tasks.

* version added is now 2.10

* skip server 2008 r2 for now

* run tests on server 2012 and higher
2019-11-15 16:04:19 +10:00
Wilmar den Ouden
40071e5db3 win_disk_facts: Adds Win32_DiskDrive object to facts (#51595)
* Adds win32_disk_drive object to win_disk_facts

* Names class parameter for Get-CimInstance as requested in the devdocs

* Maps whole class and adds docs

* Improve matching of disks when UniqueID is different format

* Improve logic for PNPDeviceID mapping

* Adds test for win32_disk_drive
2019-11-15 15:45:18 +10:00
Jordan Borean
762fcf78b9
win_pester - Align dir scanning with Pester's defaults (#64880)
* win_pester - Align dir scanning with Pester's defaults

Co-authored-by: Coby Caldwell <cobycaldwell@gmail.com>

* Fix sanity issues
2019-11-15 13:53:30 +10:00
Dag Wieers
521d6465f6 win_chocolatey: Fix error when choco.exe not found (#53115)
* win_chocolatey: Fix error when choco.exe not found

* Slight tweak to check and added changelog fragment

* Removed ignore rule that's no longer needed
2019-11-15 12:46:36 +10:00
Daniel-Sanchez-Fabregas
cd39e6ec6e win_domain_user: add retry logic for null user principal group (#54334)
* win_domain_user: add retry logic for null user principal group

* win_domain_user.ps1: Fix "user without group" case use

* Added changelog fragment

* Fix up missing dollar sign
2019-11-15 11:54:37 +10:00
Gianluca
bf8fe221bf Modified setup.ps1 in order to show Windows Installation type (#41002)
* Modified setup.ps1 in order to show Windows Installation type

* Fix after pull request comment

* Added changelog fragment
2019-11-15 11:19:01 +10:00
Matt Clay
4f51b7d323 Remove ansible-test --tox delegation option.
Use the --venv option instead.

This option was only available when running from source to test the ansible/ansible repository.

This will have no effect on testing collections or running from an installed version of Ansible.

Also update docs to reference the --venv option instead of the --tox option.
2019-11-14 17:18:00 -08:00
Gonéri Le Bouder
0aa59ce9ab vmware/test: use better name for datastores
In the VMware tests, we call the datastores `ds1` and `ds2`. The first
one is read-only, the second is read-write and can be used to deploy
VMs. The naming convention was not clear enough and source of a lot
confusion and mistake.

We now have two better names:

- ro_datastore, which is ... read-only
- rw_datastore, the one that we can use to deploy new VM.
2019-11-14 16:55:05 -05:00
SriVignessh Pss
161e0be89b Fix access variable name programmatically faq docs (#64041)
* Add an example of replacing dashes with underscores in interface names for IPv4
2019-11-14 15:38:40 -06:00
Farid Da Encarnacao
a6f45713fc Add default value to 0 for disk in nova_flavor module (#64749)
* Add default value to 0 for disk in nova_flavor module

* Apply suggestions from code review

Add type int for disk size

Co-Authored-By: John R Barker <john@johnrbarker.com>
2019-11-14 20:50:16 +00:00
Mark Chappell
551b17b8a2 ec2_vpc_net_info: integration tests (#62649)
* ec2_vpc_net: (integration tests) migrate to using module_defaults

* ec2_vpc_net: (integration tests) use a private subnet for the tests

* ec2_vpc_net_info: Add integration tests

* ec2_vpc_net_info: add cidr_block_association_set to documentation

* Update AWS hacking test policy to allow VPC CIDR disassociation

* Update test/integration/targets/ec2_vpc_net/tasks/main.yml

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

* Store vpc2 ID to make it clearer which VPC we're changing

* Be more consistent with our quoting

* Explicitly test that the VPC IDs haven't changed
2019-11-14 13:36:42 -07:00
johnbui423
db3994cb03 Default to python3 on Debian 10 (#63097) 2019-11-14 13:52:13 -06:00
Anusha Hegde
e9feea2270 VMware: new module vmware_guest_serial_port (#63126)
The ask was to add an option in the vmware_guest itself. Upon inspection, a serial port can
be created in multiple ways and so can be a module in itself. Therefore, created a new module
called vmware_serial_port.

Fixes: #54956
2019-11-14 14:16:30 -05:00
Prasad Katti
9b0cdad4d4 Add a random component to state machine name in aws_step_functions_st… (#64476)
* Add a random component to state machine name in aws_step_functions_state_machine testsuite

* Pick a random number from a bigger set to avoid conflicts between parallel runs

Co-Authored-By: Matt Clay <matt@mystile.com>
2019-11-14 08:37:55 -08:00
Julien Palard
81b334bcaf Close subprocess stdout and stderr in the ssh connection plugin
Eliminate `ResourceWarning: unclosed file` by closing all
file handles of each subprocess used by the SSH connection
plugin to execute commands.

This change prevents Ansible from accumulating "forgotten"
open file handles.

PR #64785 by Julien Palard
Fixes #64768
2019-11-14 17:35:30 +01:00
Sebastian Neira
67fd17bee4 Update RDS snapshot info to use DBClusterIdentifier (#64253) 2019-11-14 09:02:42 -07:00
Jason Pepper
d6a51807cd Fix kinesis_stream wait loop pause. (#64283) 2019-11-14 08:53:01 -07:00
Thomas Reppert
fbdd295cef Adjust conditional for disabling alert email (#63951)
* Adjust conditional for disabling alert email

Conditional was improperly disabling existing alert email when it was found enabled.  The expectation is that it should only disable if module.param['enabled'] was set to false.

* Adjusted disable logic

Added back in the logic of only disabling the alert email if it is module.params['enabled'] is false AND current value of enabled is true on the array
2019-11-14 10:44:55 -05:00
Martin Krizek
5c0b2c151c
Fix ansible_failed_{task,result} undefined in rescue (#64831)
This is a fix for a regression introduced by Perfy. Since then we mainly
operate on host.name instead of the Host object. In a call to
set_nonpersistent_facts where we set ansible_failed_task and
ansible_failed_result variables we were still passing the object which
led to those vars being undefined.

Fixes #64789
2019-11-14 15:50:54 +01:00
Robert de Bock
f17a55a181 Add advice how to prevent jinja2 warning (#60594)
* Add advice how to prevent jinja2 warning

##### SUMMARY
This addition helps users to demonstrate how to prevent `[WARNING]: when statements should not include jinja2 templating delimiters`.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr

* Update playbooks_tests.rst

* Update playbooks_tests.rst

Refer to the advised FAQ about when to use `{{ }}`.
2019-11-14 14:36:05 +00:00
Abhijeet Kasurde
eac7fa1860
gitlab_user: Remove optional parameters while state is absent (#64832)
While deleting gitlab user, several parameters such as email, name,
password are not required. This fix removes this requirement from the
module.

Fixes: #61921

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-14 17:21:14 +05:30
Jonathon Sheffield
9ee601288c Fix postgres_user not commiting changes when groups is set (#64807)
resolves #64806
2019-11-14 15:09:45 +05:30
Andre Lehmann
a75a79b84c hostname - Add Manjaro Linux distribution (#64810)
* Add Manjaro Linux distribution
2019-11-14 14:31:21 +05:30
Jiri Tyr
e0373a73a8 VMware: Simplifying get_vm() in module_utils.vmware (#62217) 2019-11-14 10:40:37 +05:30