Commit graph

863 commits

Author SHA1 Message Date
Toshio Kuratomi
8893c2d2d0 Fix typo: Need lvreduce instead of lvextend.
Fixes #513
2015-05-20 19:23:45 -07:00
Toshio Kuratomi
88eff11c04 Many more doc fixes 2015-05-15 12:12:26 -07:00
Otto Kekäläinen
c034d08093 gluster_volume: Finalize brick->bricks transition by previous author 2015-05-15 17:55:16 +03:00
Otto Kekäläinen
8009bdfe77 gluster_volume: Improved parsing of cluster parameter list 2015-05-15 17:54:25 +03:00
Otto Kekäläinen
77479882a4 gluster_volume: Parameter expects comma separated list of hosts, passing {{play_hosts}} will fail as Python does not parse it into a list 2015-05-15 17:24:18 +03:00
Otto Kekäläinen
73f4e2dd06 gluster_volume: Clarify error message to tell what actualy failed 2015-05-15 16:49:39 +03:00
Otto Kekäläinen
6539add9d1 gluster_volume: Typofix in docs (equals, not colon) 2015-05-15 16:47:23 +03:00
Brian Coca
08445418aa more string corrections 2015-05-14 10:45:32 -04:00
Brian Coca
edf519a0c2 moar quotes 2015-05-14 09:37:00 -04:00
Greg DeKoenigsberg
b232f143e4 Adding author's github id 2015-05-14 01:19:04 -04:00
Greg DeKoenigsberg
1c662556e9 Adding author's github id 2015-05-14 01:16:42 -04:00
Greg DeKoenigsberg
2804ffd925 Adding author's github id 2015-05-14 01:12:33 -04:00
Greg DeKoenigsberg
5e327de353 Adding author's github id 2015-05-14 01:12:07 -04:00
Greg DeKoenigsberg
2002a235db Adding author's github id 2015-05-14 01:10:43 -04:00
Greg DeKoenigsberg
88bebd353d Adding author's github id 2015-05-14 01:09:41 -04:00
Greg DeKoenigsberg
2fdebb296a Adding author's github id 2015-05-14 01:08:41 -04:00
Greg DeKoenigsberg
c90c3e77da Adding author's github id 2015-05-14 01:06:57 -04:00
Greg DeKoenigsberg
45478760e3 Adding author's github id 2015-05-14 01:06:16 -04:00
Greg DeKoenigsberg
3d4477ab07 Adding author's github id 2015-05-14 01:04:45 -04:00
Greg DeKoenigsberg
7f8e55a66a Adding author's github id 2015-05-14 01:03:29 -04:00
Greg DeKoenigsberg
f59b405e7a Adding author's github id 2015-05-14 01:02:50 -04:00
Greg DeKoenigsberg
cff5b5b5cc Adding author's github id 2015-05-14 01:00:38 -04:00
Greg DeKoenigsberg
e1385a9e8b Adding author's github id 2015-05-14 00:59:06 -04:00
Greg DeKoenigsberg
b08c630fe9 Adding author's github id 2015-05-14 00:58:26 -04:00
Greg DeKoenigsberg
c10896c401 Adding author's github id 2015-05-14 00:50:42 -04:00
Greg DeKoenigsberg
d1999aa7cf Adding author's github id 2015-05-14 00:49:57 -04:00
Greg DeKoenigsberg
57ad76208d Adding author's github id 2015-05-14 00:48:29 -04:00
Greg DeKoenigsberg
f65bb1c55e Adding author's github id 2015-05-14 00:47:26 -04:00
Greg DeKoenigsberg
7b9d8baf76 Adding author's github id 2015-05-14 00:46:37 -04:00
Greg DeKoenigsberg
4399d9feee Adding author's github id 2015-05-14 00:45:08 -04:00
Greg DeKoenigsberg
34d93e0488 Adding author's github id 2015-05-14 00:43:58 -04:00
Matt Martz
a258606694 Use try/finally with file opening to close the file 2015-05-11 10:29:28 -05:00
Matt Martz
e568032bc3 Fix up modules that have python24 syntax error 2015-05-11 09:51:48 -05:00
fdupoux
69c0a6360b Suppress prompts from lvcreate using --yes when LVM supports this option 2015-05-09 14:06:58 +01:00
Timothy Vandenbrande
a90f5f6ba9 Merge remote-tracking branch 'upstream/devel' into devel 2015-05-07 15:51:19 +02:00
Sterling Windmill
7c675705f3 Allow for specifying name instead of host as per the documentation at http://docs.ansible.com/known_hosts_module.html 2015-05-04 15:57:40 -04:00
Robert Osowiecki
4ffb5f065b Using get_bin_path to find rmmod and modprobe 2015-04-30 17:50:07 +02:00
Doug Luce
1fa73cd0a3 Add the cronvar module.
This manages environment variables in Vixie crontabs.  It includes
addition/removal/replacement of variables and ordering via the
insertbefore/insertafter parameters.
2015-04-21 18:02:33 +00:00
Brian Coca
579cc55cb7 Merge pull request #408 from bcoca/fix_known_hosts_24
fixed 2.4 compatibility
2015-04-20 13:21:52 -04:00
Brian Coca
3c9131b09c added aliases docs 2015-04-20 10:20:50 -04:00
Brian Coca
048a3b8062 Merge pull request #406 from rnowling/gluster-multiple-bricks
Issue #403: Add support for multiple bricks to gluster_volume
2015-04-20 10:16:52 -04:00
RJ Nowling
6d66beb793 Change 'brick' to 'bricks' and add 'brick' as an alias. Add example with multiple bricks. 2015-04-20 09:13:52 -05:00
Jonathan Mainguy
ae34395f01 Fixes bug where state=absent did not work 2015-04-19 15:29:30 -04:00
Brian Coca
2535a49284 fixed 2.4 compatibility 2015-04-18 21:50:06 -04:00
RJ Nowling
20d998a6d6 Improve documentation for gluster_volume brick parameter 2015-04-17 14:59:10 -05:00
RJ Nowling
c7853c9f08 Issue #403: Add support for multiple bricks to gluster_volume 2015-04-17 14:48:53 -05:00
Benjamin Albrecht
658e7300ad Fix possible values for zfs sync property 2015-04-14 21:23:20 +02:00
RJ Nowling
582da5b911 Make 'module' global. Small whitespace formatting fixes. Closes Issue #397. 2015-04-14 12:02:32 -05:00
mcameron
1f5e243acf Revert "system/lvol: Suppress prompts from lvcreate"
This reverts commit f8d04bec1b.
2015-04-08 17:37:53 +01:00
Brian Coca
dc0cfbd1b4 Merge pull request #369 from bcoca/known_hosts_oserrors
now also captrure OSErrors on temp file creation
2015-04-02 15:56:26 -04:00
Brian Coca
89284bcce0 now also captrure OSErrors on temp file
fixes #360
2015-04-01 20:44:28 -04:00
Brian Coca
21fce8ac73 Merge pull request #217 from wimnat/issue-197
Convert symlinks specified in pvs to actual path
2015-03-31 23:59:16 -04:00
Brian Coca
d4d5d7cf73 Merge pull request #190 from yuriks/patch-1
crypttab: Fix parameter checking with state=absent
2015-03-31 23:58:52 -04:00
Brian Coca
f901fd0160 glusterbin needs to be global 2015-03-31 14:29:38 -04:00
Matthew Vernon
30cf73e83a Fix for issue #353 (handle change in ssh-keygen behaviour)
Prior to openssh 6.4, ssh-keygen -F returned 0 (and no output) when no
host was found. After then, it instead returned 1 and no output. This
revised code behaves correctly with either behaviour. There is
currently no other code path that results in exit(1) and no output.
2015-03-31 17:20:48 +01:00
Brian Coca
7794042cf6 fixed missing parens 2015-03-30 22:30:58 -04:00
Brian Coca
4c0b1b42bc minor fixes to gluster:
- removed functions from main scope
- renamed rebalance function to disambiguate from variable
- updated docs with defaults
- added exception handling to command execution
2015-03-30 20:15:40 -04:00
Tyler Kellen
c08ce5b30d correct version_added for known_hosts
It was added in 1.9, not 1.6.
2015-03-28 13:20:30 -06:00
Toshio Kuratomi
2b192c7f8e remove non-ascii quotes from message string
Fixes https://github.com/ansible/ansible/pull/8564
2015-03-26 11:42:56 -07:00
Brian Coca
3f247e2d78 Merge pull request #313 from DavidWittman/12-alternatives-fixes
Fix multiple issues with alternatives module
2015-03-25 23:46:32 -04:00
Brian Coca
09fc1eefe5 Merge pull request #114 from rndmh3ro/patch-1
Added documentation and example for port ranges.
2015-03-25 23:41:05 -04:00
Dustin C. Hatch
f8d04bec1b system/lvol: Suppress prompts from lvcreate
Occasionally, `lvcreate` will prompt on stdin for confirmation. In
particular, this may happen when the volume is being created close to
the location on disk where another volume existed previously. When this
happens, Ansible will hang indefinitely with no indication of the
problem. To work prevent this problem, the `--yes` command-line argument
can be passed to `lvcreate`, which will instruct it not to prompt.

Signed-off-by: Dustin C. Hatch <dustin@hatch.name>
2015-03-22 22:16:37 -05:00
David Wittman
34e7d9c938 Fix multiple issues with alternatives module
- Changes are no longer erroneously reported on RHEL (#12)
 - Adding new link groups on Debian works again.
   - This was broken in a previous commit by assuming the OS was RHEL
     if `update-alternatives --query <name>` had a return code of 2
 - Prefer `--display` over `--query` for determining available
   alternatives
   - --display is more distro-agnostic and simplifies the code
 - Fix missing `msg=` in `fail_json` call when `link` is missing
 - Document that `link` is required on RHEL-based distros

Tested on Ubuntu 12.04+ and CentOS 6/7
2015-03-13 23:16:44 -05:00
Toshio Kuratomi
8baba98ebe Don't know why but the 1.8.x branch didn't include the commit for crypttab.
Update documentation to show it is new in 1.9 as a result of that
oversight.
2015-03-11 11:07:33 -07:00
Dmitry Bashkatov
19d51a51db gluster_volume: remove redundant code 2015-03-11 17:22:38 +03:00
Dmitry Bashkatov
26c2080dcf gluster_volume: use force option during add-brick 2015-03-11 16:40:22 +03:00
Dmitry Bashkatov
c6448660a3 gluster_volume: fixes, new "force" option 2015-03-11 10:54:13 +03:00
Richard Gray
7c40201c3d Set default for locale_gen state parameter
Fix the state parameter for the locale_gen module to be non-mandatory
with a default value of 'present', as indicated by the module
documentation.
2015-03-07 21:24:32 +13:00
Matthew Vernon
7a9e6aee90 Changes from Brian Coca's review of this module
These are all the code changes from Brian's review:
* change #! line
* rename "host" to "name" [keep as alias]
* make documentation clearer
* imports 1 per line
* use get_bin_path to find ssh-keygen
* key not actually required when removing host
2015-03-06 18:24:32 +00:00
Matthew Vernon
d821a39131 known_hosts: manage ssh known_hosts files with ansible.
The known_hosts module lets you add or remove a host from the
known_hosts file. This is useful if you're going to want to use the
git module over ssh, for example. If you have a very large number of
host keys to manage, you will find the template module more useful.

This was pull request 7840 from the old ansible repo, which was
accepted-in-principle but not yet merged. The mailing list thread
reading it is:

https://groups.google.com/forum/#!topic/ansible-devel/_e7H_VT6UJE/discussion
2015-03-06 18:24:32 +00:00
Brian Coca
41ddb689db Merge pull request #182 from misho-kr/devel
fix lvol module to properly query the size of logical volumes
2015-03-06 11:53:33 -05:00
Brian Coca
405bb040f8 Merge pull request #285 from fuglu/devel
svc: Add kill command (svc -k)
2015-03-03 08:07:07 -05:00
Brian Coca
650d740a3a Merge pull request #196 from alxgu/lvol_fix_casesensitivity
Bugfix PR for lvol: Cast size(LogicalVolumeSize) to lower .
2015-02-26 08:46:07 -05:00
Benjamin Kluck
8a5297c535 svc: Add kill command (svc -k) 2015-02-25 18:24:18 +01:00
Brian Coca
9f11d10135 Merge pull request #181 from sterfield/devel
Allow every type of locales + archlinux fix
2015-02-17 13:45:12 -05:00
SkaveRat
8eabcdcbc6 Fix missing restart method
Script was missing the restart command
2015-02-12 22:22:31 +01:00
Kai de Haan
e4f57eae44 svc: Ensure python 2.5 compatibility
* eg. debian lenny
2015-02-12 20:46:20 +01:00
Brian Coca
9219797bb5 Revert "Add listsnapshots property to zfs" 2015-02-12 10:17:56 -05:00
Brian Coca
5148a88e2c Merge pull request #88 from queeno/facter_should_return_puppet_custom_facts
Facter module should return custom facts
2015-02-11 17:32:57 -05:00
Brian Coca
83c051dfd5 Merge pull request #248 from bcoca/fix_alternatives
now properly checks that link is suplied before trying to use it
2015-02-11 17:32:00 -05:00
Brian Coca
c7e3aee0f0 now properly checks that link is suplied before trying to use it
should fix #46
2015-02-11 17:21:35 -05:00
Kelley Reynolds
92c30c7c41 Add listsnapshots property to zfs 2015-02-11 17:16:41 -05:00
Brian Coca
3f78475cae daemontools module 2015-02-11 12:35:43 -05:00
Misho Krastev
d11e36589a Merge branch 'upstream_devel' into devel
Conflicts:
	system/lvol.py
2015-01-24 22:13:53 -08:00
Sebastien ROHAUT
9cb97b2898 Add "-" to ulimit type
Just edited pam_types to add the '-', as explained in man 5 limits.conf
2015-01-23 20:07:27 +01:00
Giovanni Tirloni
cb46aab3d1 add createparent option to zfs create 2015-01-22 09:13:12 -05:00
Hiroshi Umehara
759e032473 Generalize locale name normalization 2015-01-22 12:07:10 +09:00
Rob White
adb1f0a1c8 Convert symlinks specified in pvs to actual path 2015-01-22 13:37:37 +11:00
Hiroshi Umehara
42f79478a7 Add EUC-JP locale name normalization
The function normalizes checks for UTF-8, but the same issue exists for
other locales as well.  This fix adds normalization for EUC-JP, a Japanese
locale.
2015-01-21 16:10:12 +09:00
Pierre-Louis Bonicoli
40298a8f24 remove unused variable 2015-01-12 19:02:30 +01:00
Pierre-Louis Bonicoli
25f595c2ba Avoid to use the builtin 'echo'
By default, the interpretation of escape characters could be disabled (bash)
or enabled (dash).
2015-01-12 18:52:25 +01:00
Alexander Gubin
e15fba5156 lvol: Cast size(LogicalVolumeSize) to lower to fix the difference between lvs and lvcreate 2015-01-12 17:43:51 +01:00
Brian Coca
ffa8abf979 Merge pull request #120 from alxgu/lvol_fix_path
Fix lvol: Find LVM commands in PATH env - Bugfix Pull Request
2015-01-09 16:04:45 -05:00
Yuri Kunde Schlesner
1d60d33dc1 crypttab: Fix parameter checking with state=absent
Only the `name` parameter is required when removing an entry, but the module tried to ensure at least one other parameter was set.
2015-01-08 21:44:58 -02:00
Bert Mertens
3981872375 Fix getent behaviour with fail_key=False 2015-01-06 09:57:30 +01:00
Toshio Kuratomi
d4f5b6d41a Fixes for docs building 2015-01-05 08:40:57 -08:00
Misho Krastev
5acc634549 fix lvol module to properly query the size of logical volumes 2015-01-05 01:52:20 -08:00
Sterfield
48ecbd037e Missing import re
I don't even know how it magically worked, but the fact is the code was
correct, and ran OK without the import re.
2015-01-03 22:24:27 +01:00
Sterfield
c9656ff3b4 Now allow every type of locales + archlinux fix
The previous version of this code was supporting only locales using the
format "<language>_<territory>.<charset>". But all the locales that
doesn't have this format were not installable (such as "fr_FR" or
"fr_FR@euro").
Also, if an invalid locales was provided, the module kept sending a
"changed" status.

Now :
 * if the user provides an invalid locales, the module failed. Locales
   are verified using /etc/locale.gen or /usr/share/i18n/SUPPORTED if
   Ubuntu
 * Every types of valid locales are now supported.
 * The locale module was not working on Archlinux, as there's no space
   between the "#" and the locale. This is now supported. Credits goes
   to danderson189, this is his code.

This module was tested on debian jessie, ubuntu 14 LTS and last
Archlinux.
2015-01-03 18:01:13 +01:00
Nicolas Brisac
5462748553 Merge remote-tracking branch 'upstream/devel' into devel 2015-01-02 21:30:51 +01:00
Brian Coca
3e7da5366b Merge pull request #176 from bcoca/gluster_volume_docfix
fixed doc bug
2015-01-02 14:22:23 -05:00
John Barker
9efac37b1b Add a note about debconf passwords always being recorded as changed 2014-12-31 22:10:18 +00:00
Brian Coca
2e6b94047d fixed doc bug 2014-12-30 19:53:59 -05:00
Sebastien ROHAUT
4c22ee75b1 Update pam_limits.py
- Comments are now managed correctly
- Cannot use use_min and use_max at the same time
2014-12-24 15:36:54 +01:00
Timothy Vandenbrande
b365fc4464 added a source/network add/remove to/from zone for firewalld - removed useless comment 2014-12-19 09:35:40 +01:00
Timothy Vandenbrande
6fab8f49a9 added a source/network add/remove to/from zone for firewalld 2014-12-19 09:35:40 +01:00
Nikolai Lifanov
1be1aacadf fix at.py module on non-glibc systems 2014-12-17 10:09:36 -05:00
Cosmo Petrich
443d7683a0 Remove default from 'permanent' and 'state' docs
These fields are both required, and thus do not actually have defaults.
2014-12-12 18:49:19 +11:00
Brian Coca
108db556a0 Merge pull request #136 from bcoca/gluster_revamp
revamp of gluster volume management
2014-12-11 20:55:23 -05:00
Brian Coca
fdd41fb95c Merge pull request #1 from mscherer/devel
Add a new option immediate= to immediately apply a permanent change
2014-12-11 20:47:48 -05:00
Brian Coca
6725d5188d revamp of gluster volume management
also implemented deleting a volume
2014-12-06 19:08:07 -05:00
Toshio Kuratomi
19e688b017 Fixes to documentation 2014-12-03 08:16:11 -08:00
Michael Scherer
62cae242cf Add a new option immediate= to immediately apply a permanent change
Currently, either you apply the change in the configuration
of firewalld ( without permanent=True ), or you apply it live.
I most of the time want to do the 2 at the same time, ie open the
port ( so I can use the service ) and make sure it stay open on reboot.
2014-12-01 19:51:11 +01:00
Brian Coca
9e798ec6bc Merge pull request #48 from rosmo/glusterfs-module
Added GlusterFS module.
2014-12-01 11:50:06 -05:00
Brian Coca
52f526c360 Merge pull request #17 from abompard/devel
Module alternatives: support RedHat-based OSes
2014-12-01 11:35:32 -05:00
Brian Coca
cbfabba9e3 Merge pull request #7 from groks/crypttab-module
New crypttab module for editing Linux /etc/crypttab file
2014-12-01 11:33:45 -05:00
Alexander Gubin
20ef2696bc Fix lvol: Find LVM commands in PATH env 2014-11-26 11:27:29 +01:00
Brian Coca
e64751b0eb Merge pull request #53 from bcoca/getent_doc_fixes
corrected and made better docs for getent
2014-11-20 15:49:33 -05:00
Sebastian Gumprich
040135dbba Added documentation and example for port ranges.
Also added punctuation marks.
2014-11-20 20:48:41 +00:00
Nicolas Brisac
1e3645a9e3 Allow filtering of routed/forwarded packets
MAN page states the following :

    Rules for traffic not destined for the  host  itself  but  instead  for
    traffic  that  should  be  routed/forwarded through the firewall should
    specify the  route  keyword  before  the  rule  (routing  rules  differ
    significantly  from  PF  syntax and instead take into account netfilter
    FORWARD chain conventions). For example:

        ufw route allow in on eth1 out on eth2

This commit introduces a new parameter "route=yes/no" to allow just that.
2014-11-14 17:09:24 +01:00
Brian Coca
664858ec20 Merge pull request #56 from filipenf/fix-lvg
LVG module fix when using multiple devices (string to list)
2014-11-06 15:26:37 -05:00
Sebastien ROHAUT
722d810ef2 Update pam_limits.py
Change path
2014-10-30 11:13:17 +01:00
Sebastien ROHAUT
c8fbac0ff2 Update pam_limits.py 2014-10-30 11:10:49 +01:00
Sebastien ROHAUT
b845c0ef56 Update pam_limits.py 2014-10-30 11:10:02 +01:00
Sebastien ROHAUT
8122edd727 Update pam_limits.py
Tabs...
2014-10-30 11:07:42 +01:00
Sebastien ROHAUT
e5939fffdd Create pam_limits.py
The pam_limits module modify PAM limits, default in /etc/security/limits.conf.
 For the full documentation, see man limits.conf(5).
2014-10-30 11:03:44 +01:00
Taneli Leppä
2d495f7e6e Added .py extension to glusterfs module. 2014-10-27 11:31:37 +02:00
Simon Aquino
4dd6c8204a Facter module should return custom facts
The ansible facter module should also return puppet custom facts by
default.
2014-10-21 23:47:03 +01:00
Franck Nijhof
130bd670d8 Small fix for boolean when boolean type was set via a variable (somehow changes the behaviour of Ansible because of YAML as it seems. Booleans then become represented as a string). 2014-10-13 07:34:24 +02:00
Franck Nijhof
2c43cdb123 Renamed module from mac_defaults to osx_defaults so the naming is more up to par with existing modules (e.g. osx_say) 2014-10-12 14:41:57 +02:00
Chris West
613b3bdda0 Enable "ufw default allow routed"
* The policy is shown in `status verbose`, so all the check mode stuff should keep working.
 * `--dry-run` works as expected.
 * No idea whether it's legal as an argument to `interface`
2014-10-12 12:43:50 +01:00
Franck Nijhof
a55035c558 Added module for managing Apple Mac OSX user defaults 2014-10-12 00:20:00 +02:00
Filipe Niero Felisbino
6cfb97a1c8 Replace dev_string to dev_list 2014-10-06 12:49:20 -03:00
Brian Coca
b0d5733fd0 corrected and made better docs for getent 2014-10-04 10:21:26 -04:00
Taneli Leppa
6dc09c966c Added GlusterFS module. 2014-10-03 10:25:58 +03:00
Baptiste Mispelon
827da3ae1a Fixed typo in locale_gen documentation. 2014-10-02 16:42:13 +02:00
Dan Keder
838d05ba42 Add module system/seport.py
Module for managing SELinux network port type definitions
2014-10-01 11:22:50 +02:00
jravetch
c89ce9e8d7 mkfs.xfs uses -f instead of -F flag
mkfs.xfs uses the -f instead of -F flag to force creating a filesystem on a devices that have an existing filesystem
2014-09-29 15:40:58 -07:00
Aurélien Bompard
6b5aa62854 Module alternatives: support RedHat-based OSes
RedHat-based OSes have a version of update-alternatives which comes from
the chkconfig package and does not support the --query parameter. Work
around that.
2014-09-30 00:38:56 +02:00
Aurélien Bompard
b645dd330c Module alternatives: support check mode 2014-09-30 00:38:54 +02:00
Steve
26f58a8eb7 New crypttab module for editing Linux /etc/crypttab file 2014-09-29 01:11:11 +01:00
Michael DeHaan
110250d344 package files 2014-09-26 11:04:10 -04:00
Michael DeHaan
b1e789968b File extensions! 2014-09-26 10:40:16 -04:00
Michael DeHaan
50f105578a Restructuring. 2014-09-26 10:14:28 -04:00
Michael DeHaan
73123b69fa Move modules into subdirectory. 2014-09-26 09:23:50 -04:00
Toshio Kuratomi
8b81062be0 The fix for gh-7284 causes problems for initscripts which have the
standards compliant return codes but return a verbose error message via
stdout.  Limit the times when we invoke the heuristic to attempt to work
around this.
2014-09-22 14:53:07 -04:00
Michael Scherer
c9a0a7ae4b Fix #9704, correctly set changed as false when nothing is done 2014-09-21 14:55:31 +02:00
Toshio Kuratomi
7b100dd389 Be more specific in checking if a job restarted successfully.
Fixes: #9056
2014-09-19 12:03:27 -07:00
Toshio Kuratomi
36083c3b90 Failure to enable a service now fails the task
Fixes: 8855
2014-09-18 12:39:54 -07:00
Toshio Kuratomi
a50258d26a remove debugging that was causing failure 2014-09-17 10:25:54 -07:00
Toshio Kuratomi
2e16bd3a44 Refactor the Linux service_enable() method
* Fix check_mode for initctl systems

Fixes #9009
2014-09-17 09:34:33 -07:00
Toshio Kuratomi
104401805b Revert "Refactor the Linux service_enable() method" needs some debugging
This reverts commit e294e31fd3.
2014-09-17 09:17:33 -07:00
Toshio Kuratomi
c362902f50 Refactor the Linux service_enable() method
* Fix check_mode for initctl systems

Fixes #9009
2014-09-17 08:44:32 -07:00
Toshio Kuratomi
a9928492f7 Make systemd vs rht detection more robust for centos
Centos 6.x and below use an old RHT style of configuring hostname.
CentOS 7.x and better use systemd.  Instead of depending on the
distribution string which seems to have changed over the course of 6.x
we need to explicitly check the version.

Fixes #8997
2014-09-16 09:53:13 -07:00
James Cammarata
7edcf21bdc Move initscript rc check to later in service status check
Fixes #7284
2014-09-11 12:11:06 -05:00
Michael DeHaan
5aa6ddef7f Tracebacks are now catchable with ignore_errors and have streamlined output. Also removes 'baby-JSON' for bash modules. 2014-09-11 12:27:21 -04:00
Patrik Lundin
0abf14ff19 service: use self.changed in service_enable_rcconf().
This sets the "changed" result of the module when a rc file is modified.
Previously only --check mode would show that it was going to change.
2014-08-28 00:52:23 +02:00
James Cammarata
30d6713bf0 Add additional checks to detect upstart services
Also adds checks for the upstart version, in order to test check
support for manual vs. start on manual
2014-08-25 13:41:39 -05:00
Eri Bastos
6f8a29dc3d Proposed fix for issue #7757 2014-08-25 12:10:14 -05:00
James Cammarata
c8376e296f Tweaking change to documentation language for cron name param 2014-08-25 09:54:21 -05:00
James Cammarata
509761249c Merge branch 'devel' of https://github.com/mattparker/ansible into mattparker-devel 2014-08-25 09:51:17 -05:00
James Cammarata
07e77c5bed Merge pull request #8740 from mattparker/patch-1
Name appears to be a required parameter for cron module
2014-08-25 09:49:58 -05:00
James Cammarata
1f2727c607 Merge pull request #8729 from ercpe/openrc-hostname
Hostname strategy implementation for OpenRC based systems (e.g. Gentoo)
2014-08-25 09:28:29 -05:00
Matt Parker
6086c505fe Update cron documenation
The "name" parameter seems to be rather important as the identifying feature of a cron job.  This is an update to the documentation to further emphasize this.
2014-08-25 10:29:45 +01:00
Matt Parker
5accd15ba6 Name appears to be a required parameter
As far as I can tell, `name` is a required parameter.  The guard test at (now) line 458 says you need name if `state == present` and at 464 if `state != present`, although that's not quite as clear.  Each of the code paths at 485 - 495 pass the name param through to `add_job`, `update_job` and `remove_job`, and the actual _update_job method earlier seems to require it too.  However I don't really know python so I may be wrong, but I can't see the circumstances when `name` is not required.
2014-08-25 10:23:54 +01:00
Johann Schmitz
7ef67e3f8b Hostname strategy implementation for OpenRC based systems (e.g. Gentoo) 2014-08-23 09:00:28 +02:00
Ding Deng
85c6434262 debconf module: add the missing 'error' vtype and reorder vtypes as they appeared in debconf-devel(7). 2014-08-19 17:44:02 +08:00
Michael DeHaan
60ce2d3853 Fix documentation builds. 2014-08-08 15:12:10 -04:00
Michael DeHaan
f21d6c7980 Merge pull request #8002 from prune998/patch-2
added missing force flag on mkfs commandline
2014-08-08 13:55:19 -04:00
Michael DeHaan
185d5a6221 Merge branch 'spelling' of git://github.com/cgar/ansible into devel
Conflicts:
	docsite/rst/guide_rax.rst
	plugins/callbacks/mail.py
2014-08-08 13:28:45 -04:00
Michael DeHaan
66ec9089bd Update docs. 2014-08-08 11:51:27 -04:00
Michael DeHaan
f6f184b36d Updating docs. 2014-08-08 11:51:27 -04:00
Brian Coca
aeeefd046f bumped to 1.7 2014-08-08 11:51:27 -04:00
Brian Coca
5aa2ca762a added control to fail or not on missing key
made split 'smarter' but still overridable
2014-08-08 11:51:27 -04:00
Brian Coca
391f8ec600 added getent module to get system data as facts 2014-08-08 11:51:27 -04:00
Serge van Ginderachter
961d4b0d6c execute the mount after path validation
This avoids a stale situation where name/path contains some impossible path,
but gets configured (faultly) in fstab, and the module only fails after that,
when creating that path.
2014-08-06 10:52:08 +02:00
Jonathan Mainguy
650003dd5c Fixes issue #8339 where Scientific Linux incorrectly tries to use FedoraStrategy of hostnamectl 2014-08-02 15:38:52 -04:00
Michael DeHaan
e978dcf7eb Merge pull request #8283 from ps-jay/sys_mount_fstype_doc
Add fstype arg to the mount examples
2014-07-30 08:28:59 -04:00
Michael DeHaan
bc01f2571e Merge pull request #8311 from neersighted/wrap_distroversion
Wrap get_distribution_version() in the hostname module
2014-07-28 15:48:18 -04:00
Michael DeHaan
2212b64fd9 Cleaning up explanation of mount module states. 2014-07-28 12:18:45 -04:00
Bjorn Neergaard
cbc417ca1b Wrap get_distribution_version() in the hostname module
We wrap get_distribution_version() with a new function,
_get_distribution_version(), that returns `0` when the result is a string or
`None`.

This accounts for the case when get_distribution_version() returns a string,
and we try to compare it to a float. We do this in the hostname module instead
of the module snippets because other modules may want the real string
version.module snippets because other modules may want the real string version.
2014-07-28 11:16:30 -05:00
Michael DeHaan
99ad691950 Merge branch 'ufw' of git://github.com/Trozz/ansible into devel 2014-07-28 12:08:29 -04:00
Michael DeHaan
caba7ac6a6 Merge pull request #7954 from alimony/patch-3
cron module: Use correct parameter name in error message.
2014-07-28 11:29:05 -04:00
James Cammarata
03f0d6bec8 Merge pull request #8308 from robinro/extend-hostname-distrolist
Extended distributions list for hostname module
2014-07-28 09:12:59 -05:00
Robin Roth
7920f4eaf5 Fix extra newline at end of hostname for Fedora
This fixes a bug introduced by 138b45e3.
The hostname has an additional newline at the end which leads to the
state always being 'changed: true' even if the hostname is unchanged.
2014-07-28 15:22:10 +02:00
Robin Roth
a26bc9c926 Extended distributions list for hostname module
Implementations already present
2014-07-28 15:19:41 +02:00
Tom Lazar
d89adce760 FreeBSD 10 compatibility fix
On FreeBSD the whitespace around the ``=`` triggers a (cryptic) ``no such file or directory`` error. removing the whitespace like above fixes this.
2014-07-25 14:33:24 +02:00
Philip Jay
bb7b290ed8 Add fstype arg to the mount examples
Needed fstype in the examples, since fstype is a required argument for
mount.
2014-07-25 09:58:54 +10:00
Berend de Boer
f46c4ee093 Default for fstab missing, causing KeyError: 'fstab' 2014-07-24 13:14:46 +12:00
James Cammarata
6879e4ff0a Merge pull request #8223 from renard/create-fstab-if-not-exists
Create fstab if not exists
2014-07-21 15:03:14 -05:00
Sébastien Gross
e0f7b3f39c [mount] make sure fstab exists
This is mainly to prevent from failing with no such file or directory
during module execution.
2014-07-21 18:32:02 +02:00
Sébastien Gross
806052a9e5 [mount] Add documentation for fstab option 2014-07-21 18:30:59 +02:00
Hector Acosta
60edb6b04b Add check_mode support to authorized_key. Fixes #7300
Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
2014-07-19 17:55:58 -05:00
Yasser Nabi
8cc894bef2 Enable puppet facts
Currently facter facts omit facts that a distributed via Puppet. This
commit adds the `--puppet` option.

In cases where puppet is not installed, the command sends a warning to
STDERR *but* completes successfully. So should not cause any issues.

The benefit is, filtering can be done based on facts set by Puppet.
2014-07-17 17:53:12 +01:00
Michael DeHaan
96fe275946 Merge pull request #8139 from peterkh/devel
Fix "TypeError: group id must be integer" if groupid passed in for group key
2014-07-16 15:55:14 -04:00
Ruggero Marchei
ae95ebd075 fix LooseVersion exception with empty distribution_version 2014-07-16 07:55:20 +02:00
Peter Hall
ae67002c15 Fix "TypeError: group id must be integer" if groupid passed in for group
key
2014-07-15 11:16:47 +10:00
Ruggero Marchei
8d01986617 fix issue #8102 2014-07-15 01:26:44 +02:00
Cristian Ciupitu
72d6e6d805 Remove useless code 2014-07-09 23:11:15 +03:00
Michael Leer
39b34b008c add interfact documentation #7704 2014-07-01 18:49:07 +01:00