cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
8962 commits 47 branches 390 tags 440 MiB
Commit graph

602 commits

Author SHA1 Message Date
Mengdi Gao
4ff5218903 Improve doc accuracy of template module 2016-04-13 10:04:06 +08:00
peter.jang
c52f475c64 added rsync protocol support (#1999) 
* added rsync protocol support

* correction for example document(add example for push on delegate)

* use startswith method for safety
 2016-04-08 11:41:53 -04:00
Brian Coca
a268e5a119 Merge pull request #2647 from bertvv/issue_2498 
Also show stdout when validation fails. This fixes #2498
 2016-03-17 08:49:39 -07:00
Brian Coca
c86a0ef84a fixed exit json 2016-03-09 15:42:30 -05:00
Matt Martz
07f29ecd7f Fix synchronize docs to indicate the correct default for use_ssh_args 2016-03-09 11:12:21 -06:00
Toshio Kuratomi
80543ee6f8 Merge pull request #3197 from dagwieers/unarchive-download-error-fix 
unarchive: Ensure that download failure is properly raised before read fails
 2016-03-08 12:23:53 -08:00
Brian Coca
94e66cb108 fixes to assemble 
now uses atomic move to avoid data corruption
correclty cleans up temp files in every case
returns backup_file info if needed
validate validate before temp file gets created
backup AFTER validate
 2016-03-08 10:38:23 -05:00
Dag Wieers
7cd47eb73a Ensure that a download failure is properly raised before the read fails 
Without this change, a download failure may bail out with the message:

    "Failure downloading http://foo/bar, 'NoneType' object has no attribute 'read'"

whereas with this fix, you'd get a proper error like:

    "Failure downloading http://foo/bar, Request failed: <urlopen error [Errno 113] No route to host>"

or one of the many other possible download errors that can occur.
 2016-03-08 01:19:23 +01:00
Toshio Kuratomi
2920658776 Change one param to be of type path 2016-02-29 00:33:34 -08:00
Toshio Kuratomi
832e81e691 Set some module parameters to type=path 2016-02-29 00:21:02 -08:00
Toshio Kuratomi
a7cfa1c8cd Correct dest_port to be of type int 2016-02-29 00:13:21 -08:00
Toshio Kuratomi
cfbe65f8c8 Set name to type path so that tilde and env vars are expanded 2016-02-28 23:46:40 -08:00
Brian Coca
c50ca43d8d fixed typo, now correctly check isdir 
fixes #3089
 2016-02-22 12:36:37 -05:00
Brian Coca
ab4c542b33 added missing checksum alias 2016-02-22 12:36:37 -05:00
Brian Coca
cefdb9a494 Merge pull request #2896 from towolf/add_diff_to_lineinfile 
Add diff to lineinfile.py for both file contents and file attributes
 2016-02-18 05:35:17 -08:00
Brian Coca
81b827f869 fixed option name mismatch, added aliases 
also removed empty aliases
 2016-02-15 17:13:46 -05:00
Brian Coca
8c2ef29a7a added follow to specific modules that support it 
was removed from common file docs
 2016-02-15 14:14:56 -05:00
Jose Moreira
cb712f2ba8 Fixed module doc typos 2016-02-15 15:03:40 +00:00
Brian Coca
191bf977f7 Merge pull request #3042 from lgp171188/patch-1 
Fix typo in the copy module error message
 2016-02-15 08:16:03 -05:00
Brian Coca
238c26c7e2 recursive copy is not available(yet) on remote_src 2016-02-15 08:16:17 -05:00
Guruprasad
ea6c2573e3 Fix typo in the copy module error message 
Fix the typos in the error message shown on trying to use remote_src=yes for copying directories
 2016-02-15 16:22:29 +05:30
Brian Coca
b89f4c7cab cleaner error on recursive remote copy 
TODO: add recursive copy support when remote_src=yes
probably need to make shared the logic in the action plugin.
 2016-02-12 22:38:16 -05:00
Brian Coca
6a42e54e57 removed 'overquoting' of example 
fixes #3029
 2016-02-12 13:24:07 -05:00
Toshio Kuratomi
93d02189f6 Remove duplicate documentation fields 2016-01-28 09:24:20 -08:00
Tobias Wolf
99ba594f0a Add diff for both file contents and file attributes to lineinfile 
Using the difflist feature added in ansible/ansible@c337293 we can add
two diffs to the `diff` dict returned as JSON: A `before` and `after` pair of
changed file contents and the diff of the file attributes.

n.b.: the difflist handling from the above commit is logically broken.
PR will follow.

Example output:

    TASK [change line and mode] ************************************************************
    changed: [localhost]
    --- before: /tmp/sshd_config (content)
    +++ after: /tmp/sshd_config (content)
    @@ -65,21 +65,21 @@
     X11DisplayOffset 10
     PrintMotd no
     PrintLastLog yes
     TCPKeepAlive yes
     #UseLogin no

     #MaxStartups 10:30:60
     #Banner /etc/issue.net

     # Allow client to pass locale environment variables
    -AcceptEnv LANG LC_*
    +AcceptEnv        LANG LC_* GF_ENV_*

     Subsystem sftp /usr/lib/openssh/sftp-server

     # Set this to 'yes' to enable PAM authentication, account processing,
     # and session processing. If this is enabled, PAM authentication will
     # be allowed through the ChallengeResponseAuthentication and
     # PasswordAuthentication.  Depending on your PAM configuration,
     # PAM authentication via ChallengeResponseAuthentication may bypass
     # the setting of "PermitRootLogin without-password".
     # If you just want the PAM account and session checks to run without

    --- before: /tmp/sshd_config (file attributes)
    +++ after: /tmp/sshd_config (file attributes)
    @@ -1,3 +1,3 @@
     {
    -    "mode": "0700"
    +    "mode": "0644"
     }
 2016-01-27 12:36:11 +01:00
Toshio Kuratomi
c8d5fdaf27 Merge pull request #2891 from ansible/synchronize-better-error-missing-rsync 
Better error message when rsync nad ssh aren't present where synchronize is run
 2016-01-26 11:36:29 -08:00
Toshio Kuratomi
cb1fefdf92 Better error message when rsync nad ssh aren't present where synchronize is run 
Fixes https://github.com/ansible/ansible/issues/9305
 2016-01-26 09:43:38 -08:00
Brian Coca
3239691e9e Merge pull request #2870 from towolf/add_diff_to_synchronize 
Add custom diff field to synchronize module
 2016-01-26 10:09:20 -05:00
Tobias Wolf
cd3b9366fe Add custom or 'prepared' diff field to synchronize module 
This PR depends on pull requeest ansible/ansible#14105

rsync has a custom diff output that cannot easily be expressed as
`/usr/bin/diff before after`
 2016-01-26 09:34:25 +01:00
Toshio Kuratomi
d9e29752c1 Add an internal param instructing synchronize to replace localhost with the host that's being ssh'd from 2016-01-25 16:46:44 -08:00
Matt Martz
76925ef613 Merge pull request #2858 from sivel/issue/14064 
Add note about precautions of using become with fetch
 2016-01-22 11:35:22 -06:00
Matt Martz
3f232beb0a Add note about precautions of using become with fetch. Addresses https://github.com/ansible/ansible/issues/14064 2016-01-22 11:29:35 -06:00
Toshio Kuratomi
0b7469fa90 Fix documentation build 2016-01-21 08:37:15 -08:00
Toshio Kuratomi
76a478a226 Document that synchronize in 2.0.0.x has broken sudo behaviour. 
Part of the changes for #13825
 2016-01-21 08:24:33 -08:00
Toshio Kuratomi
78b4eac6fc Merge pull request #2722 from mscherer/fix_2630 
Fix 2630
 2016-01-11 11:37:34 -08:00
Brian Coca
48bd80c9cb adds diff info for file info 2016-01-05 14:52:54 -05:00
Michael Scherer
948900f7fb Fix doc inconsistency (#2630) 2015-12-22 15:22:17 +01:00
Brian Coca
f500a2ec53 added mime option to stat module 
it uses file magic to now return mime_type and charset of a file as
per output of `file -i /path`
 2015-12-14 21:18:13 -05:00
Adam Fields
27f561dca2 added a reference to the template module for clarity 2015-12-10 12:45:59 -05:00
quoing
877daf970d Fix: Default ACL parameters are not correctly handled 2015-12-08 11:44:03 -08:00
Brian Coca
db66144386 simplified lowercasing 2015-12-08 11:41:32 -08:00
quoing
c93de2f930 Add "default" entry option back (removed in e95bcae), update will translate entry to standard parameters so compatibility with BDS is kept 2015-12-08 11:41:32 -08:00
Bert Van Vreckem
9556bcb9c2 Also show stdout when validation fails. This fixes #2498 2015-12-08 13:10:25 +01:00
Brian Coca
8a2459c643 Merge pull request #2590 from noseka1/devel 
Fix ini_file module, avoid bracklets in key break idempotence
 2015-12-02 20:44:59 -08:00
Ales Nosek
9c74272c9b Fix #2475 ini_file module: bracklets in key break idempotence 
Escape the regex special characters in the option name.
 2015-12-02 20:31:27 -08:00
krdlab
61a3625ed0 Fix 'stat' module document 2015-12-02 18:20:20 +09:00
Dylan Martin
bfa7cdb5c4 improved error message when no handler found 2015-11-30 11:47:38 -08:00
Brian Coca
c6fdd3809f fixed typo EEXISTS is actually EEXIST 
fixes #2585
 2015-11-30 07:23:29 -08:00
Brian Coca
9030ae996c Merge pull request #2569 from gerph/gerph-fix-docs-file 
Update documentation for 'file' module to include 'diff_peek'.
 2015-11-27 12:57:19 -08:00
Charles Ferguson
176b4103b6 Add documentation to 'file' AnsibleModule definition for internals. 
The parameters 'diff_peek' and 'validate' are not expected to be used
by users. They are internal. To make it clear, this change adds the
comments 'Internal use only' to each of those definitions to make
it clear that they are actually used, just not by end-users.
 2015-11-27 20:49:27 +00:00
Charles Ferguson
9325c0ae5f Update documentation for 'file' module to include 'diff_peek'. 
The 'diff_peek' option isn't documented at all, and provides a
rudimentary check that the content isn't binary. Documentation is
added to explain the option.

The 'validate' option has a declaration, but isn't implemented.
Therefore it may as well be removed from the module.
 2015-11-26 15:40:09 +00:00
Charles Paul
1bc0b6ee6a create non-existent ini file 
fixing fail_json

more verbose fail msg
 2015-11-23 23:07:14 +09:00
Maarten Claes
e9c548da41 This fixes copy with the remote_src option 
It was broken in 6e37f1dcef when the remote_src was added. Need to
pass the absolute path to copy2 instead of a tuple.
 2015-11-18 13:12:59 +01:00
Brian Coca
6e37f1dcef fixed remote_src support, now actually copies and does not move 2015-11-12 09:39:37 -08:00
Timothy Appnel
ca12ed5d98 Added the checksum_algo alias to the stats module. 2015-11-07 18:16:20 -05:00
Brian Coca
e74dc8c1dd minor doc fixes 2015-11-07 08:23:57 -05:00
Ales Nosek
22790d301a Make the syntax work with Python 2.4 2015-10-30 21:57:25 -07:00
Ales Nosek
7f59773460 ini_file should only change what was specified and nothing more #5860 
See also:
http://alesnosek.com/blog/2015/08/03/improving-ansibles-ini-file-module/
 2015-10-28 22:11:02 -07:00
Brian Coca
45a9f0b453 since find doesn't make changes, support check mode and gather data for other tasks in check mode 2015-10-28 09:32:01 -04:00
Toshio Kuratomi
3993f4e967 Simplify logic to handle options set to empty string 
Fixes #2125
 2015-10-26 13:02:21 -07:00
Brian Coca
87b8086163 Merge pull request #2327 from ryansydnor/devel 
Add capability for stat module to use more hash algorithms
 2015-10-26 14:56:49 -04:00
Brian Coca
486d233cbe Merge pull request #2262 from bcoca/find_regex 
added regex support to find
 2015-10-23 17:39:49 -04:00
Ryan Sydnor
fb10161510 Add capability for stat module to use more hash algorithms 
Specifically, the stat module now has a checksum_algorithm parameter.
This lets the module utilize one of the hash algorithms available on the host
to return the checksum of the file.

This change is backwards compatible. The checksum_algorithm defaults to
sha1 and still returns its result to the stat.checksum property.
 2015-10-22 22:28:10 -04:00
Brian Coca
2b33c92e7a corrected docs for stat's lnk_source 
fixes #12850
 2015-10-21 09:24:44 -04:00
Brian Coca
074aad23e7 final form, use_regex now controls if patterns is glob or regex 
- fixed cases in which stat fails (dangling symlink)
- now properly reports name of skipped paths
 2015-10-19 20:44:44 -04:00
Brian Coca
e603b1bb69 changed so regexes and shell globs work transparently 2015-10-19 20:44:44 -04:00
Brian Coca
fdd88863d4 fixed bug in spec 2015-10-19 20:44:44 -04:00
Brian Coca
bc4b40d8e7 added regex support to find, also added 'singular' aliasess to patterns and paths 2015-10-19 20:44:44 -04:00
Brian Coca
5893eb51a5 documented new remote_src option 2015-10-16 01:10:04 -04:00
varnav
07c5143a99 Fixed confusion in the docs 
As 'path' is actually alias for 'dest', this could be confusing.
 2015-09-23 08:24:16 +03:00
Toshio Kuratomi
e9139ba4fa Change the example of rsync_opts to use a list instead of a string 
Fixes #9889
 2015-09-22 13:59:37 -07:00
James Cammarata
22d25de23c Fix syntax error in synchronize docstring 2015-09-17 11:30:03 -04:00
James Cammarata
627bd47fd3 Merge pull request #2055 from skylerbunny/patch-1 
Explanation of privilege escalation in notes
 2015-09-17 11:18:30 -04:00
Brian Coca
f12a2135ca Merge pull request #1525 from mjuenema/devel 
Removed check whether destination directory is writable from files/un…
 2015-09-14 09:01:36 -04:00
skylerbunny
489f3e67f1 Explanation of privilege escalation in notes 
An attempt to make clear how privilege escalation works with respect to the src/source host and dest/destination host. One existing note was incorporated into three new ones, iterating each.
 2015-09-12 13:13:48 -07:00
James Cammarata
310cf77edc Merge pull request #1947 from astorije/astorije/fix-acl 
Fix the acl module
 2015-09-11 13:06:19 -04:00
Brian Coca
68ab025dac minor doc fixes 2015-09-01 10:58:15 -04:00
Jérémie Astori
72fb7a0a17 Fix physical walk on acl module for Linux 
`-h` is for BSD [1] while `-P`/`--physical` is for Linux [2].
This commit fixes that option now that acl module is (temporarily)
only supported for Linux.
I will re-add `-h` when fixing BSD support.

[1]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[2]: http://linuxcommand.org/man_pages/setfacl1.html
 2015-08-20 23:35:53 +00:00
Jérémie Astori
8eefd44aef Make sure entry is not sent when acl state=query 2015-08-20 22:59:00 +00:00
Jérémie Astori
0e659ad872 Make sure permission-less entries are accepted when state=absent 
Also, remove that try condition as, at that stage, no permissions with
other than 2 or 3 fields are sent to the function.
 2015-08-20 22:58:49 +00:00
Jérémie Astori
e95bcaeb8a Remove support for d[efault]: in entry permissions 
It is not documented in [the Ansible doc page][1] nor
[the BSD setfacl man entry][2] (which means it might not be compatible
with BSD) so removing it does not break the API.

On the other hand, it does not conform with POSIX 1003.1e DRAFT
STANDARD 17 according to the [Linux setfacl man entry][3] so safer to
remove.

Finally, the most important reason: in non POSIX 1003.e mode, only ACL
entries without the permissions field are accepted, so having an
optional field here is very much error-prone.

[1]: http://docs.ansible.com/ansible/acl_module.html
[2]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[3]: http://linuxcommand.org/man_pages/setfacl1.html
 2015-08-20 22:22:28 +00:00
Brian Coca
f925f7e01f Merge pull request #1734 from freym/assemble-file-validation 
assemble: add file validation support.
 2015-08-19 11:15:21 -04:00
Jérémie Astori
3ac990556d Fix wrong expectation regarding entry format in acl module 2015-08-19 00:26:04 +00:00
Jérémie Astori
421d3f12cf Fix wrong processing of lines returned by setfacl in test mode 2015-08-19 00:25:18 +00:00
Jérémie Astori
50c6425673 Fix minor whitespace issues 2015-08-19 00:24:08 +00:00
Brian Coca
d61fde42ef updated encoding comment and expanded authors field 2015-08-14 22:01:05 -04:00
Brian Coca
d4a39d23df Merge pull request #150 from astorije/recursive_acl 
Add recursive support for ACL module
 2015-08-14 20:21:01 -04:00
Jérémie Astori
acfc2166b0 Set version number in recursive option description 2015-08-14 23:40:47 +00:00
Jérémie Astori
f8027a7f0a Ensure Python 2.4 compatibility and Linux-restricted support 
- Make build_entry compatible with Python 2.4
- Re-add missing warning/comment that was forgotten while refactoring
- Replace `all()` with a good ol' for-loop Python 2.4 compatibility
- Make a condition check more explicit (when `state` is `query`)
- Make sure this module can only be run with on a Linux distribution
- Add a note about Linux-only support in the documentation
- Set the version in which recursive support was added, 2.0
 2015-08-14 22:06:51 +00:00
Marius Gedminas
9bcf69a155 Fix obvious copy-paste error in module docs 2015-08-13 19:47:49 +03:00
Toshio Kuratomi
f39e5ffa1d Modify the default for synchronize's dest_port again 2015-08-05 13:05:59 -07:00
Toshio Kuratomi
ed2d8121b3 Update docs to reflect precedence for synchronize's dest_port param 2015-08-05 12:46:01 -07:00
Toshio Kuratomi
0071fd0bf7 Allow mode as a synchronize parameter (handled in action plugin) 2015-08-05 11:54:36 -07:00
Brian Coca
697307f88c Merge pull request #1670 from mikeputnam/issue-1643-gpl-header 
Add missing GPLv3 License header
 2015-07-30 14:39:44 -04:00
Toshio Kuratomi
19741d75eb Fi the local_rsync_path parameter used by the action plugin 2015-07-27 11:35:48 -07:00
James Cammarata
2bfddb015d In copy, set the mode before running th validation 
Because some programs that do validation (like visudo) may require
the permissions to be more restricted.

Fixes ansible/ansible#11385
 2015-07-26 14:40:22 -04:00
Brian Coca
9b8470ae95 minor doc fixes 2015-07-24 17:57:13 -04:00
Brian Coca
c688408385 fixed fragment docs 2015-07-24 17:54:02 -04:00
Jeff Widman
fd6518179b Move validate command into doc fragment and fix a few typos 2015-07-21 17:58:43 -07:00
Brian Coca
46fa43d9e0 Merge pull request #988 from isaacsimmons/ini-file-catch-interpolation-error 
Handle ini file properties that contain interpolation errors
 2015-07-20 20:49:23 -04:00