2 commits
Author | SHA1 | Message | Date | |
---|---|---|---|---|
Markus Bergholz
|
8ab304af44
|
implement support for hidden/protected variables gitlab_project_variable (#67461)
* #66135 implement support for hidden/protected variables * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com> * update example value * fix pep * fix pep8 * fix tailing whitespace * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Felix Fontein <felix@fontein.de> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Felix Fontein <felix@fontein.de> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Felix Fontein <felix@fontein.de> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Felix Fontein <felix@fontein.de> * Update test/integration/targets/gitlab_project_variable/tasks/main.yml Co-Authored-By: Felix Fontein <felix@fontein.de> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Felix Fontein <felix@fontein.de> * fix recommendations and request changes * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Felix Fontein <felix@fontein.de> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Felix Fontein <felix@fontein.de> * Update test/integration/targets/gitlab_project_variable/tasks/main.yml Co-Authored-By: Felix Fontein <felix@fontein.de> * fix undefine module * add missing import * expand documentation * add idempotent check * add changelog * Update changelogs/fragments/67461-gitlab-project-variable-masked-protected.yml Co-Authored-By: Felix Fontein <felix@fontein.de> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Felix Fontein <felix@fontein.de> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Felix Fontein <felix@fontein.de> * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Felix Fontein <felix@fontein.de> * check also for integer_types * expand integration test and check also for float type * append documentation * Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py Co-Authored-By: Felix Fontein <felix@fontein.de> Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com> Co-authored-by: Felix Fontein <felix@fontein.de> |
||
Markus Bergholz
|
18aae0a02b |
add new module with integration tests to manage gitlab project variables (#56574)
* add new module with integration tests to manage gitlab project variables * fix invalid yaml in DOCUMENTATION variable and don't import * from ansible module * remove extends_documentation_fragment and put imports after DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA * fix author in documentation and remove import from display * add alias file for integration test * split long lines and try to fix the author key remove tailing whitespace * replace email address with github username * adding the at style to username * add metaclass and future import * add state variable to be able to delete selected variables * add test with state = absent * update documentation. scheme is necessary * use singular in exmaple section * use key purge instead of purge_vars use purge instead of purge_vars also in the integration test * create gitlab object in the ansible main function * remove usedless .format * follow best practice fail message * add return documentation, return information about which variables were added, updated or removed and catch gitlab api auth error * use module_utils.api with api_url and api_token * use dict instead of list for vars * use project name instead of name as playbook key * add ansible checkmode_support, reduce variables in gitlab_project_variables class, remove wrong/duplicated HAS_GITLAB_PACKAGE check * use extends_documentation_fragment and don't pop elements from basic_auth_argument_spec * use just project_variable as output variable * update mutually_exclusive as suggested * re-add api_token documentation, because it is not included in api basic auth * remove useless statement remove unnecessary if * add one test with a changing value * put type at first position * keep item to reduce api calls, build array and keep indexes by replacing with None instead of poping * more asserts * Update lib/ansible/modules/source_control/gitlab_project_variable.py Co-Authored-By: Felix Fontein <felix@fontein.de> Update lib/ansible/modules/source_control/gitlab_project_variable.py Co-Authored-By: Felix Fontein <felix@fontein.de> Update lib/ansible/modules/source_control/gitlab_project_variable.py Co-Authored-By: Felix Fontein <felix@fontein.de> Update lib/ansible/modules/source_control/gitlab_project_variable.py Co-Authored-By: Felix Fontein <felix@fontein.de> Update lib/ansible/modules/source_control/gitlab_project_variable.py Co-Authored-By: Felix Fontein <felix@fontein.de> Update lib/ansible/modules/source_control/gitlab_project_variable.py Co-Authored-By: Felix Fontein <felix@fontein.de> * remove unused return key from documentation msg is only returned when failed * Update lib/ansible/modules/source_control/gitlab_project_variable.py Co-Authored-By: Felix Fontein <felix@fontein.de> * remove error key, because it is not returned * change also documentation from purged_vars to purge * Update lib/ansible/modules/source_control/gitlab_project_variable.py Co-Authored-By: Felix Fontein <felix@fontein.de> Update lib/ansible/modules/source_control/gitlab_project_variable.py Co-Authored-By: Felix Fontein <felix@fontein.de> Update test/integration/targets/gitlab_project_variable/tasks/main.yml Co-Authored-By: Felix Fontein <felix@fontein.de> Update test/integration/targets/gitlab_project_variable/tasks/main.yml Co-Authored-By: Felix Fontein <felix@fontein.de> * remove extra spaces fix wrong spelling * expand return value documentation with examples * add check_mode test reorder tests. first the check_mode test, later all other tests * Update lib/ansible/modules/source_control/gitlab_project_variable.py Co-Authored-By: Felix Fontein <felix@fontein.de> * fix existing keys in 'present' array rework key handling (reduce code) fix integration tests use untouched instead of present to identify unchanged variable keys fix wrong replacement minor fixes on request set aliases to unsupported, because the test succeed remove posix group1 because it conflicts with unsupported remove useless item from aliases * rework gitlab connection |