cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
5067 commits 47 branches 390 tags 440 MiB
Commit graph

520 commits

Author SHA1 Message Date
Dustin C. Hatch
fbcf39e1e1 Correct regex in is_keyid 
The `rpm_key` module claims to take a key ID as an argument, however it fails if one is actually given:

    msg: Not a valid key DEADBEEF

The reason for this is the regular expression in the `RpmKey.is_keyid` method is incorrect; it will only match the literal string "0-9a-f" exactly 8 times, rather than exactly 8 characters in the set 0-9 or a-f.
 2014-07-11 14:02:25 -05:00
Jacopo
91e246a776 Fixed bug with environment path for homebrew_cask 2014-06-28 14:27:33 +10:00
Hector Acosta
35ca6d535b Check at most 16 characters of the key. Fixes #7936 
Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
 2014-06-27 03:18:54 -05:00
Hector Acosta
b5fe46d48c Correctly handle .repo files in zypper_repository module 
Before the changes, removing a repository required a repo url. This shouldn't be required since zypper allows removing a repo based on its alias (mapped to name in this module).

The name variable was always required, which is misleading since repofiles provide their own alias. So a runtime check was added to avoid this confusion.

Additionaly, running this module on .repo files weren't idempotent. e.g

Before:
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo name=foo"
{"repo": "http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo", "state": "present", "changed": true}
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo name=foo"
{"msg": "Repository named 'devel_languages_python' already exists. Please use another alias.\n", "failed": true}

After:
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo"
{"repo": "http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo", "state": "present", "changed": true}
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo"
{"repo": "http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo", "state": "present", "changed": false}

Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
 2014-06-26 13:17:27 -07:00
James Cammarata
8e6a60dfd6 Merge pull request #7942 from sidred10/devel 
Fixed FreeBSD ports install issue
 2014-06-26 11:50:33 -05:00
sid
2f02d27744 Fixed FreeBSD ports install issue 2014-06-26 20:52:57 +05:30
Maxim Odinintsev
f4c183f5b8 Successfull exit if sync=yes and no package provided 2014-06-26 15:02:15 +03:00
Maxim Odinintsev
f4774a71b7 Success exit if sync=yes and no package provided 2014-06-26 14:55:16 +03:00
James Cammarata
1320f862de Merge pull request #7930 from trbs/apt_key_fetch_url_failure_codes 
apt_key clear message when downloading key returns an (http) error code
 2014-06-25 22:27:08 -05:00
George Yoshida
284476d4ec In the yum module example, use present/absent instead of installed/removed 2014-06-25 23:21:43 +09:00
trbs
e12d09861f apt_key clear message when downloading key returns an (http) error code 2014-06-25 15:30:34 +02:00
Sam Hanes
ed1aef3fa5 Restore #6484 reverted by c751168. 2014-06-23 17:12:19 -07:00
James Cammarata
46100f5bc4 Merge branch 'upgrade-release' of https://github.com/amenonsen/ansible into amenonsen-upgrade-release 2014-06-23 10:35:48 -05:00
James Cammarata
590a8bf2e8 Allow deb package installation via with_items 
Fixes #7863
 2014-06-21 20:06:48 -05:00
yuyak
54fdd5416b Fix typo in apt module documentation 2014-06-21 21:27:57 +08:00
James Cammarata
9e8bbd8eac Merge pull request #7801 from koenpunt/npm-rbenv-exec 
Allow gem executable to contain spaces
 2014-06-17 11:16:42 -05:00
Koen Punt
6c20fa0d6f Allow gem executable to contain spaces 
rbenv has a special exec function which loads the correct ruby version before executing a command.
The syntax for this is `/usr/local/rbenv/bin/rbenv exec gem ...` for example.
But previously when specifying executable='/usr/local/rbenv/bin/rbenv exec gem' this would not work because the string was treated as one executable. This PR fixes that by splitting the executable on spaces.
 2014-06-17 11:58:10 +02:00
Koen Punt
ec9e6e1cd6 Allow executable to contain spaces 
NVM has a special script which loads the correct node version before executing a command.
The syntax for this is `/usr/local/nvm/nvm-exec ...`, so `nvm-exec npm list --json` for example.
But previously when specifying `executable='/usr/local/nvm/nvm-exec nvm'` this would not work because the string was treated as one executable.
 2014-06-17 01:31:24 +02:00
James Cammarata
1bec2e7eb7 Minor cleanup of openbsd_pkg example comment 2014-06-16 11:35:57 -05:00
James Cammarata
adb9feaf83 Merge pull request #7774 from mwpher/devel 
[openbsd-pkg] Add note regarding package flavors
 2014-06-16 11:33:53 -05:00
Todd Owen
198048c356 Fix in pkgutil: don't call pipes.quote() on None. 
In this function, 'site' may be None, which will cause an exception
if it is passed to pipes.quote().
 2014-06-15 10:20:35 +08:00
Matthew Pherigo
09e7cc2aa6 [openbsd-pkg] Add note regarding package flavors 
This adds a note to the openbsd-pkg module which explains how to specify
package flavors as well as how to avoid ambiguity errors on a package
with multiple flavors.

Technically, this is not Ansible-specific, but it's pretty likely the
user will encounter this problem.
 2014-06-14 19:42:09 -05:00
James Cammarata
9d86d41741 Cleaning up svr4pkg commit fix for #7645 2014-06-09 10:48:06 -05:00
James Cammarata
eb57ceee96 Merge branch '7645' of https://github.com/kcghost/ansible into kcghost-7645 2014-06-09 10:45:29 -05:00
Casey Fitzpatrick
6a5ad84656 fix for svr4pkg module failure reporting, issue #7645 2014-06-08 19:59:44 -04:00
Jean-Frédéric
ea78ad9906 Fix documentation of deb option in apt module 
The apt module may install a .deb package on the remote machine, not on the local.
Fix the misleading documentation.
 2014-06-06 18:18:44 +02:00
Andrew Resch
da7835da1d Fix typo in variable name 2014-05-23 16:09:57 -07:00
Andrew Resch
5016dc40fc Replace CommandException with Exception 2014-05-23 12:44:01 -07:00
Daniel Jaouen
3b38077246 Add upgrade_all option to homebrew module. 2014-05-23 11:09:18 -04:00
Ralf Geschke
d452bb896d added missing description of composer command 2014-05-21 18:14:21 +02:00
Ralf Geschke
af33222364 added missing description... 2014-05-21 18:12:53 +02:00
Ralf Geschke
5446bcdf90 implemented the missing "command" option, defaults to "install"... 2014-05-21 18:01:33 +02:00
James Cammarata
792298f114 Default use_proxy to True for fetch_url() 
Also added some error handling to the fetch_url() call in the
apt_repository module, so that failures to look up the PPA info
are properly handled.

Fixes #7322
 2014-05-19 23:04:13 -05:00
Abhijit Menon-Sen
9eebdd1edb Allow '-t ' to be passed to apt: upgrade 2014-05-17 23:02:20 +05:30
James Cammarata
289170bd2d Merge branch 'yum_module_typos' of https://github.com/mpeters/ansible into mpeters-yum_module_typos 2014-05-16 09:24:47 -05:00
Michael Peters
098513a8a5 slight language change based on feedback from jimi-c 2014-05-16 09:44:32 -04:00
Michael Peters
715f059c5a fixing some typos in the docs of the yum module 2014-05-16 09:22:12 -04:00
Alan Pearce
332909a956 Update composer example 
Remove unsupported 'install' argument
 2014-05-16 14:06:55 +01:00
Yuichi TANIKAWA
41fbdd9421 Add dots to valid path characters 2014-05-10 18:13:16 +09:00
James Cammarata
bf3079c77a Make sure distro variable is set if python-apt is installed 
Fixes #7295
 2014-05-06 09:42:50 -05:00
Michael DeHaan
594e5dcdd7 In apt module show 'name' vs pkg to standardize with the rest of the modules. 'pkg' is an alias for name. 2014-04-29 15:48:51 -04:00
Carlos E. Garcia
4dcaa9d9fb multiple spelling error changes 2014-04-29 10:41:05 -04:00
mkosmach
cfc8b1c561 add simplejson as alternative to json 2014-04-25 02:44:51 -07:00
Michael DeHaan
a9b4fcf703 Add missing license headers to two modules and standardize formatting of another. 2014-04-24 10:32:54 -04:00
James Cammarata
33c1f697d2 Merge branch 'apt_key_format' of https://github.com/andreasf/ansible into andreasf-apt_key_format 2014-04-24 00:02:10 -05:00
James Cammarata
6468b72d59 Merge pull request #7022 from jjshoe/patch-1 
apt_key lists all keys in uppercase
 2014-04-23 15:58:23 -05:00
James Cammarata
2725538515 Merge pull request #7095 from radeksimko/pokemon-exc-fix 
Prevent catching unrelated exceptions
 2014-04-21 11:49:04 -05:00
Radek Simko
08befa9c86 Prevention for catching unrelated exceptions added 2014-04-21 15:35:49 +01:00
Radek Simko
7d47f46807 Explicit check of return code for autoinstallation of python-apt added 
This will allow easier debugging through more meaningful error message.
 2014-04-21 14:10:09 +01:00
Andreas Fleig
cef705d04f apt_key: fix key lookup for 64 bit key ids 
Fixes #7018 by extending `all_keys` to work with either short or long keys.

Also removes the ununsed method `key_present`.
 2014-04-17 03:51:19 +02:00
jjshoe
eeb2c240ca apt_key lists all keys in uppercase 
allow for a little user error
 2014-04-16 10:06:59 -05:00
Cédric RICARD
556c780ac9 Fixed test on 'cached' parameter. 
'cached' parameter is boolean, not string
 2014-04-15 16:41:27 +02:00
James Tanner
076bba555f Addresses #6908 Add a mode parameter to apt_repository 2014-04-14 16:42:23 -04:00
James Tanner
c827f8ad3d Remove debug line 2014-04-14 16:02:08 -04:00
James Tanner
f273d3ef42 Addresses #6908 Strip usernames and passwords from apt_repository filenames 2014-04-14 13:18:21 -04:00
James Tanner
e4d7ffc47c Fix version added for annotation in pkgng 2014-04-08 10:28:01 -04:00
James Tanner
2ac7caa3c6 Fix version_added for install_options in homebrew 2014-04-08 10:13:33 -04:00
Drew Blas
2755a8296e Update apt:deb with correct version 
The docs site says this option is available in 1.5, but it is not.  

#5910 https://github.com/ansible/ansible/pull/5910 added the deb option.  The PR was generated two months ago (before 1.5) but was not included until after 1.5 was released.  This fixes the docs.
 2014-04-04 05:59:57 -05:00
Michael DeHaan
e5ad1febc0 Merge pull request #6793 from muffl0n/patch-4 
apt_key: Output URL for debugging
 2014-04-03 17:35:49 -04:00
Michael DeHaan
2e62cbdaa2 Clarify docs message. 2014-04-02 17:37:10 -04:00
Michael DeHaan
89c1e50f7b Note that keyserver was added in 1.6 2014-04-02 17:18:14 -04:00
Andrew Resch
dfdca084f0 redhat_subscription calls AnsibleModule() without argument_spec 
The Rhsm object requires an AnsibleModule but it isn't created with an argument_spec and fails.  Since the rhn.module is set directly after, setting None for the required argument of Rhsm fixes the module.
 2014-04-01 11:22:29 -07:00
Sven Schliesing
ff0d0afb07 Output URL for debugging 2014-04-01 13:55:58 +02:00
James Tanner
f7609c8bbe Fix merge conflicts 2014-03-31 13:15:21 -04:00
Daniel Jaouen
44b563a40a Miscellaneous fixes to homebrew module. 2014-03-28 19:37:05 -04:00
Daniel Jaouen
e77c65af80 Update homebrew module. 2014-03-28 19:20:51 -04:00
Michael DeHaan
b566b27edd Merge pull request #6746 from Jmainguy/svr4pkg 
svr4pkg changes - Did my best to rebase. Now includes the latest changes made to devel, al...
 2014-03-28 18:50:29 -04:00
Michael DeHaan
a72d15fb7f Changelog and version updates. 2014-03-28 17:01:15 -04:00
Michael DeHaan
1657792a05 Merge branch 'layman' of git://github.com/jirutka/ansible into devel 2014-03-28 17:00:52 -04:00
Jonathan Mainguy
a5ac920a19 Did my best to rebase. Now includes the latest changes made to devel, along with my change of adding category option to module 2014-03-28 15:35:52 -04:00
Michael DeHaan
6fb2d56970 Resolve merge. 2014-03-28 14:56:59 -04:00
Michael DeHaan
7ced8de690 Rename apt-rpm to apt_rpm. 2014-03-28 13:18:49 -04:00
Michael DeHaan
5599835a1d Merge branch 'apt-rpm' of git://github.com/evgkrsk/ansible into devel 2014-03-28 13:17:37 -04:00
Michael DeHaan
8964b2e049 Merge branch 'devel' of git://github.com/leafnode/ansible into devel 
Conflicts:
	library/packaging/apt_key
 2014-03-28 13:15:06 -04:00
Michael DeHaan
f4bf078d6f Rename prerelease to pre_release. 2014-03-28 13:09:10 -04:00
Bob Zoller
b023f32cdf gem module supports prerelease (--pre) 2014-03-28 13:09:10 -04:00
Michael DeHaan
72696fec03 Merge branch 't-apt-list' of git://github.com/Elemecca/ansible into devel 2014-03-28 12:19:23 -04:00
Michael DeHaan
ca6545cb66 Merge pull request #6671 from dermute/svr4pkg-G 
svr4pkg supports the -G switch for pkgadd
 2014-03-28 11:42:46 -04:00
Michael DeHaan
ea3e0f8386 Merge branch 'devel' of https://github.com/drewblas/ansible into devel 2014-03-28 11:07:40 -04:00
Anton Lindström
d3cb2d38b7 Make pip dry run work better for the common case 
This change allows the pip module to figure out if something needs to be done during
a dry run using 'pip freeze'. This is implemented for the most basic case: name,
version and state=(present|absent). In other cases it will fall back to the old
behavior.
 2014-03-26 15:48:21 +01:00
Alexander Winkler
81194f2bcc version_added for the new parameters documentation 2014-03-26 10:25:42 +00:00
Alexander Winkler
cc5e37e5fd svr4pkg supports the -G switch for pkgadd 2014-03-25 09:03:48 +00:00
James Cammarata
d77f1976a6 Revert "add yum module downgrade support" 
This reverts commit cbd1da6457.
 2014-03-24 12:27:32 -05:00
Colin Mattson
3b710005ad Clarify documentation for apt pkg, state, install_recommends 2014-03-21 13:52:36 -07:00
willthames
0b87bbe839 Allow npm to install to a directory that doesn't yet exist 
If path is specified but does not exist, create it.
Fail if path is specified but is not a directory
 2014-03-21 13:30:12 +10:00
Michael DeHaan
5e557c6d29 Update cpanm 2014-03-20 08:10:02 -04:00
James Tanner
9efcbd8ef2 Fixes #6548 correct issues from rhn_register refactoring 2014-03-18 21:21:18 -04:00
Michael DeHaan
d10de23f39 Merge pull request #6565 from fabianfreyer/devel 
Fixed bug that occurred when pkgsite not specified
 2014-03-18 17:13:05 -04:00
Fabian Freyer
a061440828 Fixed bug that occurred when pkgsite not specified 2014-03-18 21:55:05 +01:00
James Tanner
12340279c4 Merge pull request #6220 from trevorah/ansible.git 
apt_repository: autoinstall python-apt if not available
 2014-03-18 16:21:04 -04:00
vyrak bunleang
5549c2cdd0 prevent state from changing from head to installed 
allows for --HEAD to be included in brew install command
 2014-03-17 16:56:54 -06:00
Michael DeHaan
950c0ebce6 Merge pull request #6529 from sivel/apt-repository-no-pycurl 
Remove dependency on pycurl in apt_repository
 2014-03-17 17:32:23 -04:00
Matt Martz
427fe86ae7 remove dependency on pycurl from apt_repository by using module_utils/urls.py instead 2014-03-17 11:31:04 -05:00
Michael DeHaan
2f6988d946 Update formatting in module example. 2014-03-17 09:10:33 -04:00
Jonathan Dray
63e2d9b3f7 fix: bug in apt when python-apt is not present apt-get was not called due to unsafe call 2014-03-17 02:24:12 +01:00
Michael DeHaan
265aed79ab Update version_added 2014-03-16 16:35:52 -04:00
Drew Stokes
34e63357ef add registry option to npm module 2014-03-16 16:35:52 -04:00
Michael DeHaan
5e36c1e742 Merge pull request #6069 from danieljaouen/homebrew_class 
Update homebrew module.
 2014-03-16 15:21:00 -05:00
Michael DeHaan
6241c03e25 Update cask version, changelog. 2014-03-16 16:18:27 -04:00
Michael DeHaan
4f531e6468 Merge branch 'homebrew_cask' of git://github.com/danieljaouen/ansible into devel 2014-03-16 16:18:05 -04:00