Commit graph

688 commits

Author SHA1 Message Date
Brian Coca
3f247e2d78 Merge pull request #313 from DavidWittman/12-alternatives-fixes
Fix multiple issues with alternatives module
2015-03-25 23:46:32 -04:00
Brian Coca
09fc1eefe5 Merge pull request #114 from rndmh3ro/patch-1
Added documentation and example for port ranges.
2015-03-25 23:41:05 -04:00
Dustin C. Hatch
f8d04bec1b system/lvol: Suppress prompts from lvcreate
Occasionally, `lvcreate` will prompt on stdin for confirmation. In
particular, this may happen when the volume is being created close to
the location on disk where another volume existed previously. When this
happens, Ansible will hang indefinitely with no indication of the
problem. To work prevent this problem, the `--yes` command-line argument
can be passed to `lvcreate`, which will instruct it not to prompt.

Signed-off-by: Dustin C. Hatch <dustin@hatch.name>
2015-03-22 22:16:37 -05:00
David Wittman
34e7d9c938 Fix multiple issues with alternatives module
- Changes are no longer erroneously reported on RHEL (#12)
 - Adding new link groups on Debian works again.
   - This was broken in a previous commit by assuming the OS was RHEL
     if `update-alternatives --query <name>` had a return code of 2
 - Prefer `--display` over `--query` for determining available
   alternatives
   - --display is more distro-agnostic and simplifies the code
 - Fix missing `msg=` in `fail_json` call when `link` is missing
 - Document that `link` is required on RHEL-based distros

Tested on Ubuntu 12.04+ and CentOS 6/7
2015-03-13 23:16:44 -05:00
Toshio Kuratomi
8baba98ebe Don't know why but the 1.8.x branch didn't include the commit for crypttab.
Update documentation to show it is new in 1.9 as a result of that
oversight.
2015-03-11 11:07:33 -07:00
Dmitry Bashkatov
19d51a51db gluster_volume: remove redundant code 2015-03-11 17:22:38 +03:00
Dmitry Bashkatov
26c2080dcf gluster_volume: use force option during add-brick 2015-03-11 16:40:22 +03:00
Dmitry Bashkatov
c6448660a3 gluster_volume: fixes, new "force" option 2015-03-11 10:54:13 +03:00
Richard Gray
7c40201c3d Set default for locale_gen state parameter
Fix the state parameter for the locale_gen module to be non-mandatory
with a default value of 'present', as indicated by the module
documentation.
2015-03-07 21:24:32 +13:00
Matthew Vernon
7a9e6aee90 Changes from Brian Coca's review of this module
These are all the code changes from Brian's review:
* change #! line
* rename "host" to "name" [keep as alias]
* make documentation clearer
* imports 1 per line
* use get_bin_path to find ssh-keygen
* key not actually required when removing host
2015-03-06 18:24:32 +00:00
Matthew Vernon
d821a39131 known_hosts: manage ssh known_hosts files with ansible.
The known_hosts module lets you add or remove a host from the
known_hosts file. This is useful if you're going to want to use the
git module over ssh, for example. If you have a very large number of
host keys to manage, you will find the template module more useful.

This was pull request 7840 from the old ansible repo, which was
accepted-in-principle but not yet merged. The mailing list thread
reading it is:

https://groups.google.com/forum/#!topic/ansible-devel/_e7H_VT6UJE/discussion
2015-03-06 18:24:32 +00:00
Brian Coca
41ddb689db Merge pull request #182 from misho-kr/devel
fix lvol module to properly query the size of logical volumes
2015-03-06 11:53:33 -05:00
Brian Coca
405bb040f8 Merge pull request #285 from fuglu/devel
svc: Add kill command (svc -k)
2015-03-03 08:07:07 -05:00
Brian Coca
650d740a3a Merge pull request #196 from alxgu/lvol_fix_casesensitivity
Bugfix PR for lvol: Cast size(LogicalVolumeSize) to lower .
2015-02-26 08:46:07 -05:00
Benjamin Kluck
8a5297c535 svc: Add kill command (svc -k) 2015-02-25 18:24:18 +01:00
Brian Coca
9f11d10135 Merge pull request #181 from sterfield/devel
Allow every type of locales + archlinux fix
2015-02-17 13:45:12 -05:00
SkaveRat
8eabcdcbc6 Fix missing restart method
Script was missing the restart command
2015-02-12 22:22:31 +01:00
Kai de Haan
e4f57eae44 svc: Ensure python 2.5 compatibility
* eg. debian lenny
2015-02-12 20:46:20 +01:00
Brian Coca
9219797bb5 Revert "Add listsnapshots property to zfs" 2015-02-12 10:17:56 -05:00
Brian Coca
5148a88e2c Merge pull request #88 from queeno/facter_should_return_puppet_custom_facts
Facter module should return custom facts
2015-02-11 17:32:57 -05:00
Brian Coca
83c051dfd5 Merge pull request #248 from bcoca/fix_alternatives
now properly checks that link is suplied before trying to use it
2015-02-11 17:32:00 -05:00
Brian Coca
c7e3aee0f0 now properly checks that link is suplied before trying to use it
should fix #46
2015-02-11 17:21:35 -05:00
Kelley Reynolds
92c30c7c41 Add listsnapshots property to zfs 2015-02-11 17:16:41 -05:00
Brian Coca
3f78475cae daemontools module 2015-02-11 12:35:43 -05:00
Misho Krastev
d11e36589a Merge branch 'upstream_devel' into devel
Conflicts:
	system/lvol.py
2015-01-24 22:13:53 -08:00
Hiroshi Umehara
759e032473 Generalize locale name normalization 2015-01-22 12:07:10 +09:00
Rob White
adb1f0a1c8 Convert symlinks specified in pvs to actual path 2015-01-22 13:37:37 +11:00
Hiroshi Umehara
42f79478a7 Add EUC-JP locale name normalization
The function normalizes checks for UTF-8, but the same issue exists for
other locales as well.  This fix adds normalization for EUC-JP, a Japanese
locale.
2015-01-21 16:10:12 +09:00
Pierre-Louis Bonicoli
40298a8f24 remove unused variable 2015-01-12 19:02:30 +01:00
Pierre-Louis Bonicoli
25f595c2ba Avoid to use the builtin 'echo'
By default, the interpretation of escape characters could be disabled (bash)
or enabled (dash).
2015-01-12 18:52:25 +01:00
Alexander Gubin
e15fba5156 lvol: Cast size(LogicalVolumeSize) to lower to fix the difference between lvs and lvcreate 2015-01-12 17:43:51 +01:00
Brian Coca
ffa8abf979 Merge pull request #120 from alxgu/lvol_fix_path
Fix lvol: Find LVM commands in PATH env - Bugfix Pull Request
2015-01-09 16:04:45 -05:00
Yuri Kunde Schlesner
1d60d33dc1 crypttab: Fix parameter checking with state=absent
Only the `name` parameter is required when removing an entry, but the module tried to ensure at least one other parameter was set.
2015-01-08 21:44:58 -02:00
Bert Mertens
3981872375 Fix getent behaviour with fail_key=False 2015-01-06 09:57:30 +01:00
Toshio Kuratomi
d4f5b6d41a Fixes for docs building 2015-01-05 08:40:57 -08:00
Misho Krastev
5acc634549 fix lvol module to properly query the size of logical volumes 2015-01-05 01:52:20 -08:00
Sterfield
48ecbd037e Missing import re
I don't even know how it magically worked, but the fact is the code was
correct, and ran OK without the import re.
2015-01-03 22:24:27 +01:00
Sterfield
c9656ff3b4 Now allow every type of locales + archlinux fix
The previous version of this code was supporting only locales using the
format "<language>_<territory>.<charset>". But all the locales that
doesn't have this format were not installable (such as "fr_FR" or
"fr_FR@euro").
Also, if an invalid locales was provided, the module kept sending a
"changed" status.

Now :
 * if the user provides an invalid locales, the module failed. Locales
   are verified using /etc/locale.gen or /usr/share/i18n/SUPPORTED if
   Ubuntu
 * Every types of valid locales are now supported.
 * The locale module was not working on Archlinux, as there's no space
   between the "#" and the locale. This is now supported. Credits goes
   to danderson189, this is his code.

This module was tested on debian jessie, ubuntu 14 LTS and last
Archlinux.
2015-01-03 18:01:13 +01:00
Brian Coca
3e7da5366b Merge pull request #176 from bcoca/gluster_volume_docfix
fixed doc bug
2015-01-02 14:22:23 -05:00
John Barker
9efac37b1b Add a note about debconf passwords always being recorded as changed 2014-12-31 22:10:18 +00:00
Brian Coca
2e6b94047d fixed doc bug 2014-12-30 19:53:59 -05:00
Nikolai Lifanov
1be1aacadf fix at.py module on non-glibc systems 2014-12-17 10:09:36 -05:00
Cosmo Petrich
443d7683a0 Remove default from 'permanent' and 'state' docs
These fields are both required, and thus do not actually have defaults.
2014-12-12 18:49:19 +11:00
Brian Coca
108db556a0 Merge pull request #136 from bcoca/gluster_revamp
revamp of gluster volume management
2014-12-11 20:55:23 -05:00
Brian Coca
fdd41fb95c Merge pull request #1 from mscherer/devel
Add a new option immediate= to immediately apply a permanent change
2014-12-11 20:47:48 -05:00
Brian Coca
6725d5188d revamp of gluster volume management
also implemented deleting a volume
2014-12-06 19:08:07 -05:00
Toshio Kuratomi
19e688b017 Fixes to documentation 2014-12-03 08:16:11 -08:00
Michael Scherer
62cae242cf Add a new option immediate= to immediately apply a permanent change
Currently, either you apply the change in the configuration
of firewalld ( without permanent=True ), or you apply it live.
I most of the time want to do the 2 at the same time, ie open the
port ( so I can use the service ) and make sure it stay open on reboot.
2014-12-01 19:51:11 +01:00
Brian Coca
9e798ec6bc Merge pull request #48 from rosmo/glusterfs-module
Added GlusterFS module.
2014-12-01 11:50:06 -05:00
Brian Coca
52f526c360 Merge pull request #17 from abompard/devel
Module alternatives: support RedHat-based OSes
2014-12-01 11:35:32 -05:00
Brian Coca
cbfabba9e3 Merge pull request #7 from groks/crypttab-module
New crypttab module for editing Linux /etc/crypttab file
2014-12-01 11:33:45 -05:00
Alexander Gubin
20ef2696bc Fix lvol: Find LVM commands in PATH env 2014-11-26 11:27:29 +01:00
Brian Coca
e64751b0eb Merge pull request #53 from bcoca/getent_doc_fixes
corrected and made better docs for getent
2014-11-20 15:49:33 -05:00
Sebastian Gumprich
040135dbba Added documentation and example for port ranges.
Also added punctuation marks.
2014-11-20 20:48:41 +00:00
Brian Coca
664858ec20 Merge pull request #56 from filipenf/fix-lvg
LVG module fix when using multiple devices (string to list)
2014-11-06 15:26:37 -05:00
Taneli Leppä
2d495f7e6e Added .py extension to glusterfs module. 2014-10-27 11:31:37 +02:00
Simon Aquino
4dd6c8204a Facter module should return custom facts
The ansible facter module should also return puppet custom facts by
default.
2014-10-21 23:47:03 +01:00
Chris West
613b3bdda0 Enable "ufw default allow routed"
* The policy is shown in `status verbose`, so all the check mode stuff should keep working.
 * `--dry-run` works as expected.
 * No idea whether it's legal as an argument to `interface`
2014-10-12 12:43:50 +01:00
Filipe Niero Felisbino
6cfb97a1c8 Replace dev_string to dev_list 2014-10-06 12:49:20 -03:00
Brian Coca
b0d5733fd0 corrected and made better docs for getent 2014-10-04 10:21:26 -04:00
Taneli Leppa
6dc09c966c Added GlusterFS module. 2014-10-03 10:25:58 +03:00
Baptiste Mispelon
827da3ae1a Fixed typo in locale_gen documentation. 2014-10-02 16:42:13 +02:00
jravetch
c89ce9e8d7 mkfs.xfs uses -f instead of -F flag
mkfs.xfs uses the -f instead of -F flag to force creating a filesystem on a devices that have an existing filesystem
2014-09-29 15:40:58 -07:00
Aurélien Bompard
6b5aa62854 Module alternatives: support RedHat-based OSes
RedHat-based OSes have a version of update-alternatives which comes from
the chkconfig package and does not support the --query parameter. Work
around that.
2014-09-30 00:38:56 +02:00
Aurélien Bompard
b645dd330c Module alternatives: support check mode 2014-09-30 00:38:54 +02:00
Steve
26f58a8eb7 New crypttab module for editing Linux /etc/crypttab file 2014-09-29 01:11:11 +01:00
Michael DeHaan
110250d344 package files 2014-09-26 11:04:10 -04:00
Michael DeHaan
b1e789968b File extensions! 2014-09-26 10:40:16 -04:00
Michael DeHaan
50f105578a Restructuring. 2014-09-26 10:14:28 -04:00
Michael DeHaan
73123b69fa Move modules into subdirectory. 2014-09-26 09:23:50 -04:00
Toshio Kuratomi
8b81062be0 The fix for gh-7284 causes problems for initscripts which have the
standards compliant return codes but return a verbose error message via
stdout.  Limit the times when we invoke the heuristic to attempt to work
around this.
2014-09-22 14:53:07 -04:00
Michael Scherer
c9a0a7ae4b Fix #9704, correctly set changed as false when nothing is done 2014-09-21 14:55:31 +02:00
Toshio Kuratomi
7b100dd389 Be more specific in checking if a job restarted successfully.
Fixes: #9056
2014-09-19 12:03:27 -07:00
Toshio Kuratomi
36083c3b90 Failure to enable a service now fails the task
Fixes: 8855
2014-09-18 12:39:54 -07:00
Toshio Kuratomi
a50258d26a remove debugging that was causing failure 2014-09-17 10:25:54 -07:00
Toshio Kuratomi
2e16bd3a44 Refactor the Linux service_enable() method
* Fix check_mode for initctl systems

Fixes #9009
2014-09-17 09:34:33 -07:00
Toshio Kuratomi
104401805b Revert "Refactor the Linux service_enable() method" needs some debugging
This reverts commit e294e31fd3.
2014-09-17 09:17:33 -07:00
Toshio Kuratomi
c362902f50 Refactor the Linux service_enable() method
* Fix check_mode for initctl systems

Fixes #9009
2014-09-17 08:44:32 -07:00
Toshio Kuratomi
a9928492f7 Make systemd vs rht detection more robust for centos
Centos 6.x and below use an old RHT style of configuring hostname.
CentOS 7.x and better use systemd.  Instead of depending on the
distribution string which seems to have changed over the course of 6.x
we need to explicitly check the version.

Fixes #8997
2014-09-16 09:53:13 -07:00
James Cammarata
7edcf21bdc Move initscript rc check to later in service status check
Fixes #7284
2014-09-11 12:11:06 -05:00
Michael DeHaan
5aa6ddef7f Tracebacks are now catchable with ignore_errors and have streamlined output. Also removes 'baby-JSON' for bash modules. 2014-09-11 12:27:21 -04:00
Patrik Lundin
0abf14ff19 service: use self.changed in service_enable_rcconf().
This sets the "changed" result of the module when a rc file is modified.
Previously only --check mode would show that it was going to change.
2014-08-28 00:52:23 +02:00
James Cammarata
30d6713bf0 Add additional checks to detect upstart services
Also adds checks for the upstart version, in order to test check
support for manual vs. start on manual
2014-08-25 13:41:39 -05:00
Eri Bastos
6f8a29dc3d Proposed fix for issue #7757 2014-08-25 12:10:14 -05:00
James Cammarata
c8376e296f Tweaking change to documentation language for cron name param 2014-08-25 09:54:21 -05:00
James Cammarata
509761249c Merge branch 'devel' of https://github.com/mattparker/ansible into mattparker-devel 2014-08-25 09:51:17 -05:00
James Cammarata
07e77c5bed Merge pull request #8740 from mattparker/patch-1
Name appears to be a required parameter for cron module
2014-08-25 09:49:58 -05:00
James Cammarata
1f2727c607 Merge pull request #8729 from ercpe/openrc-hostname
Hostname strategy implementation for OpenRC based systems (e.g. Gentoo)
2014-08-25 09:28:29 -05:00
Matt Parker
6086c505fe Update cron documenation
The "name" parameter seems to be rather important as the identifying feature of a cron job.  This is an update to the documentation to further emphasize this.
2014-08-25 10:29:45 +01:00
Matt Parker
5accd15ba6 Name appears to be a required parameter
As far as I can tell, `name` is a required parameter.  The guard test at (now) line 458 says you need name if `state == present` and at 464 if `state != present`, although that's not quite as clear.  Each of the code paths at 485 - 495 pass the name param through to `add_job`, `update_job` and `remove_job`, and the actual _update_job method earlier seems to require it too.  However I don't really know python so I may be wrong, but I can't see the circumstances when `name` is not required.
2014-08-25 10:23:54 +01:00
Johann Schmitz
7ef67e3f8b Hostname strategy implementation for OpenRC based systems (e.g. Gentoo) 2014-08-23 09:00:28 +02:00
Ding Deng
85c6434262 debconf module: add the missing 'error' vtype and reorder vtypes as they appeared in debconf-devel(7). 2014-08-19 17:44:02 +08:00
Michael DeHaan
60ce2d3853 Fix documentation builds. 2014-08-08 15:12:10 -04:00
Michael DeHaan
f21d6c7980 Merge pull request #8002 from prune998/patch-2
added missing force flag on mkfs commandline
2014-08-08 13:55:19 -04:00
Michael DeHaan
185d5a6221 Merge branch 'spelling' of git://github.com/cgar/ansible into devel
Conflicts:
	docsite/rst/guide_rax.rst
	plugins/callbacks/mail.py
2014-08-08 13:28:45 -04:00
Michael DeHaan
66ec9089bd Update docs. 2014-08-08 11:51:27 -04:00
Michael DeHaan
f6f184b36d Updating docs. 2014-08-08 11:51:27 -04:00
Brian Coca
aeeefd046f bumped to 1.7 2014-08-08 11:51:27 -04:00
Brian Coca
5aa2ca762a added control to fail or not on missing key
made split 'smarter' but still overridable
2014-08-08 11:51:27 -04:00
Brian Coca
391f8ec600 added getent module to get system data as facts 2014-08-08 11:51:27 -04:00