cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
26061 commits 47 branches 390 tags 440 MiB
Commit graph

12676 commits

Author SHA1 Message Date
Björn Andersson + SU Sheng Loong
469bf9ebd0 monit: Add retry for pending/initializing services 
If there are already ongoing actions for a process managed by monit, the
module would exit unsuccessfully. It could also give off false positives
because it did not determine whether the service was started/stopped
when it was in a pending state. Which might be turning the service off,
but the action was to start it.

For example "Running - pending stop" would be regarded as the service
running and "state=enabled" would do nothing.

This will make Ansible wait for the state to finalize, or a timeout decided
by the new `max_retries` option, before it decides what to do.

This fixes issue #244.
 2016-12-08 11:33:38 -05:00
Michal Svab
5f743c4fdc maven_artifact: check whether snapshot is the latest snapshot 2016-12-08 11:33:38 -05:00
Matthew Jones
d24f02fd39 Fix up vsphere_copy after open_url change 
* Remove leading module parameter on open_url call as it's no longer used
  by module_utils.urls.open_url
* Force basic auth otherwise vsphere will just return a 401
 2016-12-08 11:33:38 -05:00
twmartin
33ee8d6f89 Correct 'object not iterable' TypeError 2016-12-08 11:33:38 -05:00
Bruce Pennypacker
e5970186ad Remove extraneous space from end of command string in nagios_cmd 2016-12-08 11:33:38 -05:00
daveres
ab7aa73cdb Correct problem with changed:true 
I have just changed a small piece of this module to avoid to return always that the task is changed
 2016-12-08 11:33:38 -05:00
Chrrrles Paul
0606233431 Changing docs to reflect vm_name as the default vm_id_type 2016-12-08 11:33:38 -05:00
Rob
103be7ab51 Added missing else statement that caused existing rules to be discarded 2016-12-08 11:33:38 -05:00
Charles Paul
caea50ba4d pep8 whitespace 2016-12-08 11:33:37 -05:00
Charles Paul
a1efe9486a upped version added, search by vm_name by default 2016-12-08 11:33:37 -05:00
Ritesh Khadgaray
8f362afc34 vmware_vm_shell: add the ability to start program without network connection 2016-12-08 11:33:37 -05:00
Toshio Kuratomi
6f40bab20f Simplify code 2016-12-08 11:33:37 -05:00
Guido Günther
13deae9b8f zypper: Add returncode to result 
This will be used in integration tssts and makes the whole thing
more similar to the yum module.
 2016-12-08 11:33:37 -05:00
Gordon Fierce
c23162c04b Fix documentation to prevent formatting error where each letter has its own line. 2016-12-08 11:33:37 -05:00
Brian Geihsler
30da816c54 Fix #1101: win_webpicmd strict mode fixes 2016-12-08 11:33:37 -05:00
Brian Coca
c60d6cad72 corrected version added to 2.1 2016-12-08 11:33:37 -05:00
Rob
f547c37db4 Use doc fragment and fix examples 2016-12-08 11:33:37 -05:00
Rob
2b0fc33fd5 Tolerate missing classic_link_enabled attribute 2016-12-08 11:33:37 -05:00
whiter
a873e9a3cb New module - ec2_vpc_net_facts 2016-12-08 11:33:37 -05:00
Atsushi Sasaki
6278cef67b Enable to resize a volume with cs_volume 2016-12-08 11:33:37 -05:00
gfrank
5b3363d178 Replace slashes in the parameter string Also remove duplicate documentation 2016-12-08 11:33:37 -05:00
Michael Scherer
4e4085ad7e Add a more explicit error message, fix #1282 2016-12-08 11:33:37 -05:00
Adam Keech
28baed011d Appending "Registry::" is not needed and no longer works. 2016-12-08 11:33:37 -05:00
Guillaume Grossetie
af12e6d3a3 Resolves #1312, Improve pam_limits documentation 
Adds comment parameter and improve examples.
 2016-12-08 11:33:37 -05:00
Michael Weber
bee443c983 Fix error 'fail_json() takes exactly 1 argument' 
Fixes bug #1257
 2016-12-08 11:33:36 -05:00
Josh Gachnang
058feb47c2 Fix mongodb_user docs typo 
Bob's last name is Belcher: http://bobs-burgers.wikia.com/wiki/Bob_Belcher.

These docs made me chuckle, so thanks :)
 2016-12-08 11:33:36 -05:00
Toshio Kuratomi
5bd1bcaa2d Don't raise or catch StandardError in amazon modules 2016-12-08 11:33:36 -05:00
GUILLAUME GROSSETIE
5fbc5cb529 Resolves #1290, Adds limit_type choice "-" 2016-12-08 11:33:36 -05:00
Rene Moser
2715cbffb7 cloudstack: new module cs_volume 2016-12-08 11:33:36 -05:00
Xav Paice
f30dbc9b20 Added stdout and stderr to puppet output for rc=2 2016-12-08 11:33:36 -05:00
Tom Bamford
fa9e1fd384 Ensure tag values get updated in ec2_vpc_subnet 2016-12-08 11:33:36 -05:00
Ryan Sydnor
1899e9e6cc Use boto normalized location for bucket creation 
If a bucket is being created in us-east-1, the module passed
'us-east-1' to boto's s3.create_bucket method rather than
Location.DEFAULT (an empty string). This caused boto to generate
invalid XML which AWS was unable to interpret.
 2016-12-08 11:33:36 -05:00
Hans-Joachim Kliemeck
b3ffcd7c6c fix race condition and missing property 2016-12-08 11:33:36 -05:00
Jiri tyr
d4d24bac60 Adding yumrepo module 
This patch is adding a new module which allows to add and remove YUM
repository definitions. The module implements all repository options
as described in the `yum.conf` manual page.
 2016-12-08 11:33:36 -05:00
Brian Coca
4ddb181d71 removed json import 2016-12-08 11:33:36 -05:00
Toshio Kuratomi
f68b88b84d Quote strings that make the module docs fail to build 2016-12-08 11:33:36 -05:00
Toshio Kuratomi
d6db0f3981 Switch StrictVersion for LooseVersion since some distros ship beta versions and StrictVersion would fail on that. 
Also clean up some minor style things
 2016-12-08 11:33:36 -05:00
Olaf Kilian
c048990419 Add requirement and check for compatible version of docker-py 2016-12-08 11:33:36 -05:00
Olaf Kilian
64838bb52d Set no_log for password argument 2016-12-08 11:33:35 -05:00
Olaf Kilian
7c8d1a1d0a Improve registry key parity between clients * Don't extract hostname part from docker_url since this leads to docker CLI client not recognizing Docker Hub credentials set by docker_login module anymore (looks for the full URL as a key). 2016-12-08 11:33:35 -05:00
Olaf Kilian
b826aa6b35 Rework change detection 2016-12-08 11:33:35 -05:00
Olaf Kilian
348cab4511 Adapt to new dockercfg file location and structure 2016-12-08 11:33:35 -05:00
Olaf Kilian
d330f72213 Make module importable for unit tests 2016-12-08 11:33:35 -05:00
Olaf Kilian
32862e737f Set default for email parameter to None 2016-12-08 11:33:35 -05:00
Olaf Kilian
dab1588253 Add requirement for python >= 2.6 2016-12-08 11:33:35 -05:00
Olaf Kilian
4ea0125dc6 Default registry to docker hub 2016-12-08 11:33:35 -05:00
Olaf Kilian
a64bae30b5 Added more meaningful fail messages on Docker API 2016-12-08 11:33:35 -05:00
Olaf Kilian
dfaa1ec528 Added default email address 2016-12-08 11:33:35 -05:00
Olaf Kilian
36330d00ad Removed unused import of sys module 2016-12-08 11:33:35 -05:00
Olaf Kilian
e998090d52 Extract only the hostname part from self.registry This is needed for update_dockercfg() to register only the host part of a specified registry URL in the .dockercfg. 2016-12-08 11:33:35 -05:00
Olaf Kilian
c42d94edd1 Remove registry from exit_json because misleading docker-py is not returning the name of the registry if already logged in. It can differ from the registry specified by the user, which was return as registry. 2016-12-08 11:33:35 -05:00
Olaf Kilian
9d69e78f18 Update PR based on review from @resmo 2016-12-08 11:33:34 -05:00
Olaf Kilian
d23f78c799 Add docker_login module - Ansible version of "docker login" CLI command - Persists Docker registry authentification in .dockercfg (only login once - no need to specify credentials over and over again anymore) - Works for all other docker-py based modules (docker, docker_images) as well as the Docker CLI client 2016-12-08 11:33:34 -05:00
Romain Brucker
e8b5b8bd20 Editing iptable module to use -m state --state instead of -m conntrack --ctstate 2016-12-08 11:33:34 -05:00
Alberto Gireud
a7b90cf456 Fix return documentation 2016-12-08 11:33:34 -05:00
Alberto Gireud
bbdebd7548 Add openstack project module 2016-12-08 11:33:34 -05:00
Jonathan Davila
66569ab725 Sendgrid docs fix 2016-12-08 11:33:34 -05:00
Brian Coca
507986703c corrected choices which was meant to be type 2016-12-08 11:33:34 -05:00
James Cammarata
df517b5f03 Version bump for new beta 2.0.0-0.5.beta3 2016-12-08 11:33:34 -05:00
Jonathan Mainguy
c277a8b191 Added style= and more colors. 2016-12-08 11:33:34 -05:00
YAEGASHI Takeshi
ae72b7c12c New module: blockinfile 2016-12-08 11:33:34 -05:00
Indrajit Raychaudhuri
92efb6eb51 homebrew: Aditional examples for documentation 2016-12-08 11:33:34 -05:00
Indrajit Raychaudhuri
273d1c51e6 homebrew: Add explicit documentation for 'path' argument (with expected default) 
In Homebew, a formula is installed in a location relative to the actual
`brew` command. The documentation clarifies that.

Additionally, removed redundant 'path' reconstruction in multiple places.
 2016-12-08 11:33:34 -05:00
Caduri
a364ec5483 exchange name contains chars that needs to be quoted 2016-12-08 11:33:34 -05:00
Joel Thompson
5bedb1f12d Add sns_topic module to manage AWS SNS topics 
This adds an sns_topic module which allows you to create and delete AWS
SNS topics as well as subscriptions to those topics.
 2016-12-08 11:33:34 -05:00
Etherdaemon
0fbfcc3b20 Add new module to allow for getting and listing of Route53 relevant details 2016-12-08 11:33:34 -05:00
Kenny Gryp
c908c0663d revert to unbreak pull request 2016-12-08 11:33:34 -05:00
Kenny Gryp
c766cbd98a in order for replication setup to work, some errors should be ignored 2016-12-08 11:33:33 -05:00
Kenny Gryp
4e401fc4e6 including error code and error number when database connection creation fails 2016-12-08 11:33:33 -05:00
Robin Roth
85f2165273 better cope with rpm not returning package name 
if the rpm query is missing a package name (or giving some error): fail soft

before the patch: the module fails because the installed_state dict is missing the package name

after the patch: the missing package is assumed to not be in the correct state and is installed/removed with zypper
 2016-12-08 11:33:33 -05:00
xiaclo
b36b12e968 Allow NPM to update packages 2016-12-08 11:33:33 -05:00
Ritesh Khadgaray
83bf44c78f allows user to not update zabbix host config if host is present. 2016-12-08 11:33:33 -05:00
Kerim Satirli
9802112dd4 fixes a typo in Datadog Monitor docs 2016-12-08 11:33:33 -05:00
Jimmy Tang
40e6b3870e Fix documentation, the correct parameter is "name" 2016-12-08 11:33:33 -05:00
root
4e72c23bae Fixed call to module.log 2016-12-08 11:33:33 -05:00
Greg DeKoenigsberg
f475a123c0 Add new SMEs for Zabbix 2016-12-08 11:33:33 -05:00
wimnat
482f0a8d1c Prevent ec2_remote_facts from failing when listing a terminated instance 2016-12-08 11:33:33 -05:00
Romain Brucker
3ef5be470f Fixing limit type from list to string 2016-12-08 11:33:33 -05:00
Romain Brucker
fbad76e86a Adding limit feature to iptables module 2016-12-08 11:33:33 -05:00
Brian Coca
61ba4b98e1 made ctstate default to [] and evaluation conditional on the list being popoulated 2016-12-08 11:33:33 -05:00
Brian Coca
fb3aec47ca fixed default from None to [] for ctstate 2016-12-08 11:33:33 -05:00
Brian Coca
eae8942583 avoid index error on empty list, key being true means its not None nor [] fixes #13009 2016-12-08 11:33:33 -05:00
pmakowski
9ab42a98ca no-suggests is obsolete, switch to no-recommends 2016-12-08 11:33:33 -05:00
Henrik Wallström
2b860bbae8 Adds examples for win_iis_virtualdirectory 2016-12-08 11:33:32 -05:00
whiter
d8dc9485f4 Refactor ec2_remote_facts to use filters 2016-12-08 11:33:32 -05:00
Henrik Wallström
6d166d75bc Fix: support for virtual directories in applications 2016-12-08 11:33:32 -05:00
Adam Keech
b8fbbdbff0 Fixing Some Issues with out Parameters are passed around. Also some refactoring. 2016-12-08 11:33:32 -05:00
Hans-Joachim Kliemeck
3ad86e383e added start mode feature 2016-12-08 11:33:32 -05:00
Hans-Joachim Kliemeck
b2f666a2dd strict variables fix 2016-12-08 11:33:32 -05:00
Hans-Joachim Kliemeck
349c4a2a48 added dependency and user settings 2016-12-08 11:33:32 -05:00
nitzmahone
51b1cd061a Strict-Mode fixes 
Changes to missing member handling to support running top-level script under Strict-Mode v2 (as Ansible 2.0.0 does now)
 2016-12-08 11:33:32 -05:00
Kirill Kozlov
426613b00d Fix broken examples in docs 2016-12-08 11:33:32 -05:00
Brian Coca
42a27ce558 added missing : to docs 2016-12-08 11:33:32 -05:00
Brian Coca
eb4fe5a0d8 made ctstate accept lists 2016-12-08 11:33:32 -05:00
Daniel Vigueras
d332a9a8e4 Add conntrack module ctstate support to iptables 2016-12-08 11:33:32 -05:00
Toshio Kuratomi
a47427cddf Return errno and http status as requested by @bcoca 2016-12-08 11:33:32 -05:00
Toshio Kuratomi
24ce8887bf Better status conditional from dagwieers 2016-12-08 11:33:32 -05:00
Toshio Kuratomi
117f640bb9 Port vsphere_copy from httplib to open_url for TLS cert validation 2016-12-08 11:33:32 -05:00
Javier Palacios
185761bfcb BUGFIX: misnamed function name breaks check mode 2016-12-08 11:33:32 -05:00
Ramunas Dronga
86bea2d6ab fixed composer usage example 2016-12-08 11:33:31 -05:00
Ramunas Dronga
ae18a1d877 added constraint for space in composer command 2016-12-08 11:33:31 -05:00
Ramunas
662fa86f07 removed check for empty composer response 2016-12-08 11:33:31 -05:00
Ramunas Dronga
6e4b42ebbc added version info for params 'arguments' 2016-12-08 11:33:31 -05:00
Ramunas Dronga
ae59ea7deb allow specify arguments for composer 2016-12-08 11:33:31 -05:00
Toshio Kuratomi
8c8c63110e Move existing check for root before we make expensive network calls 2016-12-08 11:33:31 -05:00
Brian Coca
8e255afbec switched to 'support check mode' as it does not make changes and gathers information that might be needed for other tasks to check 2016-12-08 11:33:31 -05:00
Rene Moser
83021279a1 new module ipify_facts 2016-12-08 11:33:31 -05:00
Brian Coca
b7372b509a corrected extension in module spec fixes #1190 2016-12-08 11:33:31 -05:00
Brian Geihsler
92cbe5be0e Fix #1107: Prepend registry type on key path 2016-12-08 11:33:31 -05:00
Brian Geihsler
6fed60c1bd Fix #1107: Use Get-Attr in win_regedit 2016-12-08 11:33:31 -05:00
Monty Taylor
9b9464ab89 Revert "Change show_diff to default to yes" 
This was originally to match what puppet agent --test is, since the
rest of the options defaulted to on are grabbed from --test. However,
some security concerns have since been raised - namely that since this
is not the same invocation as --test but instead a remote orchestration
of puppet, the fact that passwords leak into the diff is a dangerous
default.

This reverts commit b86762c180.
 2016-12-08 11:33:31 -05:00
Trond Hindenes
d90f91e802 Various improvements to win_package 2016-12-08 11:33:31 -05:00
Toshio Kuratomi
9c75b5eac3 Make the pkg/name param into a list so that changes to make changes to _squash_items easier 2016-12-08 11:33:31 -05:00
Rene Moser
682b7ce3bd cloudstack: cs_portforward: fix example does not match description 2016-12-08 11:33:31 -05:00
Brian Coca
29fad0223d whitespace fixes 2016-12-08 11:33:30 -05:00
Romain Brucker
e4ce38fa0b Adding comment support for iptables module 2016-12-08 11:33:30 -05:00
Brian Coca
50905e5673 fixed typos in cryptab, thanks @timw fixes #1176 2016-12-08 11:33:30 -05:00
Siva Popuri
c3ecf5a0bf added author to module doc string. 2016-12-08 11:33:30 -05:00
Siva Popuri
34ba9fa4f8 Added RETURN doc string for all modules and few minor enhancements. 2016-12-08 11:33:30 -05:00
Matteo Acerbi
e6fe4b10f5 Fix docs for ec2_vpc_route_table 
The documentation pointed to vpc_peering_connection, not vpc_peering_connection_id.
 2016-12-08 11:33:30 -05:00
Greg DeKoenigsberg
5c494fb37b Remove @lorin from list of reviewers 2016-12-08 11:33:30 -05:00
Corwin Brown
8e557dfc45 Made win_iis_webapppool Strict Compliant 2016-12-08 11:33:30 -05:00
Alexander
8e509c2736 fix typo error 
fix spell error for whether
 2016-12-08 11:33:30 -05:00
Matt Carroll
164e1f3baa Fix ZFS create 
This was failing due to the createparent variable being referenced but
never actually loaded from properties
 2016-12-08 11:33:30 -05:00
Brian Coca
d9a29f394f fixed missed passing use-sudo 2016-12-08 11:33:30 -05:00
Ondra Machacek
d43d4718f3 system: pam_limits: add support for unlimited/infinity/-1 
Early pam_limits module didn't support special values for items.
This patch is adding support to special values unlimited, infinity and -1.

Issue: https://github.com/ansible/ansible-modules-extras/issues/1033
Signed-off-by: Ondra Machacek <machacek.ondra@gmail.com>
 2016-12-08 11:33:30 -05:00
Jonathan Mainguy
451a05c1a2 Change show_diff to default to yes, to match what puppet agent --test is, since the rest of the options defaulted to on are grabbed from --test 2016-12-08 11:33:30 -05:00
james
c2a4e230aa More consistent use of run_command() wrapper function, which now adds the default binary location to the search path 2016-12-08 11:33:30 -05:00
James Cammarata
d26e062331 Version bump for new beta 2.0.0-0.4.beta2 2016-12-08 11:33:30 -05:00
Ramon de la Fuente
79352b5e38 module guideline changes 2016-12-08 11:33:29 -05:00
Ramon de la Fuente
c0b69067d7 added the folder structure and general explanation to examples, removed module name typo 2016-12-08 11:33:29 -05:00
Ramon de la Fuente
88ac3eca78 removed link to guide, and added more documentation and examples 2016-12-08 11:33:29 -05:00
Ramon de la Fuente
7841bf9c91 adding the deploy_helper module 2016-12-08 11:33:29 -05:00
M0ses
a1dbb83075 fix errorhandling in zypper.py module 
package_latest was calling package_present but did not care
about the return code so errors in package_present were hidden
and everthing look ok on the console when zypper update did not fail,
but no packages where installed.
 2016-12-08 11:33:29 -05:00
Brian Coca
d15b3776f0 added version_added to new feature, removed unused aliases 2016-12-08 11:33:29 -05:00
daniel-sc
04efe69c34 configurable timeout for creating gce image 2016-12-08 11:33:29 -05:00
Chrrrles Paul
6777f634d5 tpyo in doc string 2016-12-08 11:33:29 -05:00
whiter
5e529a6afc Use filters attribute rather than eni id so facts can be filtered on much more. Matches the new ec2_vpc_route_table_facts and ec2_vpc_subnet_facts modules 2016-12-08 11:33:29 -05:00
ogenstad
7c6175af3d lookupMib=False for pysnmp 4.3.0 2016-12-08 11:33:29 -05:00
Toshio Kuratomi
2dcbacd48e Fix doc build by moving misplaced CIDR documentation 2016-12-08 11:33:29 -05:00
Brian Coca
577566139f fixed undefined msg and now actually return something meaningful fixes #1127 2016-12-08 11:33:29 -05:00
Rene Moser
ea6fdeb585 cloudstack: add new loadbalancer rule modules 2016-12-08 11:33:29 -05:00
Shawn Siefkas
29d6313366 Handling dry run exception 2016-12-08 11:33:29 -05:00
Shawn Siefkas
253d177dc3 Check mode support for VPC route table creation 2016-12-08 11:33:29 -05:00
Christopher M. Fuhrman
5574516934 pkgin: Support multiple matching packages 
pkgin searches for packages such as 'emacs' can return multiple matches,
the first of which is not guaranteed to match.  So, iterate through
found packages until we have an appropriate match.  Should we *not* find
a match, then return False indicating match failure.
 2016-12-08 11:33:29 -05:00
Brian Geihsler
2f6f6cedf8 Fix #1099: Only populate site result when it is there 2016-12-08 11:33:28 -05:00
Siva Popuri
002fc53863 minor change to remove extra brackets 2016-12-08 11:33:28 -05:00
Siva Popuri
85c09c9944 fixed typos 2016-12-08 11:33:28 -05:00
Siva Popuri
d13e34e131 corrected a typo 2016-12-08 11:33:28 -05:00
Siva Popuri
56cdaba0ab ansible module for managing anti affinity policy in centurylink cloud has been added 2016-12-08 11:33:28 -05:00
Siva Popuri
843ad8e7e8 minor refactor to remove un-used parameter 2016-12-08 11:33:28 -05:00
Siva Popuri
fd09597267 removed empty aliases from doc string 2016-12-08 11:33:28 -05:00
Siva Popuri
a2c2efb2ae Corrected a typo 2016-12-08 11:33:28 -05:00
Siva Popuri
4a8e3e9632 ansible module for managing alert policy in centurylink cloud has been added 2016-12-08 11:33:28 -05:00
Siva Popuri
01847f7bfc Ansible module for managing server snapshots in Centurylink Cloud 2016-12-08 11:33:28 -05:00
Toshio Kuratomi
60c495f18c Fix win_acl docs build 2016-12-08 11:33:28 -05:00
Toshio Kuratomi
0111b616d7 Fix docs to build 2016-12-08 11:33:28 -05:00
Linus Unnebäck
ebfb8bc7cf iptables: add note about rules 2016-12-08 11:33:28 -05:00
Linus Unnebäck
8d93747275 iptables: expand rule options 2016-12-08 11:33:28 -05:00
Linus Unnebäck
1790722dd4 module: system/iptables 2016-12-08 11:33:28 -05:00
Phil
0524904dda fixes examples in docs to use updated param name 2016-12-08 11:33:28 -05:00
Phil
43074a736d changes param src to path, and updates docs accordingly 2016-12-08 11:33:27 -05:00
Phil
00a4ec5e3b updates user search verification for local/domain - Thanks to @trondhindenes for implementing this strategy - also updated documentation 2016-12-08 11:33:27 -05:00
Phil
9ad30acd96 changes check for src 2016-12-08 11:33:27 -05:00
Phil
6abfcffc70 check if the rule exists or not before allow/deny rules are added/removed, and fixes where result changed would be true on all executions. 2016-12-08 11:33:27 -05:00
schwartzmx
25a3793a49 inital commit win_acl 2016-12-08 11:33:27 -05:00
Brian Coca
a65647efee added version_added and fixed some doc parsing issues 2016-12-08 11:33:27 -05:00
Jeremy Wells
c8e0f3a552 Add consul http checks to consul.py 
Consul module already supports ttl and script checks. This commit adds
http checks.
 2016-12-08 11:33:27 -05:00
Steve
fea8995df1 Fix bug #1105 - incorrect use of lstrip() 
Remove only the literal prefix '/dev/mapper/' - not any of the characters
in '/dev/mapper/' - from the name param of the crypttab module.
 2016-12-08 11:33:27 -05:00
Brian Coca
d530764c49 fixed option in examples 2016-12-08 11:33:27 -05:00
Charles Paul
3913de1c43 reference instance_id in docs, fixes for calls to fail_json 2016-12-08 11:33:27 -05:00
Trond Hindenes
15ac8e9141 turned out strict msi code checking 2016-12-08 11:33:27 -05:00
Nicolas Landais
4fc4030c58 Adding fix to get around bug found with the New-Webstire command when running playbook on a vanilla machine. 2016-12-08 11:33:27 -05:00
Dreamcat4
40a1bd1962 fix: Add 'enable:' flag for enabling existing rules which are disabled by default. 
This is a very much needed flag. To turn on/off existing firewall rules. And like the recent fix of the 'Profile' key, the netsh cmd prints 'Enabled' in the textual output. (at least on win10 it does). So again a similar small code added for the necessary exception handling when the difference check happens.

Please merge / push upstream like the other fixes. Many thanks. This is the last fix I have put together for this patch set. So I will raise my PR now.

But if you want to fix more bugs, it seems there may be others. In terms of the control code. Sometimes it will delete a rule under 'force' condition (when found difference) - but instead it is supposed to just modify the existing rule. Some weird behaviour regarding that. The other problem is that ansible does not return the error text printed by 'netsh' cmd verbatim... but it should as that makes debugging these errors a *lot* easier.
 2016-12-08 11:33:27 -05:00
Dreamcat4
e0da4a3362 fix: update documentation with new module name "win_firewall_rule" 2016-12-08 11:33:27 -05:00
Dreamcat4
7188ae4fe1 fix: The names of firewall profiles are different on win10 & win2008r2 
Hi again. This commit removes a small portion of your script's own internal error checking. In specific: for the value of the profile: key. This is essential to avoid errors on other verisons of the windows operating system which are not win2008r2 (your version).

For example: on win10 (and most likely win8x too), the names of the profiles don't include the values 'current' and 'all'. But instead the values are 'Public' 'Private' 'Domain' and 'Any. But in addition, there are also certain combinatorial values, such as profile=Public,Private etc. Which is too many to error check yourself.

Yet removing the error checking here should not cause any ill effects however: since the netsh advfirewall ... cmds themselves to add / remove / modify actually to their own error checking of the profile=value. So when the cmd is run, it will error out itself with an appropriate / informative error msg. No harm done.

Therefore please remove the highlighed portions from your own script. It is essential for interoperability with win10 and win8x. Many thanks.
 2016-12-08 11:33:27 -05:00
Dreamcat4
f64e438150 fix: win10 - Add exception handling for 'Profiles:' textual output key name mismatch. 
In win10 (and pribably win8x also):

The output of 'show rule' key includes the line "Profiles:<TAB>Public,Private".
Yet your script expects the key name printed out to be "Profile:<TAB>value".

This commit added the necessary exception handling to avoid flagging 'different=true' under the false circumstance. The key name to SET a firewall rule is still "profile=" and not "profiles=".

There is coming up another commit to fix the value handling for win10/win8. Which is another (different) error with the profile: key.
 2016-12-08 11:33:26 -05:00
Dreamcat4
b9dd3568f3 fix: fw rule names must always be quoted, to permit spaces ' ' and brackets '()' 
Without this fix, the 'netsh' command gets name=Firewall Rule Name instead of name="Firewall Rule Name". Thus causing all sorts of havoc. Basic shell quoting rules seems to apply to Windows Powershell too. This is very much needed as many of windows 10's default firewall rules contain spaces and brackets () characters.
 2016-12-08 11:33:26 -05:00
Ramon de la Fuente
1d09eaf6d0 updated the examples to the new Slack API 2016-12-08 11:33:26 -05:00
Ramon de la Fuente
918012a42f module guidelines compliency 2016-12-08 11:33:26 -05:00
Stefan Berggren
aeb1090542 Add attachments support to slack module. 2016-12-08 11:33:26 -05:00
Kevin
b43329b6a0 Remove homebrew- prefix when checking if repo has already been tapped 
See: https://github.com/Homebrew/homebrew/blob/master/Library/Homebrew/cmd/tap.rb

Example:

```
$ brew tap neovim/homebrew-neovim
$ brew tap
neovim/neovim
...
```
 2016-12-08 11:33:26 -05:00
Luis Rodriguez
adedc7ef3f Fix bug #1067 2016-12-08 11:33:26 -05:00
Brian Coca
1426c3ba02 added missing GPL licences fixes #508 2016-12-08 11:33:26 -05:00
Michael Perzel
f84dc8fd5d Improve example wide_ip variable 2016-12-08 11:33:26 -05:00
Michael Perzel
9c8891740c Wrap main() in conditional 2016-12-08 11:33:26 -05:00
Michael Perzel
21425f36ef Update bigip_api method to use variable name server 2016-12-08 11:33:26 -05:00
Michael Perzel
6681a5b386 Style updates 2016-12-08 11:33:26 -05:00
Michael Perzel
ca0d4aad52 Module for managing F5 wide ip 2016-12-08 11:33:26 -05:00
Toby Fleming
3293fe7231 Homebrew: Allow colons, direct check for outdated formula 2016-12-08 11:33:26 -05:00
Indrajit Raychaudhuri
e115f62a2d homebrew: Also add 'formula' as alias for 'name' and reformat 2016-12-08 11:33:25 -05:00
Indrajit Raychaudhuri
c397dfe9ed homebrew: Improve 'argument_spec' handling 
- Remove choice list for boolean values in argument_spec and make it
  more consistent with core modules
- Add 'package' alias and support for list type for 'name' parameter
- Added self as maintainer
 2016-12-08 11:33:25 -05:00
jhawkesworth@users.noreply.github.com
17d1c8916d Document module limitations to resolve https://github.com/ansible/ansible-modules-extras/issues/908 2016-12-08 11:33:25 -05:00
Matt Martz
803d9695e0 sys.exit removal for system/capabilities.py 2016-12-08 11:33:25 -05:00
Matt Martz
a87cf4967e sys.exit removal for notification/mail.py 2016-12-08 11:33:25 -05:00
Matt Martz
e99a202ac5 sys.exit removal for cloud/google/gce_img.py and cloud/google/gce_tag.py 2016-12-08 11:33:25 -05:00
Matt Martz
7cb0d86c27 sys.exit removal for cloud/misc/ovirt.py 2016-12-08 11:33:25 -05:00
Matt Martz
950c951e06 sys.exit removal for cloud/xenserver_facts.py 2016-12-08 11:33:25 -05:00
James Cammarata
766ad0ace2 Updating version for 2.0.0-0.3.beta1 release 2016-12-08 11:33:25 -05:00
Matt Martz
9c4fae7e3f Fix open_iscsi EXAMPLES section 2016-12-08 11:33:25 -05:00