Commit graph

850 commits

Author SHA1 Message Date
Matt Parker
6086c505fe Update cron documenation
The "name" parameter seems to be rather important as the identifying feature of a cron job.  This is an update to the documentation to further emphasize this.
2014-08-25 10:29:45 +01:00
Matt Parker
5accd15ba6 Name appears to be a required parameter
As far as I can tell, `name` is a required parameter.  The guard test at (now) line 458 says you need name if `state == present` and at 464 if `state != present`, although that's not quite as clear.  Each of the code paths at 485 - 495 pass the name param through to `add_job`, `update_job` and `remove_job`, and the actual _update_job method earlier seems to require it too.  However I don't really know python so I may be wrong, but I can't see the circumstances when `name` is not required.
2014-08-25 10:23:54 +01:00
Johann Schmitz
7ef67e3f8b Hostname strategy implementation for OpenRC based systems (e.g. Gentoo) 2014-08-23 09:00:28 +02:00
Ding Deng
85c6434262 debconf module: add the missing 'error' vtype and reorder vtypes as they appeared in debconf-devel(7). 2014-08-19 17:44:02 +08:00
Michael DeHaan
60ce2d3853 Fix documentation builds. 2014-08-08 15:12:10 -04:00
Michael DeHaan
f21d6c7980 Merge pull request #8002 from prune998/patch-2
added missing force flag on mkfs commandline
2014-08-08 13:55:19 -04:00
Michael DeHaan
185d5a6221 Merge branch 'spelling' of git://github.com/cgar/ansible into devel
Conflicts:
	docsite/rst/guide_rax.rst
	plugins/callbacks/mail.py
2014-08-08 13:28:45 -04:00
Michael DeHaan
66ec9089bd Update docs. 2014-08-08 11:51:27 -04:00
Michael DeHaan
f6f184b36d Updating docs. 2014-08-08 11:51:27 -04:00
Brian Coca
aeeefd046f bumped to 1.7 2014-08-08 11:51:27 -04:00
Brian Coca
5aa2ca762a added control to fail or not on missing key
made split 'smarter' but still overridable
2014-08-08 11:51:27 -04:00
Brian Coca
391f8ec600 added getent module to get system data as facts 2014-08-08 11:51:27 -04:00
Serge van Ginderachter
961d4b0d6c execute the mount after path validation
This avoids a stale situation where name/path contains some impossible path,
but gets configured (faultly) in fstab, and the module only fails after that,
when creating that path.
2014-08-06 10:52:08 +02:00
Jonathan Mainguy
650003dd5c Fixes issue #8339 where Scientific Linux incorrectly tries to use FedoraStrategy of hostnamectl 2014-08-02 15:38:52 -04:00
Michael DeHaan
e978dcf7eb Merge pull request #8283 from ps-jay/sys_mount_fstype_doc
Add fstype arg to the mount examples
2014-07-30 08:28:59 -04:00
Michael DeHaan
bc01f2571e Merge pull request #8311 from neersighted/wrap_distroversion
Wrap get_distribution_version() in the hostname module
2014-07-28 15:48:18 -04:00
Michael DeHaan
2212b64fd9 Cleaning up explanation of mount module states. 2014-07-28 12:18:45 -04:00
Bjorn Neergaard
cbc417ca1b Wrap get_distribution_version() in the hostname module
We wrap get_distribution_version() with a new function,
_get_distribution_version(), that returns `0` when the result is a string or
`None`.

This accounts for the case when get_distribution_version() returns a string,
and we try to compare it to a float. We do this in the hostname module instead
of the module snippets because other modules may want the real string
version.module snippets because other modules may want the real string version.
2014-07-28 11:16:30 -05:00
Michael DeHaan
99ad691950 Merge branch 'ufw' of git://github.com/Trozz/ansible into devel 2014-07-28 12:08:29 -04:00
Michael DeHaan
caba7ac6a6 Merge pull request #7954 from alimony/patch-3
cron module: Use correct parameter name in error message.
2014-07-28 11:29:05 -04:00
James Cammarata
03f0d6bec8 Merge pull request #8308 from robinro/extend-hostname-distrolist
Extended distributions list for hostname module
2014-07-28 09:12:59 -05:00
Robin Roth
7920f4eaf5 Fix extra newline at end of hostname for Fedora
This fixes a bug introduced by 138b45e3.
The hostname has an additional newline at the end which leads to the
state always being 'changed: true' even if the hostname is unchanged.
2014-07-28 15:22:10 +02:00
Robin Roth
a26bc9c926 Extended distributions list for hostname module
Implementations already present
2014-07-28 15:19:41 +02:00
Tom Lazar
d89adce760 FreeBSD 10 compatibility fix
On FreeBSD the whitespace around the ``=`` triggers a (cryptic) ``no such file or directory`` error. removing the whitespace like above fixes this.
2014-07-25 14:33:24 +02:00
Philip Jay
bb7b290ed8 Add fstype arg to the mount examples
Needed fstype in the examples, since fstype is a required argument for
mount.
2014-07-25 09:58:54 +10:00
Berend de Boer
f46c4ee093 Default for fstab missing, causing KeyError: 'fstab' 2014-07-24 13:14:46 +12:00
James Cammarata
6879e4ff0a Merge pull request #8223 from renard/create-fstab-if-not-exists
Create fstab if not exists
2014-07-21 15:03:14 -05:00
Sébastien Gross
e0f7b3f39c [mount] make sure fstab exists
This is mainly to prevent from failing with no such file or directory
during module execution.
2014-07-21 18:32:02 +02:00
Sébastien Gross
806052a9e5 [mount] Add documentation for fstab option 2014-07-21 18:30:59 +02:00
Hector Acosta
60edb6b04b Add check_mode support to authorized_key. Fixes #7300
Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
2014-07-19 17:55:58 -05:00
Yasser Nabi
8cc894bef2 Enable puppet facts
Currently facter facts omit facts that a distributed via Puppet. This
commit adds the `--puppet` option.

In cases where puppet is not installed, the command sends a warning to
STDERR *but* completes successfully. So should not cause any issues.

The benefit is, filtering can be done based on facts set by Puppet.
2014-07-17 17:53:12 +01:00
Michael DeHaan
96fe275946 Merge pull request #8139 from peterkh/devel
Fix "TypeError: group id must be integer" if groupid passed in for group key
2014-07-16 15:55:14 -04:00
Ruggero Marchei
ae95ebd075 fix LooseVersion exception with empty distribution_version 2014-07-16 07:55:20 +02:00
Peter Hall
ae67002c15 Fix "TypeError: group id must be integer" if groupid passed in for group
key
2014-07-15 11:16:47 +10:00
Ruggero Marchei
8d01986617 fix issue #8102 2014-07-15 01:26:44 +02:00
Cristian Ciupitu
72d6e6d805 Remove useless code 2014-07-09 23:11:15 +03:00
Michael Leer
39b34b008c add interfact documentation #7704 2014-07-01 18:49:07 +01:00
Prune
afb358af77 added missing force flag on mkfs commandline
even if the option ```force=yes``` is used in the playbook, it is not reflected in the mkfs command line.
As force option is dependent of the fs type, a "if-then-else" case have been added. Also, some FS types does not have a force option.
2014-07-01 15:09:39 +02:00
Markus Amalthea Magnuson
a58709ac1d Use correct parameter name in error message.
The parameter is called `cron_file` but the error message uses `file` which is confusing.
2014-06-27 14:53:54 +02:00
James Cammarata
936daf6f63 Updating the other classes in the group module to match #7249 2014-06-24 12:28:43 -05:00
James Cammarata
4ca9ebf084 Merge pull request #7249 from jfchevrette/implement-group-checking-if-state-present
Allow group module to handle check_mode properly when group.state=present and group already exists
2014-06-24 12:27:31 -05:00
James Cammarata
236a2989cc Merge branch 'lvg_dm_names' of https://github.com/ajsalminen/ansible into ajsalminen-lvg_dm_names 2014-06-20 13:24:07 -05:00
James Cammarata
ad4926e090 Update authors for modprobe module 2014-06-20 11:12:49 -05:00
James Cammarata
974693882e Merge branch 'add_name' of https://github.com/stygstra/ansible into stygstra-add_name 2014-06-20 11:12:24 -05:00
James Cammarata
6ad83bb5ce Merge branch 'devel' of https://github.com/tgolly/ansible into tgolly-devel 2014-06-19 22:41:58 -05:00
Michael DeHaan
4fbc2a83e0 Merge pull request #7861 from cchurch/devel
Windows Remote Support
2014-06-19 22:10:41 -05:00
David Stygstra
cae41d0931 Added author and copyright lines to modules I contributed 2014-06-19 20:02:02 -04:00
Michael DeHaan
8b262d775b Slight tweak to windows wording. 2014-06-19 14:24:15 -05:00
Matt Martz
cab68bc579 Mention that with windows target hosts, fact_path and filter are not currently supported 2014-06-19 14:24:14 -05:00
James Cammarata
2c22cf46cf Merge branch '7763' of https://github.com/rmarchei/ansible into rmarchei-7763 2014-06-18 12:16:01 -05:00
James Cammarata
34405ea905 Merge branch 'lvg_fix' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-lvg_fix 2014-06-18 09:00:41 -05:00
Ilya Rusalowski
b1a31ebb84 Set default vg_options to empty string 2014-06-17 20:42:18 +04:00
Ruggero Marchei
f522425415 move get_distribution_version() to basic.py 2014-06-17 10:22:14 +02:00
Ruggero Marchei
bd69e9f265 use different strategy for RHEL >= 7. Fixes 7763 2014-06-14 19:29:04 +02:00
James Cammarata
d35d5ac9d1 Merge pull request #7741 from mgcrea/devel
Add support for Linaro distribution in hostname module
2014-06-12 08:58:56 -05:00
James Cammarata
3e04d8c70c Merge pull request #7737 from toddmowen/zfs-fix-7696
zfs: fix incompatibility - share.nfs vs sharenfs (issue #7696)
2014-06-12 08:53:21 -05:00
Olivier Louvignes
158d6276eb Add support for Linaro distribution in hostname module 2014-06-12 12:06:59 +02:00
Todd Owen
34517b0836 zfs: work around incompatibility by renaming share.nfs to sharenfs
Fixes #7696
2014-06-12 16:21:16 +08:00
rgbkrk
5591e8838d Error checking and reporting on interface ufw rule 2014-06-11 11:10:38 -05:00
Ron Gomes
73246a49dc Fix incorrect argument ordering in error message, which provokes a
printf-related TypeError.
2014-06-09 15:03:51 -04:00
Yann Coleu
f378ed643c Add primary group in the first user module doc example 2014-06-02 14:32:52 +02:00
Nicolas Brisac
ecda1455bf open_iscsi module: support RC 21 when listing logged-in target 2014-05-24 18:14:28 +02:00
Brian Coca
5c87e97a45 now module searches for update-alternatives vs hardcoding it 2014-05-20 22:51:27 -04:00
James Cammarata
3a8ebd4325 Pull the link out of the alternatives output when not specified
Fixes #7414
2014-05-16 14:44:31 -05:00
Adam Chainz
6b10cf756a Fix grammar and value errors in cron documentation 2014-05-09 15:19:42 +01:00
Luca Berruti
eca36953c8 Make alternatives module python 5 compatible 2014-05-08 14:46:49 +02:00
Jean-Francois Chevrette
8756612599 this should return 0 to indicate a non-failure when check_mode is True 2014-05-07 10:20:51 -04:00
Antti Salminen
a6b482c500 Switch to mapper device name if pvs returns the wrong one. 2014-05-03 10:36:22 +03:00
Carlos E. Garcia
4dcaa9d9fb multiple spelling error changes 2014-04-29 10:41:05 -04:00
Michael Scherer
4ed4bfff90 Do not fail if we try to generate a ssh key for a user without being root
If we try to use the user module without being root, it fail on RHEL/Fedora
because usermod --help cannot be run. The root cause is lack of permission
due to EAL4+ certification, as seen in shadow-utils changelo.

So if we cannot run it, assume there is no append. It doesn't matter
much since we will not be able to run usermod at all with or without the
option.
2014-04-28 12:29:57 +02:00
Chris Lamb
b123b648a0 Correct/update debconf examples - need to specify vtype.
Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
2014-04-23 21:51:01 +01:00
Michael Scherer
cf3365b99e Add a better error message for service
While migrating my playbook to a newer ansible version, I faced
the error message "unknown init system, cannot enable service". It turned
out to be caused by a wrong service name that was not expanded anymore.

So by giving the name of the service that cannot be enabled and a more precise
reason, i think people will be able to diagnose their issue more easily.
2014-04-22 09:13:57 +02:00
Hernandes B. de Sousa
780b5e0bbf Add missing info for the append option
Both 'default' and 'choices' options were missing at the documentation.
2014-04-16 01:22:12 -03:00
James Cammarata
0c96e2f33b Check to make sure the firewalld client is connected before proceeding
Fixes #6911
2014-04-15 15:03:52 -05:00
Jonathan Davila
a90aa46ed2 Added example demonstrating other functionality 2014-04-11 11:14:40 -04:00
James Tanner
0025273fca Fixes syntax error in cron module caused by #6870 2014-04-08 12:53:56 -04:00
Eric Lake
58dccfbc29 Adding bold to service doc to call up state and enabled. 2014-04-07 09:37:15 -05:00
MorrisA
ac72d44219 Modified Cron to add AIX Crontab support, changed according to suggestions
from mpdehaan and redone entirely.
2014-04-05 18:10:45 -07:00
Serge van Ginderachter
867702b26a lvg module bugfix on vg_options patch
When no vg_options are passed to the module, 'vg_options' still exists
in the module.params dict with a value of None, so the default empty string in
the get method is never used. None cannot be "splitted", which backtraced.
2014-04-04 15:32:35 +02:00
Michael DeHaan
3d8997d219 Name is not required, update docs. 2014-04-03 18:03:13 -04:00
Michael DeHaan
7258c15ce1 Merge pull request #6831 from aresch/patch-1
Fix _parse_value always returning 0 when not true, false or None.
2014-04-02 20:09:41 -04:00
Andrew Resch
32e5383bef Fix _parse_value always returning 0 when not true, false or None. 2014-04-02 15:59:05 -07:00
Joshua Lund
74962a0e35 Update cron module documentation. The 'name' parameter is required. 2014-04-02 16:41:09 -06:00
Michael DeHaan
5826e1354a Slightly revise wording. 2014-04-02 17:43:40 -04:00
Michael DeHaan
ff2177442b Merge branch 'authorized_key-manage_dir' of git://github.com/tyll/ansible into devel 2014-04-02 17:42:24 -04:00
Michael DeHaan
4917f4a48f Merge pull request #6810 from bob-smith/debconf-text
debconf detail requirements and fix typos
2014-04-02 17:25:22 -04:00
James Cammarata
57adad7097 Fix issue with sysctl parameter parsing introduced by 0e8c7b1
Fixes #6806
2014-04-02 15:26:02 -05:00
Michael DeHaan
05551cfe51 Merge pull request #6826 from bob-smith/debconf-parsing
debconf correctly quote strings
2014-04-02 16:14:17 -04:00
James Cammarata
09c998f104 Fixing some parsing issues in authorized_key module
Also adds an integration test for authorized_key for future validation.

Fixes #6700
2014-04-02 15:02:54 -05:00
John Barker
ed4717a978 debconf correctly quote strings 2014-04-02 20:43:12 +01:00
John Barker
e4a779d4dd debconf detail requirements and fix typos 2014-04-01 21:51:12 +01:00
Tim G
32d48d75e9 Bugfix, fix crontab commands on HP-UX 2014-04-01 21:09:08 +10:00
Michael Scherer
ba9f910ec9 fix typo in the capabilities module description 2014-03-30 22:33:24 +02:00
Adam Nielsen
b35086c7a3 More descriptive error message if init system is unknown 2014-03-30 11:46:13 +10:00
Ahti Kitsik
74fa705e20 Bugfix for ufw to support "logging" properly:
It's a separate parameter so updated docs and set it as mutually exclusive param.
Also due to an array construction typo it was not working in any situation (ufw LOGLEVEL was passed to cmd instead of ufw logging LOGLEVEL).

Also fixed doc and parameters parsing typo ("choises" should be "choices")
2014-03-29 11:06:51 +02:00
Michael DeHaan
85320532d4 Rename vgoptions to vg_options. 2014-03-28 12:53:36 -04:00
Michael DeHaan
07423c1714 Merge branch 'devel' of git://github.com/chamill/ansible into devel
Conflicts:
	library/system/lvg
2014-03-28 12:53:00 -04:00
Michael DeHaan
9fa0ec57fb Scrub choices=BOOLEANS from remaining core module references. Correct form in argument_spec is type='dict'. 2014-03-28 11:41:35 -04:00
Michael DeHaan
073d34b40e Merge pull request #6524 from tyll/update_rc_d_disable
service module: Properly disable Debian services
2014-03-28 11:10:46 -04:00
Michael DeHaan
d3d1c8ce9a Merge pull request #6630 from bigl0af/devel
Modified library/system/user so that password change date is set on Sola...
2014-03-28 10:57:59 -04:00
Michael DeHaan
1e747e00e5 Merge pull request #6296 from jdauphant/devel
Add linux module parameters for the modprobe module
2014-03-27 17:12:21 -04:00
Cristian Ciupitu
7a4270184a Micro-optimization: replace s.find(x)==0 with s.startswith(x)
timeit shows a speedup of ~1.4x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
2014-03-27 20:35:20 +02:00
Ahti Kitsik
c757b6624f Fixed ufw module doc tags, it's reset everywhere, not reseted. 2014-03-27 17:22:39 +02:00
Seth Woodworth
21b7c358ee adds missing ' to debconf examples 2014-03-23 18:52:08 -04:00
Pierre-Louis Bonicoli
9a140881be Fix ValueError when selection contains a colon 2014-03-23 03:35:10 +01:00
David Fox
01acd73e30 Modified library/system/user so that password change date is set on Solaris when updating password 2014-03-22 15:12:56 -04:00
Till Maas
35f9e62422 service module: Properly disable Debian services
Services on Debian need to be disabled with 'disable' instead of 'remove'
to avoid them being enabled again when 'update-rc.d $service defaults' is run,
e.g. as part of a postinst script.
2014-03-20 09:19:42 +01:00
Till Maas
a063987d0e authorized_key: Be more specific about manage_dir
- Explain which properties are managed when manage_dir is True.
2014-03-20 09:15:59 +01:00
Michael DeHaan
7f36630dd5 Add capabilities module. 2014-03-19 17:48:17 -04:00
nate@bx.psu.edu
2daee9ed20 Bugfix for xattrless files and the capabilities module. 2014-03-19 17:48:17 -04:00
nate@bx.psu.edu
c19e4a7d0b Create a capabilities module for managing Linux kernel capabilities(7) with setcap(8). 2014-03-19 17:48:17 -04:00
James Cammarata
9f9c077878 Merge branch 'issues/6341' of https://github.com/threatgrid/ansible into threatgrid-issues/6341 2014-03-18 10:46:39 -05:00
James Tanner
4028f55c04 Fixes #6519 Properly handle state=absent in sysctl module 2014-03-18 09:30:21 -04:00
Michael DeHaan
ba99056948 Version bump for alternatives module, changelog. 2014-03-16 16:54:57 -04:00
Gabe Mulley
4c132c11f7 add a module for update-alternatives 2014-03-16 16:54:57 -04:00
Michael DeHaan
29a3a1d516 Move facts to 'module_utils' so they can be referenced by other modules. Note unlike other module_utils/ dirs this keeps the original
license -- so usage of facts code in modules will be limited to GPLv3 modules.
2014-03-16 16:12:02 -04:00
Michael DeHaan
c914e9e462 Update setup module signature from merge commit. 2014-03-16 14:11:43 -04:00
Michael DeHaan
cac81b1ad9 Merge pull request #6339 from threatgrid/systemd-template-svc-fix
systemd template services must not discard template part
2014-03-16 12:40:44 -05:00
Michael DeHaan
790a38e25d Merge conflict. 2014-03-16 13:36:52 -04:00
Michael DeHaan
201297cbfe Merge pull request #6175 from AdmiralNemo/fix-filesystem
filesystem: Ignore blkid cache
2014-03-16 12:31:53 -05:00
Michael DeHaan
d4de77fd45 Merge pull request #6097 from mattjeffery/bug/modprobe_normalise_name
Normalise the module name when comparing against the module names in /proc/modules
2014-03-16 12:31:17 -05:00
Michael DeHaan
bf33be20e1 Merge pull request #6005 from pgehres/chkconfig
Adding better failure output for chkconfig failures
2014-03-16 12:27:46 -05:00
Cristian Ciupitu
a416dba3d1 hostname module: don't filter hostnamectl with awk
There's no need to filter hostnamectl's output with awk because its man
page says:

    hostnamectl [OPTIONS...] {COMMAND}

       --static, --transient, --pretty
	   If status is used (or no explicit command is given) and one
	   of those fields is given, hostnamectl will print out just
           this selected hostname.

E.g. hostnamectl --static status => ansible.example.org
2014-03-16 13:10:28 -04:00
Cristian Ciupitu
7f681c33a2 Micro-optimization: replace s.find(x)!=-1 with x in s
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
2014-03-16 13:10:28 -04:00
James Tanner
59fb47ae9a Fixes #6482 Check sysctl file path and catch read exceptions 2014-03-14 11:16:45 -04:00
Michael DeHaan
29138b1872 More shell updates 2014-03-12 17:31:00 -04:00
Richard C Isaacson
9e9f43272a setup module: Mark unsafe commands as use_unsafe_shell=True. 2014-03-12 11:13:20 -05:00
Ryan
3494d67f30 add module param to Network & sub-classes
add module param to Network and sub-classes of Network, so that ansible 1.5.1 changes to LinuxNetwork apply to all Network classes.
2014-03-12 09:37:12 -04:00
Michael DeHaan
65c4e388eb Revert "Fix issue#6430 by instantiating Network() with expected arguments"
This reverts commit 2a723e908e.
2014-03-12 09:23:13 -04:00
James Laska
cb63352aff Fix issue#6430 by instantiating Network() with expected arguments 2014-03-12 09:04:42 -04:00
Richard C Isaacson
7d83f64bae Fix docstring issue. 2014-03-11 16:23:18 -05:00
Richard Isaacson
19d77ada25 Merge pull request #6406 from risaacson/at_module2
This fixes what was merged in 1.5.0.
2014-03-11 15:27:51 -05:00
James Tanner
e63e909d6f Fix name in locale_gen docstring 2014-03-11 16:13:55 -04:00
James Tanner
4fae7da5e8 Fix snippet imports and version_added in ufw module 2014-03-11 16:07:08 -04:00
James Cammarata
6a81debb0a Merge pull request #5518 from pyykkis/ufw
UFW module (another take)
2014-03-11 15:03:33 -05:00
James Tanner
820c328ca8 Set version_added for locale_gen 2014-03-11 15:56:30 -04:00
James Tanner
3763008d15 Rename locale module to locale_gen 2014-03-11 15:55:26 -04:00
James Cammarata
52d14d0fee Merge pull request #5411 from AugustusKling/locale
locale module
2014-03-11 14:54:36 -05:00
Michael DeHaan
e767de4978 Merge pull request #6372 from mriedelumab/devel
Returning 'NA' when no virtualization found
2014-03-11 10:17:22 -05:00
James Tanner
fc33860e5d Force command action to not be executed by the shell unless specifically enabled 2014-03-10 16:13:30 -05:00
Matthew Riedel
d21a8f6ddc Returning 'NA' when no virtualization found 2014-03-10 11:58:04 -04:00
Richard C Isaacson
3188429105 Some cleanup. 2014-03-10 10:31:08 -05:00
Charles Duffy
532cda524f #6341: use shared function for parsing systemd status; check rc code 2014-03-10 01:05:48 -05:00
Charles Duffy
fd5083fe71 #6341: check systemd service status with show subcommand 2014-03-10 00:09:29 -05:00
Jarno Keskikangas
19fb807824 Recognize rule changes even if ufw is in disabled state.
See http://askubuntu.com/questions/30781/see-configured-rules-even-when-inactive
for the details.
2014-03-09 12:56:52 +02:00
Jarno Keskikangas
9abdacc725 Insert rule to a specific num. 2014-03-09 12:56:51 +02:00
Jarno Keskikangas
76eb4969fb Fix typo: 'reseted' -> 'reset'. 2014-03-09 12:56:51 +02:00
Jarno Keskikangas
b8f37df8e7 Add protocol options 'esp' and 'ah'. 2014-03-09 12:56:51 +02:00
Jarno Keskikangas
767cfcb0bd Add functionality and reduce complexity.
* Separate 'state', 'policy' and 'rule' commands
* Support for 'logging' command
* Support for 'direction' and 'interface' attributes
* Reliable change notifications based on 'ufw status verbose' diff
* Update documentation
* Cleanup
2014-03-09 12:56:51 +02:00
Aleksey Ovcharenko
4754bf47be New module [ufw]: this module handles Ubuntu UFW operations
* Updated documentation related to IPv6 usage.

BugFixes:
* Solved the default_policy and state mutual exclusive status.
* Fixed changed status for IPv6 addresses.

Added @otnateos patch.
2014-03-09 12:56:51 +02:00
Richard C Isaacson
ce98edfc87 Cleaning up pep8 alerts. 2014-03-07 23:06:19 -06:00
Richard C Isaacson
bdfb2de7fc Documentation cleanup. 2014-03-07 23:04:56 -06:00
Richard C Isaacson
a94e1e5477 Refactored a few things to be more inline with the Ansible way. Passing testing. 2014-03-07 23:04:07 -06:00
Charles Duffy
32620cab4d systemd template services must not discard template part 2014-03-07 18:53:15 -06:00
jctanner
b105942654 Merge pull request #5872 from tomdymond/add-ignoreerror-to-sysctl
Add option to enable the sysctl -e option
2014-03-05 12:58:05 -05:00
Julien DAUPHANT
7ce4eba507 Add version_added 1.6 for the params modprobe option 2014-03-05 16:45:20 +01:00
Julien DAUPHANT
c95b358694 Add linux module parameters for the modprobe module 2014-03-05 16:42:52 +01:00
anatoly techtonik
63f0a644ac setup: Fix KeyError: 'ipv4_secondaries' (issue #6274) 2014-03-04 20:00:18 +02:00
James Tanner
87f17e7e94 Fix debconf docstring indentation 2014-03-03 13:48:44 -05:00
James Tanner
b07e5742b3 Merge branch 'debconf' of git://github.com/bcoca/ansible into bcoca-debconf 2014-03-03 13:46:11 -05:00
Brian Coca
a4f6a12181 didnt make 1.5 ... lets see 2014-03-01 22:28:51 -05:00
Brian Coca
a7444f5178 added better gentoo/funtoo support 2014-03-01 21:56:02 -05:00
Michael DeHaan
d71921492b Merge pull request #6223 from lvh/patch-2
Support ssh-ed25519 keys
2014-02-28 12:59:05 -05:00
Laurens Van Houtven
c50b772e61 Support ssh-ed25519 keys
The newest version of OpenSSH supports a new, wonderful key type. authorized_key incorrectly discards pubkeys of this type as busted because it doesn't recognize type signature.
2014-02-28 18:46:54 +01:00
James Cammarata
08fca488f3 Use the no-user-groups option (-N) for useradd in the user module
If no group was specified, but a group by the same name as the user
exists, an error was raised in the situation where USERGROUPS_ENAB is
enabled in /etc/login.defs (which is the case for almost every major
linux distro). In this case, the user will be put in group 100 (which
is usually the "users" group on those same distros). This is currently
only done in the base class, as the issue may not exist on other
platforms like AIX or the BSDs.

Fixes #6210
2014-02-28 11:46:27 -06:00
Dustin C. Hatch
d2dc260e98 filesystem: Ignore blkid cache
Sometimes, `blkid` will incorrectly return no information about a block
device, even if it exists and has a valid filesystem. This causes the
*filesystem* module to fail if *force=no*. Instructing `blkid` to use
`/dev/null` as a cache file will force it to rescan the block device on
each run, making results more consistent.

Signed-off-by: Dustin C. Hatch <admiralnemo@gmail.com>
2014-02-25 20:16:01 -06:00
Chris Church
09b076e39c Fix setup module to gather facts from PowerPC Macs. 2014-02-25 18:27:36 -05:00
James Cammarata
8aec47af89 Merge branch 'usermod_fix' of https://github.com/tknguyen79/ansible into tknguyen79-usermod_fix
Conflicts:
	library/system/user
2014-02-24 23:38:51 -06:00
Stefan J. Betz
b335eb2412 Require force for LVM shrink and remove operations in lvol. Fixes #5774
Conflicts:
	library/system/lvol
2014-02-24 18:52:35 -06:00
Richard C Isaacson
eb2762bc5b If you try to resize a lvol to the current size return a changed=False and don't fail.
This addresses GH-5165 and adds the ability to check if a lvol exists.

The tests for this don't fit nicely into the current integration tests so they are below.

```
---

- name: remove any existing lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: remove any existing lv=two of vg=main
  lvol: lv=two vg=main state=absent

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  ignore_errors: true
  register: lvol_result0

- name: Assert that we will get a "No size given."
  assert:
    that:
      - "'No size given.' in lvol_result0.msg"

- name: create lv=one of vg=main sized 30g
  lvol: lv=one size=30g vg=main state=present
  register: lvol_result1

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result1.changed == True"

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  register: lvol_result2

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result2.changed == False"

- name: remove lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: create lv=two of vg=main sized 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result3

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result3.changed == True"

- name: reduce lv=two of vg=main to 15G
  lvol: lv=two size=15G vg=main state=present
  register: lvol_result4

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result4.changed == True"

- name: increase lv=two of vg=main to 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result5

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result5.changed == True"

- name: create lv=two of vg=main sized 30G when already exists at 30G
  lvol: lv=two size=30g vg=main state=present
  register: lvol_result6

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result6.changed == False"

- name: remove lv=two of vg=main
  lvol: lv=two vg=main state=absent
```
2014-02-24 16:56:08 -06:00
Matt Jeffery
6cfa724472 Normalise the module name when comparing against the module names in /proc/modules. 2014-02-20 16:54:33 +00:00
C. Morgan Hamill
c29f2fb888 Add 'vgoptions' parameter to lvg module.
Allows specifying extra flags to pass to `vgcreate`.
2014-02-18 15:20:12 -05:00
Nils Pascal Illenseer
7f40790fc1 Fix zfs create command for properties with spaces
If a property value contains one or more spaces, the zfs command will fail.
With value quoted this behavior is fixed.
2014-02-18 11:30:17 +01:00
Richard C Isaacson
cb8c462880 Merge remote-tracking branch 'berendt/fixing_permissions' into pull_4703 2014-02-17 11:46:23 -06:00
Peter Gehres
a9bf607013 Adding better failure output for chkconfig failures rather than
just saying that the service name is unknown
2014-02-13 23:05:00 -08:00
Sean Chittenden
c892f51002 Fix broken behavior when removing all auxiliary groups from a user
(e.g. 'groups=' in the user module).
2014-02-10 13:08:53 -08:00
Brian Coca
01a1482f1a hopefully last batch of fixes
- removed previous 'typification' of input as it needs it is typed by
  module as strings and needs to be output as strings, making it
  useless.
- now checks for vtype and value against None when question is specified
- simplified set_selections as vtype and value should have a string
  value going in.
- added example of querying questions for a package
- added module requirement of question,vtype and value being required
  together.
2014-02-09 20:47:01 -05:00
Brian Coca
4b0c2d839e made changes as per feedback:
- field names are more consistent with debconf
- values are now 'booleanized' or accepted as list/set objects when
  pertinent
- updated docs to reflect all of the above and debconf cli tools
  required
2014-02-09 17:46:18 -05:00
Brian Coca
c11fbd54e1 fixed main() issue created in prev fix, now values are empty string if they were None
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
2014-02-06 11:59:37 -05:00
Brian Coca
8a6a2aba75 changes names to name in example 2014-02-05 18:28:17 -05:00
Brian Coca
ddb191f208 fixes as per feedback 2014-02-05 18:08:01 -05:00
Tom Dymond
c9e7541e60 Reworked PR to avoid repeating the command 2014-02-05 15:35:24 +00:00
jctanner
4901af0ef6 Merge pull request #5554 from ttarabul/devel
Use /etc/rc.conf.local for sevice configuration on FreeBSD
2014-02-04 10:59:19 -08:00
Tom Dymond
16edbd3181 Add option to enable the sysctl -e option 2014-02-04 18:19:28 +00:00
kustodian
405dee2398 Updated authorized_key module documentation regarding manage_dir
Added a warning in the documentation about manage_dir when selecting an alternate directory for authorized_keys
2014-01-29 23:39:43 +01:00
Aaron Lindsay
931f8e4c5b Add move_home option to user module 2014-01-29 14:10:26 -05:00
Richard C Isaacson
cc20868bfb Tested implementation adding action option for (add, delete, unique). 2014-01-28 20:29:41 -05:00
Richard C Isaacson
855154226e Rough cut implementation based on @resmo's comments. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
4e4ba1f695 Rough cut implementation based on @resmo's comments. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
c677056dfe Change to dynamically pick up the command from the PATH. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
9dc98d9b66 Formating and syntax fixes that were pointed out during code review. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
eb9831cf62 Added user option. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
7e1361d0e0 First commit of the at module being very basic. 2014-01-28 20:29:41 -05:00
Brian Coca
fee79e6501 be permissive with BSD with service enabled upper/lower/mixed cases
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
2014-01-28 14:49:57 -05:00
Jakub Jirutka
1dc5ee00b6 sysctl: parse bool value as 0/1 and refactor a little bit 2014-01-27 20:26:11 +01:00
Thoai Nguyen
220b0f87d9 reorder usermod options 2014-01-22 15:27:00 -05:00
jctanner
f14f6ebd44 Merge pull request #5676 from simonz05/bugfix-sysctl-multivalue2
Correctly compare values returned by 'sysctl -e -n'
2014-01-20 06:11:29 -08:00
Augustus Kling
de19375d1b Fix error reporting in case locale-gen fails on non-Ubuntu systems. 2014-01-20 00:11:01 +01:00
Augustus Kling
eabc9cd775 Merge remote-tracking branch 'upstream/devel' into locale 2014-01-19 23:51:27 +01:00
Augustus Kling
00ee613446 Handle install/uninstall of locales for Ubuntu, too. 2014-01-19 23:35:10 +01:00
Simon Zimmermann
be69ca4ead correctly compare the values, better func name 2014-01-18 11:04:15 +01:00
Simon Zimmermann
45728d739c Correctly compare values as returned from 'sysctl -e -n' 2014-01-18 10:50:24 +01:00
Simon Zimmermann
624c563e43 fix str format error due to missing '%' in sysctl module 2014-01-17 22:31:12 +01:00
James Tanner
f3b86abc30 Fixes #5661 Handle null values for sysctl parameters 2014-01-17 11:30:07 -05:00
Michael DeHaan
49b0db9819 Merge pull request #5658 from rishid/devel
Add support for Scientific Linux for hostname module
2014-01-16 17:55:24 -08:00
jctanner
921ae2134b Merge pull request #5655 from scottgilbert/devel
Allow keystring passed to authorized_key to contain blank lines and comments
2014-01-16 14:22:57 -08:00
James Tanner
03aba39b59 Fixes #5656 quote values with multiple columns before calling
the sysctl command. Calling sysctl should also not be true by default
2014-01-16 16:30:13 -05:00
rishid
4ef5b60f3d Add support for Scientific Linux for hostname module
hostname module was lacking support for Scientific Linux, this commit adds it.
2014-01-16 16:08:51 -05:00
Scott Gilbert
df72690e6c Allow keystring passed to authorized_key to contain blank lines and comments 2014-01-16 12:14:37 -06:00
James Tanner
a9c5aa8f78 Remove unused variable from authorized_key 2014-01-16 11:46:06 -05:00
James Tanner
30f7b2d298 Fixes #5486 Keep authorized key options in tact and ordered 2014-01-15 17:10:10 -05:00
James Tanner
272c3634cd sysctl module: append newline character to lines in the file 2014-01-15 10:25:27 -05:00
Michael DeHaan
cb6f7748d5 All modules should be using /usr/bin/python in the shebang as ansible_python_interpreter processes this (see FAQ).
Fixing for standardization purposes.
2014-01-15 09:52:17 -05:00
jctanner
da9cd8e018 Merge pull request #5490 from rgbj/devel
user module/OpenBSD: using login_class always makes status 'changed'
2014-01-14 14:44:51 -08:00
jctanner
9779206142 Merge pull request #5426 from lichesser/debian_release_4565
setup module: Partial fix for #4565, reporting Debian release version. Works only for Debian 7 and later
2014-01-14 13:00:08 -08:00
James Tanner
1b712ec48d sysctl module: fail if reloading the file did not succeed 2014-01-14 10:48:57 -05:00
James Tanner
f0b842b28b Fixes #5469 Refactor sysctl module into object oriented code,
and add a sysctl_set parameter to manage the values in /proc
2014-01-13 18:53:02 -05:00
Tyler
5ce664b499 keep /usr/local/etc/rc.conf for backwards compatibility 2014-01-08 14:38:49 -05:00
Tyler
c073438d40 Use /etc/rc.conf.local for sevice configuration on FreeBSD
/etc/rc.conf.local is the preferred location for system-specific
startup configuration, and /usr/local/etc/rc.conf generally isn’t used.

see:
http://www.freebsd.org/doc/handbook/configtuning-core-configuration.html
2014-01-08 13:48:11 -05:00
Joshua Lund
e0a720b8b2 Improved the documentation for password generation 2014-01-07 18:20:39 -07:00
James Tanner
154a99529c Fixes #5353 create etc/hostname file in debian if it does not exist 2014-01-07 15:53:16 -05:00
Michael DeHaan
0fdcb8ea69 Merge pull request #5528 from dverhelst/devel
Adding support for detecting RHEV Hypervisor in ansible_virtualization_type
2014-01-07 15:51:21 -05:00
Paul Beattie
31f81c3a1b Fixed typo in example documentation 2014-01-04 00:22:14 +00:00
rgbj
fa5a448983 On OpenBSD, make user module status 'changed' only if necessary when using 'login_class' parameter 2014-01-03 15:41:12 +01:00
jctanner
6f16ea6d49 Merge pull request #5167 from jaspernbrouwer/devel
service_module: Fixed false positive on initctl as enable_cmd
2014-01-02 20:24:00 -08:00
James Tanner
e2c7aeca4c Fixes #5040 setup module: do not add primary interface info to the secondary interface data 2014-01-02 16:17:24 -05:00
lichesser
bab510f0c5 Partial fix for #4565. Works only for Debian 7 and later 2013-12-26 17:53:17 +01:00
Michael DeHaan
05c755f2dc Fix a documentation item. 2013-12-25 13:50:15 -05:00
Augustus Kling
c850c0a76b Basic handling of locales. 2013-12-24 12:29:02 +01:00
Brian Coca
45872dfee7 making pylint happier
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-12-23 14:09:15 -05:00
Brian Coca
ebba754ee6 corrected my grammar (again Mikhail)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-12-23 13:48:53 -05:00
Brian Coca
72eba69175 did some minor refactoring on docs and fixed spelling mistakes (thanks
Mikhail)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-12-23 13:35:27 -05:00
Jasper N. Brouwer
9dab01c5e2 Swapped conditions of the changed if statements 2013-12-23 09:54:16 +01:00
Brian Coca
ce72f27787 corrected indentation and now handles non existing previous key (not
just changed existing)

Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-12-20 12:50:06 -05:00
Brian Coca
3587053119 and it was supposed to be a dict
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-12-19 17:22:05 -05:00
Brian Coca
564bd29eeb fixed typo for showing diff
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-12-19 17:21:00 -05:00
Brian Coca
0c2ec0d9d1 debconf package
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-12-19 16:54:02 -05:00
jctanner
76c3055986 Merge pull request #4886 from sergeyhush/devel
fix when the system does not have lsb_release script, but has /etc/lsb_release file
2013-12-13 11:25:45 -08:00
jctanner
0a2fd6f088 Merge pull request #5213 from dalevizo/devel
Add get_dmi_facts in setup for FreeBSD systems using dmidecode
2013-12-12 15:32:59 -08:00
Dimos Alevizos
8cda18ec51 Minor changes to simplify code 2013-12-08 09:02:50 +02:00
David Hummel
e329b23365 Fix issue #5214: hostname persistence on RedHat/CentOS 2013-12-07 21:10:42 -05:00
Dimos Alevizos
34ff7e00a9 Add get_dmi_facts in setup for FreeBSD systems using dmidecode 2013-12-07 17:16:20 +02:00
jeromew
5413ee9431 user module: force= and remove= should not be mutually exclusive 2013-12-05 17:07:24 -05:00
jctanner
5040665cd0 Merge pull request #5075 from gservat/patch-1
Added support for parsing in the SLES patch level correctly
2013-12-05 13:34:57 -08:00
gservat
38ec5b0058 This change is meant to replace distribution_release, not version! 2013-12-06 07:53:39 +11:00
gservat
a8c9e2afd1 Oops... fixed an error 2013-12-06 07:49:03 +11:00
Alfons Zitterbacke
f37a217a33 added AIX network facts 2013-12-05 10:13:55 +01:00
Alfons Zitterbacke
f556151c56 added AIX network facts 2013-12-05 10:06:44 +01:00
James Tanner
3bb1a263cf Fixes #5169 Evaluate check_mode in the user module SunOS class 2013-12-05 00:44:55 -05:00
Jasper N. Brouwer
677f95294e Fixed false positive on initctl as enable_cmd
Also on update-rc.d
In service module
2013-12-04 21:49:00 +01:00
jctanner
5fb01db898 Merge pull request #5090 from dragon3/hostname_support_amazon_linux
hostname module: add support for Amazon Linux
2013-12-03 12:34:55 -08:00
jctanner
4125713b6e Merge pull request #5107 from maetthu/devel
authorized_key module: rewrite options to dict parser, fixes #5032
2013-12-02 14:02:43 -08:00
jctanner
cd5c817a36 Merge pull request #5063 from samh/devel
Fixed hostname module for RHEL6 Workstation
2013-12-02 13:38:32 -08:00
James Tanner
4f9aadcc07 Addresses #5023 Fix import comments 2013-12-02 15:13:49 -05:00
James Tanner
38edad70ac Fixes #5023 Convert all modules to use new snippet import pattern 2013-12-02 15:11:23 -05:00
James Tanner
0242f10781 Fixes #4796 handle unicodedecode errors from dmidecode output 2013-12-02 11:56:38 -05:00
Michael DeHaan
4704dfefb0 Merge pull request #5046 from JensRantil/improve-mount-doc
mention that the mount module will remove mount directories
2013-12-01 14:27:40 -08:00
Matthias Blaser
1e1def3fbd rewrite options to dict parser, fixes #5032 2013-11-30 09:03:35 +01:00
Michael DeHaan
4c35b7f380 There's a cleaner way to do this, commit to module formatter pending.
Revert "No longer need to reference 'version_added' in docs for these, as this was quite a while ago."

This reverts commit ff0a41d446.
2013-11-27 21:23:03 -05:00
Michael DeHaan
9e4d71203d No longer need to reference 'version_added' in docs for these, as this was quite a while ago. 2013-11-27 21:19:32 -05:00
dragon3
b5eb3c41e3 hostname module: add support for Amazon Linux 2013-11-28 09:31:25 +09:00
gservat
3b6e9a07f6 Added support for parsing in the SLES patch level correctly
On SLES, the setup module was returning the architecture as the distribution version (i.e. platform.dist() didn't quite return the right thing). This change checks for /etc/SuSE-release and grabs the second column in the third line as distribution_version.
2013-11-27 23:44:34 +11:00
Sam Hartsfield
a8a6771b0e Fixed hostname module for RHEL6 Workstation 2013-11-26 11:36:10 -05:00
James Tanner
fa4b30819a Fix comment yaml escaping in authorized_key module 2013-11-26 08:54:19 -05:00
James Tanner
999b04f7fa Save comment hashes in sshkeys 2013-11-25 23:46:48 -05:00
James Tanner
7de788f346 Cleanup debug statements 2013-11-25 22:16:04 -05:00
James Tanner
d0c2b37688 Fixes #5032 escape and safely split key options in authorized_keys module 2013-11-25 22:13:42 -05:00
James Tanner
486d248401 Fixes #5010 Add user to all defined supplementary groups 2013-11-25 14:56:46 -05:00
Jens Rantil
79a3ed2654 Improved documentation of mount module
Mentioning the fact that mount point directories are created and
removed.
2013-11-25 13:58:00 +01:00
James Tanner
407d6041b3 Fixes #5021 safely split hostkeys with quotes 2013-11-22 16:36:31 -05:00
James Tanner
6ca17b90d0 Fix pep8 error in hostname module 2013-11-19 16:39:48 -05:00
Michael DeHaan
147210ddcf Merge pull request #4868 from hnakamur/rhel5_hostname_fix
hostname module fix for RHEL5
2013-11-19 11:38:29 -08:00
Michael DeHaan
db9176f77d Remove the 'host' module for now because the alias handling involves a bit too much automagic. Proposal is to come up with a spec
of how it should work and accept to spec, using the existing patch (cherry-picked) as a baseline.
2013-11-19 14:12:45 -05:00
Michael DeHaan
08996d78d6 Add version_added to all modules missing version_added information, the docs formatter will now
raise errors when omitted, updated changelog with new modules.
2013-11-18 18:55:49 -05:00
Michael DeHaan
55a48aacc3 Changelog updates and a few module renames. vpc -> ec2_vpc, githooks -> github_hooks, blacklist -> kernel_blacklist. These are all new in 1.4 so safe to change. 2013-11-18 18:28:21 -05:00
Sergey Sudakovich
8ecd617df8 compatible with python 2.4 2013-11-18 11:33:04 -08:00
jctanner
ab54bce2f6 Merge pull request #4910 from matze/add-system-blacklist-module
Add system module to blacklist kernel modules
2013-11-15 11:06:05 -08:00
Rene Moser
b1f27ca902 host: fix bug, alias was not removed 2013-11-15 14:04:41 +01:00
Rene Moser
25f527a32d host: removed unused self_has_aliases 2013-11-15 14:04:40 +01:00
Rene Moser
ee9dc73a63 host: skip lines beginning with new line 2013-11-15 14:04:40 +01:00
Rene Moser
502d9f43e5 host: fix changed is not available on fail 2013-11-15 14:04:40 +01:00
Matthias Vogelgesang
6ce4635952 Add system module to blacklist kernel module 2013-11-15 10:34:55 +01:00
nextus
6d701cb517 Don't allow cron module to delete cron_file without name parameter assignment 2013-11-14 13:24:14 +04:00
nextus
f0ea92cc75 Fix: absent state removing whole cron.d file instead of specific job 2013-11-13 23:58:37 +04:00
James Tanner
73d36f84b1 Merge pull request #4282 from cristobalrosa/ansible
Add a fact for checking if interface is in promiscuous mode.
2013-11-13 10:33:57 -05:00
Sergey Sudakovich
ae9fd2172e fix when the system does not have lsb_release script, but has /etc/lsb_release file 2013-11-12 15:25:39 -08:00
James Tanner
36c4f05891 Add more error detail to the service module for FreeBSD 2013-11-12 00:02:30 -05:00
jctanner
fc51fb8853 Merge pull request #4304 from ferringb/fixes/cron-permissions
Enforce umask for cron module, so cron_file generated files are 0644.
2013-11-11 14:23:39 -08:00
Hiroaki Nakamura
cc17a0ac7d Apply the same change as https://github.com/hnakamur/ansible-playbooks/pull/2 2013-11-10 08:28:33 +09:00
James Tanner
44014d6800 Set the correct version added for the hostname module 2013-11-07 22:01:02 -05:00
jctanner
9083258fa7 Merge pull request #3940 from hnakamur/hostname_module
Add a hostname module, which sets system's hostname.
2013-11-07 15:11:06 -08:00
James Tanner
e62cbba1fc Address #4573 Check interface keys and return gracefully on solaris zones 2013-11-06 18:11:22 -05:00
Jim Richardson
71bf839121 return True/False from remove_job_file()
revised fix for https://github.com/ansible/ansible/issues/4795
2013-11-04 14:14:53 -08:00
Jim Richardson
dd313b1b8f fix for https://github.com/ansible/ansible/issues/4795
Incorrect changed result in cron module.
Report changed=False if no cron is removed:wq
2013-11-03 17:43:51 -08:00
Hiroaki Nakamura
7aa728a32f Fix for RHEL6. 2013-11-01 23:32:14 +09:00
Michael DeHaan
99a8213be1 Merge pull request #4754 from mscherer/fix_4648
Fix 4648, cron module is not working on solaris
2013-10-31 14:49:25 -07:00
Michael DeHaan
0e7069d7c1 Undo an inadvertant revert from template changes so we still allow pythonic imports in module land. 2013-10-31 16:53:05 -04:00
Michael Scherer
2a3ee8dbf4 make cron module work on solaris
Cron on solaris do not take the same
set of option than vixie cron on linux, and
among the biggest difference, root cannot set
the crontab of a user directly from a file. Thus the
use of su to run the crontab command. Fix issue #4648
2013-10-31 19:58:26 +01:00
Michael Scherer
5547cc9c29 remove unused function 2013-10-31 19:58:26 +01:00
Scott Dunlop
be6e2c9097 add "zle" as a supported ZFS compression type
ZFS supports "zle" compression, which compresses runs of null bytes efficiently.
2013-10-31 10:48:41 -07:00
James Tanner
8036e6ee23 Revert templating enhancements from 73dbab70 e6c28658 d409352c 9858b1f2 4587528b 9b1fe455 214b0b05 8d3db803 7f9504d1 5031104c 35cb9dc2 2bd8cb57 1e85c754 2013-10-30 10:50:16 -04:00
jctanner
63b1c47881 Merge pull request #4715 from mscherer/fix_4702
Fix #4702, make setup work on windows
2013-10-29 06:03:49 -07:00
Michael Scherer
2865a1b074 Fix #4702, make setup work on windows 2013-10-28 23:41:18 +01:00
James Cammarata
4c80cf411c Fixing authorized_keys module to make the key part detection better
Fixes #4677
Fixes #4657
Fixes #4599
2013-10-28 13:52:45 -05:00
Christian Berendt
8672ce9769 changing permissions of modules to 0644 2013-10-28 14:50:35 +01:00
Michael DeHaan
8bcd697816 Merge pull request #4424 from localvoid/firewalld-rich_rules
Add support for Rich Rules in firewalld module
2013-10-27 08:55:22 -07:00
Michael DeHaan
dcc1beab37 Merge pull request #4600 from earchibald/devel
Added ['date_time']['tz_offset'] using %z to get the time offset rather ...
2013-10-27 08:30:28 -07:00
Michael DeHaan
a6aeb12c8c Merge pull request #4560 from tronner/issue4461
Fix illegal set operation in FreeBSD section of user module.
2013-10-26 11:31:20 -07:00
Michael DeHaan
bc6d454b5e Enable imports to work on a snippet based system, allowing for instance a library of common EC2 functions
to be reused between modules.  See library/system/service and library/system/ping for initial examples.  Can
work the old way to just import 'basic', or can import the new way to import multiple pieces of code from
module_utils/.
2013-10-26 11:09:30 -04:00
James Tanner
f27e2fd285 Fixes #4448 reloaded services should be started if not running 2013-10-25 15:30:02 -04:00
James Cammarata
a220d7c18c Merge branch 'fix_autorized_keys' of https://github.com/mscherer/ansible into mscherer-fix_autorized_keys 2013-10-24 20:13:38 -05:00
James Cammarata
8fc62a1fb0 Fixing up authorized_keys to accept comments with spaces 2013-10-24 20:12:56 -05:00
Michael Scherer
d53abc2d5e make sure that options are quoted, as people can add a shell
script there with a comma that would produce invalid configuration
upon being wrote again
2013-10-24 23:51:55 +02:00
Michael Scherer
2ad3a46e13 sort the option_key to have a constant predictable line 2013-10-24 23:47:34 +02:00
Michael Scherer
7afaeea131 adding a single comma at the end of the options list confuse the module
it start to duplicate line, because this create
a empty option in the list, and so the module add a new line along the previous
one. See

>>> ' a,b, '.strip().split(',')
['a', 'b', '']
2013-10-24 23:46:49 +02:00
Scott Sturdivant
037dcbb4da If the output of rcvar isn't a key=value pair, ignore it. 2013-10-21 14:20:54 -06:00
Eugene Archibald
6599feac47 Fixed (broken) tab to (correct) spaces for indentation 2013-10-19 17:04:37 -07:00
Michael DeHaan
ce8b0944a9 Misc pep8 fixes 2013-10-19 13:03:15 -04:00
Michael DeHaan
c981999975 Merge pull request #4592 from mscherer/fix_4586
setup module, replace ':' by '_' in interface name, fix #4586
2013-10-19 09:07:56 -07:00
Eugene Archibald
70c78eade0 Added ['date_time']['tz_offset'] using %z to get the time offset rather than time zone. 2013-10-18 20:32:35 -07:00
Michael Scherer
4fb753997f fix logic in module host to add aliases even if none exist already, fix #4563
self._has_aliases is used to know if a alias already exist, but
the test we want is to know if we need to add a new alias, which
is stored in self.aliases
2013-10-19 01:51:42 +02:00
Michael Scherer
fa0d869ddd setup module, replace ':' by '_' in interface name, fix #4586 2013-10-19 00:24:07 +02:00
James Tanner
54781bdfe1 Fixes #4554 Enumerate user homedir if not passed as an argument 2013-10-17 13:15:32 -04:00
Thomas Ronner
3b45cb366f Fix illegal set operation in FreeBSD section of user module. 2013-10-17 15:02:23 +00:00
jctanner
6dedb68bde Merge pull request #4517 from adfinis-sygroup/devel
Remove keys regardless of the options
2013-10-16 17:40:43 -07:00
James Tanner
798dba436a Fixes #4350 Create homedirectory if create=yes and directory is missing 2013-10-16 20:08:41 -04:00
Hiroaki Nakamura
744b758633 Add support for Fedora, OpenSUSE and ArchLinux.
Tested under Fedora 19 and OpenSUSE 12.3. Not tested on ArchLinux.
2013-10-16 01:15:47 +09:00
Hiroaki Nakamura
7bd59c4b23 Do not use shortcut conditional operator which is not supported in Python 2.4. 2013-10-15 23:41:49 +09:00
James Cammarata
57cec2a88b Handle ssh key files that may only have a type/key specified
If a specified key did not have a comment, it would be ignored as
an invalid key.

Fixes #4513
2013-10-15 09:05:50 -05:00
Stefan Heinemann
576f5813a2 Set the options of an authorized key comma separated
According to the sshd man page, no spaces are permitted between the
options of an authorized ssh key
2013-10-15 15:29:52 +02:00
Stefan Heinemann
948713db5e Don't mind the options of a key when removing it
This allows to remove a key without knowing the options in the
authorized_key file
2013-10-15 15:29:47 +02:00
Michael DeHaan
377b3f4b6f Merge branch 'devel' of git://github.com/shirou/ansible into devel 2013-10-14 11:50:25 -04:00
Keith Buck
5397f90f0c Improve the formatting and content for the sysctl module's description. 2013-10-14 07:16:47 +00:00
James Cammarata
2753a40d5a Adding 'unique' option to authorized_key module and cleanup
A small refactoring of the authorized_key module to accomodate these
changes, plus fixing some things like not rewriting the file on every
new key. These changes bring the original feature for ssh options in-
line with the comments in #3798

Fixes #3785
2013-10-11 16:22:37 -05:00
David Minor
0828d3a316 Add ssh key options parameter to authorized_key module 2013-10-11 16:22:37 -05:00
James Tanner
74833f730b Fixes #4312 for older versions of usermod which do not have --append 2013-10-11 09:10:46 -04:00
Michael DeHaan
beae21dd40 Remove examples of module antipattern of setting the choices array for boolean types. 2013-10-11 08:45:13 -04:00
Boris Kaul
82a89b79d6 Add support for Rich Rules in firewalld module 2013-10-10 20:09:52 +07:00
Boris Kaul
3e85f39ba7 Fix timeout bug in firewalld module 2013-10-10 13:41:42 +07:00
James Tanner
4ce2a5f8df Second attempt at preventing ipv6 route enumeration on EL4 machines 2013-10-08 18:40:15 -04:00
James Tanner
bee6b544f5 Revert "Do not enumerate ipv6 routes in CentOS 4"
This reverts commit 5186c408f7.
2013-10-08 15:51:12 -04:00
James Tanner
879d20cac3 Do not enumerate ipv6 routes in CentOS 4 2013-10-08 15:12:38 -04:00
Michael DeHaan
d1b9ca4427 Add documentation about how passwords are generated. 2013-10-08 08:36:48 -04:00
James Cammarata
85cd7f7500 Better detection/categorization of ipv4 secondaries/virtual IPs
Fixes #3916
Fixes #3478
2013-10-07 15:18:33 -05:00
Michael DeHaan
9771032885 Merge pull request #4389 from MattTheRat/devel
addresses #4371 - adds -m to usermod commands
2013-10-07 12:15:20 -07:00
Matt Warren
f40a1e0eae addresses https://github.com/ansible/ansible/issues/4371 - adding -m to home directory modification 2013-10-07 10:47:12 -04:00
Michael DeHaan
c405a61505 Merge pull request #4336 from orkaa/devel
Fixes service update-rc.d functionality on debian
2013-10-07 05:56:43 -07:00
Martijn Lina
3d16b75096 replace dashes in rc.conf keys (which are based on freebsd rc.d filenames) to underscores 2013-10-04 16:30:39 +02:00
Skylar Saveland
db378d4515 fixes 4365 - Mac with cisco vpn client, GenericBsdIfconfigNetwork get_default_interfaces fails with index out of range 2013-10-03 18:58:11 -07:00
Adam Miller
8b5bb43958 fixed firewalld get_service_enabled 2013-10-02 18:52:53 -05:00