Commit graph

28491 commits

Author SHA1 Message Date
Felix Fontein
3290b8343c
docker: fix sanity errors (#60047)
* Remove sanity check errors.

* More linting.

* Forgot to update places.

* Remove choices which aren't provided in argspec.
2019-08-09 23:50:11 +02:00
Paul Belanger
4f78b694f0
Remove unused imports / variables from vyos modules (#60333)
This code is not used, lets remove it.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-09 16:47:08 -04:00
Alex Stephen
2e90efd4a7 Changing GCP Facts modules to Info Modules (#60172)
* file changes, porting guide, changelog fragment, renaming autoscaler, removing rst links
* Apply suggestions from code review

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-08-09 15:13:08 -05:00
Chris Archibald
b6202dde32 Allow firmware update for (SP, ACP, Shelf, Disk) (#58597)
* update

* Revert "update"

This reverts commit 84848f8291.

* correct module

* fixes
2019-08-09 16:04:46 -04:00
Yaakov Selkowitz
93d9d64038 facts: fix double-counting of CPUs on POWER systems (#58360)
On POWER systems, /proc/cpuinfo provides a 'processor' entry as a
counter, and a 'cpu' entry with a description (similar to 'model name'
on x86). Support for POWER in get_cpu_facts was added via the 'cpu'
entry in commit 8746e692c1.  Subsequent
support for ARM64 in commit ce4ada93f9
used the 'processor' entry, resulting in double-counting of cores on
POWER systems.

When unit tests were later written for this code in
commit 55306906cf, the erroneous values
were just accepted in the test instead of being diagnosed.

Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
2019-08-09 13:01:29 -04:00
Shachaf92
b5f42869dc win_dns_record PTR docs update (#60158)
* win_dns_record PTR docs update

* Update win_dns_record.py
2019-08-09 11:04:09 -05:00
Nathan Swartz
d61df0a9ba Lun mapping upstream dev (#57096)
* Fix hosts with same lun number conflict in netapp_e_lun_mapping.

This patch fixes an issue of when multiple hosts are created and then
subsequently volume(s) are mapped to them using the same specified number.

* Fix netapp_e_host module bug when lun=0

* Add thin-volumes to the netapp_e_lun_mapping update_mapping_info method.
2019-08-09 08:25:38 -04:00
Chris Archibald
48021a4200 add modify to snapshot policy (#59149) 2019-08-09 07:56:31 -04:00
Fred-sun
f088621610 Update azure_rm_webapp related document (#59027)
* Update azure_rm_webapp related document

* resolve format error

* remove whitespace

* update new

* updated according by comments

* update new according by comments

* add support time
2019-08-09 07:30:57 -04:00
Jordan Borean
dbd082efe4
Ansible.AccessToken - Added shared util for managing a Windows access token (#60302)
* Ansible.AccessToken - Added shared util for managing a Windows access token

* Fix tests when running in CI

* More fixes for older servers

* More fixes for Server 2008
2019-08-09 21:10:44 +10:00
Felix Fontein
49e16922b2 Remove no longer necessary check (since elements is procesed for path). (#59953) 2019-08-09 09:40:26 +02:00
Ganesh Nalawade
309a58eafd
Add [junos_l2_interfaces] resource module (#59693)
* Add [junos_l2_interfaces] resource module

*  Add new resource module junos_lag_interfaces.
*  Targets model https://github.com/ansible-network/resource_module_models/pull/12
*  Deprecate junos_l2_interface module

* Fix CI failures

* Fix CI issues
2019-08-09 13:09:19 +05:30
Matt Clay
3777c2e93d Fix plugin names when loading all plugins. (#59950)
* Fix plugin names when loading all plugins.

Add an integration test to verify plugin __package__ and __name__ are correct.

* Make sure filter and test names are unique.

* Remove __package__ test.

On Python 2.x __package__ is not set, but it is on Python 3.x.
2019-08-09 07:23:12 +01:00
yanzhangi
9aabe70452 update ce_aaa_server_host to fix bugs (#60272) 2019-08-08 22:52:25 -04:00
Abhijeet Kasurde
647b78a09c
VMware: Check if datastore is valid (#58872)
Check validation of datastore selected using autoselect_datastore API.

Fixes: #58541

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-08-09 07:56:52 +05:30
Andrew Gaffney
b38cb37728
Transform octal escape sequences in mtab fields (#60122) 2019-08-08 16:31:42 -05:00
Matt Martz
707e33793d
Undeprecated the skip argument for first_found. Fixes #58942. Fixes #59949. (#60161) 2019-08-08 13:55:11 -05:00
James Cassell
c954c07271 TRANSFORM_INVALID_GROUP_CHARS: document "ignore" option (#57318)
Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
2019-08-08 13:50:20 -04:00
Strahinja Kustudic
54d9d7805d systemd module will now wait on deactivating state (#59471)
If a service is in the 'deactivating' state running systemctl stop foo,
would wait for the foo service to actually stop before it exits. The
module didn't behave like that and it considered the deactivating state
as if the service wasn't running. This change will align the module with
the systemctl behaviour.
2019-08-08 12:56:17 -04:00
Jiri Hnidek
577bb88ad8 Added support for syspurpose to redhat_subscribtion module (#59850)
* Added several unit tests
* Added documentation for new syspurpose option and suboptions
* Simplified specification of module arguments
* Added new changelog file with fragments
2019-08-08 11:43:05 -04:00
Nathan Swartz
10543c8a4c Facts dev upstream (#57082)
* Improved netapp_e_facts module.

Added the following facts:
  - storage system segment size
  - cache block size capabilities
  - workload tags
  - storage array hosts
  - host groups
  - list of mapped volumes for each initiator

* Remove proxy specific facts from netapp_e_facts module

* Add unit tests for netapp_e_facts module.
2019-08-08 11:36:23 -04:00
Drew
6932a5b357 add npipe support to docker_swarm_service (#60073)
* add npipe support to docker_swarm_service

* add changelog fragment

* tweak changelog fragment formatting

* Update lib/ansible/modules/cloud/docker/docker_swarm_service.py

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-08-08 17:25:13 +02:00
yanzhangi
c2e7683926 update ce_aaa_server to fix bugs (#60270)
* update ce_aaa_server to fix bugs

* update ce_aaa_server to fix bugs
2019-08-08 11:03:42 -04:00
yanzhangi
66c3e9bb9b update ce_acl to fix bugs (#60274) 2019-08-08 11:03:29 -04:00
Grey Christoforo
29f89b33ba pacman: fix package state detection (#51311) 2019-08-08 16:48:57 +02:00
Ganesh Nalawade
6f0aae256d
Add [junos_lldp_interfaces] model (#59720)
* Add [junos_lldp_interfaces] model

*  Add new resource module junos_lldp_interface
*  Targets model https://github.com/ansible-network/resource_module_models/pull/40
*  Deprecate junos_lldp_interface module

* Fix CI issues
2019-08-08 18:23:54 +05:30
Nathan Swartz
f6ae6eb3e0 Remove automatic default group assignment in netapp_e_host module (#60239) 2019-08-08 08:48:09 -04:00
Trishna Guha
87a568da0b
Add nxos_lacp resource module (#59717)
* Add nxos_lacp resource module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add commands in module doc

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-08 16:52:16 +05:30
Manu Lange
6a5cd9a820 prevent recursive logging csharp stackoverflow. (#59503)
* prevent recursive logging situation.

* Add changelog
2019-08-08 09:50:41 +10:00
Chris Archibald
2cae0739e9 updates (#60143) 2019-08-07 19:44:44 -04:00
Stuart Pittaway
2c90ddd44d Allow encryption of volumes based off snapshots (#58983)
Since May 10, 2019 AWS have allowed encrypted volumes to be created from snapshots.  BOTO3 allows this, but the EC2 module does not.  This change removes the restriction.

https://aws.amazon.com/about-aws/whats-new/2019/05/launch-encrypted-ebs-backed-ec2-instances-from-unencrypted-amis-in-a-single-step/
2019-08-07 16:38:17 -07:00
kfattig
d5a02fb3c8 Updated Docs to clarify how 'become' is handled (#60006) 2019-08-08 08:48:21 +10:00
ximon18
2cca9176a7 Added a Docker Machine dynamic inventory plugin (#54946)
* Added my Docker Machine dynamic inventory plugin (from https://github.com/ximon18/ansible-docker-machine-inventory-plugin) to begin the process of proposing it for inclusion in Ansible core. There are no integration tests yet. The docker_swarm inventory plugin has such tests but has some concerning note in its 'aliases' file about disabling docker due to test instability and also I wouldn't know at his point how to get Docker Machine installed on the integration test platform.
2019-08-07 18:14:14 -04:00
silverwizard
5d8302120b Removed breaking type check from nagios module (#49568)
* Removed extraneous type check from nagios module, in order to allow python 3.x

* Removed now useless import types

* Added changelog fragment

* Update changelog.

* Rebased and removed check due to module adding earlier guardrails

* Updated changelog to mention earlier fix adding now completely removed guardrails

* Remove superfluous type checks. Fix docs type.

* Update ignore.txt.
2019-08-07 22:43:14 +02:00
Nilashish Chakraborty
7b90e8aec4
Add iosxr_lacp_resource module (#59724)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-08-08 00:13:06 +05:30
Moritz Maisel
5a6003d0ed fix misleading example in docker_image doc (#60207)
Using docker_image to tag an image as "latest" only updates an existing
tag when used with "force_tag: yes" option. As "latest" is present in
most cases, the option is added to the example to prevent unexpected
behaviour.
2019-08-07 13:44:37 -04:00
Martin Krizek
164881d871 Remove UnsafeProxy (#59711)
* Remove UnsafeProxy

Move the work from UnsafeProxy to wrap_var and add support for bytes.
Where wrap_var is not needed, use AnsibleUnsafeBytes/AnsibleUnsafeText
directly.

Fixes #59606

* item is not always text

* Address issues from reviews

* ci_complete
2019-08-07 10:39:01 -05:00
Nathan Swartz
e80f8048ee Fix netapp_e_volume wait-for-initialization to complete issue. (#58304)
* Fix netapp_e_volume wait-for-initialization to complete issue.

* Add unit tests for wait_for operations in netapp_e_volume module.
2019-08-07 11:28:39 -04:00
Stanislav S. Yarmonov
18e0d679dd hcloud: Fix missing labels propagation in inventory plugin. (#57586) 2019-08-07 15:51:09 +02:00
Wojciech Wypior
ce1f25cffd adds module to manage apm acls (#59992) 2019-08-07 06:48:55 -07:00
Wojciech Wypior
77b323459f adds more modules to bigip provision (#59996) 2019-08-07 06:45:27 -07:00
Wojciech Wypior
7b97abf6a2 adds apm module to manage network access components for APM (#59993) 2019-08-07 06:44:57 -07:00
Wojciech Wypior
47e3ed8100 adds module to manage device self signed certificates (#59994) 2019-08-07 06:44:41 -07:00
Wojciech Wypior
0d92abad7d adds module to manage snat translations (#59995) 2019-08-07 06:43:10 -07:00
Wojciech Wypior
57cbfae797 added user information collection to bigip_device_info (#60016) 2019-08-07 06:42:43 -07:00
Jill R
4308b87d72 Don't truncate cidr_ipv6 addresses in ec2_group.py (#59106)
* Better cidr_ipv6 validation in ec2_group.py

* Improve warning/error handling, add changelog

* Update unit test for ipv6 validation

* Fix logic that was causing non /128 cidrs with host bits to not be handled
2019-08-07 08:39:55 -04:00
Marat Sharafutdinov
8751319820 Add wait_sleep parameter for the k8s module (#59714) (#59854) 2019-08-07 21:27:54 +10:00
MyronFanQiu
8c0ec5fd82 delete the check for the resource group (#58492) 2019-08-07 05:36:14 -04:00
Hugh
041ede30b3 Update azure_rm_appserviceplan_facts.py (#58847)
<!--- Your description here -->

+label: docsite_pr
2019-08-07 05:25:36 -04:00
Diane Wang
d5bff7a87f VMware: vmware_export_ovf fix timeout and export path issue (#60062)
* fix timeout and export path issue

* change path type
2019-08-07 05:05:42 -04:00
Martin Nečas
279617a94e add docs (#60192) 2019-08-07 04:41:33 -04:00
Jordan Borean
45d0e5994a
win_user - use proper error code when failing to validate creds (#60181) 2019-08-07 18:28:44 +10:00
sushma-alethea
92187ae53e icx: new module icx_command (#59903)
* new module

* new cliconf

* cliconf

* icx cliconf

* icx test units module

* icx units module

* icx banner unit test

* added notes

* new changes

* icx .rst

* modified platform_index.rst

* modified platform_index.rst

* changes resolved

* PR comments resolved

* Update platform_index.rst

PR comment resolved

* new module

* new cliconf

* cliconf

* icx cliconf

* icx test units module

* icx units module

* icx banner unit test

* added notes

* new changes

* icx .rst

* modified platform_index.rst

* modified platform_index.rst

* changes resolved

* PR comments resolved

* Update platform_index.rst

PR comment resolved

* new module icx_command

* PR issue

* new PR fix
2019-08-07 13:27:24 +05:30
Martin Nečas
fb87bafaae ovirt vnic network filter fix (#59727)
* init network filter fix

* add check_params

* update migratable state

* update pass through check

* update pep8 syntax

* allow remove description

* update_check change default attr for network_filter and qos

* update_check qos and network filter update

* add docs about exeption

* remove blank space

* update docs and add comments to conditions

* update comment

* update migratable var for pass_through enabled
2019-08-07 03:49:36 -04:00
Daniel Mellado Area
7b583e114d Remove description from junos_l3_interfaces (#60058)
The description will be just handled by the _interfaces module, this one
will be just dealing with l3 config options.
2019-08-07 13:10:49 +05:30
The Magician
d165223f74 New Module: gcp_compute_autoscaler_facts (#60097) 2019-08-07 01:09:23 -04:00
dx0xm
24274b72c9 UCS: new module ucs_vlan_find (#59220)
* UCS: new module to find vlan(s) based on different criteria
* extending ucs doc
* doc update
* Minor fix
2019-08-07 09:02:23 +05:30
Chris Archibald
5673482460 bug fix (#60140) 2019-08-06 17:53:29 -04:00
Matt Martz
923e21836b
Move plugin loader playbook dir additions back to Playbook instead of PlaybookCLI (#59557)
* Move plugin loader playbook dir additions back to Playbook instead of PlaybookCLI. Fixes #59548

* Restore cli additions
2019-08-06 15:58:15 -05:00
Alex Stephen
61d60d07d1 no logging for service account contents (#60149)
* no logging for service account contents

* changelog

* fixes
2019-08-06 15:27:11 -05:00
Jordan Borean
94f5e2d9ed
ansible-galaxy - ignore cert failures for login (#59959) 2019-08-07 05:59:34 +10:00
Nathan Swartz
acbffce079 Host dev upstream (#57086)
* Improve netapp_e_host module

Add host type strings for windows, windows cluster, linux and vmware to netapp_e_host module
Make host port information case-insensitive in netapp_e_host module
Fix port removal and default group.
Fix port reassignment in netapp_e_host module.
Fix port label or address change within existing host object in module netapp_e_host
Add unit and integration tests

* Created new unit test for netapp_e_host module
2019-08-06 15:01:22 -04:00
Barry Peddycord III
80e5b2ade5 Update broken NCLU documentation link (#60009) 2019-08-06 13:46:31 -04:00
Wojciech Wypior
2af67f0dce fixes issue with RD encoding in names (#59990)
fixes issue with file download function on ASM file transfer endpoints
corrects doc fragments
removes not used parameters
corrects various sanity failures previously ignored across multiple modules
2019-08-06 10:11:02 -07:00
monobaila
54b04f227e Update validate example in copy.py (#60053) 2019-08-06 11:32:40 -04:00
Timal Peramune
faebe22439 Conflicting Documentation (#60135)
##### SUMMARY
"state" parameter isn't "required" since the default is already set to "present"
2019-08-06 11:32:12 -04:00
Timal Peramune
828e346f2c Conflicting Documentation (#60136)
##### SUMMARY
"state" parameter isn't "required" since the default is already set to "present"
2019-08-06 11:31:13 -04:00
Timal Peramune
1c0b733489 Conflicting Documentation (#60137)
##### SUMMARY
"state" parameter isn't "required" since the default is already set to "present"
2019-08-06 11:27:50 -04:00
Nathan Swartz
a9aeabb456 Improve netapp_e_storagepool and add units. (#57095)
Refactored module to use eseries base class
Removed E322 and E326 for netapp_e_storage module from the ignore.txt file
Updated version_added quotes in netapp_e_storagepool
2019-08-06 10:02:14 -04:00
Nilashish Chakraborty
2c432f8bc7
Add vyos_l3_interfaces resource module (#59929)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-08-06 19:30:58 +05:30
Daniel Mellado Area
e3681c049c
Add junos vlans resource module (#59041) 2019-08-06 16:00:01 +02:00
Abhijeet Kasurde
2a1393e0e1
VMware: Check dvswitch presence before accessing it (#60052)
Check if dvswitch object is not None before accessing it's
properties such as UUID. This can be due to two reason

1. Permission issues
2. There is no association between given distributed virtual portgroup
distributed virtual switch

Fixes: #59952

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-08-06 10:38:50 +05:30
kfattig
dd7b9627ad Runas docs (#60082)
* Mention seclogon requirement in runas docs

* Mention seclogon requirement in Win become docs
2019-08-06 10:44:17 +10:00
Alex Stephen
ac5228390c Removing validate-module exceptions on GCP modules (#60113)
* facts modules with new types
* remove ignores on sanity tests
* removing new modules
2019-08-05 16:17:06 -07:00
The Magician
2a64a84667 New Module: gcp_cloudtasks_queue_facts (#60095) 2019-08-05 18:38:09 -04:00
The Magician
4317a97c42 New Module: gcp_compute_autoscaler (#60096) 2019-08-05 18:38:00 -04:00
The Magician
26a2d84dba New Module: gcp_compute_snapshot (#60098) 2019-08-05 18:37:51 -04:00
The Magician
820cfbbb77 Bug fixes for GCP modules (#60089) 2019-08-05 18:26:14 -04:00
The Magician
8241fd88de Bug fixes for GCP modules (#60090) 2019-08-05 18:26:06 -04:00
The Magician
fcc869ab7a Bug fixes for GCP modules (#60091) 2019-08-05 18:25:57 -04:00
The Magician
0234937ca3 Bug fixes for GCP modules (#60092) 2019-08-05 18:25:49 -04:00
The Magician
de8d428157 Bug fixes for GCP modules (#60093) 2019-08-05 18:25:41 -04:00
The Magician
c1a99c390c Bug fixes for GCP modules (#60088) 2019-08-05 18:16:26 -04:00
The Magician
5e0bcc60b5 New Module: gcp_cloudtasks_queue (#60094) 2019-08-05 16:47:52 -04:00
Andrey Klychkov
d2cc9f5f06 Bugfix 60043: turn off the default db warning where it doesn't make sense (#60105) 2019-08-05 16:28:00 -04:00
Felix Fontein
aecdfd397e ecs_taskdefinition_facts: rename to ecs_taskdefinition_info (#60023)
* Rename ecs_taskdefinition_facts to ecs_taskdefinition_info.
2019-08-05 12:47:35 -07:00
Nathan Swartz
41235ac05a Improve netapp_e_hostgroup and add unit tests. (#57094)
* Improve netapp_e_hostgroup and add unit and integration tests.

netapp_e_hostgroup was refactored for maintainability and improved
documentation clarity.

* Remove ignore sanity check E338 for netapp_e_hostgroup module

* Add __future__ import (absolute_import, division, print_function) to test_netapp_e_hostgroup unit test.
2019-08-05 13:19:23 -04:00
Xu Yuandong
13c8f7b00c It is necessary to undo mmi-mode enable after running commands. (#60071) 2019-08-05 11:52:25 -04:00
Xu Yuandong
16e237e095 set mmi-mode enable to run commands nad unset after running. (#60075) 2019-08-05 11:52:11 -04:00
Andrew Gaffney
32a8d8ae2a
Move definition of UnixHTTPSConnection behind guard (#60049)
This allows module_utils/urls.py to not immediately fall over when run
against a python without SSL support.
2019-08-05 10:46:47 -05:00
Matt Martz
df6b8d2a4a
Fix async output with adhoc callbacks. Fixes #15988 (#59935) 2019-08-05 10:36:41 -05:00
Chris Archibald
be24db8886 New module na_ontap_object_store (#59048)
* New module object store

* fixes

* fix tests
2019-08-05 09:27:38 -04:00
Lukas Kämmerling
38848a4b0c hcloud: Add basic hcloud_route module (#59908) 2019-08-05 14:35:05 +02:00
Trishna Guha
e46237d705
Fix nxos_facts httpapi (#60055)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-05 18:01:29 +05:30
Lukas Kämmerling
8a5bde798a hcloud: Add hcloud_server_network module (#60061) 2019-08-05 14:06:22 +02:00
Lukas Kämmerling
0377c51c3a hcloud: Add hcloud_subnetwork module (#59781) 2019-08-05 11:13:28 +02:00
Trishna Guha
021b1810c9
Add nxos_vlans resource module (#59294)
* Add nxos_vlans resource module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* address review comments

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix CI failure and udpate tests

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add commands in module doc

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-05 12:50:16 +05:30
Mike Wiebe
9610f2b8ac NX-OS Telemetry Resource Module (#59126)
* Combined telemetry module commit

* Minor fixes

* Add back whitespace

* Add telemetry subscription support and simplify

* Remove comment line

* Make ansibot happy

* Create common build_args method

* More ansibot fixes

* Refactored integration tests, remove old files

* Add subscription tests

* Add integration tests

* Update module docs

* Test updates

* Address review comments

* Comment should be one line, not two

* Address Trishna comments

* State deleted should purge all config

* Remove misleading comment

* Doc fixes

* Fix source int bug and remove local debug msg

* Add additional integration test checks
2019-08-05 11:35:46 +05:30
Simon Dodsley
178db5f3ed Fix bug in purefa_facts where remote pgroup without a schedule is skipped (#60030) 2019-08-04 04:29:23 -04:00
Wojciech Wypior
ee0c19e519 corrected lib imports to work with python 2.x (#60017) 2019-08-02 22:11:03 -07:00
Wojciech Wypior
1268993506 added previously omitted parameter in gtm topology module (#60015) 2019-08-02 22:09:20 -07:00
Wojciech Wypior
95ef456bb7 fixes options parameter idempotency issue on v14.x (#60019) 2019-08-02 22:06:07 -07:00
Wojciech Wypior
d224a7ccf6 fixes idempotency issues with IPV6 addresses (#60021) 2019-08-02 22:03:33 -07:00
Wojciech Wypior
2e54ac37b0 refactors bigip_firewall_log_profile to use correct patterns (#60014)
doc correction in bigip_pool
changes functions in bigip_message_routing_route
2019-08-02 14:49:05 -07:00
Wojciech Wypior
c9a9621a02 fixes issue with recieve parameter idempotency (#59999)
fixes assert statements in unit tests
2019-08-02 13:29:40 -07:00
Sam Doran
a9fe21bc62
docker_compose - use valid variable in exception message (#60020) 2019-08-02 15:57:22 -04:00
Andrey Klychkov
41e198b429 Issue 59955: add example to postgresql_query module (#59979) 2019-08-02 14:30:17 -04:00
Matt Davis
8d1f658ce4
move CLI entrypoints under ansible package (#60004)
* needed so ansible-test can always find the right ones to copy to a target
* renamed the underlying scripts to be properly accessible as Python modules
2019-08-02 11:27:02 -07:00
Timal Peramune
1b246d89e3 Conflicting documentation (#59982)
##### SUMMARY
The "mode" parameter is already 'push' by default, so "required: true" isn't necessary.
2019-08-02 12:49:20 -04:00
Matt Martz
38eee51057
Fix issue with empty cow_whitelist (#59946)
* Fix issue with empty cow_whitelist. Fixes #45631

* Account for None
2019-08-02 11:13:08 -05:00
Felix Fontein
f3e20346cb
Google: gcpubsub_facts -> gcpubsub_info (#57668)
* Rename gcpubsub_facts -> gcpubsub_info.

* Update porting guide and add changelog fragment.
2019-08-02 17:27:28 +02:00
Dave Bendit
fc558fb85f [docker_container] Adding support for mounts option (#49808)
* [WIP][docker_container] Adding support for `mounts` option

Fixes #42054

* Adjusting to current standards.

* Add changelog.

* Adjust types.

* Cleanup.

* Add idempotency checks for mounts.

* Improve diff for mounts.

* Linting.

* Python 2.6 compatibility.

* Fix error message formatting.

* Move mounts and volumes tests into own file.

* Add set of mount tests.

* Golang's omitempty for bool omits false values.

* Simplify sanity checks. Correct order of volume_options sanitization and usage.

* Fix key.

* Fix check.

* Add tests where both volumes and mounts show up.

* Add collision test.
2019-08-02 17:11:14 +02:00
Felix Fontein
a7573102bc
docker_container: fix port bindings with IPv6 addresses (#59715)
* Pass IPv6 addresses for port bindings without square brackets.

* Add changelog.

* Add test.
2019-08-02 17:10:39 +02:00
Ruediger Pluem
f94772f807 Only error out if the gid exists with a different group name (#59769)
Only error out if the gid exists with a different group name as
otherwise it will error out if the group with this gid already
exists, like on a rerun of the playbook. This fixes a regression
introduced by 4898b0a4a2.
2019-08-02 15:51:10 +02:00
Sumit Jaiswal
b847327645
Resource module for ios_interfaces and Facts Update (#59716)
* ios interfaces resource
2019-08-02 14:34:05 +05:30
Markus Bergholz
18aae0a02b add new module with integration tests to manage gitlab project variables (#56574)
* add new module with integration tests to manage gitlab project variables

* fix invalid yaml in DOCUMENTATION variable and don't import * from ansible module

* remove extends_documentation_fragment and put imports after DOCUMENTATION/EXAMPLES/RETURN/ANSIBLE_METADATA

* fix author in documentation and remove import from display

* add alias file for integration test

* split long lines and try to fix the author key

remove tailing whitespace

* replace email address with github username

* adding the at style to username

* add metaclass and future import

* add state variable to be able to delete selected variables

* add test with state = absent

* update documentation. scheme is necessary

* use singular in exmaple section

* use key purge instead of purge_vars

use purge instead of purge_vars also in the integration test

* create gitlab object in the ansible main function

* remove usedless .format

* follow best practice fail message

* add return documentation, return information about which variables were added, updated or removed and catch gitlab api auth error

* use module_utils.api with api_url and api_token

* use dict instead of list for vars

* use project name instead of name as playbook key

* add ansible checkmode_support, reduce variables in gitlab_project_variables class, remove wrong/duplicated HAS_GITLAB_PACKAGE check

* use extends_documentation_fragment and don't pop elements from basic_auth_argument_spec

* use just project_variable as output variable

* update mutually_exclusive as suggested

* re-add api_token documentation, because it is not included in api basic auth

* remove useless statement

remove unnecessary if

* add one test with a changing value

* put type at first position

* keep item to reduce api calls, build array and keep indexes by replacing with None instead of poping

* more asserts

* Update lib/ansible/modules/source_control/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

Update lib/ansible/modules/source_control/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

Update lib/ansible/modules/source_control/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

Update lib/ansible/modules/source_control/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

Update lib/ansible/modules/source_control/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

Update lib/ansible/modules/source_control/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* remove unused return key from documentation

msg is only returned when failed

* Update lib/ansible/modules/source_control/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* remove error key, because it is not returned

* change also documentation from purged_vars to purge

* Update lib/ansible/modules/source_control/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

Update lib/ansible/modules/source_control/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

Update test/integration/targets/gitlab_project_variable/tasks/main.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>

Update test/integration/targets/gitlab_project_variable/tasks/main.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>

* remove extra spaces

fix wrong spelling

* expand return value documentation with examples

* add check_mode test

reorder tests. first the check_mode test, later all other tests

* Update lib/ansible/modules/source_control/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* fix existing keys in 'present' array

rework key handling (reduce code)

fix integration tests

use untouched instead of present to identify unchanged variable keys

fix wrong replacement

minor fixes on request

set aliases to unsupported, because the test succeed

remove posix group1 because it conflicts with unsupported

remove useless item from aliases

* rework gitlab connection
2019-08-02 09:08:37 +02:00
Felix Fontein
6d074d8a94
Move ome_* and idrac_* modules one level up (#59698)
* Move ome_* and idrac_* modules one level up.

* Fix paths.

* Fix package name.

* Oranize in different directories.

* Update BOTMETA.

* Update new ignore entries.

* Revert "Update BOTMETA."
Revert "Oranize in different directories."
Adjust ignores.txt.
2019-08-02 09:06:18 +02:00
Sam Doran
372f21e3b5 Handle new output for podman image build (#59807) 2019-08-02 00:55:32 -04:00
Jesse Evers
e410dcbfed Add logic to handle multiple actions in an ALB listener rule, Fixes #41861 (#41975)
* added logic to handle multiple actions in an ALB listener rule (#41861)

* fix linting and pep8 issues

* added test for multiple actions using OIDC authentication

* added error messages related to old versions of botocore and multiple actions

* fix action validation error checks (need to check the exception string)

* added logic to make oidc configs idempotent (remove clientsecret for check)

* modified TargetGroupName to TargetGroupArn substitution to account for multiple rule actions

* refactored tests so that it can be run against different versions of botocore

* fix runme.sh to refelct changes to cloud testsuite

* add UseExistingClientSecret to oidc config (AWS api change)

* remove tests for OIDC auth action; add tests for redirect and fixed-response

* add in fixes from markuman and mjmayer

* remove documentation for cognito integration (not sure how to test); added example config for fixed-response and redirect actions

* renamed oidc/multiple action tests; leaving commented due to some AWS API changes

* pep8 fix

* more pep8 fixes

* Restructure elb_application_lb test suite

Move from runme.sh to virtualenv based roles

Update policies to fix tests

Don't log temp dir deletion, so many files in the diff!
2019-08-02 10:40:53 +10:00
Jordan Borean
309e342aaa
Remove six decorator for unicode text conversion (#59895) 2019-08-02 09:15:31 +10:00
Abhijeet Kasurde
056aac1e30 Minor fixes in galaxy command for collection (#59846)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-08-02 07:48:34 +10:00
Jordan Borean
88e3449189
Fix ansible-galaxy import command to use argspec instead (#59898) 2019-08-02 07:31:28 +10:00
Jakob Ackermann
20b5ff5ab7 [s3_bucket] access the bucket encryption response gracefully (#59826)
Signed-off-by: Jakob Ackermann <das7pad@outlook.com>
2019-08-01 14:00:07 -07:00
Nathan Swartz
26fff6f5c3 Improved netapp module utility for E-Series. (#59527)
Add header option to request method in NetAppESeriesModule
Add multipart formdata builder function
Fix issue with url port change
2019-08-01 13:24:38 -04:00
yanzhangi
a01ee2759d Update ce_vrrp to fix bugs (#59677)
* update ce_vrrp to fix bugs

* update ce_vrrp to fix bugs

* update ce_vrrp to fix bugs

* update ce_vrrp to fix bugs
2019-08-01 11:05:30 -04:00
James Cassell
17f2b5f73e os_subnet: allow using non-default subnet pool (#52608) 2019-08-01 10:11:53 -04:00
Abhijeet Kasurde
025e30ea0c VMware: add support for http_proxy in connection API
This commit allows users to access a vCenter or a ESXi through a
HTTP CONNECT based proxy.

To do so, the users have to set the `proxy_host` and `proxy_port`
variables.

The can also use the `VMWARE_PROXY_HOST` and `VMWARE_PROXY_PORT`
environment variables.

This feature depends on pyvmomi > v6.7.1.2018.12.

Fixes: #42221

Co-Author: Abhijeet Kasurde <akasurde@redhat.com>
Co-Author: Gonéri Le Bouder <goneri@redhat.com>
2019-08-01 15:57:26 +02:00
benjdudas
4eb156b2f5 regex match for lowercase Cisco (#59550) 2019-08-01 18:57:27 +05:30
itercheng
eea46a0d1b Support Ericsson device management (#59277)
* Support Ericsson device management

* modify code

* modify error

* delete redundant file

* delete file

* modified error

* modify additional file name

* delete code

* add blank line

* delete redundant code

* add platform_eric_eccli.rst

* modify syntaxError

* modify document

* modify error

* modify maintaners

* modify document

* add end_string
2019-08-01 16:55:10 +05:30
Abhijeet Kasurde
07e7b69c04
VMware: minor changes in vmware_dvs_portgroup_find (#59911)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-08-01 15:14:17 +05:30
dx0xm
c35b512413 vmware: new module vmware_dvs_portgroup_find (#59567)
* vmware: new module to find portgroup(s) based on different criteria
2019-08-01 14:52:51 +05:30
Mario Lenz
3aa73cb6b8 VMware: Refactor vmware_cluster into several modules (#58468)
Refactor vmware_cluster into several modules (vmware_cluster, vmware_cluster_drs, vmware_cluster_ha and vmware_cluster_vsan) as discussed in #58023.

vmware_cluster lacks a lot of configuration options for DRS, HA and vSAN. Implementing them
all in vmware_cluster would make the module hard to maintain. Therefore, splitting it into several
modules and implementing the missing configuration options in them seems a good idea to me.

This is step one, refactoring vmware_cluster into several modules. Step two, implementing more
configuration options for DRS, HA and vSAN, will follow.
2019-08-01 10:35:29 +02:00
Sumit Jaiswal
b2db38bbc6
resolves test error for PR59550 (#59901)
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-08-01 13:34:14 +05:30
Xu Yuandong
adfbd04b3a ce_netstream_template: update to fix a bug. (#59690)
* update to fix a bug.

* Update ce_netstream_template.py

* Update ce_netstream_template.py

* Update ce_netstream_template.py
2019-07-31 22:54:34 -04:00
Sandra McCann
eb15ee91df removed module from support list (#59878) 2019-07-31 14:58:24 -04:00
Dusan Matejka
f1fd13c0ef Fixed "dictionary changed size during iteration" for zabbix_template when used with newest Python3 (#59181) 2019-07-31 14:30:29 -04:00
glyngholm
f46eb8ebcd Headers in URL lookup plugin (#59555)
* Update url.py

Allow passing of headers to URL lookup plugin
2019-07-31 14:23:55 -04:00
Nilashish Chakraborty
730fa78ca4
Add vyos_interfaces resource module (#58589)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-31 23:06:53 +05:30
Simon Dodsley
288d74ca48 Update FlashBlade Directory Service config module to support NIS (#59608) 2019-07-31 13:33:24 -04:00
yanzhangi
d6fd4eb8e6 update ce_bgp_af to fix bugs (#59678)
* update ce_bgp_af to fix bugs

* update ce_bgp_af to fix bugs

* update ce_vrrp to fix bugs

* update ce_bgp_af to fix bugs

* update ce_bgp_af to fix bugs
2019-07-31 13:28:46 -04:00
Sam Doran
81d254da4c
Update version in metadata for bundled distro (#59869) 2019-07-31 12:38:25 -04:00
Maciej Delmanowski
75be309242 Don't warn if local user is found in user database (#56838)
If the 'local' parameter of the 'user' Ansible module is enabled, and
the user has been found in the local user database, don't emit
a warning, because this is an expected outcome.

Add changelog and integration tests

Co-authored-by: drybed <drybjed@gmail.com>
2019-07-31 12:14:22 -04:00
Jered Sutton
cb9ab42ab8 Document behavior of fetch when file already exists (#59816)
* Document behavior of fetch when file already exists
2019-07-31 12:09:58 -04:00
Mark Chappell
934d25a820 iam_password_policy: boto expects pw_expire to be ommitted when setting no expiration requirements (#59848)
Fixes #59102
2019-07-31 12:03:30 -04:00
Abhijeet Kasurde
3eeaf2f974 Add description of collection_paths in base.yml (#59778)
Fixes: #59775

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-31 11:57:44 -04:00
Mark Chappell
c1e5758c4c Add missing aws modules to aws module defaults group (#59788)
* Add missing aws modules to aws module defaults group

* add changelog
2019-07-31 11:53:14 -04:00
Kevin Breit
b09fbc3bf3 New module - meraki_webhook (#57855)
* Initial commit for meraki_webhook

* Split integration tests into two files to avoid delegate_to
2019-07-31 11:31:16 -04:00
Kevin Breit
d105c205ef meraki_snmp - Add support for network SNMP settings (#57708)
* meraki_snmp module supports network SNMP settings
- Network SNMP settings were added to the API
- Parameters are different so it's a new data structure
- Full suite of integration tests
- Commit includes some cleanup as well

* Add reset task for SNMPv3
2019-07-31 11:29:57 -04:00
Kevin Breit
516b39b79a meraki_organization - Add deletion support (#59415)
* Add support for deleting organizations
- Still working on integration tests

* Update documentation and verify check mode works
2019-07-31 11:29:42 -04:00
Timal Peramune
7afa5913a7 Conflicting documentation (#59777) 2019-07-31 11:17:59 -04:00
Felix Fontein
1534d6aea3 Update docs for pesize. (#59751) 2019-07-31 11:06:52 -04:00
sushma-alethea
f2cb44633a Modules to manage ICX devices (#58969)
* new module

* new terminal

* new terminal

* new cliconf

* cliconf

* icx cliconf

* icx_cliconf

* icx test units module

* icx units module

* icx banner unit test

* PR changes resolved

* changes resolved

* Changes Resolved

* check_running_config changes resolved

* added notes

* removed icx rst

* new commit

* new changes

* deleted icx rst

* icx .rst

* modified platform_index.rst

* modified platform_index.rst

* changes resolved

* PR comments resolved

* Update platform_index.rst

PR comment resolved
2019-07-31 20:01:41 +05:30
Daniel Mellado Area
58a53fe0eb
Add junos_l3_interfaces (#59026) 2019-07-31 16:29:32 +02:00
sky-joker
47f9f43b0d VMware: Modify guest_id reference URL of vmware_guest (#59861) 2019-07-31 19:42:29 +05:30
Nathaniel Case
80d8058f5c
Change sub_plugin check to completely ignore napalm (#59298)
This also fixes cases where sub_plugin might not be loaded in executor
2019-07-31 08:46:17 -04:00
Marc Hörsken
98df8e01db Fix py3 decoding issues in cyberarkpassword (#59500)
* Fix py3 decoding issues in cyberarkpassword.py
* Use to_native instead of forced utf-8 decoding
* Use to_bytes to avoid trouble with Popen
* Create 59500-cyberarkpassword-fix-py3-decoding.yaml
2019-07-31 13:46:47 +05:30
Chris Archibald
dc427ff6d5 na_ontap_quota was not using vserver (#58594)
* fix issues

* fixes
2019-07-30 22:32:49 -04:00
Jordan Borean
04ec47bdf1
win_dsc - be more lenient with datetime parsing (#59703)
* win_dsc - be more lenient with datetime parsing

* Remove l that shouldn't be there
2019-07-31 08:45:37 +10:00
Markus Bergholz
196347ff32 ability to use lambda target in elb_target_group (#57394)
* enable elb_lambda_target test
2019-07-30 15:35:36 -07:00
Jordan Borean
652bfc7e19
win_template - use shared doc fragment for shared options (#59701)
* win_template - use shared doc fragment for shared options

* Change smart quote to em dash and fix whitespace issue
2019-07-31 08:05:24 +10:00
Simon Dodsley
4c1f52c6c0 Add support for preferred arrays to host configuration (purefa_host) (#59735) 2019-07-30 17:31:40 -04:00
Simon Dodsley
27c60a7cec Add ability to force immeadiate replication of a pgroup (#59785) 2019-07-30 17:31:23 -04:00
Peter Mounce
24d8e82655 Windows Setup doc; offer 10x perf improvement (#58259)
* Windows Setup; document 10x perf improvement
2019-07-30 15:53:17 -04:00
Fred-sun
6208294054 Update the document according to the yuwzho-datadisk branch (#59491) 2019-07-30 15:38:00 -04:00
Tyler
6a53147a15 Update homebrew.py (#59646)
##### SUMMARY

It should be known that this does not install homebrew. It only uses homebrew that is already installed. It's a core requirement.

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-07-30 15:36:29 -04:00
Abhijeet Kasurde
2ebc4e1e7e inventory: Handle IndexError while parsing limit file (#59776)
Handle IndexError exception raised while parsing the limit file.

Fixes: #59695

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-30 13:02:17 -04:00
6cUbi57z
2f403981b5 unarchive - add requirement of zipinfo command to docs (#59556) 2019-07-30 11:28:54 -04:00
nick6655
1d560e5ce9 pbrun: Use default value for become_user (#59754)
* Update pbrun.py

Require ternary operator for if get_option('user') returns NoneType object.

* Update pbrun.py

Added default value to become_user in documentation.

* Update pbrun.py

Changed default for become_user to be '' instead of root.
2019-07-30 11:15:48 -04:00
Gonéri Le Bouder
1ec155e773 vmware_guest: clone VM with attached CDROM
If a VM has an attached CDROM, `backing` attribute of the CDROM will
be defined.
As a result, we cannot just loop `vm_obj.config.hardware.device` and check
for the existance of the attribute to decide if the entry is a
harddrive.

Instead, we check the type of the device, and only keep the
`vim.vm.device.VirtualDisk` disk.

This issue is actually breaking our test-suite with regular environment
because we keep a Fedora ISO attached to the VM.
2019-07-30 14:09:07 +02:00
Lukas Kämmerling
5bddd2f04a Add hcloud_network module (#59366)
* Add hcloud_network module

* Apply suggestions from code review

Co-Authored-By: Matt Clay <matt@mystile.com>

* Add notice about dependency

* Adjust tests

* Apply suggestions from code review

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Allow changing of ip range

* Add Setup step
2019-07-30 14:00:33 +02:00
Abhijeet Kasurde
0b27ec3ddc
Revert "mysql.py: remove unused import" (#59768)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-30 17:24:06 +05:30
Xu Yuandong
3c7e8f7905 ce_netstream_global: update to fix a bug. (#59689)
* update to fix a bug.

* Update ce_netstream_global.py
2019-07-30 06:19:29 -04:00
Jordan Webb
20c4ad3b95 Add pipelining to podman connection plugin (#57579)
* Add pipelining to podman connection plugin

* Add changelog fragment
2019-07-30 10:14:19 +02:00
Martin Krizek
fd899956b4
Use correct delegate_to hostnames in loops (#59659)
Fixes #59650
2019-07-30 09:46:29 +02:00
Abhijeet Kasurde
f7af4875d3 Misc typo fixes (#59620)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-29 17:05:26 -04:00
Fred-sun
2bc0eecdb3 Update azure_rm_webappslot document (#59494)
* Update azure_rm_webappslot document
2019-07-29 16:15:06 -04:00
Jiri Hnidek
978fe81a6d Added unit tests for redhat_subscription module (#58665)
* Fixed the redhat_subscription module:
  - Option 'pool_ids' works in Python3 now
  - It tries to attach only pools IDs that are available
  - Optimization of code: do not call list --available, when
    no pool is requested
  - Simplified configure() method
  - Small changes to generate same commands on Python2 and Python3.
    Order of arguments/options and pool IDs have to be same to
    be able to run unit test using Python2 and Python3.
  - Added fragments file for redhat_subscribtion module
2019-07-29 16:11:29 -04:00
John Mahowald
8944be32bf lvg: simplify pesize description (#59699)
Remove confusing phrase about pesize as a "multiple of 128KiB".
Allowed values are anything accepted by vgcreate -s,
powers of 2, minimum 1K for lvm2.

As pesize less than 1M is accepted since Ansible 2.6,
close #29295
2019-07-29 16:09:05 -04:00
The Magician
4a7e11ba9a Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59324) 2019-07-29 12:26:39 -07:00
Shrikant Chaudhari
0b8354751b Added new module avi_user.py (#57116)
* Added new module avi_user.py and tests for that

* Updated documentation as per module argspec

* Updated as per review comments on IP address

* Updated documentation for types

* Fixed sanity check failure for __future__ import

* Updated documentation as per review comments.
2019-07-29 11:49:04 -04:00
Xu Yuandong
9182d54e98 ce_config: Optimize multi-level views & fix a bug. (#59523)
* Optimize multi-level views

* update to rewrite load_config.

* update.

* update.

* update.

* update.
2019-07-29 08:54:51 -04:00
Tommy Brecher
4d775cbbf1 ec2_eip - added support for BYOIP and filtering reuse addresses by tag/value (#59180)
* change variable name from isinstance to is_instance (prevent overriding builtin function)

* Added support for:
  - Filtering existing Elastic IPs based on a tag name or it's value (when reuse_existing_ip_allowed is true)
  - Allocating new Elastic IPs from a given IPv4 pool (BYOIP support)

* yamllint corrections

* added examples for:
  -  tag_name,
  -  tag_value
  -  public_ipv4_pool

* remove aliases

* Added changelog fragment

* added integration tests for ec2_eip module

* removed space to trigger rebuild
2019-07-29 19:40:19 +10:00
MyronFanQiu
373e887e7f a bug fix for elastic pool name (#56820) 2019-07-29 17:13:56 +08:00
Abhijeet Kasurde
336be58665 VMware: Fix Service Content calls in vmware_deploy_ovf
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-29 11:00:02 +02:00
Martin Krizek
08d7905be2
Remove incorrect usage of UnsafeProxy (#59633)
This removes couple of uses of UnsafeProxy that relies on the
implementation that is no longer present in the codebase.
2019-07-29 09:48:09 +02:00
Xu Yuandong
86937e06e3 ce_file_copy: update to Compatible with multiple version of NETCONF API. (#59450)
* update to Compatible with multiple version of NETCONF API.

* update for  shippable.

* Update ce_file_copy.py

* Update ce_file_copy.py

* Update ce_file_copy.py

* Update ce_file_copy.py

* Update ce_file_copy.py
2019-07-29 02:02:32 -04:00
Tom Moore
a589cac18a Windows: new win_netbios module (#58331)
* Initial commit win_netbios module

* Ansibot sanity improvements.

* Corrected file permissions.

* Windows: module description update

* Adding integration tests

* Added missing alias file

* Improvements made to tests and WMI efficiency.

* Correction from sanity check failures

* Shippable corrections

* Moved reboot flag.

* Slight tweak to return value conditoin
2019-07-29 07:56:53 +10:00
Itai Malek
c24b841c0a fixed _merge_dictionaries calls in GcpSession class (#59375) 2019-07-28 08:00:24 +05:30
Sorin Sbarnea
7c6fb57b7d Implements extra_hosts for docker_image module (#59540)
* Implements etc_hosts for docker_image module

Allows custom hosts on docker_image module.

The of this option made impossible to use docker_image module to build
images that required a custom hostname in /etc/hosts. For running
containers this option was already present.

While the python-docker API uses extra_hosts term, our existing module
already uses etc_hosts argument, so it sounds better to have some
consistency between docker_container and docker_image.

Fixes: #59233

* Update test/integration/targets/docker_image/files/EtcHostsDockerfile

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/cloud/docker/docker_image.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update changelogs/fragments/docker_image_etc_hosts.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-07-26 16:39:21 -04:00
Ihor Borodin
3b5a96fcb7 Fixing race condition in ec2 inventory plugin (#59638)
* Fixing race condition in ec2 inventory plugin

Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>

* Fixing code block according to suggestion

* Adding changelog fragment
2019-07-26 13:27:48 -04:00
Sloane Hertel
007fe842b9
aws_ec2 inv plugin - fix author field (#59649)
* Fix author field

* Add BOTMETA entry to get notifications
2019-07-26 12:23:56 -04:00
Xu Yuandong
c3d1f9b085 ce_stp: update to fix a bug. (#59347)
* update to fix a bug.

* update for shippable.

* Update ce_stp.py
2019-07-26 12:09:53 -04:00
Kevin Breit
3cdc667888 New module - meraki_mx_l7_firewall (#55485)
* Initial commit for meraki_mx_l7_firewall module

* Add argument checking

* Sanity fixes

* Fix crash and improve integration tests

* Improved integration tests and coverage

* Reformat response data
- Module does not match argument structure of API
- PR reformats the response to match Ansible arg spec
- Improved integration tests

* Fix reformatting for diffs

* Create rename_* functions
- is_update_required() ignores the key id
- Meraki expects one of the keys to be id
- Function temporarily renames key to appId to get around this

* Tweak documentation and tests
- Tests now do an include so each task doesn't need delegate_to

* Fix which files I'm editing
2019-07-26 11:43:28 -04:00
Kevin Breit
f8f3986871 New module - meraki_nat (#52889)
* Initial commit for meraki_nat module
- Query fully works
- Present is still very much in development

* Add initial code for present functionality, not complete

* Add request documentation

* Add examples and return documentation.

* Added payload to requests
- Module seems to need new idempotency check

* Allow 1:1 and 1:many NAT to work
- New idempotency check method is probably required to work

* Make all three options work
- Module isn't idempotent

* Diff support
- Added integration tests
- Diff support isn't quite done

* Fix diff output

* Enable idempotency assertion in tests

* Add test assertions for code coverage

* Update documentation and tests
- Split tests to separate file to avoid delegate_to

* Fix blank line
2019-07-26 11:42:36 -04:00
Kevin Breit
db783eb2b9 New module - meraki_firewalled_services (#57289)
* Initial commit for module
- Module can query or modify network services on Meraki gear
- Check mode supported
- Integration tests included

* Small change to examples

* Move mutual exclusive to build in approach

* Sanity err

* Split integration tests into two files to avoid delegate_to

* Add the integration tests, woops
2019-07-26 11:39:20 -04:00
Pilou
65013c4001 consul_session: ensure certificate is checked when HTTPS is used (#58693)
* consul_session: ensure SSL certificate is checked

* consul_session: don't ignore validate_certs param
2019-07-26 15:05:38 +02:00
Sachidananda Urs
08b9e18d4f Call remove-brick only if no. of bricks > 0 (#56781) (#58635) 2019-07-26 07:15:11 -04:00
Simon Dodsley
d82446652f Update FlashBlade filesystem module to support quotas and NFS v4.1 (#59559) 2019-07-26 04:06:08 -04:00
Nilashish Chakraborty
3da4c0dd3a
Update argspec to normalize across platforms (#59596)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-26 12:30:26 +05:30
Abhijeet Kasurde
c1ee1f142d
gcp_utils: Handle JSON decode exception (#59427)
Handle json.loads exception rather than providing stacktrace

Fixes: #56269

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-26 11:31:07 +05:30
Adam Miller
49da47d09f
force_basic_auth for default httpapi connection auth (#59193)
The default for a httpapi connection is to do basic auth, however
when setting the url_username and url_password without
force_basic_auth, the call to ansible.module_utils.open_url would
not always properly handle the basic auth headers based on the
combinations of **kwargs passed. This ensures that is always the
case when no session token exists and as the goal is to use basic
auth in the event of not having a session token, this should be
a safe operation.

Signed-off-by: Adam Miller <admiller@redhat.com>
2019-07-25 16:40:09 -05:00
Nilashish Chakraborty
3a103405b1
Handle lowercase in version info (#59565)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-25 23:06:53 +05:30
basos g
3c8838f0f7 Add check mode indicators at the beginning and the end of the playbook, play, and task (#49432)
* Add integration tests for default callback check mode markers
2019-07-25 12:05:43 -04:00
Brian Coca
a5d409a8b2
point at corresponding version (#59200) 2019-07-25 11:54:01 -04:00
Dieter De Moitie
9b9066d10f Updated references to removed modules in documentation (#59580) 2019-07-25 11:41:07 -04:00
Andrey Klychkov
db26fe2f1e module_utils.common.*: removed unused objects (#59570) 2019-07-25 11:04:18 -04:00
Sandra McCann
cfe01390aa clarify ansible-galaxy collection cli command options (#59470)
* clarify ansible-galaxy collection cli command options
2019-07-25 09:41:37 -05:00
Gonéri Le Bouder
ef59dd2ca2 vmware_guest_network: fix the network look up
Before this fix, the module was not able to look up a `VM Network` located at
`/DC0/network/VM Network`. As a consequence, the test module was failing
with a real environment (Non-govcsim).
2019-07-25 14:02:52 +02:00
Xu Yuandong
585128e5ac ce_mlag_config: update to fix a bug. (#59336)
* update to fix a bug.

* update

* Update ce_mlag_config.py

* Update ce_mlag_config.py
2019-07-25 07:12:15 -04:00
Brian Coca
e9a37f8e31
prevent templating of passwords from prompt (#59246)
* prevent templating of passwords from prompt

  fixes CVE-2019-10206
2019-07-24 16:00:20 -04:00
Tomáš Pospíšek
4ef38fcee2 remove useless overhead (#59517)
in the examples for the apt module, pass the list directly to the `pkg` option instead of providing it in `vars`
2019-07-24 14:24:53 -05:00
Nilashish Chakraborty
119f2b873a
junos_ping supports only network_cli (#59534)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-24 23:11:27 +05:30
Nilashish Chakraborty
f2b0bfd4aa
Add iosxr_lacp resource module (#59281)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-24 22:55:42 +05:30
Sandeep Bandi
1d82d25ea2 Adding Avi ansible lookup module (#58667)
* Adding Avi ansible lookup module

(cherry picked from commit 77b8951f68cbc889e6595b2a359ca27b84a43c0d)

* Added description for examples

* Added debug logs and unit tests

* Fix __builtin__ import and restting super

* Fix pep8 errors

* Updated as per review comments on IP address
2019-07-24 11:35:04 -04:00
Andrey Klychkov
e9725862ca mysql.py: remove unused import (#59511) 2019-07-24 10:36:18 -04:00
Strahinja Kustudic
5fc769f6b1 sysctl - Reload also when current system values differ (#56153)
Previously if `sysctl_set=no` (which is the default) this module only
checked for changes in the sysctl.conf file to decide whether it should
reload it or not. This means that if the values in the conf file are the
same as they are set with the module, but the current values on the
system are different, that this module wouldn't apply the changes on the
system and thus the value set with the module wouldn't be applied on the
OS. This isn't obvious and it doesn't make sense that the module works
like that by default, especially because there is a separate option
`reload`. Now sysctl will also check if the current value differs on the
system and if it does, it will reload the file again.
2019-07-24 10:04:15 -04:00
Abhijeet Kasurde
401e70c0a2
VMware: add facts about tags in vmware_cluster_facts (#56848)
Fixes: #46458

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-24 15:45:15 +05:30
Andrey Klychkov
fd35833554 postgresql modules: fix by flake8 (#59497) 2019-07-24 15:40:44 +05:30
Xu Yuandong
93265bf92e ce_mtu: update to fix bugs. (#59343)
* update to fix bug.

* Update ce_mtu.py

* Update ce_mtu.py

* Update ce_mtu.py
2019-07-24 05:53:08 -04:00
Abhijeet Kasurde
281307b492
VMware: make properties configurable (#53050)
This allows user to control set of properties which can be included
in the hostvars.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-24 15:18:32 +05:30
Martin Krizek
1010363c0b
Preserve original variables when using a loop (#59426)
Fixes #59414
2019-07-24 11:35:14 +02:00
Jill Rouleau
5a7f579d86 Fix clouds_yaml_path type in openstack inventory
Fixes: 59442
2019-07-24 10:25:44 +02:00
Xu Yuandong
6ff54c546e update to fix a bug (#59346) 2019-07-24 04:09:53 -04:00
Abhijeet Kasurde
bafd06bc89
VMware: Fix custom value in vmware_guest (#58157)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-24 10:54:16 +05:30
Jordan Borean
ba7097cba3
Collection test (#59488)
* Add missing __init__.py for collection unit tests

* Added more tests for collection install and remove default path
2019-07-24 12:38:32 +10:00
Abhijeet Kasurde
d9b9e07d0b
VMware: Add datatypes in documentation (#59221)
* Remove E337 warnings
* Update docs
* Fix minor typos

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-24 07:55:55 +05:30
Jordan Borean
3581e63ca8
psexec - update example for for delegation example (#59475) 2019-07-24 10:12:34 +10:00
Chaz Ruhl
aebc3b0730 Update cobbler_system.py (#59316)
State was not referenced appropriately in doc examples.
2019-07-23 15:13:07 -05:00
Nathan Swartz
6a77533b57 Specify type-str for common NetApp E-Series documention options. (#59459) 2019-07-23 14:38:11 -05:00
Shachaf92
092e5515d1 win_firewall_rule - update doc for localport dep. on protocol (#59467) 2019-07-23 14:37:08 -05:00
UNR Information Security
7b4ce9e4ae Update find.py (#59456)
Return values for `matched` and `examined` in the find module are integers and not strings.
2019-07-23 13:51:56 -05:00
Andrey Klychkov
333953117c Add human_to_bytes isbits arg unit tests&docstring
PR #58623

Co-Authored-By: Sviatoslav Sydorenko <webknjaz@redhat.com>
Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
2019-07-23 14:56:56 +02:00
Xu Yuandong
133cb945ae update to fix bugs. (#59345) 2019-07-23 06:30:45 -04:00
Martin Nečas
1998c9c19d add example (#59287) 2019-07-23 06:05:17 -04:00
Martin Nečas
8ee587aa7d ovirt add template cluster (#59378)
* ovirt add template cluster

* update doc

* add global search fallback

* update docs
2019-07-23 06:04:42 -04:00
Xu Yuandong
f1dbf6292b update to "state is present but all of the following are missing: password" bug (#59344) 2019-07-23 05:56:01 -04:00
Xu Yuandong
b728347260 ce_bfd_session: update & add 2 params. (#59333)
* update & add 2 paramers.

* update for shippable

* update for shippable
2019-07-23 03:38:27 -04:00
Ganesh Nalawade
1092ee55d4
Add [junos_lag_interfaces] resource module (#59011)
* Add junos_lag_interfaces resource module

*  Add new resource module junos_lag_interfaces.
*  Targets model https://github.com/ansible-network/resource_module_models/pull/29
*  Deprecate junos_linkagg module

* Fix CI issues

* Fix junos integration test cases

* Fail if base lag interface is not configured
2019-07-23 11:53:15 +05:30
Trishna Guha
3bad4d6a50
Add nxos_lag_interfaces resource module (#59031)
* Add nxos_lag_interfaces resource module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* ix CI failure

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* module_utils nxos transport-provider fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* CI failure

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* nxos_lag_interfaces tests

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-07-23 11:11:37 +05:30
The Magician
04445f184b Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59322) 2019-07-22 22:07:48 -07:00
The Magician
c6c262a07e Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59131)
* Bug fixes for GCP modules
* ignore syntax
2019-07-23 10:01:47 +05:30
The Magician
b81239ce50 Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59323)
* Bug fixes for GCP modules
* ignore syntax
2019-07-23 10:00:22 +05:30
The Magician
5d412d89b1 Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59325)
* Bug fixes for GCP modules
* ignore syntax
2019-07-23 09:58:21 +05:30
Martin Nečas
c7f414dece ovirt vm when creating Nonetypefix (#59377)
* ovirt vm when creating Nonetypefix

* update fix and add comment

* add changelog

* Update 59377-ovirt-vm-when-creating-fix.yml
2019-07-22 16:18:08 -07:00
Brian Coca
8a886a6bee
Fix gather facts ignoring gather_subsets config (#59271)
* Fix gather facts ignoring gather_subsets config

 fixes #58728

* Update lib/ansible/playbook/play.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-22 17:59:22 -04:00
Jordan Borean
aa0de421d2
Ignore collection build release files in the root collection directory (#59121) 2019-07-23 07:52:30 +10:00
Brandon Authier
199c97728f Update disk description in vmware_guest.py (#59399)
Corrects grammar in the disk description section of the vmware_guest module documentation.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-07-22 16:14:45 -05:00
Navid Nabavi
b2e58856bf Update hpilo_boot.py (#59136)
Change `hpilo` requirement to `python-hpilo` to avoid being confused in installation with pip.
2019-07-22 16:09:56 -05:00
Alex IP
a2b49854ca Update copy.py (#56370)
* Update copy.py to make the behavior of the `content` option clearer.
2019-07-22 15:57:33 -05:00
Jordan Borean
65049620ee
Generate galaxy.yml based on single source of truth (#59170)
* Generate galaxy.yml based on single source of truth

* Fix up tests and align file names

* Minor Makefile tweak

* Remove link in galaxy.yml file and make it a template file

* Moved collections docs to dev_guide

* change Makefile clean path

* Added readme to example meta file

* review fixes

* Use newer style for doc generation script

* Fix mistake in dev_guide index

* removed uneeded file, fixed links and added preview banner

* Moved banner for sanity test
2019-07-23 06:50:46 +10:00
Jordan Borean
9ff26a4a22
psrp - Added proper reconnection variable name (#59369) 2019-07-23 05:55:52 +10:00
PRASOON KARUNAN V
a20afb5822 Add support for test script parameters in win_pester (#58790)
* add parameter list argument

* add tests

* fix test and add doc

* correct test file

* fix typo

* fix tests

* fix typo in file name

* correct file name reverting the previous commit

* correct property name

* add checkmode message

* changes as per review comments

* variable casing and other review comment changes

* define $test_parameters_check_mode_msg variable
2019-07-23 05:46:26 +10:00
Matt Martz
284dafe476
Perfy McPerferton (#58400)
* InventoryManager start of perf improvements

* 0 not 1

* More startswith to [0] improvements

* Remove unused var

* The hash doesn't need to be a string, start as a list, make it into a tuple

* set actually appears faster than frozenset, and these don't need to be frozen

* Cache hosts lists, to avoid extra get_hosts calls, pass to get_vars too

* negligible perf improvement, it could help with memory later

* Try the fast way, fallback to the safe way

* Revert to previous logic, linting fix

* Extend pre-caching to free

* Address test failures

* Hosts are strings

* Fix unit test

* host is a string

* update test assumption

* drop SharedPluginLoaderObj, pre-create a set, instead of 2 comparisons in the list comprehension

* Dedupe code

* Change to _hosts and _hosts_all in get_vars

* Add backwards compat for strategies that don't do set host caches

* Add deprecation message to SharedPluginLoaderObj

* Remove unused SharedPluginLoaderObj import

* Update docs/comments

* Remove debugging

* Indicate what patterh_hash is

* That won't work

* Re-fix tests

* Update _set_hosts_cache to accept the play directly, use without refresh in get_hosts_remaining and get_failed_hosts for backwards compat

* Rename variable to avoid confusion

* On add_host only manipulate _hosts_cache_all

* Add warning docs around _hosts and _hosts_all args
2019-07-22 14:25:20 -05:00
Chris Archibald
6adf0c581e New feature to na_ontap_snapmirror (#59047)
* updates

* updating version added for connection type
2019-07-22 13:46:00 -04:00
Brian Coca
74ac229fa8 fix all cases of none remote/become users (#59397)
some cases failed, when defaults were None on the plugins
2019-07-22 12:24:31 -05:00
Joseph Andreatta
7ee5835821 VMware: vmware_dvs_host: Add vendor_specific_config (#57637)
* Add vendor_specific_config
* Fix documentation typo
* Add example using vendor_specific_config
2019-07-22 22:06:30 +05:30
Chris Archibald
b1360c0d94 bug fixes (#59049) 2019-07-22 11:05:56 -04:00
Trois-Six
6f9f67be18 virt_net: add way to get facts for only one specified network 2019-07-22 16:34:07 +02:00
Eric Anderson
46b821d51f state wasn't a valid value (#59274)
State isn't a valid value for the gcp_compute_address module, remove it from docs example
2019-07-22 09:25:26 -05:00
n3pjk
6531819172 snow: Fix token reference in basic authentication (#59315)
* Fix OAUTHClient logic
* Add Env variable support for snow modules

Fixes: #59299

Signed-off-by: Paul Knight <paul.knight@state.de.us>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-22 19:31:04 +05:30
Evert Mulder
66d12f6f1e Only convert VirtualDiskFix for #57653 clone_with_convert is failing 2019-07-22 12:52:48 +02:00
Martin Krizek
b7868529ee
Revert "Speed up VariableManager by preserving Templar state. (#45572)" (#59280)
This reverts commit 6069d09b9d.

Fixes #57351
2019-07-22 10:27:11 +02:00
Abhijeet Kasurde
791e565802
VMware: Additional testcase for mem_reservation (#59365)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-22 10:44:19 +05:30
Tyler Ramer
8d0f2e5725 Address regression causing bootproto=dhcp for manual IP addresses (#56376)
Commit b7724fdf85
appears to have caused a regression, where `ip4`, `gw4`, `ip6`, `gw6`
were converted to `ipv4.address`, `ipv4.gateway` etc.

This causes bootproto (or `ipv4.method`) to remain `dhcp`, as noted in https://github.com/ansible/ansible/issues/36615

This commit only reverts the key-value pairs to the original names,
which is in line with both expectation (manual ip addr == no dhcp) and
the language used in the playbook, which is, for example, "ip4" not
"ipv4.address"

Co-authored-by: Stuart Pollock <spollock@pivotal.io>
Co-authored-by: Tyler Ramer <tramer@pivotal.io>
2019-07-22 09:30:24 +05:30
Klaus Frank
252d1b7e95 VMware Tools Connector does not support pipelining (#57237) 2019-07-22 09:27:00 +05:30
Abhijeet Kasurde
1f49abb51c
VMware: Accept 0 as valid value for memory reservation (#59230)
vmware_guest accepts 0MB as valid value for memory reservation in
virtual machine hardware configuration. This fixes the regression
introduced via 193f69064f.

Fixes: #59190

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-22 09:03:25 +05:30
Xu Yuandong
c8697a4864 ce_switchport: add link-type hybrid and dot1qtunnel to mode. and fix bugs. (#59332)
* add link-type hybrid and dot1qtunnel to mode.and fix bugs.

* add verstion_add option for doc.

* update for shippable:E319.

* Update ce_switchport.py
2019-07-21 23:07:09 -04:00
Mark McKinstry
db95ff4823 update documentation for dictionaries (#59354)
it has been fixed if using 0.9.0 or newer

ref https://github.com/ansible/ansible/pull/49053#issuecomment-511073083
2019-07-22 09:43:43 +10:00
Jordan Borean
2f2b106423
Fix win_reg_stat for HKU hives (#59359) 2019-07-22 09:12:14 +10:00
Micah Hunsberger
74598b212e win_hosts to use Ansible.Basic CSharp Util and better diff support (#58600)
* switch win_hosts to use csharp util

* update win_hosts doc to match doc guide

* changed linking format for option values
2019-07-22 09:08:36 +10:00
Jordan Borean
015119df8c
Windows - Add common util for web requests (#54759)
* Windows - Add common util for web requests

* Use different method of retrieving options from module arg spec

* Added proper version_added for module options

* Fix linting errors

* Fix proxy issues and updated cred docs

* Fix FTP usage with proxy settings

* Removed uneeded function added in bad rebase

* Fix up client certificate auth

* fix new sanity checks

* Edit http agent code and update porting guide
2019-07-22 08:42:24 +10:00
Jordan Borean
1f3a3fdd3e
win_firewall_rule - removed deprecated force option (#59358) 2019-07-22 08:24:57 +10:00
maletin
883cc665e3 parameter ensure replaced by state (#59342)
corrected a typo at the absent-example.
2019-07-21 04:26:07 -04:00
Chris Archibald
f8c278e210 add dns info to gather facts (#59145)
* add dns info

* fix doc fragment

* Revert "fix doc fragment"

This reverts commit 8f08ac192e.
2019-07-19 18:30:30 -04:00
The Magician
e7fba5cea0 New Module: gcp_mlengine_version (#59224) 2019-07-19 16:52:40 -04:00
The Magician
5b0214bcce New Module: gcp_appengine_firewall_rule (#58852) 2019-07-19 16:42:37 -04:00
The Magician
40ff1949fb New Module: gcp_mlengine_model (#59222) 2019-07-19 16:41:07 -04:00
Sam Doran
8edad83ae0
User - make groups and append mutually exclusive with local (#59309)
* Update intigration tests
2019-07-19 16:05:15 -04:00
The Magician
5c6aa9b9e8 Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59171)
* Bug fixes for GCP modules

* ignore syntax
2019-07-19 11:33:47 -07:00
The Magician
c5e26ab4da Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59172)
* Bug fixes for GCP modules

* ignore syntax
2019-07-19 11:33:04 -07:00
The Magician
b75e8d19be Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59132)
* Bug fixes for GCP modules

* ignore syntax
2019-07-19 11:32:05 -07:00
Felix Fontein
4a574c4d0c Option parsing: warn if both an option and its alias are specified for a module (#53698)
* Print warning when both an option and its alias is specified.

* Improve output.

* Put warnings into self._warnings directly, resp. use self.warn() when handling subspecs.

* Add changelog.

* Add unit test.
2019-07-19 13:11:41 -04:00
Sam Doran
f231f21669
Handle situation where ansible_architecure may not be defined when gathering facts (#55466) 2019-07-19 11:33:05 -04:00
Nilashish Chakraborty
bb006db7c8
Add exclusive configuration mode support (#59289)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-19 19:03:35 +05:30
Abhijeet Kasurde
4b152235ff
Typo fixes (#59227)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-19 18:18:14 +05:30
Raul Mahiques
fd2116e26a Added state "remount" which will remount the device (#52649) 2019-07-19 08:59:27 +02:00
Martin Krizek
a752e2a467
Clear 'connection related' plugin vars for next loop iteration (#59024)
Fixes #58876
2019-07-19 08:39:05 +02:00
Denis Afonso
da047eec59 cloudformation_facts: Fixes PhysicalResourceId KeyError(#55990)
Fixes: #38033
2019-07-19 10:51:54 +05:30
yanzhangi
e7c9c9585e update ce_vrrp to fix a bug (#59185)
* update ce_vrrp to fix a bug

* update module ce_vrrp 20190718

* update ce_vrrp to fix bugs
2019-07-18 21:33:19 -04:00
Pedro Magalhães
c010a6d288 Fix maven_artifact.py when your maven is behind a cloudflare (#53495)
Cloudflare has a feature that checks Browser Integrity Check, when the user agent is not present, it can fail on BIC.

Since we are defining the default value of variable "self.module.params['http_agent']" to None, this will cause that
User-Agent header will not be added, because of the conditional if present on module_utils/urls.py [1]

[1] https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/urls.py#L1135-L1136

This fix will ensure that the "self.module.params['http_agent']" will be defined

URLs:
https://support.cloudflare.com/hc/en-us/articles/200171806-Error-1010-The-owner-of-this-website-has-banned-your-access-based-on-your-browser-s-signature
https://support.cloudflare.com/hc/en-us/articles/200170086-What-does-the-Browser-Integrity-Check-do-
2019-07-18 18:55:36 -04:00
Simon Dodsley
4acbb83c84 Add checks for VG and Pod existence when creating volume (#58857) 2019-07-18 18:11:06 -04:00
Simon Dodsley
a1220268b2 Add new facts for Pure Storage FlashArray (#58894)
* Update purefa_facts module to support NVMe and preferred arrays

* Update purefa_facts with new information available from array
2019-07-18 17:46:19 -04:00
Simon Dodsley
aeb0245ebd Add check for correct API version before trying to execute (#59205) 2019-07-18 17:17:31 -04:00
The Magician
5f222c478d Bug fixes for GCP modules (#59130) 2019-07-18 16:41:45 -04:00
The Magician
6128d0cd8b New Module: gcp_mlengine_model_facts (#59223) 2019-07-18 16:39:57 -04:00
The Magician
de92ea6b3d New Module: gcp_mlengine_version_facts (#59225) 2019-07-18 16:39:48 -04:00
Aljaž Košir
42073b6331 Add lambda_bucket_event module (#58059) 2019-07-18 10:54:01 -07:00
pratikgadiya12
393e4a41d0 Added support to create and delete multiple databases in MySQL (#58602)
* Added support to create/delete mulitiple databases in MySQL

Fixes: #58370

* Added additional tests cases and fixed documentation changes

* Code refactoring and added tests for better test coverage

- Removed db_exists usage from most of the code. Used existence_list
 and non_existence_list instead

- Added additional tests to cover all scenarios w.r.t creation and deletion
 on multiple databases

- Added tests for dump operations

* Minor fix

* Minor fix - create check mode test

* Added dump tests for better dump tests coverage

* Removed minor database connection details

* fixed error

* Added test case for import operations

* Code refactoring and review fixes

- Added dump all test case

* Fixed review comments

* Minor review comment fixes

* Altered db_create return value

* Removed db_list and altered "does exist" to just "exist"

* Kept db and db_list in module.exit_json

* Refactored tests

- Added removal of dump2 file

* Moved import tests to state_dump_import file

* Removed import tests from multi_db_create_delete

* Updated porting guide, added RETURN block

* Minor identation fix

* Added validation to check if databases are dumped
2019-07-18 16:56:32 +02:00
Felix Fontein
cdf0947df0
Fix typo in import package name. (#59229) 2019-07-18 16:54:33 +02:00
Hannes Ljungberg
0e8eb1d17f pip: Remove unused option use_mirrors and remove all ignore.txt entries
PR #58977

* Remove unused option use_mirrors

* Add changelog fragment
2019-07-18 16:38:37 +02:00
Sam Doran
d2edf1d435 User - Create parent directories if they do not exist in the specified home path (#51043)
* Create a user home directory if it has parents that do not exist

The useradd command line tool does not create parent directories. Check if the specified home path has parents that do not exist. If so, create them prior to running useradd, then set the proper permission on the created directory.

Add tests

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Use dict for default user group in tests

Signed-off-by: Sam Doran <sdoran@redhat.com>

* Fix tests

Signed-off-by: Sam Doran <sdoran@redhat.com>
2019-07-18 10:19:11 -04:00
Chris Archibald
2fbc226509 Update to base Netapp.py for Azure, and Rest API (#59151)
* base changes

* updateS

* fixes

* fies

* updates

* fix issues

* updates
2019-07-18 08:37:00 -04:00
Sumit Jaiswal
b2d8ef69f9
PR to support Ansible Checkmode in Checkpoint modules (#57695)
* added checkmode support

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-07-18 16:26:55 +05:30
Eitan Raviv
264945d75f ovirt-host-network: support commit on success (#59212)
In ovirt-engine 4.3 and onwards a 'commit on success' parameter is
available. It is used to commit a network configuration automatically
upon successful application of the configuration without needing a
separate save request.

Therefore since ansible 2.8 if the 'save' parameter is specified as
'true' the commit on success parameter will be set to true and used
instead of making an additional save request.
2019-07-18 06:39:32 -04:00
Martin Nečas
9489433a4d use sysprep only when needed (#59196) 2019-07-18 03:59:51 -04:00
n3pjk
7e25a61464 snow: Call Refactored login from snow modules (#59201)
* Remove python shebang from snow_record*
* Add python shebang to all snow modules
* Remove NO_LOG from username
* Call Refactored login from snow modules
2019-07-18 10:53:23 +05:30
Sebastiaan Mannem
d0538c0d7a postgresql_pg_hba: Exception when two lines with same weight are compared (#59198) 2019-07-18 10:50:19 +05:30
Abhijeet Kasurde
8a13b41823
VMware: Use managed object id to find VM (#59143)
* Based upon partial work of wilmardo
* Now, user can specify managed object id of virtual machine to find
an existing virtual machine

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-18 07:38:12 +05:30
James Cassell
28259ee247 dzdo: fix password prompt (#59208) 2019-07-18 10:42:00 +10:00
Michael Letterle
b8a41a90b8 Wrap Get-MachineSid's body in a try/catch
It's not critical information and there's been a number of issues over
the years with trying to retrieve it. If an exception is thrown just
return null.

Fixes: #47813
2019-07-17 19:11:56 -04:00
Yunge Zhu
42c43a2822 add azure_rm_keyvaultkey_info module (#55754) 2019-07-18 06:55:51 +08:00
Brian Coca
c2253c8133
Allow for no role_versions to be present (#56519)
* Allow for no role_versions to be present

  fixes #46650

  better info on fetch, ensure list return

* use correct to_
2019-07-17 12:35:24 -04:00
Brian Coca
4ef2545eb5
if users are None/empty, dont assume sameness (#58875) 2019-07-17 11:17:48 -04:00
Brian Coca
48d4d6ec69
Stop ignoring merge hash behaviour in inventory (#58460)
* stop ignoring merge hash behaviour in inventory

fixes #58120

* added porting note

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
2019-07-17 11:16:56 -04:00
Brian Coca
a39b721db5
fixes to config manager (#58530)
* skip unreadable ansible.cfg

* all types should check for type

* patch access for tests and fix tests that relied on missing files not being checked
2019-07-17 10:39:30 -04:00
dx0xm
b8eba8e1f0 VMware: Add testcase for vmware_dvs_portgroup_facts (#59088)
* Tests for choosing specific DVS while gathering facts

Signed-off-by: dx0xm <52723266+dx0xm@users.noreply.github.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-17 18:31:52 +05:30
Phillipe Smith
ce907c8b90 New module os_group_info (#57120)
* Added domain_id param to get_group

* Added module os_group_facts based on os_project_facts

* Fix pep8 alarms and version_added to 2.9

* Update lib/ansible/modules/cloud/openstack/os_group_facts.py

Co-Authored-By: Raimund Hook <1150270+StingRayZA@users.noreply.github.com>

* Update lib/ansible/modules/cloud/openstack/os_group_facts.py

Co-Authored-By: Raimund Hook <1150270+StingRayZA@users.noreply.github.com>

* Update lib/ansible/modules/cloud/openstack/os_group_facts.py

Co-Authored-By: Raimund Hook <1150270+StingRayZA@users.noreply.github.com>

* Update lib/ansible/modules/cloud/openstack/os_group_facts.py

Co-Authored-By: Raimund Hook <1150270+StingRayZA@users.noreply.github.com>

* Fixes based on https://github.com/ansible/ansible/pull/57120#issuecomment-511338588

* Update lib/ansible/modules/cloud/openstack/os_group_info.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/cloud/openstack/os_group_info.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/cloud/openstack/os_group_info.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Removed availability_zone option

* Revert "Removed availability_zone option"

This reverts commit 20155c0b0f.

* Reverted to the original code to open a new Pull Request
2019-07-17 13:55:53 +02:00
Jordan Borean
edfdf30bcb Improve docs for win_service for custom account rights (#59155) 2019-07-17 08:03:47 +01:00
dx0xm
09aa98bf43 VMware: Gather facts about vlan id from DVS Portgroup in vmware_dvs_portgroup_facts (#59085) 2019-07-17 11:39:44 +05:30
Hannes Ljungberg
6f94995b52 npm: Validate all option types (#58965)
* Add type validation for name, version and registry
* Add changelog fragment
* Remove ignore of E337 and E338
2019-07-17 09:34:58 +05:30
Eugene Narciso
fbb4eaaba9 Update net_static_route document (#59168)
Update net_static_route examples section document, the missing colon can potentially cause confusion.
2019-07-17 09:08:34 +05:30
Sumit Jaiswal
0bde145b1f PR to fix minor issues with Checkpoint module (#58049)
* minor checkpoint module fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* state default value set

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-07-16 18:51:32 -04:00
Fred-sun
6430205d39 Update azure_rm_virtualmachine related document (#58861)
* Update azure_rm_virtualmachine_facts module's documentation with nitzmahone feedback, CI fixes

* 'remove_on_absent' does not define choices
2019-07-16 15:58:14 -05:00
Matt Clay
493785ccef Remove extra blank line from galaxy .travis.yml.
This fixes the last yamllint error on the file.

The file is currently ignored by CI, but that will be changing soon.
2019-07-16 13:50:19 -07:00
Matt Davis
d28f25d118
patch ansible-connection collection plugin loading (#59119) 2019-07-16 13:46:15 -07:00
Matt Clay
d4dec59cb0 Fix collection loader builtin handling. (#58897)
- Support more import statements:

  from ansible_collections.ansible.builtin.plugins.module_utils import basic
  from ansible_collections.ansible.builtin.plugins.module_utils.basic import AnsibleModule

- Add unit tests for more import statements.
- Raise ImportError instead of returning None if load_module fails.
2019-07-16 13:40:22 -07:00
Shachaf92
681ab6515a win_domain_group_membership - Fix to a fix in extra_args (#58943)
* win_domain_group_membership - Fix to a fix in extra_args

* addig missing l on the fly
2019-07-17 05:38:42 +10:00
Alicia Cozine
e5e3486be6 clarifies how ASK works for Tower credentials (#59050)
* clarifies how ASK works for credentials
2019-07-16 15:37:47 -04:00
Toshio Kuratomi
019d078a5a
Move common build code from _build_helpers (#55986)
We have some common code used by several docs scripts.  Migrate that
into the build-only shared code repository.

* Move lib/ansible/utils/_build_helpers.py to the directory for common
  build code
* Migrate docs/bin/dump_config.py to a build-ansible subcommand
* Migrate dump_keywords to the build-ansible framework
  * Make the script more maintainable by using functions and good
    variable names
  * Port to Python3 idioms
  * Fix bug so that private attributes will be undocumented
* Move generate_man to a build-ansible subcommand
* Port plugin_formatter to a build-ansible subcommand
* Rework command_plugins so that docs scripts can target Python-3.4+ and
  releng-only subcommands can use more recent versions of Python.
  The architecture is now that command_plugins/* need to be importable
  on Python-3.4.  The init_parsers() method needs to run on Python-3.4.
  But the main() method can utilize features of more recent Python as
  long as it fits within those parameters.
* Update docs build requirements

Port the plugin_formatter to build-ansible framework
2019-07-16 12:19:01 -07:00
Fred-sun
65e0f37fc0 Update azure_rm_virtualnetwork related document (#59023)
* Update azure_rm_virtualnetwork related documentation
2019-07-16 14:18:20 -05:00
Kyle Sferrazza
b376c91749 win_hotfix: fix docs typo (#59124) 2019-07-16 14:09:13 -05:00
Fred-sun
c7387549a4 Update azure_rm_virtualnetworkpeering related document (#59025)
* Update azure_rm_virtualnetworkpeering related documentation
2019-07-16 14:04:32 -05:00
Chris Archibald
8bf069114f New Module: Vscan Enable (#57953)
* new module

* fix netapp.py

* updates

* fixes
2019-07-16 13:40:56 -04:00
Wojciech Sciesinski
e8a7d89180 Correct a documentation of the jenkins_plugin module (#59139) 2019-07-16 11:46:18 -04:00
Dara Poon
b16c264dca chroot connection plugin: defer get_option() call (#59065)
* The chroot connection plugin crashes because its constructor calls
  self.get_option(...) before the plugin loader has established its
  self._load_name.  Therefore, we should defer the self.get_option(...)
  call so that it happens in connect().

Fixes #59063
2019-07-16 11:31:06 -04:00
Kiyo Nagamine
88c4cf28ea Modified blockinfile module's exmple using loop keyword (#59022) 2019-07-16 11:13:04 -04:00
Ewoud Kohl van Wijngaarden
9c5b3401ff Close file after using it (#59000) 2019-07-16 10:07:27 -05:00
Jonathan
f0eaf1fb39 Module mail : Add Date header (#59080)
* Mail module : add date header (#58808)
2019-07-16 10:55:59 -04:00
Abhijeet Kasurde
de66abe521
VMware: Add support for storagePod (#58627)
* User now can be specify datastore cluster for deploying OVF
* Added find_resource_pool_by_cluster API

Fixes: #57849

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-16 13:14:21 +05:30
Gonéri Le Bouder
a63e17cd63 vmware_vmkernel: simplify the code (#55176)
- drop a dead branch in a condition tree
- simplify the look-up of the vnic
2019-07-16 09:28:22 +05:30
A Codeweavers Infrastructure Bod
e2adb37789 crypttab: 'NoneType' object is not callable when password is NoneType (#56790)
This looks to have been broken in commit 8bd5757720 where a fields.append was replaced with a call to self.password
2019-07-16 07:58:19 +05:30
Fred-sun
9e6399f74c Update azure_rm_virtualmachinescalesetextension related document (#58908)
* Update azure_rm_virtualmachinescalesetextension documentation
2019-07-15 16:02:42 -05:00
d-little
ee71a7df74 timezone - Add AIX support using chtz (#58838)
* init AIX support

* fix pylint whitespace issues

* Switch chtz from required=False to True

* Refactor AIX to include _get_timezone()

* More Pylint...
2019-07-15 15:52:50 -04:00
Milan Zink
7cbd06f3a3 Adding vserver/SVM NFS info to na_ontap_gather_facts (#58826) 2019-07-15 14:35:09 -04:00
Xu Yuandong
7a0a21ea7a ce_file_copy : update ce_file_copy to fix a bug. (#59071)
* update ce_file_copy to fix a bug.

* Update ce_file_copy.py

* Update ce_file_copy.py
2019-07-15 14:18:46 -04:00
Elijah DeLee
a6d32eda84 Remove extra print statement (#59104)
Let ansible-inventory handle all output
Fixes #59101
2019-07-15 13:26:19 -04:00
Martin Krizek
4898b0a4a2 group: detect duplicate GIDs when local=yes (#58469) 2019-07-15 12:52:15 -04:00
Alvaro Olmedo Rodriguez
a1dcba63b3 java_keystore - Prefer SHA256 and solve SHA256 keytool in java11 version (#57302) 2019-07-15 12:44:30 -04:00
Andrey Klychkov
2a07123fdd jboss module: add check mode support and integration tests (#58959)
* git war file and wildfly archive from S3
* create setup_wildfly_server role for integration tests
2019-07-15 12:17:08 -04:00
Stéphane Travassac
262c9ffdb6 VMware: fix for vmware_guest_file_operation binary file (#57614) 2019-07-15 19:05:54 +05:30
Jordan Borean
66a5ed64ca Remove reference to Windows for assemble docs (#59082) 2019-07-15 08:25:30 -05:00
Kevin Dwyer
ec35cbc437 Pass allow_unauthenticated when installing a deb directly - allowing unauthenticated dependencies (#58771)
* Pass allow_unauthenticated when installing a deb directly - allowing unauthenticated dependencies.

* Add changelog for ansible/ansible#58771
2019-07-15 12:02:14 +02:00
shiro
644eead954 Fix docs for yum_repository.py (#59068)
* The description has been replaced with proxy_password and proxy_username.
* Rename 59068-fix doc for yum_repository.py to 59068-fix_doc_for_yum_repository.yml
2019-07-15 15:19:40 +05:30
Noe Gonzalez
3a5d13b0d7 VMware: Fix vmware_guest cloning bug (#58737)
* fix vmware_guest cloning bug
* added tests for resizing disks during clone
2019-07-15 10:09:54 +05:30
Rémi REY
b6273e91cf Fix deprecation warning message from grafana_annotations
The Display class has no `info` attribute/method. The use of the method
was raising an Exception in task_queue_manager and displayed an
unappropriate deprecation warning.
2019-07-14 18:27:39 +02:00
Xu Yuandong
07a598089a update ce_interface to fix a bug. (#59070) 2019-07-14 11:28:40 -04:00
Felix Fontein
8d6f1846a6
docker_* modules: improve tag validation and requests error handling (#58791)
* Add method to validate docker tags.

* Validate tag option of docker_image.

* Fix regex. Always return boolean, not None vs. Matcher object.

* Also catch requests errors.

* Linting.

* Add changelog.
2019-07-13 22:36:18 +02:00
Felix Fontein
fa7c387f9b docker_container: add support for nocopy mode (#59043)
* Add support for nocopy mode.

* Add changelog.
2019-07-13 14:50:32 -04:00
Hannes Ljungberg
34a68fa0fb pip: Document option types and validate name elements
PR #58966

Also:
* Validate that name elements are strings
2019-07-13 17:05:37 +02:00
n3pjk
a135c483ce Add OAuth and Multi-Record Query for SNOW (#58410)
* Add SNOW OAuth Support and Multi-record Query

* Add OAuth documentation to snow_record_find

* Fix lint and verification issue for PR 58410

* Fix E309 and E324 errors in PR 58410

* Fix E307, need advice on E309

* Fix E309 for PR 58410

* Re-add instance, username and password documentation

* Fix data type mismatch in documentation

* Remove doc_fragment overlap

* Refactor service now module space

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-13 20:34:36 +05:30
jpic
945e35ada2 Fix exception in unixy callback v2_runner_retry (#58801) 2019-07-13 09:08:51 +05:30
The Magician
d1587bca41 Bug fixes for GCP modules (#58902) 2019-07-12 18:50:49 -04:00
Chris Archibald
f3aac3a112 MOTD was not idempotent (#57372)
* fix issue

* fix issues

* fix issues

* fix issues
2019-07-12 16:47:41 -04:00
Simon Dodsley
13d45cd0f9 Fix typo in purefa_user and purefa_dsroledocumentation examples (#59005)
fa_url not fb_url
2019-07-12 15:35:36 -05:00
Andrey Babushkin
3b0c933f18 [win_credential.py] Fix example in docs (#59042)
Example should use "secret" instead of "password".
2019-07-12 15:30:09 -05:00
The Magician
51e1b090db Bug fixes for GCP modules (#58901) 2019-07-12 16:21:43 -04:00
The Magician
119b8521a6 Bug fixes for GCP modules (#58904) 2019-07-12 16:21:31 -04:00
Fred-sun
8c55a9c70b Update azure_rm_virtualmachinescalesetinstance related document (#58909)
* Update azure_rm_virtualmachinescalesetinstance related documentation
2019-07-12 15:11:45 -05:00
Alicia Cozine
fec314febb clarifies nmcli option 'conn_name' (#59034) 2019-07-12 16:07:55 -04:00
Fred-sun
343acd76d4 Update azure_rm_virtualmachineextesion related document (#58907)
* Update azure_rm_virtualmachineextension related documentation
2019-07-12 15:04:50 -05:00
Sam Doran
dd30d86f1e
Use comprehensions rather than map() (#58997)
Since we now require Python > 2.6 on the controller, we can drop the use of map() here
2019-07-12 15:49:39 -04:00
The Magician
6fb7a2b7cc Bug fixes for GCP modules (#58903) 2019-07-12 15:11:22 -04:00
The Magician
5cd0e2f19f Bug fixes for GCP modules (#58900) 2019-07-12 15:08:08 -04:00
Pavan Bidkar
7b8edbf9dd VMWare: New Module for content library CRUD operations (#58716) 2019-07-12 09:34:05 -07:00
Martin Krizek
aea5b795c0 Make ansible_index_var accessible as a magic var (#59030) 2019-07-12 08:50:19 -04:00
Pavan Bidkar
6bd6bf98e5 VMware: New Module for VMWare content Library info (#58703)
* Changes as per review comments and renamed file to vmware_content_library_info
* Removing password field from publish info dictionary
* Removed current password field from publish info
* Modified vmware_content_library_info module with review comments.
* Review comments. Moved test .yml files under tasks folder
* Moved test files under module name folder. Handled library_get call under try catch to throw proper error message
* Fixed precheck failure bare except. Catching Exception
2019-07-12 15:50:30 +05:30
Abhijeet Kasurde
617972499f
VMware: Correct network_exists_by_name API call (#59006)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-12 11:22:06 +05:30
Ganesh Nalawade
f09bd91ad0
Add junos_interfaces resource module (#58871)
* Add junos_interfaces resource module [junos_interfaces]

*  Add new resource module junos_interfaces.
*  Targets model https://github.com/ansible-network/resource_module_models/pull/8
*  Depcreate junos_interface module

* Fix CI failures

* Fix integration test failures

* Fix CI failures

* Fix review comments
2019-07-12 09:05:48 +05:30
Mark Dierolf
9fc710f657 Fixed a bug where the Route 53 Health Check would add a new health check instead of updating an existing one when the user has > 100 health checks (#58539) 2019-07-11 14:57:09 -07:00
Chris Archibald
9cb78b4826 New options to volume (#58531)
* updates to volume

* fix ansibot

* fix issues

* Revert "fix issues"

This reverts commit 54988709ae.
2019-07-11 17:42:00 -04:00
Derrick Johnson
b91a90a274 Fix examples to use the module (#58988)
This was probably a copy/paste mistake. The examples are using a different module.
2019-07-11 15:24:17 -05:00
Kiyo Nagamine
e8b8a0ab26 Enhancement: replaced with_items keyword for loop keyword. (#58865) 2019-07-11 15:41:43 -04:00
Jordan Borean
bcc23e70e6
win_dns_client - fix bug in devel and added tests (#58971)
* win_dns_client - fix bug in devel and added tests

* Fix sanity issue
2019-07-12 05:36:12 +10:00
layderv
6aad3a6842 iptables gid_owner (#58795) 2019-07-11 15:29:40 -04:00
Fred-sun
dfd48ab3c3 Update azure_rm_virtualmachineimage_facts document (#58660)
* Update azure_rm_virtualmachineimage_facts documentation
2019-07-11 14:10:37 -05:00
Anatoly Pugachev
75724bb7ca Fix reported AIX filesystem module incorrect fail_json() usage (#58642)
* Fix reported AIX filesystem module incorrect fail_json() usage and
extend reporting on an error.

Fixes #58609

* pep8 and ansible-test fixes, as well one missed msg param
2019-07-11 14:23:18 -04:00
Brian Coca
adea964c3e
Fix gather_facts error/skipped reporting (#58927)
now give back full output from each module executed
 fixes #57204
2019-07-11 14:18:32 -04:00
Chris Archibald
59feb63d19 Add uid, and gid to volume clone (#57371)
* and new features

* fix issues

* fix issues

* fix issues

* add unit tests
2019-07-11 13:57:36 -04:00
Brian Coca
a7b14ec1be
Fix strat inv (#58982)
* Fix strategy functions that update inventory

* added tests
2019-07-11 13:49:49 -04:00
Martin Krizek
b0f38931b0
yum: check whether the lock file disappeared (#58581) 2019-07-11 18:14:42 +02:00
Hannes Ljungberg
4ab364eaaf Cleanup EXAMPLES (#58972) 2019-07-11 12:12:21 -04:00
Kedar Kulkarni
17c88724ab Updating known_hosts module Docs (#58785) 2019-07-11 11:41:57 -04:00
Chris Archibald
6e3d54ae81 Set vscan_fileop_profile for na_ontap_cifs (#57373)
* new features

* update unit tests
2019-07-11 10:49:35 -04:00
pratikgadiya12
e8f4ebb22c nmcli: Argument vlanid (int) is changed internally to string (#58963)
* Argument vlanid (int) is changed internally to string
* Modified test case to check vlan id

Fixes: #58949
2019-07-11 18:02:02 +05:30
Valeriy Zabawski
cc4dc075f7 Adds minor improvements to 'zabbix_actions' module (#58379)
Changes:

    1. Update mandatory arguments in accordance with Zabbix API.
       Only esc_period, eventsource and name fields are mandatory.

       Reference: https://www.zabbix.com/documentation/3.0/manual/api/reference/action/object

    2. Add default values to argument options in order to prevent "TypeError: 'NoneType' object is not iterable" error.

    3. Add new condition operators (introduced in Zabbix 4.0 and 4.2)

    References:
      - https://www.zabbix.com/documentation/4.2/manual/api/reference/action/object#action_filter_condition
      - https://www.zabbix.com/documentation/4.0/manual/api/reference/action/object#action_filter_condition

    4. Update module documentation
2019-07-11 06:14:00 -04:00
Toshio Kuratomi
33d2728879 Rename python files in hacking/ directory to have .py suffix
ansible-test only passes files which have the .py suffix for sanity
tests on python files.  This change will allow sanity tests to run on
the Python files in hacking/

* Rename test-module to test-module.py
* Symlink test-module for backwards compat since end users may be using
  test-module
* Fix test-module sanity errors that are now triggered
* Rename ansible_profile to ansible-profile.py
* Rename build-ansible
2019-07-10 22:17:35 -07:00
Chris Archibald
ee24e6c5be Qtree was not idempotent (#58596)
* fixes

* fixes
2019-07-10 20:18:17 -04:00
Jill R
fd9b52f305 Add version_added to ec2 inv iam_role_arn option (#58945) 2019-07-10 16:11:19 -05:00
flowerysong
c513c1e2d3 aws_s3: Improve ETag handling (#46332)
* cosmetic: Remove useless call to ec2_argument_spec()

* aws_s3: Improve ETag handling

* Extract ETag calculation into a utility function for reuse by
  aws_s3_sync.
* Reduce code duplication in put/get by restructuring the logic
* Only calculate ETag when overwrite == different
* Fail gracefully when overwrite == different and MD5 isn't available
  (e.g. due to FIPS-140-2).

* aws_s3: clean up integration tests

Clean up tests, add tests for overwrite settings in both directions.
2019-07-10 14:05:12 -07:00
bcavns01
0e7e3c0ae8 Add msg parameter to the mandatory filter (#56724)
* Add msg parameter to the mandatory filter

The `mandatory` filter would be more useful, particularly when dealing with nested dictionaries, with the simple addition of a `msg` parameter for supplying it with a custom failure message.
2019-07-10 15:53:48 -04:00