Commit graph

9442 commits

Author SHA1 Message Date
Jakub Holy
f5ce5e4a78 mention that include works with addtional task files
Mention we can include roles/x/tasks/anothertasks.yml with `include anothertasks.yml` within the role's `main.yml` as this is not obvious from the documentation
2014-02-12 14:06:59 +01:00
Maykel Moya
811aa2611e Add support for string values
The SET GLOBAL statement requires properly quoting of values. For example, the
following correct queries will fail if quotes are toggled:

mysql> SET GLOBAL innodb_lru_scan_depth = 2000;
mysql> SET GLOBAL master_info_repository = "TABLE";

`mysql_variable` module doesn't quote the value argument, therefore
string values will fail.

  # this task will pass, 2000 is passed without quotes
  - name: set a numeric value
    mysql_variable: variable=innodb_lru_scan_depth value=2000

  # this task will fail, TABLE is passed without quotes
  - name: set a string value
    mysql_variable: variable=master_info_repository value=TABLE

With this patch prepared statements are used. Proper quoting will be
done automatically based on the type of the variables thus an attempt
to convert to int, then to float is done in first place.

Booleans values, ie: ON, OFF, are not specially handled because they
can be quoted. For example, the following queries are correct and
equivalent, they all set _innodb_file_per_table_ to logical _True_:

mysql> SET GLOBAL innodb_file_per_table = "ON";
mysql> SET GLOBAL innodb_file_per_table = ON;
mysql> SET GLOBAL innodb_file_per_table = 1;

Tested in mysql 5.5 and 5.6.
2014-02-12 12:44:28 +01:00
Richard C Isaacson
cb7c2b7524 Updates for the unarchive module and action_plugin.
There is a bit going on with the changes here. Most of the changes are cleanup of files so that they line up with the standard files.

PR #5136 was merged into the current devel and brought up to working order. A few bug fixes had to be done to get the code to test correctly. Thanks out to @pib!

Issue #5431 was not able to be confirmed as it behaved as expected with a sudo user.

Tests were added via a playbook with archive files to verify functionality.

All tests fire clean including custom playbooks across multiple linux and solaris systems.
2014-02-12 01:57:00 -06:00
Richard C Isaacson
e6c9705058 Merge remote-tracking branch 'pib/unarchive_remote' into pull_5136 2014-02-11 22:55:34 -06:00
Michael DeHaan
874667179f Merge pull request #5967 from willthames/env_setup_library
Allow hacking/env-setup module path to use config file library path
2014-02-11 21:17:13 -05:00
willthames
e2d04f7e96 Allow hacking/env-setup module path to use config file library path
hacking/env-setup now adds the configured library path in ANSIBLE_CONFIG
to the ANSIBLE_LIBRARY environment variable in addition to the previous
default of ANSIBLE_HOME/library.

This replaces #5950.
2014-02-12 12:06:57 +10:00
Michael DeHaan
f07091ed69 Merge pull request #5962 from sivel/rax-facts-docs-update
rax_facts and rax_keypair modules: update docs
2014-02-11 16:39:59 -05:00
Matt Martz
e8952a5a99 The OpenStack auth attributes apply to rax_keypair also 2014-02-11 14:25:13 -06:00
James Cammarata
a023cbce14 When using jsonify in modules, try several unicode encoding for dumps()
Fixes #4821
2014-02-11 14:19:40 -06:00
James Cammarata
ce0b1a8a96 Fixing tests for git 2014-02-11 12:41:49 -05:00
jctanner
fe94c0cd05 Merge pull request #5957 from sivel/rax-no-default-disk-config
rax module: Don't set a default for disk_config
2014-02-11 11:55:06 -05:00
Maykel Moya
06beddfe68 Fix documentation url 2014-02-11 16:55:10 +01:00
Maykel Moya
0b44a3e54f Minor grammar fix in manpages 2014-02-11 16:50:10 +01:00
James Tanner
b5c242773d Update bug reporting instructions to refer to the issue template 2014-02-11 10:26:25 -05:00
Michael DeHaan
acae162d4d Merge pull request #5945 from swills/patch-1
Add some notes on installing on FreeBSD
2014-02-11 08:04:45 -05:00
James Tanner
89c89c8ed2 Re-add synchronize unit tests 2014-02-10 23:56:32 -05:00
James Tanner
9ce46e5f41 Refactor the synchronize action plugin and add unit tests 2014-02-10 23:39:17 -05:00
Christopher H. Laco
471b1a7a47 Add rax_identity module
For some tasks, I need to drop the username/api_key into configuration
files. Rather than rely on how I'm calling the rax modules. It seemed
more appropriate to authenticate against Rackspace and return the wealth
of information contained in the pyrax identity payload with other
modules/templates.
2014-02-10 22:40:38 -05:00
Michael DeHaan
f858679f97 Merge pull request #5948 from bob-smith/spelling_and_typos
Fix various typos in markdown documentation
2014-02-10 20:51:13 -05:00
John Barker
1f4b91575b Fix various typos in markdown documentation 2014-02-10 23:00:19 +00:00
Matt Martz
8095aa6584 Don't set a default disk_config. Defaulting to 'auto', causes issues with new images 2014-02-10 16:12:32 -06:00
jctanner
4688be33d4 Merge pull request #5946 from bob-smith/patch-1
Fix typos in ISSUE_TEMPLATE.md
2014-02-10 17:00:25 -05:00
James Cammarata
3f90020d62 Open LOG_LOCK file with FD_CLOEXEC to prevent file descriptor leakage
Fixes #5399
2014-02-10 15:51:52 -06:00
John Barker
b8967a231e Fix typos in ISSUE_TEMPLATE.md 2014-02-10 21:41:31 +00:00
Steve Wills
0d4bd3e851 Add some notes on installing on FreeBSD
Could perhaps be expanded with more prose, but this will do for a start.
2014-02-10 16:13:10 -05:00
Sean Chittenden
5e0cf6663a Fix broken behavior when removing all auxiliary groups from a user
(e.g. 'groups=' in the user module).
2014-02-10 13:08:53 -08:00
James Cammarata
bbda98a3ee Merge branch 'issue_4812' into devel 2014-02-10 13:35:53 -06:00
James Cammarata
bb79b16d59 Specify mode in the makedirs call for fireball/accelerate keys 2014-02-10 13:27:43 -06:00
James Cammarata
65cb79a5c1 Merge branch 'devel' of https://github.com/xyrix/ansible into xyrix-devel 2014-02-10 13:18:59 -06:00
Matt Martz
bd3c7c3efa The name parameter for search_opts is a regex string, so make sure we include start and end of string characters 2014-02-10 13:18:03 -06:00
zimbatm
4aaf8f9a4c library/digital_ocean: Adds the missing backups_enabled create option 2014-02-10 17:35:10 +00:00
Mohan Krishnan
fb3c8c90e5 Allow explict setting of vpc_security_groups to allow modification of security groups of RDS instances within a VPC 2014-02-10 14:01:45 +07:00
Michael DeHaan
36250c6b86 Merge pull request #5931 from suzaku/fix_typo
Fix typo in CODING_GUIDELINES.md
2014-02-09 23:24:08 -05:00
Brian Coca
f475de2316 hopefully last batch of fixes
- removed previous 'typification' of input as it needs it is typed by
  module as strings and needs to be output as strings, making it
  useless.
- now checks for vtype and value against None when question is specified
- simplified set_selections as vtype and value should have a string
  value going in.
- added example of querying questions for a package
- added module requirement of question,vtype and value being required
  together.
2014-02-09 20:47:01 -05:00
satoru
02c7c9cb18 Fix typo 2014-02-10 09:12:38 +08:00
Brian Coca
a1de284dba made changes as per feedback:
- field names are more consistent with debconf
- values are now 'booleanized' or accepted as list/set objects when
  pertinent
- updated docs to reflect all of the above and debconf cli tools
  required
2014-02-09 17:46:18 -05:00
Michael DeHaan
d3c1b8de78 Merge pull request #5883 from amirhhz/improve-ec2-module-docs
Improve ec2 module docs
2014-02-09 14:07:35 -05:00
Michael DeHaan
317f8f39f6 Merge pull request #5920 from geerlingguy/patch-1
Change reference to open 'intranet' to 'internet'
2014-02-09 13:25:38 -05:00
Michael DeHaan
29b2768298 Merge pull request #5924 from Barthalion/devel
Include all man pages in Arch Linux package.
2014-02-09 13:25:10 -05:00
Michael DeHaan
114ad44f0f Merge pull request #5926 from riceo/devel
Fix Linode inventory plugin causing a Chube exception when attempting to obtain information on a specific Linode host
2014-02-09 13:24:03 -05:00
Aaron Rice
a326d24446 Save api id to index as an int instead of a list 2014-02-09 16:33:34 +00:00
Bartłomiej Piotrowski
2b06de5664 Include all man pages in Arch Linux package.
While we're on it, change $pkgdesc to follow its counterpart from
official repositories. Additionally don't install RELEASES.txt and
CONTRIBUTING.md; there is little use for them from the user's perspective.
2014-02-09 13:53:40 +01:00
Jeff Geerling
a19c394a02 Change reference to open 'intranet' to 'internet'
The Internet is being referred to, but the documentation uses the word 'intranet'.
2014-02-09 00:33:28 -06:00
Scott Anderson
baf508a379 Change standard AWS access and secret key parameter names to aws_access_key and aws_secret_key. Fixes an authentication problem with the rds module and standardizes the naming convention on something more encompassing than ec2_*_key. 2014-02-08 18:35:26 -05:00
Matt Saunders
674969a7d8 Added user_data parameter to nova_compute module - currently no file parsing just text - Re issue #4992 2014-02-08 22:47:03 +00:00
Michael DeHaan
3f2f5fec0a Merge pull request #5911 from fly/fix_linode_typo
add missing ' in Linode documentation
2014-02-08 16:14:27 -05:00
Richard Isaacson
ab0adaf613 Merge pull request #5912 from risaacson/issue5739_5
Refining the fix made in #5885.

Merging this quickly after PR as further testing of of earlier fix demonstrated flaws. Those flaws are now removed and tested to be removed.
2014-02-08 02:33:44 -06:00
Richard C Isaacson
786e3d2fd2 Refining the fix made in #5885.
It turns out that some of the assumptions in #5885 were slightly off. The previous fix relied on a call to the module to creat a tmp_path. This is insufficent as there are few cases that we need to have the tmp directory before we make the module call. If we don't have a tmp_path before we do a recursive call or when we find a file that does not match the remote md5 hash we need to create a tmp directory. Also we are not more percise when we will need to clean up the remote tmp_path.
2014-02-08 02:25:42 -06:00
Jon Chen
970997c764 fix linode typo 2014-02-07 20:47:57 -05:00
Michael DeHaan
1609dfbca4 Revert "Revert "Revert "Add the fork manager code (related to previous patch)."""
This reverts commit 60d3611b70.
2014-02-07 20:38:24 -05:00