Commit graph

23372 commits

Author SHA1 Message Date
Tim Rupp
f3a61dd93d
Adds aliases parameter to gtm wide ip (#44652)
This parameter can assign aliases to a wide ip.
2018-08-24 14:38:41 -04:00
Tim Rupp
73c97cb779
Adds parameters and removes netaddr dependency (#44654)
several new parameters added to bigip_node and the netaddr dependency
has been removed.
2018-08-24 14:38:23 -04:00
Tim Rupp
b5d45bdd1a
Refactors bigip_iapp_service and adds params (#44653)
Module was refactored to look like other f5 modules. also added new
params.

* decription
* device_group
* metadata
2018-08-24 14:38:13 -04:00
Tim Rupp
2930b28247
Adds new params to gtm server module (#44650)
Parameters to support iquery options were added.
2018-08-24 14:09:20 -04:00
Tim Rupp
7e6fbb3f8b
Adds params and remove netaddr (#44648)
This patch adds new parameters to the vcmp guest module and removes
the netaddr python dependency
2018-08-24 13:58:49 -04:00
Tim Rupp
e4af3e7b4d
Misc fixes (#44649)
Correcting docs and adding a Parameters handler for description
2018-08-24 13:58:25 -04:00
Tim Rupp
639cfe3b6f
Refactors device group (#44599)
Make module use patterns that other modules use
2018-08-24 13:58:12 -04:00
Aren
9db3e597f3 state: present added in docs (#37197)
* state: present added in docs

* atomic_container.py docs now match argspec, enforce test
2018-08-24 12:22:18 -05:00
Sloane Hertel
d3f5238c09
Fix dangerous elb_application_lb state (#44646)
* elb_application_lb: fix dangerous default of deleting an ELB if state is omitted by changing state to default to present to be more like other AWS modules
2018-08-24 13:04:15 -04:00
Shuang Wang
b03feb6d40 Implement part of #27617 [expend checksum format to <algorithm>:(<checksum>|<url>)] (#43751)
* expend checksum format to <algorithm>:(<checksum>|<url>)

* continue to code at office

* ALPHA - expend checksum format to <algorithm>:(<checksum>|<url>)

* clean up tmpfile and comment

* try to add test code for 27617

* try to add test code for 27617

* try to add test code for 27617

* try to fix [Could not find or access 'testserver.py']

* fix test code [Could not find or access 'testserver.py']

* fix test code [add files dir]

* fix test code [files dir not exists]

* as [connection was closed before a valid response was received]

* [connection was closed before a valid response was received]

* [connection was closed before a valid response was received]

* add test item [sha1 and sha256]

* since [connection was closed before a valid response was received]

* fix [connection was closed before a valid response was received]

* fix test code typo

* add docs for #27617

* PR #43751 is minor change

* fix pep8 issue.

* fix test code style.

* fix unexpected quote
2018-08-24 12:45:32 -04:00
Chris Archibald
3820c3351b Adding ElementSW Backup Module (#43960)
* Adding ElementSW Backup Module
2018-08-24 17:23:03 +01:00
Chris Archibald
319bd2de5f Adding ElementSW Cluster Pair Module (#43967)
* Adding ElementSW Cluster Pair
2018-08-24 17:21:52 +01:00
Chris Archibald
448db900dd Adding ElementSW SnapShot Schedule Module (#43974)
* Adding ElementSW SnapShot Schedule Module
2018-08-24 17:18:02 +01:00
Chris Archibald
d7efcc4161 Adding ElementSW Vlan Module (#43981)
* Adding ElementSW Vlan Module
2018-08-24 17:16:51 +01:00
Chris Archibald
790e19804b Adding ElementSW Volume Module (#43982)
* Adding ElementSW Volume Module
2018-08-24 17:16:07 +01:00
Yanis Guenane
03e3a0b202 scaleway: Introduce scaleway_organization_facts module
Co-authored-by: Rémy Leone <rleone@online.net>
2018-08-24 18:15:45 +02:00
Yanis Guenane
809aa2d767 scaleway: Introduce scaleway_snapshot_facts module
Co-authored-by: Rémy Leone <rleone@online.net>
2018-08-24 18:15:45 +02:00
Yanis Guenane
2cfcfd6dc9 scaleway: Introduce scaleway_server_facts module
Co-authored-by: Rémy Leone <rleone@online.net>
2018-08-24 18:15:45 +02:00
Yanis Guenane
5c65ba62aa scaleway: Introduce scaleway_ip_facts module
Co-authored-by: Rémy Leone <rleone@online.net>
2018-08-24 18:15:45 +02:00
Yanis Guenane
d62f63b680 scaleway: Introduce scaleway_image_facts module
Co-authored-by: Rémy Leone <rleone@online.net>
2018-08-24 18:15:45 +02:00
Yanis Guenane
e4e6569cc9 scaleway: Introduce scaleway_volume_facts module
Co-authored-by: Rémy Leone <rleone@online.net>
2018-08-24 18:15:45 +02:00
Yanis Guenane
4bdec575c0 scaleway: Introduce scaleway_security_group_facts module
Co-authored-by: Rémy Leone <rleone@online.net>
2018-08-24 18:15:45 +02:00
Rémy Léone
8f9d55529d scaleway: Refactor modules 2018-08-24 18:15:45 +02:00
Yanis Guenane
29cfebe332 scaleway: Create a base class for all the modules
Purpose of this commit is to create a base class for the upcoming
scaleway module to use.

Co-authored-by: Rémy Leone <rleone@online.net>
2018-08-24 18:15:45 +02:00
Chris Archibald
caeae632ba Adding ElementSW Volume Pair (#43984)
* Adding ElementSW Volume Pair
2018-08-24 16:30:15 +01:00
Chris Archibald
54c526991a Adding ontap_cg_snapshot.py Module (#44181)
* Adding ontap_cg_snapshot.py Module

* Fix issues
2018-08-24 16:29:21 +01:00
Chris Archibald
ea5a455656 Adding ontap_dns.py Module (#44193)
* Adding ontap_dns.py Module

* Change Short Description
2018-08-24 16:23:34 +01:00
Chris Archibald
3c69ad7104 Adding ontap_fcp.py Module (#44197)
* Adding ontap_fcp.py Module
2018-08-24 16:21:33 +01:00
Chris Archibald
b85458d8ba Adding ontap_snapmirror.py Module (#44215)
* Adding ontap_snapmirror.py Module
2018-08-24 16:02:35 +01:00
Chris Archibald
d6e74adbf5 Adding ontap_software_update.py Module (#44218)
* Adding ontap_software_update.py Module
2018-08-24 16:01:37 +01:00
Chris Archibald
0534b7ad38 Adding ontap_svm_options.py Module (#44220)
* Adding ontap_svn_options.py Module
2018-08-24 15:58:45 +01:00
Michael Price
ad91793428 Resolve issues in NetApp E-Series Host module (#39748)
* Resolve issues in NetApp E-Series Host module

The E-Series host module had some bugs relating to the update/creation
of host definitions when iSCSI initiators when included in the
configuration. This patch resolves this and other minor issues with
correctly detecting updates.

There were also several minor issues found that were causing issues with
truly idepotent updates/changes to the host definition.

This patch also provides some unit tests and integration tests to help
catch future issues in these areas.

fixes #28272

* Improve NetApp E-Series Host module testing

The NetApp E-Series Host module integration test lacked feature test
verification to verify the changes made to the storage array.

The NetApp E-Series rest api was used to verify host create, update, and
remove changes made to the NetApp E-Series storage arrays.
2018-08-24 15:44:59 +01:00
Pierre Gaxatte
3122860f22 Update os_server docs when removing an instance (#41963)
When removing an instance via its ID, it is not clearly explained that one should use the `name` parameter.

Also a simple example is provided.

+label: docsite_pr
2018-08-24 10:42:25 -04:00
njferrant
507d6e241e NetApp: return lun info for na_ontap_lun_map module (#42961)
* return lun details for na_ontap_lun_map

return lun details for na_ontap_lun_map.py and added return value documentation
2018-08-24 15:37:28 +01:00
Victor da Costa
53405f673c friendly message when requirement is not installed (#42321)
* friendly message when requirement is not installed
2018-08-24 15:08:24 +01:00
Dag Wieers
86147d598f Various improvements to script module docs (#44637)
This PR includes:
- Use uppercase in descriptions
- Add trailing dot to descriptions
- Grammar/spelling fixes
- Adding names to examples as a best practice
- Simplify structure
2018-08-24 09:56:44 -04:00
Chris Coley
ce5530e08d Fix incorrect default value for shutdown_command (#44607) 2018-08-24 09:51:14 -04:00
Yanis Guenane
9869f378fd inventory/vultr: Few minor improvements (#44622) 2018-08-24 15:35:29 +02:00
Yuma Inaura (稲浦悠馬)
34c582287a Fix script module document (#42778)
script module seems does not create / remove files
it seems only checks file existence or not existence


+label: docsite_pr
2018-08-24 14:59:04 +02:00
linnil1
1651483e44 [Junos] Add l3-interface option for vlan (#43863)
* [Junos] Add l3-interface option for vlan

* Add version_added for new option
2018-08-24 18:06:27 +05:30
Ganesh Nalawade
b454fbe684
Update netconf_config module doc and return diff (#44634)
* Update netconf_config module doc
* Return santizied before and after config
  in diff key
2018-08-24 17:57:12 +05:30
Ganesh Nalawade
d20b4ee56a
Fix netconf_config source option issue (#44630) 2018-08-24 17:01:48 +05:30
Alex Mayer
e4e45a419a Firewalld: Switch "true" To "yes" In Examples (#44588)
Matches documentation section values
Make module examples more consistent with core modules
2018-08-24 10:17:56 +02:00
Abhijeet Kasurde
f59d189d02 Minor typo fix in package module documentation (#44617)
Added missing round bracket

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-24 10:14:58 +02:00
Samer Deeb
a07af2a1f7 issue:43021 add support for onyx version 3.6.6000 and above (#44527)
* issue:43021 add support for onyx version 3.6.6000

Signed-off-by: Samer Deeb <samerd@mellanox.com>

* issue:43021 add support for onyx version 3.6.6000

Signed-off-by: Samer Deeb <samerd@mellanox.com>
2018-08-24 07:59:10 +01:00
Ondra Machacek
56b9823bb8 ovirt_vm: Fix undefined variable (#44618)
Fix unassigned variable while suspending vm.
2018-08-24 02:29:02 -04:00
Abhijeet Kasurde
33f5b1aa0f
VMware: new module: vmware_local_role_facts (#44553)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-24 10:00:40 +05:30
Toshio Kuratomi
f46c943d3d Fix another corner case of too many warnings for world readable current working directory
There should be no warning if there is no ansible.cfg file i nthe
current working directory.
2018-08-23 20:23:59 -07:00
Sam Doran
4d9218cec4 Add reboot action plugin (#35205)
* Update docs

* Add reboot action plugin

Refactor win_reboot so it is subclassed from reboot

* Use new connection methods

* Test fixes

* Use better uptime command for Linux

Use who -b to get the last time the system was booted rather than uptime, which changes every second.

* Use distribution specefic commands and flags

Query the managed node to determien its distribution, then set the appropriate command and flags.

* Tune debug messages a bit

* Update module docs with details about pre_reboot_delay

s docs

* Ensure that post_reboot_delay is a positive number

* Remove the stringification

* Add integration tests

* Make sure aliases are honored

* Handle systems that have an incorrect last boot time

SystemD and fakehw-clock do not properly set the
last boot time and instead always set it to epoch.
Use a different command if that is the case.

* Copyright and encoding fixes

* Minor fixes based on feedback

* Add exponential backoff to sucess check method

* Update integration test

Skip the integration test if it would try to reboot the control node. We need a new mechanism to account for this scenario in ansible-test, so tests must currently be run manually for this plugin.

* Update integration test

Skip the integration test if it would try to reboot the control node. We need a new mechanism to account for this scenario in ansible-test, so tests must currently be run manually for this plugin.

* Fail early with running with local connection

* Update docs based on feedback

* minor refactoring, state mgmt changes
2018-08-23 18:12:12 -07:00
Will Thames
60e3af42d5 sns_topic boto3 port (#39292)
* Port sns_topic to boto3 and add tests
2018-08-23 21:04:18 -04:00
Stephen SORRIAUX
a78cc15099 Add new parameters to manage mtime and atime for file module, fixes #30226 (#43230)
* Add new parameters related to mtime and atime for file module, fixes #30226
2018-08-23 17:20:54 -07:00
Balthazar Rouberol
1b3f074ec6 Change DataDog to Datadog (#34273) 2018-08-23 20:20:29 -04:00
Brian Coca
9cc56981b5
Add new host_pinned strategy (#44586)
The 'free' strategy still attempts to do all hosts per task before going to the next, it just doesn't wait for slow hosts,
This strategy processes each host as fast as possible to the end of the play before trying to process another host in the pool.
2018-08-23 20:16:32 -04:00
Matt Clay
3fb5056606 Fix PEP8 issue. 2018-08-23 16:43:59 -07:00
Sloane Hertel
79ecb4c41f
Add diff mode for ec2_group (#44533)
* Add (preview) diff mode support ec2_group

* Add diff mode to some ec2_group integration tests

* Remove unnecessary arguments and add comment to the module notes

* Add changelog
2018-08-23 19:43:18 -04:00
Sloane Hertel
b152515fcb RDS inventory plugin (#41919)
Comments out uses of rds_instance in the integration tests and replace with AWS CLI until rds_instance has been merged
2018-08-23 19:42:32 -04:00
Dag Wieers
3d70274864
Added an async 'started' test (like 'finished') (#43445) 2018-08-24 01:29:34 +02:00
Dag Wieers
cc2164f92a
ACI: Add specific info about running locally (#43903)
Since the ACI modules (like most network-related modules) run on the
local controller, this PR adds the necessary details so users are aware
of this particular feature.
2018-08-24 01:28:39 +02:00
Matt Martz
242e9229a1
Pin deprecation of tags in params for include to deprecation of include (#44596) 2018-08-23 16:25:33 -05:00
Felix Fontein
0e6234ab04 Adding module which allows to complete certificate chains (#44169)
* Adding certificate_complete_chain module.

* Avoid code smell errors.

* Removing input_chain_src.

* Make sure line ending is there.
2018-08-23 23:18:36 +02:00
Yanis Guenane
72d4880b85 Vultr: Introduce the Vultr inventory plugin (#44400)
This commit introduce the Vultr inventory plugin.
2018-08-23 23:14:26 +02:00
Tim Rupp
14909e76ec
Adds features to device connectivity (#44598)
Adds new parameter and removes f5-sdk
2018-08-23 17:08:28 -04:00
Tim Rupp
9c12d845ab
Removes f5-sdk code from bigip modules (#44595)
This patch is part of an ongoing effort to fully remove the f5sdk
from the f5 modules.
2018-08-23 16:53:34 -04:00
GElkayam
4bea004a4e Fix assign_public_ip: no disregarded (#29691) (#43954)
in case assign_public_ip is False, it is not handled.
2018-08-23 16:43:44 -04:00
Tim Rupp
05920b92d6
Misc fixes to bigip modules. (#44594)
Adding docs, formatting docs, adding validation checks and values
2018-08-23 15:57:08 -04:00
Matt Martz
2787bda0fa
Deprecated version should be an explicit version number (#44593) 2018-08-23 14:45:39 -05:00
Tim Rupp
1fd6821db0
Add parameter and remove netaddr (#44584)
This patch adds a description parameter to most fields. It also removes
netaddr from the modules.
2018-08-23 15:28:08 -04:00
Jose Rodriguez
14e3febb2c Prevent utf-8 codec error in py3 (#44228)
Cannot upload templates in Python 3.x. Gives utf-8 codec error.
Fixes this by opening the template file in binary mode.
2018-08-23 14:33:00 -04:00
Matt Martz
aa07da21a3
Bump sudo/su deprecation to 2.9 (#44581) 2018-08-23 13:22:54 -05:00
Alex Mayer
4002be6960 Firewalld: Add bool Type To permanent In Docs (#44579) 2018-08-23 14:06:06 -04:00
Zim Kalinowski
1704c5932a adding app gateway module (#39940)
* adding app gateway module

* improved application gateway

* added register output

* subnet_output

* debugging

* dumping params

* fix dump

* fixed mapping

* fixed bug

* fixed param problem

* small fixes in code and added sample test

* fixed syntax

* fixing sanity stuff

* sanity fixes

* more sanity tests fixed

* added azure_tags

* tags

* pruning app gateway

* pruning app gateway

* string -> str

* removed type: str

* trying to add idempotency

* fixed syntax

* fix sanity

* fixed bugs

* fixed error

* disabled ssl policy check for  a while

* fixed dict comparison

* fixed syntax

* compare just http listeners & frontend ports

* fix syntax

* syntax

* syntax

* just compare sku

* fix syntax

* just http settings collections

* fixing appgw module

* make it green

* fix items issue

* compare all arrays

* fixed sanity

* adding snake_to_camel transformations

* fix

* another fix

* snake to camel

* additional snake to camel fixes

* fixed public ip address conversion

* version added is now 2.7

* changed alias

* dict_merge

* added ssl policy spec

* fixed new sanity issue

* renamed module

* fixed ssl policy translation

* added test for ssl & certificates

* updated doc

* fixed docs improved tests

* fix

* fixed test
2018-08-23 10:24:21 -07:00
Tim Rupp
5a020e7170
Minor fixes and enhancements to bigip modules (#44549)
Various cleanup and fixes in docs and iterations.
2018-08-23 12:50:30 -04:00
rabru
59e25bbe5b Update bigiq_application_https_offload.py (#44562)
<!--- Your description here -->

+label: docsite_pr
2018-08-23 12:47:21 -04:00
Sam Doran
05fff27415
Pass path to GalaxyRole object (#43051)
This will list all roles in all paths in roles_path rather than just the first path in roles_path.
2018-08-23 12:44:48 -04:00
Matt Martz
88509e75ad
Remove bare_deprecated functionality (#44517)
* Remove bare_deprecated functionality

* Change tests due to bare_deprecated removal
2018-08-23 11:31:16 -05:00
Sam Doran
df335d91b0
Properly un expire account on creation (#44174)
When creating a new account, check to see if the expiration parameter is negative and pass in the appropriate parameter. Since the negative integer passed into expires is converted to time.struct_time which in turn gets converted to a formatted time string when passed to the underlying command, a -1 or large negative number would result in passing a date before 1970-01-01 to the underlying command.

This had the opposite effect of creating an account with no expiration account resulting in a newly created account that was already expired, or just throwing an error on certain systems.
2018-08-23 12:29:33 -04:00
Uwila
b1d6802d71 Fix ignoring of 'Login Profile cannot be found' errors in iam (#43198) 2018-08-23 12:14:51 -04:00
jctanner
653d9c0f87 New keyword: ignore_unreachable (#43857) 2018-08-23 11:41:02 -04:00
Pilou
2603604fd6 gather facts improvements (#44008)
* gather_subset is a list of strings

When gather_subset is an integer, a message pointing out the problem, current tb error 
is replaced by this one:

    ERROR! the field 'gather_subset' should be a list of (<class 'str'>,), but the item '42' is a <class 'int'>
...
* gathering_facts test: ensure smart gathering is on
2018-08-23 11:36:06 -04:00
Guillaume Delpierre
23e44319ce crypto: Add new module openssl_pkcs12 (#27320)
[module] Create new module to handle PKCS#12 file.
2018-08-23 08:15:22 -07:00
Trishna Guha
9c4ed4dfc1 use retry_json nxos_banner (#44376)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-08-23 15:55:50 +02:00
Ganesh Nalawade
64045cb024 Add support for multiple answers in cli_command module (#44560)
* Add support for multiple answers in cli_command module

*  Add multiple answers support for multiple prompts

Depends on PR #44492

* Doc update
2018-08-23 09:49:18 -04:00
Lindsay Hill
6c05e03fea Replace invalid_params with ValueError (#44545) 2018-08-23 15:49:08 +02:00
skylerbunny
d4e15d40e8 Update tags documentation to explain newer tags behavior (#44274) 2018-08-23 09:46:54 -04:00
Ganesh Nalawade
e25d8e2b99 Add support for multiple prompt answers in network_cli (#44492)
* Currently network_cli support multiple prompts
  single answer as response. This PR adds support
  for multiple answers.
* In case of multiple prompts and mulitple answers the
  index of a particular prompt in the prompts list should
  match with the index in the answer list.
2018-08-23 09:46:42 -04:00
Ondra Machacek
24c26aded8 oVirt: Add depracation warning to all modules (#44440) 2018-08-23 09:42:05 -04:00
Lingxian Kong
4d2e0c58a8 Add os_member module for openstack loadbalancing service (#43908) 2018-08-23 08:45:16 -04:00
Vincent Rischmann
81a5aba0a2 docker_container: allow arbitrary log_driver (#33579)
Docker supports logging plugin (see https://docs.docker.com/engine/admin/logging/plugins)
so it no longer makes sense to limit the log_driver option to a set of
fixed choices.
2018-08-23 07:05:42 -04:00
Zim Kalinowski
9788951789
Adding os_disk_size_gb parameter to Virtual Machine (#43316)
* added os disk size gb

* fixed mistake

* added os_disk_size_gb to test

* fixed test

* no default for disk size
2018-08-23 15:36:58 +08:00
guoqiao
6ef9c2d7b7 Fix mail module for python 3.7.0 (#44550) (#44552)
In python 3.7.0, changes in `ssl.py` breaks `smtplib.SMTP_SSL`, which
then breaks `mail` module in ansible.

Run this line in python shell:

    import smtplib;smtplib.SMTP_SSL().connect(host='smtp.gmail.com', port=465)

Before python 3.7.0, we will get:

    (220, b'smtp.gmail.com ESMTP j13-v6sm3086685pgq.56 - gsmtp')

In python 3.7.0, we get such error at `lib/python3.7/ssl.py` line 843, method `_create`:

    ValueError: server_hostname cannot be an empty string or start with a leading dot.

The ssl module is using host info on SMTP_SSL instance, which is not set.
The fix/workaround is simple, just pass host info to it:

    import smtplib;smtplib.SMTP_SSL(host='smtp.gmail.com').connect(host='smtp.gmail.com', port=465)

Fixes: #44550

Signed-off-by: Guo Qiao <guoqiao@gmail.com>
2018-08-23 16:50:54 +10:00
Andreas Olsson
4e895c10ba Have nsupdate add expected quotation to TXT records (#43386)
This prevents the accidental creation of TXT records where every
single word gets split into its own string, such as TXT record values
in the format of `"foo" "bar" "baz"`. That being an implicit behavior
I have very hard to see anyone purposely relying on.

TXT record values can still explicitly be defined as one or more
strings, without any change in syntax.

Resolves #43380
2018-08-23 02:40:50 -04:00
Jordan Borean
e07352b9de basic.py: catch ValueError when trying to import hash algorithms (#44551)
* basic.py: catch more Exceptions when trying to import md5 hash algorithms
2018-08-22 23:34:50 -07:00
Felix Fontein
c8ee383783 Clarify usage of env_file (#42211). (#44535) 2018-08-23 02:16:48 -04:00
Sumit Jaiswal
b1f915b28b
Added Support for excluding IPs in nios_next_ip and created new pluggin for nios_next_network (#44437)
* adding next network pluggin

* include exclude option for next_ip search

* changing example provider input

* adding new line at end

* version added info

* to fix shippable errors

* to fix shippable errors

* adding exclude option in doc section

* fix review comment

* fix review comment
2018-08-23 03:08:39 +00:00
Sumit Jaiswal
1d2bb34992
Includes support for Reverse-Mapping zone in nios_zone module (#44525)
* support reverse mapping

* support reverse mapping

* support reverse mapping

* fix shippable errors

* fix shippable errors

* fix shippable errors
2018-08-23 03:07:30 +00:00
/v\atthew L Daniel
d7e66f16a6 Correct the default doc for attached in ec2_eni (#44523)
* Correct the default doc for attached in ec2_eni

Also corrected a typo in the summary

* Address ansible-test sanity error about E324

* Fix and remove the E325 suppression for ec2_eni
2018-08-23 12:44:49 +10:00
Steve Dodd
c89dfad846 Update shell.py (#44477)
* Update shell.py

<!--- Your description here -->
Add example for disabling warnings to shell module
+label: docsite_pr

* Fix PEP8 issues
2018-08-23 12:31:55 +10:00
Ryan Brown
4c8808ec9d
Extend module_defaults by adding default groups for cloud modules (#44127)
Extends `module_defaults` by adding a prefix to defaults `group/` which denotes a builtin list of modules. Initial groups are: `group/aws`, `group/azure`, and `group/gcp`
2018-08-22 21:33:27 -04:00
Tim Rupp
fdcb883ac0
Adds new params to bigip trunk (#44547)
* description and q-in-q
2018-08-22 21:21:46 -04:00
Tim Rupp
27059a859e
Add time_wait_recyle param to bigip_profile_tcp (#44543)
Allows for configuring the time-wait-recycle setting on a tcp profile
2018-08-22 20:55:35 -04:00
Yuwei Zhou
fff5fb2077 Add route table and route module (#41175)
* add route module

* add test

* add table

* add  route table

* fix dict

* fix

* fix

* route  table accept no name

* add default

* fix

* fix

* fix

* fix pep

* support route table

* fix line ending

* fix pep

* fix

* fix

* set the default to 'None'

* make return value only id

* camel and snake

* set test alias

* change facts line ending

* change test

* fix

* add default

* fix

* fix line break

* remove unsafe args

* fix comment

* fix
2018-08-22 15:24:57 -07:00
Tim Rupp
6da6652e6b
Fixes and features for bigip gtm monitor modules (#44540)
Merging in gtm monitor work from downstream repo. includes various
new fixes and features.
2018-08-22 18:19:55 -04:00
Zim Kalinowski
a73340ee74 adding postgresql server facts (#43328)
* adding postgresql server facts

* updating postgresql server facts, minor changes

* changed return dict to list

* fixed test

* fixed several issues

* several updates

* fixed naming

* list -> complex

* try again

* fixed mistake

* added user_visible_state to the result

* added fully_qualified_domain_name

* fixed second test

* updates

* fixed test

* updated samples in return value

* wait for postgresql server to be actually ready

* another approach for test

* second server was not created

* fixing pr comments

* fix sanity

* removed forgotten  ansible_facts
2018-08-22 15:18:01 -07:00
Matt Martz
a1febd95b7
Remove deprecated ec2_facts (#44536)
* Remove deprecated ec2_facts

* Add changelog
2018-08-22 16:48:22 -05:00
Matt Martz
5ea7480e90
Remove deprecated s3 module (#44537)
* Remove deprecated s3 module

* Add changelog
2018-08-22 16:48:09 -05:00
sdubrul
061877d584 added account_alias in the response of module aws_caller_facts (#42345)
* added account_alias in the response of module aws_caller_facts

* added comment to explain list_account_aliases

* renamed caller_identity to caller_facts as the content is extended

* created changelog

* security-policy needs the iam:ListAccountAliases for this module to work

* test now checks for the added field account_alias

* gracefully handle missing iam:ListAccountAliases permission
2018-08-22 17:21:12 -04:00
Felix Fontein
960d99a785 ACME: new helper module for ACME challenges which need TLS certs (#43756)
* Added helper module for generating ACME challenge certificates.

* Soft-fail on missing cryptography. Also check version.

* Adding integration test.

* Move acme_challenge_cert_helper from web_infrastructure to crypto/acme.

* Adjusting to draft-05.

* The cryptography branch has already been merged.
2018-08-22 23:12:43 +02:00
Matt Martz
6ac4dae834 Bump a few deprecations to correct versions (#44534) 2018-08-22 17:11:41 -04:00
Vladimir Dobriakov
6f480fd03d Fixes #23078 - eliminate trailing whitespace in to_nice_json (#42633)
* Fix #23078 - eliminate trailing whitespace in to_nice_json

* Add changelog fragment for #42633
2018-08-22 14:55:30 -05:00
♫ Christian Krause ♫
d779eb1f15 doc: fixes the the repetitions (#43937)
Wow, this does not seem to be an uncommon misspelling. Might be there
are some left that span over two lines. I noticed the one in the git
module and then used `grep -rw 'the the'` to find some more.
2018-08-22 21:53:30 +02:00
Tim Rupp
9a17ee6d84
Removes netaddr dependency (#44519)
One more dep removed from bigip_selfip
2018-08-22 15:16:55 -04:00
Chris Archibald
65c9280935 Adding ontap_vserver_peer.py Module (#44226)
* Adding ontap_vserver_peer.py Module
2018-08-22 12:04:26 -07:00
Wes Mosher
b6fef17848 fix ec2_vpc_peer example with incorrect parameter (#43905)
+label: docsite_pr
2018-08-22 14:57:42 -04:00
Pedro Magalhães
12812d21c5 Add 'instance_protocol' parameter when fetching ELB Listeners (#40785)
This PR changes the ec2_elb_facts module to output the value of ELB InstanceProtocol
2018-08-22 13:57:02 -04:00
Ben Irving
0e536f746b Fix spelling error of secondary_availability_zone in rds module (#43852) 2018-08-22 13:55:22 -04:00
Rob St. Marie
a8f2b8f5ab CloudFormation: Allow failed changesets to gather stack_outputs (#43509) 2018-08-22 13:54:31 -04:00
Mark Goddard
8522e6420e Support project parameter for os_security_group module (#34472)
Many OpenStack modules provide the ability to register a resource in a
project other than the one being used to authenticate with, by adding a
project parameter to the module. Examples include os_network, os_subnet,
and os_router. This change adds a project parameter to the
os_security_group module.

Fixes: #34467
Fixes: #30292
2018-08-22 13:52:25 -04:00
Will Thames
c4303804bf Ensure that target group ports are cast to int on creation (#44442)
A previous fix fixed this for existing target groups but not
for new target groups

Fixes #37368
2018-08-22 13:51:59 -04:00
bhuztez
dd8edf5ae2 docker_container: fix working_dir (#42857)
WorkingDir should be read from Config instead of HostConfig, check
https://docs.docker.com/engine/api/v1.37/#operation/ContainerInspect
2018-08-22 13:42:56 -04:00
Till Maas
0fabf2109f service_facts: Use LC_ALL/LANG=C to run commands (#44474)
This allows to parse the output when the user's locale changes the
commands' output. For example chkconfig uses 'Ein' and 'Aus' instead of
'on' and 'off' when using LANG=de_DE.UTF-8 breaking the service
detection on RHEL 6.
2018-08-22 13:27:03 -04:00
Christoph
2b9d4b9253 More consistent Docker unit parsing (#16748)
* Docker: Convert units for kernel_memory

Other memory arguments already use human_to_bytes to convert the
units.  This change makes the behavior more consistent.

* Update Docker unit parsing documentation

This explains the units more precisely and makes the documentation
more consistent.

This fixes #16526.
2018-08-22 13:05:23 -04:00
Alex Stephen
261b90edc0 New GCP Module: gcp_compute_ssl_policy (#42797) 2018-08-22 13:00:15 -04:00
photoninger
d68c734ae2 Fix for "cannot marshal None unless.." (#33660)
when using only an activation key without any channels.
As already suggested by mattclay in
https://github.com/ansible/ansible/pull/25079

and also patch unit test for rhn_register and
add test case for activationkey only
2018-08-22 12:25:58 -04:00
Chris Archibald
5b19d67873 Bug Fixes for ontap_export_policy_rule.py (#44196)
* Bug Fixes for ontap_export_policy_rule.py
2018-08-22 09:03:56 -07:00
Chris Archibald
86a48af541 Bug Fixes for ontap_net_routes.py (#44208) 2018-08-22 09:01:28 -07:00
Chris Archibald
66ae8efbd3 Bug Fixes for ontap_net_vlan.py (#44209)
* Bug Fixes for ontap_net_vlan.py

* Make documentation changes
2018-08-22 09:00:49 -07:00
Chris Archibald
00143d806c Bug Fixes for ontap_snapshot.py (#44216) 2018-08-22 08:59:26 -07:00
Chris Archibald
6d2c45e447 Bug Fixes issue with netapp.py (#44283)
* Fix issue
2018-08-22 08:31:57 -07:00
Matt Martz
81ca04512d
Raise a nicer error when we cannot execute the editor (#44423)
* Raise a nicer error when we cannot execute the editor. Fixes #44419

* Don't use to_bytes when constructing an exception

* Add changelog fragment
2018-08-22 10:24:11 -05:00
Alex Stephen
613a53c114 New GCP Module: gcp_compute_target_vpn_gateway (#42798) 2018-08-22 10:50:55 -04:00
Alex Mayer
c968704ef6 Stat: doc: Change ignore MD5 example to generic checksum (#44480) 2018-08-22 16:48:07 +02:00
Lingxian Kong
3dbc3a5dda Add os_pool module for openstack load-balancing service (#43907) 2018-08-22 10:38:53 -04:00
Alex Stephen
53677738ff New GCP Module: gcp_compute_firewall_facts (#44027) 2018-08-22 10:31:21 -04:00
Alex Stephen
8c9f6215e0 New GCP Module: gcp_compute_global_address_facts (#44029) 2018-08-22 10:31:04 -04:00
Ganesh Nalawade
522dd923c8
Fix network config line diff ignore (#43924)
* If config is added in form of lines add
  capability to ignore confgiure lines given as input
  in task
2018-08-22 19:40:09 +05:30
Pablo
5f953d1129 Fix handlers on strategy free (#33011)
Add _flushed_hosts dict to store when handlers are flushed and prevent them
to be executed too early using _filter_notified_hosts.

Add _wait_on_handler_results to wait only for handlers to be completed.

Remove only hosts that have been flushed from handler notified list.

Fix #31504, #23970
2018-08-22 10:07:31 -04:00
Daniel-Sanchez-Fabregas
ec2aa12581 Fix win_domain_computer (#44054)
Fixes #43653

- Change descrtiption parameter default to null.
  When reading an empty description from AD, powershell returns a null.
- Convert after and before diff keys to ordered hashes.
  Unordered state descriptions make --diff report equal values as
  changes.
2018-08-22 06:46:06 -04:00
Max
fe85d85ba6 Update one_vm.py (#43349)
OpenNebula 5.5.8  expects int in DISK_SIZE field when you create a vm, not a float.
For example, "42 GB" should be sent to OpenNebula API as "43088", not as "43088.0". MEMORY you cast to int explicitly, but DISK_SIZE not.
2018-08-22 01:56:47 -04:00
Tim Rupp
49f34fec13
Correct unit tests and module fixes (#44488)
Cleanup of unit tests. Modules fixes in iapp_template nad profile_dns
to support unit tests.
2018-08-21 22:02:11 -04:00
Brian Coca
bda074d34e
fix tempating issues with no_log and loops (#44468)
* fix tempating issues with no_log and loops

 - task is no log if any item is
 - added test cases

fixes #43294
2018-08-21 21:53:56 -04:00
Jordan Borean
6982dfc756 psrp: Added new Windows connection plugin (#41729)
* psrp: Added new Windows connection plugin

* Tweaks to connection options from review
2018-08-21 16:43:13 -07:00
Tim Rupp
07a011cd6f
Various bigiq fixes (#44487)
Fixes usage of the RestClient class. Documentation fixes. Removal
of dependency code.
2018-08-21 18:40:19 -04:00
Tim Rupp
d39a711aa1
Adds the bigip firewall DoS profile module (#44486)
This module can be used to manage AFM DoS profiles on a BIG-IP
2018-08-21 18:29:34 -04:00
Tim Rupp
d05da83495
Removes dependencies and cleans up code (#44484)
Portions of the f5-sdk were removed as well as the netaddr library
and were replaced with libraries that are part of ansible. Additionally,
deprecated code has been removed.
2018-08-21 18:01:52 -04:00
Toshio Kuratomi
0e7b470a01 Remove deprecated tags config option (#44479)
* Remove deprecated tags config option

* wordsmith porting guide entry

acozine via github
2018-08-21 14:57:06 -05:00
Yunfan Zhang
18f361ecdd Added Ansible Tower inventory plugin. (#41816)
Signed-off-by: Yunfan Zhang <yz322@duke.edu>
2018-08-21 14:41:26 -04:00
Tim Rupp
b5e99949e2
Adds the bigip_profile_http module (#44473)
This module can be used to manage HTTP profiles on a BIG-IP.
2018-08-21 14:22:09 -04:00
Florian Apolloner
6cf341b40e Fixed hash_host option in known_hosts module. Fixes #44284 2018-08-21 10:28:45 -07:00
Lindsay Hill
f10abe7bf5 add missing slxos_config action plugin (#44103)
* add missing slxos_config action plugin
2018-08-21 10:03:36 -07:00
Lindsay Hill
bec0a1ceb3 nos_facts module and tests (#44094) 2018-08-21 10:03:04 -07:00
Lindsay Hill
b0a25d321d new nos_config module (#44140)
* new nos_config module

* Update cliconf/nos.py to add missing 'end'
2018-08-21 10:02:40 -07:00
Andreas Olsson
9c4e3789d5 Deal with case insensitivy in cloudflare_dns module (#44366)
Cloudflare's DNS API deals with the case insensitivy of DNS names and
IPv6 addresses by forcing them into lower case. To properly be able to
detect changes the Ansible module needs to behave accordingly.

To what extent the API expects sent DNS names to be lower case varies
between record types. Yet, since sending lower case always works, and
since we always get lower case back, it feels cleanest to use lower
case for all DNS names.
2018-08-21 12:32:22 -04:00
Joakim Israelsson
88659dcba4 Documentation fix, decrypt is True by default (#44435) 2018-08-21 09:21:25 -07:00
skylerbunny
4062939681 Return variable in get_url is 'status_code', not 'status' (#43366)
Subject is self explanatory.
Resolves #43365.

+label: docsite_pr
2018-08-21 18:16:42 +02:00
Petr Ruzicka
a49d1b7b91 Replacing old "with_items:" by "loop:" (#44303)
Replacing old "with_items:" by "loop:"

+label: docsite_pr
2018-08-21 12:03:46 -04:00
Matt Martz
2bf6507c44
Use newer is_sequence function instead of MutableSequence (#44331)
* Use newer is_sequence function instead of MutableSequence. Fixes #44327

* Add changelog for #44331

* Update changelog fragment to describe the fix in more detail
2018-08-21 10:42:11 -05:00
The Fox in the Shell
dcc4a38f98 ldap_passwd.passwd_set: Use the synchronous API 2018-08-21 11:31:43 -04:00
Brown
4558c9102a Fix passwd function call 2018-08-21 11:31:43 -04:00
Ganesh Nalawade
ce541454e9
Update netconf_config module (#44379)
Fixes #40650
Fixes #40245
Fixes #41541

*  Refactor netconf_config module as per proposal #104
*  Update netconf_config module metadata to core network supported
*  Refactor local connection to use persistent connection framework
   for backward compatibility
*  Update netconf connection plugin configuration varaibles (Fixes #40245)
*  Add support for optional lock feature to Fixes #41541
*  Add integration test for netconf_config module
*  Documentation update
* Move deprecated options in netconf_config module
2018-08-21 20:41:18 +05:30
René Moser
40d37a5add doc: fix maintainer's name (#44452) 2018-08-21 16:32:37 +02:00
Daniel-Sanchez-Fabregas
798dc4b438 In expect module documentation add no_log to password change example (#44436)
* Update expect.py

Recommend not showing passwords in the logs

+label: docsite_pr

* Fix unicode quotes
2018-08-21 08:42:41 -05:00
Martin Nečas
a9362df668 ovirt add remote_vv_file (#41959)
* init remote_vv_file

* update documentation

* update documentation 2

* update description

* add correct style of ovirt info

* update documentation

* correct line width in docs

* use correct end line in docs
2018-08-21 06:40:07 -04:00
Chris Keller
60a6841296 Fix for ovirt_disk Can't Update Disk Name Independently (#44371) (#44372)
* Fix for ovirt_disk Can't Update Disk Name Independently (#44371)

* Adding Disk Rename Example to Example Section (#44371)
2018-08-21 06:36:27 -04:00
Petr Balogh
3f8b51491d Add io_thread parameter for ovirt_templates module (#44406)
Adds ability to set io_threads for template.
2018-08-21 06:35:47 -04:00
Wade Dorrell
8717f5ef5f Spelling and consistency changes (#44425) 2018-08-21 14:07:01 +08:00
Ken Partridge
5b78b1032b Add module cpm_status for WTI device management (#42970)
* Add WTI OOB and PDU Device status, control and configuration module

* reorganized module names, removed multiple modules

* Fixed sanity check failures

* Fixed sanity check failures

* Fixed sanity check failures

* Fixed sanity check failures

* moved module from network directory to remote_management.
added validate_certs parameter
added example returned data.

* pep8 issues

* cpm_status code removed from module section and placed in plugins/lookup.
Modified module code to lookup style code

* EXAMPLE spacing format error

* EXAMPLE formatting

* removed split_line parameter. Return is exclusively formatted JSON

* display edits

* delete display debug text

* Change the examples to use YAML rather than k=v shorthand

* re-enabled "required" flags for cpm_username and cpm_password

* moved redundant ansible.module_utils._text import of to_native to previous ansible.module_utils._text import line

* Got unusual error from GitHub checkin of Unstable, bump to see if it happends again.
2018-08-20 21:56:06 -04:00
Ryan Brown
91a16990d8 New module: Python Requirements Facts (#43108)
* New boto3_facts module

boto3_facts aims to help users see whether their python and module
versions are as expected.

* Rename to `assert_python_requirements`

* Update integration tests

* Document options

* fix imports

* boilerplate

* fix docs

* reorder import

* Make distutils optional and fail gracefully when it is not available

* fix example doc

* fix docs on requirements_facts
2018-08-21 09:19:10 +10:00
Matt Martz
617372f8c0
Mass nuke deprecated items that are easily removed. ci_complete (#44320) 2018-08-20 16:26:10 -05:00
Guilherme Steinmuller
b7139782cf Fix enable_snat parameter (#44418)
Fixes the issue #44285
2018-08-20 16:59:05 -04:00
Matt Martz
9b2baebe64
Don't use copy.deepcopy in high workload areas, use naive_deepcopy (#44337)
* Don't use copy.deepcopy in high workload areas, use deepishcopy. ci_complete

* Add tests

* Add changelog fragment

* rename to naive_deepcopy and add extra docs

* Rename to module_response_deepcopy and move to vars/clean
2018-08-20 15:08:29 -05:00
Monty Taylor
27ac2fc67c Ensure that apt is always chosen on debian/ubuntu (#44413)
One can install alternate packages managers on debuntu machines.
However, doing so doesn't mean you want to suddenly start using them.

Add in a check similar to the fedora yum/dnf check that sets apt as the
pkg_mgr if the ansible_os_family is Debian.
2018-08-20 15:59:56 -04:00
Ryan Brown
6d52afeed6 New module cloudformation_stack_set (#41669)
* [AWS] new module cloudformation_stack_set with integration tests
2018-08-20 14:38:14 -04:00
Julien PRIGENT
3921f34253 ec2_instance.py: Add CpuOptions to EC2 (#43799)
* ec2_instance.py: Add CpuOptions to EC2

* ec2_instance_facts.py: Add CpuOptions to EC2 facts

* ec2_instance.py: LooseVersion and pylint indentation

* Implement nested cpu_options dict

* Fix botocore required version

* ec2_instance: Split integration tests to add executions with old botocore versions

* Ensure runme.sh is executable
2018-08-20 20:49:00 +10:00
Clement Trebuchet
401c45384e FIX ISSUE:#43878 when the vlans string have a final comma. (#43879) 2018-08-20 12:48:46 +05:30
Sumit Jaiswal
167c389270
This PR is raised to implement update of existing Nios Zone and Network objects (#44118)
* to resolve issue 43658

* removing unused variable
2018-08-20 07:14:11 +00:00
Abhijeet Kasurde
d6cc1c37cc
VMware: new module: vmware_category (#39945)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-20 10:45:24 +05:30
Artem Leshchev
8323f3e3b7 Fix module name in error text at parse_xml filter (#44313)
* Fix module name in error text at parse_xml filter

* Fix test that includes erroneous module name in error text at parse_xml filter
2018-08-20 10:19:16 +05:30
Abhijeet Kasurde
e6f0f8073d
VMware: Update other parameters in vSwitch (#43883)
Allow parameter update for vSwitch without any NICs

Fixes: #43821

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-20 10:00:57 +05:30
Abhijeet Kasurde
d06d1d4840
VMware: minor fix for vmware_deploy_ovf (#44299)
* Check value of ovf path
* Assign variable before using

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-20 09:39:05 +05:30
Georg Öttl
d73e9a6508 Update azure_rm_functionapp.py (#43638) 2018-08-20 10:08:54 +08:00
Yanis Guenane
0c65bcb23b Vultr: Introducing vultr_network_facts module (#43600)
This commit introduces a new module called vultr_network_facts.

This module aims to return the list of networks avaiable in Vultr.

Sample available here:

```
"vultr_network_facts": [
  {
    "date_created": "2018-08-02 11:18:49",
    "id": "net5b62e8991adfg",
    "name": "mynet",
    "region": "Amsterdam",
    "v4_subnet": "192.168.42.0",
    "v4_subnet_mask": 24
  }
]
```
2018-08-20 00:29:05 +02:00
Tim Rupp
359d97f01b
Adds bigip_device_auth module (#44373)
This module can be used to configure auth settings to the mgmt
interface on a BIG-IP.
2018-08-19 17:32:19 -04:00
Tim Rupp
b54f6cd132
Adds bigip_firewall_rule module (#44370)
This module can be used to manage rules in either a firewall policy
or a firewall rule list in AFM, on BIGIP.
2018-08-19 14:36:08 -04:00
Tim Rupp
d8ea154fb8
Adds the firewall-rule-list module for BIGIPs (#44368)
This module allows one to manage rule lists in AFM on a BIGIP.
2018-08-19 11:28:03 -04:00
Tim Rupp
8dd39a031f
Adds module to manage srcaddr persistence profiles (#44364)
This module can manage source address persistence profiles on a BIG-IP
2018-08-19 11:13:01 -04:00
Tim Rupp
3a15b6512c
Adds bigip http compression profile module (#44362)
This module can be used to manage http compression profiles on
a BIG-IP.
2018-08-19 02:46:56 -04:00
Tim Rupp
1148d57012
Adds bigip_firewall_policy module (#44361)
This module is used to manage firewall policy objects on a bigip.
2018-08-19 02:18:15 -04:00
Tim Rupp
e95dbf5f47
Adds oneconnect profile module (#44360)
This module can be used to manage oneconnect profiles on a BIG-IP
2018-08-19 01:55:23 -04:00
Tim Rupp
fae42c83f1
Adds bigip_monitor_dns module (#44359)
This module can be used to manage DNS monitors on a BIG-IP.
2018-08-19 01:35:49 -04:00
Tim Rupp
783b565583
Adds bigip_remote_role module (#44358)
This module can be used to manage remote roles on a BIG-IP used
for remote authentication to management interfaces.
2018-08-19 01:15:04 -04:00
Tim Rupp
0eb284b040
Adds cli alias module for BIG-IP (#44357)
This module allows one to manage CLI aliases in a BIG-IP.
2018-08-19 00:56:02 -04:00
Tim Rupp
41df1e15fe
Adds module for utility license assignment on BIG-IQ (#44356)
This module can be used to distribute utility licenses to BIG-IPs
from a BIG-IQ
2018-08-19 00:34:14 -04:00
Tim Rupp
48e99982ff
Adds bigip_software_image module (#44355)
This module can be used to manage software images on a BIG-IP.
2018-08-19 00:16:48 -04:00
Tim Rupp
c1b2ef2c1a
Adds bigip_tunnel module (#44354)
This module can be used to manage tunnels on a BIG-IP.
2018-08-18 23:58:34 -04:00
Tim Rupp
ee5b761c21
Adds bigip_device_facts module (#44351)
This is a new module to manage the different facts that can be gathered
from a bigip.
2018-08-18 16:26:58 -04:00
Yanis Guenane
902c4a04c6 Vultr: Introducing vultr_network module (#43598)
This commit introduces a new module called vultr_network.

It allows a user to manage networks on the Vultr cloud.
2018-08-18 21:56:50 +02:00
Andreas Olsson
8691c7ced7 Add DS record type to cloudflare_dns module (#44349)
Cloudflare recently added support for DS records. They are used to
delegate DNSSEC trust to a subdomain.
2018-08-18 21:56:02 +02:00
Tim Rupp
47b527224a
Renames the security_port_list module (#44350)
Renames the module by adding a symlink, introducing the new module,
and naming the symlink so that it identifies as deprecated.
2018-08-18 14:44:23 -04:00
Tim Rupp
b65f05f9c0
Renames the security_address_list module (#44348)
Renames module and includes a symlink with the old name so that it
will still work, though will be deprecated too.
2018-08-18 14:29:25 -04:00
Abhijeet Kasurde
adf3ab5e72
VMware: Add cluster fact in vmware_vm_facts (#44292)
This fix adds an additional fact about cluster in VM facts.

Fixes: #44101

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-18 18:51:37 +05:30
Christian Rebischke
66a8711ecb fixed proxmox_kvm documentation (#44308)
The documentation defines `cpu` as:

```
default cpu type
default value: kvm64
```

Therefore defining `cpu` with `8` in the `examples` section makes no
sense. So changing to `cores`.

Signed-off-by: Christian Rebischke <Chris.Rebischke@posteo.de>
2018-08-18 05:39:18 -04:00
Abhijeet Kasurde
19116e0102 ovirt: minor typo fixes in documentation (#44345)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-18 10:06:52 +02:00
mooninite
8bf122e97f vmware_deploy_ovf: Add cluster support (#43606)
When a datacenter has multiple clusters it is required to use the
cluster name to find the correct default resource pool to import
OVF images to.

Fixes issue 42644.

Signed-off-by: Michael Cronenworth <mike@cchtml.com>
2018-08-18 12:07:13 +05:30
Chris Adams
ab76fcd18a rds_instance_facts: use correct parameter in example (#44323)
The example referenced `name:` which is not a supported parameter.

+label: docsite_pr
2018-08-18 09:48:44 +10:00
Chris Archibald
8c97aa948e Bug Fixes for ontap_interface.py (#44200) 2018-08-17 14:37:15 -07:00
Chris Archibald
4abfbe06c4 Bug fixes for ontap_broadcast_domain_ports.py (#44180) 2018-08-17 14:37:03 -07:00
Chris Archibald
87467dcd66 Bug fixes for ontap_cifs.py (#44182) 2018-08-17 14:36:07 -07:00
Chris Archibald
cfa304a400 Bug fixes for ontap_cifs_acl.py (#44184) 2018-08-17 14:35:43 -07:00
Chris Archibald
3d0287aca1 Bug Fixes for ontap_cluster.py: (#44187) 2018-08-17 14:35:14 -07:00
Chris Archibald
9dac00fabe Bug fixes for na_ontap_cluster_ha.pya (#44188) 2018-08-17 14:34:53 -07:00
Chris Archibald
9858f41628 Bug Fixes for ontap_iscsi.py (#44201) 2018-08-17 14:30:53 -07:00
Chris Archibald
5778691923 Bug Fixes for ontap_job_schedule.py (#44202) 2018-08-17 14:30:33 -07:00
Chris Archibald
cd2af0b06a Bug Fixes for ontap_license.py (#44203) 2018-08-17 14:29:42 -07:00
Chris Archibald
060d444949 Bug Fixes for ontap_lun_map.py (#44205) 2018-08-17 14:29:33 -07:00
Chris Archibald
d220859190 Bug fixes for ontap_net_ifgrp.py (#44206) 2018-08-17 14:27:07 -07:00
Chris Archibald
6e527c3f36 Bug Fixes for ontap_net_port.py (#44207) 2018-08-17 14:26:26 -07:00
Chris Archibald
4be72ba60d Bug Fixes for ontap_ntp.py (#44212) 2018-08-17 14:23:16 -07:00
Chris Archibald
44f4f54fe5 Bug Fixes for ontap_service_processor_network.py (#44214) 2018-08-17 14:22:33 -07:00
Chris Archibald
270bc58b84 Bug Fixes for ontap_snmp.py (#44217) 2018-08-17 14:15:38 -07:00
Alex Stephen
bcc5b6ac7e New GCP Module: gcp_compute_ssl_policy_facts (#44042) 2018-08-17 15:55:20 -04:00
Alex Stephen
799fdc4612 New GCP Module: gcp_compute_ssl_certificate_facts (#44041) 2018-08-17 15:48:17 -04:00
Alex Stephen
7676fb14ba New GCP Module: gcp_compute_instance_facts (#43698) 2018-08-17 15:47:51 -04:00
Alex Stephen
e97558d4f7 New GCP Module: gcp_compute_subnetwork_facts (#44043) 2018-08-17 15:24:24 -04:00
Alex Stephen
3eeb474907 New GCP Module: gcp_compute_target_pool_facts (#44046) 2018-08-17 15:24:12 -04:00
stoned
e5f4987a8f Make mandatory filter error message more verbose (#44139)
...by adding the undefined variable/attribute name, if available.
2018-08-17 15:11:43 -04:00
Alex Stephen
9abe66845f New GCP Module: gcp_compute_target_vpn_gateway_facts (#44049) 2018-08-17 14:58:41 -04:00
Alex Stephen
fc7aca48a6 New GCP Module: gcp_compute_backend_bucket_facts (#44024) 2018-08-17 14:45:07 -04:00
Alex Stephen
80881483e1 New GCP Module: gcp_compute_disk_facts (#44026) 2018-08-17 14:44:52 -04:00
Alex Stephen
cca329d532 New GCP Module: gcp_compute_forwarding_rule_facts (#44028) 2018-08-17 14:44:39 -04:00
Alex Stephen
4739434ad2 New GCP Module: gcp_compute_global_forwarding_rule_facts (#44030) 2018-08-17 14:44:16 -04:00
Alex Stephen
04c9d47209 New GCP Module: gcp_compute_image_facts (#44034) 2018-08-17 14:37:27 -04:00
Alex Stephen
5022360358 New GCP Module: gcp_compute_instance_group_facts (#44035) 2018-08-17 14:35:18 -04:00
Alex Stephen
b0009dc9c8 New GCP Module: gcp_compute_instance_group_manager_facts (#44036) 2018-08-17 14:35:03 -04:00
Alex Stephen
7eff98bee1 New GCP Module: gcp_compute_instance_template_facts (#44037) 2018-08-17 14:34:18 -04:00
Chris Smolen
3f5cf2aad4 add example using the "when" keyword (#41038)
* add example using the "when" keyword

<!--- Your description here -->
add example using the "when" keyword comparing group_var variable to returned value from ios_facts
+label: docsite_pr
+label: issue #311

* Update ios_config.py

* Update ios_config.py
2018-08-17 14:30:37 -04:00
Alex Stephen
79cca62028 New GCP Module: gcp_compute_network_facts (#44038) 2018-08-17 14:26:59 -04:00
Alex Stephen
d494b70902 New GCP Module: gcp_compute_route_facts (#44039) 2018-08-17 14:26:09 -04:00
Alex Stephen
18139104ee New GCP Module: gcp_compute_router_facts (#44040) 2018-08-17 14:25:25 -04:00
Anil Kumar Muraleedharan
31158b322e Moving method from util to module (#43923)
* Moving method from util to module

* Update cnos_portchannel.py

* To remove unwanted method from cnos.py
2018-08-17 14:17:11 -04:00
Dmitrii Shuvar
9d3b479faf Update docs iptables.py (#41245)
* Update iptables.py

added to documentation the required variable 'protocol' for variable destination_port.

* Update iptables.py
2018-08-17 20:14:30 +02:00
Yanis Guenane
e635dc6969 Vultr: Introducing vultr_block_storage_facts module (#43218)
This commit introduces a new module called vultr_block_storage_facts.

This module aims to return the list of block storage volume avaiable
in Vultr.
2018-08-17 19:32:13 +02:00
Alex Stephen
81f211c995 New GCP Module: gcp_compute_target_tcp_proxy_facts (#44048) 2018-08-17 13:25:40 -04:00
Alex Stephen
2ca83b0dbb New GCP Module: gcp_compute_target_ssl_proxy_facts (#44047) 2018-08-17 13:25:33 -04:00
Alex Stephen
e36cd0fd53 New GCP Module: gcp_compute_target_http_proxy_facts (#44044) 2018-08-17 13:25:10 -04:00
Alex Stephen
672584c0d2 New GCP Module: gcp_compute_target_https_proxy_facts (#44045) 2018-08-17 13:24:55 -04:00
Alex Stephen
812db9240a New GCP Module: gcp_compute_https_health_check_facts (#44033) 2018-08-17 13:22:01 -04:00
Alex Stephen
a9a0ef8959 New GCP Module: gcp_compute_http_health_check_facts (#44032) 2018-08-17 13:21:51 -04:00
Alex Stephen
4fa371deea New GCP Module: gcp_compute_health_check_facts (#44031) 2018-08-17 13:21:44 -04:00
Alex Stephen
868ec6305c New GCP Module: gcp_compute_url_map_facts (#44050) 2018-08-17 13:20:35 -04:00
Alex Stephen
1b4c3a6688 New GCP Module: gcp_compute_vpn_tunnel_facts (#44052) 2018-08-17 13:12:53 -04:00
Alex Stephen
2fe1f3deb4 Bug fixes for gcp_compute_backend_service_facts (#44291) 2018-08-17 13:12:24 -04:00
Alex Stephen
605fb0f68f New GCP Module: gcp_compute_address_facts (#44023) 2018-08-17 12:38:50 -04:00
Alex Stephen
0c0fce7532 New GCP Module: gcp_compute_vpn_tunnel (#44051) 2018-08-17 12:35:12 -04:00
Anil Kumar Muraleedharan
6f94f8be08 Update cnos_backup.py (#44246)
* Update cnos_backup.py

* Removing unused methods in cnos.py util file.
2018-08-17 12:07:55 -04:00
Anil Kumar Muraleedharan
dafe633d02 cnos_conditional_command to use persistent connection instead of paramiko (#43876)
* Making cnos_conditional_template to use persistent connection instead of paramiko
2018-08-17 12:02:47 -04:00
Anil Kumar Muraleedharan
9c1f06268e Making cnos_conditional_template to use persistent connection instead of paramiko (#43868)
* Making cnos_template to use persistent connection instead of paramiko
2018-08-17 12:01:42 -04:00
Zhikang Zhang
501503f4cb
Allow version specifiers for pip install (#41792)
Allow version specifiers for pip install.
2018-08-17 11:46:53 -04:00
Adam Miller
6d95624c22 Refactor yum and dnf, add feature parity (#43621)
* Refactor yum and dnf, add feature parity

Signed-off-by: Adam Miller <admiller@redhat.com>

* remove unnecessary module_utils, move the classes into the module code

Signed-off-by: Adam Miller <admiller@redhat.com>

* remove yum -> yum4, out of scope

Signed-off-by: Adam Miller <admiller@redhat.com>

* use ABCMeta

Signed-off-by: Adam Miller <admiller@redhat.com>

* re-arrange run() caller vs callee

Signed-off-by: Adam Miller <admiller@redhat.com>

* make sanity checks happy

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix yum unit tests

Signed-off-by: Adam Miller <admiller@redhat.com>

* remove unecessary debug statements, fix typo

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix licensing and attribution in yumdnf module_util

Signed-off-by: Adam Miller <admiller@redhat.com>

* include fix from PR 40737

original commit 5cbda9658a
original Author: Strahinja Kustudic <kustodian@gmail.com>

yum will fail on 'No space left on device', fixes #32791 (#40737)

During the installing of packages if yum runs out of free disk space,
some post install scripts could fail (like e.g. when the kernel
package generates initramfs), but yum would still exit with a status
0.  This is bad, especially for the kernel package, because it makes
it unable to boot.  Because the yum module is usually used for
automation, which means the users cannot read every message yum
prints, it's better that the yum module fails if it detects that
there is no free space on the disk.

Signed-off-by: Adam Miller <admiller@redhat.com>

* Revert "fix licensing and attribution in yumdnf module_util"

This reverts commit 59e11de5a2.

* move fetch_rpm_from_url out of yumdnf module_util

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix the move of fetch_rpm_from_url

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-17 11:15:11 -04:00
Zhikang Zhang
d7921b4d5b
Support --separate-git-dir option in Git module (#41712)
Make git module support --separate-git-dir option. When git version is higher than 1.7.5, use built-in --separate-git-dir option during the clone. When lower, adjust the location of git dir manually after clone to achieve the same effect.
2018-08-17 10:43:04 -04:00
Alicia Cozine
0be5734741 add insertbefore/after details to lineinefile docs (#44277) 2018-08-17 10:19:07 -04:00
Felix Fontein
a99cfc1814 New acme_account_facts module. (#44301) 2018-08-17 15:32:09 +02:00
Chris Archibald
bc4f7abe96 Bug fixes for ontap_ucadapter.py (#44221) 2018-08-17 09:21:59 -04:00
Chris Archibald
374a22f4c7 Bug Fixes for ontap_user.py (#44222) 2018-08-17 09:21:50 -04:00
Chris Archibald
6d97765688 Bug Fixes for ontap_user_role.py (#44223) 2018-08-17 09:11:39 -04:00
Chris Archibald
d0a7147224 Bug fixes for ontap_volume_clone.py (#44225) 2018-08-17 09:11:28 -04:00
Monty Taylor
e89e4c991c Fix openstack inventory plugin for API changes (#43580)
The inventory plugin api grew a self.cache that wasn't there when we
first wrote it. There's also a need to pull in the documentation
fragments so that we have the cache parameters.
2018-08-17 07:03:08 -04:00
Abhijeet Kasurde
39e2bd01a6
VMware: remove blank from ntp server list (#44273)
Due to blank line returned from vCenter, wrong values were appended
to NTP server list. This fix adds filter for such blank values of NTP servers.

Fixes: #44183

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-17 15:23:56 +05:30
Yanis Guenane
57497a490b Vultr: Introducing vultrr_block_storage module (#43202)
This commit introduces a new module called vultr_block_storage/

It allows a user to manage block storage volumes on the Vultr cloud.
2018-08-17 10:30:57 +02:00
Trishna Guha
899eddf9e4
fix diff precedence cli_config module (#44295)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-08-17 12:59:24 +05:30
Deepak Agrawal
aed6722fbc
DCI devel iosxr fix : on-device diffs does not work always (#44265)
* fix devel dci failure on iosxr

* pep8 issue fix
2018-08-17 12:34:11 +05:30
Trishna Guha
6090802551
nxos_linkagg mode fix (#44294)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-08-17 12:27:13 +05:30
Felix Fontein
cfba02bc3b Allowing to force account URI. (#44282) 2018-08-17 07:43:38 +02:00
Abhijeet Kasurde
6caf0e8149
VMware: New module : vmware_host_ssl_facts (#43871)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-17 10:25:25 +05:30
George Wilson
90517f4dfa Azure RM Common - use built in module logging (#43820) 2018-08-17 10:40:25 +08:00
Zim Kalinowski
5f36c73fe5 adding mysql database facts (#43322) 2018-08-17 10:36:13 +08:00
Zim Kalinowski
c8649f8b73 adding postgresql database facts (#43327) 2018-08-17 10:35:22 +08:00
Nicolai
bfdaf40a7a Add netcup_dns module (Manage DNS records hosted by netcup) (#44063)
* Add support for netcup dns api
2018-08-16 14:56:54 -07:00
Madhura-CSI
47cb3856b5 Support for accelerated networking and network security group for scaleset vms (#34788)
* Support for accelerated networking and network security group for scaleset vms
2018-08-16 14:52:12 -07:00
Matt Martz
509e92ef72
Swap default for INVALID_TASK_ATTRIBUTE_FAILED to True, add additional info to exception (#44138) 2018-08-16 16:30:47 -05:00
Matt Martz
0beaea22a4
Bump deprecation for include to 2.12 (#44230) 2018-08-16 16:30:10 -05:00
Felix Fontein
f7ac1c588d Move acme_* modules from web_infrastructure into crypto category (#44279)
* Moving acme_* modules from web_infrastructure into crypto category.

* Creating new subcategory 'acme' in 'crypto'.
2018-08-16 22:21:39 +02:00
Evgeni Golov
aa354cbad0 meta: sort choices matching to description (#23004) 2018-08-16 14:15:20 -05:00
Steve Jennings
a9cf4d58bf Fix grammar and clarify 'list' description for ABE (#44271)
Grammar on the description for option 'list' was grammatically incorrect. Also suggest to add wording that clarifies that 'list' is indeed Access-Based Enumeration.

+label: docsite_pr
2018-08-16 14:54:15 -04:00
Yanis Guenane
2556098479 Vultr: Introducing vultr_server_facts module (#43001)
This commit introduces a new module called vultr_server_facts.

This module aims to return the list of servers avaiable avaiable in
Vultr.

Sample available here:

```
"vultr_server_facts": [
  {
    "allowed_bandwidth_gb": 1000,
    "application": null,
    "auto_backup_enabled": false,
    "cost_per_month": 5.00,
    "current_bandwidth_gb": 0,
    "date_created": "2018-07-19 08:23:03",
    "default_password": "p4ssw0rd!",
    "disk": "Virtual 25 GB",
    "firewallgroup": null,
    "id": 17241096,
    "internal_ip": "",
    "kvm_url": "https://my.vultr.com/subs/vps/novnc/api.php?data=OFB...",
    "name": "ansibletest",
    "os": "CentOS 7 x64",
    "pending_charges": 0.01,
    "plan": "1024 MB RAM,25 GB SSD,1.00 TB BW",
    "power_status": "running",
    "ram": "1024 MB",
    "region": "Amsterdam",
    "server_state": "ok",
    "status": "active",
    "tag": "",
    "v4_gateway": "105.178.158.1",
    "v4_main_ip": "105.178.158.181",
    "v4_netmask": "255.255.254.0",
    "v6_main_ip": "",
    "v6_network": "",
    "v6_network_size": "",
    "v6_networks": [],
    "vcpu_count": 1
  }
]
2018-08-16 20:29:48 +02:00
Raúl Cuza
c84e70cf10 Add note to apt_key doc about update requirement (#25111)
* Add note about adding new key requiring update

When a new repo and new key are added, attempts to install packages
signed by that key fail until `apt-get update` is run.  This note
is an attempt to help users avoid getting errors when they miss
this step.

* related to issue #25091

* switch example to apt module
2018-08-16 13:18:17 -05:00
axelll
29fa302ce9 Update proxysql_query_rules.py (#43877)
<!--- Your description here -->

+label: docsite_pr
2018-08-16 19:52:08 +02:00
Nilashish Chakraborty
d63ba5999b
Use single parameter for source-interface (#44260)
* Compress src interface into one key

* Modified regex to support varied interface types

* Fixed documentation

* Unpacking return values from splitting method
2018-08-16 22:33:53 +05:30
Lindsay Hill
3960ebb8e8 new voss_facts module (#44234)
@LindsayHill Thank you!
2018-08-16 18:53:35 +05:30
Anil Kumar Muraleedharan
410c85522a Making cnos_template to use persistent connection instead of paramiko (#43862)
* Making cnos_template to use persistent connection instead of paramiko
2018-08-16 09:13:06 -04:00
Chris Archibald
ef037480a4 Bug fixes for na_ontap_aggregate.py (#44177)
* Bug fixes for na_ontap_aggregate.py

* Fix issues
2018-08-16 08:48:11 -04:00
Chris Archibald
92a2207199 Bug Fixes for ontap_broadcast_domain.py (#44179)
* Bug Fixes for ontap_broadcast_domain.py

* Fix issues
2018-08-16 08:37:06 -04:00
Chris Archibald
d22d97d420 Bug fixes for ontap_cifs_server.py (#44185)
* Bug fixes for ontap_cifs_server.py

* Fix issues
2018-08-16 08:36:47 -04:00
Chris Archibald
5f29735987 Bug Fixes for ontap_lun.py (#44204)
* Bug Fixes for ontap_lun.py

* Fix issues
2018-08-16 08:36:28 -04:00
Chris Archibald
aa44158f80 Bug Fixes for ontap_nfs.py (#44210)
* Bug Fixes for ontap_nfs.py

* Fix issues
2018-08-16 08:36:19 -04:00
Chris Archibald
11a3d56faf Bug Fixes for ontap_svm.py (#44219)
* Bug Fixes for ontap_svm.py

* Fix issues
2018-08-16 08:36:10 -04:00
Chris Archibald
38680f38f1 Bug Fixes for ontap_volume.py (#44224)
* Bug Fixes for ontap_volume.py

* Fix issues
2018-08-16 08:36:00 -04:00
Chris Archibald
b83565958e Bug fixes for ontap_export_policy.py (#44194)
* Adding ontap_export_policy.py Module

* fix issues
2018-08-16 08:15:32 -04:00
Chris Archibald
1d0dede9de Bug Fixes for ontap_igroup.py (#44199)
* Bug Fixes for ontap_igroup.py

* Fix issues
2018-08-16 08:15:23 -04:00
Chris Archibald
95b86dea88 Bug fixes for ontap_qtree.py (#44213)
* Bug fixes for ontap_qtree.py

* Fix issues
2018-08-16 08:15:13 -04:00
Sumit Jaiswal
4e5dbb92dc
To resolve nios_network issue where vendor-encapsulated-options can not have a use_option flag (#43925)
* to resolve 43657

* fix shippable error
2018-08-16 09:29:48 +00:00
Zim Kalinowski
ac895828c1 adding mysqlserver facts (#43321) 2018-08-16 17:10:07 +08:00
Trishna Guha
7e39c5bf07
check_mode in nxos_static_route module (#44252)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-08-16 14:30:47 +05:30
Yunge Zhu
aef5099695 add azure app service plan facts (#44156)
* add app service plan facts

* fix lint

* fix missed tags

* remove  azure_

* fix test random
2018-08-16 16:13:32 +08:00
Sumit Jaiswal
6a395d8e24
to resolve 43705 (#44078) 2018-08-16 08:11:30 +00:00
Trishna Guha
6af6e806ed
nxos_interface port-channel idempotence fix for mode (#44248)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-08-16 12:16:04 +05:30
Zim Kalinowski
0a9c58f866 adjusting curated response format, notification of raw format depreciation. (#43587) 2018-08-16 14:45:36 +08:00
Abhijeet Kasurde
f9d4e4d396 ovirt: minor typo in documentation (#44241)
Fixed "attribues" to "attributes"

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-16 07:10:03 +02:00
Robson Roberto Souza Peixoto
2796be1132 Add AzureRMStorageAccount StorageV2 kind (#44242)
close 38455
2018-08-16 12:58:01 +08:00
Bjorn Hansen
ff6d4e6bf4 azure_rm_common: only remove tags from new_tags if append_tags is not… (#24040) 2018-08-16 11:35:39 +08:00
Jasper Aorangi
babfe45852 Add 'panos_set' module for pushing arbitrary commands to PAN-OS NVA's (#43339)
* Add 'panos_set' module for pushing arbitrary commands to PAN-OS NVA devices
2018-08-15 20:16:30 -07:00
Lance Richardson
dc08b9a738 new module exos_config (#43902)
- support config operations for EXOS-based platforms
- add regex to detect command failure responses
- add exos action plugin for "backup" operation
- add unit tests for exos_command (currently 94% coverage of
  exos_config.py)
2018-08-15 14:56:50 -07:00
Sam Doran
00e7c020b2 Add backup feature to user module (#41854)
*  Add backup option

* Only backup shadow file when the OS has one

* Only backup shadow file for SunOS

* Update docs on backup feature

* Add changelog fragment

* Add tests for shadow backup

* Remove backup option, make it automatic

Remove the option to enable/disable backups and make it automatic. Add note to docs describing this behavior.

Change tests to account for new module behavior.

Change section name in changelog fragment since minor_features is not a valid section.
2018-08-15 16:22:26 -04:00
Zhikang Zhang
0971a342d8
Solve race condition in password lookup (#42529)
NOTE:
1. use os.open() with os.O_CREAT|os.O_EXCL to check existence
and create a lock file if not exists, it's an atomic operation
2. the fastest process will create the lock file and others will
wait until the lock file is removed
3. after the writer finished writing to the password file, all the reading
operations use built-in open so processes can read the file parallel
2018-08-15 15:10:52 -04:00
Tom Matthews
5c1e620504 Strip trailing comments from /etc/default/passwd (#43931)
* strip additional comments from /etc/default/passwd

Strip trailling comments from /etc/default/passwd like
MINWEEKS=1 #MINWEEKS=2
MAXWEEKS=12  # MAXWEEKS=8
Which otherwise cause failures with "failed to read /etc/default/passwd: too many values to unpack"

* fix carriage return typo in commit

* yet another typo in commit

* Fix indent problem

* add changelog fragment for PR 43931
2018-08-15 15:04:45 -04:00
Andreas Olsson
3ddec4d64e Fix the nsupdate module's TTL change detection (#42973)
Ideally I would have liked to compare the TTL as part of the
prerequisite check. Sadly that isn't supported by the RFC 2136 update
protocol. Hence the additional query.

Resolves #39465
2018-08-15 14:33:00 -04:00
Alex Stephen
63e87a3a0a Bug fixes for gcp_compute_route (#42820) 2018-08-15 14:28:49 -04:00
Alex Stephen
f5f0d16516 Bug fixes for gcp_compute_subnetwork (#42822) 2018-08-15 14:28:36 -04:00
Alex Stephen
97b3845e89 Bug fixes for gcp_compute_url_map (#42828) 2018-08-15 14:28:24 -04:00
Alex Stephen
82678b9bac Bug fixes for gcp_pubsub_topic (#42834) 2018-08-15 14:28:08 -04:00
Alex Stephen
87c6d4be57 Bug fixes for gcp_storage_bucket (#42835) 2018-08-15 14:27:41 -04:00
Alex Stephen
cbf945d287 Bug fixes for gcp_compute_network (#42819) 2018-08-15 13:52:13 -04:00
Alex Stephen
60e78f33ce Bug fixes for gcp_compute_http_health_check (#42812) 2018-08-15 13:52:00 -04:00
Andreas Olsson
6d772874f9 Add SSHFP and TLSA records to cloudflare_dns module (#44011)
* Update cloudflare_dns account link

* Add SSHFP and TLSA records to cloudflare_dns module

These are record types which Cloudflare recently added support
for. They both go well together with DNSSEC.

Technically it's a bit of a simplification to use the hash_type
parameter for TLSA records. Yet, it fits with all the real world usage
I have seen, and it keeps the module from sprawling too much.

Related to #43803
2018-08-15 17:30:33 +02:00
Andrew Gaffney
5708894f90 Bugfixes and integration tests for 'default' callback plugin
* display 'changed' tasks when hiding 'ok' tasks
* display proper task title for handlers (fixes #44007)
2018-08-15 07:56:17 -07:00
ivarmu
742ba04125 Add callback plugin to show current/total numberings for tasks and hosts in a task. (#40769)
Change version_added as requested
2018-08-15 10:22:53 -04:00
Michael Mayorov
7538a63f70 Fix referenced before assignment in sysvinit module (#42695)
* Fix referenced before assignment in sysvinit module

* removed redundant variable initialization
2018-08-15 09:59:03 -04:00
Martin Nečas
9d5ce3d335 add custom_compatibility_version (#40813)
* add custom_compatibility_version

* use implemented methods get minor and major
2018-08-15 08:56:18 -04:00
Ondra Machacek
df581eb749 ovirt_vms: Search template also by cluster (#44161) 2018-08-15 08:22:49 -04:00
Ganesh Nalawade
d9ee693652
Update netconf plugins for junos and iosxr (#44157)
* Update netconf plugins for junos and iosxr

Fixes #39160

*  Update api signature for netcon api's
   from variable arguments to named arguments

* Udpate get default rpc supported

* Fix CI issue
2018-08-15 16:34:45 +05:30
tzurE
615337c3d7 Add ibm storage module to ansible (#39960)
* Initial commit for ibm_storage ansible modules
Added modules for managing IBM Spectrum Accelerate storage systems.
Separate modules to manipulate storage entities within the systems.

* sanity checks fix

* PR sanity checks fix

* updated the review to contain only one module, one utility and doc fragment, as instructed at the core meeting.

* IBM_Storage: fixed review issues.

* IBM_Storage: fix review issues

* IBM_Storage: review issues and sanity checks

* IBM_Storage: Review and sanity fixes

* IBM_Storage: pep8 fix

* IBM_Storage: review fixes

* IBM_Storage: review issues

* IBM_storage: license fix
2018-08-15 08:38:11 +02:00
housysadm
bb553f138b ios_user purge example (#42904)
* Update ios_user.py

Added an example of purging all users except those listed and admin

* Update ios_user.py
2018-08-14 17:23:10 -04:00
Matt Davis
6b81c36533
restore task arg splatting (#43798)
* restore task arg splatting

* reverts #41804
* supersedes #41295
* fixes #42192
* after lots of discussion amongst the core team, we decided to preserve this feature, clarify the runtime warnings/docs, and prioritize a path toward fixing the underlying behavior that causes this feature to be insecure (un-namespaced facts).

* update faq text

note that warning is disabled when inject_facts_as_vars is

* wordsmithing FAQ entry
2018-08-14 12:58:00 -07:00
Chris Archibald
9dceca8a88 Deprecated Old NetApp Cdot Modules (#43781)
* MVP2 Post ElementSW OSRB sync

* Revert "MVP2 Post ElementSW OSRB sync"

This reverts commit c13db2ad962cd56bffce052c2891c558a2240c72.

Undoing bad push

* move deprecated files

* add documentation

* add new line

* Fix version issue

* fix issue with ignore file, hopefully

* Add ontap modules to porting guide

* fix refs

* add _module to ref
2018-08-14 09:39:52 -07:00
Alex Stephen
984cc10465 Bug fixes for gcp_compute_target_tcp_proxy (#42827) 2018-08-14 09:53:46 -04:00
Alex Stephen
97006cded2 Bug fixes for gcp_compute_target_http_proxy (#42823) 2018-08-14 09:53:29 -04:00
Alex Stephen
569e094efd Bug fixes for gcp_compute_target_ssl_proxy (#42826) 2018-08-14 09:52:57 -04:00
Alex Stephen
b88442064f Bug fixes for gcp_compute_target_pool (#42825) 2018-08-14 09:52:40 -04:00
Alex Stephen
eaacda42f5 Bug fixes for gcp_compute_target_https_proxy (#42824) 2018-08-14 09:52:25 -04:00
Yanis Guenane
763d66ff9c Vultr: Ensure self.returns is the source of truth (#44115)
As of today, self.returns it not the source of truth. If the return
value from querying the resource contains more values than the one
listed in self.returns, those value will be returned even though not
explicitly specified in self.returns.

This commit ensures that only the values listed on self.returns are
actually returned. The other values not listed are supressed.
2018-08-14 15:43:15 +02:00
Yanis Guenane
21fcaf0738 scaleway: Add common documentation fragment
Every scaleway modules will require the same base of parameters. Instead
of documenting it each and every time, we build a doc fragment that will
allow one to simply extend documentation for every new module.

extends_documentation_fragment: scaleway
2018-08-14 14:03:32 +02:00
Strahinja Kustudic
5cbda9658a yum will fail on 'No space left on device', fixes #32791 (#40737)
During the installing of packages if yum runs out of free disk space,
some post install scripts could fail (like e.g. when the kernel package
generates initramfs), but yum would still exit with a status 0.  This is
bad, especially for the kernel package, because it makes it unable to
boot.  Because the yum module is usually used for automation, which
means the users cannot read every message yum prints, it's better that
the yum module fails if it detects that there is no free space on the
disk.
2018-08-14 13:41:34 +02:00
Deepak Agrawal
84bedcbd82
Httpapi plugin for Firepower device (#43773)
* Common Rest Module using httpapi transport

* comparing json objects

* platform independant Rest Api

* FTD rest module

* Remove FTD module which will be committed later from cisco team

* remove debug code

* remove common rest module

* fix shippable errors

* Add notification users

* more shipable errors
2018-08-14 14:28:07 +05:30
Trishna Guha
a8c24a5d5e
Add cli_config module (#42413)
* cli_config module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* rename diff and replace

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* add nxos changes

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* nxos tests

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* remove severity

* address review comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* add module diff

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* add iosxr test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* address diff review

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add junos tests

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* vyos cliconf diff fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-08-14 13:52:15 +05:30
Trishna Guha
227bf61daa
junos cliconf diff fix (#44109)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-08-14 13:01:27 +05:30
Nilashish Chakraborty
b14f256d41
Fixes ios_l2_interface and ios_vlan not working on certain interface types issue (#43819)
* Fixes #43654 and #43582

* Remove q statement

* Fix shippable errors

* Fix more shippable errors

* Fix unittest
2018-08-14 11:35:09 +05:30
Trishna Guha
e188073629
multiline_delimiter should be True ios cliconf (#44106)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-08-14 11:34:07 +05:30
Zim Kalinowski
ee96d42d7d Fixing upgrade_policy idempotence (#38022) 2018-08-14 13:24:34 +08:00
Trishna Guha
43ae240431
nxos_facts test lldp feature and fix nxapi check_rc (#44104)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-08-14 10:14:13 +05:30
Lindsay Hill
727503c5ab fix typo in edit_config_capability name (#44102) 2018-08-14 09:17:50 +05:30
Andreas Calminder
21066410be authorized_key 29891 use os.path.realpath to follow keyfile symlinks (#40417)
* 29891 use os.path.realpath to follow keyfile symlinks
* 29891 add parameter follow
* updated changelog fragment
* add documentation and set default to false
2018-08-13 16:06:33 -07:00
Toshio Kuratomi
688ffa4cee We can create a frozenset from a tuple
No need to create an intermediate set.
2018-08-13 15:21:44 -07:00
Tim Rupp
96a6011b3f
Update f5 module_utils from downstream (#44092)
Upstreaming fixes and features for f5 module_utils as part of 2.7
dev cycle
2018-08-13 15:14:23 -07:00
Zhikang Zhang
cda3b53035
make doc templates not case sensitive for the default value (#41158) 2018-08-13 16:47:12 -04:00
Alex Stephen
b0542217e2 Bug fixes for gcp_compute_instance_template (#42818) 2018-08-13 15:29:48 -04:00
Alex Stephen
829dcf1d23 Bug fixes for gcp_compute_instance_group (#42816) 2018-08-13 15:29:27 -04:00
Alex Stephen
f977590a2a Bug fixes for gcp_compute_instance (#42815) 2018-08-13 15:28:50 -04:00
Alex Stephen
7a92b8c9ed Bug fixes for gcp_compute_global_forwarding_rule (#42810) 2018-08-13 15:28:11 -04:00
nishiokay
c99cd634bb Update cs_storage_pool.py (#42454)
Added "maintenance" to allocation_state in the Parameters section.

+label: docsite_pr
2018-08-13 15:19:36 -04:00
Alex Stephen
f405857f50 Bug fixes for gcp_compute_firewall (#42807) 2018-08-13 14:55:10 -04:00
Matt Martz
17c89d1ffa
Remove unused rslt_q, rename the one queue to final_q everywhere (#43894)
* Remove unused rslt_q, rename the one queue to final_q everywhere

* Test update
2018-08-13 13:43:28 -05:00
Till Maas
bb85bbceeb pip: combine chdir and env only when env is set (#40793)
* pip: combine chdir and env only when env is set

This fixes an AttributeError when chdir without virtualenv is specified:

 File "/tmp/ansible_2UAFsZ/ansible_module_pip.py", line 387, in main
    env = os.path.join(chdir, env)
 File "/usr/lib64/python2.7/posixpath.py", line 75, in join
    if b.startswith('/'):
AttributeError: 'NoneType' object has no attribute 'startswith'

* Add test for pip with chdir

Signed-off-by: Till Maas <opensource@till.name>
2018-08-13 19:59:01 +02:00
Sumit Jaiswal
fd4e774cec
Resolves bug where existing host_record was deleted when existing record name is used with different IP (#43235)
* resolves bug 42937

* resolves integration test failure

* resolves integration test failure

* resolves integration test failure
2018-08-13 17:27:06 +00:00
Sam Doran
6d38167d49
Only template values in vars_prompt rather than all vars (#39304)
* Only template values in vars_prompt rather than all vars

This allows the use of variables in vars_prompt fields but allows variables entered in the prompt to affect play vars rather than throwing an undefined error.

Only post validate if there was a vars_prompt

* Add tests for vars_prompt
2018-08-13 12:54:31 -04:00
Stefan Prietl
d5662df695 Fix actions and wait in os_server_action module (#43504)
* Fix call to sdk.iterate_timeout in os_server_action

* Correct indentation for several actions in os_server_action
2018-08-13 12:52:20 -04:00
Zhikang Zhang
b20d903cc4 Give warning if user inputs not encrypted password to user module (#43615)
* Check the password format

Check the password format and notify user if they
input unencrypted password.

* Fix sanity error

* Add integration test

* Missed a task name

* Hard code the testing password

Since some testing platfrom has no passlib installed

* Add changelog fragment

* Rework some English sentences

* Fix a grammar mistake
2018-08-13 12:45:37 -04:00
Juan Jimenez
cceddfab9b Update lambda.py (#44066)
Timeout doesn't say if in secs, minutes or ??
2018-08-13 12:33:14 -04:00
Alex Stephen
50bd91b48b New GCP Module: gcp_compute_backend_service_facts (#44025) 2018-08-13 12:21:49 -04:00
Alex Stephen
fbfea59d7d Bug fixes for gcp_compute_ssl_certificate (#42821) 2018-08-13 12:15:15 -04:00
Alex Stephen
c38e1e5631 Bug fixes for gcp_container_cluster (#42829) 2018-08-13 12:15:02 -04:00
Alex Stephen
dd3c4b0d39 Bug fixes for gcp_pubsub_subscription (#42833) 2018-08-13 12:14:11 -04:00
Alex Stephen
3dc363d135 Bug fixes for gcp_storage_bucket_access_control (#42836) 2018-08-13 12:13:53 -04:00
Alex Stephen
7f10d432ec Bug fixes for gcp_container_node_pool (#42830) 2018-08-13 12:11:06 -04:00
Alex Stephen
7f981b4123 Bug fixes for gcp_dns_managed_zone (#42831) 2018-08-13 12:09:38 -04:00
Alex Stephen
2a346af18b Bug fixes for gcp_compute_instance_group_manager (#42817) 2018-08-13 12:09:23 -04:00
Alex Stephen
c239e6f045 Bug fixes for gcp_compute_https_health_check (#42813) 2018-08-13 12:08:42 -04:00
Alex Stephen
6b5f86a4aa Bug fixes for gcp_compute_image (#42814) 2018-08-13 12:08:12 -04:00
Alex Stephen
439716a832 Bug fixes for gcp_compute_health_check (#42811) 2018-08-13 12:07:24 -04:00
Alex Stephen
c8418a709b Bug fixes for gcp_compute_disk (#42806) 2018-08-13 12:04:57 -04:00
Alex Stephen
146c126780 Bug fixes for gcp_compute_global_address (#42809) 2018-08-13 12:02:10 -04:00
Alex Stephen
65df8834e8 Bug fixes for gcp_compute_forwarding_rule (#42808) 2018-08-13 12:00:11 -04:00
Mike Wiebe
8f75bb5799 nxos issu should abort when issu is not possible. (#43793)
* Use expect module to copy files

* Abort when issu not possible

* Update copy_kick_system_images.yaml

* Update platform/version support
2018-08-13 20:36:42 +05:30
Yanis Guenane
fd554e9d75 vultr.py: query_resource_by_key Handle list and dict (#43301)
The Vultr API is inconsistent in the type of the value it returns
based on the resources. While most of the time it will be a dict, for
some resources it will be a list (/v1/user/list, /v1/block/list).

query_resource_by_key() fails if the return value isn't a dict (.items()
does not exist on list). This patch aims to support both list and dict.
2018-08-13 16:59:27 +02:00
Herman
ed29cd7f44 add choices to documentaton for paramater flat (#43939) 2018-08-13 10:57:00 -04:00
Alex Stephen
d1399ec5a2 Bug fixes for gcp_compute_backend_service (#42805) 2018-08-13 10:55:21 -04:00
Alex Stephen
476e98e0cf Bug fixes for gcp_compute_backend_bucket (#42804) 2018-08-13 10:54:56 -04:00
Alex Stephen
4ecdf11aaa Bug fixes for gcp_compute_address (#42704) 2018-08-13 10:50:04 -04:00
Jonny McCullagh
aac668ee1f Update wait_for.py (#44071)
Removed the 'wait 300 seconds' from the examples that did not have the 300 sec timeout

+label: docsite_pr
2018-08-13 10:48:21 -04:00
Nathaniel Case
a3385a60b4
httpapi: let httpapi plugin handle HTTPErrors other than 401 (#43436)
* Hold httpapi response in BytesIO

* Let httpapi plugin deal with HTTP codes if it wants

* Python 3.5 won't json.loads() bytes

* Don't modify headers passed to send

* Move code handling back to send()

but let httpapi plugin have a say on how it happens
2018-08-13 10:25:06 -04:00
Toshio Kuratomi
e2e44f846c Fix the local and ssh plugins for a cornercase retrying a syscall
The bundled selectors library which is used by the local and ssh
connection plugins had a bug which caused a traceback in a cornercase.
If selectors were in use and a syscall was interrupted, selectors would
attempt to restart the syscall after the interrupt was processed.  if
the attempt determined that the timeout for running the syscall had
already expired, the code attempted to raise OSError.  The raise was
using a Python3-ism and needed to be ported to work on Python2.

Fixes #41630
2018-08-13 07:17:11 -07:00
René Moser
1fb0e11b56
vultr: rename prefix vr_to vultr_ (#43994)
* vultr: rename modules

* replace string vr_ with vultr_

* add deprecation warning

* fix sanity tests

* add changelog
2018-08-13 10:21:50 +02:00
Ganesh Nalawade
24d112fc60
Fix cli_command junos test failure and update doc (#44021)
* Fix cli_command junos test failure and update doc

*  Fix cli_command module integration test failure
   for junos
*  Update cli_command module doc for prompt and
   config command run scenario's

* Update cli_command module doc
2018-08-13 11:02:43 +05:30
Tim Rupp
0beae82f56
Add no-change handlers and fix utf8 (#44020)
the bigip_command module was not handling utf-8 appropriately. Also,
this patch includes some enhancements for no-change detection
2018-08-12 21:44:49 -07:00
Tim Rupp
0d332dd095
Adds fixes and features to bigip_virtual_server (#44019)
Merging in downstream work from the f5-ansible repository.
2018-08-12 20:46:08 -07:00
Felix Fontein
aef16ee195 ACME: use Cryptography (if a new enough version is available) instead of OpenSSL (#42170)
* Collecting PEM -> DER conversions.

* Using cryptography instead of OpenSSL binary in some situations.

* Moving key-to-disk writing for key content to parse_account_key.

* Rename parse_account_key -> parse_key.

* Move OpenSSL specific code for key parsing and request signing into global functions.

* Also using cryptography for key parsing and request signing.

* Remove assert statements.

* Fixing handling of key contents for cryptography code path.

* Allow to disable the use of cryptography.

* Updating documentation.

* 1.5 seems to work as well (earlier versions don't have EC sign function). Making Python 2.x adjustments.

* Changing option to select_crypto_backend.

* Python 2.6 compatibility.

* Trying to test both backends separately for acme_account.

* Also testing both backends separately for acme_certificate and acme_certificate_revoke.

* Adding changelog entry which informs about select_crypto_backend option in case autodetect fails.

* Fixing YAML.
2018-08-12 19:12:01 +02:00
Felix Fontein
7f41f0168a ACME certificate revocation: add support for new draft-14 error message (#43980)
* Adding support for new certificate-already-revoked error message in draft-14.

* Updating documentation.

* Fixing typo.
2018-08-12 04:29:48 -04:00
Adam Miller
231961564a fix firwewalld permanent zone operations (#42868)
Fixes #42310

Previously, the firewalld module was making a call to
FirewallClientConfig.getZoneNames() which doesn't exist in versions
of firwalld older than 0.4.2, this patch implements the same logic
with older API calls to not require a newer version of firewalld.

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-12 03:08:05 -04:00
Yanis Guenane
ffcdc53536 module_utils/vultr.py: Ensure comparison is accurate (#43298)
In query_resource_by_key(), there is an equal comparison that is made to
know if the object we are looking for is present. Due to type difference
this comparison doesn't always retrieve true, even when it should.

This is due to the fact that the value in r_data dict are of type
unicode, while the other can be of type int, float,... .

```
>>> a = u'1'
>>> type(a)
<type 'unicode'>
>>> b = 1
>>> type(b)
<type 'int'>
>>> a == b
False
>>> str(a) == str(b)
True
```

Hence the values, for comparison purposes, are casted into strings.
2018-08-11 04:48:44 -04:00
Luca Lorenzetto
051320a5f5 docs: Fixed wrong storage platform on module docs for EMC VNX (#43899) 2018-08-11 09:29:34 +02:00
René Moser
041fcb2435
cs_pod: workaround for 4.11 API break (#43944) 2018-08-11 09:22:14 +02:00
Andrew Gaffney
c1f41ee607 Display correct task title with strategy 'free' (fixes #43950) 2018-08-10 23:39:44 -07:00
Nathaniel Case
1bb4d232f3 replace errant use of 'response' with 'answer' (#43985) 2018-08-10 14:37:22 -07:00
Jasper Aorangi
42257706b6 Add enable_ip_forwarding option to azure_rm_networkinterface; Fixes #43276 (#43335)
* Merge again trickily similar Accelerated networking and IP forwarding

* Add type to enable_ip_forwarding documentation

* Fix merge error

* auth to auto

* azure_rm_networkinterface: remove auth_source from tests

* azure_rm_networkinterface: remove spurious auth_source from test

* azure_rm_networkinterface: Revert formatting on test

* azure_rm_networkinterface: Correct indentation
2018-08-10 14:14:48 -07:00
Lindsay Hill
5981a7489b new nos_command module (#43056) 2018-08-10 13:50:02 -07:00
Toshio Kuratomi
5ba41a9575 Remove call to parse_returned_data when removing tmpdir
_parsed_return_data should only be used with the return from a module.
This location was invoking a remote shell command rather than a module
so we don't want it here.
2018-08-10 12:18:11 -07:00
Brian Coca
abe68d523c
fix alt linux detection for new versions (#43723)
they dropped the Linux so now it only shows as ALT, it should still be backwards compatible
pkg_mgr detection relies on `Altlinux` string, so properly setting os_distribution should take care of it as side effect
fixes #43539
2018-08-10 15:16:33 -04:00
Alexey Sheplyakov
37361d9b0b pkg_mgr: fixed apt_rpm detection (#43769)
Instead of checking the distribution name (which apparently is tricky to find out)
check if /usr/bin/apt-get is managed by RPM.

Fixes #43539
2018-08-10 15:16:15 -04:00
Brian Coca
9be3a7dde5
handle env exception in gathering even no inject (#43569)
* handle env exception in gathering even no inject

(cherry picked from commit 60e3b9b3527daea6d9fb75a80cc14b35923748f3)
2018-08-10 15:11:20 -04:00
Chris Archibald
479408330e Adding Common files for NetApp ElementSW release (#43727)
* MVP2 Post ElementSW OSRB sync

* Revert "MVP2 Post ElementSW OSRB sync"

This reverts commit c13db2ad962cd56bffce052c2891c558a2240c72.
2018-08-10 09:33:08 -07:00
ssemyonov
7a4517a067 Introduce force and verbose options in serverless module (#43947)
* Introduce `force` and `verbose` options in serverless module

* Add "version_added: 2.7" for the new `force` and `verbose` options
2018-08-10 12:30:36 -04:00
Matt Martz
c1c229c6d4
Remove use of simplejson throughout code base (#43548)
* Remove use of simplejson throughout code base. Fixes #42761

* Address failing tests

* Remove simplejson from contrib and other outlying files

* Add changelog fragment for simplejson removal
2018-08-10 11:13:29 -05:00
Trishna Guha
96346938ee
nxos_vlan refactor to support non structured output (#43805)
* nxos_vlan refactor to support non structured output

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* unittest fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* minor fixes

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* use check_rc

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* address review comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* remove additional return statement

* address Nate's review

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-08-10 21:03:56 +05:30
Nathaniel Case
f221105882
Prevent data being truncated over persistent connection socket (#43885)
* Change how data is sent to the persistent connection socket.

We can't rely on readline(), so send the size of the data first. We can
then read that many bytes from the stream on the recieving end.

* Set pty to noncanonical mode before sending

* Now that we send data length, we don't need a sentinel anymore

* Copy socket changes to persistent, too

* Use os.write instead of fdopen()ing and using that.

* Follow pickle with sha1sum of pickle

* Swap order of vars and init being passed to ansible-connection
2018-08-10 09:26:58 -04:00
Ganesh Nalawade
d1de1e0449
Update iosxr cliconf plugin (#43837)
* Update iosxr cliconf plugin

Fixes #39056

*  Update iosxr cliconf plugin
*  Modify iosxr module_utils code to support
   refactored cliconf plugin api's
*  Other minor changes

* Fix unit test failure

* Update ios, eos, nxos plugin for diff

* Fix review comment
2018-08-10 13:12:51 +05:30
Jordan Borean
7b1cc11685
win_domain modules: ensure Netlogon service is still running after promotion (#43703) 2018-08-10 16:17:45 +10:00
Deepak Agrawal
8eaebf86b6
openvswitch_db : Handle column value conversion and idempotency in no_key case (#43869)
* change column value to string. handle idempotency in no key case

* fix unit test failures in baseline
2018-08-10 10:31:03 +05:30
Dag Wieers
2974df9d5e
Fix typo 2018-08-10 01:34:23 +02:00
Ryan Brown
b9df8564a2 Fix spelling of ansbile to ansible (#43898) 2018-08-09 18:32:42 -04:00
Luca Lorenzetto
cdb5140ade New module for managing EMC VNX Block storage (#42945)
* New module for managing EMC VNX Block storage

With the module emc_vnx_sg_member users can add or remove luns from
existing storage groups.

This module has been developed in couple with emc_vnx_mv_promote for
disaster recovery process automation, but can be used by itself.
2018-08-09 10:38:26 -07:00
mbusbee
b851321b65 VMware: datastore selection (#35812)
This fix adds additional parameter 'datastore'. This parameter
provides a flexibility to specify custom datastore or datastore cluster
to deploy new virtual machine from template (which is located in different
datastore or datastore cluster from virtual machine's datastore or datastore
cluster).

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-09 22:50:46 +05:30
Nathaniel Case
0f554f9208
Remove unnecessary features from cli_command (#43829)
* Remove wait_for & associated params

* Upgrade command dict to top-level, remove more wait_for accessories

* We don't need all this anymore

* Update docs

* Update tests to new argspec

* Be a little more explicit about sendonly

Also remove reference to the word provider.

* Add example of prompt and answer
2018-08-09 12:46:38 -04:00
Pilou
32eab149b6 [doc] import_role: mention version from which behavior changed and fix some typos (#43843)
* [doc] fix some typos

* [doc] import_role: mention version from which behavior changed
2018-08-09 09:00:59 -05:00
Nilashish Chakraborty
59cd693218
Add source interface and use-vrf features (#43418) 2018-08-09 18:36:54 +05:30
Abhijeet Kasurde
bc84f69ae0
Fix unreferenced msg from vmware_host (#43872)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-09 15:44:50 +05:30
Trishna Guha
55f8b9fa71
set supports_generate_diff to False vyos (#43873)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-08-09 15:37:08 +05:30
Alex Bush
d1d08304f9 azure_rm_loadbalancer_facts.py: list() takes at least 2 arguments fix (#29046) (#29050) 2018-08-09 15:07:38 +08:00
Antoine Cotten
6741e98c04 azure_rm_deployment: collect tags from existing Resource Group (#26104) 2018-08-09 15:04:30 +08:00
Abhijeet Kasurde
e364d717cb
VMware: remove unused imports (#43804)
Idea taken from https://github.com/ansible/ansible/pull/43402

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-09 10:34:55 +05:30
Dag Wieers
ddf3ba01d2
aci_fabric_node: Fix idempotency (with newer ACI ?) (#43848) 2018-08-09 02:27:22 +02:00
Dag Wieers
02b5057392
Support dash-separated leaf IDs (as documented) (#43846) 2018-08-09 02:27:03 +02:00
akira6592
8662e87b1a Corrects module name in net_get module doc (#43816) 2018-08-08 16:14:33 -07:00
curry9999
2d79589515 To improve readability, we added a line feed. (#43801)
* 	modified:   google/gcp_compute_backend_bucket.py
	modified:   google/gcp_compute_backend_service.py
	modified:   google/gcp_compute_forwarding_rule.py
	modified:   google/gcp_compute_global_forwarding_rule.py
	modified:   google/gcp_compute_image.py
	modified:   google/gcp_compute_instance.py
	modified:   google/gcp_compute_instance_group.py
	modified:   google/gcp_compute_instance_group_manager.py
	modified:   google/gcp_compute_instance_template.py
	modified:   google/gcp_compute_route.py
	modified:   google/gcp_compute_subnetwork.py
	modified:   google/gcp_compute_target_http_proxy.py
	modified:   google/gcp_compute_target_https_proxy.py
	modified:   google/gcp_compute_target_ssl_proxy.py
	modified:   google/gcp_compute_target_tcp_proxy.py
	modified:   google/gcp_compute_url_map.py
	modified:   google/gcp_container_node_pool.py
	modified:   google/gcp_dns_resource_record_set.py
	modified:   google/gcp_pubsub_subscription.py
	modified:   google/gcp_storage_bucket_access_control.py

* 	modified:   lib/ansible/modules/cloud/amazon/aws_ses_identity.py
	modified:   lib/ansible/modules/cloud/amazon/route53_facts.py
	modified:   lib/ansible/modules/cloud/cloudscale/cloudscale_server.py
	modified:   lib/ansible/modules/network/aos/_aos_logical_device.py
	modified:   lib/ansible/modules/network/aos/_aos_rack_type.py
	modified:   lib/ansible/modules/network/aos/_aos_template.py
	modified:   lib/ansible/modules/network/cumulus/nclu.py
	modified:   lib/ansible/modules/web_infrastructure/ansible_tower/tower_job_launch.py
	modified:   lib/ansible/modules/web_infrastructure/ansible_tower/tower_job_wait.py
2018-08-08 16:10:26 -07:00
Dag Wieers
014fca8ca5
Fix all ACI examples to use delegate_to (#43439)
This is to avoid users connecting to the APIC using SSH, which is likely
to fail. In the ACI documentation (linked from every module) we go into
more details on how people are supposed to work with the modules..
2018-08-08 23:24:50 +02:00
Nathaniel Case
35f625ee3b
Network *_config action plugin updates (#43838)
* Compatibility fixes for ${network_os}_config action plugins
2018-08-08 15:15:08 -04:00
Anil Kumar Muraleedharan
ceb49bdf12 Lenovo size reduce cnos.py of util (#43823)
* Changing Lenovo Inc to Lenovo and update License file to be consistent.

* Moving code in util file to module file. This is done as per a review comment

* Update cnos_vlag.py

* Update cnos_vlan.py

* Update enos_config.py
2018-08-08 14:24:39 -04:00
Feilong Wang
23adc436fd Add OpenStack Magnum cluster template module (#42654) 2018-08-08 13:55:51 -04:00
Matt Clay
1f40718a26 Fix PEP 8 issue in exos_facts. 2018-08-08 08:49:31 -07:00
Lingxian Kong
84a1decaf0 Add os_listener module for OpenStack Octavia (#42604) 2018-08-08 11:22:06 -04:00
Lingxian Kong
018a8eb8ee Add os_loadbalancer module for OpenStack Octavia service (#42552) 2018-08-08 11:21:44 -04:00
Lance Richardson
bd4d68c785 network/exos: add exos_facts module (#43210)
Add exos_facts module. Known limitations at this time include:
   - Interface MTU is not reported.
   - Only primary interface IP is reported.

Add basic unit tests for the exos_facts module.

An EXOS CLI prompt can be prefixed with '! ' (shutting down), '* '
(running configuration does not match saved configuration), and
can include various status tokens within parentheses after these
prefixes. Update prompt regex to accept valid CLI prompts.
2018-08-08 16:02:18 +02:00
sward1557
e24c036057 Added junos_config note about override set format (#43608) 2018-08-08 15:58:28 +02:00
Lindsay Hill
8429f777da New networking module: voss_command (#43741)
* new voss_command module

* Removed incorrect version_added line
2018-08-08 15:56:50 +02:00
Andreas Calminder
3419c75411 make lockfile destination settable and update doc (#42795)
* make sure lock file is available for others when unlocking

* add tmpdir option and updated documentation
2018-08-08 06:52:11 -07:00
Abhijeet Kasurde
1366a694f9
VMware: Update example (#43786)
* Unified examples in all modules
* validate_certs is now 'no' instead of 'False'
* delegate_to changes

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-08 17:14:27 +05:30
Ganesh Nalawade
4618583f2f
Update eos clcionf plugin (#43809)
* If the remote host supports session
  capability set the `supports_generate_diff`
  flag to false which identifies if config diff should
  be generated within module or not
2018-08-08 15:11:25 +05:30
Yuwei Zhou
6dce96e1d0 refine aks document (#43810) 2018-08-08 15:51:23 +08:00
Trishna Guha
5f8654e5bd
revert #43546 nxos terminal plugin (#43806)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-08-08 10:47:56 +05:30
Yuwei Zhou
88a738b0ba Fix nsg cannot add rule with purge_rules false (#43699) 2018-08-08 11:41:46 +08:00
Yunge Zhu
5088f7c926 add azure_rm_appserviceplan module (#40906)
* add azure_rm_appserviceplan module

* fix lint in test

* fix lint

* fix test

* fix test syntax

* resolve comments

* fix test
2018-08-07 15:54:31 -07:00
Yunge Zhu
97942cf049 add azure_rm_webapp (#40005)
* add azure_rm_webapp

* fix lint error

* resolve comments

* fix lint

* fix lint

* fix lint

* fix lint

* fix test failure

* fix test

* fix test

* fix test

* refine ux

* resolve comments

* fix lint and test

* fix lint

* code cleanup

* combine windows_frameworks/linux_framework to one

* fix lint in doc

* fix l int

* fix lint

* fix bug

* fix bug

* fix bug

* fix bug

* fix syntax error

* fix lint error

* fix bug of wrong indent

* fix test issue

* update java framework parameter

* fix lint error

* resolve comments

* fix lint

* resolve comments

* fix bug

* update test

* fix lint

* fix test
2018-08-07 15:53:15 -07:00
Dag Wieers
d8ba8c03f3
ACI: Make querying links and nodes possible (#43441)
This functionality was not considered when the module was written, but
there's no reason why it shouldn't be supported.

We had to rework the query string construction and object filtering.
This new functionality allows to filter on arbitrary keys and supports
None values.

This PR fixes various issues with the existing framework, including
querying specific objects using construct_url_4 (i.e.
aci_epg_to_contract and aci_static_binding_to_epg)
2018-08-07 23:54:54 +02:00
curry9999
529cd19ca5 I changed the document of win_hostname.py. (#43761)
* Host name is contrary to naming convention

<!--- Your description here -->

+label: docsite_pr

* removed yaml separators
2018-08-08 06:30:46 +10:00
curry9999
9c4be54625 To improve readability, we added a line feed. (#43764)
* A line break was added.

<!--- Your description here -->

+label: docsite_pr

* "blank line contains whitespace" was fixed.
2018-08-07 16:07:35 -04:00
Willian Ricardo
29f2bf651e [aws] Allow CloudWatch Log Group retention to be changed when log group exists (#43752)
* fix bugs #42028 and #43735
2018-08-07 16:06:06 -04:00
curry9999
d7009abee4 [docs] required arguments: name (#43758)
<!--- Your description here -->

+label: docsite_pr
2018-08-07 15:49:52 -04:00
Jerry Elmore
f5cd6d2821 Corrected spelling of 'formatted' (#43785) 2018-08-07 15:49:04 -04:00
Abhijeet Kasurde
ce7eecd782 Misc typo fixes in function docs (#43779)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-07 20:13:51 +02:00
Yanis Guenane
68e6587748 Vultr: Ensure facts works when no resource exists (#43603)
Vultr API is being inconsisten in what it returns. An empty list when no
resources exists, but a dict of dict when they do. The case needs to be
handled so the module do not fail. An extra test has been added.
2018-08-07 20:12:36 +02:00
Arnaud Venturi
130824c3e1 Correct a typo in pip module error message (#43784) 2018-08-07 19:53:19 +02:00
AlexisLessard
3055ca2cc0 Clarifications of parameters in yum_repo module (#38453)
* Clarifications of parameters in yum_repo module

Added a note defining where the "name" parameter of the module will appear in the repo file and note explaining that the description parameter of the module is actually the name parameter in the repo file. It might help people transform their existing yum repository files in ansible managed repos.
2018-08-07 11:48:29 -05:00
Abhijeet Kasurde
5936e1f449
VMware: confine search for network till datacenter level (#40382)
If there are multiple distributed virtual portgroup network with same name
in different datacenter, vmware_guest module used to choose first DVPG irrespective
of the datacenter. This caused problem if two datacenter has same name for DVPG,
vmware_guest module failed with error "The object or item referred to could not be found."

This fix adds check to search for network (Distributed Virtual Portgroup)
till datacenter level. This avoids selection of same name DVPG from other datacenter.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-07 22:10:10 +05:30
Abhijeet Kasurde
3dcbf3b003
VMware: new module : vmware_guest_boot_facts (#43240)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-07 22:08:37 +05:30
Abhijeet Kasurde
281c8f6861
VMware: added missing facts vmware_drs_rule_facts (#42992)
vmware_drs_rule_facts was missing details about vm_group and host_group
and their respective memeber names. This fix adds those details and updates documentation.

Fixes: #42980

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-07 22:07:39 +05:30
Will Thames
c8e8a84210 Allow tower_inventory_sources params to be False (#43749)
Ensure that params set to False are respected, rather than ignored.
2018-08-07 07:19:15 -04:00
Felix Fontein
7b7709ae75 ACME: support for TLS-ALPN-01 (#42158)
* Added support for TLS-ALPN-01 verification.

* Unrelated commit to re-trigger tests.

* Added test for TLS-ALPN-01.

* Try to remove to_bytes in the hope that binary data survives in Python 2.

* Using Base64 encoding for TLS-ALPN-01 value.
2018-08-07 08:52:22 +02:00
David Wittman
a24898b715 Add cap_drop to docker_container module (#36889)
Closes #29578
2018-08-07 12:11:52 +05:30
Andrew Gaffney
9f9e936d3c Force all args to strings for 'command' (fixes #43732) 2018-08-06 14:27:45 -07:00
Branko Majic
2f5e3a75a3 Fix introduction version for parameter "local" in module "group" (#43719)
Parameter "local" has been introduced to the "group" module in version 2.6, not 2.5.
2018-08-06 11:40:19 -04:00
Nathaniel Case
ab39481c31
cli_command module (#42916)
* Create cli_command module to do direct cliconf calls

* Update edgeos cliconf signature to match.

* cli_command is cli-only

* Add tests
2018-08-06 10:41:57 -04:00
Simone Tiraboschi
086cb0233f ovirt: ovirt_hosts_facts: add all_content (#43525)
Add all_content parameter also to ovirt_hosts_facts
to fetch the complete list of of details.
2018-08-06 08:58:57 -04:00
Gustavo Muniz do Carmo
d971dd23a4 ldap_entry bugfix (#43620) 2018-08-06 15:01:08 +05:30
Abhijeet Kasurde
741fa025a0
delegate_to: accept only string for delegation host (#43473)
delegate_to parameter in task only accepts string,
this fix will error out if other datatypes are provided instead of
string.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-08-06 11:40:12 +05:30
rmudingay
7feef1b64b junos_user: additonal sshkey types added (#43685) 2018-08-06 10:20:27 +05:30
Lindsay Hill
c325fd9a46 Typo in edit_banner (#43668)
Looks like `send_commad` was mistakenly added in https://github.com/ansible/ansible/pull/43203. Should be `send_command`
2018-08-06 10:12:26 +05:30
Ganesh Nalawade
35adc12c38
Update junos cliconf plugin (#43643)
* Update junos cliconf plugin

Fixes #39056

Refactor junos cliconf plugin api and other
minor changes

* Fix CI issue

* Fix CI failure
2018-08-06 10:08:05 +05:30
Kevin Breit
3750c3a4d9 Meraki/doc response vlan (#43669)
* Add proper response documentation to meraki_vlan

* Add fixed IP assignemnts and reserved IP range response docs

* Fix syntax error

* Remove duplicate reservedIpRanges documentation
2018-08-06 01:52:16 +02:00
Jordan Borean
22b921d47f
win-async: fix race condition in async run (#43691) 2018-08-06 09:21:53 +10:00
Aurélien Grimal
71952a0aad Fix bug #32437 (#38166) 2018-08-05 17:49:11 -04:00
Jordan Borean
8f8e3db067
win_chocolatey: fix regression around using all as a package name (#43483) 2018-08-06 07:33:55 +10:00
Simon Dodsley
e576acf6e4 Add support for host personality in purefa_host module. (#42976)
This is recommended when ActiveCluster is supported in the FlashArray
2018-08-03 22:48:49 -07:00
Simon Dodsley
3a7b6efea8 Update Pure Storage FA pgsnap module to allow volume restore from snap (#42774) 2018-08-03 22:47:54 -07:00
Matt Martz
4094b017c0
Fix invocation output. Fixes #43447 (#43542) 2018-08-03 12:40:34 -05:00
Toshio Kuratomi
30662bedad
Only print warning when ansible.cfg is actually skipped (#43583)
Only print warning when ansible.cfg is actually skipped

* Also add unittests for the find_ini_config_file function
* Add documentation on world writable current working directory
  config files can no longer be loaded from a world writable current
  working directory but the end user is allowed to specify that
  explicitly.  Give appropriate warnings and information on how.

Fixes #42388
2018-08-03 10:39:33 -07:00
Rémi REY
48280463f2 modules/terraform: fix -no-color position in workspace command (#43644) 2018-08-03 13:14:14 -04:00
Nicolas Finné
d8bdf38b50 Fix telnet action plugin type error (#43609)
* Fix telnet action plugin type error

* removed blank line too much (pep8 E303)
2018-08-03 09:50:14 -04:00
Nilashish Chakraborty
4a1d37a76b Fix argument error in DCI (#43634) 2018-08-03 19:02:26 +05:30
Anil Kumar Muraleedharan
119376a685 Refactoring to persistence connection BGP, factory, reload, save, showrun modules (#43534)
* Refactoring to persistence connection BGP, factory, reload, save, showrun modules

* Refactoring methods from Util to module file

* Removing BGP Utility methods

* Adding to errors that need to be ignored
2018-08-03 08:40:24 -04:00
Rémi REY
32c01644d4 modules/terraform: use -no-color option in workspace commands (#43628) 2018-08-03 08:24:57 -04:00
Michael Dodwell
5130b67159 Allow for the specification of a rhsm_repo_ca_cert if changing baseurl (#43343)
* Allow for the specification of a rhsm_repo_ca_cert if changing baseurl

If changing the baseurl we should allow for a ca cert to be updated from redhat-uep.pem

* Fixing documentation section

* added version to option rhsm_repo_ca_cert

* got rid of extra CR
2018-08-03 07:48:40 -04:00
Pierre-Louis Bonicoli
93a4269957 filesystem: use LANG=C when cmd output is parsed 2018-08-03 11:57:22 +02:00
Pierre-Louis Bonicoli
f6f413ec7a filesystem: add support for f2fs
Closes: #40418
2018-08-03 11:57:22 +02:00
saichint
e393d5d2b4 add local directory option to nxos_file_copy (#43277)
* add local directory option to file_copy pull

*  shippable fix
2018-08-03 10:33:06 +05:30
hi117
7ea909418e Add scope parameter to systemd (#40179)
* Added changes for Issue #38828, adds scope paramater to systemd module

* Removed description for old paramater

* Added version_added field for new option

* Readded the user paramater as a deprecated paramater

* Changed version for the scope paramater since I missed the release window
2018-08-02 19:05:20 -04:00
Aaron Haaf
8a56aa322e Implement signed_request for sigV4 requests (#42758)
* Implement signed_request for sigV4 requests

* Correct linting errors

* More linting changes. Correct import.

* Final linting fix for inline comments

* Correct import of urllib.parse

* Update copyright and shebang line

* Remove shebang

* Put boto3 requirement. Abtract out get_aws_key_pair for module consumption.

* Dummy out unused region variable.

* Handle Boto3 ImportError

* - implement get_aws_credentials_object with willthames suggestion
- Handle session_token

* Make quote style consistant

* Chop arugment line up

* Correct indent
2018-08-03 08:31:10 +10:00
Brian Coca
522c245ee7 added version info and removed 'bare' exception 2018-08-02 18:19:43 -04:00
Vianney Foucault
5385de4bfd Support for postgresql default privileges (#32987)
* Support for postgresql default privileges

fix the following issues:

* #29701
* #23657

* The ALTER DEFAULT PRIVILEGES is implemented with type 'default_privs'
* Added a Query Builder for simplification
* Some minor lint

* Fixed Lint Issue in doc

Fixed misspelled method name

* Removed the damned empty space on line 243 ! (within the doc) x|

* Kept Compat in string interpolation for old beloved python 2.6
2018-08-02 18:15:33 -04:00
Zhikang Zhang
3a3869f4c8
Clarify usage of encrypt arg (#43330)
According to the do_encrypt interface, encrypt arg should be the hash method name used for encrypting returning password. But in the doc and lookup code it's a boolean flag, correct it to string.
2018-08-02 14:03:49 -04:00
Brian Coca
62d8c8fde6 more useful messages when module failure (#43576)
* more useful messages when module failure

specially if the 'interpreter' is not found

* 1 less var

* shebang can be none

* remove typoes
2018-08-02 13:30:57 -04:00
Sebastian Wiesinger
a5774bd29a Fix ini variables for netconf and network_cli connections (#43599) 2018-08-02 21:08:51 +05:30
Pilou
12973e0541 Tower modules: move HAS_TOWER_CLI check in module_utils and minor improvements (#39809)
* tower_* modules: move HAS_TOWER_CLI in TowerModule

Besides this change allows to define other common parameters such as
mutually_exclusive.

* tower_*: config file can not be used with auth params

* tower module_utils: remove useless call to expanduser

'path' type: expanduser & expandvars are automatically called
2018-08-02 11:17:39 -04:00
David Moreau Simard
934500fb05 Properly detect credentials for tower_project
It seemed like it was mostly the wrong variables been looked at, making
it so a git repository could not be created without a credential.
2018-08-02 11:17:04 -04:00
Rémi REY
0461620b2d Terraform: add workspace support for switching and removing workspaces (#43489)
From terraform documentation:
```
The persistent data stored in the backend belongs to a workspace. Initially the backend has only one workspace, called "default", and thus there is only one Terraform state associated with that configuration.

Certain backends support multiple named workspaces, allowing multiple states to be associated with a single configuration. The configuration still has only one backend, but multiple distinct instances of that configuration to be deployed without configuring a new backend or changing authentication credentials.
```

This patch introduces the `workspace` parameter in the terraform module. The module will select
the workspace is it does not exists, or simply select it if it exists.

Fixes #43134

Add 'purge_workspace' parameter and handle the workspace context

The `purge_workspace` parameter allows to remove a workspace when asking for state = absent.
It allows to leave a clean state file without empty workspaces if the parameter is true.

Also adding the support of a workspace context that allows to restore the workspace
when that was active when the module started.
2018-08-02 09:37:26 -04:00
Trishna Guha
09ae1ec308
cliconf refactor eos, nxos fix (#43596)
* cliconf refactor eos and nxos fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* move nxos replace check to plugins

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* address review comment

* fix shippable
2018-08-02 16:34:48 +05:30
Petr Ruzicka
4e4ae1508e Removing required from documentaion of name parameter (#43530)
* Removing required from documentaion of name parameter

* extra text to make clearer when name is required
2018-08-02 17:37:14 +10:00
Timo Sand
3a4b6b1d12 Adds example of using wildcard domain in pam_limits (#43391)
* Adds example of using wildcard domain

* Fixes W293

* Slight formatting changes on the examples
2018-08-02 17:23:46 +10:00
♫ Christian Krause ♫
54e1bca62a improves pam_limits documentation (#43526)
- the man page is actually limits.conf
- uses code highlighting for these
2018-08-02 17:13:24 +10:00
mjmayer
4549962f85 Fix comparison of priority (#43329)
The existing rule priority comes from aws as a string. It is then
compared to the new rule priority, which is defined as an int. This change
casts the new rule priority as a string making the comparison work. The
reason to cast it as a string rather than an int is used because a priority
can also be set to 'default'. When trying to case 'default' as an int, it creates
an error.
2018-08-02 17:05:20 +10:00
Zim Kalinowski
9e5e35e64c Replaced old sample in lb (#43591) 2018-08-02 15:02:44 +08:00
Ganesh Nalawade
3f3101dfe5
Raise exception if command timeout is triggered (#43078)
* Raise exception if command timeout is triggered

Fixes #43076

If persistent connection timeout is triggered, riase
exception which will be send over socket to module code
instead of silently shutting down the socket.

* Fix CI failure

* Fix review comment

* Fix CI failure

* Fix review comment

* Fix review comment
2018-08-02 12:08:37 +05:30
Zim Kalinowski
b771913c0d improved vmss documentation (#43590) 2018-08-02 14:11:10 +08:00
Ganesh Nalawade
b0bd1651fa
Fix netconf plugin set_option (#43589)
* To enable set config option with `Netconf` plugin
  inherit `NetconfBase` class from `AnsiblePlugin` parent class
2018-08-02 11:31:17 +05:30
Ganesh Nalawade
733e512f35
Fix typo in cliconf get_config (#43553) 2018-08-02 09:44:30 +05:30
Bill Nottingham
572a2187ab Add some requirements to the plugin docstrings. 2018-08-02 00:10:48 -04:00
Toshio Kuratomi
734384b91d Fix config manager to show errors
If there were fatal bugs in this portion of config, they would never be displayed
because config would fail to load and then every^U (Exageration... only
half of every) other part of the code which depended on config to be
loaded would fail before we ever got around to a section of code that
would process UNABLE.

Remove the try except from here so that we are able to debug this code
2018-08-01 19:42:35 -07:00
Toshio Kuratomi
d483d646eb Normalize config from environment as text strings
On Python3, these would be text strings already.  On Python2, we need to
convert them from bytes.

Use a new helper function py3compat to do this.

Fixes #43207
2018-08-01 19:42:35 -07:00
Robert Bo Davis
a452a92199 Fix referenced before assignment in role requirements 2018-08-01 16:48:49 -04:00
Robert Bo Davis
298d73a1a7 Fix referenced before assignment in role requirements 2018-08-01 16:48:49 -04:00
Joren Vrancken
7c13c4b207 Add specific exceptions to except 2018-08-01 16:42:05 -04:00
Jackson Isaac
f968fcd288 junos_vlan: Add Vlan ID Range in description (#41855) 2018-08-01 15:41:22 -04:00
vista-
f81e258043 NCLU - Add example: Changing the hostname and committing on Cumulus Linux (#42872)
* Add example to change the hostname and commit on Cumulus Linux

* Modify phrasing a bit
2018-08-01 15:32:57 -04:00
Brian Coca
2e9a7e2564 remove deprecated 2018-08-01 15:17:28 -04:00
Brian Coca
21fc6a0c38 nicer error message on multiprocessing fail
fixes #43090
2018-08-01 15:14:23 -04:00
Shuang Wang
68683b4c73 fix issue [ get_url does not change mode when checksum matches ] (#43342)
* fix  #29614

* add change log for #43342

* Cleanup tests and add tests for this scenario


Co-authored-by: ptux
2018-08-01 15:02:27 -04:00
Christer Hemgren
d3fb958a06 asa_config doc attach acl to interface (#41253)
+label: docsite_pr
Issue ansible/community#311
2018-08-01 11:43:20 -04:00
Trishna Guha
1f410cc19f
Fail module if configure replace fails nxos (#43546)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-08-01 20:30:39 +05:30
joren485
6d680d8281 Use socket.error instead of non-existent socket.Error (#43499) 2018-08-01 10:24:31 -04:00
Nathaniel Case
9169daa326
\r does not round-trip the local socket, escape and restore on the other side (#43507) 2018-08-01 08:44:39 -04:00
Rushan
c4591f0861 Leading dot in efs_facts.mountpoint (#35909)
* remove leading dot in efs_facts mountpoint

* remove leading dot in efs_facts mountpoint

* remove leading dot in efs.py

* introduce filesystem_address var in efs* modules and revert changes to mount_point
2018-08-01 06:32:06 -04:00
Sumit Jaiswal
01fb7ea150
Allow DNS bypass for add/remove of host records with nios_host_record (#42934)
* fixes issue 42420

* fixes issue 42420

* fix shippable docs error

* shippable fix and test case add

* shippable fix and test case add

* shippable fix and test case add

* shippable fix

* removing extra assert

* shippable fix
2018-08-01 10:33:58 +05:30
Dag Wieers
e2cac8cc93 Fix all VMware examples to use delegate_to (#43426)
Some users have problems using the VMware modules because they use the
vCenter as target, and Ansible uses SSH to connect to the targets.

Eventually we need to update the VMware guide to explain how the modules
work, but the first fix is to update the examples.

(We should backport to v2.6 and v2.5 too)
2018-08-01 09:10:57 +05:30
Sumit Jaiswal
e96f90b440
Nios integration and unit tests for all remaining nios new modules (#43399)
* new nios module support

* new nios module support

* new nios module support

* new nios module support

* new nios module support

* new nios module support

* new nios module support

* new nios module integration test support

* new nios module integration test support

* new nios module integration test support

* new nios module integration test support

* new nios module integration test support

* new nios module integration test support

* new nios module integration test support

* new nios module integration test support

* new nios module integration test support

* new nios module integration test support

* new nios module integration test support

* new nios module integration test support

* new nios module integration test support

* new nios module integration test support

* new nios module integration test support

* new nios module integration test support

* new nios module integration test support

* new nios module integration test support

* new nios module integration test support

* new nios module integration test support

* new nios module integration test support

* new nios module integration test support

* new nios module integration test support

* new nios module integration test support

* test/integration/targets/nios_naptr_record/tasks/nios_naptr_record_idempotence.yml

new nios module integration test support

* fix pep8 error

* fix pep8 error

* adding newline at end

* adding newline at end

* adding newline at end

* adding newline at end

* adding newline at end

* adding newline at end

* adding newline at end

* adding newline at end

* adding newline at end

* adding newline at end

* adding newline at end

* adding newline at end

* adding newline at end

* adding newline at end
2018-08-01 08:54:01 +05:30
Yuwei Zhou
7314aa7298 Fixes #30393: Virtual machine can refer existing NIC from other resource group (#42562) 2018-08-01 10:52:21 +08:00
Gustavo Muniz do Carmo
5149ab1e00 New module request: azure_rm_virtualmachine_facts #38081 (#38279)
* New module request: azure_rm_virtualmachine_facts #38081

* New module request: azure_rm_virtualmachine_facts #38081 #38279 pep8 fixes

* New module request: azure_rm_virtualmachine_facts #38081 #38279 validate-modules fixes

* New module request: azure_rm_virtualmachine_facts #38081 #38279 serialize_vm

* New module request: azure_rm_virtualmachine_facts #38081 #38279 get_item

* New module request: azure_rm_virtualmachine_facts #38081 #38279 avoid get vm twice

* New module request: azure_rm_virtualmachine_facts #38081 #38279 some jborean93 requests

* New module request: azure_rm_virtualmachine_facts #38081 #38279 camel_dict_to_snake_dict

* New module request: azure_rm_virtualmachine_facts #38081 #38279 integration test

* New module request: azure_rm_virtualmachine_facts #38081 #38279 virtual network required

* New module request: azure_rm_virtualmachine_facts #38081 #38279 consider additional vms present

* New module request: azure_rm_virtualmachine_facts #38081 #38279 trailing comma

* New module request: azure_rm_virtualmachine_facts #38081 #38279 remove from smoketest

* New module request: azure_rm_virtualmachine_facts #38081 #38279 filtering by tag fix

* New module request: azure_rm_virtualmachine_facts #38081 #38279 virtual network issues fix

* New module request: azure_rm_virtualmachine_facts #38081 #38279 remove trailing comma

* adding curated format for vm

* New module request: azure_rm_virtualmachine_facts #38081 #38279 rights to zim + lint fixes

* clean up

* updates to vm facts

* commented out failing thing

* fixed mistake

* New module request: azure_rm_virtualmachine_facts #38081

* New module request: azure_rm_virtualmachine_facts #38081 #38279 pep8 fixes

* New module request: azure_rm_virtualmachine_facts #38081 #38279 validate-modules fixes

* fixed test

* fixed test problem

* New module request: azure_rm_virtualmachine_facts #38081 #38279 serialize_vm

* New module request: azure_rm_virtualmachine_facts #38081 #38279 get_item

* New module request: azure_rm_virtualmachine_facts #38081 #38279 avoid get vm twice

* New module request: azure_rm_virtualmachine_facts #38081 #38279 some jborean93 requests

* New module request: azure_rm_virtualmachine_facts #38081 #38279 camel_dict_to_snake_dict

* New module request: azure_rm_virtualmachine_facts #38081 #38279 integration test

* New module request: azure_rm_virtualmachine_facts #38081 #38279 virtual network required

* New module request: azure_rm_virtualmachine_facts #38081 #38279 consider additional vms present

* New module request: azure_rm_virtualmachine_facts #38081 #38279 trailing comma

* New module request: azure_rm_virtualmachine_facts #38081 #38279 remove from smoketest

* New module request: azure_rm_virtualmachine_facts #38081 #38279 filtering by tag fix

* New module request: azure_rm_virtualmachine_facts #38081 #38279 virtual network issues fix

* New module request: azure_rm_virtualmachine_facts #38081 #38279 remove trailing comma

* adding curated format for vm

* New module request: azure_rm_virtualmachine_facts #38081 #38279 rights to zim + lint fixes

* clean up

* updates to vm facts

* commented out failing thing

* fixed mistake

* fixed test

* fixed test problem

* ldap_entry 'Tuple_to_LDAPMod(): expected a byte string in the list' issue

* Revert "ldap_entry 'Tuple_to_LDAPMod(): expected a byte string in the list' issue"

This reverts commit efe316c52e5a70fc1aa9f58eff3a9d5b2599763f.

* changed return value

* fixed test

* fixed test mistake

* one space too much

* removed change made by mistake

* virtual machine description

* remove example

* fixed yaml
2018-08-01 10:23:50 +08:00
Jiri Tyr
c93f24b45b Fix for creation and removal of swap record in fstab (fixes #42706, #31437 and #30090) (#42837) 2018-07-31 17:09:38 -04:00
Matt Martz
fd839d7a67
Catch exceptions when importing plugins, and display an appropriate warning. Fixes #43237 (#43501) 2018-07-31 16:00:04 -05:00
Matt Martz
5f98a5a736
Only cache task.loop when delegated_host was templated. Fixes #43016 #43449 (#43451) 2018-07-31 15:58:53 -05:00
Matt Martz
01c0446cb5
Add AnsibleModule signature schema, and fix associated issues (#43512) 2018-07-31 15:04:22 -05:00
Sloane Hertel
25218e6843 Fix dualstack without s3_url (#43510) 2018-07-31 15:50:15 -04:00
Joren Vrancken
9896853d1f Fix typo of makedirs 2018-07-31 15:41:38 -04:00
Joren Vrancken
b954917761 Surround top-level function and class definitions with two blank lines. 2018-07-31 12:06:56 -07:00
Sloane Hertel
4b3e5998bf Allow AWS endpoints and dualstack (#43497) 2018-07-31 15:04:21 -04:00
Matt Martz
dc908f4cb5 Prefer name of include_role. Fixes #43332 2018-07-31 13:25:47 -04:00
Joren Vrancken
d5bec06150 Fix typo of stderr 2018-07-31 13:23:05 -04:00
Brian Coca
222c907ffb
actually check we can run scm command for roles (#43315)
* actually check we can run scm command for roles
* a better error message than file not found
* more narrow exception hanlding
* refactor common functions for more extended use and further 'basic.py' separation
2018-07-31 13:04:05 -04:00
joren485
b3c054c55e Use dbus.exceptions of non-existent dbus.Exceptions (#43495) 2018-07-31 21:56:44 +05:30
Adam Miller
09eac6bab9 Revert "dnf: Call dnf.Base.close() before exit to cleanup. (#41810)"
This reverts commit 32436ea9a5.
2018-07-31 09:17:40 -07:00
Alex
29a62038b7 module_utils_service: Fix glob path of rc.d (#43018)
Some distribtuions like SUSE has the rc%.d directories under /etc/init.d

Quote of /etc/rc.d.README on SLES11.

"Some people expect the system startup scripts in /etc/rc.d/.
We use a slightly different structure for better LSB compliance."
2018-07-31 11:56:11 -04:00
Seuf
af55b8e992 Grafana dashboard grafana 5 compatible (#41249)
* Grafana dashboard module compatible with grafana 5+

* Use url_argument_spec to init modules arguments

* Add changelog fragment
2018-07-31 11:55:18 -04:00
Matt Martz
a7f45c0660 Add basedir to ansible_search_path before running loops. Fixes #43302 (#43431) 2018-07-31 11:51:32 -04:00
Andreas Olsson
726c6eb889 Support Amazon S3 Dual-Stack Endpoints in aws_module (#43403)
* Use https:// for docs.aws.amazon.com in aws_s3 module

* Support Amazon S3 Dual-Stack Endpoints in aws_module

The default S3 endpoint only resolves to IPv4 addresses. By enabling
the dual-stack endpoint IPv6 too get added as an option.
2018-07-31 11:35:33 -04:00
Alex Dukhno
dd28be3aab Update pagerduty modules to rest v2 (#42618)
* refactored from procedural to OOP

* updated ongoing maintenance windows to PagerDuty REST API v2

* update create maintenance windows to PagerDuty REST API v2

* update absent maintenance windows to PagerDuty REST API v2

* update pager alert module to PagerDuty REST API v2

* removed basic HTTP authorization
updated parameter description and examples

* fix failed sanity checks

* revised documentation according to review

* make obsolete service key parameter an alias to a new integration key parameter
2018-07-31 10:39:29 -04:00
Abhijeet Kasurde
122780abce Fix args schema regression in k8s module
Add back comma for required_one_of argument as it's
supposed to be an iterable of iterables.

PR #39787 by @Akasurde
Fixes: #39786

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-07-31 14:44:29 +01:00
Abhijeet Kasurde
c44b05e167
VMware: update documentation and example (#43474)
This fix updates the documenation of vmware_guest_custom_attribute_defs module.

Fixes: #43443

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-07-31 16:11:16 +05:30
Ganesh Nalawade
857200fa7f
Update cliconf get_config api (#43472)
*  Change `filter` parameter to `flag` to be in sync
   with original naming convention
2018-07-31 02:53:29 -07:00
Zim Kalinowski
c8fcbdef71
fix for special case of last element of url (#43354)
* fix for special case of last element of url

* improved version

* fixed mistake

* adding appropriate test

* fix problem

* just fixed task name
2018-07-31 16:31:08 +08:00
curry9999
c344a94846 version_added 2.6 -> 2.7 (#43317) 2018-07-31 10:43:32 +05:30
Ganesh Nalawade
ea6ef3fae8
Enable setting options for cliconf and other implementation plugins (if set to configurable) (#43368)
* Enable setting setting cliconf plugin options

Fixes #43367

* Add support to set configuration options for implementation plugins (eg: cliconf)
  from `ansible-connection`

* Fix CI failure
2018-07-30 21:53:44 -07:00
joren485
d03b9eddf6 Remove unused imports from /bin and lib/ansible/cli (#43440)
* Remove unused imports from lib/ansible/cli

* Remove unused imports from bin/
2018-07-30 18:55:42 -07:00
Jordan Borean
d115794bf7 PrivilegeUtil: use native methods to get pointer offset (#43461) 2018-07-30 18:33:49 -04:00
joren485
240b65ddda Fix an unreachable else statement (#43463) 2018-07-31 08:27:13 +10:00
curry9999
486a43829c change aws_kms example (#43438) 2018-07-31 08:16:17 +10:00
Jordan Borean
9259f31fee Add Ansible.ModuleUtils.PrivilegeUtil and converted code to use it (#43179)
* Add Ansible.ModuleUtils.PrivilegeUtil and converted code to use it

* Changed namespace and class to be a better standard and fixed some typos

* Changes from review

* changes to avoid out of bound mem of server 2008

* changes to detect failure when setting a privileged not allowed
2018-07-30 14:48:54 -07:00
Matt Martz
77d2008150
Don't perform string to bool conversion in set_fact when jinja2 native types is enabled (#43425)
* Don't perform string to bool conversion in set_fact when jinja2 native types is enabled. Fixes #42599

* Add tests for boolean conversions in set_fact
2018-07-30 15:44:38 -05:00
Ryan Brown
43c508b3c3
[AWS] iam_role->AnsibleAWSModule and support IAM permission boundaries (#43270)
* Convert to AnsibleAWSModule and support IAM permission boundaries

* Handle adding boundary to existing role that lacks one

* Properly clean up role boundary associations on delete

* Handle case when policy boundary is `""` but does not exist
2018-07-30 15:06:23 -04:00
Abhijeet Kasurde
80369cf034 VMware: provide appropriate error if NICs missing (#43414)
While creating/reconfiguring vSwitch without NICs check if nics details
are gathered or not.

Fixes: #42619

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-07-30 12:55:19 -04:00
Ryan Brown
1c082e93ef
[aws] Catch errors raised when deleting objects remaining in an s3_bucket (#43358)
* Catch errors raised when deleting objects remaining in a bucket

* Also remove VersionId when it is not needed
2018-07-30 11:22:00 -04:00
Trishna Guha
fee4c24ad4
Add md5sum check in nxos_file_copy module (#43423)
* Add md5sum check in nxos_file_copy module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* address review comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-07-30 20:42:47 +05:30
Abhijeet Kasurde
1bab901966
VMware: add details about vswitch and dvswitch (#43066)
This fix adds additional details of vswitch and dvswitch and their
respective nics used.

Fixes: #43009

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-07-30 11:43:59 +05:30
Orr
1e4831e744 VMware: check if folder already exists before creation (#41588)
* check if folder already exists before creation
* added integration test
2018-07-30 11:11:42 +05:30
Egor Zaitsev
249a6aae22 New module: routeros — manage MikroTik RouterOS (#41155)
* Implement initial RouterOS support

* Correct matchers for license prompts

* Documentation updates & mild refactor

* Remove one last Cisco function

* Sanity test fixes

* Move imports to the beginning

* Remove authorize property

* Handle ANSI codes

* Revert to_lines function

* CR fixes

* test(routeros): add unit tests

* Added another test (with ANSI colors and banner in fixture).

* Ignore CRLF line endings in system_package_print file

* fix: review by ganeshrn
2018-07-30 10:28:03 +05:30
Ganesh Nalawade
21dcaa4349
Handle ConnectionError exception in network modules (#43353)
* Handle ConnectionError exception in network modules

* Catch ConnectionError expection and fail module in case
  expection is raised.

* Fix CI failure
2018-07-30 10:24:58 +05:30
Abhijeet Kasurde
a44adc1dc9 f5: raise exception (#43409)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-07-29 21:10:42 -07:00
Abhijeet Kasurde
cc3dadf16e
VMware: new module : vmware_about_facts (#43146)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-07-29 14:51:14 +05:30
Eric Rinish
551501f326 use faster method to get short_description from DOCUMENTATION (#42705)
* use faster method to get short_description from DOCUMENTATION

* fixed pep8 whitespace

* fixed blank line
2018-07-27 17:27:44 -04:00
Joren Vrancken
350dbaf457 Correct default value of always_post_validate in docstring 2018-07-27 16:01:07 -04:00
flowerysong
a08668cf00 Port ec2_tag to boto3 (#39712)
* Add volume manipulation to EC2 integration test policy

* Port ec2_tag to boto3
2018-07-27 15:45:18 -04:00
Florian Braun
74af52533f Variable Timout for Katello Module + Documentation (#41834)
* Changed Foreman timeout to be setable via a parameter
Added a Parameter to set the timout to wait for the started Foreman actions
by the user instead of using the hard coded 1000 Seconds

* katello module screamed for more docu :)

* fix docu + some ci findings
made docu better and moved chices in relations to other options to the description

* added a quote to description and removed wrong combination of param product

* Removed choices from params
also removed katello from a ignore file
2018-07-27 12:31:12 -07:00
tstoner
2c3d418e53 Nxapi ssl (#42905)
* NXAPI ssl ciphers & protocols default values

* TLSv1, TLSv1.1, TLSv1.2 and weak cipher support

* NXOS NXAPI weak/strong cipher & TLSv 1.2, 1.1 & 1.0 support

* Version checking for strong/weak ciphers & TLS 1.2, 1.1 & 1.0 support

* Cleaned up erroneously committed changes.

* Specific NXOS platform checking for nxapi ssl ciphers & protocols

* Fixed ansibot reported errors.

* Resolved ansibot reported error.

* Added network_os_version to mocked up N7K unit test device_info

* Calling get_capabilities() once in main and passing results into methods.

* Removed raising exceptions when platform capabilities return None
per reviewers request. Skipping nxapi ssl options when capabilities
are None and generating a warning when these options are skipped

* Cleaned up explicit checks for None/not None
2018-07-27 22:10:39 +05:30
Jose Delarosa
779d273192 Add new module for Redfish APIs (#41656)
* Add new module for Redfish APIs

Communicates with Out-Of-Band Controller through Redfish APIs
Module gathers hardware information and sends back

* Removed unused library imports

* Removed token entry from headers

* Made 'command' optional and defined default value for each 'category'

* Replace 'result' with 'ansible_facts' for returned dict variable

* Removed unused variable definitions and library imports

* Renamed dicts where data is returned.

Should make it easier to sort through returned data that is placed
in one file.

* Defined dicts to specify available categories and commands in each one.

- Allows specifying default command for each category
- Allows specifying all commands for each category
- Removed Inventory category and moved commands to System category
- Renamed dicts where data is returned to allow to dump more than one in a file

* Remove choice[] since it's redundant

* Added flexibility when specifying categories

- If a category is not specified, it sets a default value
- Can handle more than one category
- Will accept value "all" for category which will set to all available
- Renamed category System to Systems to better reflect Redfish API

* Defined default category in a variable

* Made category argument a list

* Added examples

* Made command argument a list

* Replaced 'ansible_facts' with 'redfish_facts' for returned dict variable.

* Added default value for category in documentation

* Moving redfish_facts inside ansible_facts

* Updated how results dicts are constructed, where applicable

* Improved error messages

* Removed unused variables

* Undo commit 66a7dcd789 due to variable 'e' oversight
2018-07-27 12:21:25 -04:00
Jose Angel
711dd9f834 VMware Module - vmware_guest_move (#42149) 2018-07-27 20:21:45 +05:30
Anil Kumar Muraleedharan
f2c9a6b126 Lenovo port to persistence 1 (#43194)
* CNOS Vlag module is refactored to use persistence connection instead of paramiko.

* Changing interface and port channel modules to persistent connection and adding UT for them.

* Fixing pep8 issues

* Removing trailing new line

* Removing trailing new line

* Removing trailing new line

* Correcting indentation mistake

* Update cnos_vlag.py

* Removing commented examples

They are commented because those configurations are not meant for L2 ports
2018-07-27 10:47:02 -04:00
Abhijeet Kasurde
e24041449e
VMware: new module: vmware_guest_boot_manager (#40609)
This module can be used to manage virtual machine boot order and
related parameters.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-07-27 19:58:13 +05:30
Artem Goncharov
6667ec4474 fixes #42042 (#42939)
Do not create group with empty name when region (optional argument) is 
not given in the openstack connection
2018-07-27 10:02:34 -04:00
Abhijeet Kasurde
605a90dfeb
VMware: new module: vmware_category_facts (#39894)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-07-27 15:57:40 +05:30
Abhijeet Kasurde
9a561b53fa
VMware: Dynamic Inventory plugin (#37456)
* Disable warnings on validate_certs=False
* Required requests version
* Add testcase for inventory plugin
* Include review comments from mattclay
* remove pyvmomi installation
* remove config file at exit
* Add cache in vmware_inventory inventory plugin
* shertel review comments
* Rename vmware_inventory to vmware_vm_inventory
* bcoca's review comments
* Export username and password for failing testcase

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-07-27 15:38:19 +05:30
Xyon
9121f2a4c9 Validate and reject if csr_path is not supplied when provider is not assertonly (#41385) 2018-07-27 05:24:51 -04:00
Abhijeet Kasurde
20092786cf
VMware: new module : vmware_guest_custom_attributes (#38114)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-07-27 13:33:43 +05:30
Abhijeet Kasurde
08c9cb33b7
VMware: new module: vmware_guest_attribute_defs (#38144)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-07-27 13:27:14 +05:30
Abhijeet Kasurde
4dac5bed83
VMware: Fix mark as virtual machine method (#40521)
Choose resource pool by using get_resource_pool rather than select_resource_pool_by_name

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-07-27 12:56:08 +05:30
Lindsay Hill
4a98802b52 Ironware: Deprecate provider, support network_cli (#43285) 2018-07-27 12:51:45 +05:30
Denis GERMAIN
3f9e457751 feat: Add a enable_accelerated_networking flag in module + tests; fixes #41218 (#42109) 2018-07-27 14:56:36 +08:00
Zim Kalinowski
750774d768 fixing aiuth source (#42923) 2018-07-27 14:48:17 +08:00
Abhijeet Kasurde
aefe963483
VMware: handle special characters in datacenter name (#42922)
This fix handles special characters in VMware objects

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-07-27 12:17:10 +05:30
Abhijeet Kasurde
7dd5f4c01c
VMware: update examples in vmware_vm_shell (#42410)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-07-27 12:15:26 +05:30
Abhijeet Kasurde
1aeca65d10
VMWare: refactor vmware_vm_shell module (#39957)
* Update documentation
* Update wait_for_process logic
* Update examples and return
* Add missing msg in fail_json method

Fixes: #38320

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-07-27 11:22:41 +05:30
Abhijeet Kasurde
56f5390151
VMware: additional VSAN facts about Hostsystem (#40456)
VSAN related facts (cluster_uuid) will be used in vmware_vsan_cluster
while adding new host in VSAN cluster.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-07-27 11:18:42 +05:30
Ganesh Nalawade
af3f510316
nxos cliconf plugin refactor (#43203)
* nxos cliconf plugin refactor

Fixes #39056

*  Refactor nxos cliconf plugin as per new api definition
*  Minor changes in ios, eos, vyos cliconf plugin
*  Change nxos httpapi plugin edit_config method to be in sync with
   nxos cliconf edit_config

* Fix CI failure

* Fix unit test failure and review comment
2018-07-27 11:05:40 +05:30
Ryan Reed
e215f842ba Correcting conditionals looping (#43331)
Empty conditionals would not break out of the loop, causing every command to be run for the same number of times as retries is defined (10 by default)
2018-07-27 10:42:34 +05:30
Abhijeet Kasurde
dd73bae51a VMware: handle indexError for snapshot details (#42575)
Fixes: #42539

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-07-27 00:55:21 -04:00
Adrián Matellanes
c62d9a023a Fix zabbix-template module error version comparison (#39199)
* Fix zabbix-template module error version comparison

* Fix zabbix-template module error version comparison
2018-07-27 00:18:02 -04:00
Vladimir Dobriakov
92ab566527 Make example work: "Import Zabbix Temlate" (#40905)
<!--- Small typo, but it was hard to find, why the ansible module execution failed -->

+label: docsite_pr
2018-07-27 00:12:20 -04:00
Andreas Olsson
ab41fb9cd4 Fix cloudflare_dns proxied change detection (#43096)
Resolves #35190
2018-07-27 09:27:05 +05:30
Abhijeet Kasurde
604fcb55ae
VMware: add support for boot option firmware (#42730)
This fix adds support for the boot option 'firmware'

Fixes: #42541

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-07-27 09:18:04 +05:30
Toshio Kuratomi
dce0a8d052 Switch to imp.load_module 2018-07-26 20:07:25 -07:00
Toshio Kuratomi
52449cc01a AnsiballZ improvements
Now that we don't need to worry about python-2.4 and 2.5, we can make
some improvements to the way AnsiballZ handles modules.

* Change AnsiballZ wrapper to use import to invoke the module
  We need the module to think of itself as a script because it could be
  coded as:

      main()

  or as:

      if __name__ == '__main__':
          main()

  Or even as:

      if __name__ == '__main__':
          random_function_name()

  A script will invoke all of those.  Prior to this change, we invoked
  a second Python interpreter on the module so that it really was
  a script.  However, this means that we have to run python twice (once
  for the AnsiballZ wrapper and once for the module).  This change makes
  the module think that it is a script (because __name__ in the module ==
  '__main__') but it's actually being invoked by us importing the module
  code.

  There's three ways we've come up to do this.
  * The most elegant is to use zipimporter and tell the import mechanism
    that the module being loaded is __main__:
    * 5959f11c9d/lib/ansible/executor/module_common.py (L175)
    * zipimporter is nice because we do not have to extract the module from
      the zip file and save it to the disk when we do that.  The import
      machinery does it all for us.
    * The drawback is that modules do not have a __file__ which points
      to a real file when they do this.  Modules could be using __file__
      to for a variety of reasons, most of those probably have
      replacements (the most common one is to find a writable directory
      for temporary files.  AnsibleModule.tmpdir should be used instead)
      We can monkeypatch __file__ in fom AnsibleModule initialization
      but that's kind of gross.  There's no way I can see to do this
      from the wrapper.

  * Next, there's imp.load_module():
    * https://github.com/abadger/ansible/blob/340edf7489/lib/ansible/executor/module_common.py#L151
    * imp has the nice property of allowing us to set __name__ to
      __main__ without changing the name of the file itself
    * We also don't have to do anything special to set __file__ for
      backwards compatibility (although the reason for that is the
      drawback):
    * Its drawback is that it requires the file to exist on disk so we
      have to explicitly extract it from the zipfile and save it to
      a temporary file

  * The last choice is to use exec to execute the module:
    * https://github.com/abadger/ansible/blob/f47a4ccc76/lib/ansible/executor/module_common.py#L175
    * The code we would have to maintain for this looks pretty clean.
      In the wrapper we create a ModuleType, set __file__ on it, read
      the module's contents in from the zip file and then exec it.
    * Drawbacks: We still have to explicitly extract the file's contents
      from the zip archive instead of letting python's import mechanism
      handle it.
    * Exec also has hidden performance issues and breaks certain
      assumptions that modules could be making about their own code:
      http://lucumr.pocoo.org/2011/2/1/exec-in-python/

  Our plan is to use imp.load_module() for now, deprecate the use of
  __file__ in modules, and switch to zipimport once the deprecation
  period for __file__ is over (without monkeypatching a fake __file__ in
  via AnsibleModule).

* Rename the name of the AnsiBallZ wrapped module
  This makes it obvious that the wrapped module isn't the module file that
  we distribute.  It's part of trying to mitigate the fact that the module
  is now named __main)).py in tracebacks.

* Shield all wrapper symbols inside of a function
  With the new import code, all symbols in the wrapper become visible in
  the module.  To mitigate the chance of collisions, move most symbols
  into a toplevel function.  The only symbols left in the global namespace
  are now _ANSIBALLZ_WRAPPER and _ansiballz_main.

revised porting guide entry

Integrate code coverage collection into AnsiballZ.

ci_coverage
ci_complete
2018-07-26 20:07:25 -07:00
Richard Schwab
ec20d4b13e Enable zone detection in nsupdate (#41365)
Fixes #41346
2018-07-26 23:06:47 -04:00
Zim Kalinowski
30ef83c1c0 fixing bug in storage account sample (#43308) 2018-07-26 17:20:20 -04:00
Zim Kalinowski
e43d4ac512 fixing mysql server sample (#43300) 2018-07-26 16:07:37 -04:00
Zim Kalinowski
3f9cacf777 fixed postgresql server sample (#43299) 2018-07-26 16:07:07 -04:00
Nilashish Chakraborty
18235af363
Fix baud rate and nxos_logging default case idempotency bug (#43295)
* Fix baud rate and idempotency bug

* Fix Shippable errors

* Combine commands calls

* Fix Shippable errors II
2018-07-26 23:15:25 +05:30
Nathan Hyde
d3230b9172 Correct link to Getting Started with Docker Guide (#42709)
Update link to the docker getting started guide.

+label: docsite_pr
2018-07-26 10:39:01 -05:00
Nathaniel Case
ab40c72a3c
httpapi: Split off and save response text contents (#43305)
* Split off and save response text contents

* login might depend on httpapi
2018-07-26 10:12:34 -04:00
Abhijeet Kasurde
13dd1acbec Fix typo in ignore_unknown_extensions doc
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-07-26 09:28:33 -04:00
Blair Rampling
7a35e2f8c1 adds naptr record module (#39383)
* adds naptr record module

* fixes pep8

* fixes doc errors
2018-07-26 15:45:03 +05:30
Ganesh Nalawade
5e44189a36
Update junos_netconf module documentation (#43291)
Fixes #42719

* Add module documentation to reflect that when netconf
  port is not mentioned the module by default enables
  netconf on port 830 only.
2018-07-26 10:52:25 +05:30
Dag Wieers
32b5992578 uri: Avoid false traceback in common scenarios (#39526)
* uri: Avoid exception in common scenario

So I was confused by the fact that the **uri** module, when not
returning an acceptable HTTP status code, returns:

    The full traceback is:
      File "/tmp/ansible_UQwiI4/ansible_module_uri.py", line 471, in main
        uresp['location'] = absolute_location(url, uresp['location'])

While the actual error was:

    Status code was 400 and not [201]: HTTP Error 400:

I also wonder why that message ends abruptly. I would have expected
`HTTP Error 400: Bad Request` which would be more useful.

* uri: Avoid false positive tracebacks in fail_json() on PY2
2018-07-25 18:17:44 -07:00
Toshio Kuratomi
6eacfecb73 ANSIBLE_REMOTE_TMP was an implementation of unified temp that was later changed
One of the earlier implementation of unified temp for 2.4 passed the
temp diretory to the remote side using this environment variable.  We
later changed it to be passed via a module parameter but forgot to
remove the environment variable.
2018-07-25 16:57:46 -07:00
Adam Miller
66b1adfc83 fix fedora version dnf fact, default pkg_mgr detection per distro family (#43261)
* fix fedora version dnf fact, default pkg_mgr detection per distro family
* loop over possible dnf/yum paths in case there are multiple canonical sources later in life

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-07-25 16:20:07 -07:00
John Jensen
7ba0d8f60e fix regex parse for total memory in slxos_facts.py (#43258)
* fix regex parse for total memory in slxos_facts.py

* account for one or no spaces per LindsayHill's suggestion
2018-07-25 16:59:23 -04:00
Fabian von Feilitzsch
d27de6acd9 Add from_yaml_all to support multi document yaml strings (#43037)
* Support multi-doc yaml in the from_yaml filter

* Most automatic method of handling multidoc

* Only use safe_load_all

* Implement separate filter

* Update plugin docs and changelog
2018-07-25 16:12:22 -04:00
Julien Champseix
19dc267e4c Allow specifying the output encoding in the template module (#42171)
Allow specifying the source and destination files' encodings in the template module

* Added output_encoding to the template module, default to utf-8
* Added documentation for the new variables
* Leveraged the encoding argument on to_text() and to_bytes() to keep the implementation as simple as possible
* Added integration tests with files in utf-8 and windows-1252 encodings, testing all combinations
* fix bad smell test by excluding windows-1252 files from the utf8 checks
* fix bad smell test by excluding valid files from the smart quote test
2018-07-25 13:10:40 -07:00
Andrew Gaffney
dbff49dee0
Remove dead 'vault_password' play attribute (#41847) 2018-07-25 12:01:10 -05:00
Dag Wieers
9bf22309b3 Clarify uncertain nature of tracebacks on Python 2 (#42513)
* Only add exception/traceback on Python 3

On Python 2 the traceback could be any exception from the stack frame
and likely unrelated to the fail_json call.

On Python 3 the traceback is cleared outside any exception frame, so the
call always returns the most inner traceback (if any), and therefor is
most likely related to the fail_json call.

* Add uncertainty to traceback on Python 2

On Python 2 the last exception in the stack frame is being returned,
this could be unrelated to the actual error, especially if fail_json()
is called outside an except: block.
2018-07-25 11:49:16 -04:00
curry9999
1305fca414 change version_added cobbler_sync (#43248) 2018-07-25 14:38:36 +02:00
saichint
fa5f396a4b nxos_file_copy enhancement (#42424)
* add file_pull option

* typo correction

* fix shippable error

* review comments

* fix for review comments by mwiebe

* possible shippable fix

* remove file_copy from ignore

* more review comments addressed

* review comments

* add localhost for remote scp server in tests

* timeout fix
2018-07-25 17:46:55 +05:30
mjmayer
a488b3a8ed elb_application_lb purge rules option (#43113)
* Add parameter to keep elb rules

Does not purge elb rules. This is usefull if running the elb_application_lb
 role and there is the desire to keep existing rules.

* Change variable name keep_rules to purge_rules

The descriptor purge has been used in the past.

* Changed default for purge_rules

Default is purge_rules. This is how the module has functioned previously. This change maintains
 the previous behavior.

* Add integration test for purge_rules flag

* Change wording of test task

* Fix merge conflcit

* Changed default for purge_rules

Default is purge_rules. This is how the module has functioned previously. This change maintains
 the previous behavior.

* merge conflcit

* Change wording of test task

* Add purge_rules option to test

* Change test description wording

* Expand purge_rules documentation

* Clarifies documentation for purge_rules option
2018-07-25 20:55:34 +10:00
Fran Garcia
577306e74b Fix #42000 : ovirt_host_pm documentation for slot parameter (#42196)
* Fix for #42000: ovirt_host_pm ignores slot parameter

* Fix for #42000: ovirt_host_pm ignores slot parameter

* Remove non-required slot parameter
2018-07-25 05:19:24 -04:00
Jordan Borean
2c9cbae3f9
Removed deprecated Windows items slated for removed in 2.7 (#43231) 2018-07-25 12:02:49 +10:00
tomelrod
5eb47066e3 Documentation change for resizefs (#43224)
* Documentation change for resizefs

Changed documentation to match the default value of resizefs set in the code.
Added a note on the resizefs use on the example utilizing it.

* Remove test now it validates fine
2018-07-25 00:22:24 +02:00
Dag Wieers
939de473c6
Add a 'finished' test for async jobs (#38325)
This provides a more convenient way for testing (async) jobs.

When used with a non-async job it will report a warning so the user is
aware that he may be doing something incorrect.

Since the 'finished' result value is an integer (!), the test is turning
this in a proper boolean.
2018-07-24 23:21:28 +02:00
Dag Wieers
5ecfb0b793 cobbler_system: New module to manage Cobbler systems (#39913)
* cobbler_system: New module to manage Cobbler systems

This module is useful to provision new systems using Cobbler and Ansible.

* cobbler_system: warn on invalid properties
2018-07-24 15:50:20 -04:00
Andrew Gaffney
42346937b1
Display task banner before item status (#42892)
This is a follow-up to #41058
2018-07-24 12:25:28 -05:00
Brian Coca
917b6b0d09 import_playbook is not usable from inside a play
(cherry picked from commit 55dddf530ad094810929823f80c4546e97a69ac7)
2018-07-24 13:25:12 -04:00
Nathaniel Case
a7097f6735
Try to enable more exotic auth methods in httpapi (#43212)
* Try to enable more exotic auth methods in httpapi

* Auth tokens won't always come back.

* Reconcile #43147 with this PR
2018-07-24 13:22:40 -04:00
Brian Coca
ac1f05478e Allow to specifically customize console's color 2018-07-24 13:21:58 -04:00
Xyon
3bb9f689e9 Fix spelling; summery -> summary (#43213)
Fix the incorrect spelling of "summary".
2018-07-24 22:10:48 +05:30
Rémy Léone
3113c68053 Fix author name in the documentation 2018-07-24 12:01:37 -04:00
Gregory Hellings
6f007c35c1 Improved the documentation of known_hosts
The documentation for the key parameter was lacking in specificity and
also lacking in testing. These parts are both remedied herein.

Fixes #43157
2018-07-24 09:25:12 -04:00
Brian Coca
0718a53b07 also get checksum on 'any' if it is a file
fixes #42785
2018-07-24 08:59:52 -04:00
Brian Coca
cdc762dd9e
don't assume all delegation subkeys exist (#43032)
* don't assume all delegation subkeys exist

fixes #43026

* add tests
2018-07-24 08:54:58 -04:00
Deepak Agrawal
bf544c2200
Add support for commit label in iosxr_config (#42931)
* Add support for commit label in iosxr_config

* sanity pep8 etc fixes
2018-07-24 17:16:26 +05:30
Abhijeet Kasurde
4f1746ee1d
vault: check dir value before passing (#43184)
This fix checks if dirname is not equal to '' before proceeding
to create actual directory with name.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-07-24 16:27:17 +05:30
Trishna Guha
dd6ef3355f
get_device_info nxos zero or more whitespace regex (#43178)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-07-24 10:55:37 +05:30
Andreas Olsson
c6854fde29 Fix cloudflare_dns JSON response error handling (#42894)
* The JSONDecodeError exception only exists in Python 3.

* Without a properly parsed JSON response there is no more error
  processing to be done, no matter the http response code.

Relates to #38178
2018-07-24 09:51:44 +05:30
Lindsay Hill
42a9fb1337 Fix broken IPv6 regex (#43175) 2018-07-24 09:13:24 +05:30
uwila
c0048007a9 Detect failed sysvinit module (#43127)
* Detect failed sysvinit module

- This checks the stderr instead of the rc to detect whether the
  sysvinit module was successful or not, as even when failing, the
  rc would be 0.
- It immediatly became obvious that the debug info when failing
  was far too little to properly debug the role. To improve this,
  I also added the rc, stderr and stdout to the debug output.

* Revert stderr check to rc check, rename out->stdout, err->stderr
2018-07-23 19:58:42 -04:00
Jordan Borean
d5d29f4cfa
ssh - skip connection reset if controlpath does not exist (#43062) 2018-07-24 08:20:54 +10:00
Jordan Borean
04431216e7
win_user: use different method to validate credentials that does not rely on SMB/RPC (#43059)
* win_user: use different method to validate credentials that does not rely on SMB/RPC

* Use Add-Type as SetLastError on .net reflection not working on 2012 R2
2018-07-24 08:16:42 +10:00
Jordan Borean
48ad90ac8e
powershell: support recursive requires statements (#43143) 2018-07-24 08:16:16 +10:00
Jordan Borean
93c05074ee
win_chocolatey: refactor module to fix bugs and add new features (#43013)
* win_chocolatey: refactor module to fix bugs and add new features

* Fix some typos and only emit install warning not in check mode

* Fixes when testing out installing chocolatey from a server

* Added changelog fragment
2018-07-24 07:52:13 +10:00
Jarryd Tilbrook
460f858640 Enable check_mode in command module (#40428)
* Enable check_mode in command module

This only works if supplying creates or removes since it needs
something to base the heuristic off. If none are supplied it will just
skip as usual.
Fixes #15828

* Add documentation for new check_mode behavior
2018-07-23 14:06:41 -07:00