cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
39874 commits 47 branches 390 tags 440 MiB
Commit graph

23230 commits

Author SHA1 Message Date
René Moser
1ed3bd9168
vultr: fix for unreliable API behavior (#45712) 2018-09-19 00:01:53 +02:00
René Moser
22986648dc
vultr_server: fix diff for user data (#45753) 2018-09-18 23:20:11 +02:00
Sloane Hertel
8d2df9be52 ec2_group - fix VPC precedence for security group targets (#45787) 
Update the dictionary with the preferred values last to get the right order of VPC precedence

Fixes #45782
 2018-09-18 15:33:19 -04:00
Stijn Martens
049a462058 Update influxdb_database.py (#39984) 
InfluxDB >= 1.2.4 is not supported

+label: docsite_pr
 2018-09-18 12:54:02 -05:00
Christer Hemgren
4da13eefb2 asa_config add doc l3 interface (#41250) 
* asa_config add doc l3 interface

+label: docsite_pr
Issue ansible/community#311

* fix interface idempotent

* newline, names, and debug:var
 2018-09-18 13:39:14 -04:00
Christer Hemgren
7b1c61000e update asa_config with bgp doc example (#41376) 
* update asa_config with bgp doc example

+label: docsite_pr
Issue ansible/community#311

* fix spelling
 2018-09-18 10:53:32 -05:00
Sam Doran
afd8b97fb1
Make sure strings are bytes for Py2/3 compatibility (#45746) 2018-09-18 10:10:47 -04:00
Matt Martz
b6fcbfe813
Support transfering empty files to target host. Fixes #36725 (#45751) 2018-09-18 09:05:20 -05:00
Matt Martz
f8c98600a9
If including a file resulted in AnsibleFileNotFound, clarify error message. Fixes #45661 (#45667) 2018-09-18 09:04:33 -05:00
Sloane Hertel
c004a639b3
[ovirt] remove 2.8 deprecations (#45506) 2018-09-18 08:28:00 -04:00
mrmagooey
1f8c5905b3 VMware: fix return to return a tuple instead of a bool (#45764) 
fixes "'bool' object is not iterable" exception when `res` is falsey
 2018-09-18 16:53:17 +05:30
Martin Nečas
28a074c835 ovirt add vnic (#44716) 
* ovirt add vnic
 2018-09-18 10:02:49 +01:00
Dario Zanzico
54c3d1c24e New module: add docker_stack module (clound/docker/docker_stack) (#24588) 
* add docker_stack module + tests
 2018-09-18 09:54:44 +01:00
Felix Fontein
0961d914d7 Don't parse/interpret options if state is 'absent'. (#45700) 2018-09-17 22:07:52 -04:00
Will Thames
d2569a3f7d Improve iam_group exception handling (#45599) 
* Improve iam_group exception handling

Use AnsibleAWSModule for iam_group and handle BotoCoreErrors
as well as ClientErrors. Use fail_json_aws to improve error messages

* Add minimal iam_group test suite

Update some of the read-only IAM permissions (this is not sufficient
to run the test suite but it gets further than it did until it tries
to add a (non-existent) user)

* Clean up after tests
 2018-09-17 19:53:44 -04:00
Michael Scherer
5c49641798 Port the aix_inittab to python 3 (#45678) 
Since izip no longer exist on python 3, we need to use zip
Fix #45220
 2018-09-17 19:01:38 -04:00
Raymond Wanyoike
c41632fad2 Add the key_name/value_name options to the dict2items filter (#45550) 
* Add the key_name/value_name options to dict2items - as with items2dict, allow users to configure the key/value name for dict2items, add "version added" and examples
 2018-09-17 15:53:52 -05:00
Sandra McCann
7092dd7fbf Add 'Wait for' example to asa_command module (#45190) 
* Added example to register result of a ping test, including a wait_for command.
* added names to tasks
* updated examples to remove deprecated commands etc
* removed group_var
 2018-09-17 15:12:46 -05:00
Denis GERMAIN
68e264e878 Wrong parameter in scaleway sshkey module example (#45737) 
* Update scaleway_sshkey.py
fix: typo "present" in example
 2018-09-17 15:04:09 -05:00
zharalim
8526f63255 Enhance the note about fileglob being local (#45398) 
Made the note clearer and instructed to use find module for remote operations.
Relating to #34497
 2018-09-17 16:00:41 -04:00
C. Friedrichs
05840ffe16 updated documentation in vmware_guest.py (#45481) 
Added note regarding online disk resizing and changed wording of a few sentences. Also added vSphere 6.7 as "tested on" as it works very well.
 2018-09-17 15:59:21 -04:00
Rémy Jacquin
63444136ba Add example for multiple package selection with dnf (#45610) 
Thanks for enhancing the Ansible documentation!
 2018-09-17 15:54:48 -04:00
Michael Scherer
bef1e5621b Add a alias from organisation to organization (#45688) 
Since 'organization' is the spelling used accross all others modules,
I think it would be better to at least have this one as a alias.

Organisation is the UK/Australia/NZ spelling, while organization is the
US one.
 2018-09-17 15:50:46 -04:00
Nathaniel Case
52c20bbd3f
Update from napalm PR (#45743) 2018-09-17 15:39:07 -04:00
Aidan Feldman
fa18d45eb3 Link to the Galaxy platforms list from the meta file template (#34046) 
* Link to the Galaxy platforms list from the meta file template
Fixes https://github.com/ansible/galaxy/issues/52.
* make ansible/ansible text match mazer text on platforms
 2018-09-17 13:39:54 -05:00
Sloane Hertel
21f4b5911e [aws] fix version_added for elb_classic_lbmodule (#45559) 2018-09-17 14:32:51 -04:00
Sloane Hertel
b42c7f4512 [iam_role] A hyphen with nothing following becomes [None] rather than []. Fix example syntax. (#45742) 2018-09-17 14:32:15 -04:00
Sloane Hertel
d7ca3f2bd3 ec2_group: fix regression for targets that are a list containing strings and lists (#45594) 
* Fix targets that may be a list containing strings and lists which worked prior to 2.6.

* Add ec2_group integration tests for lists of nested targets

* changelog

* Add diff mode support for lists of targets containing strings and lists.
 2018-09-17 14:31:41 -04:00
Lingxian Kong
cf1e0bde99 os_loadbalancer: support to create populated load balancer (#44619) 
The user can use os_loadbalancer module to configure a fully functional
load balancer by specifying the sub-resources definition in the module,
rather than combining os_listener, os_pool and os_member modules.
 2018-09-17 14:10:03 -04:00
Dag Wieers
a7a99c5fd4 reboot: Fix typo and support bare Linux systems (#45607) 
* reboot: Fix typo and support bare Linux systems

This fixes a problem for bare Linux systems that do not support 'who -b' or 'uptime -s'.

* Accumulate stdout and stderr information
 2018-09-17 14:04:03 -04:00
Nathaniel Case
21ff9c6a4a
Add initial napalm connection plugin (#45224) 
* Add initial napalm connection plugin

* Fix review comments
 2018-09-17 12:53:57 -04:00
Nathaniel Case
917fcb9c55
These won't get upgraded to bool if ansible doesn't know they are (#45736) 2018-09-17 11:34:57 -04:00
David Passante
05328ebf21 Cloudstack: fix support for some VPC service capabilities (#45727) 
* Fix support for VPC capabilities such as redundant routers or region level VPC

* Add integration test cases for "region level VPC" and "distributed router" capabilities
 2018-09-17 16:08:16 +02:00
Nathaniel Case
780dc9c561
There are other instances of transform being used... update them as well (#45663) 2018-09-17 08:42:20 -04:00
Rémy Léone
66f03827d6 Add a netbox dynamic inventory plugin (#45347) 2018-09-16 15:13:56 +01:00
René Moser
00d04ef757
twilio: fix multi to_number support (#44878) 
* twilio: fix multi to_number support

* use json helper
 2018-09-16 08:38:25 +02:00
Matt Martz
07b2698c03 Add new expand_shell argument for run_command, to disable expanding shellisms (#45620) 
* Add new expand_shell argument for run_command, to disable expanding shellisms. Fixes #45418

* s/expand_shell/expand_user_and_vars/g
 2018-09-14 16:07:11 -04:00
Ken Dreyer
e46ce1619f add docstring for ansible.inventory.helpers.get_group_vars 
Document the expected parameter type and return type of
get_group_vars().
 2018-09-14 16:02:45 -04:00
julianladisch
5adcaf4538 Suggest full fingerprint for apt_key. (#44697) 
* Suggest full fingerprint for apt_key.
Background: https://gwolf.org/node/4070 (Gunnar Wolf: Stop it with those short PGP key IDs!)
I've put the full fingerprint into the examples.
* avoids the phrase 'best practice'
 2018-09-14 14:50:46 -05:00
Anil Kumar Muraleedharan
4ec317ceca Lenovo doc update (#45483) 
* Merge issue

* Update cnos_rollback.py

* Updating license for the refactored method

* Update cnos_rollback.py

* Removing the BSD License as suggested by Legal

* To add Documentation for ENOS as well as CNOS

* Merge issue

* Revert "To add Documentation for ENOS as well as CNOS"

This reverts commit 80e6e39054be0c3a8f95d16dc39ca9d93baf8c4b.

* Adding Docs for ENOS and CNOS

* Update cnos.py

* Update cnos_rollback.py

* Update cnos.py

* Update platform_cnos.rst

* Update platform_enos.rst

* Removed version 2.7

* Removing 2.7
 2018-09-14 15:23:57 -04:00
Jon Cormier
7aaa5da41d [aws_ssm_parameter_store] use describe_parameters paginator (#45632) 
Fix the service reaching an internal limit while processing the results and returning unexpected data
 2018-09-14 15:17:15 -04:00
lwm
1d754b43de Linode: clarify how to create/delete linode machines with linode_id. (#45659) 
* Attempt to explain `linode_id` a bit better.

Don't include in any example that creates a Linode.

Based on comments in

> https://github.com/ansible/ansible/issues/45403#issuecomment-419752856

* Add simple creation example. Show how to pass `linode_id`.
 2018-09-14 15:10:32 -04:00
Maugli
235b11f681 Return correct version on installed VyOS (#39115) 
* Return correct version on installed VyOS

Previously existing regexp will shows only "VyOS" without numeric output of router version.
For example: from  "Version:      VyOS 1.1.6" only VyOS will be written in ansible_net_version variable
For more informative output numeric value should be returned as well

* Fixed unittests
 2018-09-14 22:51:30 +05:30
Matt Martz
829f48e3f5
Flip default for AGNOSTIC_BECOME_PROMPT (#45563) 
* Flip default for AGNOSTIC_BECOME_PROMPT

* simplify AGNOSTIC_BECOME_PROMPT porting guide entry

* clarify AGNOSTIC_BECOME_PROMPT changelog entry

* fixes version typo

* uses alternate wording (rather than escaping *)
 2018-09-14 11:16:13 -05:00
Martin Krizek
d383d87b22 include_vars: fix checking for a string in ignore_files 2018-09-14 11:18:00 -04:00
Michael Scherer
a1e2f1bf73 [voss_facts] remove uneeded global declaration of variable warnings (#45653) 
Since the variable is used only once, no need to declare it global.
Remove a warning from linter (lgtm.com)
 2018-09-14 10:39:41 -04:00
Deaton64
3782a236ba Update azure_rm_trafficmanagerprofile.py examples (#45649) 
Wrong module name used in examples. changed `azure_rm_trafficmanager` to `azure_rm_trafficmanagerprofile`
 2018-09-14 09:48:11 -04:00
Michael Scherer
518f80c3fb [module_utils/aws/urls] remove assigning variable itself (#45612) 
Flagged by lgtm.com
 2018-09-13 17:42:04 -04:00
Xyon
8d6522c671 Update mysql_db.py (#41317) 
Add note to inform that mysql_db is not idempotent when state is "import".

+label: docsite_pr
 2018-09-13 17:31:45 -04:00
Michael Scherer
ede3a8cee1 Fix formatting for the error on azure_rm_appserviceplan_facts (#45613) 
Since there is only 1 argument, {1} can't work since that's the
2nd argument for format. Flagged by lgmt.com
 2018-09-13 17:00:21 -04:00
Tim Rupp
5a3a865ca0
More bigip software fixes (#45633) 
Fixes problems related to token timeout. Adds cleanup of tokens.
 2018-09-13 15:58:17 -04:00
Brian Coca
ddb3764039
avoid empty groups in json output (#45621) 
they get confused as hosts by script plugin

fixes #45601
 2018-09-13 15:38:52 -04:00
Tim Rupp
e619052424
Fixes multiple lgtm issues (#45629) 
Most of the issues were just inclusions of code that were not used.
This cleans those up. Other alerts were semi-false-positives for now
 2018-09-13 15:26:17 -04:00
Matt Martz
e68f895e61
Support empty files with piped transfer_method. Fixes #45426 (#45618) 2018-09-13 13:53:36 -05:00
Vibhav Sinha
e26d758d6f fix gce_backend_service examples for healthchecks (#31134) 
gce_backend_service module expects healthchecks to be an array of string. The previous example incorrectly mentioned healthchecks as an array of objects each containing a `name` key.
 2018-09-13 13:47:43 -05:00
Tim Rupp
34d08adea0
Fixes lgtm alert (#45619) 
Alert was for an include that was not used.
https://lgtm.com/projects/g/ansible/ansible/latest/files/lib/ansible/modules/network/f5/_bigip_facts.py?sort=name&dir=ASC&mode=heatmap&showExcluded=false#L98
 2018-09-13 13:45:55 -04:00
Michael Scherer
de84a05bf4 Remove unused import iControlUnexpectedHTTPError (#45611) 
Since that's unused in the code, no need to import it.
This got flagged by linter
 2018-09-13 13:16:23 -04:00
Anton Nikulin
b7263eab1d Store Authorization header inside HttpApi connection plugin (#45598) 2018-09-13 19:34:30 +05:30
Nathaniel Case
285b927889
network command modules cleanup (#45242) 
* Standardize _command modules

* Centralize command transformation process

* Fix check mode error test
 2018-09-13 08:55:35 -04:00
Zim Kalinowski
df768914a1 adding sql firewall rule facts (#45059) 2018-09-13 17:54:58 +08:00
Strahinja Kustudic
8d8df46fe6 Add an error message if a pkg cannot be removed, fixes #35672 (#40723) 2018-09-13 02:54:38 -04:00
tterranigma
cc477ec920 Update fileglob.py (#45558) 
* Update fileglob.py

Closes #45557

* Update fileglob.py
 2018-09-13 12:10:00 +10:00
Nathaniel Case
3d0f19d8cd
Exclude the whole ansible_failed_task block (#45587) 
It has lots of FieldAttributes that won't serialize.
Also the connection doesn't care.
 2018-09-12 21:17:24 -04:00
Jordan Borean
d81249994e
win_script: add support for become and centralise exec wrapper builder (#45582) 
* win_script: add support for become and centralise exec wrapper builder

* satisfying the pep8 gods

* do not scan for module dependencies when running as a script
 2018-09-13 08:50:13 +10:00
Sam Doran
03dbb1d9c4 Improve code stability is checksum checking 
- use context manager for dealing with the checksum file
- use loop that can tolerate zero, one, or more items return rather than the previous expression which would break if anything other than exactly one item was returned
 2018-09-12 15:29:15 -07:00
Martin Nečas
2a3f3382fd Ovirt add rename functionality (#44951) 
* add renaming of ovirt
* add renaming func to ovirt cluster
* ovirt update examples in docs
 2018-09-12 14:36:06 -07:00
Jon "The Nice Guy" Spriggs
ab2e6fded1 Show multi-line messages in debug documentation (#23000) 
* Show multi-line messages in debug documentation

* Add two-line entry
* Indicate that jinja2 filters are not applied here

* Fix to incorrect documentation change
 2018-09-12 16:55:48 -04:00
Ferdinand Holzer
3c083837c0 Clarify how java_cert checks keystore certificates (#26567) 2018-09-12 15:51:37 -05:00
Dag Wieers
310b0a2521 Docs: Make docsite rebuilds smarter/faster (#45062) 
* Make the following scripts  idempotent so that we only have to rebuild changed docs, not all docs:

  * plugin_formatter
  * generate_man
  * dump_keywords.py
  * dump_config.py
  * testing_formatter.sh
 2018-09-12 13:50:36 -07:00
Tim Rupp
e266a24263
Fixes bugs in the bigip_software modules (#45577) 
This patch makes hotfix code work, where before, only base images
were working
 2018-09-12 15:56:43 -04:00
Brian Coca
1ed57f1f64 moving from with_ff to just ff (#44847) 2018-09-12 15:35:04 -04:00
Evert
f7ef06e849 Added a note regarding the delegate_facts option. (#25257) 
* Added a note regarding the delegate_facts option with a link to documentation
 2018-09-12 14:30:05 -05:00
Richard Schwab
ea8924f744 Make it clear that recurse only applies to state=directory (#40222) 
This would otherwise cause confusion as it could be interpreted as only changing attributes for directories (and not files inside).

+label: docsite_pr
 2018-09-12 13:00:49 -04:00
Anil Kumar Muraleedharan
ac58c36ad0 Lenovo cli bugfixes (#45278) 
* To change all CLIs present in the code to latest CNOS CLI. One bug of executing with Lenovo Jakku switch is also getting fixed.

* To change the file names as the commands have changed from display to show

* To change to new CLI in test_cnos_comand.py as well
 2018-09-12 10:31:45 -04:00
thetuxkeeper
11cfa96797 fixing bytes <-> str regexp issue in cloudengine (#45285) 2018-09-12 09:59:42 -04:00
abirami-n
06fd9820a3 Fixes handling of terminal_initial_prompt on dellos6 and dellos9 devices (#45273) 
* Fix terminal initial prompt on dellos6 and dellos9

* Fix_pylint
 2018-09-12 19:28:32 +05:30
Nathaniel Case
eaf01d321f
eos: Don't error on VLAN missing warning (#45433) 2018-09-12 09:55:23 -04:00
Ghilli3
6040175186 Initial commit of fmgr_sys_proxy.py (#45518) 2018-09-12 19:18:27 +05:30
Zim Kalinowski
73c8041ec0 Azure load balancer crash fix (#45546) 2018-09-12 16:25:35 +08:00
Zim Kalinowski
111febe62e extended vmss facts (#45535) 2018-09-12 13:22:47 +08:00
Brian Brooks
0198d93f68 Update keycloak_client.py (#45505) 
Slightly improve wording about lack of input sanity checking on API calls.

+label: docsite_pr
 2018-09-12 06:22:54 +02:00
Zim Kalinowski
821c27cefb fixed tag support in autoscale facts (#45533) 
* fixed tag support in autoscale facts

* forgot to add tags to arg spec
 2018-09-11 23:00:58 -04:00
Deepak Agrawal
81214409cf
asa_config/ios_config: diff strict does not work with multiple parents (#45150) 
* multiple parents issues in diff

* Integration tests for missing functionality

* add testcase for other platforms. vnxos does not support qos so need to find a command chain on v-nxos for multiple parets. junos uses on-device diff so should not need this.

* Fix for issue when any candidate parent did not meet the exact line in running-config

* DCI runs eos_config without become flag
 2018-09-12 07:50:24 +05:30
Michael Scherer
004621ef8e Fix useless comparaison between 2 constants (#45524) 
Found with https://lgtm.com
 2018-09-11 19:37:50 -04:00
Jose Delarosa
197059b4a2 Update the root URI to match the DMTF specification (#45295) 2018-09-11 19:15:59 -04:00
Kerry
bf90a44468 Clarify the creates and removes options (#45485) 
* Clarify the creates and removes options

The description for the creates and removes options were worded poorly. This change improves readability and is easier to understand.

 Double negatives are BAD

+label: docsite_pr

* Fix trailing whitespace
 2018-09-11 15:45:19 -05:00
William
2ea9cfcd52 Fix python 3 compatibility for network id lookup (#45467) 
Due to a change in python 3 filters return filter instead of list. This breaks the network name to id lookup for the docker_swarm_module. By wrapping it in list it ensures it is a list when returned and the id is extracted.
 2018-09-11 15:45:42 -04:00
Sloane Hertel
e5269c047c [AWS] cloudfront_distribution - fix method name from 'validate_distribution_id_from_caller_reference' to 'validate_distribution_from_caller_reference' and set distribution_id to the distribution's key 'Id' (#45498) 2018-09-11 15:08:30 -04:00
Matt Martz
5785de582f
Fix logic to not re-download existing files when force=no (#45495) 
* Fix logic to not re-download existing files when force=no. Fixes #45491

* Reduce logic complexity
 2018-09-11 13:56:13 -05:00
Nathaniel Case
b22b07e300 Fixup network connection documentation (#45487) 
* Fixup network connection documentation similar to suggestions in #45224

* Another tpyo
 2018-09-11 14:23:38 -04:00
Matt Clay
ae4d5e3257 Avoid duplicate Azure storage account types. 2018-09-11 10:37:48 -07:00
David Rodríguez
600c7ac108 Fix remote checksums when paths have leading dots (#45287) 
* Fix remote checksums with paths have leading dots

* Fix result recorded from the wrong file

* Add changelog fragment
 2018-09-11 12:47:29 -04:00
Michael Scherer
804d574d1f Add documentation for the modify command, by giving a example (#19699) 2018-09-11 11:38:39 -04:00
Sam Doran
03414727ba Add documentation about patterns with commas to find module (#45360) 
Thanks @samdoran  for the example and clarification!
 2018-09-11 11:04:17 -04:00
Yuwei Zhou
fa04387550 fix the autoscale resource id (#45477) 
* fix the autoscale resource id

* Update main.yml
 2018-09-11 18:52:43 +08:00
James Cassell
211aeebd0d remove unused templar._clean_data() (#42739) 2018-09-11 09:11:03 +02:00
Zim Kalinowski
8a221d81dd fixing facts for mysql server (#45374) 2018-09-11 14:27:50 +08:00
Harald Albers
796d8b5dc8 VMware: Fix wait_for_task backoff behavior (#45429) 
Signed-off-by: Harald Albers <github@albersweb.de>
 2018-09-11 09:58:53 +05:30
Jordan Borean
01398f61d5
Win deprecate 2.8 (#45473) 
* Remove deprecated/expired functionality

* win:_msi: Remove the win_msi module

* removed some missed deprecated return options and added porting guide reference

Co-authored-by: dagwieers <dagwieers@users.noreply.github.com>
 2018-09-11 14:23:48 +10:00
Jordan Borean
ec6d82435f
win_scheduled_task: add deprecation warning for repetition format (#45468) 
* win_scheduled_task: add deprecation warning for repetition format

* fixed up sanity issues
 2018-09-11 14:22:57 +10:00