Brian Coca
83b5220068
clarified ping module purpose
2015-10-21 13:58:05 -04:00
Toshio Kuratomi
dc51e1ae41
Mark a few parameters as no_log
2015-10-20 15:35:17 -07:00
Brian Coca
ccbcff8c8e
better handling of checkmode for solaris
...
fixes #2296
2015-10-19 20:09:21 -04:00
Brian Coca
0307e3e649
Merge pull request #2209 from gekmihesg/devel
...
Support sysctl on OpenBSD
2015-10-09 13:26:24 -04:00
Achilleas Pipinellis
1499288c64
Add missing documentation: cron_file requires user to be set
2015-10-08 19:20:08 +03:00
gekmihesg
cdf0c8a560
Support sysctl on OpenBSD
...
Fixes #1233
2015-10-06 17:38:47 +02:00
Simon Li
d616fd12da
Fix incorrect variable in group.py: user -> group
2015-10-03 01:09:03 +01:00
Brian Coca
a15aa09251
removed typo
2015-10-01 10:16:34 -04:00
Brian Coca
f6bbd2ac5b
removed syslog in favor of common module logging functions
2015-10-01 00:13:58 -04:00
Brian Coca
3e42527fde
revert must_exist
2015-10-01 00:13:58 -04:00
Mike Boone
539c996ede
Updated link to the FAQ.
2015-09-20 22:45:51 -04:00
Brian Coca
81a7243bbb
changed chmod to 2.4 compat
2015-09-14 09:54:38 -04:00
Brian Coca
813053c51c
Merge pull request #986 from ssssam/cron-permissions-fix
...
Fix permissions issue with 'cron' module
2015-09-11 16:37:16 -04:00
Brian Coca
e278f285aa
partially reverted previous change to deal with systemctl show status not returning errors on missing service
...
Now it looks for not-found key instead of running status which does return error codes when service is present but in diff states.
fixes #12216
2015-09-02 17:11:30 -04:00
Brian Coca
bbcfb1092a
check systemctl status before show as show will not return antyhing other than rc=0 even when it fails.
2015-09-01 10:58:15 -04:00
Marius Gedminas
5595a9f81d
authorized_key: fix example in documentation
...
'key=' cannot be pointing to a file name; it needs to be the key itself as a string (or a URL).
2015-08-31 09:08:35 +03:00
Tim Rupp
48f522455d
Add hostname support for Kali linux 2.0
...
This patch allows the hostname module to detect and set the hostname for a
Kali Linux 2.0 installation. Without this patch, the hostname module raises
the following error
hostname module cannot be used on platform Linux (Kali)
Kali is based off of Debian.
2015-08-28 20:35:24 -07:00
Benno Joy
8bf800d5c5
Merge pull request #1973 from mgedmin/user-no-ssh-keygen-in-check-mode
...
user: don't generate SSH keys in check mode
2015-08-27 12:13:06 +05:30
Marius Gedminas
4ae4331a6b
user: don't generate SSH keys in check mode
...
Fixes https://github.com/ansible/ansible/issues/11768
Test plan:
- (in a Vagrant VM) created a user 'bob' with no ssh key
- ran the following playbook in check mode:
---
- hosts: trusty
tasks:
- user: name=bob state=present generate_ssh_key=yes
- saw that ansible-playbook reported "changes=1"
- saw that /home/bob/.ssh was still absent
- ran the playbook for real
- saw that /home/bob/.ssh was created
- ran the playbook in check mode again
- saw that ansible-playbook reported no changes
- tried a variation with a different username for a user that didn't
exist: ansible-playbook --check worked correctly (no errors, reported
"changed")
2015-08-26 08:51:52 +03:00
Simon Li
428550e179
Don't fail in check_mode if user exists
...
PR #1651 fixed issue #1515 but the requirement for path to be defined is unecessarily strict. If the user has previously been created a path isn't necessary.
2015-08-21 17:55:28 +01:00
Александр Костырев
31ec203583
Fix documentation of authorized_key.py
...
man for sshd http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man8/sshd.8?query=sshd
says there's no "host" option but "from".
2015-08-17 18:00:04 +03:00
Brian Coca
5d7cb981d3
made continue into a pass (there was no loop)
2015-08-13 10:05:30 -04:00
Brian Coca
6d7428527d
minor doc fixes
2015-08-12 23:55:01 -04:00
Brian Coca
2fd171a5e1
Merge pull request #878 from EvanK/system-cron--disabled
...
cron module: Add disabled option for commented jobs
2015-08-12 23:50:47 -04:00
Brian Coca
cd0a1947c2
Merge pull request #1899 from austinhyde/fix-service-rcconf-newlines
...
Service module incorrectly handles lines not ending in a newline
2015-08-12 19:34:34 -04:00
Brian Coca
7a2687178e
avoid shlex exceptions in rc parsing (happens with multiline entries)
...
fixes #1898
2015-08-12 18:10:24 -04:00
Brian Coca
0c403781a7
Merge pull request #1905 from evverx/fix-legacy-services-enabled
...
Fix service.enabled on: Debian 8, Ubuntu 15.04
2015-08-12 10:18:50 -04:00
Evgeny Vereshchagin
55e8863cb4
Fix service.enable on: Debian 8, Ubuntu 15.04
...
Workaround for https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=751638
See https://github.com/systemd/systemd/issues/937
2015-08-12 14:13:19 +00:00
Brian Coca
072c4f38ea
Merge pull request #62 from 0x46616c6b/user-add-skeleton-support
...
Add support for skeleton directory (useradd -k) in user module
2015-08-12 09:17:35 -04:00
Austin Hyde
5c25057868
Always end rc.conf entries with a new line
2015-08-10 17:42:26 -04:00
Brian Coca
0e9fccd098
changed verbose override variable
2015-07-29 14:54:19 -04:00
James Cammarata
bc60c893f5
Prefer non-zero rc's over text analyis in service status checks
...
Fixes ansible/ansible#10441
2015-07-27 12:51:30 -04:00
saito-hideki
e91ad2ab6c
Add Solaris support in hostname module
...
feature_pull_request: #1804
2015-07-25 23:32:55 +09:00
saito-hideki
b991a2708b
Add Solaris support in hostname module
2015-07-25 21:48:13 +09:00
Brian Coca
a2b713edad
Merge pull request #1790 from renard/allow-star-password-on-openbsd-2015-07-24
...
[user] Allow '*' as empty password.
2015-07-24 18:55:13 -04:00
KIKUCHI Koichiro
a3b9fb58bf
Fix service enabled check failure on FreeBSD
2015-07-24 21:05:16 +09:00
Sébastien Gross
349195e689
[user] Allow '*' as empty password.
...
If `password` is defined as `*` `useradd` or `usermod` returns an error:
msg: usermod: Invalid password: `*'
This works very well on Linux host to not define any password for a
user (mainly useful if your setup is only based on SSH keys for
auth). On OpenBSD this does not work, so we have to ignore the encrypted
password parameter if it defined as `*`.
2015-07-24 10:48:36 +02:00
fti7
6a872469fc
mount: Support for Check-Mode
2015-07-23 15:51:24 -04:00
Brian Coca
718fd1f891
prevent usless assignment of home
2015-07-18 23:28:41 -04:00
Brian Coca
045b8e8cff
Merge pull request #1733 from tersmitten/the-tilde-expansion-doesnt-work-with-userhome
...
The tilde expansion doesn't work with user.home
2015-07-18 23:26:20 -04:00
bambou
e04f75d872
Check if the gid is set
2015-07-18 17:53:02 +02:00
Mischa ter Smitten
0ca732baaf
The tilde expansion doesn't work with user.home
2015-07-15 12:00:23 +02:00
Brian Coca
8546744418
Merge pull request #1286 from 0tmc/freebsd_mount_fix
...
Use of proper fstab file on FreeBSD
2015-07-07 17:59:29 -04:00
Sean Chittenden
c57d70ad20
Fix group mod and group add for FreeBSD
2015-07-07 12:06:52 -07:00
Brian Coca
03d4805074
Merge pull request #1279 from no2a/devel
...
Not use "is" to compare strings
2015-07-04 16:00:05 -04:00
Brian Coca
328b6b5a39
Merge pull request #1454 from grossws/patch-issue-530
...
Escape spaces, backslashes and ampersands in fstab
2015-07-04 15:13:27 -04:00
Brian Coca
2b209f8065
Merge pull request #1642 from sivel/core-fixups
...
Core module fix-ups
2015-07-01 11:00:47 -04:00
Toshio Kuratomi
1dc5074602
Merge pull request #1651 from verm666/issue-1515
...
fix authorized_keys in check_mode
2015-07-01 07:52:48 -07:00
Matt Martz
b6b576abf6
Replaced tabbed indentation with spaces for group module
2015-07-01 09:39:19 -05:00
verm666
b00b3f2b3c
fix authorized_keys in check_mode
...
This change is in response to issue #1515 .
Original pull request #1580 .
The original problem is: in authorized_key module you have no idea about users
which will be created by Ansible at first run. I can propose next two ways to
solve this problem:
1. Combine modules system/user.py and system/authorized_key.py in one module
(so you will know everything about users in that module)
2. Use small workaround: add my commit and always provide 'path' parameter
for authorized_key module during runs with --check option.
2015-07-01 07:04:45 -07:00