Commit graph

47826 commits

Author SHA1 Message Date
Evgeni Golov
8d0c193b25 allow before/after diff to be NoneType (#62582)
when creating or deleting an object (e.g. via an API), before/after can
be `None` (or at least represented as such by the used library). to
avoid modules havig to do

    diff={'before': before or '', 'after': after or ''}

let's just convert `None` to an empty string that can be diffed properly
2019-09-20 15:47:18 -04:00
Will Thames
bb0fa0a622 k8s: apply no longer the default behaviour (#62632)
There are too many lingering uncertainties about the correctness of
apply behaviour. All tests seem to suggest it works, and it's definitely
performed well in real world application, but it may be a breaking
and unexpected change to default to apply

We will let apply bed in during 2.9 and allow people to opt in, we
may default to it in future (or not)
2019-09-20 08:22:42 -07:00
Major Hayden
cced1a3cd1 ec2_vpc_subnet: Rename resource_tags > tags (#62663)
Most of the AWS module documentation refers to `tags` and not
`resource_tags`. This patch updates the documentation to match
other AWS module documentation. 😉

Signed-off-by: Major Hayden <major@redhat.com>
2019-09-20 15:36:11 +01:00
Gonéri Le Bouder
5ecbe9cbbb vcenter provider: Only rely on VMWARE_TEST_PLATFORM
Until now, the vcenter provider was switching between `static` and
`govcsim` depending on the presence of the following configuration file:
`test/integration/cloud-config-vcenter.ini`.

This was not consistent with Worldstream, which we enable with the
`VMWARE_TEST_PLATFORM` environment variable.

We now only rely on `VMWARE_TEST_PLATFORM` to know which platform should be
used. `govcsim` is still the default, this to preserve the original
behaviour.

This commit also rename the following variables to be consistent with the rest
of the code base. It also ensures they are alway defined, even with `govcsim`:

- `VCENTER_HOSTNAME`
- `VCENTER_USERNAME`
- `VCENTER_PASSWORD`
2019-09-20 10:33:44 -04:00
Sandra McCann
170b4e63ff fixed options (#62605) 2019-09-20 09:08:47 -05:00
chashtag
7cfcf18a8c Update ovirt_vm.py (#62425)
* Update ovirt_vm.py
2019-09-20 09:40:14 -04:00
Sviatoslav Sydorenko
2969614c2c Fix link syntax and a typo in dev collections doc (#62650) 2019-09-20 09:36:23 -04:00
Andrey Klychkov
be9bf8cd15 postgresql: move CI test of *_publication, *_ext, *_slot to separate targets (#62646) 2019-09-20 12:47:13 +01:00
Mario Lenz
0c66e7ef10 VMware: Remove mentions of enable_vsan from vmware_cluster_ha example (#62616)
* VMware: Remove mentions of enable_vsan from vmware_cluster_ha example
* Add changelog fragment
2019-09-20 12:03:20 +05:30
Will Medlar
6541bb0315 pids: Search for process name matches in the cmdline (#59318)
* Also search for process name matches in the cmdline
* Return integer pids
* Use correct variable name
* Fix linter concerns
2019-09-20 12:00:25 +05:30
Arvind Shyamsundar
41bfd2bf0e Include computer_name in VM instance facts (#62566) 2019-09-20 12:16:58 +08:00
richardsonky
153a322f54 Master (#62626)
* Update win_package.ps1

Update Test-Path to use -LiteralPath instead of -Path to fix issue where powershell will not detect path with special characters such as '=' and '[]'.

* Update win_package.ps1

modified other instances of -Path and changed to -LiteralPath.  All except line L243 since it is a different function.

* added literal path to get-itemproperty
2019-09-20 13:25:47 +10:00
yanzhangi
2a206f0e4c update ce_bgp_af to fix bugs (#62589)
* update to fix bugs

* update to fix bugs
2019-09-19 22:34:11 -04:00
Gonéri Le Bouder
cee55ab718 mongodb_replicaset/test: properly kill the nodes
The `pids` module returns the list of the PID in a `pids` key.

This change ensures we correctly wait for the end of the previous mongod
instances before we start the next ones.

In addition, we remove an unnecessary `ignore_errors`.
2019-09-19 17:19:48 -04:00
Jordan Borean
85eba9d860 Fix test_galaxy failing test 2019-09-19 13:20:43 -07:00
Sandra McCann
7badeb6df0 [docs] split collections into user and dev guide sections (#62363)
* split collections into user and dev guide sections

* sentence case
2019-09-19 15:09:19 -05:00
Sandra McCann
6d35f9026f added networking porting guide info (#61999)
* added networking porting guide info

* Update docs/docsite/rst/porting_guides/porting_guide_2.9.rst

Co-Authored-By: Nathaniel Case <this.is@nathanielca.se>

* implemented review comments
2019-09-19 14:29:15 -05:00
John Mahowald
4116d263c4 Add missing gcp modules to gcp module defaults group (#57779)
* Add missing gcp modules to gcp module defaults group

Fixes #56324

* Add changelog fragment for #57779
2019-09-19 20:25:47 +01:00
Sloane Hertel
4cc4c44dd0
Add a representer for AnsibleUnsafeBytes (#62598)
* Add a representer for AnsibleUnsafeBytes

* changelog

* Add unit tests

Remove native string test until we have time to evaluate how this the function should work
Add non-ASCII characters to test cases

* Compare to the string on Python 2

Add a comment in the test about this behavior
2019-09-19 14:27:48 -04:00
Zim Kalinowski
c8e220a62e vm change to support specialized (#62586) 2019-09-19 09:45:24 -07:00
Nathaniel Case
9a43a8fcfc
Display leftover messages when shutting down. (#62431) 2019-09-19 10:37:14 -04:00
Andrey Klychkov
7b3d8431dd postgresql: move CI tests of *_tablespace, *_membership, *_idx to separate targets (#62575)
* postgresql: move CI tests of *_tablespace, *_membership, *_idx to separate targets

* postgresql: move CI tests of *_tablespace, *_membership, *_idx to separate targets, change formatting
2019-09-19 14:57:45 +01:00
Horst Gutmann
7047b66d34 Add examples for various inventory setups to the documentation (#62323)
* Add examples for various inventory setups to the documentation. This closes #12480.

* Update docs/docsite/rst/user_guide/intro_inventory.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/user_guide/intro_inventory.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update wording in inventory examples

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update wording in inventory examples

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Use code-block and rename groups in inventory setup examples

* Fix group name in inventory setup example

Co-Authored-By: Sandra McCann <samccann@redhat.com>
2019-09-19 09:32:04 -04:00
satunnainen
95525030e2 enables to set keys not present in existing config (#61607) 2019-09-19 07:14:26 -04:00
Josh Souza
875cc156c9 Remove notifications for joshsouza (#62443) 2019-09-19 11:53:36 +01:00
Andreas Olsson
70a33c3140 nsupdate: Don't mention the Microsoft DNS server (#62330)
Microsoft's DNS server uses GSS-TSIG to secure Dynamic DNS
updates. That is a Kerberos based form of TSIG neither supported by
the Ansible nsupdate module nor the underlying dnspython module.

Related to #57294 and #62238.
2019-09-19 11:45:53 +01:00
hyperized
ea73e0c43a Update BOTMETA.yml (#62482) 2019-09-19 11:40:14 +01:00
Xu Yuandong
7541dab1ef update to fix a bug. (#62417) 2019-09-19 05:15:48 -04:00
Zim Kalinowski
558ce6575d
modify vmss to support specialized (#62571) 2019-09-19 14:29:49 +08:00
Sumit Jaiswal
35463d45f4
Fix traceback empty config error to meaningful msg for IOS (#62538)
* fix empty config msg

* fix space

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-09-19 10:13:36 +05:30
Zim Kalinowski
054519920e
snapshot fix for backporting (#62559) 2019-09-19 11:42:08 +08:00
Will Thames
a684bb9f5b Ensure k8s apply works with check mode (#60572)
* Ensure k8s apply works with check mode

Update the new predicted object with fields from the previous object
before applying in check mode

Don't log output of `file` with `state: absent` on huge virtualenvs!

Fixes #60510

* Use openshift client fix to improve apply for check mode

Use new apply_object method to get a better approximation
of the expected object in check mode.

Requires released upgrade to openshift

* Add changelog fragment for k8s apply check mode fix

* Update changelogs/fragments/60510-k8s-apply-check-mode.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-09-19 05:30:31 +02:00
Toshio Kuratomi
bebb11b918 Disable setting of -s in shebang
RPM builds on Fedora and RHEL create a python shebang line with -s

This is not good for ansible since ansible has a lot of optional
features which need extra dependencies installed.  If the user installs
those extra dependencies to their home directory or to /usr/local then
the -s will keep them from being used.
2019-09-18 20:27:56 -07:00
Rohit
978def38d8
error message updated (#62536)
* error message updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test cases updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* error message updated

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-09-19 08:34:31 +05:30
Matt Clay
1c64dba3c9 Fix plugin names for collection plugins. (#60317)
* Fix plugin names for collection plugins.

Add an integration test to verify plugin __name__ is correct for collection plugins.

* Fix collection loader PEP 302 compliance.

The `find_module` function now returns `None` if the module cannot be found. Previously it would return `self` for modules which did not exist.

Returning a loader from `find_module` which cannot find the module will result in import errors on Python 2.x when using implicit relative imports.

* add changelog

* sanity/units/merge fixes
2019-09-18 17:47:56 -07:00
yanzhangi
cbe8271745 update ce_static_route to fix bugs (#62498) 2019-09-18 20:31:44 -04:00
Sam Doran
b7897e3a8d cron - Only run get_bin_path() once (#62554) 2019-09-18 19:04:26 -04:00
Jordan Borean
064e443ea5
psexec - Fix kerb and interactive support (#62556) 2019-09-19 08:41:02 +10:00
Matt Davis
d0c7b42e58
fix collection jinja2 cache issue (#62543)
* prevents premature lookup (and potential KeyError) of Jinja filter/test function cache that's not fully populated
2019-09-18 14:39:59 -07:00
Jordan Borean
bad338aca6
win_exec_wrapper - Be more defensive when trying to get output errors (#62376)
* win_exec_wrapper - Be more defensive when trying to get output errors

* Fix up property search
2019-09-19 06:53:56 +10:00
Jordan Borean
bf5b6695ec Add hint for config option priority (#62463)
* Add hint for config option priority

* Fix some spelling issues
2019-09-18 16:36:08 -04:00
Old Schepperhand
864928365e Improve dconf documentation to include conversion problems (#62316) 2019-09-18 16:04:44 -04:00
Jordan Borean
d16ee65ecd Add link to become plugins in become docs (#62462) 2019-09-18 15:53:16 -04:00
Marco Tulio R Braga
a4a216640f chore/doc-module: sts_assume_role.py (#62475)
Update `Example` section with with the correct module usage.
2019-09-18 15:50:34 -04:00
Jean-Frédéric
951a80c8b0 cron - Use the default crontab executable in cron and cronvar modules (#59765)
In some remote environments, the `crontab` executable is
overloaded with a custom executable, which typically does
some pre/post processing before forwarding to crontab.

Instead of using the hardcoded `/usr/bin/crontab`, this uses
the `get_bin_path` utility to locate the default crontab executable.
2019-09-18 15:35:06 -04:00
Rohit
b24f7d2800
vyosnoconfig tracebackfix (#62518)
* vyosnoconfig tracebackfix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* vyos noconfig tracebackfix test cases added

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* test/integration/targets/vyos_lldp_global/tests/cli/empty_config.yaml
2019-09-18 21:58:39 +05:30
chkp-orso
55f285a384 fix if equals error code if command not found (#62529) 2019-09-18 18:00:42 +02:00
chkp-orso
2232232b45 fix delete to pass the right parameters (#62525) 2019-09-18 20:59:59 +05:30
chkp-orso
cf8e84fc62 fix session_uid (#62523) 2019-09-18 20:38:31 +05:30
Jordan Borean
2e1c6a7839 Add fix for specifying current dir in collections_paths (#62478) 2019-09-18 08:04:22 -07:00