* Added storage modules and unit tests
Removed unnecessary file
Fixing pep8 issues
Adding reusable documentation to the data fragment file
Fixing issues reported by module validation in documentation
Fixed issues: 10549, 10553
Fixed unit tests
Added future imports and removed license from init py file
Resolved import issue reported by ansible sanity test
Fixed unit tests
Adding CPG management module
Fixing sanity test issues
Resolving line ending issues
Resolved import issue reported by ansible sanity test
Correcting the error message when resource is more than 31 char
Update hpe3par_cpg.py
Fix for defect 10556: Unable to modify volume. Persona not set
Fix for defect 10556: Unable to modify volume. Persona not set
Fixing pep8 changes
Fixed pep8 issues
Added more pep8 related fixes
Added more pep8 related fixes
Fixed rebase issue in cps test
Adding GPL3.0+ License (#7)
* Update hpe3par.py
* Update hpe3par_cpg.py
* Update hpe3par_cpg.py
Adding GPLV3+ only license
Fix anity test
Addressing review comments
Fixing undefined variable error
Addressed review comments and added more unit tests (#8)
Added maintainers
Fixed sanity test
Update test_hpe3par_cpg.py
Renamed the module as per the review comments (#9)
* Added maintainers
* Renaming the module to remove the vendor name from the module
* remove pep8 related issues
Modify the requirements to add version of 3par sdk
Review address (#10)
* Unit is no longer a different paramter in the task
* Fixing unit tests
* Taking into account the default values
Fixing issue with default values
fixing unit test
Adding more flexibility and checks to the size and it's units
Fixed pylint extra line issue
Fixing conflicts in BOTMETA.yml
Made changes according to the review comments
Updating ansible version
Refactored the code to move reusable method to module utils
Modified the GPLv3+ license text according to the review comments. Modified the module utils license to BSD
Corrected the BOTMETA entry. Fixed the pep8 issues
Fixing entries in BOTMETA.yml
Removed ansible version, renamed the version to address the name review comments
Reverting name change for module to revert test failures
Set size and raid type and now reuqired together based on the review comment
Fixed unit tests
Removing default value as raid and set size are now required together
Renaming the modules to ss_3par_*
Resolving the pep8 issues
Added storage modules and unit tests
Removed unnecessary file
Fixing pep8 issues
Adding reusable documentation to the data fragment file
Fixing issues reported by module validation in documentation
Fixed issues: 10549, 10553
Fixed unit tests
Added future imports and removed license from init py file
Resolved import issue reported by ansible sanity test
Fixed unit tests
Adding CPG management module
Fixing sanity test issues
Resolving line ending issues
Resolved import issue reported by ansible sanity test
Correcting the error message when resource is more than 31 char
Update hpe3par_cpg.py
Fix for defect 10556: Unable to modify volume. Persona not set
Fix for defect 10556: Unable to modify volume. Persona not set
Fixing pep8 changes
Fixed pep8 issues
Added more pep8 related fixes
Added more pep8 related fixes
Fixed rebase issue in cps test
Adding GPL3.0+ License (#7)
* Update hpe3par.py
* Update hpe3par_cpg.py
* Update hpe3par_cpg.py
Adding GPLV3+ only license
Fix anity test
Addressing review comments
Fixing undefined variable error
Addressed review comments and added more unit tests (#8)
Added maintainers
Fixed sanity test
Update test_hpe3par_cpg.py
Renamed the module as per the review comments (#9)
* Added maintainers
* Renaming the module to remove the vendor name from the module
* remove pep8 related issues
Modify the requirements to add version of 3par sdk
Review address (#10)
* Unit is no longer a different paramter in the task
* Fixing unit tests
* Taking into account the default values
Fixing issue with default values
fixing unit test
Adding more flexibility and checks to the size and it's units
Fixed pylint extra line issue
Fixing conflicts in BOTMETA.yml
Made changes according to the review comments
Updating ansible version
Refactored the code to move reusable method to module utils
Modified the GPLv3+ license text according to the review comments. Modified the module utils license to BSD
Corrected the BOTMETA entry. Fixed the pep8 issues
Removed ansible version, renamed the version to address the name review comments
Reverting name change for module to revert test failures
Set size and raid type and now reuqired together based on the review comment
Fixed unit tests
Removing default value as raid and set size are now required together
Renaming the modules to ss_3par_*
Resolving the pep8 issues
Update lib/ansible/modules/storage/hpe3par/ss_3par_cpg.py
Co-Authored-By: farhan7500 <farhan7500@gmail.com>
Update lib/ansible/modules/storage/hpe3par/ss_3par_cpg.py
Co-Authored-By: farhan7500 <farhan7500@gmail.com>
Fixed rebase issue
Fixed rebase issuein BOTMETA.yml
* Modified the documentation based on the review comments
* Fixed the pep8 sanity issue
* Moved the doc fragment file based on latest changes
* Reverting inadvertent rebase changes
* Fixed inadvertent change during rebase
* BOTMETA: Restart ovirt labeling
1. Creates ovirt team
2. Labels following with ovirt label
- $modules/cloud/misc/ovirt.py
- $modules/cloud/ovirt/
- contrib/inventory/ovirt4.py
- $module_utils/ovirt.py
* Fix bot complains about non-existent team virt
* Added forgotten ingnores for team virt
Signed-off-by: Martin Perina <mperina@redhat.com>
* Correct the ignored list
So this appears to be the correct fix.
As per Community Core Meeting 2019-02-14 consensus, remove this
section of the bug report issue template.
https://github.com/ansible/community/issues/436
Signed-off-by: Adam Miller <admiller@redhat.com>
* Move docker_ module_utils into subpackage.
* Remove docker_ prefix from module_utils.docker modules.
* Adding jurisdiction for module_utils/docker to $team_docker.
* Making docker* unit tests community supported.
* Linting.
* Python < 2.6 is not supported.
* Refactoring docker-py version comments. Moving them to doc fragments. Cleaning up some indentations.
* gitlab_group: refactor module
* gitlab_user: refactor module
* gitlab_group, gitlab_user; pylint
* gitlab_project: refactor module
* gitlab_group, gitlab_project, gitlab_user: Enchance modules
- Add generic loop to update object
- Enchance return messages
- PyLint
* gitlab_runner: refactor module
* gitlab_hooks: refactor module
* gitlab_deploy_key: refactor module
* gitlab_group: enchance module and documentation
- Enchange function arguments
- Add check_mode break
- Rewrite module documentation
* gitlab_hook: enchance module and documentation
- Rewrite documentation
- Enchance function parameters
- Rename functions
* gitlab_project: enchance module and documentation
- Rewrite documentation
- Enchance function parameters
- Add try/except on project creation
* gitlab_runner: enchance module and documentation
- Rewrite documentation
- Fix Copyright
- Enchance function arguments
- Add check_mode break
- Add missing function: deletion
* gitlab_user: enchance module and documentation
- Rewrite documentation
- Enchance function parameters
- Add check_mode break
- Add try/except on user creation
* gitlab_deploy_key, gitlab_group, gitlab_hooks, gitlab_project,
gitlab_runner, gitlab_user: Fix residual bugs
- Fix Copyright
- Fix result messages
- Add missing check_mode break
* gitlab_deploy_key, gitlab_group, gitlab_hooks, gitlab_project, gitlab_runner, gitlab_user: pylint
* gitlab_runner: Add substitution function for 'cmp' in python3
* unit-test: remove deprecated gitlab module tests
- gitlab_deploy_key
- gitlab_hooks
- gitlab_project
Actually, they can't be reused because of the modification of the way that the module communicate with the Gitlab instance. It doesn't make direct call to the API, now it use a python library that do the job. So using a pytest mocker to test the module won't work.
* gitlab_deploy_key, gitlab_group, gitlab_hooks, gitlab_project, gitlab_runner, gitlab_user: add copyright
* gitlab_deploy_key, gitlab_group, gitlab_hooks, gitlab_project, gitlab_runner, gitlab_user: Support old parameters format
* module_utils Gitlab: Edit copyright
* gitlab_deploy_key, gitlab_group, gitlab_hooks, gitlab_project,
gitlab_runner, gitlab_user: Unifying module inputs
- Rename verify_ssl into validate_certs to match standards
- Remove unused alias parameters
- Unify parameters type and requirement
- Reorder list order
* gitlab_deploy_key, gitlab_group, gitlab_hooks, gitlab_project, gitlab_runner, gitlab_user: Unifying module outputs
- Use standard output parameter "msg" instead of "return"
- Use snail_case for return values instead of camelCase
* validate-module: remove sanity ignore
* BOTMETA: remove gitlab_* test
- This tests need to be completely rewriten because of the refactoring
of these modules
- TodoList Community Wiki was updated
* gitlab_user: Fix group identifier
* gitlab_project: Fix when group was empty
* gitlab_deploy_key: edit return msg
* module_utils gitlab: fall back to user namespace is project not found
* gitlab modules: Add units tests
* unit test: gitlab module fake current user
* gitlab_user: fix access_level verification
* gitlab unit tests: use decoration instead of with statement
* unit tests: gitlab module skip python 2.6
* unit tests: gitlab module skip library import if python 2.6
* gitlab unit tests: use builtin unittest class
* gitlab unit tests: use custom test class
* unit test: gitlab module lint
* unit tests: move gitlab utils
* unit test: gitlab fix imports
* gitlab_module: edit requirement
python-gitlab library require python >= 2.7
* gitlab_module: add myself as author
* gitlab_modules: add python encoding tag
* gitlab_modules: keep consistency between variable name "validate_certs"
* gitlab_modules: enchance documentation
* gitlab_runner: fix syntax error in documentation
* gitlab_module: use basic_auth module_utils and add deprecation warning
* gitlab_module: documentation corrections
* gitlab_module: python lint
* gitlab_module: deprecate options and aliases for ansible 2.10
* gitlab_group: don't use 'local_action' is documentation example
* gitlab_module: correct return messages
* gitlab_module: use module_util 'missing_required_lib' when python library is missing
* gitlab_module: fix typo in function name.
* gitlab_modules: unify return msg on check_mode
* gitlab_modules: don't use deprecated options in examples
So many reports of missing modules could be solved
more quickly with the info from `python_requirements_facts`
Replace the legacy issue template with a link to the
new interface
* * docker_node: New module for operations on Docker Swarm node
* Shared code for Docker Swarm modules
* * docker_node: Removed the attribute `force` as it is not used for any operation
* docker_node_facts: Update module to use client class AnsibleDockerSwarmClient instead of AnsibleDockerClient
* docker_node_facts: List of nodes can be provided as input, inspect all registered nodes or manager host itself
* docker_node: Update in method name called from AnsibleDockerSwarmClient
* docker_node: Additional method to shared module to get formatted output list of registered nodes
* docker_node: Additional method to shared module to get formatted output list of registered nodes
* docker_node: removed state list (featue moved to docker_swarm_facts)
* docker_node: Node labels manipulation (remove, replace, merge)
* module_utils/docker_swarm: Updated output for nodes list - adding swarm leader flag
* docker_node_facts: update in input and return values, update in documentation section
* docker_node: Updated operations on labels, tracking if change is required
* docker_node: Updated documentation, parameter 'hostname' is now required
docker_node_facts: Updated documentation
* * Failing Ansible tasl if not run on swarm manager - code cleanup
* * docker_node: Remove the 'action' list from output
* * docker_node: variable name change to be align with Python best practice, BOTMETA.yml update
* * module_utils/docker_swarm.py: fix for incorrect fail() action
* docker_node: documentation and code small updates
* * docker_node: revised labels manipulation
* docker_node_facts: Reverting to repository version, moving this change to separate PR
* * docker_node: Documentation update
* * docker_node: Update to node availability and role modification
* * docker_node: Update to check_mode handling
* * docker_node: Code cleanup
* docker_node_facts: Code cleanup
* docker_node_facts: Adding back the module with only update to use AnsibleDockerSwarmClient instead of AnsibleDockerClient
docker_node: cosmetic code changes
BOTMETA: updated on $team_docker
* docker_node: BOTMETA update
* promote doc_fragments into actual plugins
change tests hardcoded path to doc fragments
avoid sanity in fragments
avoid improper testing of doc_fragments
also change runner paths
fix botmeta
updated comment for fragments
updated docs
* ebs_optimized is not suboption of 'network'
* Add Shaps as ec2_instance maintainer
* Added workaround-backward compatible check for ebs_optimized
* Added ebs_optimized test
* CI fixes, dynamic select of ENA-enabled AMI
* netbox_device module
* Add init.py to each directory
* Fixed a few of the shippable failed tests
* No need for import pynetbox in netbox_utils-removed, changed syntax for set
* A bit more cleanup
* Fixed the 'data' to have suboptions
* Fixed formatting for device_role
* Attempting to fix shippable errors
* Final testing and updated documentation
* Fixed return type and removed testing result files
* Updated some returns to be a list to keep 'meta' formatting consistent
* Updated module to standardize the meta return type
* Updated short_description and added David Gomez as author
* Updated short_description, added David Gomez as author, added module direcotry to BOTMETA.yml
* Updated data type to dict and removed JSON from netbox_utils
* Fixes#18568
* Commit of the first set of utm modules
* added documentation line for module_utils file
* removed other utm modules for the first pr
* added maintainers to botmeta
* implemented fixes for shippable
* fixed whitespaces and newlines in included doc fragment
* added types and choices to documentation
* fix for E501
* Implemented change requests
* changed utm_utils license to BSD
* changed str() to to_native()
* added a status state that will just return information about my object
* renamed state 'status' to 'info'
* added team_e-spirit to botmeta and added the team as maintainer for the utm_utils
* only return a result if the lookup was not empty. Do not return a null result
* removed info state
* added boilerplate
* made preparation for info-only modules
* Adding a basic get lookup for rabbitmq.
* Always return a list
* If content type is JSON, make accessible via dict.
* Fixed incorrect json.loads variable and missing raise
* Change to document returned data
* Fixed pep8 issues
* Adding integration testing
* Moving lookup intgration tests to new target
* New rabbitmq lookup plugin (#44070).
* New rabbitmq lookup plugin (#44070).
* PR review feedback updates
* Testing pika is installed
* Minor mods to tests
* Check if connection is already closed or closing
* Updated tests and connection testing
* PR review feedback updates
* PR review include ValueError in AnsibleError output
* Suggesting to use set_fact when using returned variable more than once.
* Cleaned up some tests, added some notes and handling connection closure on some exceptions.
* Removed finally statement and added some additional error handling.
* Added some additional error handling.
* PR review updates.
* Additional integration tests and removing return in finally
* Updated version
* Changing back to running tests on ubuntu.
* Additional tests
* Running tests on Ubuntu only
* Fixing syntax error
* Fixing ingtegration tests and a string/byte issue
* Removed non-required test and fixed BOTMETA
* Trying to fix integration test failure on ubuntu1404
* Some issues occured when handling messages from the queue with to_native. Switching to to_text resolved the issues.
* Renaming channel to queue (thanks dch). Disabling trusty tests.
plugins/ is COMMUNITY
Set sensible defaults for directories
support:network for the platforms that we Networking SUPPORTS,
everything else is COMMUNITY
Mark other support:network (ansible-connection, etc)
Infoblox is support:core
contrib/ by definition should be support:community
Remove duplicated labels
Make yamllint happy(ier)
Adds sanity test to ensure BOTMETA.yml is valid
Add lwm, an active user of the linode module to the maintainer list.
Removes myself from the linode maintainer list as I no longer use the Linode module in an occupational capacity and unfortunately don't foresee having much time to devote to cultivating the health of the module(s) in the coming future.
* Improve GitHub templates
The existing templates are basically a copy for each type of issue (bug,
feature, doc) whereas we can make the template more specific to the task
at hand.
This PR includes:
- More specific sections depending on the type of issue
- More concise and direct instructions (NO NEED FOR FRUSTRATION CAPS!)
- Single-line comments (no need to guide people to avoid wrong edits)
- Improved paste area
- Better headings/titles
- No 'Summary' title for PRs (so commit information is placed correctly)
This PR would require some improvements to Ansibot.
* Remove controversial Ansibot stuff
Make it easier to get the first batch merged.
* Restore ISSUE_TEMPLATE.md
* Incorporate reviewer suggestions
* Make OS / ENVIRONMENT doc-related
* Rephrase Ansibot-related message
This PR includes:
- Removal of maintainers that are listed as author in the module
- Removal of entries that do not extend the original author list
- Move ignored-statement to namespace/directory (where useful)
- In some cases, fix the authors-list or add missing github id
We end up with a list of exceptions/additions and a large set of
namespace/directory maintainers or team of maintainers.
Some entries could be further improved by discussing with some
maintainers.
* Common Rest Module using httpapi transport
* comparing json objects
* platform independant Rest Api
* FTD rest module
* Remove FTD module which will be committed later from cisco team
* remove debug code
* remove common rest module
* fix shippable errors
* Add notification users
* more shipable errors
* Create a template for security related bugs
This template serves as a redirect for people who might not know where to open security related issues. It guides them to email security@ansible.com instead of opening an issue here.
* Update security_bug_report.md
* Implement initial RouterOS support
* Correct matchers for license prompts
* Documentation updates & mild refactor
* Remove one last Cisco function
* Sanity test fixes
* Move imports to the beginning
* Remove authorize property
* Handle ANSI codes
* Revert to_lines function
* CR fixes
* test(routeros): add unit tests
* Added another test (with ANSI colors and banner in fixture).
* Ignore CRLF line endings in system_package_print file
* fix: review by ganeshrn
* New ansible module netconf_rpc
* add integration test for module netconf_rpc
* pep8/meta-data corrections
* usage of jxmlease for all XML processing
separation of attributes "rpc" and "content"
* removed unused imports
improved error handling
* fixed pep8
* usage of ast.literal_eval instead of eval
added description to SROS integration test for cases commented out
* Get the str value of xmlrpc.client.DateTime
* get_all_records should be used instead of get_all
* Facts returned with 'ansible_facts'
* Remove some redundant code
* Add cheese as maintainer
* Add changelog entry
* add pytest_cache to gitignore
* onepassword lookup plugin
* fix linter/style test complaints
* second pass at making pycodestyle happy
* use json module instead of jq
* update copyrights, license & version added
* fix python2 compatibility
* doh. fix spacing issue.
* use standard ansible exception
* remove potentially problematic stdin argument
* actually call assertion method
* add support for top-level fields
* make vault uuids pedantically consistent in fixture
* fix new style issues
* ability specify section & correct case handling
* improve error handling
* add onepassword_raw plugin
* Add maintainer info
* Move common code to module_utils/onepassword.py
* Load raw data JSON data for easier use in Ansible
* Put OnePass class back inside lookup plugin
There is no good place for sharing code across lookups currently.
* Remove debugging code in unit tests
* Patche proper module in raw unit tests
* Add changelog entry
Co-authored-by: Scott Buchanan <sbuchanan@ri.pn>
Too much to do, too little time. Happy to remain on the WG,
be consulted for advice by the WG, and retain the notifications
for my existing authorships and the remaining notifications
(and have added some more explicit ECS notifications)
* Adding exos_command cli_conf module
* fixing documentation, indentation and metadata_version
* removing doc fragmentation and adding required import
* removing unnecessary code and including company name on short_description
* updating BOTMETA.yml with exos module information
* Adding slx_command module and supporting module_utils.
This commit adds the slx_command module and tests as well as the
required slxos module_utils.
* Update copyright in header
* Adding missing module init
* Cleaning up shebangs/licensing.
* Incorporating feedback
Removing reference to `waitfor` alias in `slxos_command` module.
Adding `Extreme Networks` to `short_description` of `slxos_command` module.
* Adding cliconf tests
* Fixing 3.X tests
* Adding docstrings to test methods for slxos cliconf tests
* Adding slxos terminal tests
* Adding slxos module_utils tests
* Adding Extreme Networks team members to BOTMETA.yml
* Clean up vmware BOTMETA
This removes everything that's already part of the module docs. So
basically the BOTMETA file only extends the information from the module.
* Updated author information and copyright statement
Don't use different labels for docs, that's what is:pr and is:issue is
for.
Discussed and approved by dharmabumstead
Makes it easier to do label:docs label:networking to find all issues
and PRs
This PR includes:
- Further cleanup of BOTMETA.yml
- Cleanup of author github handles
- Use of proper booleans
- One-line license statement
- Copyright format statement
- Smaller cleanups
* keycloak_clienttemplate
* BOTMETA maintainership for identity/keycloak namespace
* fix superfluous blank line
* catch ValueError when trying to decode JSON
* further documentation for protocol mappers and some checks
* whitespace fixes, YAML fixes
* remove state: dump, update argument_spec and documentation with suboptions
* add documentation for realm option
* document aliases for auth_keycloak_url, auth_username, and auth_password (i.e. url, username, and password)
* remove bearer_only, consent_required, standard_flow_enabled, implicit_flow_enabled, direct_access_grants_enabled, service_accounts_enabled, public_client, and frontchannel_logout from module options.
* adds two new infoblox lookup plugins
* nios - lookup plugin to return nios objects to the playbook
* nios_next_ip - lookup plugin to return the next avaiable ip address
* adds some additional examples to nios lookup
* fix up pep8 failures
* updates in response to review comments
* Imported lookup plugin from Role
* Plugin cleanup, including:
* Use existing Python YAML parsing
* Remove environment variables as connection options
* Added initial debugging information
* Reworked the lookup plugin using the Python Request library. As it's available through Ansible, it makes communication with Conjur much more straight forward.
* Removed un-used libraries
* Fixed linting issues
* Standardized output on `format` and insure it works for 2.6, 2.7, and 3.x.
* Use quote_plus from the six library for improved python 2/3 behavior.
* Refactored identity & configuration to prefer user's file. This also includes a refactor to remove an un-needed dictionary merge method.
* Removed `requests` in favor of `ansible.module_utils.urls`.
* Refactored netrc loading to warn if host is not present.
* Tests and a refactor to support easier testing.
* Added reference to website
* Fixed two linting errors
* Fixed an extra line found by linting
* Updated file write to use binary to insure config files are written correctly
* Resolved linting issues
* Refactored config & identity loading to take advantage of plugin options
* Cleanup a bunch of small items caught by linting
* Removed extra line caught by linting
* Swapped in pytest and added some tests with mocked network responses
* Pushing to see if this approach works better...
* Refactored be open_url mocking based on feedback
* Fixed a couple linting issues & refactored mocking into each method to attempt to resolve a failing test
* Use a generic MagicMock for python 2.6
* Fixes doc typo
require -> required
* Use `type: path` in identity_file and config_file
Also removes `expanduser` calls below (which will now be called automatically on
paths.)
* Defines maintainers for conjur_variable plugin
* BOTMETA.yml:
** defines $team_cyberark_conjur as maintainers of Conjur Variable plugin
** adds myself and @jvanderhoof to that team
* Adds URLs to relevant documentation for Conjur Variable lookup plugin
* Clarifies "the server," "the machine" -> "controlling host"
The machine identity used is that of the Ansible controlling host, not any
server being provisioned or instructed. This documentation change aims to make
that relationship clear.
* Adds response code to exception message on authentication failure
* Enhances exception messages to specify the controlling host
These error messages are less likely to confuse a user as to which machine is
associated with the files, identities, and configurations being described.
* Adds ANSIBLE_METADATA for Conjur variable lookup plugin
* npm module compatible with npm5
Uses the `--long` flag in `npm list` to get the `missing` key back.
* npm: add integration tests
* npm: test the module with npm 4 as well
* Remove debug tasks, use variables
* Use tests instead of filters
* Adds xcambar as a maintainer of the npm module
* add lib/ansible/plugins/connection/lxd.py maintainer in BOTMETA.yaml
Signed-off-by: Adam Miller <admiller@redhat.com>
* github nick change for trstringer on team_azure in BOTMETA
Signed-off-by: Adam Miller <admiller@redhat.com>
* Mellanox OS name change: MLNXOS changed to ONYX
Signed-off-by: Samer Deeb <samerd@mellanox.com>
* Fix alphabetical order of modules metadata
Signed-off-by: Samer Deeb <samerd@mellanox.com>
* filesystem: list used tools
* filesystem: btrfs and reiserfs don't support resizing
* filesystem: list supported filesystems
use formatting functions and 'filesystem' instead of 'file system'
* filesystem: PEP8
* filesystem: remove useless calls to module.boolean
* filesystem: fail when the requested action isn't implemented
* filesystem: resizefs: list supported FS rather than unsupported
* filesystem: refactor
* filesystem: add integration tests
* filesystem: allow to use image file with 'dev' param
* filesystem: test resizefs (ext2/3/4 filesystems only)
* filesystem: Btrfs, handle older version than v0.20-rc1
* filesystem: use loop keyword (integration tests)
* filesystem: new test, check when another filesystem already exists
* filesystem: add myself as a maintainer
* filesystem: fix tests as filters
