Commit graph

25078 commits

Author SHA1 Message Date
Brian Coca
50b40c47df aws_ec2 Implement the missing 'region discovery' (#51333)
* aws_ec2 Implement the missing 'region discovery'

  fixes #45288

  tries to use api as documented (which seems to fail in latest boto3 versions)
  and fallback to boto3 'hardcoded' list of regions

* fixes and cleanup, add error for worst case scenario

* fix tests, remove more unused code

* add load_name

* acually load the plugin

* set plugin as required

* reverted test changes, removed options tests

* fixes as per feedback and cleanup
2019-01-29 14:59:38 -06:00
Brian Coca
3ba3af5058
toggle for stripping empty shell/command output (#51342)
* toggle for stripping empty shell/command output

  fixes #45367

* Update lib/ansible/modules/commands/command.py

Co-Authored-By: bcoca <bcoca@users.noreply.github.com>
2019-01-29 15:55:38 -05:00
bverschueren
369076a1a4 Fix gcp utils dict replace (#51426)
* fix reference before assignment of new_item if item is plain string

* fix KeyError if managed_zone is plain string
2019-01-29 15:52:31 -05:00
Sam Doran
b9561842c8 Clarify use of variables in content parameter in copy module (#50940) 2019-01-29 15:36:06 -05:00
Will Thames
23b5599244 Add k8s module_defaults group and document (#51093)
It makes sense to use module_defaults with k8s modules, and thus
have a k8s module_defaults group.
2019-01-29 14:23:27 -06:00
Brian Coca
2b1b4db04d added docs for sleep/systemd interaction (#51336)
fixes #22430
2019-01-29 15:19:29 -05:00
Adam Miller
61ed229732 dnf load substitutions from installroot (#51206)
Fixes #51059

Signed-off-by: Adam Miller <admiller@redhat.com>
2019-01-29 15:10:53 -05:00
Hasegawa Takuya
109ef8c79d add example into os_server for server group (#51375)
* add example for server group
2019-01-29 13:42:29 -06:00
Dag Wieers
b083edbfe0 HP-UX: Fix ansible_pkg_mgr to use swdepot (#51411)
* HP-UX: Fix ansible_pkg_mgr to use swdepot

* Revert to use /usr/sbin/swlist
2019-01-29 13:59:43 -05:00
Ahmed Hussein
470dd9a0b2 update git.py (#51017)
* update git.py

clone option description was wrong 

+label: docsite_pr

* Update lib/ansible/modules/source_control/git.py

Co-Authored-By: ahadel <ah.adel2@gmail.com>
2019-01-29 13:34:38 -05:00
Dag Wieers
3b27b29994 AIX: Add ansible_pkg_mgr to installp (#51410) 2019-01-29 10:51:55 -05:00
Richlv
901ae2333e acknowledge operations are update operations now (#51304)
Acknowledge operations are update operations since Zabbix 4.0

+label: docsite_pr
2019-01-29 09:51:18 -05:00
Chris Archibald
971cea8c5a removed version line 2019-01-29 14:05:08 +00:00
Chris Archibald
d897ff7bf2 Updates to ontap_user 2019-01-29 14:05:08 +00:00
Nilashish Chakraborty
77303d72ab
Add new module - junos_ping (#50711)
* WIP junos_ping

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Added junos_ping module

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Minor changes

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Minor changes - 2

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix CI

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Initial tests

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* WIP tests

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix spaces

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fixed unit tests

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Removed unused print statements

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Removed unused print statements

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Update license template

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fixed Review Comments

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-01-29 15:36:12 +05:30
vaneuk
844e194aa4 changed interface config blocks parsing logic (#50340) 2019-01-29 04:42:31 -05:00
Ganesh Nalawade
8f5cd049d6
Allow check_mode with supports_generate_diff capability in cli_config (#51384)
* If network cliconf support `supports_generate_diff` in
  that case diff between running and cnadidate config
  is generated within Ansible and if check_mode is enabled
  in that case return only diff without actually invoking
  edit_config()
2019-01-29 12:00:39 +05:30
Trishna Guha
f712e86728
Add multiline config example in cli_config docs (#51413)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-01-29 10:46:16 +05:30
Dag Wieers
870525d762 PSRP: Add read_timeout connection parameters (#46850)
* PSRP: Add read_timeout connection parameters

* Changed debug() into warning()

* Only expose when read_timeout is not set
2019-01-29 14:02:53 +10:00
Tad Merchant
71ef69d51f check elb type in compare_subnets for elbv2 (#50203)
* Add check for elb type to fix difference between NLB and ALB AZ return structure

Fixes #49558

* Fix spacing for pep8 (hopefully) compliancE

* use empty array default instead of loadbalancer type detection

hat tip briantist

* spacing is probably important.
2019-01-29 13:28:39 +10:00
Dag Wieers
d8a0e1a9b7
aci_aaa_user: Fix changing user description (#51408)
This fixes a reported problem with the aci_aaa_user module.
2019-01-29 03:16:58 +01:00
Mariusz Mazur
3f4ca18e7b k8s: fix handling exceptions for certain modules (#51386) 2019-01-29 09:11:22 +10:00
Chanwit Kaewkasi
c6b3f2c848 change the default value of user to null (#51376)
Change the default value of user from root to null to conform the current Docker behavior and the current Ansible documentation.
2019-01-28 15:38:02 -05:00
Chris Archibald
cc618b00a5 changes to cifs_server 2019-01-28 20:34:56 +00:00
Chris Archibald
0ab5b765ec Rewrite of Na_ontap_job_schedule and new options (#49507)
* New options, and rewrite

* add module
2019-01-28 20:30:59 +00:00
Chris Archibald
5cc34af927 ucadapter rewrite and unit test (#49497)
* ucadapter rewrite

* update skip line
2019-01-28 20:29:56 +00:00
Thomas O'Donnell
2e4b579eb3 Update postgresql_lang connection methods (#49221)
Have added some extra arguments to the postgresql_lang module to allow
configuring an SSL connection to the postgresql server and explicit
support for connecting via a unix socket. The arguments and method used
here for the connection are the same as used by the postgresql_schema
module.
2019-01-28 15:14:09 -05:00
Jordan Borean
a259b810ad
Ansible.Basic - make choices validate case insensitive (#51203)
* Ansible.Basic - make choices validate case insensitive

* fix win_certificate_store tests
2019-01-29 05:42:01 +10:00
Mattias Lindvall
c34f85c788 Python3 fix: Decode output from popen in iocage connection (#41868)
* decode output from popen in iocage connection

* use ansibles to_native instead of stdlibs decode
2019-01-28 11:34:39 -05:00
Matt Martz
134b77961b
Add inject_ovf_env functionality for vmware_deploy_ovf (#51074)
* Add functionality to set hidden properties. Fixes #50299

* Add inject_ovf_env functionality

* Add xml declaration

* Revert "Add functionality to set hidden properties. Fixes #50299"

This reverts commit 4b41bb7520.

* Add changelog fragment

* Minor changes

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-01-28 09:55:21 -06:00
Kairo Araujo
55f0cfb2b8 New module: installp for AIX packages (#30238)
* Included module installp for AIX packages

This module works with installp AIX packages.
With this module is possible manage (install and remove) native
AIX packages using simple playbooks.

* Included module installp for AIX packages

This module works with installp AIX packages.
With this module is possible to manage (install and remove) native
AIX packages using simple playbooks.

* Fixed variable for installp parameters and docs

Followed the comments for merge
- changed variable for installp params
- doc for name and multiple packges using comma

* Replaced manual split to a list according argument_spec

Changed manual split for module.params["name"] to argument_spec

* Fixed PEP8 space after operator

Fixed PEP8 space after operator

* improved package verification and pep8

- improved package/fileset verification on AIX before to take
actions to remove or install
- Applied PEP8 and non-written conventions
- better comments and documentation

note: even If the package is already installed, even the
package/fileset is new, the module will not install it.
On AIX it is not recommended because it can break your
OS version with missen filesets.

* applied single/double quotes convention.

applied single/double quotes convention.

* Package name 'all' allowed as AIX command line

- Allowed use 'name'  as all such as AIX allows
- Removed 'global' varible regarding licence that is used
only by install()

* Documentation format issue

E302 DOCUMENTATION is not valid YAM

* Required (cosmetic) changes and improvements

* Small changes

* Silly PEP8 fixes

* Fix underscore variable
2019-01-28 16:29:46 +01:00
Nilashish Chakraborty
92b0cd8e0e
Add more return values to *_config modules (#50702)
* Add more return values to *_config modules

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add more rv

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Exclude from cli_config docs for now

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add new rv docs for junos_config

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix CI errors

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Support date time for configurable backup path

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Change logic based on configurable path

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Remove unwanted import

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix docs

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add filename rv

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Change dosc filename rv

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Make new rv code more readable

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-01-28 20:49:56 +05:30
Dag Wieers
b595228983
mso_stae_contract: Add EPG contracts (#51383)
This module creates EPG contracts in schema templates.
2019-01-28 14:37:30 +01:00
Nathaniel Case
9336281a60
Standardize cliconf get_capabilities (#51147)
* Standardize cliconf get_capabilities

* Check for capabilities before querying them

* Try to be more helpful when unexpected things are found in get_capabilities

* Add flags param to get_config for compatibility
2019-01-28 08:24:44 -05:00
Dag Wieers
86c3f14972
mso_st_deploy: Deploy a schema template (#51379)
This new module deploys a schema template to sites.
2019-01-28 12:55:29 +01:00
Zim Kalinowski
2bb8eea413 Adding mysql configuration facts module (#45075) 2019-01-28 16:36:23 +08:00
Nilashish Chakraborty
69dd03d472
ios_user: Add support for multiple sshkeys (#51173)
* Add support for multiple sshkeys

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix CI

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add the keys at on go

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Update tests

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-01-28 13:44:15 +05:30
Karsten Jakobsen
99a4a3dc33 VMware: New module vmware_vm_host_drs_rule (#50651)
* Added new vmware module for creating DRS VM-HOST rules Host groups in a given cluster
* Fixing punctuation in lib/ansible/modules/cloud/vmware/vmware_vm_host_drs_rule.py
* Added better Docstring
* Better messaging and documentation. Removed unused lib
* Added operation to determine create or update msg
* Fixed class params to only take module. This is less error prone
* Bugfix, undefined names
2019-01-28 06:15:45 +01:00
Zim Kalinowski
be859a9f8e
Automatically removing all resources allocated by VM (#50652) 2019-01-28 12:27:32 +08:00
Daniel Speichert
1a105a99dc hpilo_boot: fix module doc to match code and logic (#51360)
* hpilo_boot: fix module doc to match code and logic

There is no explicit nor implied value for media.
In fact, not choosing media makes perfect sense.

* Remove ignored sanity test failure
2019-01-27 21:17:29 +01:00
Hannes Ljungberg
72a44e144a docker_swarm_service: Compare image by digest (#51134)
* Compare image by digest

* Add changelog fragment

* Fix version check

* Remove unused import

* Add note about image resolving

* Don’t overwrite image

* Fix documentation error

* Add resolve_image option

* Add version_added

* Remove whitespace

* Remove unused attribute

* Remove unused attribute
2019-01-27 11:48:16 -05:00
Samuel Carpentier
6846152c46 New module: tower_notification (#50512)
* New module: tower_notification

* Fix CI check failures

* Add integration tests and extend examples

* Add missing required field for deletion tests and examples

* Add missing required field for deletion tests and examples

* Set port type to int

* Add missing field for Slack notification

* Add missing field types for IRC notification

* Update module documentation

* Correct field name and type for IRC notification

* Uniformize 'targets' field

* Uniformize 'targets' field
2019-01-27 16:28:49 +00:00
Hannes Ljungberg
b426daa064 docker_swarm_service: Remove root as default user (#51110)
* Remove root as default user

* Add changelog fragment

* Add deprecation documentation

* Tweak user default docs for docker_swarm_service

Co-Authored-By: hannseman <hannes@5monkeys.se>

* Tweak user default deprecation docs

Co-Authored-By: hannseman <hannes@5monkeys.se>
2019-01-27 16:26:41 +00:00
Hannes Ljungberg
ee39853426 docker_swarm_service: Fix endpoint mode idempotency (#51232)
* Fix endpoint mode idempotency

* Remove newline
2019-01-27 09:06:09 -05:00
Nerijus Baliūnas
ffb2e30786 fix debug msg in example (#51361)
See ansible#33984.
2019-01-26 19:27:12 +00:00
Anatoly Pugachev
88dee04f66 Prefer to use gmake (if available) on non linux OS (#51294)
* Prefer to use gmake (if available) on non linux OS

Fixes #26187

* Small cosmetic changes
2019-01-26 15:28:55 +01:00
Richlv
d2eb7a6cc1 Document trigger_severity values (#51331)
* Document the valid values for trigger_severity.
* Minor typo fix.

+label: docsite_pr
2019-01-26 07:17:39 -05:00
Dusan Matejka
2133f0821a zabbix_template: Fixed interactions between options and data within JSON object (#51222) 2019-01-26 13:15:32 +01:00
Dag Wieers
73636175da
MSO: Refactor modules to common structure (#51354)
This PR includes:
- Various fixes to jsonpatch interface
- Added seealso: and notes: to docs
- Various improvements to docs
- A set of bugfixes found during integration tests

Full integration tests follow.
2019-01-26 03:48:13 +01:00
Brian Coca
9a1c291d01 add toggle for host pattern mismatch behaviour (#51199)
* add toggle for host pattern mismatch behaviour

	fixes #40030

* fix
2019-01-25 16:00:28 -05:00