Commit graph

3772 commits

Author SHA1 Message Date
Michael DeHaan
247d688c13 Merge pull request #6233 from garethr/aws-autoscaling-groups
Added modules to manage ec2 autoscaling groups
2014-03-11 10:15:40 -05:00
Michael DeHaan
297b048d0e Fix other reference to APT_ENV_VARS. 2014-03-11 10:47:53 -04:00
Michael DeHaan
c09d4b1c7a Update apt module so that environment variables are set correctly since not going through shell. Very sorry folks, it will be addressed. 2014-03-11 08:39:28 -04:00
Michael DeHaan
0f962dba14 Missing comma in argument spec. 2014-03-10 19:37:34 -04:00
James Tanner
ba0fec4f42 Force command action to not be executed by the shell unless specifically enabled 2014-03-10 16:13:30 -05:00
James Cammarata
9730157525 Validate SSL certs accessed through urllib*
* Adds another module utility file which generalizes the
  access of urls via the urllib* libraries.
* Adds a new spec generator for common arguments.
* Makes the user-agent string configurable.

Fixes #6211
2014-03-10 16:06:52 -05:00
Matthew Riedel
5875d19f4d Returning 'NA' when no virtualization found 2014-03-10 11:58:04 -04:00
Richard C Isaacson
c6fbb0059b Some cleanup. 2014-03-10 10:31:08 -05:00
Federico Feroldi
b9ab31ebd8 Fix for #6365: cloudformation module fails to update if stack exists 2014-03-10 13:11:09 +01:00
Charles Duffy
18f53d9219 #6341: use shared function for parsing systemd status; check rc code 2014-03-10 01:05:48 -05:00
Charles Duffy
d59973295d #6341: check systemd service status with show subcommand 2014-03-10 00:09:29 -05:00
Jarno Keskikangas
37ef39d0fa Recognize rule changes even if ufw is in disabled state.
See http://askubuntu.com/questions/30781/see-configured-rules-even-when-inactive
for the details.
2014-03-09 12:56:52 +02:00
Jarno Keskikangas
4d5340587e Insert rule to a specific num. 2014-03-09 12:56:51 +02:00
Jarno Keskikangas
0247708199 Fix typo: 'reseted' -> 'reset'. 2014-03-09 12:56:51 +02:00
Jarno Keskikangas
2613e6fb14 Add protocol options 'esp' and 'ah'. 2014-03-09 12:56:51 +02:00
Jarno Keskikangas
f4e8a86c87 Add functionality and reduce complexity.
* Separate 'state', 'policy' and 'rule' commands
* Support for 'logging' command
* Support for 'direction' and 'interface' attributes
* Reliable change notifications based on 'ufw status verbose' diff
* Update documentation
* Cleanup
2014-03-09 12:56:51 +02:00
Aleksey Ovcharenko
651c04a3ec New module [ufw]: this module handles Ubuntu UFW operations
* Updated documentation related to IPv6 usage.

BugFixes:
* Solved the default_policy and state mutual exclusive status.
* Fixed changed status for IPv6 addresses.

Added @otnateos patch.
2014-03-09 12:56:51 +02:00
Hagai
748e8a7740 Add a package to missing list if npm list reported it as invalid 2014-03-09 12:48:44 +02:00
Michael DeHaan
c79b5ea4b4 Merge pull request #6344 from alimony/patch-1
Touch up documentation strings for DigitalOcean.
2014-03-08 18:41:48 -06:00
Markus Amalthea Magnuson
3f681ebc52 Touch up documentation strings for DigitalOcean. 2014-03-08 12:40:45 +01:00
Dolph Mathews
8808e029f9 spelling correction for "separate"
s/seperate/separate/

http://en.wiktionary.org/wiki/separate
2014-03-08 04:51:34 -06:00
Richard C Isaacson
aba86e3657 Cleaning up pep8 alerts. 2014-03-07 23:06:19 -06:00
Richard C Isaacson
f3c1177265 Documentation cleanup. 2014-03-07 23:04:56 -06:00
Richard C Isaacson
7686204b43 Refactored a few things to be more inline with the Ansible way. Passing testing. 2014-03-07 23:04:07 -06:00
Charles Duffy
44ebd3f4f3 systemd template services must not discard template part 2014-03-07 18:53:15 -06:00
Richard C Isaacson
a483e42583 unarchive module: Add creates functionality.
Closes GH-5354.

Forklift copy logic into unarchive. Provides integration unit tests.
2014-03-07 18:19:46 -06:00
Richard C Isaacson
d6247a3583 Yum: Fix logic in yum. 2014-03-07 15:22:59 -06:00
Richard C Isaacson
47b2dc611c Look at the filename and if it has a version defined possibly process this as a downgrade. 2014-03-07 15:01:39 -06:00
Richard C Isaacson
9244283122 Spelling and formatting. 2014-03-07 13:53:31 -06:00
Cove Schneider
29f1528492 change order of copyright 2014-03-07 11:08:08 -06:00
Cove Schneider
f47fe7af62 add sponsor copyright/attribution 2014-03-07 11:07:48 -06:00
Cove Schneider
cbd1da6457 add yum module downgrade support 2014-03-07 11:07:18 -06:00
aresch
a45bfbe06e Fix rpm_key on system with no gpg keys imported
Without the -a option, rpm command will fail (exit code 1) and execute_command() will fail causing an initial key import to not work.

[root@test ~]# rpm -q gpg-pubkey
package gpg-pubkey is not installed
[root@test ~]# echo $?
1
[root@test ~]# rpm -qa gpg-pubkey
[root@test ~]# echo $?
0
2014-03-06 16:12:11 -08:00
Scott Anderson
db67c3d772 Fixes a bug that prevents round-tripping of * and @ 2014-03-06 19:10:56 -05:00
James Cammarata
5a235f9e99 Merge pull request #6318 from jimi-c/issue_5305_ec2_elb_None_issue
Adding a wait loop to ec2_elb for the initial lb state when registering
2014-03-06 14:01:11 -06:00
Michael DeHaan
616d7e53b1 Merge pull request #6305 from amree/fix-mysql-replication-port
Fixed SQL syntax error when running mysql_replication module
2014-03-06 11:08:12 -06:00
Michael DeHaan
7710867922 Merge pull request #6308 from muffl0n/file_fix_documentation
Module "file": Fix link to "path" in documentation
2014-03-06 11:04:47 -06:00
Michael DeHaan
acd64bf5a1 Merge pull request #6313 from phenomenes/msg-encoding-fix
Don't use keyword `error` in encode
2014-03-06 10:59:11 -06:00
James Cammarata
9f2999df79 Un-escape newlines in delimiters for assemble module 2014-03-06 09:44:56 -06:00
Jimena Cabrera-Notari
cc6e1ec261 Don't use keyword error in encode
This is not supported in Python 2.6. Just use positional arguments.
2014-03-06 13:33:53 +00:00
Sven Schliesing
f62cc1e351 Fix link in documentation
c(dest) -> c(path)
2014-03-06 13:16:29 +01:00
willthames
4a093a9709 Make it easier to determine whether instance creation or tagging fails 2014-03-06 16:30:39 +10:00
Will Thames
b9a7352e0a Work to allow security tokens and profiles to work with Ansible
Allow security tokens and profiles to be used as arguments
to the 'common' ec2 modules

Mostly refactoring to provide two new methods,
`get_aws_connection_info`, which results in a dict that can be
passed through to the boto `connect_to_region` calls, and
`connect_to_aws` that can pass that dict through to the
`connect_to_region` method of the appropriate module.

Tidied up some variable names

Works around boto/boto#2100

profiles don't work with boto < 2.24, but this detects for that
and fails with an appropriate message. It is designed to work
if profile is not passed but boto < 2.24 is installed.

Modifications to allow empty aws auth variables to be passed
(this is useful if wanting to have the keys as an optional
parameter in ec2 calls - if set, use this value, if not set,
use boto config or env variables)

Reworked validate_certs improvements to work with refactoring

Added documentation for profile and security_token to affected modules
2014-03-06 16:28:30 +10:00
amree
1d731e5c30 MASTER_PORT variable for CHANGE MASTER TO command can only accept integer value 2014-03-06 12:19:54 +08:00
James Cammarata
25cf215f54 Create the tempdir in the accelerate module if it doesn't exist
Fixes #6047
2014-03-05 22:08:09 -06:00
jctanner
6a615f18c5 Merge pull request #5872 from tomdymond/add-ignoreerror-to-sysctl
Add option to enable the sysctl -e option
2014-03-05 12:58:05 -05:00
jctanner
40ee030790 Merge pull request #6265 from franckcuny/gce-fixes
Add credential parameters to the GCE modules.
2014-03-05 00:11:52 -05:00
Leo R. Lundgren
dd62de0384 Fix whitespace (tabs -> spaces). 2014-03-05 05:12:21 +01:00
Leo R. Lundgren
347b425c67 Make irc module accept the nick being shortened by the server.
This can happen if the server has a NICKLEN setting which is less
than the length of the specified nick. With this patch we now grab
that nick and use it moving forward, instead of failing because we
didn't get back the one we specified, in the connection response.
2014-03-05 04:39:08 +01:00
Franck Cuny
6294264dc4 Add credential parameters to the GCE modules.
In order to simplify the workflow with the GCE modules, it's now
possible to add the parameters and project name as arguments to the
various GCE modules.

The inventory plugin also returns the IP of the host in
`ansible_ssh_host` so that you don't have to specify IPs into the
inventory file.

Some update to the documentation are also added.

Closes #5583.
2014-03-04 19:27:49 -08:00
Michael DeHaan
da2126eda5 Merge pull request #6279 from techtonik/patch-1
setup: Fix KeyError: 'ipv4_secondaries' (issue #6274)
2014-03-04 14:24:36 -05:00
anatoly techtonik
a48f0da9d8 setup: Fix KeyError: 'ipv4_secondaries' (issue #6274) 2014-03-04 20:00:18 +02:00
Michael Scherer
5fd7b8010f Fix wrong module name for exception in nova compute
failed: [127.0.0.1] => {"failed": true, "parsed": false}
  invalid output was: Traceback (most recent call last):
    File "/tmp/ansible-tmp-1393950384.39-102240090845592/nova_compute", line 1328, in <module>
      main()
    File "/tmp/ansible-tmp-1393950384.39-102240090845592/nova_compute", line 241, in main
      except exc.Unauthorized, e:
  NameError: global name 'exc' is not defined
2014-03-04 17:30:15 +01:00
jctanner
0e494242cf Merge pull request #6271 from jimkytola/docker-image-fix
Removes pluralization of manager tag attribute.
2014-03-04 10:37:50 -05:00
Jim Kytola
186d19f224 Removes pluralization of manager tag attribute. 2014-03-04 10:07:32 -05:00
ToBeReplaced
23d4ecc2a5 Add comment about mod_admin_extra
Fixes issue #6027.
2014-03-04 09:19:44 -05:00
willthames
f568140ea5 Allow ec2_tag module to list the tags of an instance
Use the list argument to state to just collect the
tags of a resource through the AWS API.
2014-03-04 23:36:17 +10:00
Quinn Slack
635fdcb533 Add new cloud/rds DB instance types (db.m3 and db.cr1 families) 2014-03-03 19:59:27 -08:00
Joshua Conner
10f36e8c62 nova_compute: remove ternary statement 2014-03-03 10:55:28 -08:00
James Tanner
39e368b713 Fix debconf docstring indentation 2014-03-03 13:48:44 -05:00
James Tanner
ff1ae57fbf Merge branch 'debconf' of git://github.com/bcoca/ansible into bcoca-debconf 2014-03-03 13:46:11 -05:00
James Tanner
abd7c0b565 Update cpanm module to newer module patterns 2014-03-03 13:37:32 -05:00
James Tanner
4da0428d89 Merge branch 'module-cpanm' of git://github.com/franckcuny/ansible into franckcuny-module-cpanm 2014-03-03 13:07:26 -05:00
jctanner
b1a3e367b6 Merge pull request #6196 from softzilla/feature/docker_py_0.3.0_ansible
docker_image: added support for docker_py >= 0.3.0, Docker API >= 1.8. Replace #6178
2014-03-03 11:58:16 -05:00
James Cammarata
7f1989dc9c Adding a wait loop to ec2_elb for the initial lb state when registering
Fixes #5305
2014-03-03 10:12:03 -06:00
jctanner
1e01fb856d Merge pull request #6242 from scottanderson42/rds-group-modules
Adds modules for managing Amazon RDS parameter and subnet groups.
2014-03-03 09:42:44 -05:00
Scott Anderson
5c9739ae9c Adds modules for managing Amazon RDS parameter and subnet groups. 2014-03-02 19:36:07 -05:00
Gareth Rushgrove
a26bc3e2f9 correct name in documentation and example 2014-03-02 12:00:50 +00:00
Gareth Rushgrove
87265cd4b3 correct version added 2014-03-02 11:58:22 +00:00
Brian Coca
400a1aa49a didnt make 1.5 ... lets see 2014-03-01 22:28:51 -05:00
Brian Coca
68510ecda8 added better gentoo/funtoo support 2014-03-01 21:56:02 -05:00
Gareth Rushgrove
c770462fad Added modules to manage ec2 autoscaling groups
Includes management of Launch Configuration and related Autoscaling
Groups
2014-03-01 16:06:19 +00:00
Michael DeHaan
90655cb7b0 Fix up examples in the assert docs to match the way things work. 2014-03-01 09:34:21 -05:00
Joshua Conner
ce5939c507 nova_compute: fix for partial match b/w params['name'] and an existing name
When there is an Openstack instance that has a name that's a partial match
for module.params['name'], but a server with name module.params['name']
doesn't yet exist, this module would fail with a list index out of bounds
error. This fixes that by filtering by exact name and only then getting the
server from the list if the list is still not empty.
2014-02-28 18:05:52 -08:00
Eugene Brevdo
fa3d84d59e Tiny bugfix in ec2_vol documentation. 2014-02-28 11:56:42 -08:00
Michael DeHaan
4b281ca5c7 Make the npm production parameter in the docs list the choices. 2014-02-28 14:00:00 -05:00
Michael DeHaan
6c43e0e010 Simplify file module parameter description. 2014-02-28 13:55:07 -05:00
Michael DeHaan
bbb88517ef Since the ec2 parameter is named 'key_name' and 'keypair' is just an alias, use
the primary name of the parameter in the examples.
2014-02-28 13:52:47 -05:00
Michael DeHaan
b2c8b8ba86 Merge pull request #6222 from csinchok/patch-1
Typo in rabbitmq_plugin docs
2014-02-28 12:59:28 -05:00
Michael DeHaan
9d3a344c06 Merge pull request #6223 from lvh/patch-2
Support ssh-ed25519 keys
2014-02-28 12:59:05 -05:00
Laurens Van Houtven
80e2c597a8 Support ssh-ed25519 keys
The newest version of OpenSSH supports a new, wonderful key type. authorized_key incorrectly discards pubkeys of this type as busted because it doesn't recognize type signature.
2014-02-28 18:46:54 +01:00
James Cammarata
57486b268a Use the no-user-groups option (-N) for useradd in the user module
If no group was specified, but a group by the same name as the user
exists, an error was raised in the situation where USERGROUPS_ENAB is
enabled in /etc/login.defs (which is the case for almost every major
linux distro). In this case, the user will be put in group 100 (which
is usually the "users" group on those same distros). This is currently
only done in the base class, as the issue may not exist on other
platforms like AIX or the BSDs.

Fixes #6210
2014-02-28 11:46:27 -06:00
Chris Sinchok
796ac6d01c Typo in rabbitmq_plugin docs
Should be "plugins", not "users".
2014-02-28 11:38:11 -06:00
Richard C Isaacson
f17e549ff9 Typo fix. 2014-02-28 11:02:58 -06:00
Richard C Isaacson
809b714bfc Replace mode with octal renaming to mode.
Closes GH-6176

This way for mode we return in an octal format which is immediately usable compared to transforming it later.
2014-02-28 10:42:20 -06:00
Richard Isaacson
cca7fd3c0c Merge pull request #1 from bcoca/stat_updaates
added octal representation of mode and made md5 checksumming optional
2014-02-28 10:39:41 -06:00
Andy Trevorah
1280269866 apt_repository: autoinstall python-apt if not available 2014-02-28 16:39:06 +00:00
Richard Isaacson
44da82c90f Merge pull request #6218 from risaacson/issues_6194
Copy Module: Add the ability to set directory attributes on recursive copy.
2014-02-28 10:14:04 -06:00
Richard C Isaacson
7b6c7366d1 Minor cleanup. 2014-02-28 10:04:05 -06:00
Richard C Isaacson
890202e4c0 copy module: cleanup and if directory_mode not set default to umask 2014-02-28 10:00:54 -06:00
jctanner
42a2586dfa Merge pull request #6171 from joshuaconner/update_to_docker-py_0.3.0
docker: update to docker-py 0.3.0, plus full port binding support etc. from #5639
2014-02-28 08:31:56 -05:00
Richard C Isaacson
cf4a6b39cc Copy Module: Add the ability to set directory attributes on recursive copy.
Closes GH-6194.

These changes pass attribute modifications through to new directories during a recursive copy with an addition allowing for the directory mode to be set independantly.
2014-02-28 01:14:32 -06:00
James Tanner
aeccbeeed2 add failsafe comment for install_repoquery 2014-02-27 13:42:05 -05:00
James Tanner
122a7021bc remove install_repoquery docstring 2014-02-27 13:29:15 -05:00
James Tanner
3f43fa529d Install yum-utils by default 2014-02-27 13:16:30 -05:00
James Tanner
58c78539bb Fix typo 2014-02-27 12:40:51 -05:00
James Tanner
da210522f3 Fix up docstring type and extra info about list 2014-02-27 12:39:27 -05:00
James Tanner
79fb252dc9 Update docstring for rhn details 2014-02-27 12:34:53 -05:00
James Tanner
f89e5315af Add install_repoquery parameter to the yum module 2014-02-27 12:18:25 -05:00
Michael DeHaan
829f959dce Merge pull request #6201 from cchurch/devel
Escape subversion parameters for running svn commands
2014-02-27 10:36:44 -05:00
Richard Isaacson
73fa767a6b Added instance_tenancy functionality per social request. 2014-02-27 09:29:00 -06:00
Gareth Armstrong
02477eef69 Fix issue 5621, rpm_key doesn't work for el5 2014-02-27 14:52:56 +01:00
Chris Church
5c2c29e71f Pass svn arguments as a list of strings instead of using string substition to ensure all parameters are escaped properly. 2014-02-26 22:23:26 -05:00
James Cammarata
32a2636dc7 Add expanduser calls on src/dest in the module too 2014-02-26 15:19:45 -06:00
James Cammarata
3274785350 Merge pull request #5689 from pgehres/devel
Adding the region to the output of the ec2 module's creation of a new in...
2014-02-26 14:45:12 -06:00
Pavel Antonov
21a7bace77 Support docker_py >= 0.3.0, Docker API >= 1.8, extended error reporting 2014-02-27 00:27:39 +04:00
James Cammarata
bb5da4c5f6 Merge branch 'devel' of https://github.com/josephtate/ansible into josephtate-devel
Conflicts:
	library/cloud/ec2
2014-02-26 13:57:07 -06:00
James Cammarata
d6b912c429 Modifying the wait logic for newly created images to avoid tracebacks
Fixes #4619
2014-02-26 13:33:31 -06:00
James Cammarata
e659d55d62 Merge branch 'devel' of https://github.com/muffl0n/ansible into muffl0n-devel 2014-02-26 12:28:26 -06:00
James Cammarata
8a7c68dc18 Merge branch 'ec2-params' of https://github.com/scottanderson42/ansible into scottanderson42-ec2-params
Conflicts:
	lib/ansible/module_utils/ec2.py
	library/cloud/ec2
2014-02-26 09:37:26 -06:00
Michael DeHaan
404765162d Merge pull request #6184 from patrys/patch-1
Properly match existing security group
2014-02-26 08:10:27 -05:00
Patryk Zawadzki
da1efee21f Properly match existing security group
If we don't care about `vpc_id` then neither should the code.
2014-02-26 13:39:03 +01:00
Guido Kollerie
a000f37132 Emphasize target is on remote host. List supported file types.
From the documentation it is not immediately clear that the 'target'
option refers to a location on the remote host. This change emphasizes that.
In addition to .sql files, .bz2 and .gz files are supported for dumps and
restores. This is now documented.
2014-02-26 12:56:24 +01:00
jctanner
6fa898c511 Merge pull request #5092 from willthames/ec2_snapshot
Module to create EC2 snapshots
2014-02-26 06:10:17 -05:00
jctanner
1277b45b3c Merge pull request #5941 from sivel/rax-name-search-opts
rax module: Use regex start and end of string with name base filters
2014-02-26 05:56:39 -05:00
Brian Coca
53d71a3949 added octal representation of mode and made md5 checksumming optional
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2014-02-25 21:33:14 -05:00
Dustin C. Hatch
467914e3c3 filesystem: Ignore blkid cache
Sometimes, `blkid` will incorrectly return no information about a block
device, even if it exists and has a valid filesystem. This causes the
*filesystem* module to fail if *force=no*. Instructing `blkid` to use
`/dev/null` as a cache file will force it to rescan the block device on
each run, making results more consistent.

Signed-off-by: Dustin C. Hatch <admiralnemo@gmail.com>
2014-02-25 20:16:01 -06:00
Joshua Conner
9c72b52c01 docker: add 'version_added' to the appropriate documentation entries 2014-02-25 17:04:01 -08:00
Chris Church
1d6bdd451b Fix setup module to gather facts from PowerPC Macs. 2014-02-25 18:27:36 -05:00
Joshua Conner
66eb91c2f8 docker: update to docker-py 0.3.0, plus full port binding support, container names, links 2014-02-25 15:24:46 -08:00
James Tanner
0cca4a3919 Fixes #5255 yum: set disabled repos before enabled repos and fix the parameters used 2014-02-25 14:53:48 -05:00
James Cammarata
03cb2f5ffa Merge branch 'git_version_tags' of https://github.com/j2sol/ansible into j2sol-git_version_tags 2014-02-25 13:05:29 -06:00
James Cammarata
cb79947054 Fixing the unicode issue in uri for EL6 platforms
Fixes #5869
2014-02-25 13:04:05 -06:00
James Cammarata
6fe369fca0 Merge branch 'usermod_fix' of https://github.com/tknguyen79/ansible into tknguyen79-usermod_fix
Conflicts:
	library/system/user
2014-02-24 23:38:51 -06:00
James Cammarata
97eededc99 Handle unicode content in the uri module properly
Fixes #5869
2014-02-24 23:34:17 -06:00
Stefan J. Betz
789ae4697c Require force for LVM shrink and remove operations in lvol. Fixes #5774
Conflicts:
	library/system/lvol
2014-02-24 18:52:35 -06:00
Michael DeHaan
05bf80751b Merge pull request #6158 from risaacson/issues_5165
If you try to resize a lvol to the current size return a changed=False and don't fail.
2014-02-24 19:17:43 -05:00
Richard C Isaacson
bf30707670 If you try to resize a lvol to the current size return a changed=False and don't fail.
This addresses GH-5165 and adds the ability to check if a lvol exists.

The tests for this don't fit nicely into the current integration tests so they are below.

```
---

- name: remove any existing lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: remove any existing lv=two of vg=main
  lvol: lv=two vg=main state=absent

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  ignore_errors: true
  register: lvol_result0

- name: Assert that we will get a "No size given."
  assert:
    that:
      - "'No size given.' in lvol_result0.msg"

- name: create lv=one of vg=main sized 30g
  lvol: lv=one size=30g vg=main state=present
  register: lvol_result1

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result1.changed == True"

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  register: lvol_result2

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result2.changed == False"

- name: remove lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: create lv=two of vg=main sized 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result3

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result3.changed == True"

- name: reduce lv=two of vg=main to 15G
  lvol: lv=two size=15G vg=main state=present
  register: lvol_result4

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result4.changed == True"

- name: increase lv=two of vg=main to 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result5

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result5.changed == True"

- name: create lv=two of vg=main sized 30G when already exists at 30G
  lvol: lv=two size=30g vg=main state=present
  register: lvol_result6

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result6.changed == False"

- name: remove lv=two of vg=main
  lvol: lv=two vg=main state=absent
```
2014-02-24 16:56:08 -06:00
Kyle Kelley
b5eb4d2a71 Fix expires 2014-02-24 15:54:55 -06:00
James Cammarata
be0be16e89 Merge branch '5853-python-2.5-apt_repository-fix' of https://github.com/timurbatyrshin/ansible into timurbatyrshin-5853-python-2.5-apt_repository-fix 2014-02-24 15:20:29 -06:00
James Cammarata
3b2d409906 Fixing several bugs in assemble and updating tests
Bugfixes:
* the remote_src param was not being converted to a boolean correctly,
  resulting in it never being used by the module as the default behavior
  was remote_src=True (issue #5581)
* the remote_src param was not listed in the generic file params, leading
  to a failure when the above bug regarding remote_src was fixed
* the delimiter should always end with a newline to ensure that the file
  fragments do not run together on one line

Fixes #5581
2014-02-24 14:27:23 -06:00
James Cammarata
f03d6a67c8 Adding new tests for assemble role 2014-02-24 14:27:23 -06:00
Richard C Isaacson
aaf0a182e1 Merge remote-tracking branch 'jeromew/ansible_script_creates' into issues_4986 2014-02-24 10:16:39 -06:00
Lukáš Lalinský
8d507f79b9 Don't require pycurl in apt_repository when it's not actually needed 2014-02-22 15:33:54 +01:00
Scott Patten
dbde446358 In the route53 module, documenting that TXT and SPF requests
must be surrounded by quotes.

Otherwise you get a cryptic error message from Route 53.
2014-02-21 19:36:22 -08:00
Gianluca Borello
bf79833c9d Make sure droplet deletion works even when idempotency is achieved using 'name' and 'unique_name' rather than 'id' 2014-02-20 22:17:55 -08:00
James Cammarata
2157880029 Adding the backup destination to the resut dictionary for lineinfile 2014-02-20 13:31:54 -05:00
Matt Jeffery
8131feaade Normalise the module name when comparing against the module names in /proc/modules. 2014-02-20 16:54:33 +00:00
Daniel Jaouen
6748ef121b Update homebrew documentation. 2014-02-19 19:07:43 -05:00
Daniel Jaouen
e3a39837e1 Add back homebrew install_options parameter. 2014-02-19 19:07:43 -05:00
Daniel Jaouen
155f6e4dd3 Update homebrew documentation. 2014-02-19 19:07:43 -05:00
Daniel Jaouen
097ce84336 Fix homebrew linked/unlinked output. 2014-02-19 19:07:42 -05:00
Daniel Jaouen
91ac44a5bb Fix linked/unlinked states. 2014-02-19 19:07:42 -05:00
Daniel Jaouen
02694b80de Update homebrew module. 2014-02-19 19:07:42 -05:00
Daniel Jaouen
911a3930a6 homebrew_cask: check err instead of out for "nothing to list". 2014-02-19 19:07:00 -05:00
Daniel Jaouen
55f636675c homebrew_cask: return False instead of True when nothing to list. 2014-02-19 19:07:00 -05:00
Daniel Jaouen
8a612ba5d4 Handle homebrew_cask "nothing to list" corner case. 2014-02-19 19:07:00 -05:00
Daniel Jaouen
f7c3847391 Add module homebrew_cask 2014-02-19 19:07:00 -05:00
Michael DeHaan
d5c7290b93 Merge pull request #6066 from jsmartin/riak_module_fix
Properly fetching the riak version
2014-02-19 16:51:04 -05:00
James Laska
dbd3194e9c Resolves issue#6067 by allowing exact_count=0 2014-02-19 16:29:15 -05:00
muffl0n
b0f00cc097 already call expanduser in action_plugin 2014-02-19 21:41:57 +01:00
James Martin
0e3356c40e Properly fetching the riak version, and properly setting the python interpreter. 2014-02-19 12:12:02 -05:00
Jan-Piet Mens
01e1991baa module update: mqtt notification now uses Paho as mosquitto.py being deprecated 2014-02-19 14:53:45 +01:00
Michael DeHaan
30611eaac5 Merge pull request #6036 from mxxcon/patch-1
docs_pull_request: Add parameters highlighting
2014-02-18 13:58:44 -05:00
Michael DeHaan
6b2bbbb9ff Merge pull request #6045 from garaden/pypi_mirrors_gone
Set use_mirrors default to "no" for the pip module
2014-02-18 13:58:11 -05:00
Michael DeHaan
dc3ca7b37e Merge pull request #6051 from illenseer/devel
Fix zfs create command for properties with spaces
2014-02-18 13:54:47 -05:00
Brian Coca
310b23ee8d removed with
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2014-02-18 12:33:48 -05:00
James Cammarata
8880819395 Merge branch 'devel' of https://github.com/mtpereira/ansible into mtpereira-devel 2014-02-18 10:33:30 -06:00
Matthew Phipps
de99cc6fbf Remove use_mirrors from pip module
PyPI moved to a CDN on 2013-05-26, so mirrors are now largely
unnecessary and pip removed the functionality in 1.5. More importantly
(and why I wrote this request): on 2014-02-15 the mirror directory was
taken offline, so mirrors may not work anymore even for pip versions
that support them.
2014-02-18 10:49:22 -05:00
Matthew Phipps
63ff6c8493 pip module wasn't adding -e when using VCS 2014-02-18 10:39:51 -05:00
jeromew
7a14cb61c4 Add creates= and removes= to the script: action 2014-02-18 12:52:09 +00:00
Nils Pascal Illenseer
858004984b Fix zfs create command for properties with spaces
If a property value contains one or more spaces, the zfs command will fail.
With value quoted this behavior is fixed.
2014-02-18 11:30:17 +01:00
James Cammarata
daa3253b52 Merge branch 'devel' of https://github.com/calebbrown/ansible into calebbrown-devel 2014-02-17 15:38:56 -06:00
James Cammarata
9c9a940af6 Merge branch 'fix-5679' of https://github.com/jirutka/ansible into jirutka-fix-5679 2014-02-17 14:54:29 -06:00
Richard C Isaacson
7d670f8308 Merge remote-tracking branch 'berendt/fixing_permissions' into pull_4703 2014-02-17 11:46:23 -06:00
James Cammarata
1544c93bf2 Merge branch 'fix-postgres_user_to_understand_pg_namespaces' of https://github.com/alanfairless/ansible into alanfairless-fix-postgres_user_to_understand_pg_namespaces 2014-02-17 10:04:12 -06:00
James Cammarata
87bf16930e Merge branch 'postgres_alter_role' of https://github.com/jinnko/ansible into jinnko-postgres_alter_role
Conflicts:
	library/database/postgresql_user
2014-02-17 09:57:31 -06:00
mxxcon
4e4be3edc0 docs_pull_request: Add parameters highlighting
Added highlighting to parameter references in docs so that they standout a bit better.
2014-02-15 23:26:21 -05:00
Michael DeHaan
56befa9468 Document ansible_managed changing the template. 2014-02-15 14:13:42 -05:00
Michael DeHaan
6f9ca7cfa5 Some minor docs corrections. 2014-02-15 14:05:42 -05:00
James Cammarata
9dd9487692 Merge branch 'mohangk-fix_rds_modify_security_group' into devel 2014-02-15 09:34:46 -06:00
James Cammarata
7eb2a4c290 Merge branch 'fix_rds_modify_security_group' of https://github.com/mohangk/ansible into mohangk-fix_rds_modify_security_group 2014-02-14 14:43:42 -06:00
Bruce Pennypacker
899811f339 Added wait_timeout parameter 2014-02-14 20:16:58 +00:00
Richard Isaacson
bab91f9ed8 Merge pull request #6015 from angstwad/docfix
Spelling correction.
2014-02-14 11:04:44 -06:00
Richard Isaacson
ffeb507761 Merge pull request #5645 from resmo/fix/apt_pkg_version
apt: fixed pkg=<name>=<version> fails if package is not yet installed.

Tested and it fixes the problem on more recent versions of apt.
2014-02-14 11:01:35 -06:00
Paul Durivage
0dbd5d3e18 Spelling correction 2014-02-14 10:47:27 -06:00
Amir H. Hajizamani
cf5b1620b7 Remove superfluous/invalid quote
Allow the example to be copy-pasted with minimal confusion about the error.
2014-02-14 16:44:55 +00:00
Peter Gehres
c427a829a0 Adding better failure output for chkconfig failures rather than
just saying that the service name is unknown
2014-02-13 23:05:00 -08:00
Peter Gehres
b5761750c4 Adding the region to the output of the ec2 module's creation of a new instance. 2014-02-13 22:40:49 -08:00
Michael DeHaan
c91ceddfac Add the start of an integration test structure using Ansible playbooks, also added an assert action plugin to make writing those easier. 2014-02-13 18:28:29 -05:00
James Cammarata
0d79132757 Merge pull request #5998 from jimi-c/issue_3978_boto_ssl_cert_validation
Adding 'validate_certs' option to EC2 modules
2014-02-13 14:42:30 -06:00
James Cammarata
fdb7c733c1 Updating CHANGELOG for the new validate_certs feature
Also removing validate_cert option from the cloudformation module docs,
as it does not use the standard ec2 connection.
2014-02-13 14:40:39 -06:00
Richard Isaacson
686f87e42e Merge pull request #5944 from sean-/devel
Fix broken behavior when removing all auxiliary groups from a user. See #5933 for more details.

Tests by hand correct and passes "make clean tests".
2014-02-13 13:54:38 -06:00
James Cammarata
056d54ebd3 Adding 'validate_certs' option to EC2 modules
When disabled, the boto connection will be instantiated without validating
the SSL certificate from the target endpoint. This allows the modules to connect
to Eucalyptus instances running with self-signed certs without errors.

Fixes #3978
2014-02-13 12:32:49 -06:00
Isao Jonas
6f44e7b039 add security groups to elb_lb 2014-02-13 10:57:41 -06:00
Will Thames
c8127ea874 ec2 module fails when state is not absent
tagged_instances is initialised in a scope not visible
when state is not absent.
2014-02-13 19:51:33 +10:00
Pavel Antonov
e02cf2aab7 Refactore unused code 2014-02-12 17:06:58 -05:00
Pavel Antonov
dddd4b2522 Added modules description and examples 2014-02-12 17:06:58 -05:00
Pavel Antonov
df41ed90b8 Docker supports links and port binding. Added docker_image module 2014-02-12 17:06:58 -05:00
Michael DeHaan
0cdf8d3162 Merge pull request #5981 from angstwad/docfix
Documentation updates to rax_files, rax_files_objects
2014-02-12 14:21:10 -05:00
James Cammarata
a1b7a93b69 Modified cloudformation module to use common ec2 module functions
Fixes #3688
2014-02-12 12:54:47 -06:00
Michael DeHaan
e89dafc6c1 Merge pull request #5039 from bpennypacker/airbrake
airbrake: Made the reporting URL an optional parameter
2014-02-12 12:32:28 -05:00
Paul Durivage
f18db0dd20 Doc updates 2014-02-12 11:22:15 -06:00
Robin Roth
660fa9183c remove check for version string
this check does not get used anywhere and is not needed as zypper/rpm can handle version information directly
2014-02-12 17:14:43 +01:00
Richard Isaacson
eb4a730933 Merge pull request #5969 from risaacson/pull_5136
Updates for the unarchive module and action_plugin.
2014-02-12 10:10:25 -06:00
Richard C Isaacson
598b9c6b7c Cleanup per notes.
Some small changes to per notes from @mpdehann.
2014-02-12 10:01:10 -06:00
Isao Jonas
1602a80d76 added elasticache vpc security group ids 2014-02-12 09:06:15 -06:00
Maykel Moya
811aa2611e Add support for string values
The SET GLOBAL statement requires properly quoting of values. For example, the
following correct queries will fail if quotes are toggled:

mysql> SET GLOBAL innodb_lru_scan_depth = 2000;
mysql> SET GLOBAL master_info_repository = "TABLE";

`mysql_variable` module doesn't quote the value argument, therefore
string values will fail.

  # this task will pass, 2000 is passed without quotes
  - name: set a numeric value
    mysql_variable: variable=innodb_lru_scan_depth value=2000

  # this task will fail, TABLE is passed without quotes
  - name: set a string value
    mysql_variable: variable=master_info_repository value=TABLE

With this patch prepared statements are used. Proper quoting will be
done automatically based on the type of the variables thus an attempt
to convert to int, then to float is done in first place.

Booleans values, ie: ON, OFF, are not specially handled because they
can be quoted. For example, the following queries are correct and
equivalent, they all set _innodb_file_per_table_ to logical _True_:

mysql> SET GLOBAL innodb_file_per_table = "ON";
mysql> SET GLOBAL innodb_file_per_table = ON;
mysql> SET GLOBAL innodb_file_per_table = 1;

Tested in mysql 5.5 and 5.6.
2014-02-12 12:44:28 +01:00
Richard C Isaacson
cb7c2b7524 Updates for the unarchive module and action_plugin.
There is a bit going on with the changes here. Most of the changes are cleanup of files so that they line up with the standard files.

PR #5136 was merged into the current devel and brought up to working order. A few bug fixes had to be done to get the code to test correctly. Thanks out to @pib!

Issue #5431 was not able to be confirmed as it behaved as expected with a sudo user.

Tests were added via a playbook with archive files to verify functionality.

All tests fire clean including custom playbooks across multiple linux and solaris systems.
2014-02-12 01:57:00 -06:00
Richard C Isaacson
e6c9705058 Merge remote-tracking branch 'pib/unarchive_remote' into pull_5136 2014-02-11 22:55:34 -06:00
Michael DeHaan
f07091ed69 Merge pull request #5962 from sivel/rax-facts-docs-update
rax_facts and rax_keypair modules: update docs
2014-02-11 16:39:59 -05:00
Matt Martz
e8952a5a99 The OpenStack auth attributes apply to rax_keypair also 2014-02-11 14:25:13 -06:00
jctanner
fe94c0cd05 Merge pull request #5957 from sivel/rax-no-default-disk-config
rax module: Don't set a default for disk_config
2014-02-11 11:55:06 -05:00
Christopher H. Laco
471b1a7a47 Add rax_identity module
For some tasks, I need to drop the username/api_key into configuration
files. Rather than rely on how I'm calling the rax modules. It seemed
more appropriate to authenticate against Rackspace and return the wealth
of information contained in the pyrax identity payload with other
modules/templates.
2014-02-10 22:40:38 -05:00
Matt Martz
8095aa6584 Don't set a default disk_config. Defaulting to 'auto', causes issues with new images 2014-02-10 16:12:32 -06:00
Sean Chittenden
5e0cf6663a Fix broken behavior when removing all auxiliary groups from a user
(e.g. 'groups=' in the user module).
2014-02-10 13:08:53 -08:00
Matt Martz
bd3c7c3efa The name parameter for search_opts is a regex string, so make sure we include start and end of string characters 2014-02-10 13:18:03 -06:00
zimbatm
4aaf8f9a4c library/digital_ocean: Adds the missing backups_enabled create option 2014-02-10 17:35:10 +00:00
Mohan Krishnan
fb3c8c90e5 Allow explict setting of vpc_security_groups to allow modification of security groups of RDS instances within a VPC 2014-02-10 14:01:45 +07:00
Brian Coca
f475de2316 hopefully last batch of fixes
- removed previous 'typification' of input as it needs it is typed by
  module as strings and needs to be output as strings, making it
  useless.
- now checks for vtype and value against None when question is specified
- simplified set_selections as vtype and value should have a string
  value going in.
- added example of querying questions for a package
- added module requirement of question,vtype and value being required
  together.
2014-02-09 20:47:01 -05:00
Brian Coca
a1de284dba made changes as per feedback:
- field names are more consistent with debconf
- values are now 'booleanized' or accepted as list/set objects when
  pertinent
- updated docs to reflect all of the above and debconf cli tools
  required
2014-02-09 17:46:18 -05:00
Michael DeHaan
d3c1b8de78 Merge pull request #5883 from amirhhz/improve-ec2-module-docs
Improve ec2 module docs
2014-02-09 14:07:35 -05:00
Scott Anderson
baf508a379 Change standard AWS access and secret key parameter names to aws_access_key and aws_secret_key. Fixes an authentication problem with the rds module and standardizes the naming convention on something more encompassing than ec2_*_key. 2014-02-08 18:35:26 -05:00
Matt Saunders
674969a7d8 Added user_data parameter to nova_compute module - currently no file parsing just text - Re issue #4992 2014-02-08 22:47:03 +00:00
Jon Chen
970997c764 fix linode typo 2014-02-07 20:47:57 -05:00
Joey Baker
95545ca689 indent err 2014-02-07 15:50:44 -08:00
Joey Baker
5655ffa8bf outdated needed to see set changed 2014-02-07 15:50:17 -08:00
Joey Baker
242bfd8c68 NPM install latest made more effecient
`npm install` is smart enough to only update updated modules. Checking for `outdated` and running `update` repeats the same process 2x.
2014-02-07 15:41:21 -08:00
Jesse Keating
4593e3c357 Make sure requested version tag gets downloaded
There is a subtle bug in how the git module currently works. If the
version you request is a tag name, and you've already got the repo
cloned, and the tag name is a new tag, but refers to the already checked
out working copy, the git module would exit early without change. This
is bad as it means the new tag ref was not fetched and could not be used
in later tasks.

This change will check if the version is a remote tag, and if the tag
doesn't exist locally. If that is true, it'll do a fetch.

The activity could still be seen as not a change, because the working
copy won't be updated, if the new tag refers to the already checked out
copy, but that's not different than before and can be fixed as a more
comprehensive overhaul of tracking change in the git module.
2014-02-07 14:13:04 -08:00
Richard Isaacson
66967bde14 Merge pull request #5905 from artursvonda/update-postgresql-docs
Added port documentation to postgresql_db and postgresql_user.
2014-02-07 14:31:09 -06:00
James Tanner
a62af82757 Make ec2 exact_count and count mutually exclusive 2014-02-07 13:42:43 -05:00
James Tanner
70ebb05190 Return a tagged_instances list for hosts that matched the count_tag 2014-02-07 13:07:34 -05:00
Richard Isaacson
5a15762739 Merge pull request #5826 from romeotheriault/fix_follow_redirects
A fix for uri module regarding following redirects. The old behavior would follow redirects either way. This change clarifies the functionality and makes it a bit more explicit. Comparing the old behavior to the new 'yes' == 'all', 'no' == 'safe' and now 'no' will not follow any redirects. Historic behavior is still supported and documented with a push to the new values.
2014-02-07 11:36:51 -06:00
Arturs Vonda
6d85082586 Added port documentation to postgresql_db and postgresql_user 2014-02-07 18:27:55 +02:00
jctanner
6e7f684958 Merge pull request #5901 from jctanner/ec2_tag_exact_count_2
Add exact_count and count_tag to the ec2 module.
2014-02-07 10:57:01 -05:00
James Tanner
f101768a9d Make an example that sets the instance Names 2014-02-07 10:49:13 -05:00
James Tanner
005ef837d9 Update docstrings 2014-02-07 10:34:45 -05:00
James Tanner
fd919062cb Add exact_count and count_tag to the ec2 module. 2014-02-06 23:25:57 -05:00
Afterburn
398c71c1b7 small change to docs 2014-02-06 20:35:42 -07:00
Afterburn
2fe00ac8c9 small change to docs 2014-02-06 20:34:38 -07:00
Brian Coca
0233584343 fixed main() issue created in prev fix, now values are empty string if they were None
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
2014-02-06 11:59:37 -05:00
jctanner
0bc0315171 Merge pull request #5880 from willthames/ec2_modules_refactor
Create a common EC2 connection argument spec for EC2 modules
2014-02-06 11:08:09 -05:00
Will Thames
7600c664fe Create a common EC2 connection argument spec for EC2 modules
Refactor the currently well-factored ec2 modules (i.e. those that already use ec2_connect) to
have a common argument spec. The idea is that new modules can use this spec without duplication
of code, and that new functionality can be added to the ec2 connection code (e.g. security
token argument)
2014-02-06 15:27:41 +10:00
willthames
27fc3b8006 Module to create EC2 snapshots
Two methods of creating a snapshot
* use volume_id
* use device_name and instance_id

The latter is more useful with inventory
2014-02-06 09:44:43 +10:00
jctanner
a1d2b5f257 Merge pull request #5363 from bcoca/acl_improved
acl module: acl now supports 'default'
2014-02-05 18:40:59 -05:00
Brian Coca
54a79bfc75 fixed docstring and changed type to etype avoiding python builtin
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2014-02-05 18:36:29 -05:00
Brian Coca
de956c57fe changes names to name in example 2014-02-05 18:28:17 -05:00
Brian Coca
453d473728 fixes as per feedback 2014-02-05 18:08:01 -05:00
Richard Isaacson
66f47c2096 Merge pull request #5891 from offby1/devel
Clarify doc for get_url
2014-02-05 15:49:31 -06:00
James Tanner
7268fe43e7 Use new syntax for module snippets in rabbitmq_policy and update changelog 2014-02-05 16:21:18 -05:00
jctanner
cda3f06117 Merge pull request #4957 from retr0h/rabbitmq_policy
Added module to handle rabbit policies [1]
2014-02-05 16:07:38 -05:00
jctanner
7fcf6cebfe Merge pull request #5881 from willthames/ec2_keys
Minor tweaks to simplify examples and documentation
2014-02-05 15:50:19 -05:00
jctanner
c13161993a Merge pull request #5410 from willthames/rds_snapshot
rds module: add snapshot capabilities
2014-02-05 15:23:08 -05:00
Eric Hanchrow
7e557663c2 Clarify doc for get_url
Move a sentence from doc for the "force" option to that for the "dest" option.
2014-02-05 10:58:48 -08:00
James Cammarata
77d5a18392 When force=yes, get_url should always download the specified file
This is accomplished by not setting the If-Modified-Since header,
and setting "cache-control: no-cache" instead. Note that if the
file content has not changed, the module will still report that
changed=false, as the md5's of the tmp file and existing file are
compared before swapping

Fixes #5104
2014-02-05 11:56:05 -06:00
jctanner
f50f29f304 Merge pull request #5051 from deontologician/patch-1
Added -FF flag to rsync invocation in synchronize
2014-02-05 12:02:48 -05:00
jctanner
825a20780f Merge pull request #5127 from ovcharenko/patches
synchronize module: Added existing_only options to skip creating new files on receiver
2014-02-05 11:49:05 -05:00
jctanner
1f9de0c076 Merge pull request #5187 from 42wim/devel
Add support for --copy-links in synchronize
2014-02-05 11:26:08 -05:00
Tom Dymond
486d14cb2d Reworked PR to avoid repeating the command 2014-02-05 15:35:24 +00:00
Amir H. Hajizamani
843f4e7d7c Neaten up example YAML with 2-space indenting 2014-02-05 15:14:44 +00:00