Commit graph

482 commits

Author SHA1 Message Date
Toshio Kuratomi
e9139ba4fa Change the example of rsync_opts to use a list instead of a string
Fixes #9889
2015-09-22 13:59:37 -07:00
James Cammarata
22d25de23c Fix syntax error in synchronize docstring 2015-09-17 11:30:03 -04:00
James Cammarata
627bd47fd3 Merge pull request #2055 from skylerbunny/patch-1
Explanation of privilege escalation in notes
2015-09-17 11:18:30 -04:00
Brian Coca
f12a2135ca Merge pull request #1525 from mjuenema/devel
Removed check whether destination directory is writable from files/un…
2015-09-14 09:01:36 -04:00
skylerbunny
489f3e67f1 Explanation of privilege escalation in notes
An attempt to make clear how privilege escalation works with respect to the src/source host and dest/destination host. One existing note was incorporated into three new ones, iterating each.
2015-09-12 13:13:48 -07:00
James Cammarata
310cf77edc Merge pull request #1947 from astorije/astorije/fix-acl
Fix the acl module
2015-09-11 13:06:19 -04:00
Brian Coca
68ab025dac minor doc fixes 2015-09-01 10:58:15 -04:00
Jérémie Astori
72fb7a0a17 Fix physical walk on acl module for Linux
`-h` is for BSD [1] while `-P`/`--physical` is for Linux [2].
This commit fixes that option now that acl module is (temporarily)
only supported for Linux.
I will re-add `-h` when fixing BSD support.

[1]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[2]: http://linuxcommand.org/man_pages/setfacl1.html
2015-08-20 23:35:53 +00:00
Jérémie Astori
8eefd44aef Make sure entry is not sent when acl state=query 2015-08-20 22:59:00 +00:00
Jérémie Astori
0e659ad872 Make sure permission-less entries are accepted when state=absent
Also, remove that try condition as, at that stage, no permissions with
other than 2 or 3 fields are sent to the function.
2015-08-20 22:58:49 +00:00
Jérémie Astori
e95bcaeb8a Remove support for d[efault]: in entry permissions
It is not documented in [the Ansible doc page][1] nor
[the BSD setfacl man entry][2] (which means it might not be compatible
with BSD) so removing it does not break the API.

On the other hand, it does not conform with POSIX 1003.1e DRAFT
STANDARD 17 according to the [Linux setfacl man entry][3] so safer to
remove.

Finally, the most important reason: in non POSIX 1003.e mode, only ACL
entries without the permissions field are accepted, so having an
optional field here is very much error-prone.

[1]: http://docs.ansible.com/ansible/acl_module.html
[2]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[3]: http://linuxcommand.org/man_pages/setfacl1.html
2015-08-20 22:22:28 +00:00
Brian Coca
f925f7e01f Merge pull request #1734 from freym/assemble-file-validation
assemble: add file validation support.
2015-08-19 11:15:21 -04:00
Jérémie Astori
3ac990556d Fix wrong expectation regarding entry format in acl module 2015-08-19 00:26:04 +00:00
Jérémie Astori
421d3f12cf Fix wrong processing of lines returned by setfacl in test mode 2015-08-19 00:25:18 +00:00
Jérémie Astori
50c6425673 Fix minor whitespace issues 2015-08-19 00:24:08 +00:00
Brian Coca
d61fde42ef updated encoding comment and expanded authors field 2015-08-14 22:01:05 -04:00
Brian Coca
d4a39d23df Merge pull request #150 from astorije/recursive_acl
Add recursive support for ACL module
2015-08-14 20:21:01 -04:00
Jérémie Astori
acfc2166b0 Set version number in recursive option description 2015-08-14 23:40:47 +00:00
Jérémie Astori
f8027a7f0a Ensure Python 2.4 compatibility and Linux-restricted support
- Make build_entry compatible with Python 2.4
- Re-add missing warning/comment that was forgotten while refactoring
- Replace `all()` with a good ol' for-loop Python 2.4 compatibility
- Make a condition check more explicit (when `state` is `query`)
- Make sure this module can only be run with on a Linux distribution
- Add a note about Linux-only support in the documentation
- Set the version in which recursive support was added, 2.0
2015-08-14 22:06:51 +00:00
Marius Gedminas
9bcf69a155 Fix obvious copy-paste error in module docs 2015-08-13 19:47:49 +03:00
Toshio Kuratomi
f39e5ffa1d Modify the default for synchronize's dest_port again 2015-08-05 13:05:59 -07:00
Toshio Kuratomi
ed2d8121b3 Update docs to reflect precedence for synchronize's dest_port param 2015-08-05 12:46:01 -07:00
Toshio Kuratomi
0071fd0bf7 Allow mode as a synchronize parameter (handled in action plugin) 2015-08-05 11:54:36 -07:00
Brian Coca
697307f88c Merge pull request #1670 from mikeputnam/issue-1643-gpl-header
Add missing GPLv3 License header
2015-07-30 14:39:44 -04:00
Toshio Kuratomi
19741d75eb Fi the local_rsync_path parameter used by the action plugin 2015-07-27 11:35:48 -07:00
James Cammarata
2bfddb015d In copy, set the mode before running th validation
Because some programs that do validation (like visudo) may require
the permissions to be more restricted.

Fixes ansible/ansible#11385
2015-07-26 14:40:22 -04:00
Brian Coca
9b8470ae95 minor doc fixes 2015-07-24 17:57:13 -04:00
Brian Coca
c688408385 fixed fragment docs 2015-07-24 17:54:02 -04:00
Jeff Widman
fd6518179b Move validate command into doc fragment and fix a few typos 2015-07-21 17:58:43 -07:00
Brian Coca
46fa43d9e0 Merge pull request #988 from isaacsimmons/ini-file-catch-interpolation-error
Handle ini file properties that contain interpolation errors
2015-07-20 20:49:23 -04:00
Patrik Lundin
3849a6d87b synchronize: add flag for verifying target host.
Add the possibility to verify the target host using a "verify_host"
flag. It is disabled by default to not change the module behaviour.
2015-07-19 13:22:07 +02:00
Brian Coca
2e77041dae Merge pull request #1654 from bcoca/file_dir_exceptions
now captures any exceptions when trying to create directories
2015-07-18 23:12:34 -04:00
Matthias Frey
68a3c6ece4 assemble: add file validation support. 2015-07-15 16:35:45 +02:00
Brian Coca
e916b04e91 Also document in example that unarchive download was added in 2.0 2015-07-14 10:19:17 -04:00
Mitchell Ludwig
9e11f5fd15 Improved stat documentation 2015-07-13 17:51:32 -06:00
Brian Coca
e33f093075 added ignore hidden to assemble 2015-07-09 00:28:10 -04:00
Jérémie Astori
ae1126c217 Add recursive support for ACL module (fix #5053, fix #5550, fix #7276) 2015-07-04 22:44:10 +02:00
Mike Putnam
6c0e264806 Add missing GPLv3 License header
Fixes #1643
2015-07-03 22:57:53 -05:00
Brian Coca
37506141a3 Merge pull request #1613 from verm666/issue-1575
unarchive: fix work with 0 bytes archives
2015-07-03 22:08:52 -04:00
Brian Coca
ed179fe379 now captures any exceptions when trying to create directories 2015-07-01 10:39:50 -04:00
Matthew Gilliard
910728f6c3 Handle race condition in directory creation.
If we try to make a directory, but someone else creates the directory
at the same time as us, we don't need to raise that error to the user.
They asked for the directory to exist, and now it does. This fixes
the race condition which was causing that error to be raised, and
closes #1648.
2015-07-01 15:22:45 +01:00
verm666
8deee99fcc unarchive: fix @bcoca's remarks, issue #1575 2015-06-30 08:14:30 -07:00
Brian Coca
433ca93c42 Merge pull request #1605 from vladimirmartsul/patch-1
Add "force" description
2015-06-30 07:54:48 -04:00
Brian Coca
13116d8ac0 Merge pull request #839 from gimoh/patch-1
Do not insert extra newline if line already contains it
2015-06-30 00:09:42 -04:00
verm666
725a7b2f59 unarchive: fix work with 0 bytes archives
This change is in response to issue #1575
2015-06-26 05:49:59 -07:00
Toshio Kuratomi
a5bba2488f Update version_added to 2.0 for the partial option 2015-06-25 12:44:20 -07:00
Vladimir Martsul
2206477b73 Add "force" description
Add "force" option description
2015-06-26 01:40:58 +06:00
Juan Picca
892212b9c4 synchronize module: add partial option 2015-06-25 14:18:49 -03:00
Toshio Kuratomi
c5324f54e6 Bump amount of file to download in a chunk to 64k. 2015-06-24 06:48:57 -07:00
Toshio Kuratomi
daa1472ccf Merge pull request #1448 from Jmainguy/unarchive_http
add download ability to unarchive module
2015-06-24 06:44:58 -07:00