Paul Belanger
5046413b6d
Fix flake8 errors for iosxr tests ( #65860 )
...
These were noticed when we migrated to the cisco.iosxr collection.
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-12-15 23:48:28 -05:00
Mads Jensen
0f491c0289
Replace TestCase.assertEquals with TestCase.assertEqual.
2019-11-11 10:24:21 -08:00
Nilashish Chakraborty
f2b0bfd4aa
Add iosxr_lacp resource module ( #59281 )
...
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-24 22:55:42 +05:30
Trishna Guha
2e8a3efccb
Revert nxos, ios, iosxr return_timestamps ( #56206 )
...
* Revert "nxos_command:run_commands results failure when commands array size >1 (#52670 )"
This reverts commit 0df5b92af3
.
* Revert "added timestamps to nxos_command module (#50261 )"
This reverts commit e150943314
.
* Revert "added timestamps to ios_command module (#50323 )"
This reverts commit 2a432a093b
.
* Revert "added response_timestamps to iosxr_command module (#50095 )"
This reverts commit 2a0c356da9
.
2019-05-08 20:49:29 +05:30
Trishna Guha
a41028244d
Add platform facts in network facts modules ( #51434 )
...
* Add platform facts in network facts modules
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add nxos
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add vyos
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add iosxr
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Add junos
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix pep8
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* update unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix vyos_facts unittest
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix ios_facts unittest
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix iosxr unittests
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix CI failure
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* fix junos test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-03-11 10:56:39 +05:30
vaneuk
2a0c356da9
added response_timestamps to ios_xr_command module ( #50095 )
2019-02-04 18:49:06 +05:30
Nilashish Chakraborty
2f0c666b5b
Add option to enter admin configuration mode in iosxr_user ( #51430 )
...
* Add admin mode to iosxr_user
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Update docs for admin option
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
* Fix review comment
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-01-30 15:37:28 +05:30
Toshio Kuratomi
3fba006207
Update bare exceptions to specify Exception.
...
This will keep us from accidentally catching program-exiting exceptions
like KeyboardInterupt and SystemExit.
2018-12-16 15:03:19 -08:00
Matt Clay
3033fd96b0
Move unit test compat code out of lib/ansible/
. ( #46996 )
...
* Move ansible.compat.tests to test/units/compat/.
* Fix unit test references to ansible.compat.tests.
* Move builtins compat to separate file.
* Fix classification of test/units/compat/ dir.
2018-10-12 20:01:14 -07:00
Ganesh Nalawade
1a684df109
Fix iosxr cli_config module diff issue ( #44898 )
...
* Fix iosxr cli_config module diff issue
* Modify iosxr plugin to support configuration
diff capability (get_diff()) within Ansible
to be in sync with iosxr_config module.
* Fix unit test case failure
2018-08-30 21:39:11 +05:30
Ganesh Nalawade
d1de1e0449
Update iosxr cliconf plugin ( #43837 )
...
* Update iosxr cliconf plugin
Fixes #39056
* Update iosxr cliconf plugin
* Modify iosxr module_utils code to support
refactored cliconf plugin api's
* Other minor changes
* Fix unit test failure
* Update ios, eos, nxos plugin for diff
* Fix review comment
2018-08-10 13:12:51 +05:30
Deepak Agrawal
66b389a00d
show version brief does not work on iosxr virtual ( #37609 )
...
* show version brief does not work on iosxr virtual
* ci failures fix
2018-03-29 12:33:41 +05:30
Kedar Kekan
93acd7c651
refactor iosxr_system for cliconf and netconf ( #34749 )
...
* * refactor iosxr_system for cliconf and netconf
* * Fix unit tests and sanity issues
2018-01-17 07:29:28 -07:00
Kedar Kekan
0f692f1fe7
iosxr_user refactor for cliconf and netconf ( #34892 )
...
* * refactor iosxr_user for cliconf and netconf
(cherry picked from commit 5d0994ef598f1601fca00a0c1eff4ebb05ebbf1b)
* * Purge and units test changes
2018-01-17 07:28:58 -07:00
bdowling
552d1df901
Adds parents to mutually_exclusive with src for *_config modules ( #33957 )
...
* mutually_exclusive add - ios_config parents works with lines by not src
* mutually_execlusive parents,src added to all other net modules
* tests for mutually_exclusive parents,src and whitespce removal
2018-01-03 09:47:12 -05:00
Kedar Kekan
012a96dabd
code cleanup for --diff
and --check
modes ( #33665 )
...
* code cleanup for `--diff` and `--check` modes
* fixes UT to remove exec_command
2017-12-07 20:14:57 +05:30
Kedar Kekan
2bc4c4f156
IOS-XR NetConf and Cliconf plugin work ( #33332 )
...
* - Netconf plugin addition for iosxr
- Utilities refactoring to support netconf and cliconf
- iosx_banner refactoring for netconf and cliconf
- Integration testcases changes to accomodate above changes
* Fix sanity failures, shippable errors and review comments
* fix pep8 issue
* changes run_command method to send specific command args
* - Review comment fixes
- iosxr_command changes to remove ComplexDict based command_spec
* - Move namespaces removal method from utils to netconf plugin
* Minor refactoring in utils and change in deprecation message
* rewrite build_xml logic and import changes for new utils dir structure
* - Review comment changes and minor changes to documentation
* * refactor common code and docs updates
2017-12-06 22:37:31 +05:30
Pilou
a5c9726502
Unit tests: share common code ( #31456 )
...
* move set_module_args to units.modules.utils
* unit tests: reuse set_module_args
* unit tests: mock exit/fail_json in module.utils.ModuleTestCase
* unit tests: use module.utils.ModuleTestCase
* unit tests: fix 'import shadowed by loop variable'
2017-11-17 09:17:07 -08:00
Kedar K
e2bed36d12
- Adds iosxr_netconf module to configure netconf service on IOSXR ( #31715 )
...
* - Adds iosxr_netconf module to configure netcong service on Cisco
IOS-XR devices
* - Adds Integration test for module
- Handles diff return from load_config
* - Adds unit test for iosxr_netconf module
2017-10-24 08:49:23 +05:30
David Newswanger
b818e986b6
Change network *_user modules to use configured_password to set a users password ( #28187 )
...
* WIP, update eos_user args
* refactor password for ios_user
* add eos tests, fix ios tests
* fixed password check
* refactor iosxr_user password
* fixed password arg for nxos
* [WIP] fix vyos_user password
* fix vyos tests
* update docs for net_user
* fix typo
* fix eos tests
* add warning when attempting to use password arg
* fix sanity/unit tests
* fix eos unit tests
* fix vyos_user aggregate
* fix typo in eos documentation string
* re add configured_password to vyos tests after rebase
2017-08-17 19:06:44 +05:30
Trishna Guha
6d1bd33aa5
fix iosxr_banner ( #27378 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-07-28 17:09:04 +05:30
David Newswanger
81151ef02c
Remove Deprecated Template network modules ( #27076 )
...
* removed deprecated networking template modules
* update changelog
* update changelog
2017-07-27 19:40:11 +01:00
Ricardo Carrillo Cruz
3a3bdde869
Fix multiple code and test issues on iosxr ( #27267 )
...
* Fix multiple code and test issues on iosxr
It passes the integration tests now.
Fixes #27123
* Fix pep8 issue
* Fix unit tests
2017-07-25 17:21:53 +02:00
James Mighion
58ade65ea6
Adding admin option for iosxr_config ( #26509 )
...
* Adding admin option for iosxr_config. Adding unit test for new admin option for iosxr_config. Fixes #24308
* Removing space on empty line.
2017-07-10 10:22:45 -06:00
Trishna Guha
98269888a9
iosxr_banner Implementation module ( #25744 )
...
* Add iosxr_banner implementation module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Integration test for iosxr_banner
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Unit test for iosxr_banner
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* remove blank line pep8
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-06-16 11:56:47 +05:30
Trishna Guha
44687bb917
Add iosxr_user implementation module ( #25615 )
...
* Add iosxr_user implementation module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* iosxr_user Integration test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* iosxr_user Unit test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* Modify integration test with idempotent case
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-06-15 22:07:03 +05:30
Nathaniel Case
f52dcef7ba
Actually check for equality on empty commands array ( #25308 )
2017-06-06 09:56:44 -04:00
Dag Wieers
4efec414e7
test/: PEP8 compliancy ( #24803 )
...
* test/: PEP8 compliancy
- Make PEP8 compliant
* Python3 chokes on casting int to bytes (#24952 )
But if we tell the formatter that the var is a number, it works
2017-05-30 18:05:19 +01:00
Ricardo Carrillo Cruz
60de93c31d
Add assertion on test_iosxr_facts ( #23852 )
...
We hit bug #23737 due to bad coverage on test_iosxr_facts, we
were not checking memory facts at all.
2017-04-21 11:19:46 +02:00
Peter Sprygada
f0008248d4
fix iosxr commands to encode json ( #23346 )
...
the command dict in the iosxr module_utils wasn't encoding the request
to json. this patch will fix that problem
2017-04-06 15:44:21 +01:00
Matt Clay
a5e3d13adc
Remove shebangs from unit tests.
2017-02-27 17:53:10 -08:00
Ricardo Carrillo Cruz
ab4e83f288
Remove superfluous include on iosxr filesystems fact gathering ( #21775 )
...
The regex will catch only lines that start with 'Directory of' regardless.
Also, fixing unit tests while at it.
2017-02-22 15:44:17 +01:00
Peter Sprygada
eb1453a366
updates iosxr modules to support socket ( #21231 )
...
* updates all iosxr modules to support persistent socket
* adds iosxr action plugin to connect to device
* adds exec_command() to iosxr shared module
* fixes iosxr_config and iosxr_template local action
* update all unit test cases
* adds base test module for iosxr module testing
2017-02-15 10:47:02 -05:00
Ricardo Carrillo Cruz
375846d764
Refactor iosxr_facts to use network_cli plugin ( #20857 )
2017-02-06 22:23:17 +01:00
Ricardo Carrillo Cruz
e70bc06ea1
Refactor iosxr_command to make use of network_connection plugin ( #20772 )
2017-01-30 17:52:19 +01:00
Ricardo Carrillo Cruz
a8cfe4a5d7
Refactor iosxr_config to make use of network_connection plugin
2017-01-24 23:24:06 +01:00
Ricardo Carrillo Cruz
ae630fff56
Refactor iosxr_template to network_cli plugin
2017-01-17 20:01:56 +01:00
Peter Sprygada
4cdb266dac
adds iosxr_system declarative module ( #20134 )
...
* adds new module iosxr_system
* adds unit test cases for module
2017-01-11 17:17:37 -05:00