cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
7523 commits 47 branches 390 tags 440 MiB
Commit graph

1819 commits

Author SHA1 Message Date
Joseph Callen
56559ebc35 Resolves issue with vmware_dvs_host module for v2.0 
When this module was written back in May 2015 we were using 1.9.x. Being lazy I added to param the objects that the other functions would need. What I have noticed is in 2.0 exit_json is trying to jsonify those complex objects and failing. This PR resolves that issue with the vmware_dvs_host module.

@kamsz reported this issue in https://github.com/ansible/ansible-modules-extras/pull/1568

Playbook
```
- name: Add Host to dVS
      local_action:
        module: vmware_dvs_host
        hostname: "{{ mgmt_ip_address }}"
        username: "{{ vcsa_user }}"
        password: "{{ vcsa_pass }}"
        esxi_hostname: "{{ hostvars[item].hostname }}"
        switch_name: dvSwitch
        vmnics: "{{ dvs_vmnic }}"
        state: present
      with_items: groups['foundation_esxi']
```
Module Testing
```
TASK [Add Host to dVS] *********************************************************
task path: /opt/autodeploy/projects/emmet/site_deploy.yml:234
ESTABLISH LOCAL CONNECTION FOR USER: root
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454694039.6-259977654985844 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454694039.6-259977654985844 )" )
localhost PUT /tmp/tmpGrHqbd TO /root/.ansible/tmp/ansible-tmp-1454694039.6-259977654985844/vmware_dvs_host
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454694039.6-259977654985844/vmware_dvs_host; rm -rf "/root/.ansible/tmp/ansible-tmp-1454694039.6-259977654985844/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454694058.76-121920794239796 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454694058.76-121920794239796 )" )
localhost PUT /tmp/tmpkP7DPu TO /root/.ansible/tmp/ansible-tmp-1454694058.76-121920794239796/vmware_dvs_host
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454694058.76-121920794239796/vmware_dvs_host; rm -rf "/root/.ansible/tmp/ansible-tmp-1454694058.76-121920794239796/" > /dev/null 2>&1
localhost EXEC ( umask 22 && mkdir -p "$( echo $HOME/.ansible/tmp/ansible-tmp-1454694090.2-33641188152663 )" && echo "$( echo $HOME/.ansible/tmp/ansible-tmp-1454694090.2-33641188152663 )" )
localhost PUT /tmp/tmp216NwV TO /root/.ansible/tmp/ansible-tmp-1454694090.2-33641188152663/vmware_dvs_host
localhost EXEC LANG=en_US.UTF-8 LC_ALL=en_US.UTF-8 LC_MESSAGES=en_US.UTF-8 /usr/bin/python /root/.ansible/tmp/ansible-tmp-1454694090.2-33641188152663/vmware_dvs_host; rm -rf "/root/.ansible/tmp/ansible-tmp-1454694090.2-33641188152663/" > /dev/null 2>&1
changed: [foundation-vcsa -> localhost] => (item=foundation-esxi-01) => {"changed": true, "invocation": {"module_args": {"esxi_hostname": "cscesxtmp001", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "switch_name": "dvSwitch", "username": "root", "vmnics": ["vmnic2"]}, "module_name": "vmware_dvs_host"}, "item": "foundation-esxi-01", "result": "None"}
changed: [foundation-vcsa -> localhost] => (item=foundation-esxi-02) => {"changed": true, "invocation": {"module_args": {"esxi_hostname": "cscesxtmp002", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "switch_name": "dvSwitch", "username": "root", "vmnics": ["vmnic2"]}, "module_name": "vmware_dvs_host"}, "item": "foundation-esxi-02", "result": "None"}
changed: [foundation-vcsa -> localhost] => (item=foundation-esxi-03) => {"changed": true, "invocation": {"module_args": {"esxi_hostname": "cscesxtmp003", "hostname": "172.27.0.100", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "state": "present", "switch_name": "dvSwitch", "username": "root", "vmnics": ["vmnic2"]}, "module_name": "vmware_dvs_host"}, "item": "foundation-esxi-03", "result": "None"}
```
 2016-02-05 14:39:55 -05:00
Daniel Petty
a1c2cb0a2e Fix indent 2016-02-03 14:36:04 -07:00
Matt Martz
d2e3909443 Fix DOCUMENTATION for ec2_vpc_dhcp_options.py and add missing RETURN to ec2_vol_facts.py 2016-02-02 10:00:51 -06:00
Brian Coca
9aac5784d3 Merge pull request #1565 from mjschultz/welex91 
Ensure that port_path is split into at most 2 components.
 2016-02-01 23:56:02 -05:00
Brian Coca
a2532862d8 Merge pull request #1330 from joelthompson/feature/ec2_vpc_dhcp_options 
Add new ec2_vpc_dhcp_options module
 2016-02-01 23:48:06 -05:00
Brian Coca
20caf29213 Merge pull request #1113 from shawnsi/vpc-route-table-continued 
Additional check mode fixes for ec2_vpc_route_table module
 2016-02-01 23:46:38 -05:00
Brian Coca
7e81c60c96 corrected version added 2016-02-01 23:49:05 -05:00
Brian Coca
76feff5b4d Merge pull request #1109 from wimnat/feature/ec2_vol_facts 
New module - ec2_vol_facts
 2016-02-01 23:43:27 -05:00
Baptiste Mille-Mathias
a11220228c fix typo 
conainerization => containerization
 2016-01-31 20:05:45 +01:00
Toshio Kuratomi
36be779888 Remove duplicate documentation fields 2016-01-28 09:20:55 -08:00
Sumit Roy
acc51c2944 Ensure that port_path is split into at most 2 components. 
cloudstack: cs_instance: fix do not require name to be set to avoid clashes

Require one of display_name or name. If both is given, name is used as identifier.

cloudstack: fix name is not case insensitive

cloudstack: cs_template: implement state=extracted

Update f5 validate_certs functionality to do the right thing on multiple python versions

This requires the implementation in the module_utils code here
https://github.com/ansible/ansible/pull/13667 to funciton

fixed domain_id to actually be supported

also added domain as an alias
alt fixes #1437

Simplify the code and remove use_unsafe_shell=True

While there is no security issue with this shell snippet, it
is better to not rely on shell and avoid use_unsafe_shell.

Fix for issue #1074. Now able to create volume without replica's.

Improved fix for #1074. Both None and '' transform to fqdn.

Fix for ansible-modules-extras issue #1080
 2016-01-28 11:02:34 -06:00
Brian Coca
33213dbc24 Merge pull request #1508 from RajeevNambiar/devel 
Update sts_assume_role.py for showing the correct example syntax role…
 2016-01-26 00:00:49 -05:00
Brian Coca
65686221af Merge pull request #1488 from robbwagoner/ec2-elb-facts-with-instance-health 
Include instance states (InService or OutOfService) as ELB facts
 2016-01-25 23:54:29 -05:00
Rob White
0d86bc8d6b Add missing doc fragments 2016-01-24 11:11:49 +11:00
Shawn Siefkas
ddcc15a60f Fixing check mode support for vpc route tables 
Loop compatibility for dry run exception handling

Route table deletion dry run handler

Fixing regression in propagating_vgw_ids default value

Adjusting truthiness of changed attribute for route manipulation

Updating propagating_vgw_ids default in docstring
 2016-01-22 11:32:24 -06:00
David Shrewsbury
46b4622eba Fix exception output for os_keystone_domain. 
The message attribute of a shade exception is not very helpful.
Converting to a full string will contain many more details.
 2016-01-19 12:17:36 -05:00
Brian Coca
e9450df878 Merge pull request #1486 from resmo/for-ansible 
[2.0.1] cloudstack: fixes and improvements
 2016-01-18 21:05:11 -05:00
David Shrewsbury
f798240f43 Update Keystone Domain module for latest shade 2016-01-18 14:35:08 -06:00
Monty Taylor
02e91f8897 Extract module for keystone domain management 2016-01-18 14:35:08 -06:00
Haneef Ali
b65bd39615 Ansible module for Keystone V3 API 
Change-Id: I9db323cc9e5a42353cab5cf4be6e22449cef8542
 2016-01-18 14:35:07 -06:00
RajeevNambiar
57a6a98cd9 Update sts_assume_role.py for showing the correct example syntax role_session_name instead of session_name 
Update sts_assume_role.py for showing the correct example syntax role_session_name instead of session_name. session_name is not a valid property.
 2016-01-16 09:13:18 -05:00
Chrrrles Paul
570869ef48 Merge pull request #1487 from chrrrles/vmware_doc_fragments 
use doc fragments
 2016-01-15 15:42:25 -06:00
Robb Wagoner
4be856a40c InService percent key as literal percent (i.e 50, not .5) 2016-01-12 10:46:21 -07:00
Robb Wagoner
3226ad4284 Include instance states (InService or OutOfService) as ELB facts 2016-01-12 10:07:09 -07:00
Charles Paul
0ba3d85522 use doc fragments 2016-01-12 11:03:44 -06:00
Brian Coca
2813675b6f Merge pull request #1469 from Constantin07/update_elb_ec2_facts 
ec2_elb_facts - Print explicit error cause when no ELBs are found in AWS
 2016-01-12 10:54:47 -05:00
Brian Coca
61bb39be71 Merge pull request #1466 from stepanstipl/fix-route53_facts_hosted_zone_id 
Fix: route53_facts hosted_zone_id boto error
 2016-01-12 10:54:17 -05:00
Brian Coca
3aa2d3744d Merge pull request #1482 from ansible/json-imports-fallback 
Update for modules which import json.
 2016-01-12 10:00:37 -05:00
Rene Moser
2984c13035 cloudstack: cs_portforward: fix missing return and remove unused arg 2016-01-12 13:32:39 +01:00
Brian Coca
91c4558545 Merge pull request #1363 from wimnat/feature/eni_facts_secondary_addresses 
Add secondary addresses to facts
 2016-01-11 19:06:01 -05:00
Brian Coca
aa95a81005 added version info on autodetection feature 2016-01-11 18:58:49 -05:00
Brian Coca
c0922d4d32 Merge pull request #1146 from frogu/proxmox_lxc_support 
add lxc support, without dropping openvz
 2016-01-11 18:54:08 -05:00
Toshio Kuratomi
7e56a66ef6 Really disable RETURN 2016-01-11 14:59:23 -08:00
Toshio Kuratomi
816bfd6990 Disable RETURNS because the approved module doesn't have a RETURNS that is buildable 2016-01-11 13:23:04 -08:00
Toshio Kuratomi
759e4f2f24 Merge pull request #952 from Java1Guy/ecs_service_module 
cloud amazon ECS service modules
 2016-01-11 13:11:19 -08:00
Toshio Kuratomi
d6af6f8477 Update for modules which import json. 
Some do not use the json module directly so don't need import json.
Some needed to fallback to simplejson with no traceback if neither was installed

Fixes #1298
 2016-01-11 13:06:22 -08:00
Rene Moser
11fdb822a4 cloudstack: fixes and improvements 
cs_instance: fix case insensitivity
cs_instance: remove duplicate code block
cs_securitygroup_rule: fix KeyError on older ACS
 2016-01-11 19:06:36 +01:00
Constantin07
53e6e8c936 Print explicit error cause when no ELBs are found in AWS 2016-01-08 11:55:40 +00:00
Stepan Stipl
6bad06e827 Fix: route53_facts hosted_zone_id boto error 
Boto is expecting parameter called "Id", not "HostedZoneId".
See
http://boto3.readthedocs.org/en/latest/reference/services/route53.html#Route53.Client.get_hosted_zone

Fixes ansible/ansible-modules-extras/#1465
 2016-01-07 18:06:35 +00:00
Charles Paul
6f4aaecb6a adding no_log to password 2016-01-05 14:36:05 -06:00
Brian Coca
fa11718c0f fixed domain_id to actually be supported 
also added domain as an alias
alt fixes #1437
 2016-01-01 01:55:11 -05:00
Toshio Kuratomi
19e496c69c Merge pull request #1395 from resmo/feature/cs_template_extract 
[stable-2.0] cloudstack: cs_template: implement state=extracted
 2015-12-23 13:10:51 -08:00
Toshio Kuratomi
9bae6eafee Merge pull request #1411 from resmo/fix/stable-2.0/case_insensivity 
[stable-2.0] cloudstack: fix name is not case insensitive
 2015-12-23 13:09:52 -08:00
Toshio Kuratomi
8f6d518a5b Merge pull request #1410 from resmo/fix/stable-2.0/cs_instance 
[stable-2.0] cloudstack: cs_instance: fix do not require name to be set to avoid c…
 2015-12-23 13:08:32 -08:00
Brian Coca
6efa406b6f added examples to route53_zone 
fixes #1061
 2015-12-23 12:01:47 -05:00
Joel Thompson
736321001f Add new ec2_vpc_dhcp_options module 
This module manages EC2 DHCP options for a given VPC. It allows you to
specify all the options which AWS allows you to set in a DHCP option
set.
 2015-12-23 09:55:26 -05:00
Michael Scherer
2f3dc1352f Replace choices=BOOLEANS by type='bool', fix #1326 2015-12-21 23:39:20 +01:00
Rene Moser
06f6a5375e cloudstack: fix name is not case insensitive 2015-12-20 22:24:58 +01:00
Rene Moser
15b14f8109 cloudstack: cs_instance: fix do not require name to be set to avoid clashes 
Require one of display_name or name. If both is given, name is used as identifier.
 2015-12-20 22:18:30 +01:00
Rene Moser
56fb7abc65
cloudstack: cs_volume: simplify detach on state=absent 2015-12-20 00:33:23 +01:00