cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
8221 commits 47 branches 390 tags 440 MiB
Commit graph

324 commits

Author SHA1 Message Date
Matt Martz
7547b1db8a Fix version_added for recently added modules 2016-03-01 11:12:30 -06:00
Matt Davis
14530ef5ef Merge pull request #1636 from jhawkesworth/win_regedit_extra_drives 
Windows: win_regedit; Add extra Powershell Drives so you can access other parts of the registry
 2016-03-01 01:57:15 +00:00
Matt Davis
5fd735909f Merge pull request #635 from schwartzmx/module/win_timezone 
Module: win_timezone
 2016-03-01 01:10:42 +00:00
Matt Davis
6b607551ba Merge pull request #1166 from jhawkesworth/2nd_go_at_win_regmerge 
New module: win_regmerge for handling multiple changes to windows registry
 2016-03-01 00:42:03 +00:00
Andrea Scarpino
a1f53f3a43 Fix issue #1406 about win_firewall_rule 
I changed the logic here to always use 'netsh ... show rule' keywords as keys for $fwsettings map. While the translation (e.g. Enabled -> enable) is performed when invoking 'netsh ... add rule' command.

I tested rule creation and rule creation when the rule was already existing on Windows Server 2012.
 2016-02-18 17:59:23 +01:00
Andrea Scarpino
7c99a60f2b win_unzip: overwrite any existing file 2016-02-11 16:43:12 +01:00
=
9695db53e0 Add extra PS Drives so you can access other parts of the registry 2016-02-09 06:42:02 +00:00
Corwin Brown
9ae9d04eab Added UseBasicParsing flag 
win_uri uses "Invoke-WebRequest" under the covers, which apparently
uses Internet Explorer to parse a webpage. The problem is if a user
has never run Internet Explorer, it will be unable to do that. The
work around for this is to set the "-UseBasicParsing" flag.

The only advantage to having the Internet Explorer parsed page is
that you can then access the DOM as if it was a powershell
argument. That doesn't seem super useful for Ansible to be able
to do, so I set the default to be "-UseBasicParsing"
 2016-02-08 15:52:45 -06:00
Brian Coca
166133b1f8 Merge pull request #1111 from h0nIg/devel 
win_acl: windows 2008 fix + special account fix + strict fix
 2016-02-01 23:45:26 -05:00
Brian Coca
3ca2c51ed9 Merge pull request #1077 from blakfeld/fix_win_unzip 
Made win_unzip Powershell Strict Complient
 2016-02-01 23:42:47 -05:00
Toshio Kuratomi
36be779888 Remove duplicate documentation fields 2016-01-28 09:20:55 -08:00
tcr
263774ea7d Fix #1512 add missing property in win_firewall_rule 2016-01-18 15:27:36 +01:00
Hans-Joachim Kliemeck
d2959fb7ed fixed version added and tests 2016-01-13 10:39:33 +01:00
Hans-Joachim Kliemeck
39aab8fe06 fixxed tests 2016-01-12 12:41:41 +01:00
Hans-Joachim Kliemeck
d5ab52eb58 fixxed tests 2016-01-12 12:36:45 +01:00
Hans-Joachim Kliemeck
c239ee31ac fixed problems related to userpricincipalname (user@domain) and undefined variables 
fixed variable capitalization
 2016-01-12 11:39:19 +01:00
Hans-Joachim Kliemeck
c0b2080ae1 fixed problems related to userpricincipalname (user@domain) and undefined variables 
fixed variable capitalization
 2016-01-12 09:57:56 +01:00
Hans-Joachim Kliemeck
fe4429ba3e fixed problems related to userpricincipalname (user@domain) and undefined variables 
fixed variable capitalization
 2016-01-12 09:52:08 +01:00
Marcin Dobosz
aee09745d3 Fix win_iis_webapppool module to not null ref when removing an apppool using PS4 2015-12-22 16:20:29 -08:00
Dreamcat4
64be5b395a win_regedit: fixes #1404 
When 'value:' is set to be the key's  "(default)" property value
 2015-12-19 21:57:13 +00:00
Brian Coca
f6220ed424 Merge pull request #1373 from bcoca/win_firewall_rule_misargs 
fix error with misArg not being declared
 2015-12-16 08:07:44 -05:00
Brian Coca
641a347d96 fix error with misArg not being declared 
also fixed test to work on empty string or not for error reporting
 2015-12-15 09:17:48 -05:00
Brian Coca
d6a976f90c Merge pull request #1327 from georgefrank/win_nssm-fix-1161 
Use an empty string instead of null for AppParameters
 2015-12-14 23:20:06 -05:00
Brian Coca
892cf445dd added missing version_added to new options 2015-12-14 23:09:06 -05:00
Brian Coca
22f20ebeed Merge pull request #1295 from superquadratic/win_choco_params 
win_chocolatey: Add install_args, params and ignoredependencies
 2015-12-14 23:04:42 -05:00
daveres
5d1e9c6acb Correct problem with changed:true 
I have just changed a small piece of this module to avoid to return always that the task is changed
 2015-12-08 19:00:31 +01:00
Brian Coca
f2dbaa6b33 Merge pull request #1102 from bgeihsgt/win_webpicmd_fix 
Fix #1101: win_webpicmd strict mode fixes
 2015-12-08 09:35:09 -05:00
gfrank
cfe4f59b5b Use "" for AppParameters if it's null 2015-12-04 15:46:06 -05:00
gfrank
bc42aea3a3 Replace slashes in the parameter string 
Also remove duplicate documentation
 2015-12-04 14:33:31 -05:00
Guido Lorenz
d51950c37e win_chocolatey: Clean up documentation 2015-11-27 16:33:17 +01:00
Guido Lorenz
5948389d2f win_chocolatey: Add install_args, params and ignoredependencies 2015-11-27 16:33:10 +01:00
Adam Keech
42efef5682 Appending "Registry::" is not needed and no longer works. 2015-11-25 11:41:02 -05:00
Hans-Joachim Kliemeck
a59f1f528e fix race condition and missing property 2015-11-20 09:08:42 +01:00
Hans-Joachim Kliemeck
0688522eb7 fail if type parameter is empty 2015-11-17 15:36:52 +01:00
Hans-Joachim Kliemeck
e4d9034fbc corrected replacement of last backslash 2015-11-11 12:51:24 +01:00
Sam Liu
96d044192c new module win_file_version 2015-11-11 13:30:09 +08:00
Hans-Joachim Kliemeck
55f64daee3 corrected requirements 2015-11-06 14:36:00 +01:00
Hans-Joachim Kliemeck
9d8b6d470d fixxed problems related to path input 2015-11-06 14:29:11 +01:00
Hans-Joachim Kliemeck
5753a05625 fixxed problem with match @ 2015-11-06 10:46:55 +01:00
Hans-Joachim Kliemeck
9778015039 first implementation of win_share module 2015-11-06 09:26:49 +01:00
Hans-Joachim Kliemeck
10ce1f92aa fixxed problem with match @ 2015-11-05 17:46:25 +01:00
Hans-Joachim Kliemeck
84a8902b48 fixxed problem with match @ 2015-11-05 17:44:29 +01:00
Brian Coca
e738bf80ac Merge pull request #1123 from foretagsplatsen/documentation_win_iis_virtualdirectory 
Adds examples for win_iis_virtualdirectory
 2015-11-02 19:17:14 -05:00
Brian Coca
8a9d48a552 Merge pull request #1124 from foretagsplatsen/fix_application_in_win_iis_virtualdirectory 
Fix: support for virtual directories in applications
 2015-11-02 19:15:47 -05:00
Brian Coca
be8aacf899 Merge pull request #1143 from smadam813/devel_win_nssm 
win_nssm: strict fix + added dependencies,startmode,user/pw feature
 2015-11-02 19:14:21 -05:00
Brian Coca
937b588b3f Merge pull request #1172 from nitzmahone/win_updates_strictmode_fix 
Strict-Mode fixes
 2015-11-02 19:13:40 -05:00
Corwin Brown
228b8707b7 Added Error messages to the Try/Catch blocks 2015-11-02 14:08:00 -06:00
Brian Coca
e5f2158312 Merge pull request #1108 from bgeihsgt/win_regedit_fix 
Fix #1107: win_regedit parameter parsing and New-Item prompt error
 2015-11-01 17:16:06 -05:00
Brian Coca
6d1dd42935 Merge pull request #1174 from trondhindenes/win_package_guidfix 
Various improvements to win_package
 2015-11-01 16:40:14 -05:00
Corwin Brown
54b6528327 Adding Site_ID param 2015-10-30 13:23:14 -05:00
Corwin Brown
c4b4c412a2 Switching to Get-AnsibleParam 
Switching to Win_Unzip
 2015-10-30 09:57:53 -05:00
Trond Hindenes
f6ea32b9ec Various improvements to win_package 2015-10-28 21:52:32 +01:00
Corwin Brown
4bc04cd997 bug fixes 2015-10-28 11:55:19 -05:00
nitzmahone
8fa10acddf Strict-Mode fixes 
Changes to missing member handling to support running top-level script under Strict-Mode v2 (as Ansible 2.0.0 does now)
 2015-10-27 16:08:00 -07:00
Corwin Brown
7c12ed8af0 Using Get-AnsibleParam 
conflict

typo
 2015-10-27 15:08:03 -05:00
James Cammarata
949b124e05 Merge pull request #1114 from blakfeld/fix_win_iis_webapppool 
Made win_iis_webapppool Strict Compliant
 2015-10-27 14:33:20 -04:00
=
4f15e1e7e7 First pass at adding win_regmerge module for handling bulk registry changes 2015-10-27 06:13:42 +00:00
Hans-Joachim Kliemeck
45249fb042 only call set-acl if necessary 2015-10-26 10:20:14 +01:00
Adam Keech
56e7d80479 Fixing Some Issues with out Parameters are passed around. Also some refactoring. 2015-10-22 17:41:18 -04:00
Adam Keech
9782f08a7d Merge remote-tracking branch 'h0nlg/devel_win_nssm' into devel_win_nssm 2015-10-22 17:37:57 -04:00
Hans-Joachim Kliemeck
b4f80a777f fixed bugs with flipped protection attribute 2015-10-22 14:22:50 +02:00
Hans-Joachim Kliemeck
b03c7ebfa1 introduced state to differentiate between enabled/disabled inheritance. renamed copy to reorganize, since the meaning for inheritance=enabled is different 2015-10-21 22:43:42 +02:00
Hans-Joachim Kliemeck
8de49a5dea suggestions by @marcind 2015-10-21 21:20:44 +02:00
Hans-Joachim Kliemeck
3a5d4576c6 as suggested by @marcind, convert to boolean 2015-10-21 21:11:51 +02:00
Hans-Joachim Kliemeck
adc78eaf87 fixed documentation 2015-10-21 20:06:26 +02:00
Hans-Joachim Kliemeck
d3f83ee9a7 added start mode feature 2015-10-21 18:16:49 +02:00
Hans-Joachim Kliemeck
e7fd5dcde0 strict variables fix 2015-10-21 17:52:59 +02:00
Hans-Joachim Kliemeck
461a479cbd added dependency and user settings 2015-10-21 17:52:48 +02:00
Brian Coca
679e9fc7b4 Merge pull request #1100 from bgeihsgt/win_iis_absent_fix 
Fix #1099: Only populate site result when it is there
 2015-10-19 11:29:15 -04:00
Henrik Wallström
c893f30b2a Fix: support for virtual directories in applications 2015-10-19 16:29:43 +02:00
Henrik Wallström
918f3fa329 Adds examples for win_iis_virtualdirectory 2015-10-19 16:04:17 +02:00
Hans-Joachim Kliemeck
7978afe1fd fixed documentation 2015-10-18 17:26:12 +02:00
Hans-Joachim Kliemeck
95862793d0 added module to disable acl inheritance 2015-10-18 17:24:27 +02:00
Hans-Joachim Kliemeck
a0a51ffd66 added credits, fixed documentation 2015-10-18 17:06:28 +02:00
Hans-Joachim Kliemeck
75163ac5fe made win_acl strict compliant 2015-10-18 16:58:13 +02:00
Hans-Joachim Kliemeck
21c564848d added userprincipal support 2015-10-18 16:58:04 +02:00
Hans-Joachim Kliemeck
cda7e96fcc added userprincipal support 2015-10-17 23:10:56 +02:00
Hans-Joachim Kliemeck
7c8e3f4da1 added separate module to change owner, since win_acl is ACL only and should not be more complex 2015-10-17 17:07:39 +02:00
Toshio Kuratomi
632de528a0 Fix win_acl docs build 2015-10-16 11:11:42 -07:00
Corwin Brown
ea430466a8 Made win_iis_webapppool Strict Compliant 2015-10-15 18:02:21 -05:00
Hans-Joachim Kliemeck
71dc569566 fixed problem with sid/windows 2008 by using SID. fixed problems related to default accounts like BUILTIN\SYSTEM 2015-10-15 12:01:11 +02:00
Brian Coca
05f53f2b95 Merge pull request #200 from schwartzmx/module/win_acl 
win_acl Module

talked to @cchurch, merging this for now, need to open ticket to address the 2008 issue
 2015-10-14 15:44:47 -04:00
Brian Geihsler
c6a934d57b Fix #1107: Prepend registry type on key path 2015-10-14 11:04:38 -07:00
Brian Geihsler
d0e3a315ac Fix #1107: Use Get-Attr in win_regedit 2015-10-14 11:04:07 -07:00
Brian Geihsler
1e37276c97 Fix #1101: win_webpicmd strict mode fixes 2015-10-14 00:39:59 -07:00
Brian Geihsler
0e64863429 Fix #1099: Only populate site result when it is there 2015-10-14 00:33:28 -07:00
Corwin Brown
c35c37258f Adding win_uri module 2015-10-13 09:47:56 -05:00
Brian Coca
561d768f44 Merge pull request #1076 from trondhindenes/win_package_bugfix 
turned off strict msi code checking
 2015-10-12 09:27:54 -04:00
Brian Coca
a155f7ee34 Merge pull request #1071 from nlandais/devel 
Adding fix to get around bug found with the New-Website command when…
 2015-10-12 09:27:30 -04:00
Brian Coca
cc69ac1513 Merge pull request #1064 from dreamcat4/feature/win_fw-hotfixes 
hotfixes: module windows/win_firewall_rules
 2015-10-12 09:27:18 -04:00
Corwin Brown
f8e1600444 Made Powershell Strict Complient 2015-10-09 17:49:34 -05:00
Trond Hindenes
b9d842ecd6 turned out strict msi code checking 2015-10-09 20:28:54 +02:00
Nicolas Landais
d1dcf8e06b Adding fix to get around bug found with the New-Webstire command when running playbook on a vanilla machine. 2015-10-08 12:00:12 -04:00
=
576b5e2fc3 Document module limitations to resolve https://github.com/ansible/ansible-modules-extras/issues/908 2015-10-07 05:25:28 +01:00
Dreamcat4
ece9c2b43a fix: Add 'enable:' flag for enabling existing rules which are disabled by default. 
This is a very much needed flag. To turn on/off existing firewall rules. And like the recent fix of the 'Profile' key, the netsh cmd prints 'Enabled' in the textual output. (at least on win10 it does). So again a similar small code added for the necessary exception handling when the difference check happens.

Please merge / push upstream like the other fixes. Many thanks. This is the last fix I have put together for this patch set. So I will raise my PR now.

But if you want to fix more bugs, it seems there may be others. In terms of the control code. Sometimes it will delete a rule under 'force' condition (when found difference) - but instead it is supposed to just modify the existing rule. Some weird behaviour regarding that. The other problem is that ansible does not return the error text printed by 'netsh' cmd verbatim... but it should as that makes debugging these errors a *lot* easier.
 2015-10-06 14:03:27 +01:00
Dreamcat4
dcaa794949 fix: update documentation with new module name "win_firewall_rule" 2015-10-06 10:47:27 +01:00
Dreamcat4
469d22df97 fix: The names of firewall profiles are different on win10 & win2008r2 
Hi again. This commit removes a small portion of your script's own internal error checking. In specific: for the value of the profile: key. This is essential to avoid errors on other verisons of the windows operating system which are not win2008r2 (your version).

For example: on win10 (and most likely win8x too), the names of the profiles don't include the values 'current' and 'all'. But instead the values are 'Public' 'Private' 'Domain' and 'Any. But in addition, there are also certain combinatorial values, such as profile=Public,Private etc. Which is too many to error check yourself.

Yet removing the error checking here should not cause any ill effects however: since the netsh advfirewall ... cmds themselves to add / remove / modify actually to their own error checking of the profile=value. So when the cmd is run, it will error out itself with an appropriate / informative error msg. No harm done.

Therefore please remove the highlighed portions from your own script. It is essential for interoperability with win10 and win8x. Many thanks.
 2015-10-05 21:53:11 +01:00
Dreamcat4
6c5a4a14ef fix: win10 - Add exception handling for 'Profiles:' textual output key name mismatch. 
In win10 (and pribably win8x also):

The output of 'show rule' key includes the line "Profiles:<TAB>Public,Private".
Yet your script expects the key name printed out to be "Profile:<TAB>value".

This commit added the necessary exception handling to avoid flagging 'different=true' under the false circumstance. The key name to SET a firewall rule is still "profile=" and not "profiles=".

There is coming up another commit to fix the value handling for win10/win8. Which is another (different) error with the profile: key.
 2015-10-05 21:36:24 +01:00
Dreamcat4
2654789af7 fix: fw rule names must always be quoted, to permit spaces ' ' and brackets '()' 
Without this fix, the 'netsh' command gets name=Firewall Rule Name instead of name="Firewall Rule Name". Thus causing all sorts of havoc. Basic shell quoting rules seems to apply to Windows Powershell too. This is very much needed as many of windows 10's default firewall rules contain spaces and brackets () characters.
 2015-10-05 21:10:59 +01:00
Brian Coca
ebbd7748b1 doc formatting fixes 2015-10-05 11:57:38 -04:00