Commit graph

11446 commits

Author SHA1 Message Date
James Cammarata
b21875d5a9 Make sure 'item' variable is set when using first_available_file
Fixes #8220
2014-07-24 00:05:26 -05:00
someda
1b1d5d0d3d fix an issue that copying directory will fail when trying to change file attributes and the target file already exists on remote
- the issue was introduced by the commit 84759faa09
2014-07-24 14:03:36 +09:00
James Cammarata
2cc602beea Fixes for module param counting and additional shell quoting issues 2014-07-23 22:54:59 -05:00
James Cammarata
091b76efaa Fixes to parsing tests to remove trailing space 2014-07-23 22:54:39 -05:00
Michael DeHaan
1064550b47 Add missing file. 2014-07-23 23:32:45 -04:00
Michael DeHaan
a21092d7c2 Add missing role test file. 2014-07-23 22:35:24 -04:00
Michael DeHaan
5a763fb5b6 Add some negative tests on the same parsing infrastructure. 2014-07-23 22:34:56 -04:00
Michael DeHaan
02c63cee26 Add a lot of tests to verify parsing routines for scenarios that should pass. Some changes TBD, like stripping command spaces off end of expressions. 2014-07-23 22:10:58 -04:00
Berend de Boer
869cc7947e Default for fstab missing, causing KeyError: 'fstab' 2014-07-24 13:14:46 +12:00
Michael DeHaan
f9f37a5070 Merge pull request #8263 from bennojoy/unarchive_fix
fix for unarchive 8257
2014-07-23 19:11:08 -04:00
Benno Joy
ac85d8444b fix for unarchive 8257 2014-07-23 14:50:16 +00:00
Nacho Coloma
57428c48a2 Bugfix: bulletproof unexpected_error_msg at gce.py
This method was still failing for me with a "missing http_code" message. After applying this change, the error message is:

```
msg: Unexpected response: {'value': 'PyCrypto library required for Service Account Authentication.'}
```

I wanted to contribute a rock-solid `unexpected_error_msg` implementation.
2014-07-23 16:45:24 +02:00
James Cammarata
d2a130971a Backporting CHANGELOG/RELEASES and packaging updates for 1.6.7-8 releases 2014-07-22 17:26:15 -05:00
James Cammarata
75e5b6401c Fixing up shell quoting issues 2014-07-22 10:09:11 -05:00
James Cammarata
593057515c Merge pull request #8223 from renard/create-fstab-if-not-exists
Create fstab if not exists
2014-07-21 15:03:14 -05:00
James Cammarata
8e940004c2 Fix ec2_setup task param quoting 2014-07-21 11:33:35 -05:00
Sébastien Gross
48128ec0ab [mount] make sure fstab exists
This is mainly to prevent from failing with no such file or directory
during module execution.
2014-07-21 18:32:02 +02:00
Sébastien Gross
f2e2337d07 [mount] Add documentation for fstab option 2014-07-21 18:30:59 +02:00
James Cammarata
84759faa09 Security fixes:
* Strip lookup calls out of inventory variables and clean unsafe data
  returned from lookup plugins (CVE-2014-4966)
* Make sure vars don't insert extra parameters into module args and prevent
  duplicate params from superseding previous params (CVE-2014-4967)
2014-07-21 11:20:49 -05:00
James Cammarata
00e089e503 Revert "Explicitly set the user option for ssh connections"
This reverts commit 0f91add86f.

Fixes #8216
2014-07-21 10:32:55 -05:00
James Cammarata
571dbe09c3 Merge pull request #8214 from hacosta/checkmode
Add checkmode support for test-module script
2014-07-21 09:45:34 -05:00
Hector Acosta
b8cbf1370f Add checkmode support for test-module script
Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
2014-07-20 13:54:30 -05:00
Michael DeHaan
2769b3d0b2 Update version_added attribute on recent GCE module additions. 2014-07-19 19:08:28 -04:00
Michael DeHaan
98c6688343 Merge pull request #6976 from clconway/gce-snapshots
Adds support for snapshots and extra persistent disks to the gce modules
2014-07-19 19:07:29 -04:00
Michael DeHaan
dc262a0169 Merge pull request #8209 from hacosta/hacosta_7300
Add check_mode support to authorized_key. Fixes #7300
2014-07-19 19:00:52 -04:00
Hector Acosta
ec70bb01ef Add check_mode support to authorized_key. Fixes #7300
Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
2014-07-19 17:55:58 -05:00
Brian Coca
b65536bc56 removed parent, wasn't very useful and caused problems across versions
fixed cache expiration
2014-07-19 15:54:58 -04:00
Brian Coca
900a9f9556 added environment variables as config overrides for vmware inventory
fixed vmware properties, was getting parent's properties
cache now actually works
removed tags, they were not the ones i was looking for
renamed cache defaults fixed ini file to match
2014-07-19 13:11:31 -04:00
Lee Gillentine
69337362e7 Adding another example to demonstrate unarchive working entirely on a remote machine 2014-07-18 22:22:37 -05:00
Michael DeHaan
f0aab114ea Merge pull request #8196 from kustodian/playbooks_variables.rst
Fixed documentation in playbooks_variables.rst
2014-07-18 18:59:16 -04:00
Michael DeHaan
9caa93c1cf Add note about useful quote filter. 2014-07-18 18:23:48 -04:00
kustodian
dea19070e2 Fixed documentation in playbooks_variables.rst 2014-07-18 20:29:25 +02:00
Wayne Rosario
24a3d55c78 Adding Integration Tests for mysql_db module
Adding the following Test Coverage for RedHat and Debian OS:

 - Use mysql_db module to create, delete databases using different encoding.
 - Backup/Restore databases using different file format: sql, gz and bz2.
 - Create and delete databases using different user privilege.
 - Assert database creation, deleting and content using system commands.
2014-07-18 12:50:58 -04:00
James Cammarata
cc6ad40534 Merge pull request #8191 from Jmainguy/mysql_db_8173
This fixes 8173, if target was not defined it would break, now it wont
2014-07-18 10:16:02 -05:00
Joseph Benden
da5e32b316 Needs additional divisor. 2014-07-18 07:55:24 -07:00
Jonathan Mainguy
6789098bc5 This fixes 8173, if target was not defined it would break, now it wont 2014-07-18 09:52:37 -04:00
Michael DeHaan
9fac3b0dc5 Merge pull request #8187 from willangenent/devel
Fix for issue #8152: Missing auth headers and a faulty JSON decode
2014-07-18 07:52:07 -04:00
Will Angenent
0e33db837a Fix for issue #8152: Missing auth headers and a faulty JSON decode
Looks like this regressed in commit 9730157 due to fetch_url refactors.
2014-07-17 23:04:51 +01:00
Michael DeHaan
d4548fdd01 Merge pull request #8185 from retr0h/retr0h/align-markdown-headers
Retr0h/align markdown headers
2014-07-17 17:51:11 -04:00
Michael DeHaan
3a89cbdfa5 Merge pull request #8184 from yasn77/use_puppet_facts
Enable puppet facts
2014-07-17 17:48:57 -04:00
John Dewey
4432ca3836 Align markdown headers
A fairly trivial change since `Role Name` and `Example Playbook`
will likely be modified anyways.  However, since all the other
sections are aligned properly, felt it would be nice to "clean this up".

Before:

    Role Name
    ========

    Example Playbook
    -------------------------

After:

    Role Name
    =========

    Example Playbook
    ----------------
2014-07-17 10:29:58 -07:00
Yasser Nabi
8a6bbfd3b5 Enable puppet facts
Currently facter facts omit facts that a distributed via Puppet. This
commit adds the `--puppet` option.

In cases where puppet is not installed, the command sends a warning to
STDERR *but* completes successfully. So should not cause any issues.

The benefit is, filtering can be done based on facts set by Puppet.
2014-07-17 17:53:12 +01:00
James Cammarata
7c2cb58673 Merge pull request #8142 from jlaska/updated_ppa
Update docs to mention new PPA
2014-07-17 10:48:05 -05:00
Michael DeHaan
0fad9575e9 Refine error message about invalid ops since people forget to indent tasks fairly often. 2014-07-17 10:13:10 -04:00
James Cammarata
0e5b0a2e97 Revert "Set Jinja2's keep_trailing_newline=True in template_from_string."
This reverts commit 7a8eb0b670.
2014-07-17 09:07:04 -05:00
James Laska
03efbfca29 Correct string concatenation error 2014-07-17 08:57:47 -04:00
Michael DeHaan
515d10fd88 Merge pull request #8172 from phenomenes/channel-key-parameter
Adds channel key parameter
2014-07-17 08:14:26 -04:00
Michael DeHaan
bc194740c8 Merge pull request #8166 from scottbrown/bugfix-ansible-vault-read-password-does-not-close-file-handle
Fixing improperly closed file handle in ansible vault
2014-07-17 08:06:17 -04:00
Michael DeHaan
3aa10d9db5 Merge pull request #8145 from amandolo/ec2_tag
Fix EC2_TAG module output structure when listing tags
2014-07-17 07:45:53 -04:00
Jimena Cabrera-Notari
7efd8b61a6 Adds channel key parameter 2014-07-16 21:44:52 +01:00