cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
36216 commits 47 branches 390 tags 440 MiB
Commit graph

20427 commits

Author SHA1 Message Date
René Moser
6578403288
cs_zone_facts: implement return facts as ansible returns (#36993) 2018-03-05 11:42:38 +01:00
Abhijeet Kasurde
d1eb4fe58c
VMware: Refactor vmware_target_canonical_facts (#36964) 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2018-03-04 10:20:47 +05:30
Abhijeet Kasurde
e0945900df
New module: digital_ocean_snapshot_facts (#35897) 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2018-03-04 10:19:58 +05:30
John Smith
8824a8fe23 Assume firewall is offline on DBUS_ERROR during init (#36486) 
During init, the FirewallClient tries to connect to the DBUS socket.  If it
fails to connect it should be safe to assume firewalld is offline.
 2018-03-03 21:59:10 -06:00
Patrick Marques
83aaa8137a Fix Base64 decode TypeError (#36968) 
```
TypeError: expected bytes-like object, not str
```
 2018-03-03 16:33:07 -05:00
Abhijeet Kasurde
b973fff276
New module: digital_ocean_load_balancer_facts (#36966) 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2018-03-03 21:55:54 +05:30
Abhijeet Kasurde
3ead89e3c5
New module: digital_ocean_tag_facts (#36965) 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2018-03-03 21:55:21 +05:30
Will Thames
aa1e491244 [cloud aws_s3] Enforce required parameters for the various aws_s3 modes (#36767) 
[cloud aws_s3] Most modes require `object` parameter, and this is easy to
get wrong (e.g. through confusion with the `dest` parameter). As
it's as easy to enforce, let's do that.
 2018-03-02 16:33:04 -05:00
Will Thames
836d7a42a4 Remove old boto documentation and promote AnsibleAWSModule (#36763) 
There should no longer be a need for boto documentation - it
just adds significant extra clutter to the guidelines.

AnsibleAWSModule greatly improves the codebase to such an extent
that we should mandate it for new code unless there is a
documented good reason.
 2018-03-02 14:03:12 -05:00
Abhijeet Kasurde
3a161fa157
VMware: new module : vmware_datastore_maintenancemode (#36436) 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2018-03-02 23:35:53 +05:30
Ryan Brown
2f72d082c0 Use Tower v2 API when available, falling back to v1 where necessary (#36663) 
* Use Tower v2 API when available, falling back to v1 where necessary
 2018-03-02 11:31:53 -05:00
Kevin Breit
a3390b63fe Reversed orser of icmp_type and icmp_code per bug 36378 (#36380) 2018-03-02 16:09:32 +01:00
Trishna Guha
ef7f3fcab6
eos_static_route fix (#36903) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-03-02 08:50:27 +05:30
Ed Costello
07bc98f019 Additions to AWS Module Guidlines from Pull Request Feedback (#36834) 
* Update doc of AnsibleAWSModule to remove incorrect connect example.

Current example uses aws_connect method which no longer exists. Replace
this with the client and resource methods that do exist.

Also remove try/except block in connect example as guidelines imply that
there aren't connection errors thrown on connection, just when later
sing the connection.

* Update AWS module guidelines to include the AnsibleAWSModule connection methods.

* Add information on integration testing to the AWS module guidelines.

* Add information on common documentation fragments to AWS module
Guidelines.

* Changes as requested on PR.

* Restructure connection section to start with current best practice
* Explain the use of the CI build groups
* Use YAML Anchors for aws credentials example

* Replace guidance on use of test groups with link to aliases file.

This achieves the goal of explaining why this file is necessary without
introducing overhead of keeping documentation up to date when test
groups change.
 2018-03-02 11:40:01 +10:00
Dag Wieers
858d10a91a
Clean up VMware BOTMETA and author/license info (#36873) 
* Clean up vmware BOTMETA

This removes everything that's already part of the module docs. So
basically the BOTMETA file only extends the information from the module.

* Updated author information and copyright statement
 2018-03-02 01:07:17 +01:00
Sloane Hertel
9deef5626f Only create tags if tags are provided (#36921) 2018-03-01 15:30:08 -05:00
Ryan Petrello
0e7106b106 properly pass /api/v1/ credential fields for older Towers (#36917) 2018-03-01 15:22:29 -05:00
Mikhail Naletov
7ade607525 Add variables and variable_file in terraform module (#36879) 
* Fixes #36837

Added terraform variables for validate command

* Fixes #36837

Changed method from append to extend.
 2018-03-01 12:50:49 -05:00
Ganesh Nalawade
b12e90311f
map network_os to ncclient device_params (#36819) 
* map network_os to ncclient device_params

Fixes #36786

* update device map

* Add default netconf fallback plugin
 2018-03-01 22:23:14 +05:30
Ryan Petrello
a82043939b properly detect the absence of credential_type in older tower-cli (#36908) 2018-03-01 10:36:18 -05:00
Chris Houseknecht
ac11027d58
Convert key to snake. Fixes #36845. (#36887) (#36904) 2018-03-01 10:03:32 -05:00
Pierrick Caillon
808f45db55 Allow configuration of manual mac address (#35504) 2018-03-01 20:24:40 +05:30
Kevin M. Gallagher
3a6f0fbb9c Allow inversion of uid_owner match in iptables module (#36073) 
Fixes #20747 and updates documentation for uid_owner in iptables.py
 2018-03-01 12:24:02 +00:00
Shawn Q Jackson
9db509db80 corrected typo in documentation examples (#36894) 2018-03-01 08:55:28 +01:00
Ganesh Nalawade
41d75783b5
Fix junos_command py3 related issues (#36782) 
Fixes #36204

*  tostring() input string shoulb be in byte string format
*  to_ele() input is required in unicode format
 2018-03-01 12:09:11 +05:30
Trishna Guha
2fbfce06e7
Fix nxos_interface multiple issues (#36827) 
* fix interface_type

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix setting mtu, doc for state check param, doc for params applicable for ethernet intf

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* speed idempotence and add unittest

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fabric_forwarding_anycast_gateway applicable for svi type intf only

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix speed

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-03-01 10:56:16 +05:30
ABond
e2615308f9 Include Digital Ocean Token Alias (#36810) 2018-03-01 09:56:53 +05:30
Abhijeet Kasurde
0694aca2a0
VMware: refactor configure disk logic (#36617) 
This fix corrects logic related to disk parameters.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2018-03-01 09:36:54 +05:30
Brian Coca
809106ba77 fix unixy when debug's msg is not text (#36882) 
fixes #36850
 2018-03-01 09:23:39 +10:00
Pilou
274a4b0688 gitlab_project: don't ignore errors (#36702) 
* gitlab_project: check that errors are reported

* gitlab_project: report encountered errors

Fix #36495
 2018-02-28 23:22:47 +01:00
Jordan Borean
c3a805aa3c minor wording changes to remove ambiguity 2018-02-28 16:47:41 -05:00
Michael Gajda
45e7689335 Fix lineinfile example 
The examples comment said 'Add a line to a file if it does not exist, without passing regexp' which suggests, that the file is being created. But the default for 'create' is false. Thus the example lacked this option.
 2018-02-28 16:47:41 -05:00
Yanis Guenane
6633eaa2c1 crypto: Fix incorrect type for privatekey_passphrase (#36868) 
Fix incorrect type for privatekey_passphrase path -> str
 2018-02-28 17:19:22 +01:00
Abhijeet Kasurde
529bc0edc6
New module: digital_ocean_size_facts (#35898) 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2018-02-28 20:11:53 +05:30
mikedlr
3f19ef680a aws_ssm_parameter_store module - value parameter should be no_log since it's often a secret (#36843) 2018-02-28 14:40:58 +00:00
Gaurav Rastogi
60e39b9718 Updated the documentation of modules to match argspec including the type setting for bool parameters (#36821) 2018-02-28 14:38:03 +00:00
Ondra Machacek
365220bea5 ovirt_vms: Fix NoneType in placement policy check (#36775) 
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1549082
 2018-02-28 08:05:58 -05:00
maorlipchuk
5859c102ee Add documentation for import FCP storage domain (#36780) 
FCP storage domain task, does not need to contain port or address
since the storage domain is already on the Host.
Added an example for FCP import.
 2018-02-28 08:05:48 -05:00
Ondra Machacek
a0db015454 ovirt_host_networks: Fix removing the label (#36783) 2018-02-28 08:05:32 -05:00
Ondra Machacek
d1214484e6 ovirt_vms: Fix boot devices idempotence (#36833) 2018-02-28 08:04:28 -05:00
Claes Nästén
042c111563 nso_config break cycles in dependency sorting (#36828) 
False assumption that values can not have cyclic dependencies. Fix by
removing dependency on self and look for cycles, if found remove
dependency to get a partial sort done.
 2018-02-28 11:16:49 +00:00
Ed Costello
645952c139 Add aws_caller_facts module and use it in setup-iam.yml (#36683) 
* Add aws_caller_facts module and use it in setup-iam.yml

This removes the dependency on having the command line AWS tools
installed.
 2018-02-28 16:30:34 +10:00
saichint
db43fe6a76 nxos_facts fix and integration tests (#36796) 
* fix nxos_facts ipv6 error

* time_range not supported for N35
 2018-02-28 10:45:50 +05:30
Abhijeet Kasurde
8d49bb6eee
VMware: new module: vmware_host_capability_facts (#36497) 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2018-02-28 09:54:52 +05:30
Dag Wieers
398b3a4d76
ACI: Parameter username is not required (#36817) 2018-02-28 05:07:56 +01:00
Dag Wieers
68b39f7a84
Parameter method is not required (#36816) 2018-02-28 04:56:16 +01:00
Simon Dodsley
5b5a79917d Fix author string in documentation section (#36798) 2018-02-27 20:25:24 +00:00
Simon Dodsley
3240fee9fd Add Pure Storage FlashBlade Snapshot module (#32505) 2018-02-27 20:07:34 +00:00
Claes Nästén
e75989ec88 nso_config work around ordering issues (#36774) 
Include dependencies when sorting entries to avoid issues with certain
versions of NSO.
 2018-02-27 15:22:57 +00:00
Chandra Shekar Rangavajjula
52627f3fa0 Added extra choice floppy for bootdev option in ipmi_boot module (#36174) 2018-02-27 15:18:55 +00:00
Julien Vey
57f01c63e9 Add missing import keyword into snippet in Guidelines 
PR #36779
 2018-02-27 15:22:00 +01:00
Abhijeet Kasurde
443327f665
New module: digital_ocean_region_facts (#35911) 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2018-02-27 19:24:29 +05:30
nwsparks
e15a903bdf Win lineinfile fix (#35100) 
* win_lineinfile: fix #33858. Removed conversion from \r\n

* win_lineinfile: added test for #33858

* win_lineinfile: added documentation and more tests for change

* win_lineinfile: fixed wrong hash in testing
 2018-02-26 19:34:44 -05:00
Alex Ratner
c2feab0606 fix plugin-to-doc naming mismatch, typos, grammar (#36366) 2018-02-26 14:25:28 -08:00
Giovanni Sciortino
602f059875 Add atomic_move in ini_file module 
Fixes #34181
 2018-02-26 10:53:40 -08:00
Ryan Petrello
641f8b4ef6 tower cred: support credential kind/type for /api/v1/ and /api/v2/ (#36662) 
older versions of Tower (3.1) don't have a concept of CredentialTypes
(this was introduced in Tower 3.2).  This change detects older versions
of pre-3.2 tower-cli that *only* support the deprecated `kind`
attribute.
 2018-02-26 13:12:54 -05:00
Peter Sprygada
fb6a8c0133
fix cliconf get_config method to match base signature (#36682) 
This commit fixes up the get_config method to match the minimum method
signature as defined by the base class.  Without this patch, the
get_config method calls will fail in some cirumstances.
 2018-02-26 10:56:22 -05:00
Michael Scherer
eb162bdf7f Add space between arguments for acme-tiny (#36739) 
Currently, the module fail with a error saying that --acme-dir is mandatory.
Looking at the commandline:

    /usr/sbin/acme-tiny --chain --account-key /srv/letsencrypt/acme_key/acme.key
    --csr /srv/letsencrypt/nginx_certs/www.example.org.csr--acme-dir /srv/letsencrypt/webroot",

We can see that the space before --acme-dir is missing.
 2018-02-26 09:15:17 -05:00
Joni Salmi
ff0f6286d7 Docker service update project_name doc (#36713) 
```
FAILED! => {"changed": false, "msg": "Parameter error - project_name required when providing definition."}
```
 2018-02-26 08:25:50 -05:00
Claes Nästén
2789cc5c09 NSO ValueBuilder improvements. 4.5 leaf-list compatability. (#36583) 
Fix issues in ValueBuilder used in nso_config and nso_verify so that it
can handle leaf-list in NSO 4.5 and detect identityref types from
unions.

Fail gracefully if a type is not found.
 2018-02-26 13:18:20 +00:00
Mário Santos
8b52006d5c Fix sanity checks in OpenStack docs fragment (#36722) 
* Fix sanity checks in OpenStack docs fragment

Signed-off-by: Mário Santos <mario.rf.santos@gmail.com>
 2018-02-26 13:05:53 +00:00
Peter Sprygada
93b795baf0
allows ib_spec attrs to be filtered in update (#36673) 
* allows ib_spec attrs to be filtered in update

This change will allow the ib_spec entries to be be filtered on a change
object by setting the update keyword to false.  The default value for
update is true.  When the update keyword is set to false, the keyed
entry will be removed from the update object before it is sent to the
api endpoint.

fixes #36563

* fix up pep8 issues
 2018-02-26 07:55:26 -05:00
René Moser
cdb2969703
cs_sshkeypair: fix ssh key rename (#36726) 
* tests: cs_sshkeypair: add reproducer for failed key rename

* cs_sshkeypair: fix rename ssh key
 2018-02-26 13:43:40 +01:00
Abhijeet Kasurde
581a0637ba
DigitalOcean: new module: digital_ocean_volume_facts (#36004) 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2018-02-26 16:15:15 +05:30
Abhijeet Kasurde
4c20d16549
DigitalOcean: new module: digital_ocean_account_facts (#36003) 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2018-02-26 14:11:26 +05:30
Abhijeet Kasurde
d94a1ef4cc
VMware: refactor vmware_datastore_facts (#36423) 
This fix adds datastore cluster details about datastore in returning
facts. Updated documentation and tests.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2018-02-26 13:23:22 +05:30
Abhijeet Kasurde
435649274b
VMware: Hardware version support (#36562) 
This fix adds support for specifying hardware version for
virtual machine.

Fixes: #35831

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2018-02-26 13:21:43 +05:30
Trishna Guha
44332bda78
fix nxos_vlan aggregate (#36710) 
* fix nxos_vlan aggregate

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-02-26 12:29:49 +05:30
Trishna Guha
d6912cf40e
nxos_linkagg fix (#36706) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-02-26 11:21:51 +05:30
Ganesh Nalawade
5a6b893240
Decouple config and state check in vlan and vrf network modules (#36386) 
* Decouple config and state check in {network_os }_vlan and { network_os }_vrf modules

Fixes #35567
Fixes #34754

`interfaces` option is used for configuration as well as operational state
check. If interface is configured to given vlan or vrf but if
operational state of interface is disabled it results in module failure.

Fix is to decouple same option usage for config and state.
With this fix `interfaces` is used as config option and a new
option named `associated_interfaces` will be used for intent check
for assigned interfaces.

* Fix CI failures

* Fix review comment

* Fixed integration test failure
 2018-02-26 09:23:54 +05:30
Dag Wieers
8f6eea50db
More improvements to ACI module docs (#36689) 
* More improvements to ACI module docs

* Asorted improvements

* Found 2 more

* Improvements to aci_rest documentation
 2018-02-25 19:13:16 +01:00
Dag Wieers
07e8fb5dbb
Windows: Clean up documentation (#36684) 
This PR includes:
- Further cleanup of BOTMETA.yml
- Cleanup of author github handles
- Use of proper booleans
- One-line license statement
- Copyright format statement
- Smaller cleanups
 2018-02-25 03:09:54 +01:00
Dag Wieers
97fde8c760
ACI: Asorted fixes to documentation (#36681) 2018-02-24 22:50:54 +01:00
Dag Wieers
665f5b4e9c
ACI: Improve module index short_description (#36665) 2018-02-24 01:27:37 +01:00
Dag Wieers
7da7ba79bc Add anchors to some guides and all module categories (#36642) 
* Add anchors to some guides and all module categories

This is required if we want to use *absolute* :ref: references instead of *relative* :doc: references.

* Update the Cisco ACI Guide reference

* Add `aci_guide` anchor

* Add `network_guide` anchor

* Add category anchor

* Improve readability

* Fix small typo
 2018-02-23 17:10:47 -06:00
Ed Costello
2a0c7c4331 Fix documentation of validate_certificates option in aws doc_fragment. 
Unignore sanity test failures for AWS modules caused by this common
fragment.
 2018-02-23 13:21:44 -08:00
Brian Coca
2f13ddbd69
debug should have item (#36534) 
* debug should have item

* item should only be present when var
 2018-02-23 15:12:14 -05:00
Brian Coca
ef40e5e3b2 protect against plugins using verify incorrectly 
assume false on any errors
 2018-02-23 15:11:01 -05:00
Ryan Petrello
8a41233202 tower cred: update kind options in documentation 2018-02-23 10:49:07 -05:00
Ryan Petrello
cd6855275e tower cred: filter user name lookup by the proper key 2018-02-23 10:49:07 -05:00
Ryan Petrello
9cb4b70e27 tower cred: implement credential /api/v1/ kind compatability 2018-02-23 10:49:07 -05:00
Thierry Bouvet
640749d54f Fix credentials for Tower API V2 2018-02-23 10:49:07 -05:00
Gittins
a1241d99ee Updated examples aci_contract_subject_to_filter.py (#36626) 
Changed examples to reference the correct module name. Previously the examples used "aci_subject_filter_binding".
 2018-02-23 13:00:26 +01:00
Pilou
07927f52ae filesystem: fix documentation (#36556) 2018-02-23 10:59:38 +00:00
Martin Krizek
a79a5439c8
yum: fix yum version comparison (#36573) 2018-02-23 08:55:11 +01:00
Bruno
a7db945ac6 aci example minor fix testing actual real life scenario examples (#36613) 2018-02-23 03:04:40 +01:00
Bruno
68a97ca558 added additional examples for aci modules (#36612) 
* added additional examples for aci modules

* small fix on aci_fabric_node

* removing jina2 for clarity
 2018-02-23 02:39:58 +01:00
Julien Vey
d212bcf1e7 ec2_group:documentation explicit a behaviour for sg rules (#36586) 2018-02-23 09:24:25 +10:00
Chris Houseknecht
4a8b4bb8a8
Bump OpenShift client req to 0.4.3. Fixes openshift_scale. (#36601) 2018-02-22 16:31:47 -05:00
Simon Dodsley
b96ab46566 Initial commit for Pure Storage FlashBlade module (#32467) 2018-02-22 15:33:48 -05:00
Sloane Hertel
73fd593d45
aws_ec2 inv plugin: remove extra call to verify_file (#36588) 
* Remove extra call to verify_file

* Allow next inventory plugin to be tried if the file isn't verified
 2018-02-22 12:10:47 -05:00
Richlv
0e0d6cf4f2 Update zabbix_maintenance.py (#36123) 
clarify that removal happens by name - while expected, it's good to be explicit
 2018-02-22 10:46:04 -05:00
gratuxri
d31d981aa5 Updated vmware URL for guest_ids (#36511) 2018-02-22 12:17:11 +05:30
Matt Martz
a4df4d33ac Fix types when evaluating interpreter (#36541) 
* Fix types when evaluating interpreter. Fixes #36536
* Rename variables that contain bytes to b_*
* Get rid of to_text() and to_bytes() calls that do nothing (because the
  data is already the proper type)
 2018-02-21 18:03:16 -08:00
Jordan Borean
ef4f8851dc
win_feature: better error handling to make it easier to debug issues (#36491) 
* win_feature: better error handling to make it easier to debug issues

* removed ignroed pslint rules that are no longer needed
 2018-02-22 11:33:48 +10:00
Julien Vey
3abaa43b1c efs: improve documentation about the update of an efs (#36473) 2018-02-22 10:30:50 +10:00
Dag Wieers
a655bdb72e
Add missing copyright notice 
I did a large part of the unzip implementation and gtar functionality.
 2018-02-22 01:23:53 +01:00
Sam Doran
723daf3e3a
Check for regexp match when using insertbefore or insertafter (#36474) 
Add tests to cover this scenario
Fixes #36156
 2018-02-21 17:03:38 -05:00
Sloane Hertel
4d4553bbb0 [cloud] catch NoCredentialsError in boto3_conn (#36537) 2018-02-21 16:39:01 -05:00
Bruno
31bd214682 minor fix to exit_json for aci_static_binding_to_epg.py (#36540) 
* minor fix to exit_json for aci_static_binding_to_epg.py

* The aci.exit_json() call doesn't need arguments
 2018-02-21 21:17:41 +01:00