cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
22510 commits 47 branches 390 tags 440 MiB
Commit graph

9125 commits

Author SHA1 Message Date
Stefan Junker
4ee972190b docker: Use a list instead of a dict for volumes according to the docker-py docs. Do not add host-binds to volumes list. 2016-12-08 11:23:13 -05:00
gimoh
fd69c5687b Do not insert extra newline if line already contains it 
When using YAML multi-line strings, e.g.:

- lineinfile:
    dest: /tmp/foo
    line: >
      foo
      bar

the line already ends with a newline.  If an extra newline is appended unconditionally it will lead to inserting an extra newline on each run.
 2016-12-08 11:23:13 -05:00
Jens Carl
9ad15cdae9 - List the name servers of a zone. 2016-12-08 11:23:13 -05:00
Alexis Seigneurin
53e9caa1d0 - 'name' should not be required so as to allow uninstalling a cron_file 2016-12-08 11:23:13 -05:00
Annika Backstrom
6b2c89a422 Force redownload if sha256sum does not match 2016-12-08 11:23:13 -05:00
Igor Khomyakov
03483d2ea5 Check if a service exists 2016-12-08 11:23:13 -05:00
Federico G. Schwindt
b6258a1e4c Document globbing support 2016-12-08 11:23:13 -05:00
sysadmin75
f096359608 ansible-modules-core #530 fix - Mount module does not accept spaces in mount point path 2016-12-08 11:23:13 -05:00
Chris Church
3048626d6e Update docs, add example of using django_manage to run other commands. 2016-12-08 11:23:13 -05:00
Stefan Junker
50fe57fff3 Fix bind-volumes on docker >= 1.4.0 
If bind-volumes are submitted to docker >= 1.4.0 with the volumes set in addition to the binds, docker will create a regular volume and not bind-mount the specified path.
 2016-12-08 11:23:13 -05:00
Federico G. Schwindt
fa463fb1b7 Allow globbing in creates= and removes= directives 
Fixes 1904
 2016-12-08 11:23:12 -05:00
Robb Wagoner
e025effc99 include all launch config properties in the return 
make all properties available when registering the result
which is useful when wanting to launch a stand-alone instance based upon
an existing Launch Config.
 2016-12-08 11:23:12 -05:00
Toshio Kuratomi
870446dd6b Update version_added to 2.0 for the partial option 2016-12-08 11:23:12 -05:00
Jonathan Davila
82b809f0e2 new vpc module. does not contain subnet or route table functionality. 
changed name to ec2_vpc_net

refactored out IGW functionality
 2016-12-08 11:23:12 -05:00
Juan Picca
81ea358b09 synchronize module: add partial option 2016-12-08 11:23:12 -05:00
Toshio Kuratomi
5118d0e3b1 Add note about redirects proxies 
Fixes #1574
 2016-12-08 11:23:12 -05:00
Toshio Kuratomi
0a3150f7d7 Add version_added documentation to log_driver parameter 2016-12-08 11:23:12 -05:00
Toshio Kuratomi
9ecd06fb47 Fix apt_repository so that it does not modify the mode of existing repositories 2016-12-08 11:23:12 -05:00
Michael Weinrich
1f6c177da0 Use aws connect calls that allow boto profile use 2016-12-08 11:23:12 -05:00
Ryan Walls
01a28e7d80 Fix typo in Docker module. 2016-12-08 11:23:12 -05:00
Ryan Walls
9630972c2c Update docker module to avoid false positives when containers are first created. Also have the module check for api compatibility before trying to set a "--log-driver" option. 2016-12-08 11:23:12 -05:00
Ryan Walls
f5c1d8141b Set default "log_driver" option to None in docker module. 2016-12-08 11:23:12 -05:00
Ryan Walls
0df1b01cb2 Update docker module to look at log_driver variable when deciding if container configuration has changed. 2016-12-08 11:23:12 -05:00
Ryan Walls
3419a1e253 Add support for --log-driver option that docker released with Docker 1.6 2016-12-08 11:23:12 -05:00
Alex King
c8ae53b308 Extend hashes that can be specified by crypt_scheme beyond those understood by Apache/Nginx. 2016-12-08 11:23:12 -05:00
Sebastian Gerhards
a979417a4a rhn_register: add support for profilename 2016-12-08 11:23:12 -05:00
Jim Patterson
4185ffc43e Correct check mode for pip in virtualenv. 
Fix #412.  Check mode was always returning changed=True for pip
when the target was in a virtualenv.  The code now uses the normal
tests for determining if change status.
 2016-12-08 11:23:11 -05:00
Lorin Hochstein
abf314c258 django_manage: expand ~ in app_path parameter 
Allow users to specify app_path parameters that contain ~, for example:

app_path=~/myproject
 2016-12-08 11:23:11 -05:00
Pierre-Louis Bonicoli
c366e7acb2 apt_repository: fix file mode 
'set_mode_if_different' method should be called on dest filename and after
'atomic_move' method
 2016-12-08 11:23:11 -05:00
Patrick Roby
b318bc8b43 Add support for listing keys in a specific S3 bucket 
Includes support for specifying a prefix, marker, and/or max_keys. Returns a list of key names (as strings).
 2016-12-08 11:23:11 -05:00
James Cammarata
4239922d07 Updating version_added for new spot_type param in ec2 module 
Also made sure 'choices' were set on the module param, to catch errors
in user's playbooks, etc.
 2016-12-08 11:23:11 -05:00
Toshio Kuratomi
cb776e6190 Fix for when the password file did not exist previously 2016-12-08 11:23:11 -05:00
Jay Taylor
ed279d8175 Added support for spot request type specification (to support persistent spot requests). 2016-12-08 11:23:11 -05:00
Toshio Kuratomi
bd87c11c2a Read the url in in chunks so that we don't use as much memory for large packages 2016-12-08 11:23:11 -05:00
Toshio Kuratomi
2e7dcf3317 Small cleanups. * Import url(lib|parse|lib2) if needed by the module rather than relying on module_utils.urls to do so. * Remove stdlib modules from requirements * Use the if __name__ conditional for invoking main() 2016-12-08 11:23:11 -05:00
Toshio Kuratomi
5f27a073ba Bump amount of file to download in a chunk to 64k. 2016-12-08 11:23:11 -05:00
Jonathan Mainguy
dd0659c83d add download ability to unarchive module 2016-12-08 11:23:11 -05:00
zimbatm
99e2557b42 route53: add support for routing policies 
It is now possible to pass various routing policies if an identity is
provided.

This commit also introduces multiple optimisations:
* Only fetch records for the given domain
* Use UPSERT instead of DELETE+CREATE to update existing records
 2016-12-08 11:23:11 -05:00
billwanjohi
86e679fe3c iam: use modern helper to allow sts 
previous implementation ignored the session token when present
 2016-12-08 11:23:11 -05:00
James Cammarata
5cd3c6ebe6 Update choices and version_added for new gce.py param service_account_permissions 2016-12-08 11:23:11 -05:00
Michal Smereczynski
9d4b252f56 Added new Premium Storage instance sizes and case-related documentation clarification. 2016-12-08 11:23:11 -05:00
murdochr
aae140e6cd Change docs to reflect correct when syntax for matching variable strings as per MD's forum post as this fails with unhelpful error otherwise. 
https://groups.google.com/forum/#!topic/ansible-project/D2hQzZ_jNuM
 2016-12-08 11:23:11 -05:00
Monty Taylor
186fbd7645 Remove duplicate shade requirement 2016-12-08 11:23:10 -05:00
Monty Taylor
73cb529d2c Make sure we're always returning objects too 2016-12-08 11:23:10 -05:00
dagnello
072110c757 Resolving secgroup.id issue in this module 
secgroup['id'] was not being returned in all cases where the
specified security group exists.
 2016-12-08 11:23:10 -05:00
toninog
bea77c938e fixes to code to enable updates of user to groups and delete groups. Fixed example yaml to use groups 2016-12-08 11:23:10 -05:00
toninog
ab7678f199 Fixed more issues with the delete_group and paramater mismatch 2016-12-08 11:23:10 -05:00
Jonathan Mainguy
c9d1cc0ce3 remove blank lines from htpasswd file 
used standard mktemp()
 2016-12-08 11:23:10 -05:00
Vasyl Kaigorodov
758688a667 GCE module: added Service Account permissions sanity checks 2016-12-08 11:23:10 -05:00
Vasyl Kaigorodov
4400c5e163 GCE module: document Service Account permissions parameter usage 2016-12-08 11:23:10 -05:00
Vasyl Kaigorodov
97e880a27f GCE module: add posibility to specify Service Account permissions during instance creation 2016-12-08 11:23:10 -05:00
Jonathan Davila
6482ad964f iam certificate module 
boto import tweak

style patch
 2016-12-08 11:23:10 -05:00
Dan Abel
a51a8e1fd6 use aws connect calls that allow boto profile use 2016-12-08 11:23:10 -05:00
Hagai Kariti
b46a1ff3e1 Hostname module should update ansible_hostname 2016-12-08 11:23:10 -05:00
Vyronas Tsingaras
654d2d3f60 This enable one to find a datastore with no config_target supplied 
Signed-off-by: Vyronas Tsingaras <vtsingaras@it.auth.gr>
 2016-12-08 11:23:10 -05:00
Jon Hawkesworth
a00d86946d document file size limit for win_copy module 2016-12-08 11:23:10 -05:00
Vyronas Tsingaras
56957ca45e Remember power state when starting vm reconfigure 
This commit fixes #1391

Signed-off-by: Vyronas Tsingaras <vtsingaras@it.auth.gr>
 2016-12-08 11:23:10 -05:00
Matt Martz
158772ffc2 Fix some remaining rax asg idempotency checks 2016-12-08 11:23:10 -05:00
Benno Joy
17c185c8d1 enable azure to provision windows instances 2016-12-08 11:23:09 -05:00
Benno Joy
2314670952 enable the module to provision windows instances 2016-12-08 11:23:09 -05:00
Colin Hutchinson
97a2cd0bd9 Indentation fix for with and register in the ec2_vol example 2016-12-08 11:23:09 -05:00
Ritesh Khadgaray
9c3f9d23c8 Add the ability to grep for content 2016-12-08 11:23:09 -05:00
Vyronas Tsingaras
bdb33b5756 Properly check if vm_hardware contains keys 
This commit fixes #1475

Signed-off-by: Vyronas Tsingaras <vtsingaras@it.auth.gr>
 2016-12-08 11:23:09 -05:00
Vyronas Tsingaras
262e86b36b Use either esxi:dc,host OR cluster,resource_pool 
vsphere_guest now can deploy a template using a datacenter and hostname
as the target, instead of requiring a cluster and resource_pool.

This commit fixes #951.

Signed-off-by: Vyronas Tsingaras <vtsingaras@it.auth.gr>
 2016-12-08 11:23:09 -05:00
Robin Roth
abc89f0df5 add comment: ports need to be exposed. 
port mapping with this module only works for ports that are exposed either in the Dockerfile or via an additional arguments. This is different from the command line docker client, that is willing to also map ports that are not exposed.

This comments makes the behaviour more obvious.
 2016-12-08 11:23:09 -05:00
Monty Taylor
8ff71a3fa8 Actually use changed variable 2016-12-08 11:23:09 -05:00
Monty Taylor
4125b576e9 Return the secgroup for all present states 2016-12-08 11:23:09 -05:00
Monty Taylor
b955b2f5c8 Return resource objects from OpenStack modules 
It's not uncommon for people to want to do additional things after
creating a module. Also, add a note about it to the dev notes.
 2016-12-08 11:23:09 -05:00
Monty Taylor
89f95471f8 Return secgroup, not just id 2016-12-08 11:23:09 -05:00
Philip Kirkland
cc214afed6 adding 'encrypted' option into volume dict so ec2 module can easily include encrypted volumes 2016-12-08 11:23:09 -05:00
Toshio Kuratomi
88ae201b20 Fix bugs found by @kustodian 2016-12-08 11:23:09 -05:00
Toshio Kuratomi
f0f1dc985f Fix incorrect line breaking 2016-12-08 11:23:09 -05:00
Toshio Kuratomi
9f043d9ba8 Further optimizations pointed out by @kustodian in #1516 
* Only install yum-utils if needed (b/c we're going to use repoquery)
* Add a warning message explaining that why slower repoquery was used
  rather than yum API.
 2016-12-08 11:23:08 -05:00
Toshio Kuratomi
ba566501a8 Yum API is faster than calling out to repoquery. Looking through the commit logs it looks like we weren't previously doing that because of commit 14479e6adc 
The message there is that Yum API prints an error message if the
rhn-plugin is in use and no rhn-certificate is available.  So instead of
using repoquery in preference always here we use repoquery in preference
if the rhn-plugin is enabled.
 2016-12-08 11:23:08 -05:00
David Shrewsbury
9cbd7b2ece Remove os_security_group_rule module 
The rules module will have it's own branch.
 2016-12-08 11:23:08 -05:00
David Shrewsbury
6527f895a1 Remove 'result' value 
This value is pretty much useless, and a holdover from the old
module code. Let's remove it.
 2016-12-08 11:23:08 -05:00
Monty Taylor
eb2f3c8a44 Update version added 2016-12-08 11:23:08 -05:00
David Shrewsbury
7f0da6d851 Update the docstring for os_security_group 
Indicate that idempotence is on security group names, and give
an example for updating a security group description.
 2016-12-08 11:23:08 -05:00
David Shrewsbury
640dbee643 Update for latest shade API 
Shade version 0.7.0 introduces new API methods for creating,
deleting, and updating security groups. Let's use those and
clean up the module.
 2016-12-08 11:23:08 -05:00
az7arul
5ffb677b00 add include_doc option 2016-12-08 11:23:08 -05:00
Jamie Hannaford
f969bc0549 Fix get_launch_config var name 2016-12-08 11:23:08 -05:00
Jamie Hannaford
6b9310ecfb Fix attribute name for Auto Scale servers 2016-12-08 11:23:08 -05:00
Julia Kreger
d67ba5e25b Updating os_ironic_node module 
Updating the os_ironic_node module to the most recent version
including support for power and maintenance states.
 2016-12-08 11:23:08 -05:00
Julia Kreger
51149b9643 Updating os_ironic module 
Updating os_ironic module to the most recent version accounting for
changes in Ansible devel branch and the shade library since the
original creation of the module.
 2016-12-08 11:23:08 -05:00
nitzmahone
548ab163f5 Added choice validation for state arg 
fixes traceback on invalid state arg
 2016-12-08 11:23:08 -05:00
Toshio Kuratomi
ada424078b Restore setting cachedir when non-root but don't take a useless cachedir parameter to the function 
* Revert "Remove unused code"
  This reverts commit bcfba0c050.
* Re-add the changes to remove cachedir as a parameter
 2016-12-08 11:23:08 -05:00
Greg DeKoenigsberg
4cdd58064d Updated author data for modules 2016-12-08 11:23:08 -05:00
Sergei Antipov
e62f870859 mysql_user | Hide password 2016-12-08 11:23:08 -05:00
Greg DeKoenigsberg
eb881d7d5d Proper author info for all remaining modules 2016-12-08 11:23:07 -05:00
Greg DeKoenigsberg
18ca7aee07 Updating cloud modules with proper github author information 2016-12-08 11:23:07 -05:00
Robert Estelle
8b2327fe3a Fix missing instance_id param in ec2_eip. 2016-12-08 11:23:07 -05:00
Kamil Madac
1ae799f361 Better error handling in supervisorctl module. 
If execution of supervisorctl was not successful (exit code > 0),
module silently supress this error and returns changed = false,
which turns to OK task state.
This is very confusing, when supervisorctl needs authentication,
and credentials are not specified in module or are incorrect,
services are not restarted/started/stopped without raising an error.
 2016-12-08 11:23:07 -05:00
Monty Taylor
574bcac277 Add developer docs for the OpenStack modules 2016-12-08 11:23:07 -05:00
Hagai Kariti
b154ad4cbb ec2_vol: fix race conditions because we handle errors before actually deleting 
Just try to delete the volume and handle the error amazon sends
 2016-12-08 11:23:07 -05:00
Tyler Cross
9babe9b07d Get specific object version with S3 module. 
- allow specifying version for mode=get and mode=getstr
- when version specified doesn't exist give an error message that indicates so
 2016-12-08 11:23:07 -05:00
Pepe Barbe
5dc322b911 Add OS architecture and OS name to the Windows setup module 2016-12-08 11:23:07 -05:00
Monty Taylor
51ce05bfb9 Add Ironic Node module 2016-12-08 11:23:07 -05:00
Monty Taylor
e534753092 Add Ironic module 2016-12-08 11:23:07 -05:00
Monty Taylor
0447a88c80 Add OpenStack Object module 2016-12-08 11:23:07 -05:00
Monty Taylor
234a6c93c7 Add OpenStack Security Group support 
Two modules - one for security groups and one to manage rules in a
security group.
 2016-12-08 11:23:07 -05:00
Robert Estelle
ecae3403af Remove unnecessary wait_timeout parameter. 2016-12-08 11:23:07 -05:00
Robert Estelle
3798c8c0ce Refactoring of ec2_eip module. 2016-12-08 11:23:07 -05:00
Robert Estelle
41f7e4ed5e ec2_eip - PEP8 and minor style cleanups. 2016-12-08 11:23:07 -05:00
Robert Estelle
a41994974c EC2 Security Group - Validate parameters. 2016-12-08 11:23:07 -05:00
Edward Torbett
3a4d8f22a6 Renamed previous pkgs variable to installed_pkgs as spotted by @strahinja 2016-12-08 11:23:06 -05:00
Edward Torbett
dad26d70fa Corrected pkg to pkgs as noted by @abadger 2016-12-08 11:23:06 -05:00
Edward Torbett
9707a5a95e Added multi package operation to remove as suggested by @abadger. Adding to latest is a little more complex due to '*' support. 2016-12-08 11:23:06 -05:00
Edward Torbett
32180c3c0e Comments by @abadger 2016-12-08 11:23:06 -05:00
Edward Torbett
4b3fff108d Rather than executing yum once per package, execute yum once for all supplied packages. This is necessary when performing a yum upgrade involving multiple dependent packages installed from RPM, for example when upgrading from PostgreSQL 9.0.11 to 9.0.21 on a Red Hat server. 2016-12-08 11:23:06 -05:00
Ching Yi, Chan
be9cddbddf Refactoring for easier to read 2016-12-08 11:23:06 -05:00
Ching Yi, Chan
7cafbb5f05 Prevent memory-error from a large file 2016-12-08 11:23:06 -05:00
Soenke Ruempler
b57bcac72f Add support for SNS notification ARNs in CloudFormation 2016-12-08 11:23:06 -05:00
Andrea Mandolo
adb53cc3c5 Add "block_device_mapping" parameter on EC2_AMI Amazon module (DOCUMENTATION) - upgraded 2016-12-08 11:23:06 -05:00
Jon Hawkesworth
c86ed93f67 remove include of files options only relevant to unix from win_file.py documentation 2016-12-08 11:23:06 -05:00
Brian Coca
f66ed3a85e minor doc fixes on win_template 2016-12-08 11:23:06 -05:00
Bruce Pennypacker
4cb7df2631 Added delobj command to delete an object within a bucket 2016-12-08 11:23:06 -05:00
Jon Hawkesworth
a9b77e8480 corrected version added which I got wrong while rebasing 2016-12-08 11:23:06 -05:00
Jon Hawkesworth
5b6195e613 Fix win_copy problems described here: https://github.com/ansible/ansible-modules-core/issues/1404 and update documentation. 2016-12-08 11:23:06 -05:00
Brian Coca
b2dadaadf8 Revert "added innitial daemon-reloaded support to service module" 
This reverts commit 438d87d269.
 2016-12-08 11:23:06 -05:00
Brian Coca
3d42d8897e fixed doc issue with git 2016-12-08 11:23:06 -05:00
Brian Coca
523b4d638e updated version added 2016-12-08 11:23:05 -05:00
Louis-Michel Couture
03240cfcb6 Update example to remove outdated information 2016-12-08 11:23:05 -05:00
Brian Coca
61054921cf updated package examples 2016-12-08 11:23:05 -05:00
Brian Coca
d4d362b475 corrected copyright ... does a copied the copyrightnotice require copyright? 2016-12-08 11:23:05 -05:00
Brian Coca
0f30122750 may root help us all 2016-12-08 11:23:05 -05:00
Brian Coca
55d04f4ddf added innitial daemon-reloaded support to service module 2016-12-08 11:23:05 -05:00
Dionysis Grigoropoulos
59f7db899d git: Add option to verify GPG signature of commit 2016-12-08 11:23:05 -05:00
Alex Gandy
75fa5811db Added volumes dict to ec2_lc example 2016-12-08 11:23:05 -05:00
toninog
15b65fa115 Fixed bug in example where updating a user to a group Fixed bug in create_group and update_group whereby paramaters were not being set correctly. 2016-12-08 11:23:05 -05:00
Monty Taylor
97ce6a500d Update doc params and version_added 2016-12-08 11:23:05 -05:00
Benno Joy
f6f2359400 fix for 11177 where module readds rule even if the rules exists 2016-12-08 11:23:05 -05:00
Monty Taylor
29115f0602 AnsibleModule takes a dict as a param 2016-12-08 11:23:05 -05:00
Monty Taylor
dbf821ff67 Return a list of OpenStack clouds 
The main use of this is to feed jinja templating, so structure the
data returned slightly better for that purpose.
 2016-12-08 11:23:05 -05:00
Monty Taylor
b87c9002ae Add OpenStack Client Config module 
All of the ansible OpenStack modules are driven by a clouds.yaml config
file which is processed by os-client-config. Expose the data returned by
that library to enable playbooks to iterate over available clouds.
 2016-12-08 11:23:05 -05:00
Monty Taylor
58942eba2e Use the delete method from shade 
Sigh. Turns out glance v1 and glance v2 delete images differently too.
 2016-12-08 11:23:05 -05:00
Monty Taylor
8958deeb02 Don't update image properties if we're deleting 2016-12-08 11:23:05 -05:00
Monty Taylor
a4e4dbd863 Add OpenStack Image module 
Also deprecate old glance_image module
 2016-12-08 11:23:05 -05:00
Brian Coca
5ae6f5b767 reverting pep changes that were breaking documentation 2016-12-08 11:23:04 -05:00
Brian Coca
336c22bfd9 made non exec 2016-12-08 11:23:04 -05:00
Tim Mahoney
fb3c457122 Elasticache Subnet Group 2016-12-08 11:23:04 -05:00
Monty Taylor
0bc85d461b Add missing state parameter 2016-12-08 11:23:04 -05:00
Sankalp Khare
f7055c88de Fixed a typo in ec2_vpc module documentation 2016-12-08 11:23:04 -05:00
billwanjohi
ff7dfefbd6 cloudformation: accept local templates in yaml format 
Since the YAML data format is a subset of JSON, it is trivial to convert
the former to the latter. This means that we can use YAML templates to
build cloudformation stacks, as long as we translate them before passing
them to the AWS API. I figure this could potentially be quite popular in
the Ansible world, since we already use so much YAML for our playbooks.
 2016-12-08 11:23:04 -05:00
James Martin
38d0f31cac Streamlined rolling udpate algorithm. Still need to account for partials, and not waiting for instances if we're mass terminating them. 2016-12-08 11:23:04 -05:00
Demian Gemperli
1c5cb83ff3 Allow to add build flags for gem installation 2016-12-08 11:23:04 -05:00
whiter
fc53c2431d Added changed=True flag when new subnet groups created. Added conditional so that modify_db_subnet_group is only called when necessary and changed=True flag will be set. 2016-12-08 11:23:04 -05:00
Jonathan Davila
77fa67a240 author fix 2016-12-08 11:23:04 -05:00
Jonathan Davila
d4aff86349 iam_policy 2016-12-08 11:23:04 -05:00
Trevor Pounds
9de952cb3f Instance deregistration should try all associated ELBs. Fixes #869 2016-12-08 11:23:04 -05:00
Trevor Pounds
eff6307ac3 Use auto scaling group managed ELBs if present. 2016-12-08 11:23:04 -05:00
Jonathan Davila
a329dc05c0 iam module with fixes 
iam module. fix policy issue.

bugfix

allow for modifying path without declaring new_path
 2016-12-08 11:23:04 -05:00
Gugli
a00c078912 Add support for repos with svn:externals files 
When a SVN repository has some svn:externals properties, files will be
reported with the X attribute, and lines will be added at the end to
list externals statuses with a text looking like
"Performing status on external item at ....".
Such lines were counted as a local modification by the regex, and the
module returned a change, even though they were none.

To have a clean (and parsable) "svn status" output, it is recommended
to use the --quiet option. The externals will only appear if they have
been modified. With this option on, it seems even safer to consider
there are local modifications when "svn status" outputs anything.
 2016-12-08 11:23:04 -05:00
Raghu Udiyar
e6e8f65e92 Creating ami should be idempotent 
If the ami already exists, return details of the duplicate
ami instead of failing with an error.
 2016-12-08 11:23:04 -05:00
tedder
dd6d5f0cb5 feature pull request: catch and retry recoverable errors 
boto can throw SSLError when timeouts occur (among other SSL errors). Catch these so proper JSON can be returned, and also add the ability to retry the operation.

There's an open issue in boto for this: https://github.com/boto/boto/issues/2409

Here's a sample stacktrace that inspired me to work on this. I'm on 1.7, but there's no meaningful differences in the 1.8 release that would affect this. I've added line breaks to the trace for readability.

    failed to parse: Traceback (most recent call last):
      File "/home/ubuntu/.ansible/tmp/ansible-tmp-1419895753.17-160808281985012/s3", line 2031, in <module> main()
      File "/home/ubuntu/.ansible/tmp/ansible-tmp-1419895753.17-160808281985012/s3", line 353, in main download_s3file(module, s3, bucket, obj, dest)
      File "/home/ubuntu/.ansible/tmp/ansible-tmp-1419895753.17-160808281985012/s3", line 234, in download_s3file key.get_contents_to_filename(dest)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1665, in get_contents_to_filename response_headers=response_headers)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1603, in get_contents_to_file response_headers=response_headers)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1435, in get_file query_args=None)
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 1488, in _get_file_internal for bytes in self:
      File "/usr/local/lib/python2.7/dist-packages/boto/s3/key.py", line 368, in next data = self.resp.read(self.BufferSize)
      File "/usr/local/lib/python2.7/dist-packages/boto/connection.py", line 416, in read return httplib.HTTPResponse.read(self, amt)
      File "/usr/lib/python2.7/httplib.py", line 567, in read s = self.fp.read(amt)
      File "/usr/lib/python2.7/socket.py", line 380, in read data = self._sock.recv(left)
      File "/usr/lib/python2.7/ssl.py", line 341, in recv return self.read(buflen)
      File "/usr/lib/python2.7/ssl.py", line 260, in read return self._sslobj.read(len) ssl.SSLError: The read operation timed out
 2016-12-08 11:23:04 -05:00
Toshio Kuratomi
fa60891f68 Fix a problem introduced with #1101 and optimize privilege handling 
* If a db user belonged to a role which had a privilege, the user would
  not have the privilege added as the role gave the appearance that the
  user already had it.  Fixed to always check the privileges specific to
  the user.
* Make fewer db queries to determine if privileges need to be changed
  and change them (was four for each privilege.  Now two for each object
  that has a set of privileges changed).
 2016-12-08 11:23:03 -05:00
Tristan Fisher
75ef963922 removes bool type from validate. 2016-12-08 11:23:03 -05:00
Tristan Fisher
0180be25c4 standardizes bools in argument_spec 2016-12-08 11:23:03 -05:00
jaypei
fbc8d4ca4a use the right way to unescape line string Reference https://github.com/ansible/ansible/issues/10864 2016-12-08 11:23:03 -05:00
Feanil Patel
36dfb78831 Output the Internet Gatewoy id directly instead of in a dict. 2016-12-08 11:23:03 -05:00
Benno Joy
70188fe02a Fixes issue 1197 for s3 module, where the file gets downloaded even if checksums match 2016-12-08 11:23:03 -05:00
Feanil Patel
bfb36f0f1f Tell me what the igw id is if we created an igw. 2016-12-08 11:23:03 -05:00
Toshio Kuratomi
5027fc0642 Expand tildes and vars in the config file path 2016-12-08 11:23:03 -05:00
Brian Coca
d7bd36a215 Revert "Add deprecated documentation for _quantum_subnet" cause it was already added 
This reverts commit 3fa32c4984.
 2016-12-08 11:23:03 -05:00
Toshio Kuratomi
8576d1f9d1 Add deprecated documentation for _quantum_subnet 2016-12-08 11:23:03 -05:00
Will Thames
34e0e17090 Perform privilege grants/revokes only when required 
Use `has_table_privileges` and `has_database_privileges`
to test whether a user already has a privilege before
granting it, or whether a user doesn't have  a privilege
before revoking it.
 2016-12-08 11:23:03 -05:00
David Shrewsbury
67d8ff197e Rename os_subnet to os_subnet.py 2016-12-08 11:23:03 -05:00
Monty Taylor
acdc90f31d Add OpenStack Subnet module 
Also deprecated old quantum_subnet module
 2016-12-08 11:23:03 -05:00
xiaclo
8715ce07ae Fix issue #1156 
Fix as suggested in the issue.

https://github.com/ansible/ansible-modules-core/issues/1156
 2016-12-08 11:23:03 -05:00
Toshio Kuratomi
4f42e752e6 Allow playbook specified login_user and login_password to override config file settings 2016-12-08 11:23:03 -05:00
James Cammarata
46b60a5b70 Fix missing expanduser on chdir value 2016-12-08 11:23:03 -05:00
James Cammarata
d07378ceac Command module changes for v2 compatibility 2016-12-08 11:23:03 -05:00
Toshio Kuratomi
0af631499a Use a list comprehension instead of map and lambda 2016-12-08 11:23:02 -05:00
Toshio Kuratomi
8976b46888 Import ansible module_utils at bottom of file to not mess with line numbers in tracebacks 2016-12-08 11:23:02 -05:00
Toshio Kuratomi
b6257f73b4 Properly flip default for verifying server cert. Add nice error messages when the cert is invalid 2016-12-08 11:23:02 -05:00
Toshio Kuratomi
a4497a7ddf Change uri module to validate ssl certs by default 2016-12-08 11:23:02 -05:00
whiter
8ee2102993 Doc update to highlight use of body_type parameter 2016-12-08 11:23:02 -05:00
Toshio Kuratomi
c291c2dfea Fix for the new import code when password is empty 2016-12-08 11:23:02 -05:00
Jonathan Mainguy
a3f30540ca add :// url support for EL 5 2016-12-08 11:23:02 -05:00
Dennis Rowe
5109628693 Strip spaces around perms 2016-12-08 11:23:02 -05:00
billwanjohi
a6fd78af37 s3 put: add support for server-side encryption 
- added 'encrypt' boolean option
- reordered module options alphanumerically
 2016-12-08 11:23:02 -05:00
Toshio Kuratomi
b6a312e489 Minor fixups found during review of #582 2016-12-08 11:23:02 -05:00
Patrik Lundin
899788f1a7 service: Fix comments in OpenBsdService class. 
No functional change.
 2016-12-08 11:23:02 -05:00
Johann Schmitz
8f8109f1e0 Improved output of mysql_db plugin 
Show error number and error description on connect error to ease debugging.
 2016-12-08 11:23:02 -05:00
Andrew Pashkin
a960caae96 Add 'docker_api_version' to docker_image 
By default docker-py uses latest version of Docker API. This is not
always desireable, and this patch adds option to specify version, that
should be used.
 2016-12-08 11:23:02 -05:00
Jonathan Mainguy
7ab2ddbe2a escapeds changes 
fixed merge conflict

remove uneeded regexs

arrays
 2016-12-08 11:23:02 -05:00
Brian Coca
322518d06c stat doc fix fixes #1371 2016-12-08 11:23:02 -05:00
Robin Miller
a2f685a134 Replaced lambda functions with list comprehensions. 2016-12-08 11:23:02 -05:00
whiter
d252e7c08f Fix for issue #1332 - when instance is has finished deleting and get_db_instance returns None, exit gracefully 2016-12-08 11:23:01 -05:00
Robin Miller
8859a7cf8e Only revoke actually granted permissions, not 'ALL'. 
This prevents errors when the login_user does not have 'ALL'
permissions, and the 'priv' value contains fewer permissions than are
held by an existing user. This is particularly an issue when using an
Amazon Web Services RDS instance, as there is no (accessible) user with
'ALL' permissions on *.*.
 2016-12-08 11:23:01 -05:00
Brian Coca
7ccc2143fd sleep when only doing a time delay to avoid cpu churn 2016-12-08 11:23:01 -05:00
fdupoux
e34c7f31dc Refactoring to avoid duplication of code which manages the decompression of database dumps in various formats 2016-12-08 11:23:01 -05:00
fdupoux
9b83311471 Simplify code which prepares the decompression command 2016-12-08 11:23:01 -05:00
Toshio Kuratomi
dd4838e4aa Refactor dump compression and use get_bin_path for finding the compressors 2016-12-08 11:23:01 -05:00
fdupoux
aa79810cc8 Decompress mysql dumps on the fly using python subprocess during an import to simplify operation 2016-12-08 11:23:01 -05:00
Wang Qiang
86b6f39cf0 Do instance update after add tags to instance. 2016-12-08 11:23:01 -05:00
Jonathan Mainguy
20301427f8 fixes check mode for Ubuntu 14.04 2016-12-08 11:23:01 -05:00
James Cammarata
3e72a0657d Re-reverting windows modules PR #384 2016-12-08 11:23:01 -05:00
Vladislav Lewin
36ce019beb add SLE12 support to hostname.py 2016-12-08 11:23:01 -05:00
marko
de813195c5 Added support for foreign security groups (Fixes: #373) 2016-12-08 11:23:01 -05:00
Jesse Keating
96b03ce138 Add an openstack servers actions module 
This module supports a few of the server actions that are easy to
initially impiment. Other actions require input and provide return
values in the API calls that will be more difficult to impliment, and
thus are not part of this initial commit.
 2016-12-08 11:23:01 -05:00