Commit graph

23392 commits

Author SHA1 Message Date
Yixin Xu
5a35907b71 zabbix_host: fix link template error (#46521)
* add host interface before link template
2018-10-05 10:40:30 -04:00
Dag Wieers
b82f965616 mail: Fix regression when sending mail without SSL (#46403)
When refactoring the code the non-SSL use-case was broken.

The main cause is that we have no way to do integration tests for
testing SMTP.
2018-10-05 09:38:00 -04:00
rhodain
65952571d6 Ovirt_disk - Add ability to refresh passthrough disks (#46386)
* Ovirt_disk - Add ability to refresh passthrough disks

A new paramter "host" is added. When this paramter is specified the newly
created disk or an existing disk will refresh its information about the
underlying storage via the specified host. This oprion is only valid for
passthrough disks. This option requires at least the logical_unit.id to be
specified.

* Host search modification and some other minor changes.

* pep8 correction
2018-10-05 08:12:48 -04:00
Jordan Borean
02c11e6b51 azure_rm_common: use __version__ from module_util (#46184) 2018-10-05 07:02:44 -04:00
Martin Nečas
66b1c838c7 Ovirt delete snapshots after x days (#45551)
* ovirt add snapshot delete after x days

* update logic of deleting snapshot and rename it

* update docs and names of vars

* update docs syntax

* Update ovirt_snapshot.py

* put remove logic to function

* use default removing function for snapshot
2018-10-05 06:38:25 -04:00
Jonathan
4376417743 fix drain mode 'bool' (#30833) (#46478) 2018-10-05 03:55:42 -04:00
Martin Nečas
4c7bb32c1f Ovirt add kernel persist (#45555)
* ovirt add kernel persist

* Add description to kernel_params_persist

* update kernel_params_persist control logic

* correct pep8 syntax

* add condition for kernel_params

* put kernel persist check to function

* kernel persist check update tabs
2018-10-05 03:09:45 -04:00
Martin Nečas
d79be6a00c add external provider to ovirt network (#43636)
* add external provider to ovirt network

* add version added

* add example

* test of importing external network

* ovirt correct datacenter search in external provider

* repair importing external provider

* update external provider docs

* update pep8 syntax
2018-10-04 18:55:51 -04:00
Brian Lamar
73133d7708 [aws] ALB/NLB support SubnetMappings in AWS create LB call (#42060) 2018-10-04 16:53:32 -04:00
Brian Scholer
fbac32c5d0 Fix support for SubnetMappings and EIPs in NLB (#42979)
* Fix support for SubnetMappings and EIPs in NLB

* Fix style failures
2018-10-04 16:31:16 -04:00
Dag Wieers
8c64b4af7c win_reboot: Fix for ignore post_reboot_delay (#46360)
* win_reboot: Fix for ignore post_reboot_delay

This fixes an issue where win_reboot would be ignoring the provided
post_reboot_delay (and on Windows timing/waiting is everything!)

This must be backported to the v2.7 branch.

* Merge post-reboot handling into run()
2018-10-04 15:44:50 -04:00
Sam Doran
bcfdc37be0 Add documentation on underlying tools in user module (#46455) 2018-10-04 15:29:57 -04:00
Christian Kotte
a4961ff32a VMware: Add check mode support to module vmware_host_firewall_facts (#46265) 2018-10-04 05:28:53 -05:00
Christian Kotte
ab26119637 VMware: Add check mode support to module vmware_host_acceptance (#46260)
* Improve module description
* Add check mode support
2018-10-04 05:27:33 -05:00
Ganesh Nalawade
5e6eb921ae
Make default_operation optional in netconf_config module (#46333)
Fixes #46257

*  As per netconf rfc default-operation value is optional,
   hence removing the default value for default_operation
   option.
2018-10-04 09:47:19 +05:30
Dag Wieers
12d688c006 Docs: Clean up of 'fetch' module docs (#46330)
* Docs: Clean up of 'fetch' module docs

This is part of a series of module doc cleanups.

* Fixes as suggested by review
2018-10-03 22:31:31 -05:00
Dag Wieers
21d23829be Docs: Clean up 'win_reboot' module docs (#46377)
* Docs: Clean up 'win_reboot' module docs

This is part of a series of module doc cleanups.

* Remove hypothetical example
2018-10-04 13:19:58 +10:00
Sandra McCann
56f23594a5 add simple j2 example to vyos_config (#46442) 2018-10-03 22:13:52 -05:00
Dag Wieers
be0dc34b6f Docs: Clean up of 'template' module docs (#46297)
* Docs: Clean up of 'template' module docs

* Changed influenced by review comments
2018-10-03 22:12:25 -05:00
John Imison
c4cfa387ea Lookup plugin for rabbitmq (#44070)
* Adding a basic get lookup for rabbitmq.

* Always return a list

* If content type is JSON, make accessible via dict.

* Fixed incorrect json.loads variable and missing raise

* Change to document returned data

* Fixed pep8 issues

* Adding integration testing

* Moving lookup intgration tests to new target

* New rabbitmq lookup plugin (#44070).

* New rabbitmq lookup plugin (#44070).

* PR review feedback updates

* Testing pika is installed

* Minor mods to tests

* Check if connection is already closed or closing

* Updated tests and connection testing

* PR review feedback updates

* PR review include ValueError in AnsibleError output

* Suggesting to use set_fact when using returned variable more than once.

* Cleaned up some tests, added some notes and handling connection closure on some exceptions.

* Removed finally statement and added some additional error handling.

* Added some additional error handling.

* PR review updates.

* Additional integration tests and removing return in finally

* Updated version

* Changing back to running tests on ubuntu.

* Additional tests

* Running tests on  Ubuntu only

* Fixing syntax error

* Fixing ingtegration tests and a string/byte issue

* Removed non-required test and fixed BOTMETA

* Trying to fix integration test failure on ubuntu1404

* Some issues occured when handling messages from the queue with to_native.  Switching to to_text resolved the issues.

* Renaming channel to queue (thanks dch). Disabling trusty tests.
2018-10-04 11:25:09 +10:00
Dag Wieers
3f2f53681d Docs: Clean up 'win_service' module docs (#46407)
* Docs: Clean up 'win_service' module docs

This is part of a series of module doc cleanups.

* Fix typo pause vs paused

* Use both YAML list syntaxes
2018-10-04 11:23:41 +10:00
Sam Doran
b74279d14c Use proper index value with insertbefore on a one line file (#46071)
Add tests and changelog
2018-10-03 17:27:34 -04:00
Major Hayden
b6568c1c75 Docs: Cleanup make module docs (#46422)
Signed-off-by: Major Hayden <major@redhat.com>
2018-10-03 16:12:07 -04:00
Dag Wieers
d6a581502f Docs: Clean up of 'assemble' module docs (#46328)
This is part of a series of module doc cleanups.
2018-10-03 15:56:19 -04:00
Jordan Borean
ba638f40cf
ps-lint: ignore rules that are not relevant to Ansible (#46376) 2018-10-04 05:55:02 +10:00
Major Hayden
208b3c53dd Docs: iptables module cleanup (#46368)
Signed-off-by: Major Hayden <major@redhat.com>
2018-10-03 15:39:57 -04:00
Dag Wieers
79511d02a7 Docs: Clean up of 'file' module docs (#46327)
This is part of a series of module doc cleanups.
2018-10-03 15:22:35 -04:00
Bianca Henderson
0ab448531b Update asa_config.py (#46448)
<!--- Your description here -->

+label: docsite_pr
2018-10-03 15:03:19 -04:00
newtonne
bd849e8fb4 Macports: Add upgrade parameter and replace update_ports with selfupdate (#45049)
* macports: Replace update_ports with selfupdate

- Macports discourages use of `port sync` and recommends using `port
selfupdate` instead.
- Keep `update_cache` and `update_ports` as aliases.
- No longer require the `name` parameter so that `selfupdate` can be
used in a task by itself.

* macports: Add upgrade parameter

- New upgrade parameter which can be used to upgrade all outdated ports.

* Add changelog fragment
2018-10-03 13:58:55 -04:00
Major Hayden
84eb92d13d Docs: Cleanup selinux_permissive module docs (#46351)
Update the selinux_permissive instructions and add a comment to the
provided example.

Signed-off-by: Major Hayden <major@redhat.com>
2018-10-03 12:04:25 -05:00
Jordan Borean
e283e7d5dd fixed tests after EAP set to Stop globally, ci_complete 2018-10-03 09:17:27 -07:00
Yann Rouillard
ee3dfef016 Only delete key from redis in-memory cache if present (#35126)
Fixes #35120 : the redis cache plugin keeps key/value
entries in an in-memory cache to avoid hitting the
redis database each time.

The problem is that a cache entry is only set when
a value is get or set but it is always deleted when
trying to delete a value.

When the --flush-cache ansible-playbook option is used,
the redis cache plugin is first asked to remove every
entry corresponding to every hostname present in the inventory.
As no value as been set/get so far, it then tries to delete
an unexisting value from the cache and hence crashes with
a KeyError exception.
2018-10-03 11:06:44 -04:00
Christian Kotte
1589424c3e VMware: Add check mode support in vmware_host_config_facts (#46272) 2018-10-03 07:55:40 -05:00
Felix Fontein
77fee07a88 Change with_*: loops to loop: loops. Fix some examples. (#46373) 2018-10-03 02:41:34 -04:00
Jordan Borean
e972287c35 win_exec: refactor PS exec runner (#45334)
* win_exec: refactor PS exec runner

* more changes for PSCore compatibility

* made some changes based on the recent review

* split up module exec scripts for smaller payload

* removed C# module support to focus on just error msg improvement

* cleaned up c# test classifier code
2018-10-02 15:55:53 -07:00
Dag Wieers
aa2f3edb49 Docs: Clean up of 'blockinfile' module docs (#46331)
* Docs: Clean up of 'blockinfile' module docs

This is part of a series of module doc cleanups.

* A few more fixes after review
2018-10-02 18:22:30 -04:00
Eric L
446f83cdeb New option JUNIT_TASK_RELATIVE_PATH to output relative paths. (#37274)
* New option JUNIT_TASK_RELATIVE_PATH to output relative paths.

It makes the output in Jenkins much more readable as the absolute
path was taking the whole width of the screen, leaving no space for
the actual message.

A makedirs instead of mkdir slipped in as to make the creation of
the output directory recursive, hope this is OK.

* Add version_added field to doc set to 2.8
2018-10-02 12:25:29 -07:00
Sloane Hertel
27534e9b47 Move network utils that are used by AWS modules (#45579)
* Separate networking tools that may be used by modules outside of networking so changes to networking-only utilities don't trigger AWS integration tests

* Add unit tests for moved network utils

* Add comment to prevent imports from being mistakenly removed

* Move to_bits as well
2018-10-02 15:08:00 -04:00
Rohan Sadale
9874a49d1a Add examples for bind and unmount to mount module docs
PR #46375
2018-10-02 17:48:13 +02:00
Johannes Brunswicker
bacbd4e9fc Add ssl support to consul_kv lookup (#42456)
* implemented lookup_consul_kv
* added missing version_added for consul_url ini section
* added default value for ANSIBLE_CONSUL_CLIENT_CERT and added some more documentation
* removed trailing whitespaces
* fixed indention
* Fixes in Documentation
* removed trailing whitespace
* removed trailing whitespace
2018-10-02 11:01:03 -04:00
Peter Jenkins
0a55431d83 Correct invalid example in jenkins_script docs (#46193) 2018-10-02 08:04:28 -05:00
Erwan Quelin
87416a4b91 Fix typo in the author's github username.
Ansibot is looking at the author's github username to query reviews for
modules in the same namespace.
2018-10-02 13:57:27 +02:00
cadl42
a7221dd289 Ignore empty result of rabbitmqctl list_user_permissions (#35598)
Fix #34863
2018-10-02 15:08:50 +05:30
mrmagooey
b2dc7075df vcenter_folder - fix error events being generated, incorrect parent folders (#45951)
* fix error events being generated when vmware folders exist
* fix incorrect parent folders being identified (wrong type)
2018-10-02 14:47:35 +05:30
Egor Zaitsev
6df1f6b203 New module: routeros_facts – collect facts from RouterOS devices (#46114)
* feat(routeros): implement routeros_facts module

* fix(routeros): review by felixfontein

* fix(routeros): review by ganeshrn

* fix(routeros): review by felixfontein
2018-10-02 13:44:23 +05:30
Will Thames
411397a975 Use recursive_diff for kubernetes (#45645)
Move recursive_diff from cloudfront_distribution to
common.dict_transformations and reuse it in k8s modules
2018-10-02 03:24:52 -04:00
Zim Kalinowski
2a4bf670bb
clean up doc - removed required: false (#46357) 2018-10-01 15:39:40 -07:00
Juan Martinez
25a192034f Use specified loopvar in include_role example loop 2018-10-01 17:39:10 -04:00
Pilou
b76c4c840e WIP: Check that union Jinja filter can be chained (#46298)
* Check that union Jinja filter can be chained

* set filters: fix unexpected templating type error

this error occurs with Jinja 2.10 since 32ec69d827,
for example when union filters are chained:

$ ansible all -i localhost, -mdebug -a"msg={{ []|union([])|union([]) }}"
localhost | FAILED! => {
    "msg": "Unexpected templating type error occurred on ({{ []|union([])|union([]) }}):
            unsupported operand type(s) for +: 'set' and 'list'"
}
2018-10-01 16:30:24 -04:00
Nathaniel Case
cdaf5bd806
Add configuration to override location of ansible-connection (#46128)
* Add configuration to override location of ansible-connection

* Check var or argv[0] before $PATH
2018-10-01 14:29:59 -04:00