Matt Clay
5b5cba5e50
Update more code-smell tests. ( #36570 )
...
* Enhance use-compat-six code-smell test.
* Enhance use-argspec-type-path code-smell test.
* Enhance replace-urlopen code-smell test.
* Enhance boilerplate code-smell test.
* Enhance no-underscore-variable code-smell test.
2018-02-22 08:08:29 -08:00
Matt Clay
891f4f3b2d
Upgrade more code-smell tests. ( #36560 )
...
* Enhance no-dict-* code-smell tests.
* Enhance no-basestring code-smell test.
* Enhance no-get-exception code-smell test.
* Enhance empty-init code-smell test.
* Enhance required-and-default-attribute test.
* Remove unused code-smell test.
2018-02-21 20:09:13 -08:00
Jordan Borean
ef4f8851dc
win_feature: better error handling to make it easier to debug issues ( #36491 )
...
* win_feature: better error handling to make it easier to debug issues
* removed ignroed pslint rules that are no longer needed
2018-02-22 11:33:48 +10:00
Dag Wieers
430088c6f0
aci_interface_policy_leaf_policy_group: Fix test ( #36551 )
2018-02-21 23:48:10 +01:00
Sam Doran
723daf3e3a
Check for regexp match when using insertbefore or insertafter ( #36474 )
...
Add tests to cover this scenario
Fixes #36156
2018-02-21 17:03:38 -05:00
Bruno
afdd748f4c
changed cisco mail to normail hotmail ( #36546 )
2018-02-21 23:01:26 +01:00
Bruno
53125d37d1
add aci_static_binding_to_epg integration tests ( #36542 )
2018-02-21 21:45:38 +01:00
Dag Wieers
51ba115dea
aci_domain_to_encap_pool: Remove integration tests ( #36535 )
2018-02-21 20:33:23 +01:00
Toshio Kuratomi
03a6d72633
Revert "remove query/q ( #36315 )"
...
This reverts commit b47d2e07e1
.
query is a feature for 2.5. We're not reverting it now.
2018-02-21 10:37:51 -08:00
Dag Wieers
7435e115e0
ACI: Various changes to module documentation and guide ( #36516 )
...
* ACI: Various changes to module documentation and guide
This PR includes:
- We moved the object class information to the notes
- Add version information to guide chapters
- Add generic note to modules with reference to ACI guide
- Reference known issues in aci_rest documentation
- Remove module_utils function docs from modules
- Indicate which parameters are not required for querying all objects
- Added missing RETURN information
* Fix copyright strings
* Remove aci_domain_to_encap_pool.py for v2.5
* More updates
* PEP8 fix
* Improve listings of parameters/return values
2018-02-21 19:35:59 +01:00
Brian Coca
b47d2e07e1
remove query/q ( #36315 )
...
* remove query/q
remove and fixed tests for removed func
* paren fix
2018-02-21 10:42:54 -05:00
John R Barker
5d0ed38e3a
Fixup VMware module docs issues ( #36409 )
...
Fix various argspec vs documentation issue
2018-02-21 15:20:42 +00:00
Martin Krizek
9fced4f0a9
Add integration test for #36430 ( #36432 )
2018-02-21 16:16:02 +01:00
Sloane Hertel
f7d79d4789
[cloud] Retry WAF actions on WAFStaleDataException ( #36405 )
...
Add a util to run functions with AWSRetry to retry on WAFStaleDataExceptions and update ChangeToken for each attempt
2018-02-21 08:14:17 -05:00
mikedlr
52f2057472
aws ssm parameter lookup - change to return Nones for missing variables ( #36456 )
...
* aws ssm parameter lookup - change to return Nones for missing variables
* aws ssm parameter lookup - fix error case message to dump response
* aws ssm parameter lookup - fix integration test cases
2018-02-21 06:50:00 -05:00
Jordan Borean
df8a5d7a4f
fetch: set fail_on_missing: True as default as per docs ( #36469 )
...
* fetch: set fail_on_missing: True as default as per docs
* Updated docs for fetch to say behaviour was changed in 2.5 and updated tests
2018-02-21 18:10:23 +10:00
goshkis
abb956d9eb
vApp properties support ( #32579 )
...
* Adding support for vApp properties.
* vm specification updated only if changes have to be applied. I.e. subsequent updates with the same data will not trigger changed state
* Auxiliary variables renamed, hope this makes the code more readable
* Integration tests changed - re-adding the same properties test not implemented, but tested on real vCenter deployment
* fixing documentation "version_added" for the feature
* Addressing reviewers comments #2 :
* documentation updated with the only meaningful value for "option" attribute - "remove"
* Fixed improperly handled case when user requested "add" operation for existent property
* vApp configuration is updated only with properties that contains changes, not with all properties requested by user
2018-02-21 11:59:13 +05:30
saichint
47a92386c9
fix nxos_bgp_neighbor_af issues ( #36472 )
2018-02-21 10:20:24 +05:30
Dag Wieers
5635c50f9b
aci_iplpg: Various fixes to integration tests/module ( #36460 )
2018-02-21 00:20:38 +01:00
Dag Wieers
1720a210e9
aci_spvpg: Various fixes to integration tests/modules ( #36458 )
...
* aci_spvpg: Various fixes to integration tests/modules
This PR includes:
- A fix in module_utils aci.py
- Various fixes in integration tests
* Fix typo
2018-02-20 22:49:55 +01:00
Matt Clay
2b6ac4561b
Add support for enhanced code-smell tests. ( #36332 )
...
* Add support for enhanced code-smell tests:
- Path selection handled by ansible-test.
- Optional path filtering based on extension.
- Optional path filtering based on prefixes.
- Optional lint friendly output.
* Enhance no-assert code-smell test.
* Enhance no-tests-as-filters code-smell test.
2018-02-20 13:37:23 -08:00
Bruno
7143cf54bc
added aci_vpc_protection_group integration test ( #36448 )
...
added aci_switch_policy_vpc_protection_group integration test
2018-02-20 20:42:08 +01:00
Matt Clay
a9b58b84d8
Fix path handling in validate-modules sanity test.
2018-02-20 11:02:42 -08:00
Trishna Guha
3d06ce245a
fix vyos_l3_interface adding multiple addresses to interface ( #36377 )
...
* fix vyos_l3_interface adding multiple addresses to interface
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* add test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-20 20:54:27 +05:30
Bruno
4a6d837879
added aci_fabric_node integration test ( #36422 )
...
* added aci_fabric_node integration test
* Update main.yml
2018-02-20 15:06:41 +01:00
Brian Coca
a79378fccb
remove extra fields from debug output
...
fixes #35493
updated tests
2018-02-20 08:46:05 -05:00
Deepak Agrawal
0bbea9a579
vyos_config IndexError in sanitize_config ( #36375 )
...
* Bug in del(list) logic. Say you have a list of 4 elements a[0-3]
and you have to remove index 1 and 3, if you remove index 1 first
then list is cut short a[0-2] and does not have index 3
Fix: Remove indexes in reverse sorted order e.g. 3 and 1 in above
example so that order of indexes remain preserved even after deleting
fix is to remove indexes in reverse sorted order
* Add test cases for failed case
2018-02-20 18:29:34 +05:30
Jiri Tyr
000387ac23
Fix default value of gpgcheck in doc (PR #36267 )
2018-02-20 13:47:12 +01:00
Matt Clay
78e900cd7f
Fix ansible-test --redact option with delegation.
2018-02-19 21:58:02 -08:00
saichint
80d19e6af3
fix nxos_bgp_neighbor issues ( #36318 )
2018-02-20 10:08:17 +05:30
Dag Wieers
cac6c19a63
aci_encap_pool: Fix vxlan integration tests ( #36418 )
...
Missing cleanup would cause subsequent runs to fail when interrupted.
2018-02-20 04:45:09 +01:00
Dag Wieers
6534e6a450
ACI: Add missing examples to module docs ( #36417 )
...
This PR includes:
- A cleanup of documentation examples for ACI modules
- A small fix in aci_rest integration test
2018-02-20 03:27:17 +01:00
Dag Wieers
fb9af72b48
aci_aep: Add missing integration tests ( #36414 )
...
This PR includes:
- Add missing aci_aep integration tests
- Fix small aci_rest issue
2018-02-20 03:04:17 +01:00
Matt Clay
3a62eb5e03
Add option to hide sensitive ansible-test output.
...
This option is enabled automatically on Shippable.
2018-02-19 16:35:31 -08:00
Matt Clay
5bc9bb9fbb
Support ansible-test --truncate with delegation.
2018-02-19 11:07:43 -08:00
Dag Wieers
32dc936c20
aci_rest: Remove test data from validation test ( #36381 )
...
Oops
2018-02-19 13:27:42 +01:00
Dag Wieers
79d00adc52
aci_rest: Fix error handling and improve documentation ( #36295 )
...
This PR includes:
- A fix for a recently introduced issue wrt. error handling
- Added integration tests for provoked errors
- Influence standard return values using aci library for aci_rest
- Add proxy support documentation
- Documentation update related to #34175
2018-02-19 12:01:14 +01:00
Trishna Guha
eb7f4460c8
Set hostname to 'switch' on nxos_system ( #36373 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-19 10:57:16 +05:30
Trishna Guha
a5654bd63c
nxos_system test fix inventory_hostname_short ( #36359 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-02-18 10:32:44 +05:30
ABond
591695932e
Fix bug in DigitalOcean module_util ( #36352 )
2018-02-18 07:47:26 +05:30
Abhijeet Kasurde
5242914ae5
Fix digital ocean issues ( #36347 )
...
Remove module from ignore lists and some documentation fix in
digital_ocean_block_storage and digital_ocean module.
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-02-17 22:48:52 +05:30
rahushen
e24c547a3a
Fixes for the N3500 platform that uses the A8 image ( #36261 )
...
* fix nxos_l3_interface tests as n35 doesn't support ipv6
* add terminal dont-ask to nxos_feature and nxos_lldp
* put interfaces in L2 mode for N35
* fix nxos_feature unit-tests
2018-02-17 10:16:03 +05:30
Mike Wiebe
5b5d24631a
Fix nxos_system tests ( #36201 )
...
* Fix nxos_system tests
* Add debug connection plugin info
* Move sanity test under common
2018-02-17 10:14:50 +05:30
Matt Clay
ff922ac2ad
Import sanity test for main() in Ansible modules.
2018-02-16 11:17:36 -08:00
John R Barker
365630df65
Update ignore to deal with renamed files ( #36323 )
2018-02-16 19:07:36 +00:00
Martin Krizek
3a5263a92f
facts: fix device uuid's on el6 ( #36128 )
...
* facts: fix device uuid's on el6
Fixes #36077
2018-02-16 10:52:51 -05:00
David Newswanger
a7c2f6d092
re enabled tests that were fixed in ansible/ansible-modules-core#5008 ( #36257 )
2018-02-16 08:10:14 -05:00
Matt Clay
d2150795ba
Truncate some long messages sent to a TTY.
...
Can be overridden with the --truncate option.
2018-02-16 02:01:18 -08:00
Matt Clay
80b55e3742
Add missing validate-modules ignore entries.
2018-02-16 01:40:45 -08:00
Dag Wieers
d86c5aee3c
aci_domain_to_encap_pool: Add integration tests ( #36217 )
2018-02-15 23:47:39 -08:00