Commit graph

4469 commits

Author SHA1 Message Date
Matt Martz
b2d24aba61 Perform safe normalization of nics to use uuid 2014-06-13 12:17:42 -05:00
James Cammarata
1173a8d6af Catch error in azure related to a failed deployment when creating a vm 2014-06-12 10:25:31 -05:00
James Cammarata
0b8c8b0581 Merge branch 'devel' of https://github.com/matlockx/ansible into matlockx-devel 2014-06-12 09:32:03 -05:00
James Cammarata
d90f0bdfad Merge branch 'fix-lineinfile-eof-newline' of https://github.com/ahtik/ansible into ahtik-fix-lineinfile-eof-newline 2014-06-12 09:13:49 -05:00
James Cammarata
db4a5c6046 Merge pull request #7741 from mgcrea/devel
Add support for Linaro distribution in hostname module
2014-06-12 08:58:56 -05:00
James Cammarata
c548d0fb3b Merge pull request #7737 from toddmowen/zfs-fix-7696
zfs: fix incompatibility - share.nfs vs sharenfs (issue #7696)
2014-06-12 08:53:21 -05:00
James Cammarata
ccf47577c4 Merge branch 'sivel-rax-autoscale' into devel 2014-06-12 08:14:39 -05:00
Olivier Louvignes
8051e12490 Add support for Linaro distribution in hostname module 2014-06-12 12:06:59 +02:00
Todd Owen
4230a9a462 zfs: work around incompatibility by renaming share.nfs to sharenfs
Fixes #7696
2014-06-12 16:21:16 +08:00
rgbkrk
da107d3f0c Error checking and reporting on interface ufw rule 2014-06-11 11:10:38 -05:00
Aleksey Khudyakov
6865ffe93c Escape backslash in assemble module docs 2014-06-11 04:38:57 +11:00
James Cammarata
917ad8da72 Merge pull request #7687 from ryanpetrello/devel
Fix neutron floating IP allocation for networks w/ multiple subnets
2014-06-10 09:42:34 -05:00
James Cammarata
07e10fb9ff Merge branch 'rax-autoscale' of https://github.com/sivel/ansible into sivel-rax-autoscale 2014-06-10 09:16:02 -05:00
Paul Myjavec
074a6f3e3e Docker links and required alias
If no alias is passed one will now be created for you with the same name
as the target link container, as per the documentation
2014-06-10 22:53:55 +10:00
James Cammarata
8e3b512293 Merge pull request #7377 from mikhailguru/devel
Fixed handling of paths containing whitespaces in the synchronize module
2014-06-10 06:50:07 -05:00
James Cammarata
0073b34653 Merge pull request #7259 from darKoram/nova_keypair_check_keys
nova_keypair should fail if 'name' of key exists in keystore, but ssh hash value != public_key offered
2014-06-09 23:53:22 -05:00
James Cammarata
150a2346c1 Merge pull request #7238 from willthames/ec2_snapshot_argument_spec
Improve the ec2_snapshot argument spec and docs
2014-06-09 23:51:42 -05:00
Ron Gomes
bcf3e29e14 Fix incorrect argument ordering in error message, which provokes a
printf-related TypeError.
2014-06-09 15:03:51 -04:00
Matt Ferrante
3e875c7867 ec2_asg module enhancements
- Added a more verbose response
  - includes its settable attributes and a list of its instances.
  - allows setting of tags, changes upon which mark the task changed
  - allow getting of information from asg module, not just setting
  - doesn't mark changed if the parameter wasn't specified
  - Availability Zones are pulled from the region
2014-06-09 13:34:57 -04:00
Ahti Kitsik
1caf9be109 Bugfix to lineinfile to properly handle files with no newline at EOF when using insertafter=EOF.
Looks like #6881 is also affected by this bug.

Currently when using lineinfile insertafter=EOF for a file that has no newline then the added line is not prefixed with a newline.
As a concrete example, ubuntu distro default /etc/ssh/sshd_config has no newline so lineinfile module cannot be used to add a new line to the end of the file.
2014-06-09 19:58:45 +03:00
James Cammarata
61325f5817 Cleaning up svr4pkg commit fix for #7645 2014-06-09 10:48:06 -05:00
James Cammarata
19d6f4d177 Merge branch '7645' of https://github.com/kcghost/ansible into kcghost-7645 2014-06-09 10:45:29 -05:00
James Cammarata
989e4770d0 Merge pull request #7684 from JeanFred/patch-2
Fix documentation of deb option in apt module
2014-06-09 10:03:36 -05:00
James Cammarata
7ff3282e39 Merge pull request #7682 from sergevanginderachter/bigip_monitor_http_checkmode_fix
bigip_monitor bugfix for check mode
2014-06-09 09:39:33 -05:00
James Cammarata
4c30b3d68a Fixing mysql master replication boolean
Fixes #7528
2014-06-09 08:58:55 -05:00
Casey Fitzpatrick
fdbb77da51 fix for svr4pkg module failure reporting, issue #7645 2014-06-08 19:59:44 -04:00
Martin Joehren
98ff559fa0 azure - fixed missing return statement 2014-06-08 21:39:31 +02:00
Martin Joehren
188a13efc0 azure - fix for: temporary redirect, not deleted vhds, missing locations and role types, async api calls 2014-06-08 00:36:55 +02:00
James Cammarata
5637426f51 Merge branch 'devel' of https://github.com/ansible/ansible into devel 2014-06-06 21:56:32 -05:00
Ryan Petrello
bb0ca4c1aa Fix neutron floating IP allocation for networks with a v4 *and* v6 subnet.
For networks that have both a v4 and a v6 subnet, the floating IP plugin
currently has two problems:

* When determining the subnet for the provided `internal_network_name`, it
assumes that the first item in the list of subnets is the one you want.
Instead, it should pick the first v4 subnet.

* When multiple fixed IP's exist for a given port (as is the case in a network
a v4 and a v6 subnet), neutron needs a hint as to which fixed IP to associate
to the floating IP address (the v4 one).
2014-06-06 17:03:26 -04:00
James Cammarata
5bd8cd6e00 Cleaning up azure module
* Fixed error messages to be more descriptive
* Removed direct use of subprocess module and replaced it with calls
  to module.run_command
* Changed AZURE_MANAGEMENT_CERT_PATH to be just AZURE_CERT_PATH, which
  matches what is expected by the inventory script
2014-06-06 15:58:28 -05:00
Matt Martz
ad5cf5d55d Add Rackspace Autoscale modules
- rax_scaling_group
- rax_scaling_policy
2014-06-06 11:30:07 -05:00
James Cammarata
e083168773 Merge branch 'devel' of https://github.com/jwhitbeck/ansible into jwhitbeck-devel 2014-06-06 11:19:43 -05:00
Jean-Frédéric
c42f8907fd Fix documentation of deb option in apt module
The apt module may install a .deb package on the remote machine, not on the local.
Fix the misleading documentation.
2014-06-06 18:18:44 +02:00
James Cammarata
bd5cf57e76 Merge pull request #7653 from evanccopengeo/devel
ec2_group: Fix for 500 error when creating new security groups
2014-06-06 10:34:42 -05:00
Serge van Ginderachter
ceb1ba1687 bigip_monitor bugfix for check mode
Fixes case where properties are retrieved for a non existent monitor
which happens in check mode.
2014-06-06 16:48:36 +02:00
James Cammarata
9cb05a0845 Catch failed connection due to a bad region in ec2_scaling_policy
Fixes #7505
2014-06-05 19:40:21 -05:00
James Cammarata
a760299170 Catch failed connection due to a bad region in ec2_scaling_policy
Fixes #7506
2014-06-05 16:44:55 -05:00
Kevin Bell
e0a4c389f3 Fixed asg instance count polling 2014-06-05 16:18:31 -05:00
Kevin Bell
426a827b46 Fix default availability zone list 2014-06-05 16:18:31 -05:00
James Cammarata
26aaa7bcdd Fix typo in nova_keypair import of exceptions from novaclient
Fixes #7640
2014-06-05 15:42:38 -05:00
James Cammarata
43f96a636b Fix issue with symlink path detection
Fixes #7627
Fixes #7664
2014-06-04 23:31:59 -05:00
James Cammarata
7483acde5d Fix linking issue to directories in file module
The os.path.isdir() returns True for symlinks that point to directories,
so we also need to check to make sure it's not a symlink too.

Fixes #7657
2014-06-04 22:48:08 -05:00
James Cammarata
b3bbca03d5 Add additional params to get_target_from_rule method in ec2_group
Fixes #7592
2014-06-04 13:52:44 -05:00
James Cammarata
9f0d496d67 Fixing version_added strings for new features in ec2_elb_lb
Fixes #7631
2014-06-04 13:37:04 -05:00
James Cammarata
609fd2e993 Merge branch 'rax-meta' of https://github.com/sivel/ansible into sivel-rax-meta 2014-06-04 11:02:35 -05:00
evanccopengeo
fac9a64d23 fixing problem where ansible would error out because Amazon was saying the group didnt exist yet (needed to wait a few more seconds for amazon to propagate correctly) 2014-06-03 14:25:48 -04:00
James Cammarata
1b5f2d47bb Merge pull request #7638 from yanc0/primary_group_doc_user_example
Add primary group in the first user module doc example
2014-06-03 10:10:55 -05:00
James Cammarata
f1afc107b2 Merge pull request #7635 from josef-spak/mysql-replication-typo
Fix typo in CHANGE MASTER TO syntax
2014-06-03 10:10:04 -05:00
Yann Coleu
b5ea9e0655 Add primary group in the first user module doc example 2014-06-02 14:32:52 +02:00
Josef Špak
2d402ab5ca Fix typo in CHANGE MASTER TO syntax 2014-06-02 13:42:55 +02:00
Christoph Dwertmann
5cab159bda Don't use deprecated BaseException.message in keystone_user
fixes error "failed to parse: <attribute 'message' of 'exceptions.BaseException' objects>
TypeError: <attribute 'message' of 'exceptions.BaseException' objects> is not JSON serializable"
2014-06-02 15:11:53 +10:00
Matt Martz
84b1f21617 Add rax_meta module
Also update rax to mirror meta value normalization from rax_meta
2014-06-01 14:31:26 -05:00
Michael DeHaan
6bc056e012 Merge pull request #6863 from sivel/rax-untouched
rax module: Return untouhced servers with exact_count
2014-06-01 15:27:45 -04:00
CorbanR
42f54238e4 updating example, to be more consistent with parameter names 2014-05-30 15:57:55 -06:00
Brian Coca
fedc3a4f85 corrected doc example, non existing fact to the 2 it had 'merged' 2014-05-29 22:44:33 -04:00
Sean Whitbeck
796d8db860 Add azure VM provisioning/termination module 2014-05-29 17:29:09 -07:00
Brian Coca
202ac68995 Correctly examine path for relative links in file module
Fixes #7515
Fixes #7537
2014-05-28 11:47:44 -05:00
James Cammarata
ba641de69e Merge pull request #7536 from fly/linode-warn-ssl
warn if remote SSL cert is not checked in linode
2014-05-27 16:38:33 -05:00
James Cammarata
8e111fe82e Cleanup subversion module documentation in regards to export 2014-05-27 16:20:10 -05:00
James Cammarata
e8aebcb751 Merge pull request #7567 from kitwestneat/devel
Fixed documentation for etype parameter on acl module.
2014-05-27 16:13:00 -05:00
James Cammarata
e85c7f848f Make sure export param for subversion module is checked as a boolean
Fixes #7548
2014-05-27 14:09:50 -05:00
James Cammarata
b1d76b37db Merge pull request #7542 from sivel/rax-cdb-notfound
rax_cbs module: Don't fail when the volume is not found
2014-05-27 13:47:32 -05:00
Jon Chen
be7ff82e2d require pycurl for linode module 2014-05-27 14:37:44 -04:00
James Cammarata
3dc7df39fc Merge pull request #7532 from oasiswork/devel
open_iscsi module: support RC 21 when listing logged-in target
2014-05-27 13:13:48 -05:00
Kit Westneat
fabe8521cb Fixed documentation for etype parameter on acl module.
The etype parameter just had a copy of the default parameter documentation.
Changed it to reflect what it really is for.
2014-05-27 13:34:01 -04:00
Matt Martz
27ac5b1856 Don't fail in rax_cbs when the volume is not found 2014-05-25 19:39:43 -05:00
Nicolas Brisac
592a5b6fb1 open_iscsi module: support RC 21 when listing logged-in target 2014-05-24 18:14:28 +02:00
Brian Coca
c24956032d unified calls to fs function vs duplicate functions for file and
directory
2014-05-24 09:28:45 -04:00
Andrew Resch
3caea2e890 Fix typo in variable name 2014-05-24 09:26:44 -04:00
Andrew Resch
00389af1c2 Fix typo in variable name 2014-05-23 16:09:57 -07:00
Andrew Resch
fb1385bbd9 Replace CommandException with Exception 2014-05-23 12:44:01 -07:00
Evgenii Terechkov
7ad6f6e385 Relax suds module requirement 2014-05-23 10:40:10 -05:00
Daniel Jaouen
37fff3dc38 Add upgrade_all option to homebrew module. 2014-05-23 11:09:18 -04:00
Aleksey Khudyakov
a67c6f0663 Fix typo requird -> required 2014-05-24 00:10:46 +11:00
Michael DeHaan
ee82681d14 Merge pull request #7501 from sivel/rax-dns-serial-doc
Add notes to rax_dns and rax_dns_record to recommend using serial: 1
2014-05-22 14:10:43 -04:00
Matt Martz
413243186d Add notes to rax_dns and rax_dns_record to recommend using serial: 1 2014-05-22 11:58:28 -05:00
Michael Warkentin
c8eb47eefa Update command description
The docs were a little bit out of date with what commands are available to be run. They also didn't explain that you could pass custom commands - I almost went down the path of trying to run our custom management commands with the generic Ansible `command` module.
2014-05-21 14:00:12 -04:00
James Cammarata
062e82937f Fixing absolute path calculation for file module when linking
Fixes #7403
2014-05-21 12:49:42 -05:00
Atlas Health
26c2491583 Stopped instances can also be terminated 2014-05-21 07:18:30 -07:00
James Cammarata
7ef94428bf Merge branch 'elb-internal' of https://github.com/asnare/ansible into asnare-elb-internal 2014-05-21 08:34:21 -05:00
James Cammarata
4faff30ee0 Merge branch 'multi-word-mysql-grant-example' of https://github.com/webmat/ansible into webmat-multi-word-mysql-grant-example 2014-05-21 07:48:24 -05:00
Brian Coca
24f5030257 now module searches for update-alternatives vs hardcoding it 2014-05-20 22:51:27 -04:00
Andrew Snare
0cc6c479bc Support internal-only ELBs in EC2. 2014-05-20 22:21:14 +02:00
Mathieu Martin
a8969b5d3c Add example 'Specify grants composed of more than one word' to the mysql_user module. 2014-05-20 14:41:18 -04:00
James Cammarata
d44ed533b3 Default use_proxy to True for fetch_url()
Also added some error handling to the fetch_url() call in the
apt_repository module, so that failures to look up the PPA info
are properly handled.

Fixes #7322
2014-05-19 23:04:13 -05:00
Abhijit Menon-Sen
0dea177e77 Allow '-t ' to be passed to apt: upgrade 2014-05-17 23:02:20 +05:30
James Cammarata
cbea442ec2 Pull the link out of the alternatives output when not specified
Fixes #7414
2014-05-16 14:44:31 -05:00
James Cammarata
923baa6772 Merge branch 'yum_module_typos' of https://github.com/mpeters/ansible into mpeters-yum_module_typos 2014-05-16 09:24:47 -05:00
James Cammarata
e3ee7787ed Remove erroneous set of status_code causing a traceback in module uri
Fixes #7416
2014-05-16 08:49:08 -05:00
Michael Peters
15b3b42525 slight language change based on feedback from jimi-c 2014-05-16 09:44:32 -04:00
Michael Peters
69923cc413 fixing some typos in the docs of the yum module 2014-05-16 09:22:12 -04:00
Alan Pearce
670068aaad Update composer example
Remove unsupported 'install' argument
2014-05-16 14:06:55 +01:00
Michael DeHaan
b80b92e778 Stackdriver module was in the wrong category, so moving. 2014-05-16 08:30:38 -04:00
Matt Bray
8363ab5a6f docker: fix targetting images by name 2014-05-15 15:04:30 +01:00
James Cammarata
32ce085689 Merge branch 'patch-1' of https://github.com/telsacolton/ansible into telsacolton-patch-1 2014-05-14 21:48:31 -05:00
James Cammarata
df877f2e79 Check module_path permissions when creating ssh_wrapper for git
If the module directory is not writable/executable to the current user
(most likely because of a sudo to a non-root user), the ssh_wrapper
will be created in the default location for mkstemp() calls. To facilitate
the deletion of these new files, a new mechanism for cleaning up files
created by the module was also added.

Fixes #7375
2014-05-14 21:22:22 -05:00
telsacolton
06963c7826 Make file hardlink error message reasonble
When we hard-link a file, and the link path already exists, give the link path in the error message instead of the source
2014-05-14 16:54:26 -05:00
telsacolton
0d8104b8b7 Give reasonable error when symlink fails
When a symlink fails because the path already exists and force=no, we should output path in the error message instead of source.
2014-05-14 16:31:20 -05:00
James Cammarata
67d8df0e32 During vsphere config check attempt cast before marking values missing
Fixes #7385
2014-05-14 15:57:26 -05:00
James Cammarata
154ef942eb Merge pull request #7404 from jimi-c/issue_7363_docker_names
Make sure the docker data has a "Names" field before using it
2014-05-14 14:44:16 -05:00
James Cammarata
e623911df6 Merge branch 'bcoca-file_new_dirs_perms' into devel 2014-05-14 13:56:27 -05:00
James Cammarata
a9311a5dcb Merge branch 'file_new_dirs_perms' of https://github.com/bcoca/ansible into bcoca-file_new_dirs_perms 2014-05-14 13:53:08 -05:00
James Cammarata
bf405ef7a8 Merge pull request #7400 from etehtsea/patch-1
Fix env splitting in docker module
2014-05-14 11:00:32 -05:00
Konstantin Shabanov
ad9225895b Fix env splitting in docker module
ENV variable value could contain '=' (for example mysql://host/db?pool=10)
2014-05-14 18:11:43 +04:00
Scott Sturdivant
726dc1d2e8 Clarify that the encrypted param must also be set.
While the encrypted parameter's documentation clearly states that it needs to
be set, if you are focused on the password parameter's documentation, there's
nothing to draw your attention to the fact that encrypted may also need to be
set.
2014-05-14 07:49:11 -06:00
James Cammarata
19dbff916f Correctly cast the size_gb value for vpshere disks
Fixes #7385
2014-05-13 15:13:13 -05:00
Henry Finucane
6efc8008da Fail fast in the presence of permissions issues 2014-05-13 09:43:47 -07:00
Carson Gee
e6fbd2d8cb Fix missing variable initialization so an unspecified internal_network runs 2014-05-13 09:56:13 -04:00
Mikhail Emelchenkov
a2ca0441ae Fixed incorrect handling of paths contaiin whitespaces 2014-05-13 17:05:44 +04:00
Henry Finucane
278ecb9b55 Allow wait_for to wait on non-traditional files
Use os.path.exists to check for file existence, instead of "can we open
this file for reading".

Fixes #6710
2014-05-12 23:21:55 -07:00
Matt Martz
92b77048dc Handle ValueError during json.loads of json data from build 2014-05-12 14:16:07 -05:00
James Cammarata
bfc1201ecd Make sure the docker data has a "Names" field before using it
Fixes #7363
2014-05-12 12:27:07 -05:00
Yuichi TANIKAWA
2b644da4ca Add dots to valid path characters 2014-05-10 18:13:16 +09:00
James Cammarata
3bf890998b Merge pull request #7348 from adamchainz/patch-2
Fix grammar and value errors in cron documentation
2014-05-09 22:27:31 -05:00
James Cammarata
62c4a15c73 Merge pull request #7346 from tongpu/devel
Add documentation for required parameter name to quantum_subnet
2014-05-09 16:21:28 -05:00
Johannes 'fish' Ziemke
ea71c0c317 Fix: Remove check for Ghost state
This fixed the just committed change handling non existent Ghost state.
2014-05-09 20:13:25 +02:00
James Cammarata
c97dec9d75 Merge pull request #7338 from discordianfish/remove-ghost-state
Remove check for Ghost state
2014-05-09 13:06:16 -05:00
Johannes 'fish' Ziemke
b9d9ef511f Remove check for Ghost state
This doesn't exist anymore and causes ansible to throw a KeyError
2014-05-09 18:07:02 +02:00
Adam Chainz
3497582581 Fix grammar and value errors in cron documentation 2014-05-09 15:19:42 +01:00
James Cammarata
b78058022d Merge pull request #7342 from herbygillot/rds-params-fix
rds module: Fix undeclared reference to "params" when setting password in modify mode
2014-05-09 08:34:16 -05:00
Lukas Grossar
0aa4cb9a79 Add documentation for required parameter name to quantum_subnet 2014-05-09 15:17:04 +02:00
Michael DeHaan
54ac0fe92c Merge pull request #7343 from lberruti/alternatives_python5_2
Make alternatives module python 2.5 compatible
2014-05-09 09:08:34 -04:00
Herby Gillot
efbe4ca8d5 rds module: Fix undeclared reference to "params" when setting password in
modify mode.
2014-05-09 05:49:11 -04:00
James Cammarata
5c7109b8b9 Merge pull request #7110 from orgoj/docker-patch-version_comment
module docker - add docker version comment
2014-05-09 00:57:41 -05:00
James Cammarata
a18f4b6230 Merge branch 'devel' of https://github.com/jjshoe/ansible into jjshoe-devel 2014-05-09 00:31:39 -05:00
James Cammarata
0215134907 Fixing a doc mistake in the ec2 module from 4269bb6 2014-05-09 00:21:35 -05:00
James Cammarata
48e2a5e5a2 Merge branch 'ec2-start-stop' of https://github.com/sayap/ansible into sayap-ec2-start-stop 2014-05-09 00:04:34 -05:00
Yap Sok Ann
4269bb6a45 ec2: Fix bug with running/stopped state and wait=yes.
If `get_all_instances` returns multiple reservations, the old wait loop only
dealt with the first reservation. Thus, the wait loop may end before all
instances get to be running/stopped.

Also clean up the code a little.
2014-05-09 11:35:48 +08:00
James Cammarata
9d3583cab3 Merge pull request #7055 from bpennypacker/rds_modify
cloud/rds : renaming an rds instance always fails
2014-05-08 21:10:47 -05:00
James Cammarata
ebac5dfbce Updating docstring for docker_image based on new default for tag 2014-05-08 21:04:55 -05:00
James Cammarata
34e52c5884 Merge branch 'docker_image-patch-notag' of https://github.com/orgoj/ansible into orgoj-docker_image-patch-notag 2014-05-08 21:03:57 -05:00
James Cammarata
8dd91021f4 Merge branch 'git-submodule-when-recursive-true' of https://github.com/bibliotechy/ansible into bibliotechy-git-submodule-when-recursive-true 2014-05-08 20:47:10 -05:00
James Cammarata
39433949e0 Merge branch 'elb_subnets' of https://github.com/jimbydamonk/ansible into jimbydamonk-elb_subnets 2014-05-08 19:28:54 -05:00
James Cammarata
4358c846a0 Merge branch 'brian-brazil-devel' into devel 2014-05-08 16:47:21 -05:00
James Cammarata
b97f087f18 Fixing a typo in the monit module (status and not status()) 2014-05-08 16:46:32 -05:00
James Cammarata
a969941b85 Merge branch 'devel' of https://github.com/brian-brazil/ansible into brian-brazil-devel 2014-05-08 16:11:18 -05:00
James Cammarata
d9bb1a480a Merge pull request #7013 from orgoj/replace-patch-changed
module replace - report changed only if contents is changed
2014-05-08 15:14:19 -05:00
James Cammarata
3ac4943751 Some cleanup for the rds/vpc_security_groups fix 2014-05-08 15:08:43 -05:00
James Cammarata
768de238d4 Merge branch 'vpc_fix' of https://github.com/ebrevdo/ansible into ebrevdo-vpc_fix 2014-05-08 14:39:07 -05:00
James Cammarata
1a52fcce03 Merge pull request #7335 from napkindrawing/patch-1
Route53 module handling of domains with "*" is broken
2014-05-08 14:02:00 -05:00
napkindrawing
011ec5d9e6 Fix to unescape * was discarded by unescape of @
`decoded_name` was created twice, each from `rset.name`

So, the second call to `.replace(r'\100', '@')` overwrites decoded_name, discarding the result of the call to `.replace(r'\052', '*')`

I had a problem with wildcard domains that was fixed by this patch.
2014-05-08 14:20:32 -04:00
Chris Lamb
f510389298 Fail if monit reload failed; don't mask the error.
This is necessary for the scenario when you push a new, broken monit
config out, and then set a state=reloaded handler - the error was
previously swallowed so you could end up with successful play but missing
monitoring (!).

Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
2014-05-08 18:18:28 +01:00
Paul Armstrong
7d28f30bda Add proper state output to ec2_asg, ec2_metric_alarm, ec2_scaling_policy 2014-05-08 15:51:07 +00:00
Luca Berruti
a3d1f06cb2 Make alternatives module python 5 compatible 2014-05-08 14:46:49 +02:00
James Cammarata
713657d684 Make sure the default ec2_group egress rule is not removed
Upon a second run, the default egress rule will be removed when a
vpc is specified but no other egress rules were set. This patch
corrects that behavior by removing the default egress rule from the
list of unmatched outbound rules.

Fixes #7309
2014-05-07 20:52:03 -05:00
James Cammarata
bd56cfdf18 Merge pull request #7313 from mmoya/doc-fixes
Minor typo fix
2014-05-07 10:12:26 -05:00
Jean-Francois Chevrette
83d79f6257 this should return 0 to indicate a non-failure when check_mode is True 2014-05-07 10:20:51 -04:00
James Cammarata
b71a451ed0 Close fds when running commands from the accelerate daemon
Fixes #7307
2014-05-07 08:47:38 -05:00
Maykel Moya
1d3ce41e83 Fix typo 2014-05-07 10:35:16 +02:00
Christian Berendt
2c39eff60e [get_url] check against lowered stripped sha256sum
The content of the sha256sum attribute should be lowered before comparing it with the calculated sha256sum.

In the following example the used sha256sum uses ABC.. and not abc.. and the check failed. This should not happen.

```
TASK: [get_url url=http://ftp.fau.de/apache/hadoop/common/hadoop-2.4.0/hadoop-2.4.0.tar.gz dest=/home/vagrant/hadoop-2.4.0.tar.gz mode=0644 sha256sum=024326AC68A1A68B5566B10F95609EAAFD9F70CFEB37FCA0E97CBB1674E57C3A] ***
failed: [instance000] => {"failed": true}
msg: The SHA-256 checksum for /home/vagrant/hadoop-2.4.0.tar.gz did not match 024326AC68A1A68B5566B10F95609EAAFD9F70CFEB37FCA0E97CBB1674E57C3A; it was 024326ac68a1a68b5566b10f95609eaafd9f70cfeb37fca0e97cbb1674e57c3a.

FATAL: all hosts have already failed -- aborting
```
2014-05-06 18:27:43 +02:00
James Cammarata
537494c2d6 Make sure distro variable is set if python-apt is installed
Fixes #7295
2014-05-06 09:42:50 -05:00
James Cammarata
941af22d5d Merge pull request #7294 from adamchainz/patch-1
Fix sync_binlog name in mysql_variables example
2014-05-06 08:18:05 -05:00
James Cammarata
7bf86ec1c0 Merge branch 'fixing_apache2_module' of https://github.com/berendt/ansible into berendt-fixing_apache2_module 2014-05-06 08:02:21 -05:00
Adam Chainz
967de3cdf9 Fix sync_binlog name in mysql_variables example
The previous sync_binary_log is not a real MySQL variable.
2014-05-06 12:25:11 +01:00
James Cammarata
d6fc9f1dfc Fixing two bugs in the ec2_elb_lb module
* the current state of the ELB was not reflected properly when checking
  the status after a change was made.
* invalid zones caused a traceback when enabling/disabling zones
2014-05-05 12:48:45 -05:00
James Cammarata
faf733bc49 Removing zone choices that overly-limit available zones for gce
Fixes #7270
2014-05-05 11:58:39 -05:00
Antti Salminen
fa607f36b5 Switch to mapper device name if pvs returns the wrong one. 2014-05-03 10:36:22 +03:00
James Cammarata
b753625dbf Refuse to convert a non-empty directory into a link with the file module
Also adds an integration test for the above.

Fixes #7254
2014-05-02 14:46:38 -05:00
Kesten Broughton
aee1a97102 if key name already exists on tenant, check if public_key is offered that it matches the existing key 2014-05-02 11:09:54 -05:00
James Cammarata
ae7503d6fb Merge branch 'fix-copy-recursive-issue' of https://github.com/tksmd/ansible into tksmd-fix-copy-recursive-issue 2014-05-01 13:39:11 -05:00
James Cammarata
c0f92317ef Fixing a documentation error in the new stackdriver module 2014-05-01 11:44:31 -05:00
James Cammarata
2b898e7e8b Minor fix to imports in new stackdriver module 2014-05-01 11:39:46 -05:00
someda
50080b3774 fix #7244 recursive copy fails when setting directory attributes
- reverse the order of new_directory_list returned from split_pre_existing_dir in copy module
2014-05-02 01:38:16 +09:00
James Cammarata
6069d5d4cf Merge branch 'stackdriver' of https://github.com/bwhaley/ansible into bwhaley-stackdriver 2014-05-01 11:21:36 -05:00
willthames
44662a3d33 Improve the ec2_snapshot argument spec and docs
ec2_snapshot got missed when moving to a common argument spec.
It could already make use of the capabilities (as it uses
ec2_connect) and the documentation suggested it supported the
common argument spec (thanks to the documentation fragment work)
so it was just a matter of fixing the argument spec.

Removed unnecessary documentation for profile and security_token
that is covered by documentation fragment

Also removed spurious documentation flags (default: null, aliases: [])
which aren't needed.
2014-05-01 13:11:41 +10:00
James Cammarata
ce48e1f9ff Merge pull request #7230 from binarytemple/fix_for_issue_7228
fix issue #7228 ec2_vol crash
2014-04-30 08:30:27 -05:00
bryan hunt
88aaa70f0c fix issue #7228 ec2_vol crash 2014-04-30 10:43:05 +01:00
Atlas Health
49d0ad0644 added example 2014-04-29 17:13:25 -04:00
Atlas Health
4258eb6be7 updated docs to include snapshot_tags option
added version
2014-04-29 17:13:25 -04:00
James Cammarata
04793ff640 Merge branch 'patch-2' of https://github.com/budlight/ansible into budlight-patch-2 2014-04-29 15:58:05 -05:00
Michael DeHaan
6b26efdee0 Merge pull request #7119 from jjshoe/patch-4
Finish reverting a broken commit in #5679
2014-04-29 16:47:46 -04:00
James Cammarata
ac1948c04c Minor tweak to rsync_path construction in synchronize module
Fixes #7182
2014-04-29 15:47:16 -05:00
Michael DeHaan
d5e254d3c7 Merge pull request #6794 from follower/patch-4
Make `vpc_security_group` docs more accurate
2014-04-29 15:49:57 -04:00
Michael DeHaan
5c75ce1133 In apt module show 'name' vs pkg to standardize with the rest of the modules. 'pkg' is an alias for name. 2014-04-29 15:48:51 -04:00
James Cammarata
d2819e22e3 Merge pull request #7212 from jimi-c/issue_7027_ec2_group_egress_rules
Make sure a default allow out rule exists if no other egress rules do
2014-04-29 10:39:36 -05:00
James Cammarata
67092039d7 Merge pull request #7190 from jimi-c/issue_7180_vsphere_guest_hardware_variable_casts
Make sure values are integers for certain hardware items for vpshere_guest
2014-04-28 21:00:46 -05:00
James Cammarata
826198196b Merge branch 'elb' of https://github.com/bpennypacker/ansible into bpennypacker-elb 2014-04-28 20:39:10 -05:00
Christian Berendt
67a8ee24e1 made enabled/disabled checks of apache2_module workable 2014-04-28 19:46:34 +02:00
James Cammarata
50cd3a4a8f Make sure values are integers for certain hardware items for vpshere_guest
Fixes #7180
2014-04-28 11:40:00 -05:00
James Cammarata
a482e1583d Merge branch 'fix_user_non_root_on_rhel' of https://github.com/mscherer/ansible into mscherer-fix_user_non_root_on_rhel 2014-04-28 10:47:36 -05:00
Michael Scherer
28c373da0c Do not fail if we try to generate a ssh key for a user without being root
If we try to use the user module without being root, it fail on RHEL/Fedora
because usermod --help cannot be run. The root cause is lack of permission
due to EAL4+ certification, as seen in shadow-utils changelo.

So if we cannot run it, assume there is no append. It doesn't matter
much since we will not be able to run usermod at all with or without the
option.
2014-04-28 12:29:57 +02:00
Skyler Leigh Amador
a8d9470938 Remove --timeout option to rsync from synchronize defaults
The current 10-second default timeout for rsync seems to be behind issue #6809.

As a workaround for the underlying issue in rsync when different versions are
used on the source and destination sides, don't include the timeout option
unless the user specifies a timeout > 0.
2014-04-27 20:21:54 -07:00
Michael DeHaan
2ea386fe04 Merge pull request #7168 from jjshoe/fix_apache2_module_docs
Fix example
2014-04-27 16:28:31 -04:00
Joel Schuweiler
7916545979 Fix example 2014-04-27 12:16:51 -05:00
Joel Schuweiler
5bad971873 Finish reverting #b73cddc 2014-04-27 09:36:13 -05:00
jjshoe
a34478d6f3 Ensure the validation string has %s in it 2014-04-27 09:30:36 -05:00
Brian Brazil
d25f1dc2d0 Use empty string rather than None to avoid TypeError
Improve error messages.
2014-04-25 13:30:19 +01:00
mkosmach
fbf3b78ace add simplejson as alternative to json 2014-04-25 02:44:51 -07:00
Ben Holloway
e45d33954b documentation fix 2014-04-24 17:58:39 -06:00
Ben Holloway
4596521147 attempt to set availability_zones to all if neither availability_zones or vpc_identifier are set 2014-04-24 17:56:26 -06:00
Bruce Pennypacker
dc912ca201 removed unwanted 'if wait else None' 2014-04-24 20:41:51 +00:00
Ben
5a39672efa documentation fix availability_zones should be required for ec2_asg 2014-04-24 11:56:25 -06:00
Ben
30b634eae9 updated example to include instance_type 2014-04-24 11:50:49 -06:00
Ben
9770c7f47d Added instance_type to ec2_lc variable list 2014-04-24 11:47:41 -06:00
Michael DeHaan
31f7a0693e Add missing license headers to two modules and standardize formatting of another. 2014-04-24 10:32:54 -04:00
James Cammarata
89fa9b7305 Add parameters to get_url for the url username/password
Fixes #6928
2014-04-24 00:26:50 -05:00
James Cammarata
83f300ddd6 Merge branch 'apt_key_format' of https://github.com/andreasf/ansible into andreasf-apt_key_format 2014-04-24 00:02:10 -05:00
James Cammarata
3f1545f9db Fixing the version_added string in the vsphere_guest module 2014-04-23 22:46:14 -05:00
James Cammarata
833ceeca24 Merge branch 'vmware_core' of https://github.com/rhoop/ansible into rhoop-vmware_core 2014-04-23 21:12:40 -05:00