Brendan Almonte
8d8cfb5fcd
Read directory_mode as 'raw' type
...
Reads the directory_mode param as 'raw' type to mirror the same behavior as mode.
This'll cause non-quoted values to be represented as an int, rather than a str.
Covered by 'assert recursive copied directories mode' test.
Fixes #24202
2017-05-23 11:33:19 -07:00
cheko
0dc5e8bf71
Bugfix: Directories in /etc/skel will get users ownership when home dir is created ( #24943 )
...
* Bugfix: Directories in /etc/skel will get users ownership when home dir is created
* Bugfix: Chmod works now recursive for the home dir
2017-05-23 11:31:28 -07:00
kgottholm
5240e5a230
Vertica schema fix ( #24915 )
...
* replace deprecated cmp() with custom conditional
cmp is not present in Python3 but several modules use it
Reference 24756
2017-05-23 10:49:54 -07:00
Dag Wieers
9cd6f1bf91
win_copy: Fix recursive copy ( #23581 )
...
This fixes #23559 .
This should be backported to v2.3 branch too.
2017-05-23 10:46:13 -07:00
Nathaniel Case
dd4a79d7d3
Clean up nxos_bgp_neighbor_af ( #24890 )
...
* Fix pep8 in bgp_neighbor_af
* Remove WARNINGS
* Rewrite command detection
* Add bgp_neighbor_af test
* Finally kill invoke
2017-05-23 12:43:55 -04:00
kgottholm
1e4b227e6f
Os port fix ( #24913 )
...
* replace deprecated cmp() with custom conditional
cmp is not present in Python3 but several modules use it
Reference 24756
2017-05-23 09:40:56 -07:00
Brian Coca
e0e94a4d02
reinstated to legacy
...
(cherry picked from commit a6484da0f11d03056b446526ef1cf78f968ae3ee)
(cherry picked from commit f23e766efa859b25557537d5098de557e85120cf)
2017-05-23 10:40:44 -04:00
Kevin Clark
04073dfa9b
adds privilege escalation method for pmrun(Unix Privilege Manager 6.0)
2017-05-23 10:39:48 -04:00
Abhijeet Kasurde
f9b836a901
Include error exception in AnsibleError
...
- Use to_native instead of str
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-05-23 10:19:14 -04:00
Trishna Guha
4066b03a4c
nxos_evpn_global refactor ( #24919 )
...
* nxos_evpn_global refactor
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* ansibot told me to do this
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-05-23 14:54:54 +05:30
Matt Martz
4ac135c1b5
Fix logic surrounding copy and remote_src, remote_src is preferred, make copy action plugin only. Fixes #23591 ( #24732 )
2017-05-22 17:19:56 -07:00
Andrew Shewmaker
f5fd32eae6
docker_container: do not split command on commas ( #24900 )
...
* docker_container: do not split command on commas
Fix issue #24430
* docker_container: document command parameter
Prior behavior was strange, splitting strings on commas
only to join them again ... replacing commas with spaces.
FYI, docker-py accepts strings or lists, using shlex.split
on strings ... splitting on spaces while respecting things
like quotes.
https://github.com/docker/docker-py/blob/master/docker/api/container.py
https://github.com/docker/docker-py/blob/master/docker/types/containers.py
https://github.com/docker/docker-py/blob/master/docker/utils/utils.py
More info regarding Dockerfile syntax for CMD strings and lists
can be found at https://docs.docker.com/engine/reference/builder/#cmd
2017-05-22 15:39:57 -07:00
pdasilva
f8e47e2204
Changed assemble_from_fragments to use os.path.join ( #24909 )
...
Fixes #19437
2017-05-22 15:38:11 -07:00
Anton Kasimov
2e392f47c8
Bugfix for setting user groups on OpenBSD
2017-05-22 18:16:28 -04:00
Brian Coca
e506b5da14
only set executable from shell if not set already
2017-05-22 18:06:55 -04:00
Brian Coca
55135c0825
enable run_command to use non /bin/sh shells
...
fixes #24169
2017-05-22 18:06:55 -04:00
kgottholm
16d522cf2c
Letsencrypt fix ( #24906 )
...
* Replaced deprecated cmp with custom condition
References #24756
* Fix PEP 08 indention
2017-05-22 14:41:47 -07:00
Rob
43fc97cad3
[cloud] Fix iam_role to compare trust policies accurately ( #22936 )
...
* Fix iam_role to compare trust policies accurately
* Better exception handling and better handling of detaching all managed policies
2017-05-22 15:13:35 -04:00
Tim Rupp
4fc40304d5
Adds the bigip_command module to Ansible ( #24850 )
...
This patch adds the bigip_command module to Ansible to support arbitrary
tmsh command to a F5 BIG-IP.
2017-05-22 20:11:34 +01:00
pdasilva
45e4b8f97a
Converted the response from _get_url_data using to_native ( #24901 )
...
Updated the exception message to no longer use e.message.
Fixes #24526
2017-05-22 12:09:51 -07:00
Ricardo Carrillo Cruz
b12beca3ed
Refactos nxos_ip_interface module ( #24885 )
2017-05-22 19:48:59 +02:00
Abhijeet Kasurde
7fba31677e
Remove redeclared module variable
...
Fix removes redeclared module variable defined
previously without any usage.
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-05-22 12:22:54 -04:00
Trishna Guha
9fb9c00092
Remove deprecation for username/password eos_user, nxos_user and Doc update ( #24880 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-05-22 20:02:36 +05:30
glassresistor
4a718645e8
fixed minor py3 compliance issue in ec2_vpn_nacl ( #24758 )
...
wrapped a dict.items() with list
2017-05-19 13:58:48 -07:00
Ganesh Nalawade
7563d93901
Add nxos changes for Python3 ( #24602 )
...
* Add nxos changes for Python3
Make `execute_command` arguments and its
return value complaint to PY3 changes
made in PR #24431
* Fix CI issues
* Fix review comment
Replace surrogate_or_strict with
surrogate_then_replace as per review
comment os PR #24601
2017-05-20 01:45:53 +05:30
Michael
b65ebf3519
Fixed import of urlencode and pathname2url from urllib for python3 ( #24424 )
2017-05-19 12:22:16 -05:00
Phil Huang
98a8b967d2
Fixed wrong variable in cumulus network module ( #23950 )
...
Signed-off-by: Phil Huang <phil_huang@edge-core.com>
2017-05-19 12:49:07 -04:00
Trishna Guha
1e5a0982b9
Fix nxos_hsrp and add unit test ( #24770 )
...
* nxos_hsrp fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* unit test nxos_hsrp
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* ansibot told me to do this
* revert apply_key_map and simplify method
2017-05-19 10:40:42 -06:00
Trishna Guha
4782a4e62f
Make host required field and minor refactor ( #24534 )
...
* Make host required field and minor refactor
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* ansibot pep8 legacy file
* example doc update
2017-05-19 10:37:01 -06:00
QijunPan
68f38c5e9d
Contributing lib/ansible/modules/network/cloudengine/ce_info_center_trap.py module to manage HUAWEI data center CloudEngine ( #22049 )
...
* add ce_info_center_trap
add ce_info_center_trap
* upgrade Info Center Trap
* fix CI issues
2017-05-19 17:01:52 +01:00
QijunPan
8086f12ddb
Contributing lib/ansible/modules/network/cloudengine/ce_facts.py module to manage HUAWEI data center CloudEngine ( #22044 )
...
* add ce_facts
add ce_facts
* fix CI issues
2017-05-19 16:59:36 +01:00
QijunPan
35bc99156a
Contributing lib/ansible/modules/network/cloudengine/ce_evpn_bgp_rr.py module to manage HUAWEI data center CloudEngine ( #22043 )
...
* add ce_evpn_bgp_rr
add ce_evpn_bgp_rr
* fix CI issues
2017-05-19 16:58:55 +01:00
QijunPan
4961778732
Contributing lib/ansible/modules/network/cloudengine/ce_eth_trunk.py module to manage HUAWEI data center CloudEngine ( #22037 )
...
* add ce_eth_trunk
add ce_eth_trunk
* fix CI issues
2017-05-19 16:58:21 +01:00
QijunPan
a54c3398e1
Contributing lib/ansible/modules/network/cloudengine/ce_dldp.py module to manage HUAWEI data center CloudEngine ( #22035 )
...
* add ce_dldp module
add ce_dldp module
* fix CI issues
2017-05-19 16:57:25 +01:00
QijunPan
9f297ff0c6
Contributing lib/ansible/modules/network/cloudengine/ce_acl_interface.py module to manage HUAWEI data center CloudEngine ( #21878 )
...
* add ce_acl_interface module
add ce_acl_interface module
* update ce_acl_interface.py
* fix CI issues
2017-05-19 16:55:41 +01:00
QijunPan
b5805d5aa3
Contributing lib/ansible/modules/network/cloudengine/ce_aaa_server.py module to manage HUAWEI data center CloudEngine ( #21757 )
...
* commit ce_aaa_server module
commit ce_aaa_server module
* update ce_aaa_server.py
update ce_aaa_server.py
* update ce_aaa_server module
* upgrade ce aaa server
upgrade ce aaa server
* fix CI issues
2017-05-19 16:53:59 +01:00
QijunPan
365f816e46
Contributing lib/ansible/modules/network/cloudengine/ce_evpn_bgp.py module to manage HUAWEI data center CloudEngine ( #21759 )
...
* commit ce_evpn_bgp.py
commit ce_evpn_bgp.py
* update ce_evpn_bgp
update ce_evpn_bgp
* fix CI issues
2017-05-19 16:51:51 +01:00
QijunPan
ea0060ba64
Contributing lib/ansible/modules/network/cloudengine/ce_netstream_global.py module to manage HUAWEI data center CloudEngine ( #21817 )
...
* add ce_netstream_global module
add ce_netstream_global module
* update ce_netstream_global
update ce_netstream_global
* fix CI issues
* fix pep8 error
2017-05-19 16:50:53 +01:00
QijunPan
4ef5177e62
Contributing lib/ansible/modules/network/cloudengine/ce_netstream_export.py module to manage HUAWEI data center CloudEngine ( #21816 )
...
* add ce_netstrem_export module
add ce_netstrem_export module
* update ce_netstream_export
update ce_netstream_export
* fix CI issues
2017-05-19 16:50:01 +01:00
QijunPan
c291e5d895
Contributing lib/ansible/modules/network/cloudengine/ce_acl.py module to manage HUAWEI data center CloudEngine ( #21815 )
...
* add ce_acl module
add ce_acl module
* update ce_acl.py
update ce_acl.py
* fix CI issues
2017-05-19 16:49:31 +01:00
QijunPan
e2cd0ee18b
Contributing lib/ansible/modules/network/cloudengine/ce_netstream_aging.py module to manage HUAWEI data center CloudEngine ( #21761 )
...
* commit ce_netstream_aging
commit ce_netstream_aging
* update ce_netstream_aging
update ce_netstream_aging
* update ce_netstream_aging
update ce_netstream_aging
* fix CI issues
2017-05-19 16:48:43 +01:00
QijunPan
594dcbcaa2
Contributing lib/ansible/modules/network/cloudengine/ce_evpn_global.py module to manage HUAWEI data center CloudEngine ( #21760 )
...
* commit ce_evpn_global
commit ce_evpn_global
* update ce_evpn_global
update ce_evpn_global
* fix CI issues
2017-05-19 16:47:36 +01:00
QijunPan
04d5a80f96
Contributing lib/ansible/modules/network/cloudengine/ce_aaa_server_host.py module to manage HUAWEI data center CloudEngine ( #21758 )
...
* commit ce_aaa_server_host.py
commit ce_aaa_server_host.py
* update ce_aaa_server_host.py
* fix CI issues
2017-05-19 16:27:47 +01:00
QijunPan
0fe0538a43
Contributing lib/ansible/modules/network/cloudengine/ce_command.py module to manage HUAWEI data center CloudEngine ( #21669 )
...
* update ce_command.py
update ce_command.py
* update ce_command
update ce_command
* update ce_command.py
update ce_command.py
* update ce_command module
update ce_command module
* update ce_command module
update ce_command module
2017-05-19 16:22:20 +01:00
Sergey Bondarev
f39fa7fd22
fix from https://github.com/ansible/ansible/pull/23001
2017-05-19 09:41:09 -04:00
Sergey Bondarev
72fc9f5cbe
fix deprecation import ansible.vars.unsafe_proxy to ansible.utils.unsafe_proxy
2017-05-19 09:41:09 -04:00
Niall Donegan
29fb573fd6
Tiny Typo Fix ( #24828 )
2017-05-19 14:31:02 +01:00
Abhijeet Kasurde
d4857ed6c4
Add Password for login method in github_release ( #23661 )
...
Fix allows user to specify username and password for
using github_release to perform various operations
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-05-19 08:49:05 +01:00
QijunPan
6352a54f19
Contributing new lib/ansible/plugins/terminal/ce.py module to manage HUAWEI data center CloudEngine switch ( #21653 )
...
* commit plugins terminal ce.py module
commit plugins terminal ce.py module
* update plugins/terminal/ce.py
update plugins/terminal/ce.py
* deal with pep8 error
2017-05-19 08:43:37 +01:00
QijunPan
ad85f2b483
Contributing new /lib/ansible/plugins/action/ce_template.py module to manage HUAWEI data center CloudEngine switch ( #21649 )
...
* commit plugins action ce_template.py
commit plugins action ce_template.py
* deal with pep8 error
2017-05-19 08:42:55 +01:00
QijunPan
627ac2493d
commit plugins action ce_config module. ( #21648 )
...
commit plugins action ce_config module.
2017-05-19 08:42:36 +01:00
Gaurav Rastogi
32b4eab3dc
Avi module to setup GSLB Geo DB profile. ( #24812 )
2017-05-19 08:34:12 +01:00
Gaurav Rastogi
ea6955109b
New module to setup HTTP Policy set objects ( #24813 )
2017-05-19 08:33:37 +01:00
Gaurav Rastogi
1960aa8d96
New module to setup GSLB Application persistence profile ( #24814 )
2017-05-19 08:31:49 +01:00
Gaurav Rastogi
e90d63edd1
New Avi Module for setup of network security policy ( #24815 )
2017-05-19 08:31:00 +01:00
Gaurav Rastogi
d6e2943c97
New Avi Module to setup virtualservice datascripts ( #24818 )
2017-05-19 08:30:19 +01:00
Gaurav Rastogi
b26bc5be88
New Avi Module to setup DNS policies. ( #24819 )
2017-05-19 08:29:34 +01:00
Gaurav Rastogi
788e2efe2a
New Avi Module to setup various controller properties. ( #24811 )
2017-05-19 08:29:00 +01:00
Gaurav Rastogi
fd94b5b20d
New Avi Module to setup SE properties. ( #24816 )
2017-05-19 08:28:26 +01:00
Gaurav Rastogi
b44f3cbcf6
New Avi Module to setup user account profile settings. ( #24817 )
...
* New Avi Module to setup user account profile settings.
* removed blank line failing pep8
2017-05-19 08:27:48 +01:00
Gaurav Rastogi
61882cfdfa
New Avi Module to create VIP objects that can be used in shared VIP and multiple VIP use cases for application deployment. ( #24809 )
2017-05-19 08:26:22 +01:00
QijunPan
d53136cf1b
Contributing lib/ansible/modules/network/cloudengine/ce_ntp_auth.py module to manage HUAWEI data center CloudEngine ( #22058 )
...
* add ce_ntp_auth
add ce_ntp_auth
* fix review issues
2017-05-19 08:24:40 +01:00
QijunPan
21b778ddb0
Contributing lib/ansible/modules/network/cloudengine/ce_ospf.py module to manage HUAWEI data center CloudEngine ( #22059 )
...
* add ce_ospf
add ce_ospf
* upgrade OSPF
* fix review issues.
2017-05-19 08:24:22 +01:00
QijunPan
f8193622d6
Contributing lib/ansible/modules/network/cloudengine/ce_reboot.py module to manage HUAWEI data center CloudEngine ( #22060 )
...
* add ce_reboot
add ce_reboot
* fix review issues.
* update requirements.
2017-05-19 08:23:48 +01:00
QijunPan
7353b357e9
Contributing lib/ansible/modules/network/cloudengine/ce_rollback.py module to manage HUAWEI data center CloudEngine ( #22061 )
...
* add ce_rollback
add ce_rollback
* fix review issues
2017-05-19 08:23:30 +01:00
QijunPan
954906c143
Contributing lib/ansible/modules/network/cloudengine/ce_snmp_location.py module to manage HUAWEI data center CloudEngine ( #22065 )
...
* add ce_snmp_location.py
* fix review issues
2017-05-19 08:23:13 +01:00
QijunPan
9b20d6ac34
Contributing lib/ansible/modules/network/cloudengine/ce_sflow.py module to manage HUAWEI data center CloudEngine ( #22062 )
...
* add ce_sflow
add ce_sflow
* fix review issue
2017-05-19 08:22:51 +01:00
QijunPan
3927341872
Contributing lib/ansible/modules/network/cloudengine/ce_snmp_target_host.py module to manage HUAWEI data center CloudEngine ( #22066 )
...
* add ce_snmp_target_host
* fix review issues.
2017-05-19 08:22:34 +01:00
QijunPan
dda49ca7c9
Contributing lib/ansible/modules/network/cloudengine/ce_snmp_traps.py module to manage HUAWEI data center CloudEngine ( #22067 )
...
* add ce-snmp_traps
* fix review issues
* fix pep8 error
2017-05-19 08:22:19 +01:00
QijunPan
0172522406
Contributing lib/ansible/modules/network/cloudengine/ce_snmp_user.py module to manage HUAWEI data center CloudEngine ( #22069 )
...
* add ce_snmp_user.py
* upgrade snmp user
* fix review issues
* fix review issue
* fix CI issue
* fix CI issue
2017-05-19 08:21:55 +01:00
QijunPan
45fda73653
Contributing lib/ansible/modules/network/cloudengine/ce_vxlan_global.py module to manage HUAWEI data center CloudEngine ( #22082 )
...
* add ce_vxlan_global.py
* upgrade Vxlan Global
* metadata_version update
2017-05-19 08:21:42 +01:00
QijunPan
1c0d74339a
Contributing lib/ansible/modules/network/cloudengine/ce_vxlan_tunnel.py module to manage HUAWEI data center CloudEngine ( #22083 )
...
* add ce_vxlan_tunnel.py
* update
* upgrade Vxlan Tunnel
* metadata_version update
* deal with review issue.
* deal with review issue
2017-05-19 08:21:27 +01:00
Michael Scherer
f88c2b8ac5
Fix wrongly named variable, introduced by error on ac1017b7ad
( #24795 )
...
This broke ansible-playbook -D for template module
2017-05-18 22:29:05 -07:00
Trishna Guha
21e28a431b
Remove unused method from nxos_ospf ( #24820 )
2017-05-19 10:57:16 +05:30
Trishna Guha
998305a493
nxos_ospf_vrf fix and unittest ( #24495 )
2017-05-19 10:09:46 +05:30
Matt Martz
1eed6c5b3d
Convert some more base64 strings to text for winrm, to support async and become ( #24796 )
2017-05-18 16:06:51 -07:00
Lee Shakespeare
def76a3c3b
Lookup credential id and pass in credential rather than scm_credential ( #24624 )
...
* Lookup credential id and pass in credential rather than scm_credential
* Change the excepting handling to catch missing credentials
* Make error messages for not found lookups more useful
2017-05-18 15:44:33 -07:00
QijunPan
1487ec0ea2
Contributing lib/ansible/modules/network/cloudengine/ce_vxlan_gateway.py module to manage HUAWEI data center CloudEngine ( #22081 )
...
* add ce_vxlan_gateway.py
* metadata_version update
* deal review issues
2017-05-18 23:12:04 +01:00
QijunPan
b20c550426
Contributing lib/ansible/modules/network/cloudengine/ce_vxlan_arp.py module to manage HUAWEI data center CloudEngine ( #22080 )
...
* add ce_vxlan_arp.py
* metadata_version update
* deal review issues
2017-05-18 23:11:42 +01:00
QijunPan
a8475f6ef5
Contributing lib/ansible/modules/network/cloudengine/ce_vrf_interface.py module to manage HUAWEI data center CloudEngine ( #22079 )
...
* add ce_vrf_interface.py
* metadata_version update
* fix code review issues
* fix ci_verified
* tab to space
2017-05-18 23:11:09 +01:00
QijunPan
cb75f2a43d
Contributing lib/ansible/modules/network/cloudengine/ce_vlan.py module to manage HUAWEI data center CloudEngine ( #22076 )
...
* add ce_vlan.py
* metadata_version update
* fix review issues
* Update ce_vlan.py
* fix check issue
required_if not work well when the option value is "not None"
2017-05-18 23:10:11 +01:00
QijunPan
fb54e47491
Contributing lib/ansible/modules/network/cloudengine/ce_switchport.py module to manage HUAWEI data center CloudEngine ( #22075 )
...
* add ce_switchport.py
* metadata_version update
* fix review issues
* fix review issue
* fix CI issue
2017-05-18 23:09:49 +01:00
QijunPan
a1cbecd23c
Contributing lib/ansible/modules/network/cloudengine/ce_stp.py module to manage HUAWEI data center CloudEngine ( #22073 )
...
* add ce-stp
* fix review issues
* fix CI issues
2017-05-18 23:09:26 +01:00
QijunPan
55d0f97ace
Contributing lib/ansible/modules/network/cloudengine/ce_snmp_contact.py module to manage HUAWEI data center CloudEngine ( #22064 )
...
* add ce_snmp_connect
add ce_snmp_connect
* fix review issues
2017-05-18 23:08:05 +01:00
QijunPan
f5fc565721
Contributing lib/ansible/modules/network/cloudengine/ce_startup.py module to manage HUAWEI data center CloudEngine ( #22070 )
...
* add ce_startup
add ce_startup
* fix review issues
2017-05-18 23:07:16 +01:00
Lars Larsson
53baa36a8b
[cloud][GCE] fix bug in persistent disk snapshot naming ( #23218 )
...
snapshot_name keeps on prepending the device_name to the same string if more than one device.
result is: disk3-disk2-disk1-MySnapshot
2017-05-18 16:08:14 -04:00
Tim Rupp
c1397626fc
Adds the bigip_user module to Ansible ( #24753 )
...
The patch adds the bigip_user module to Ansible to support managing
users on an F5 BIG-IP.
Unit tests are provided. Integration tests can be found here
* https://github.com/F5Networks/f5-ansible/blob/devel/test/integration/bigip_user.yaml
* https://github.com/F5Networks/f5-ansible/tree/devel/test/integration/targets/bigip_user/tasks
2017-05-18 20:21:18 +01:00
Matt Davis
569377e951
add segfault detection to TQM
...
* prevents indefinite hangs when a worker segfaults
2017-05-18 14:59:07 -04:00
QijunPan
ba3a0e8e34
Contributing lib/ansible/modules/network/cloudengine/ce_snmp_community.py module to manage HUAWEI data center CloudEngine ( #22063 )
...
* add ce_snmp_community
add ce_snmp_community
* upgrade snmp community
* fix review issues
2017-05-18 19:46:45 +01:00
Tom Melendez
13f2d9222f
[GCP] Global Load Balancer Integration Test ( #24704 )
...
* Revert to using url_map internal to the module to allow parameter generation to work. module parameter is still url_map_name.
* [GCP] Cross Region Load Balancer Integration Test
2017-05-18 14:00:51 -04:00
Dag Wieers
c4a7f64c02
ansible/galaxy: PEP8 compliancy ( #24696 )
...
- Make PEP8 compliant
2017-05-18 18:43:35 +01:00
Dag Wieers
6f6bdf7914
ansible/parsing: PEP8 compliancy ( #24701 )
...
- Make PEP8 compliant
2017-05-18 18:41:00 +01:00
Tom Melendez
c99c3b2b5d
[GCP] Healthcheck module ( #24564 )
...
* [GCP] Healthcheck module
* fix return YAML block
* removed update_ return value; removed python26 check; typos and docs updates
* doc fix
* Updated int test for no-update conditions
* added filter_gcp_fields test
* fixed bug in update where dictionary wasn't built correctly and port was not being set.
* added default values to documentation block
2017-05-18 12:49:50 -04:00
John R Barker
ed2f13b3db
Fix more module returns ( #24782 )
...
* Correct return structure
* typo
2017-05-18 17:38:10 +01:00
Tom Melendez
3fbf3b51ff
[GCP] remove ansible.utils.display for deprecations ( #24738 )
...
* [GCP] remove ansible.utils.display for deprecations, use module.deprecate instead.
* removed test file from legacy files
2017-05-18 12:07:16 -04:00
Dylan Silva
bba4549b43
Downgraded more modules from Curated to Community ( #24751 )
2017-05-18 08:28:41 -07:00
Will Thames
5741712a09
ec2_group_facts tag list should have case preserved ( #24760 )
...
Tags should retain case, and should not be snake cased.
Easiest way to do this is to snake before converting tag
list as while that affects the keys of the boto3 tag lists,
it doesn't affect the values. Need to use `tag_value_key_name`
and `tag_name_key_name` following recent change to
`boto3_tag_list_to_ansible_dict`, which used to handle both
`key`/`Key` and `value`/`Value`
2017-05-18 09:34:53 -04:00
Trishna Guha
feafae70b5
Fix transport getting set to None when not set explicitly ( #24769 )
...
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-05-18 15:11:09 +05:30
Dag Wieers
ac1017b7ad
ansible/constants: PEP8 compliancy ( #24692 )
...
- Make PEP8 compliant
2017-05-18 10:39:01 +01:00
Dag Wieers
37bfca23c9
slurp: PEP8, imports, cosmetics ( #24677 )
...
- Make PEP8 compliant
- Ensure imports are specific
- Few cosmetic changes (sort lists, casing, punctuation)
2017-05-18 08:40:24 +01:00
Dag Wieers
de907a8e36
ansible/compat/: PEP8 compliancy ( #24689 )
...
- Make PEP8 compliant
2017-05-18 08:36:11 +01:00
Dag Wieers
ac27c54c2e
ansible/errors: PEP8 compliancy ( #24693 )
...
- Make PEP8 compliant
2017-05-18 08:34:57 +01:00
Dag Wieers
7a5e46c732
aix_lvol: PEP8, imports, cosmetics ( #24717 )
...
- Make PEP8 compliant
- Ensure imports are specific
- Few cosmetic changes (sort lists, casing, punctuation)
2017-05-18 08:31:07 +01:00
James Cammarata
5728bd9065
Merge branch 'modules_issue_1568' of https://github.com/ajdecon/ansible into ajdecon-modules_issue_1568
2017-05-18 02:28:08 -05:00
Dag Wieers
6b7d669a2b
win_psexec: Change default for -nobanner ( #24739 )
...
* win_psexec: Change default for -nobanner
* Update documentation too
2017-05-18 08:25:38 +01:00
Abhijeet Kasurde
2f955e7da8
Save commit_timeout as string in junos_config ( #24761 )
...
Fix converts commit_timeout to string as
Elementree.SubElement requires text as string.
Fixes #24611
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-05-18 12:38:26 +05:30
Matt Martz
e7d8ebf080
Base changes required to allow winrm to work on py3 ( #24744 )
2017-05-17 14:26:32 -07:00
James Cammarata
f217dae938
Also check the iterator for failed host status in linear strategy
...
When only looking at the failed state of the TaskResult, certain failures
cause the linear strategy to fail out sooner than it should and not execute
the always portion of blocks.
Fixes #24301
2017-05-17 13:41:29 -05:00
Lee Shakespeare
e2c08edfcc
Tower user remove organization ( #24544 )
...
* Remove organization field from the tower_user module re: issue #24510
* Fix trailing spaces.
* Fixes for Shippable errors, pep8
* Remove a random inserted space.
2017-05-17 14:30:14 -04:00
QijunPan
40c2b8cac9
Contributing new lib/ansible/module_utils/ce.py module to manage HUAWEI data center CloudEngine switch ( #21666 )
...
* add module_utils ce.py
add module_utils ce.py
* update module_utils/ce.py to support netconf
update module_utils/ce.py to support netconf
* update module_utils ce.py
update module_utils ce.py
2017-05-17 18:36:34 +01:00
Monty Taylor
6e85ac2ba6
Deal with server.security_groups being None ( #24742 )
...
It shouldn't happen - but there is a bug in shade where it can be None
but should be [] instead. Work around it.
Fixes #24675
2017-05-17 12:17:31 -05:00
Jonathan Mainguy
3ad09604f2
add catapult as a sms /mms api notification provider. ( #23052 )
2017-05-17 16:23:38 +01:00
Ganesh Nalawade
38eeeb755d
Add ios changes for Python3 ( #24601 )
...
* Add ios changes for Python3
Make `execute_command` arguments and its
return value complaint to PY3 changes
made in PR #24431
pep8 fixes
* Fix CI issues
* Fix review comment
2017-05-17 20:00:52 +05:30
Jose Armesto
3eb8142a41
[cloud] Fixes #24578 : ROLLBACK_COMPLETE is a failure state for CloudFormation module ( #24596 )
...
* ROLLBACK_COMPLETE is a failure state
Fixes #24578
* Adding AWS documentation on Stack status
* Fixed comment
2017-05-17 09:17:47 -04:00
Andrea Tosatto
b230b03045
[cloud] Rebase and fix ENI lookup logic to only hit unique ENIs (rebase of #20039 ) ( #23404 )
...
* fix eni lookup logic to update them only when univocally specified (Fixes #19972 )
remove redundant eni lookup
* Rename the univocally_find_eni method to uniquely_find_eni
* Idempotency logic minor fixes
* Fixing pep8 reported issues
* Adding a required_together constraint for instance_id and device_index
* Fix ec2_eni private_ip_address matching
* Adding an example of matching via subnet_id and private_ip_address
* Removing the required_together and subnet_id constraints
* Addding some notes to explain the module assumptions
* Implementing Ryan's wording proposal
2017-05-17 08:54:37 -04:00
Abhijeet Kasurde
ad41d0e88f
Pep8 fixes for parted ( #24713 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-05-17 09:23:41 +01:00
Trishna Guha
8937246f8f
Fix nxos ospf and Unit test ( #24613 )
...
* nxos_ospf fixes refactor
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
* unit test nxos_ospf
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-05-17 11:16:41 +05:30
QijunPan
05d8b64cc9
Contributing lib/ansible/modules/network/cloudengine/ce_vrf_af.py module to manage HUAWEI data center CloudEngine ( #22078 )
...
* add ce_vrf_af.py
* upgrade ce vrf af
* metadata_version update
* fix review issues
* fix CI issues
2017-05-16 22:52:41 +01:00
QijunPan
a8570db624
Contributing lib/ansible/modules/network/cloudengine/ce_ntp.py module to manage HUAWEI data center CloudEngine ( #22057 )
...
* add ce_ntp
add ce_ntp
* fix review issues
* deal pep8 issues
2017-05-16 22:51:09 +01:00
QijunPan
7722b95dd4
Contributing lib/ansible/modules/network/cloudengine/ce_static_route.py module to manage HUAWEI data center CloudEngine ( #22072 )
...
* add ce_static_route
add ce_static_route
* upgrade Static Route
* fix review issues
* fix CI issues
* fix CI issue
* fix CI issue
2017-05-16 22:49:37 +01:00
QijunPan
d7e6a6bff3
Contributing lib/ansible/modules/network/cloudengine/ce_vrf.py module to manage HUAWEI data center CloudEngine ( #22077 )
...
* add ce_vrf.py
* update ce_vrf.py
update ce_vrf.py
* upgrade vrf
* metadata_version update
* fix review issues
* fix RETURN doc
2017-05-16 22:48:10 +01:00
QijunPan
7bb64bb9a4
Contributing lib/ansible/modules/network/cloudengine/ce_vxlan_vap.py module to manage HUAWEI data center CloudEngine ( #22084 )
...
* add ce_vxlan_vap.py
* metadata version upate
* fix fail_json msg
2017-05-16 22:46:45 +01:00
QijunPan
45f05ca8aa
Contributing lib/ansible/modules/network/cloudengine/ce_mlag_interface.py module to manage HUAWEI data center CloudEngine ( #22055 )
...
* add ce_mlag_interface
add ce_mlag_interface
* upgrade ce mlag interface
* fix CI issues
2017-05-16 22:44:49 +01:00
QijunPan
fbeec055a4
Contributing lib/ansible/modules/network/cloudengine/ce_netconf.py module to manage HUAWEI data center CloudEngine ( #22056 )
...
* add ce_netconf
add ce_netconf
* update
* upgrade netconf
* fix review issues
* fix review issue.
2017-05-16 22:43:33 +01:00
Ricardo Carrillo Cruz
14b1405ee4
Fix conn_type assignment ( #24697 )
...
This should be a single equal, not a double-one
2017-05-16 23:14:17 +02:00
Brandon Davidson
0210a1a7dc
[cloud] Add vpc_id option for ec2_lc security group lookups by name ( #24459 )
2017-05-16 16:46:28 -04:00
Daniel Shepherd
cf4806d29d
[cloud] Update AWS CloudTrail module to use boto3 and updated/new CT parameters ( #22884 )
...
remove cloudtrail.py from legacy-files as it passes pep8 tests now
update return values to use snake case per coding guidelines
update boto3 exception handling to use method outlined in coding guidelines
update parameter spec and return value code per PR code review
2017-05-16 16:45:03 -04:00
Tom Melendez
07c55b855a
[GCP] Forwarding Rule module ( #24627 )
...
* [GCP] Forwarding Rule module
* pep8 formatting for tests
* remove py26 check and updated_ key; docs and typo fixes
2017-05-16 16:40:34 -04:00
Tom Melendez
29decad261
[GCP] Target Proxy Module ( #24527 )
...
* [GCP] Target Proxy Module
* pep8 fix
* updates from review: removed 26 check, fix get method, typos, renamed url_map to url_map_name
* removed blank line
2017-05-16 15:25:12 -04:00
Ganesh Nalawade
e52d06b401
Add dellos9 changes for Python3 ( #24607 )
...
* Add dellos9 changes for Python3
Make `execute_command` arguments and its
return value complaint to PY3 changes
made in PR #24431
* Minor changes
2017-05-17 00:36:52 +05:30
Ganesh Nalawade
a883635aeb
Add dellos6 changes for Python3 ( #24606 )
...
Make `execute_command` arguments and its
return value complaint to PY3 changes
made in PR #24431
2017-05-17 00:36:32 +05:30
Ganesh Nalawade
442df927f1
Add dellos10 changes for python3 ( #24608 )
...
Make `execute_command` arguments and its
return value complaint to PY3 changes
made in PR #24431
2017-05-17 00:36:15 +05:30
Ganesh Nalawade
a3c689bf0d
Add sros changes for Python3 ( #24604 )
...
* Add sros changes for Python3
Make `execute_command` arguments and its
return value complaint to PY3 changes
made in PR #24431
Code cleanup
pep8 fixes
* Fix CI issue
2017-05-17 00:33:36 +05:30
Ganesh Nalawade
16d610c1de
Add vyos changes for Python3 ( #24603 )
...
* Add vyos changes for Python3
Make `execute_command` arguments and its
return value complaint to PY3 changes
made in PR #24431
pep8 fixes
* Fix CI issues
2017-05-17 00:32:59 +05:30
Ganesh Nalawade
f4e1dc503b
Add iosxr changes for Python3 ( #24605 )
...
* Add iosxr changes for Python3
Make `execute_command` arguments and its
return value complaint to PY3 changes
made in PR #24431
* Fix CI issue
2017-05-17 00:32:41 +05:30
Dag Wieers
4f29662a9e
ansible/vars/: PEP8 compliancy ( #24685 )
...
- Make PEP8 compliant
2017-05-16 18:51:27 +01:00
jctanner
bfc551b3f8
Add vmware_guest_find.py module ( #24260 )
...
* Add vmware_guest_find.py module
* Fixup linter errors
* Add missing empty line
2017-05-16 08:48:40 -07:00
Lemar Carthens
ef13f0f389
vmware_guest: Fix VM creation when adding a network device without a MAC address ( #24138 )
...
* vmware_guest: Fix VM creation when adding a network device without a MAC address
* Provide python2.4 compatibility
2017-05-16 08:47:49 -07:00
James Cammarata
e5cd675b38
Use delegated vars for the delegated host name
...
In _process_pending_results (strategy/__init__.py), we were using the delegate_to
field directly from the original task, which was not being templated correctly.
As an alternate to #23599 , this patch instead pulls the host name out of the delegated
vars passed back in the task result dictionary to avoid having to re-template things.
Fixes #23599
Fixes #20508
2017-05-16 10:24:42 -05:00
Will Thames
9a958da57e
[cloud] Make ec2_vpc_nat_gateway results consistent ( #24042 )
...
Ensure newly created NAT gateways get converted to snake dict
Remove custom code, and associated test, for generating snake
dict and use `camel_dict_to_snake_dict`
Make use of `required_if` rather than bespoke parameter checks
Remove ec2_vpc_nat_gateway from pep8 legacy files list
2017-05-16 11:14:05 -04:00
kwerey
668092e95a
[cloud] Add support for AWS China to elasticache_subnet_group role ( #24286 )
2017-05-16 11:10:15 -04:00
kwerey
6f66e88bd8
[cloud] Use boto connect_to_region so Elasticache works in AWS China ( #24250 )
2017-05-16 11:09:54 -04:00
Will Thames
6e13e3918f
[cloud] Update VPC configuration for existing lambda ( #24368 )
...
If a lambda exists but does not have a VPC configuration,
add the VPC configuration when it's present in the ansible
parameters.
Prior to this change, setting VPC configuration on a lambda
that did not have any VPC configuration would ignore that config.
2017-05-16 11:08:21 -04:00
Ondra Machacek
4d890c1e9f
cloud: ovirt change URL in documentation ( #24438 )
2017-05-16 10:48:26 -04:00
Ganesh Nalawade
f5d865a208
Fixes #24251 save config only if it is changed ( #24345 )
...
* Fixes #24251 save config only if it is changed
Save to startup configuration only when it is different
from running configuration.
* Fix unit test issue
2017-05-16 19:54:36 +05:30
Dag Wieers
c6533d4da9
utils/unicode: PEP8 compliancy ( #24668 )
...
- Make PEP8 compliant
2017-05-16 15:24:22 +01:00
Nathaniel Case
f240ba6b60
nxos_bgp_neighbor cleanup ( #24446 )
2017-05-16 10:14:10 -04:00
Nathaniel Case
ea2569db92
Workaround for unicast RPF check ( #24519 )
2017-05-16 10:11:52 -04:00
Dag Wieers
d07f18fbb9
module_utils/rax: Small parameter cleanup ( #24664 )
...
Nothing really fancy.
- Removing boolean choices
- Use path-type for credentials
2017-05-16 10:02:04 -04:00
Lujeni
a3a0742ce5
Add new aws module - iam_cert_facts ( #24451 )
2017-05-16 09:31:39 -04:00