Commit graph

47937 commits

Author SHA1 Message Date
Roman
504d76e956 acl: fix module failure if there're spaces in a path (#63280)
* Make acl module to work with whitespaces in path

* Added a changelog fragment

* Add quotes to changelog fragment
2019-10-11 10:40:19 -07:00
Benjamin Brabant
29939383e6 Improve ecs_ecr module to handle image_tag_mutability feature (#62871)
Since 2019 jul. 26, AWS Elastic Container Registry can be configured to be immutable that prevent overwritting of an existing tag in the registry.
https://aws.amazon.com/fr/about-aws/whats-new/2019/07/amazon-ecr-now-supports-immutable-image-tags/
https://docs.aws.amazon.com/AmazonECR/latest/userguide/image-tag-mutability.html

By default, ecr is created MUTABLE, as this was the only option before this feature.
This module leverage new capabilities of boto3 to configure image_tag_mutability option.
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ecr.html#ECR.Client.put_image_tag_mutability

The image_tag_mutability option definition was inspired by existing terraform module.
https://www.terraform.io/docs/providers/aws/r/ecr_repository.html
2019-10-11 09:13:13 -07:00
tacatac
df283788e5 Nosh module documentation update (#63303)
* detail the 'status' dictionary
* did not add individual descriptions, see nosh documentation for those
* sample: False not being rendered unless 'False' is quoted
2019-10-11 11:07:53 -05:00
Matt Martz
7f4befdea7
Wrap CLI Passwords with AnsibleUnsafeText, ensure unsafe context is not lost during encode/decode (#63351)
* Wrap .encode and .decode on AnsibleUnsafe objects

* runme.sh needs to be executable

* ci_complete

* Update changelog with CVE
2019-10-11 09:17:10 -05:00
Gonéri Le Bouder
73febd4ea6 prepare_vmware_tests: use module_defaults (#63209) 2019-10-11 19:46:54 +05:30
Sandra McCann
bdd0fac606 add note about collection links (#63346) 2019-10-11 08:27:26 -05:00
Xu Yuandong
b7f12f9ff3 ce_netstream_global: bugs fix(list index out of range) (#63332)
* update to fix bugs:index out of range

* list index out of range

* list index out of range

* update for bad-whitespace

* Update ce_netstream_aging.py

* Update ce_netstream_aging.py

* Update ce_netstream_global.py

* Update ce_netstream_global.py

* Update ce_netstream_global.py

* Update ce_netstream_template.py

* Update ce_netstream_global.py

* Update ce_netstream_global.py

* Update ce_netstream_template.py

* Update ce_netstream_aging.py
2019-10-11 07:09:53 -04:00
Jacob Snapp
79ab8cb48d enabled check mode on nxos bgp modules (#57360)
* enabled check mode on nxos bgp modules

* fixed indentation

* spaces instead of tabs
2019-10-11 11:50:40 +05:30
Gonéri Le Bouder
82dedec011 vmware_guest_sendkey/test: ensure the test VM is running (#63359)
The `vmware_guest_sendkey` module fails if the test VM is off. We this
commit, we ensures the VM is running.
2019-10-11 07:52:36 +05:30
Gonéri Le Bouder
286102eb5e vmware_host_kernel_manager: fix the test (#63358)
PR #62161 changed the name of key
returned by the module from `ansible_module_results` to
`host_kernel_status`.
2019-10-11 07:52:05 +05:30
Adam Miller
aaef214a26 adapt to firewalld 0.7.0 for RHEL 8.1 Beta, Fedora 31+ (#63357)
Fixes #63254

Signed-off-by: Adam Miller <admiller@redhat.com>
2019-10-10 18:33:18 -04:00
James Cassell
bfd32c9b00 clean "changed" only after it has been processed (#59958)
* clean "changed" after it has been processed

without this change, a loop of `debug` tasks with `changed_when`
causes the "changed" status to get lost before output

* runme.sh tests for debug loop status
2019-10-10 18:24:31 -04:00
Abhijeet Kasurde
35cc228b3b VMware: name is not required parameter for vmware_guest_custom_attributes
Fixes: #63222

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-10-10 17:25:20 -04:00
ocarli
b3deab4319 Update sros_config.py (#63132) 2019-10-10 16:56:08 -04:00
ののし
6ff5968781 fix aruba_config examples (#63136) 2019-10-10 16:41:03 -04:00
Prasad Katti
32980f214a [ec2_launch_template] Update examples (#63152)
- Update tasks names for existing examples
- Add a new example showing how to delete a launch template
2019-10-10 16:36:56 -04:00
Jian Fang
719170e5c1 Update ec2.py (#63260)
Change the explanation of spot_wait_timeout
2019-10-10 16:34:22 -04:00
Matt Martz
03b98f6351 Fix plain format output functionality (#63107) 2019-10-10 15:46:36 -04:00
Matt Davis
6d52bdf4db
fix default collection resolution in adhoc (#63298)
* fix default collection resolution in adhoc

* if an adhoc command is run with a playbook-dir under a configured collection, default collection resolution is used to resolve unqualified module/action names

* Set ANSIBLE_PLAYBOOK_DIR in integration tests.

* Fix config conflict in ansible integration test.

* add adhoc default collection test

* text-ify warning string
2019-10-10 12:42:03 -07:00
Matt Davis
b20a0f4831
text-ify config warning message (#63349) 2019-10-10 11:31:54 -07:00
Gonéri Le Bouder
add74fd24b vmware_guest_network: avoid functional test failure
- Avoid the 00:50:56 MAC prefix, See: https://github.com/ansible/ansible/issues/63302
- Create an Ad-Hoc VM for the test and wait until the VMware tools are
  ready
2019-10-10 13:26:47 -04:00
Gonéri Le Bouder
7de70bde52
prepare_vmware_test: avoid the dependency on jmespath (#63344)
We don't really need to depend on jmespath for this.
2019-10-10 13:25:07 -04:00
Pavan Bidkar
904e8434db VMware: Add support to delete vm from inventory (#62903)
Fixes: #55572
2019-10-10 17:07:23 +05:30
Andrey Klychkov
3e87429365 mysql_replication: add support of resetmaster choice to mode parameter (#63321) 2019-10-10 13:02:57 +02:00
René Moser
64a66f566d
doc: mysql_info: add changelog and version_added for global_status (#63328) 2019-10-10 13:01:02 +02:00
JayalakshmiV
45acdb41d2 Added Exos vlan resource module (#61865)
* EXOS_VLAN resource module

* EXOS_VLAN resource module

* EXOS_VLAN resource module

* EXOS_VLAN resource module

* EXOS_VLAN resource module

* Fix exos_vlans resource module and integration test

* Move exos_vlan folder to exos_vlans folder

* Fix exos->config->vlans and exos->utils

* Fix version_added

* Improve exos_vlans module and integration tests

* Fix exos_vlans.py

* exos_vlan resource module
2019-10-10 06:50:04 -04:00
Yap Sok Ann
eca33b80f0 mysql_info: add support for global status (#63189)
Signed-off-by: Yap Sok Ann <sokann@gmail.com>
2019-10-10 12:14:49 +02:00
Ondra Machacek
f2e5e6de23 ovirt_vm: Fix getting console parameter (#63325)
Previously if the ovirt_vm module was executed without graphical_console
parameter, the task failed with "NoneType has no attribute 'get'". The
problem was that we obtained the graphical_console by
self.param('graphical_console', dict()), which returned None, in case
graphical_console is not passed instead of empty dict. So we must
change the line to self.param('graphical_console') or dict().
2019-10-10 04:32:00 -04:00
Andrey Klychkov
38d1025d58 mysql_replication: add mutually_excl block, new maintainer, seealso, change doc formatting (#63295) 2019-10-10 03:06:45 -04:00
Matt Davis
77de663879
config encode errors should not be fatal (#63311)
* fixes #63310
* subset of fixes from #58638
* added warning on error
2019-10-09 17:08:29 -07:00
Sam Doran
9d014778ad
cronvar - use correct binary name (#63279)
Fixes regression introduced by #62554
Add integration tests for cronvar
2019-10-09 18:33:25 -04:00
Jill R
ce402f003f
Fix STS assume role error message when role does not exist (#63249)
AWS appears to have changed this error message again.
Fixes https://app.shippable.com/github/ansible/ansible/runs/145643/115/tests
2019-10-09 14:08:29 -07:00
Adrian Likins
ed203c5902 Fix galaxy url use everywhere when url is set in config. (#63286)
In addition to trying the configured url (for ex, a migrated
'https://galaxy.ansible.com/') there is an attempt at that
URL with '/api' postpended.

If the extended URL works, update GalaxyAPI.api_server to
use the extended URL. Previously it only used it for finding
the API root info ('available_versions', etc)
2019-10-09 16:24:46 -04:00
Felix Fontein
5349b3ae4c
docker_* modules: docs improvements (#63165)
* Improve docker_container docs.

* Fix usage of C(...) and I(...).

* Fix abuses of I(...).

* tls_verify has been made an alias of validate_certs some time ago.

* Fix YAML problems.

* Update lib/ansible/modules/cloud/docker/docker_container.py

Co-Authored-By: Andrey Klychkov <aaklychkov@mail.ru>

* Update lib/ansible/modules/cloud/docker/docker_container.py

Co-Authored-By: Andrey Klychkov <aaklychkov@mail.ru>

* Fix order.

* Split long description.

* Improve formatting.

* Rewrite state docs.

* Make proper sentences.
2019-10-09 22:21:28 +02:00
Saleh Batati
1d5206f53e Pass a JSON file to the Lambda's payload (#63261)
* Add an example of passing a JSON file to the Lambda's payload
Events passed to Lambda are commonly in JSON format, the change provides an example of using JSON file as an alternative to the inline YAML payload in the other examples.
2019-10-09 15:10:32 -05:00
Jian Fang
5ed163ce3f Spot instance code error (#63246)
##### SUMMARY
Adds 'instance_initiated_shutdown_behavior: terminate' to spot instance example for greater efficiency.
2019-10-09 14:57:13 -05:00
Kev Pearce
81a614684a Typo on line 161 (#63133)
fix module name for azure_rm_manageddisk in one example
2019-10-09 14:38:32 -05:00
thaim
021d095625 Fix broken link (#63185) 2019-10-09 14:36:43 -05:00
m3gat0nn4ge
ce1c8c24f7 Update win_disk_facts.py example (#63266)
Fix incorrect index for second disk (should be `disks[1]` not `disks[0]`)
2019-10-09 14:21:37 -05:00
Felix Fontein
aa04e61c89 docker_* modules: add docker module defaults group (#63164)
* Add docker module defaults group.
* Add footnote about docker_stack not being included (instead of remarks column)
2019-10-09 14:12:02 -05:00
memotype
b46299ff86 Update stat.py (#63289)
Reword awkward documentation language.
2019-10-09 14:07:56 -05:00
Michael C
19587b35da docs: add Centos and Ubuntu to examples for playbook conditionals (#63085)
* docs: add Centos and Ubuntu to examples for playbook conditionals

Co-Authored-By: Sandra McCann <samccann@redhat.com>
2019-10-09 14:05:21 -05:00
Martin Nečas
0fcb6574dd Ovirt: add ovirt_vnic_profile_info (#62396) 2019-10-10 00:20:12 +05:30
Alexander Kapshuna
3ad602bfa6 Add aliases to path parameter of stat module (#61270) 2019-10-09 11:24:59 -04:00
James Powis
d4ad541eee dest lives in 4 different places depending on exeuction type (#62444) 2019-10-09 19:50:08 +05:30
Nathaniel Case
d336a14da6 Fix junos unicode errors. (#63046) 2019-10-09 19:26:27 +05:30
Andrey Klychkov
71bcce5db5 mysql_replication: add channel parameter (#63271)
* mysql_replication: add channel parameter

* mysql_replication: add channel parameter, add changelog
2019-10-09 14:27:01 +01:00
Martin Krizek
f72d4d2339
Do not use fully qualified module_utils imports (#63101) 2019-10-09 11:30:43 +02:00
Andrey Klychkov
9f9afcb203 mysql_replication: add connection_name param for MariaDB multi source replication support (#63229)
* mysql_replication: add connection_name param for MariaDB multi source support

* mysql_replication: add connection_name param for MariaDB multi source support, add changelog
2019-10-09 10:05:55 +02:00
Matt Davis
fd229dcbb5
add ANSIBLE_PLAYBOOK_DIR envvar support (#63220)
* add ANSIBLE_PLAYBOOK_DIR envvar support

* allows `ANSIBLE_PLAYBOOK_DIR` envvar as a fallback on CLI types that support `--playbook-dir`. This should have been implemented with #59464, but was missed due to an oversight.
* added basic integration test

* make first-class PLAYBOOK_DIR config entry

* update changelog
2019-10-08 17:34:15 -07:00