Commit graph

27635 commits

Author SHA1 Message Date
Benjamin Doherty
ac72df08dd Updates to archive module based on code review (#2699)
* Use common file arguments on destination file
* Rename 'compression' to 'format' h/t @abadger
* Add support for plain 'tar' format
* Ensure check_mode is respected
2016-12-08 11:34:50 -05:00
Peter Sprygada
4932df69bc updates to asa_config module for Ansible 2.2
* clean up functions and remove unneeded code
* config difference now includes keyword argument
* module reports changed when save argument is yes with or without check_mode
* updated fail_json return with exc kwargs
* fixed up import statements
2016-12-08 11:34:50 -05:00
Peter Sprygada
dc52d3627a fixes a number of nagging issues in asa_acl due to refactoring
* fixes issues with import error
* removes need for filter attribute in Cli instance
* now filters config either from device or provided via config argument

ref: #2890
2016-12-08 11:34:50 -05:00
Rene Moser
edb24dac2d jenkins_job: refactoring 2016-12-08 11:34:50 -05:00
Rene Moser
3c04ed977d jenkins_job: implement diff support 2016-12-08 11:34:50 -05:00
Rene Moser
171b71cfa0 jenkins_job: rename enable to enabled and mutually exclusive with config
Jenkins stores the information about the state (disabled/enabled) in the config, which result in a race condition between `config` and `enabled` and we loose idempotency. It makes sense to define them mutually exclusive.

Renamed `enable` to `enabled`. Ansible uses the name `enabled` in many modules, e.g. service as it indicates a state not an action.
2016-12-08 11:34:50 -05:00
Rene Moser
bd4c935fd7 jenkins_job: default state to present 2016-12-08 11:34:50 -05:00
Will Thames
3eeda4f844 firewalld should fail nicely when service is stopped (#2871)
Ensure the HAVE_FIREWALLD checks check only for the
presence of the python dependencies, and not the age
of the library or the state of the service, which
are checked later.
2016-12-08 11:34:50 -05:00
Peter Sprygada
7ce98f52cf bug fix in asa_acl module for missing candidate config
This bug was introduced accidentally when refactoring to 2.2.  The instance
of the candidate config was deleted.  This adds the candidate config
instance back

fixes #2890
2016-12-08 11:34:50 -05:00
Tobias Wolf
62575fdf48 Fix one character typo in my previous PR for debconf module (#2899)
Small oops in the previous PR #2530 commit.

Instead of `diff_dict` it slipped through as `diffdict`.

Please merge and sorry.
2016-12-08 11:34:50 -05:00
Alex
e2795d1401 Start zypper in non-interactive mode (#2854) 2016-12-08 11:34:50 -05:00
sgujic
d34f3b4c05 Create temporary file in a secure manner. (#2887) 2016-12-08 11:34:49 -05:00
Nils Pascal Illenseer
acadc2ac9c Delete lxd container in state stopped (#2885)
If a lxd container is stopped, do not stop it before deleting it.
2016-12-08 11:34:49 -05:00
Gilles Gagniard
05c8630b48 GCE : Fix image family handling with libcloud > 0.20.1 (#2289)
* fix image family handling with libcloud > 0.20.1

* add missing import
2016-12-08 11:34:49 -05:00
Robyn Bergeron
7c27f57052 Updating GUIDELINES.md
Updating info on how issues are routed via bot.
2016-12-08 11:34:49 -05:00
Greg DeKoenigsberg
39c1c14a08 Update MAINTAINERS.md
We could have deleted this, but just in case there are links to it from elsewhere, providing a redirect to the now authoritative GUIDELINES.md.
2016-12-08 11:34:49 -05:00
Greg DeKoenigsberg
41d7066a58 Point to GUIDELINES.md 2016-12-08 11:34:49 -05:00
johanwiren
e98eb785df Fix share aliases logic (#2862) (#2875)
Fixes #2862
2016-12-08 11:34:49 -05:00
John R Barker
3f1c3a0532 Document a10_server new options (#2876)
* Document write_config and validate_certs
2016-12-08 11:34:49 -05:00
Steve Gargan
7cd3da9b58 correctly iterate and return results of any service checks. (#2878)
current implementation was breaking making the module unusable, changing to the list comprehension fixes this. Also default to seconds instead of throwing a exception when no duration units are supplied as this causes tests to fail
2016-12-08 11:34:49 -05:00
Matt Clay
d00e941a0e Remove stderr=False from calls to exit_json. (#2879) 2016-12-08 11:34:49 -05:00
Tim Rupp
7e36f4f302 Adds bigip_ssl_certificate module (#2831)
Adds bigip_ssl_certificate module

This module is another in the ongoing "bootstrapping saga" that is
being undertaken. With this module you can manage the lifecycle of
the SSL certificates on a BIG-IP. This includes those used for
SSL offloading.

Tests for this module can be found here

https://github.com/F5Networks/f5-ansible/blob/master/roles/__bigip_ssl_certificate/tasks/main.yaml

Platforms this was tested on are

12.0.0
12.1.0
2016-12-08 11:34:49 -05:00
Ryan S. Brown
a96261a391 Normalize variable naming in cloudformation_facts module using camel2snake 2016-12-08 11:34:49 -05:00
Ryan S. Brown
215a591771 cloudformation_facts: Connect boto3 using the module_utils AWS connection instead of calling boto3 directly 2016-12-08 11:34:49 -05:00
jmenga
0d6073aa47 New module cloudformation_facts (#2329) 2016-12-08 11:34:49 -05:00
Michael Scherer
f8b7ab1e10 Do not crash if the system do not have required modules (#2852) 2016-12-08 11:34:49 -05:00
Tobias Wolf
e969010cf9 Add diff mode output to debconf module (#2530)
Support diff such that the previous and current settings are visible
without debug output and just with `--diff` if requested.
2016-12-08 11:34:49 -05:00
sermilrod
03b1844150 adding jenkins_job module (#2521) 2016-12-08 11:34:48 -05:00
Werner Dijkerman
800e1c7bc0 Added new module opendj_backendprop for updating backend settings opendj (#2855)
Add opendj_backendprop
2016-12-08 11:34:48 -05:00
Peter Sprygada
32bbddee23 update asa_config module
* removes get_module() factory method for NetworkModule
* add src argument to provide path to config file
* add new choice to match used to ignore current running config
* add update argument with choices merge or check
* add backup argument to backup current running config to control host
* add defaults argument to control collection of config with or withoutdefaults
* add save argument to save current running config to startup config
2016-12-08 11:34:48 -05:00
Peter Sprygada
e2e0029fab roll up of updates to asa_template
This updates the asa_template module with updates for Ansible 2.2.

* removes get_module() in favor of NetworkModule
* fixes up import statements
2016-12-08 11:34:48 -05:00
Peter Sprygada
283cc51fdb added new functionality to asa_command
* commands argument now accepts a dict arguments
* only show commands are allowd when check mode is specified
* config mode is no longer allowed in the command stack
* add argument match with valid values any, all
2016-12-08 11:34:48 -05:00
Peter Sprygada
8e45ec9734 roll up updates to asa_acl module
* remove get_module() in favor of NetworkModule
* fix up import statements
* roll up fixes for NetworkConfig object handling
2016-12-08 11:34:48 -05:00
Filipe Niero Felisbino
9ba2f0f266 Fix attachment issue ( thanks @gunzy83 ) 2016-12-08 11:34:48 -05:00
Filipe Niero Felisbino
f4ace1e9cc Change attached parameter default to None 2016-12-08 11:34:48 -05:00
Filipe Niero Felisbino
f41900920f Add "version_added" to attached attribute 2016-12-08 11:34:48 -05:00
Filipe Niero Felisbino
1c1a17bfd2 Add attached parameter to ec2_eni module 2016-12-08 11:34:48 -05:00
Filipe Niero Felisbino
94d03b6b55 Add RETURN docs 2016-12-08 11:34:48 -05:00
Filipe Niero Felisbino
7ae8693bda Fix docs 2016-12-08 11:34:48 -05:00
Filipe Niero Felisbino
f8314c3e61 Fix the AMI creation/modification logic thus making it idempotent 2016-12-08 11:34:48 -05:00
Thierno IB. BARRY
bc55db2ff0 elasticsearch_plugin: Fix bug when using proxy (#2603) (#2838) 2016-12-08 11:34:48 -05:00
Nadir
5de3dbbf6d Added redrive policy options (#2245) 2016-12-08 11:34:47 -05:00
Robin Roth
6c9c4e7482 Zypper repo autoimport keys (#2132)
* zypper_repository add auto_import_keys options

* also give more output on failure (rc, stdout, stderr)

* be more specific in the doc for auto_import_keys

* add runrefresh option to zypper_repository

* this comes out of ansible/ansible-modules-extras#2411, where AnderEnder adds refresh to the zypper module
* adds a way to force zypper to refresh a repository
* can be used to refresh independently of auto_import_keys
* add option to run name=* runrefresh=yes
* name runrefresh to not break existing use to refresh (now alias to autorefresh)
* add version_added flag to autorefresh

* remove wrong version_added comment
2016-12-08 11:34:47 -05:00
EarlAbides
961c076e72 Fix ec2_asg_facts module when using name parameter (#2840) (#2841) 2016-12-08 11:34:47 -05:00
Tim Rupp
f48791e8bc Bugfix bigip_facts that was trying to check the length of an iterator (#2842)
Recently, a user reported that the bigip_facts module was failing with the error

    received exception: object of type 'itertools.imap' has no len()

This reported was occurring at line 1657 of the bigip_facts module

bug report is here

https://github.com/F5Networks/f5-ansible/issues/25

Upon further investigation, the map function for returning the specified
includes was returning an iterator, and calling len() on an iterator does
not work.

I believe this problem was caused by part of the Python 3.x effort insofar
as the inclusion of this line

https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/basic.py#L143

seems to affect our usage of map(), probably for the better anyway, and we need
to change our expectations in our module's code to no longer assume a list, but
instead assume an iterator.

After trawling through the module_utils/basic code, I think a list
comprehension is more appropriate here anyway, so I'm changing it to be
that. The affected user reported it works this way, and my own testing
on 2.2.0 supports that.
2016-12-08 11:34:47 -05:00
Kevin Hulquest
e47a5674fb Add facts and storage system modules. (#2748)
* Add facts and storage system modules.

* Update version metadata.

* Add facts and storage system modules.

Update version metadata.

Add init files.

* Fixes for review comments.

* Fixes for review comments.

* Update document fragments for api_* options to indicate they are required.

* Correct bad string concatenation.

* Add option description for validate_certs since basic_auth arg_spec is no longer extended.

* Add default value for validate_certs in docstring.

* Rename directory name so it applies to netapp and not simply eseries platform.

* Rename modules to differentiate other netapp modules.
2016-12-08 11:34:47 -05:00
Robin Roth
fb49e0401e Ensure the return value for changed is bool (#2830)
fixes #2827
2016-12-08 11:34:47 -05:00
Michael Grandjean
70e8bb3092 Fix typo in EXAMPLE section (#2833) 2016-12-08 11:34:47 -05:00
John R Barker
b7afa14f64 Minor tidyup (#2828) 2016-12-08 11:34:47 -05:00
Matt Clay
7e3af74fae Add python3 testing for module PRs. (#2825) 2016-12-08 11:34:47 -05:00