Commit graph

338 commits

Author SHA1 Message Date
Trond Hindenes
cb13575186 Merge pull request #2654 from ilpianista/win_firewall_rule-fix-after-strictmode-merge
win_firewall_rule: fix "property X doesn't exist"
2016-08-17 14:02:57 +02:00
trondhindenes
2d992fe750 updated documentation for win_package (#2677) 2016-08-06 09:45:46 +02:00
Andrea Scarpino
b28daebc2b win_firewall_rule: fix "property X doesn't exist"
After commit 9392943 more properties are always sets with their defaults
values (e.g. service to 'any'). This causes no issue when the rule is created,
but causes an error message that says "The property 'X' cannot be found on this
object. Verify that the property exists." because the module checks for
any property value that has changed, but `netsh advfirewall firewall show rule`
does not list any property unless `verbose` is set. This patch solves this.

Fixes #2624
2016-08-03 11:05:08 +02:00
Robin Schneider
57c142b6ed Use HTTPS instead of legacy HTTP for ansible.com (#2636)
Mechanical edit done by this "one-liner":

git ls-files -z "$(git rev-parse --show-toplevel)" | xargs --null -I '{}' find '{}' -type f -print0 | xargs --null sed --in-place --regexp-extended 's#http://www\.ansible\.com#https://www.ansible.com#g;'

Related to: https://github.com/ansible/ansible/issues/16869
2016-08-02 21:12:51 +02:00
Trond Hindenes
2be4e15a0a bugfix code error in win_firewall 2016-06-23 08:45:29 +02:00
nitzmahone
9df4f6a4c7 fix win_updates to prevent Get-Member failure on bogus job output 2016-06-22 17:19:05 -07:00
Andrea Scarpino
9392943915 win_firewall_rule: strictmode fixes (#2432)
I set the default values to `netsh advfirewall firewall add rule` defaults.
2016-06-20 17:35:27 -04:00
Tim Small
713aaa1d4a Allow parameters to be passed for uninstall (required by some packages) (#2269) 2016-06-20 17:30:10 -04:00
nitzmahone
5cd3e328f3 add win_chocolatey support for nonzero success exit codes 2016-06-20 13:02:29 -07:00
jhawkesworth
07ed6bbd56 Various fixes to win_regedit and documentation (#2436) 2016-06-16 12:32:53 -07:00
nitzmahone
eed9d601b5 StrictMode fixes for win_iis_webbinding
StrictMode fixes for win_scheduled_task

StrictMode fixes for win_webpicmd
2016-06-15 14:46:05 -07:00
Andrea Scarpino
ac32a1b808 Fix win_environment: strict-mode fix for 'value' (#2404) 2016-06-15 11:26:03 -07:00
Rob Powell
43760b2c4a Update win_firewall_rule.py (#2337)
added profile examples as my firewall task would pass yet no firewall rule was created until I added

profile: Domain,Private,Public

When setting a Firewall rule on Windows Server 2008 R2 manually, these three are selected as default, useful to have in the documentation maybe?
2016-06-11 21:12:46 +02:00
Dag Wieers
3ca1254018 Validate return code and fail properly (#2334)
This fixes #2333
2016-06-10 19:24:43 +02:00
Toshio Kuratomi
66b60ce7cd Make documentation of win_unzip work on python3 as well 2016-06-04 10:48:02 -07:00
jjshoe
4d82ff99e2 A couple of touch ups (#2288)
I peeked at #2281 a little late, thought this might help some as well.
2016-05-31 03:33:16 +02:00
René Moser
a055d7240a fix build and doc cleanups (#2286) 2016-05-24 13:24:04 +02:00
jhawkesworth
e35d5f2c54 Add info about where you can find product ids for changed checking on win_package module (#2281) 2016-05-23 16:14:49 -04:00
Nicolas Landais
b11029adca Fix problem with 'restarted' state not restarting the apppool when it is in running state (#1451)
* Fix problem with 'restarted' state not restarting the apppool when it is in running state

* Implemeting code review comments

Comment from previous commit “You basically want to start the pool if
it's stopped and requested state is started or restarted, otherwise if
requested state is restarted, restart it.” This commit implements the
behavior stated in the PR comment
2016-05-20 17:31:46 -07:00
Corwin Brown
d2900e856b Add Win Robocopy module (#1078)
* Added more robust error handling

* Add Win Synchronize module

Renamed win_synchronize to win_robocopy

Updating email address

Adding "flags" argument.

Adding a "flags" argument that will allow the user to pass args
directly to robocopy.

If "flags" is set, recurse and purge will be ignored.

Add return code to output

Added bits to support check mode

Fixing typo in Documentation

Updated Documentation to have "RETURNED" field

Updated win_robocopy.py to have the RETURNED field. I also noticed
that win_robocopy.ps1 wasn't really using the "changed" attribute,
so I went in and made sure it was being set appropriately.

Forcing bool type for recurse and purge flag

Updated "version_added"
2016-05-20 17:25:24 -07:00
Matt Davis
0b66156f25 Merge pull request #2112 from jhawkesworth/fix_ame_2090
Fix for https://github.com/ansible/ansible-modules-extras/issues/2090
2016-04-26 11:43:58 -07:00
=
d198d025de Fix for https://github.com/ansible/ansible-modules-extras/issues/2090 2016-04-26 18:26:50 +01:00
Matt Davis
d9caac037c Merge pull request #1119 from h0nIg/devel_acl_inheritance
win_acl_inheritance
2016-04-26 09:45:42 -07:00
=
7d9b73ec5a fix problem where you couldn't compare empty strings in win_regedit following my previous change 2016-04-22 18:37:31 +01:00
Dreamcat4
9bc12dc9dd win-firewall-rule: temp disable strict-mode for the time being 2016-04-20 21:44:29 +01:00
Dreamcat4
8734e8f397 fix: win-environment strict-mode fixes 2016-04-20 14:13:03 +01:00
Dreamcat4
55c6aee5d1 fix: win-scheduled-task strict-mode fixes 2016-04-20 14:12:11 +01:00
Matt Davis
82da45e520 Merge pull request #2034 from jhawkesworth/add_binary_to_regedit
Windows: win_regedit; Add support for managing binary registry data to win_regedit
2016-04-18 10:59:10 -07:00
=
2ecb1a37dc Documentation improvements 2016-04-15 06:51:16 +01:00
=
7a8d3cf392 Further fixes to support binary data. Added boolean return values and return documentation. 2016-04-14 21:22:10 +01:00
Andrea Scarpino
38cb5c6130 The enable parameter is a boolean, then convert to a boolean. (#1607)
At the moment, this only works when 'enable' is equals to 'yes' or 'no'.

While I'm on it, I also fixed a typo in the example and added a required
parameter.
2016-04-12 14:07:32 +02:00
nitzmahone
5abb914315 win_updates fix to use documented InstanceGuid property name 2016-04-07 17:38:38 -07:00
nitzmahone
93db039783 win_updates shouldn't install hidden updates 2016-04-07 17:38:37 -07:00
=
8192ad24d5 adding the ability to manage binary registry data 2016-04-07 18:22:23 +01:00
Matt Davis
7ce47aff79 Merge pull request #1117 from h0nIg/devel_win_owner
win_owner to change owner
2016-03-31 15:45:34 -07:00
Matt Davis
185bf0abb9 Merge pull request #1830 from wtcross/win-scheduled-task-support-note
Add note server 2012 note to win_scheduled_task.
2016-03-25 07:17:40 +00:00
Hans-Joachim Kliemeck
2ce5b4c526 suggestion by @nitzmahone to not use Get-Attr in combination with ConvertTo-Bool, improved documentation regarding organize 2016-03-22 09:07:09 +01:00
René Moser
22074de5c0 Merge pull request #1648 from ilpianista/win_unzip-use-absolute-path
win_unzip: Use absolute path for src and dest
2016-03-21 18:49:54 +01:00
Brian Coca
a9dbea4b17 Merge pull request #1881 from jhawkesworth/doc_update_win_regmerge
Adds return documentation to win_regmerge module
2016-03-21 10:09:55 -07:00
Hans-Joachim Kliemeck
1c097f9495 suggestion by @nitzmahone, to not use Get-Attr in combination with ConvertTo-Bool 2016-03-21 17:49:51 +01:00
=
90d7a023a0 Added return documentation to win_regmerge module 2016-03-21 08:25:41 +00:00
Andrea Scarpino
7f38638575 win_unzip: Use absolute path for src and dest
win_unzip fails to extract files when either src or dest contains
complex paths such as "..\..\" or "C:\\Program Files" (double slashes).
Fix this by fetching absolute path of both before invoking CopyHere
method.
2016-03-20 12:29:26 +01:00
René Moser
8aa063de91 Merge pull request #1786 from ilpianista/win_firewall_rule-fix-syntax
Fix issue #1406 about win_firewall_rule
2016-03-19 16:57:03 +01:00
René Moser
791cf2b7bb Merge pull request #1649 from ilpianista/win_unzip-overwrite-files
win_unzip: overwrite any existing file
2016-03-19 16:24:23 +01:00
René Moser
218f11f7c4 Merge pull request #1872 from nonshankus/win_updates_comment
Fixing win_updates example for listing available updates.
2016-03-19 01:15:52 +01:00
nonshankus
9f9615f62a Fixing win_updates example for listing available updates. 2016-03-18 19:07:54 +01:00
René Moser
5aa5d6c045 Merge pull request #1828 from liquidat/doc-win_firewall-fix
correct win_firewall state parameter
2016-03-16 18:54:04 +01:00
Toshio Kuratomi
f9b96b9a8a Fix module docs 2016-03-15 17:44:59 -07:00
nitzmahone
34557ee6ec fix version_added issues in win_iis_website 2016-03-11 14:37:46 -08:00
nitzmahone
44effbca58 added doc note to win_iis_website site_id arg 2016-03-11 10:06:30 -08:00