Commit graph

10394 commits

Author SHA1 Message Date
jctanner
6a1dcca4be Merge pull request #6805 from sivel/env-interpreter-fix
Fix interpreter lines in a couple of modules
2014-04-01 15:03:20 -04:00
Matt Martz
b4de76373a Use /usr/bin/python instead of /usr/bin/env python 2014-04-01 13:54:37 -05:00
Andrew Resch
c92ec68fa3 redhat_subscription calls AnsibleModule() without argument_spec
The Rhsm object requires an AnsibleModule but it isn't created with an argument_spec and fails.  Since the rhn.module is set directly after, setting None for the required argument of Rhsm fixes the module.
2014-04-01 11:22:29 -07:00
Michael DeHaan
8d3e22ccc4 Merge pull request #6795 from jjshoe/patch-2
module_retention isn't defined anywhere, including the help.
2014-04-01 10:39:09 -04:00
follower
4be010b09b Clarify the port value always defaults to 3306
While the [boto docs](https://github.com/boto/boto/blob/develop/boto/rds/__init__.py#L253) make it seem like the default value of `port` is changed depending on the engine chosen, AFAICT from looking at the code the default value is never changed from 3306.

I think the docs are intended to be read as "the default value used by <engine> is <port> so you should change `port` to that value".

If you don't specify the port value and chose the database engine as PostgreSQL you'll end up with a PostgreSQL instance running on port 3306.
2014-04-02 02:25:14 +13:00
Chao Luan
134c449cf6 Remove extra quote from the mysqldump password argument
The mysqldb Ansible module will fail if the state specified is import or dump with a '1045: Access Denied' mysql error for complex passwords.

This is caused by the extra quote around the '--password' argument to mysqldump, as pipes.quotes already quotes the password string.

>>> "--password='%s'" % pipes.quote('simple')
"--password='simple'"

>>> "--password='%s'" % pipes.quote('c0mplexp@ssword!')
"--password=''c0mplexp@ssword!''"

>>> "--password='%s'" % pipes.quote('password with space')
"--password=''password with space''"
2014-04-01 23:52:08 +11:00
jjshoe
2387f044e4 module_retention isn't defined anywhere, including the help. 2014-04-01 07:49:51 -05:00
follower
618554ad63 Make vpc_security_group docs more accurate
Without the `subnet` parameter supplied there's an error `msg: Parameter vpc_security_groups invalid for create command`. (This might be a bug?)

If the VPC security group name rather than ID is supplied there's an error: `msg: Invalid security group , groupId= <some group name>, groupName=.` (Accepting a group name might be a feature enhancement.)

In my case I set the subnet as `default` and used `register` to get the result of the security group creation section and just referred to its `group_id` property.
2014-04-02 01:06:45 +13:00
Sven Schliesing
c8e80b2aa4 Output URL for debugging 2014-04-01 13:55:58 +02:00
Till Maas
e6cb32f284 ssh connection plugin: Make comments more verbose
Explain _communicate() more.
2014-04-01 09:46:51 +02:00
Till Maas
2cae7472ad ssh: propagate prompt to _communicate()
_communicate() uses the prompt variable to detect wrong passwords early,
therefore it needs to be passed to it from exec_command().
2014-04-01 09:24:44 +02:00
Michael DeHaan
57acf104c6 Update CONTRIBUTING.md
Disclosure policy should really be up here, so fixing that.
2014-03-31 18:48:28 -04:00
James Tanner
33eec0dc55 Fixes #6398 Add missing parameters to ansible-playbook manpage 2014-03-31 16:49:09 -04:00
James Cammarata
612a1a64f0 Apply extra vars after all other vars have been merged in a play
Fixes #6677
2014-03-31 15:31:10 -05:00
James Cammarata
b9c044b8c9 Making the exception caught during os.dup of stdin explicit
Related to f23bb34
2014-03-31 13:50:23 -05:00
James Cammarata
f23bb344aa Catch errors when duping stdin
Fixes #6657
2014-03-31 13:38:12 -05:00
James Tanner
06920b2e47 Add docs examples for regex_replace 2014-03-31 14:14:57 -04:00
James Cammarata
4f140be711 Merge branch 'devel' of https://github.com/Synforge/ansible into Synforge-devel 2014-03-31 13:04:56 -05:00
James Tanner
98b1cb8297 Update changelog for #5958 2014-03-31 13:51:21 -04:00
James Tanner
efba8b4771 Merge branch 'regexreplace' of git://github.com/jacobweber/ansible into jacobweber-regexreplace 2014-03-31 13:48:13 -04:00
James Tanner
7f7e2a6941 Update changelog for #5910 apt now has deb parameter 2014-03-31 13:17:49 -04:00
James Tanner
c751168895 Fix merge conflicts 2014-03-31 13:15:21 -04:00
James Tanner
811553930a Update changelog for synchronize path changes 2014-03-31 13:02:55 -04:00
James Tanner
9fe2bcd076 Merge #5903 from rhaido/ansible
Update files documentation for usage of force=True and hardlinks
2014-03-31 12:53:03 -04:00
James Tanner
2492c2714a Fixes #5307 set relative paths to the files dir for roles and the inventory dir for non-role tasks 2014-03-31 12:25:40 -04:00
Till Maas
b07113f358 ssh: Properly check for wrong su password 2014-03-31 15:51:12 +02:00
Michael DeHaan
51727e81ac Merge pull request #6769 from ericdahl/docs-typos
Documentation: fix various small typos
2014-03-31 09:36:00 -04:00
Michael DeHaan
9ca9b9fe07 Merge pull request #6768 from mscherer/fix_typo_caps
fix typo in the capabilities module description
2014-03-31 09:34:25 -04:00
Sven Schliesing
fb10ca73dc Update uri 2014-03-31 14:32:56 +02:00
Sven Schliesing
d6943e46ef Example for queueing build in Jenkins 2014-03-31 14:32:07 +02:00
James Cammarata
225eca6311 Adding an options sections to the docstring in the lldp module 2014-03-30 23:08:53 -05:00
Jim Yeh
48dc27ea74 Fix the default url of get_xml function.
* This enable a user to configure uri in get_xml function
2014-03-31 11:05:31 +08:00
James Tanner
6792c76c50 Fix librato_annotation docstring 2014-03-30 22:28:31 -04:00
James Cammarata
81b430ddce Merge pull request #6762 from jimi-c/issue_6731_fix_host_key_dir_creation
Add option to create host_key directory if it doesn't exist
2014-03-30 20:22:52 -05:00
Eric Dahl
9309b6b0e4 Documentation: fix various small typos 2014-03-30 18:45:55 -05:00
Michael Scherer
2dc3153330 fix typo in the capabilities module description 2014-03-30 22:33:24 +02:00
Michael DeHaan
b489fbfbf6 Merge pull request #6767 from mway/devel
don't parse empty stream chunks
2014-03-30 15:47:21 -04:00
Matt Way
034ac93ca2 don't parse empty stream chunks 2014-03-30 15:27:29 -04:00
James Laska
f96618c967 Use proper YAML quotes to fix webdocs 2014-03-30 14:26:18 -04:00
Michael DeHaan
2f75662a47 Merge pull request #6758 from cgtx/devel
backreferences should be double escaped
2014-03-30 11:59:06 -04:00
James Cammarata
1b3f77fafd Merge pull request #6759 from Malvineous/devel
More descriptive error message if init system is unknown
2014-03-30 01:37:17 -05:00
James Cammarata
b698f7a44b Add option to create host_key directory if it doesn't exist
Fixes #6731
2014-03-30 01:34:33 -05:00
James Cammarata
6e809c2be3 Removing wait loop around initial state check during registration
Also fixed a bug in which the state parameter was marked as a 'bool'
type, which was breaking execution of the module.

Fixes #6543
2014-03-29 23:47:11 -05:00
Adam Nielsen
1a9c5947ed More descriptive error message if init system is unknown 2014-03-30 11:46:13 +10:00
James Cammarata
7f18387c5b Merge branch 'devel' of https://github.com/dstokes/ansible into dstokes-devel 2014-03-29 20:17:38 -05:00
James Laska
6c8d8a746f Fix YAML docstring that broke webdocs 2014-03-29 19:15:42 -04:00
cgtx
f6abc17e8a backreferences should be double escaped 2014-03-29 18:14:56 -05:00
Michael DeHaan
322e7de843 Merge pull request #6754 from ahtik/fix-ufw-take2
Bugfix to ufw module to properly support "logging" (and docfix for choises, choices):
2014-03-29 11:32:45 -04:00
Ahti Kitsik
e0f3105ef9 Bugfix for ufw to support "logging" properly:
It's a separate parameter so updated docs and set it as mutually exclusive param.
Also due to an array construction typo it was not working in any situation (ufw LOGLEVEL was passed to cmd instead of ufw logging LOGLEVEL).

Also fixed doc and parameters parsing typo ("choises" should be "choices")
2014-03-29 11:06:51 +02:00
Michael DeHaan
ddd68be4e0 Merge pull request #6749 from danieljaouen/brew
Update homebrew module.
2014-03-28 20:35:57 -04:00