Stephen Fromm
6265be3aee
Fix error handling when switching versions
...
git module used to check stderr for the string 'error' after calling
switch_version(). This changes that to just look at the return code to
determine whether the command failed. If the rc is not zero, the git
module will call fail_json().
The problem is that git checkout will summarize the commit message,
such as:
HEAD is now at ea38409... removing artificial error
When the string 'error' is the commit message, this check will
erroneously think the command failed.
This also removes the method switchLocalBranch() since it is no longer
used.
2012-08-07 11:20:14 -07:00
Michael DeHaan
092f83e6f8
Merge pull request #781 from gottwald/devel-mysql-socketOption
...
login_unix_socket option for mysql modules
2012-08-06 18:45:36 -07:00
Michael DeHaan
faed4b5a33
whitespace + remove deprecated YAML parser (migration script lives in examples/scripts and warning was added
...
in 0.6 release)
2012-08-06 20:07:02 -04:00
Michael DeHaan
08c1f96e4b
Fix some subtle behavior of how the get_url module chains into the file module, plus blend the results of daisy chain
...
operations in the correct order, so the file module results overlay the original module results, not the other way
around (which keeps any failure msg's intact)
2012-08-03 07:02:31 -04:00
Ingo Gottwald
891415e616
Added login_unix_socket option to mysql_user module
2012-08-03 12:35:18 +02:00
Ingo Gottwald
a2aa30f4e5
Added login_unix_socket option to mysql_db module
2012-08-03 12:34:55 +02:00
Michael DeHaan
7e9e29011e
Add encoding lines to python modules such that they can take unicode options if they are fed them, since the
...
AnsibleModule stuff no longer base64 encodes for simplicity and speed reasons.
2012-08-02 21:29:10 -04:00
Michael DeHaan
ce01c3f7e7
Allow unicode transfer by not base64 encoding. Also: faster
2012-08-02 21:20:43 -04:00
Seth Vidal
4d29cd6ee3
make virt module command= work again - better error handling should be in its
...
future
2012-08-02 17:46:21 -04:00
Seth Vidal
fd492bebc6
- add a check for repoquery so we can abort politely
...
- make the results output a bit more readable
- fix up where repoquery is looked for so it is easier to change
2012-08-02 17:02:37 -04:00
Michael DeHaan
98e4034de2
Merge pull request #772 from gottwald/devel-serviceFix
...
Fixed a Bug in the service module "state changed" recognition
2012-08-02 08:49:30 -07:00
Ingo Gottwald
25b52109b4
Fixed a Bug in the service module state changed recognition
2012-08-02 17:18:25 +02:00
Stephen Fromm
85c838c835
Add Blade to FORM_FACTOR list and document SMBIOS spec URL
2012-08-02 07:24:05 -07:00
Stephen Fromm
9a3ad060dc
Catch exception if form factor id is unknown
2012-08-02 07:06:55 -07:00
Michael DeHaan
fa79d57d13
changelog / remove a failed=False
2012-08-01 22:35:07 -04:00
Michael DeHaan
b7c3fd1246
failed should not be in the result returns for a module upon success
2012-08-01 22:30:22 -04:00
Michael DeHaan
91d31d8164
Merge pull request #761 from skvidal/devel
...
redo of yum module - uses more system calls but should handle
2012-08-02 05:13:23 -07:00
Seth Vidal
c91befda5c
redo of yum module - uses more system calls but should handle
...
random plugin vomit better.
also should handle multiple withitems in a single execution, now.
2012-08-02 01:47:48 -04:00
Michael DeHaan
e820c282be
Merge pull request #760 from sfromm/fixes
...
A couple fixes for the file module
2012-08-02 04:54:16 -07:00
Will Thames
0e26ef9bdd
Revert acceptance of directory as dest for copy
...
Although library/copy can be corrected to understand that dest is
a directory, I can't see how to let _execute_copy know this and let the
file module know.
As a better solution than before #733 , the copy module now explicitly (rather
than silently) fails when dest is a directory.
2012-08-02 16:54:03 +10:00
Stephen Fromm
d0892c19ad
Add setype to file's argument_spec and remove secontext
...
secontext is used internally and should not be in argument_spec
2012-08-01 22:24:09 -07:00
Stephen Fromm
52afacf475
Fix module_fail_json call when symlink src does not exist
2012-08-01 22:23:02 -07:00
Michael DeHaan
25acfa8170
Join with_items for the apt module, yum pending, and various fixes to the yum module to support aliases
2012-08-01 20:33:13 -04:00
Michael DeHaan
ed14312ad6
reinstate invalid argument checks where possible, daisy chainee/chained modules turn it off
2012-08-01 19:42:31 -04:00
Michael DeHaan
77029a4227
Merge pull request #752 from go2sh/apt-patch
...
Enable apt module to handle multiply packages (comma separated)
2012-08-01 16:27:29 -07:00
Stephen Fromm
abe8d8d4d6
Return extra information from service module
...
If _do_enable() is run and returns rc == 0, set changed=True
Add enabled and state to result if they are supplied when the module is
run.
2012-08-01 14:58:32 -07:00
Stephen Fromm
42ad1c879f
Fix service module for issue 755 and another bug
...
Allow use of service module with just enable parameter, per issue #755 .
Also fixed two other issues:
- fixed parameter to be 'enabled' per docs, not 'enable'.
- fixed if block that checks whether to run _do_enable() to check
whether the parameter is set, not the value of the enable value which
may be None or False. If enabled=no, the service would never be
disabled.
2012-08-01 14:44:26 -07:00
Christoph Seitz
6baaea90ae
Tweaked error massages.
2012-08-01 18:45:32 +02:00
Christoph Seitz
b973910283
Some optimizations to previous code.
2012-08-01 18:43:39 +02:00
Christoph Seitz
418445d3c5
Enable apt module to handle multiply packages (comma separated)
2012-08-01 18:09:30 +02:00
Jan-Piet Mens
31c0e523c2
Fix exeptions, replace 'as' by ',' as reported on IRC for Python 2.4.3 on Centos5
2012-08-01 15:30:16 +02:00
Michael DeHaan
0a3ebdb6d5
Module consistency and make daisy chaining work with invalid arguments detection.
2012-08-01 00:22:02 -04:00
Michael DeHaan
8700de964c
Teach the common module code to warn users about typo'd arguments and also set everything to None automatically such
...
that code doesn't have to do a lot of params.get('foo', None) everywhere.
2012-07-31 21:23:34 -04:00
Lorin Hochstein
9bcc18d17b
Apt module: add update-cache as alias of update_cache
...
This will ensure users of previous versions of this module don't
have their playbooks break.
2012-07-31 09:56:36 -04:00
Michael DeHaan
d79900b434
Merge pull request #732 from willthames/fix_git_fail_json
...
Fixes for git module when it fails.
2012-07-31 05:04:47 -07:00
Michael DeHaan
89ef236e9c
Merge pull request #733 from willthames/copy_to_directory
...
Allow copy dest argument to be a directory
2012-07-31 05:03:50 -07:00
Michael DeHaan
a8d13fe40d
Merge pull request #735 from nix85/fix_ohai_mod
...
Changed funtion name to get_ohai_data
2012-07-31 05:02:44 -07:00
Petros Moisiadis
24c1d32120
added extra arguments for database creation
...
mysql_db: added 'encoding' and 'collation' args
postgresql_db: added 'owner', 'template' and 'encoding' args
2012-07-31 12:56:29 +03:00
Nikhil Singh
526a0b1f60
Changed funtion name to get_ohai_data
2012-07-31 13:07:53 +05:30
u348095
3cb51acd78
Allow copy dest argument to be a directory
...
Could have used shutil.copy rather than shutil.copyfile, but this
implementation preserves the md5 comparison to avoid unnecessary copies
2012-07-31 14:47:01 +10:00
u348095
e863ba0cec
Fixes for git module when it fails.
...
* module.fail_json *must* have msg argument
Using http://github.com/ rather than git://github.com/ as it gets through more
firewalls
2012-07-31 12:59:22 +10:00
Michael DeHaan
ce5f3dd148
Port the file module over to the new common code infrastructure + cleanup some redundant imports since the module code already imports those things.
2012-07-30 21:50:32 -04:00
Michael DeHaan
d0f6410326
Porting the virt module to new module core.
2012-07-30 21:16:29 -04:00
Michael DeHaan
6b72804cb4
remove unneeded imports
2012-07-28 17:15:07 -04:00
Michael DeHaan
d0a5dec686
Port setup module to use the common module base
2012-07-28 17:14:23 -04:00
Michael DeHaan
d79ba6f2aa
Port the ohai module over, while this is actually *longer* now, not transferring the args file makes this much
...
faster.
2012-07-28 17:07:55 -04:00
Michael DeHaan
5fd2018117
Convert authorized_key modules to use new common code + misc style things
2012-07-28 17:03:10 -04:00
Michael DeHaan
63459110c4
Merge pull request #730 from marktheunissen/mysql_change_params
...
Changing the parameter names to be consistent, and adding root user
2012-07-30 15:50:40 -07:00
Mark Theunissen
9a1265b856
Changing the parameter names to be consistent, and adding root user default with empty password, as per mysql standard
2012-07-30 17:15:24 -05:00
Michael DeHaan
47cead3603
Merge pull request #727 from sfromm/git
...
Git module ported to use module magic
2012-07-30 13:40:36 -07:00