Commit graph

24923 commits

Author SHA1 Message Date
Zim Kalinowski
756ad176cc fixed crash in facts (#50120) 2018-12-18 22:01:45 -05:00
Wojciech Wypior
f761cc4077 added ASM policy server technology module (#50116)
* added ASM policy server technology module

* Update bigip_asm_policy_server_technology.py
2018-12-18 18:38:19 -08:00
Toshio Kuratomi
bd072fe83a
Make the timeout decorator raise an exception out of the function's scope (#49921)
* Revert "allow caller to deal with timeout (#49449)"

This reverts commit 63279823a7.

Flawed on many levels

* Adds poor API to a public function
* Papers over the fact that the public function is doing something bad
  by catching exceptions it cannot handle in the first place
* Papers over the real cause of the issue which is a bug in the timeout
  decorator
* Doesn't reraise properly
* Catches the wrong exception

Fixes #49824
Fixes #49817

* Make the timeout decorator properly raise an exception outside of the function's scope

signal handlers which raise exceptions will never work well because the
exception can be raised anywhere in the called code.  This leads to
exception race conditions where the exceptions could end up being
hanlded by unintended pieces of the called code.

The timeout decorator was using just that idiom.  It was especially bad
because the decorator syntactically occurs outside of the called code
but because of the signal handler, the exception was being raised inside
of the called code.

This change uses a thread instead of a signal to manage the timeout in
parallel to the execution of the decorated function.  Since raising of
the exception happens inside of the decorator, now, instead of inside of
a signal handler, the timeout exception is raised from outside of the
called code as expected which makes reasoning about where exceptions are
to be expected intuitive again.

Fixes #43884

* Add a common case test.

Adding an integration test driven from our unittests.  Most of the time
we'll timeout in run_command which is running things in a subprocess.
Create a test for that specific case in case anything funky comes up
between threading and execve.

* Don't use OSError-based TimeoutError as a base class

Unlike most standard exceptions, OSError has a specific parameter list
with specific meanings.  Instead follow the example of other stdlib
functions, concurrent.futures and multiprocessing and define a separate
TimeoutException.

* Add comment and docstring to point out that this is not hte Python3 TimeoutError
2018-12-18 18:01:46 -08:00
Tom Dietrich
2b48c0187c Warn of standard behavior of 'default' key store (#49903)
* Warn of standard behavior of 'default' key store 

The default key store typically results in the key being stored as user. In instances where we're trying to install a cert to enable SSL binding in IIS, this will result in an unbind-able cert, as the IIS APPPOOL identity will not be able to read the private key, and presents a very cryptic error of 'A specified logon session does not exist'.


+label: docsite_pr

* fix trailing whitespace

* Use C(user) reference

* specify what's required for successful iis import

- store_location's default value is currently 'LocalMachine' but if this changes it could result in the documentation being inaccurate
- key_exportable is not required for a successful IIS import

* remove stray =

dang cat

Co-Authored-By: tdietrich513 <tom.dietrich@gmail.com>
2018-12-19 11:13:31 +10:00
Toshio Kuratomi
947c4300ee Fix return types
We're now stricter on naming the return types.  Replace string with str.
2018-12-18 15:14:08 -08:00
Dag Wieers
05c6ff79f9 Convert to reduced list of known types (#50010) 2018-12-19 07:25:30 +10:00
Toshio Kuratomi
fcd1486b51 VALID_ACTIONS for cli subcommands will now be a frozenset (#50058) 2018-12-19 07:03:22 +10:00
Martin Krizek
545edc9114 facts: detect FreeBSD KVM guests (#50030)
Fixes: #49158
2018-12-19 06:57:53 +10:00
Martin Krizek
29c3bb48e9 facts: correctly detect multiple ipv6 addresses per device (#50020)
Fixes #49473
2018-12-19 06:49:28 +10:00
Yannig Perré
6b41588e93 Fix with_ini example and unittest
* Fix example in ini.py
* Fix unittest in test_ini.py to pass CI as latest ansible returns list in
  different order. To prevent such issues in future results are sorted
* PEP8 E501 styling improvements

Co-Authored-By: Sergii Golovatiuk <sgolovat@redhat.com>
2018-12-18 12:25:02 -08:00
Abhijeet Kasurde
1e4ab5a038 Return correct error message to user
botocore.exceptions.ClientError does not have message, which
fails fail_json.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-18 12:23:18 -08:00
Abhijeet Kasurde
44bd8fc0a8 Update unit tests for configmanager
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-18 12:20:35 -08:00
Jordan Borean
efda3eaf1c
win_lineinfile - fix malformed returned json (#50066) 2018-12-19 05:39:25 +10:00
Michaël de Groot
13f2b29305 Small documentation update: Clarify daemon-reload always executing. (#49889)
* Small documentation update
* shortens and clarifies line
2018-12-18 12:22:57 -06:00
Michael Scherer
2734895c48 Do switch to apt if aptitude is not installed (#30738)
Trying to use the apt module on a freshly install 16.04 Ubuntu VM with
"ansible -m apt -a 'name=* state=latest' all" fail with this backtrace:

  Traceback (most recent call last):
    File \"/tmp/ansible_2inxygge/ansible_module_apt.py\", line 1055, in <module>
      main()
    File \"/tmp/ansible_2inxygge/ansible_module_apt.py\", line 998, in main
      upgrade(module, 'yes', force_yes, p['default_release'], use_apt_get, dpkg_options)
    File \"/tmp/ansible_2inxygge/ansible_module_apt.py\", line 759, in upgrade
      apt_cmd_path = m.get_bin_path(apt_cmd, required=True)
    File \"/tmp/ansible_2inxygge/ansible_modlib.zip/ansible/module_utils/basic.py\", line 2182, in get_bin_path
    File \"/usr/lib/python3.5/posixpath.py\", line 89, in join
      genericpath._check_arg_types('join', a, *p)
    File \"/usr/lib/python3.5/genericpath.py\", line 143, in _check_arg_types
      (funcname, s.__class__.__name__)) from None
    TypeError: join() argument must be str or bytes, not 'NoneType'

It seems that since aptitude is not installed on Xenial, so APTITUDE_CMD is None
and we later hit the bug in the upgrade function since it assume APTITUDE_CMD
is set.
2018-12-18 12:48:11 -05:00
Dag Wieers
ee29ba5d4f plugin_formatter.py: Improve the output when processing docs (#46541)
* Improve the output when processing files

* Update docs/bin/plugin_formatter.py

Co-Authored-By: dagwieers <dag@wieers.com>

* Show progress indicator.

* Don't pp.pformat() huge structures when they aren't used anyway.

This saves ~10 seconds on my machine.

* Only show ASCII spinner if stdout is a TTY.

* Fix: E722 do not use bare 'except'
2018-12-18 11:23:49 -06:00
Toshio Kuratomi
40144c7486 Remove dead code in ansible-inventory
This piece of code is only needed with ansible < 2.3.x (which is now EOL)
2018-12-18 08:58:38 -08:00
Brian Coca
88c87a3583
added handlers_from (#49220)
* added handlers_from

fixes #46769
2018-12-18 11:28:24 -05:00
Xander Madsen
1e415899ad GetManagerNicInventory (#49961)
* Add GetManagerNicInventory command for Manager category, and tweak redfish_utils' get_nic_inventory to accommodate manager nic interfaces

* Remove get_manager_nic_inventory, since it is unnecessary while using get_manager in get_nic_inventory

* Rework get_nic_inventory() to take a resource_type as a string, which will be just the category parameter from redfish_facts, making it clearer

* remove extraneous blank line to conform with pep8

* Add GetManagerNicInventory example task to EXAMPLES docstring
2018-12-18 09:58:17 -06:00
Dag Wieers
15d39f9108 Sanity fixes in various modules (#50080) 2018-12-18 09:53:46 -06:00
Nathaniel Case
6caed0c38b
ios retry config if section filter fails (#49485)
* Attempt to work around devices that don't understand | section

* Fix case of no flags
2018-12-18 10:34:32 -05:00
rajaspachipulusu17
d28e700a22 Pluribus networks admin session timeout module with unit tests (#50012)
* Pluribus networks admin session timeout module with unit tests
* Doc fix
* Removed unused imports
* Removed unwanted global variable
2018-12-18 17:23:45 +05:30
Christian Kotte
f123f894df Improve module vmware_local_role_manager (#47870)
* add check mode support
* improve output
2018-12-18 17:10:10 +05:30
Christian Kotte
e65b721283 VMware: new module vmware_host_ad_auth (#47901) 2018-12-18 16:34:11 +05:30
Ondra Machacek
e733d6e557 Fix activate of the disks in ovirt_vm and ovirt_disk modules (#49762)
* ovirt_disk: Add activate parameter

* ovirt_vm: Fix waiting on lun disks

Signed-off-by: Ondra Machacek <omachace@redhat.com>
2018-12-18 05:54:27 -05:00
Christian Kotte
f431e5b0e2 VMware: new module vmware_dvswitch_uplink_pg (#48846) 2018-12-18 16:14:18 +05:30
Felix Fontein
92ef500185 openssl_privatekey: add ECC support (#49416)
* Add cryptography backend for openssl_privatekey.

* Adding ECC support.

No support for X25519 and X449, since they don't support serialization.

* Improve finterprint calculation to work with Python 3.

* Add fingerprint check.

* Fix typo.

* Use separate curve option for elliptic curves, and use type 'ECC'.

* Using curve names as defined in IANA registry.

* Bump minimal supported cryptography version. Older versions might work as well, but I couldn't test them.

* Improve documentation.
2018-12-18 09:07:36 +00:00
Zim Kalinowski
6d952e4124 fixing vm state change when vm created with attached disk (#50071)
* fixing vm state change when vm created with attached disk

* minor fixes

* fixing hanging indent
2018-12-18 03:49:31 -05:00
Dag Wieers
c1ac87794e
ACI: Fix module parameters (#50051)
* Fix parameter type of private_key

* Fix parameters of various ACI modules
2018-12-18 09:30:28 +01:00
rajaspachipulusu17
cf00880ab3 Pluribus Networks dscp map module with unit tests (#49849)
* Pluribus Networks dscp map module with unit tests
* Doc string fix
2018-12-18 12:50:16 +05:30
rajaspachipulusu17
4d88cdd83a Pluribus Networks cpu class module with unit tests (#49847)
* Pluribus Networks cpu class module with unit tests
* Doc string fixes
2018-12-18 12:42:33 +05:30
Ganesh Nalawade
3163780829
Add force_host and issu options support in junos_package module (#50018)
Fixes #48171
Fixes #33742

Add force_host and issu options support in junos_package module
*  Add force_host option to ignore warnings while installing package
*  Add issu option to enable issu feature from Ansible
2018-12-18 10:51:29 +05:30
Dag Wieers
5739ccb6c3 PSRP: Add support for reconnection retries (#49772)
* PSRP: Add support for reconnection retries

This adds support for reconnection retries to overcome sudden Connection
Refused or other recoverable states. (Either because WinRM is (re)started,
or firewall changes make it briefly unavailable)

* Fixes from review comments
2018-12-18 08:20:53 +10:00
Dag Wieers
244c4c893d Add types to files fragment (#49996) 2018-12-17 17:16:35 -05:00
Gregory Storme
f461025dbb fix facts memtotal_mb rounding on VMWare and swaptotal_mb conversion from KB to MB (#49940) 2018-12-18 08:09:19 +10:00
Jérémy Lecour
2fb9b46752 Lineinfile must not insert lines multiples times with insertbefore/insertafter (#49409)
* Change test suite to fit expected behaviour

This reverts some changes from ansible/ansible@723daf3
If a line is found in the file, exactly or via regexp matching, it must 
not be added again.
insertafter/insertbefore options are used only when a line is to be 
inserted, to specify where it must be added.

* Implement the change in behaviour mentioned in the previous commit

* Fix comment to reflect what the code does

* Set the correct return message.

In these cases, the lines are added, not replaced.

* Add a changelog
2018-12-17 16:42:24 -05:00
Matt Martz
7eb1ab45a7
Allow tags to be templated from a variable (#49833)
* Allow tags to be templated from a variable. Fixes #49825

* Restore _load_tags to ensure we do csv tag splitting

* Add tests for csv tags and templated tags

* evaluate_tags doesn't need to accept strings, because _load_tags handles this
2018-12-17 15:40:26 -06:00
Matt Martz
a0d71e7735
Fix reverse_inventory order to work on python3 (#49895) 2018-12-17 15:39:29 -06:00
Aleksander Kovtunenko
ba562043e1 changed if logic Type to boolean (#49628)
* changed Type to boolean

* fix after review

* created fragment
2018-12-17 16:21:36 -05:00
Dag Wieers
a8292778f0 Fix GitHub handle, use keachi (#50043)
* Fix GitHub handle, use keachi

* Add UTF8 name
2018-12-17 19:35:49 +00:00
Toshio Kuratomi
61b1daa65f Port from plaform.dist to ansible.module_utils.distro.linux_distribution
ci_complete
2018-12-17 11:01:01 -08:00
Adrian Likins
78a8d09082 Changes to bundled distro to be Python-2.6 compatible
* Port bundled distro to use optparse instead of argparse (py2.6)
* Use an absolute import to satisfy the current import testing harness
* Port from subprocess.check_output to subprocess.Popen.communicate() (py2.6)
* Add license location

The changes have been proposed upstream here:
https://github.com/nir0s/distro/pull/232

Upstream is contemplating a branch where everyone wanting python-2.6
support can collaborate without it becoming part of the regularly
supported releases.
2018-12-17 11:01:01 -08:00
Adrian Likins
5e1f8a48f3 Bundle a copy of github.com/nir0s/distro/distro.py
Since the 'platform.dist()' and 'platform.linux_distribution()'
methods will be removed from future versions of python, this
provides an alternative to replace ansibles use of those
methods.

lib/ansible/module_utils/distro.py is a copy of
https://github.com/nir0s/distro/blob/master/distro.py

This module is originally from https://github.com/nir0s/distro
and is license under the Apache License, Version 2.0.
2018-12-17 11:01:01 -08:00
Nathaniel Case
bf4ad56479
Move errors from import to connect (#50034) 2018-12-17 12:33:44 -05:00
Dag Wieers
d4ee599fe9 Add types to common url parameters (#50000) 2018-12-17 11:26:07 -06:00
Dag Wieers
00a83035f2 Meraki: Add types to common parameters (#49998) 2018-12-17 11:24:43 -06:00
Dag Wieers
0eb2924380 MSC: Add type to common module parameters (#49999) 2018-12-17 11:23:51 -06:00
Dag Wieers
e8885ee4e8 ACI: Add types to modules and doc fragment (#49997)
* ACI: Add types to module doc fragment

* Add types to ACI modules too
2018-12-17 11:23:10 -06:00
Dag Wieers
b3f062b5ca Clean up backup doc fragment (#49995) 2018-12-17 10:41:43 -06:00
Dag Wieers
3bcc0c0498 Add types to vmware REST client/VCA doc fragments (#50001) 2018-12-17 10:33:40 -06:00
Dag Wieers
653c3da500 Fix document references in modules (#49892)
* Docs: Fixes internal module reference syntax for seealso
* Updates anchors and links
* Updates seealso in the docs for module **win_chocolatey**.
2018-12-17 10:20:06 -06:00
Martin Nečas
651ea5da44 add to ovirt snapshot download and upload disk (#46696)
* add to ovirt snapshot download and upload disk

* ovirt snapshot update docs

* ovirt snapshot add version_added to docs

* update ovirt snapshot docs
2018-12-17 10:56:27 -05:00
Johannes Brunswicker
87ee59b8d7 Sophos UTM - add module to handle utm ca host key certificate entries (#48927)
* - add module to handle utm ca host key certificate entries

* - fixed typos in doc

* Apply suggestions from code review

Co-Authored-By: MatrixCrawler <johannes.brunswicker@gmail.com>
2018-12-17 11:57:54 +00:00
Andrey Klychkov
b5ca54eeed New module - postgresql_idx (#49684)
* New module - postgresql_idx

* New module postgresql_idx: added returns block

* New module postgresql_idx: fixed documentation, typos and added idxname to fail_json
2018-12-17 11:56:33 +00:00
Dag Wieers
ba573777ba Add types to docker module fragments (#50002) 2018-12-17 11:55:31 +00:00
Deepak Agrawal
0f2f38b044
network_cli - ansible_command_timeout not working as expected (#49922)
* fix for command_timeout

Signed-off-by: Deepak Agrawal <deepacks@gmail.com>

* fix ci warning

Signed-off-by: Deepak Agrawal <deepacks@gmail.com>

* fix review comments

Signed-off-by: Deepak Agrawal <deepacks@gmail.com>
2018-12-17 13:26:23 +05:30
f-bor
134c1a624e new network module: edgeswitch_vlan (#48041)
* initial commit

* better commands generation
2018-12-17 11:30:17 +05:30
anasbadaha
1580afbd62 Fixes #46410 Onyx show facts module does not work for onyx version 3.6.6000 and higher (#49414)
Signed-off-by: Anas Badaha <anasb@mellanox.com>
2018-12-17 10:53:54 +05:30
anasbadaha
369354547e Issue: 46475 Fix onyx magp module for supporting new json format (#49417)
Signed-off-by: Anas Badaha <anasb@mellanox.com>
2018-12-17 10:52:51 +05:30
Zim Kalinowski
de3d188cdd
support lro in azure_rm_resource (#49919) 2018-12-17 13:21:25 +08:00
Toshio Kuratomi
175f3b51e5 Ensure that current uses of BaseException are required
* In some cases, it appears that Exception should have been used instead
  as there's no need to catch sys.exit KeyboardInterrupt and similar.
* In a few cases, it appears that BaseException is used because
  a library we depend on calls sys.exit() contrary to good coding
  design.  Comment those so that we know that those have been audited
  and found to be correct and change to use (Exception, SystemExit)
  instead.
2018-12-16 15:03:19 -08:00
Toshio Kuratomi
3fba006207 Update bare exceptions to specify Exception.
This will keep us from accidentally catching program-exiting exceptions
like KeyboardInterupt and SystemExit.
2018-12-16 15:03:19 -08:00
Felix Fontein
65d5f1a4ef Fix stacktrace when fail_on_error is False and a file cannot be parsed. (#49987) 2018-12-16 15:26:29 -05:00
anasbadaha
c0dbc1a441 Issue/38837 (#49873)
* Fix Issue #38837

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Issue #38837 2

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Enhance decumentation

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Failures in Shippable

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Version Added

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Add version_added:2.8 in purge attributes

Signed-off-by: Anas Badaha <anasb@mellanox.com>
2018-12-16 13:16:28 +05:30
Abhijeet Kasurde
1558f77081
AWS: make jittered_backoff API parameter configurable (#49086)
* AWS: make jittered_backoff API parameter configurable
* Review comments
* minor doc changes

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-16 11:07:59 +05:30
Abhijeet Kasurde
162d9497ba
Ad-hoc command: fix 'any' call in play_ds (#49852)
* Ad-hoc command: fix 'any' call in play_ds
* Unit test for ad-hoc cli
* Review comments

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-16 11:07:06 +05:30
Abhijeet Kasurde
ef3b75afcd
fortimanager: Correct example documentation (#49925)
Fixes: #49813

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-15 12:10:32 +05:30
Dag Wieers
26474c6902
Add seealso section to Windows and related modules (#49845)
* Add seealso section to Windows and related modules

* Fixes after review
2018-12-15 03:23:59 +01:00
Adam Miller
0eabb8097b
Fix yum/dnf handling of URIs that don't end in .rpm (#49912)
Fixes #49727

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-12-14 13:44:40 -06:00
Dave Bendit
d62d7176b0 [docker_container] Failing on non-string env values (#49843)
* [docker_container] Failing on non-string env values

Fixes #49802

* Clarify failure message

Co-Authored-By: DBendit <David@ibendit.com>

* Fixup from review
2018-12-14 13:21:54 -06:00
Dave Bendit
c67f4290e6 [docker_volume] Checking option minimal versions (#49839)
Fixes #38833
2018-12-14 13:20:48 -06:00
Akshay Gaikwad
1e0363ec7d Support for cache_from parameter in docker_image module (#49787)
* Support for cache_from parameter in docker_image module

Fixes #21704

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Minimum docker version check for cache_from option

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Add changelog fragment

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* cache_from fix when docker-py is older

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
2018-12-14 13:19:40 -06:00
Chad Anderson
6ff7797eaa Move verify up so approle and other methods work as intended. 2018-12-14 11:14:12 -08:00
Giuseppe Mancuso
d29f647f09 issue with activation_key and proxy on subscription-manager (#42624)
* Update redhat_subscription.py

I need to use a proxy server/user/password also if I user an activation_key

* remove spaces
2018-12-14 12:27:58 -05:00
Petr Ruzicka
1c8f5c7db5 with_items should not be used any more - using loop instead (#47364) 2018-12-14 12:13:32 -05:00
Petr Ruzicka
0957b37721 with_items should not be used any more - using loop instead (#47652) 2018-12-14 11:17:21 -05:00
Abhijeet Kasurde
013c42b14f
Misc typo fixes (#49816)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-14 15:12:58 +05:30
Yuwei Zhou
7609a8cdd6 support overprovision in azure_rm_vmss (#49806) 2018-12-14 16:48:40 +08:00
Deepak Agrawal
f2eef2d30b
ignore connection timeout out within parenthesis (#48413) 2018-12-14 11:22:10 +05:30
anasbadaha
fb8b59fcc6 Get Capabilities Support (#49880)
Signed-off-by: Anas Badaha <anasb@mellanox.com>
2018-12-14 09:45:31 +05:30
Jordan Borean
4019d4f6d1
Windows Privileges - moved util code to it's own C# util (#48897)
* Windows Privileges - moved util code to it's own C# util

* Rename Enabler class to PrivilegeEnabler to remove ambiguity

* rename Utils to PrivilegeUtil

* fix missing util name changes
2018-12-14 12:00:46 +10:00
Loïc Blot
c97d2c25b4 postgresql_schema: permit to drop cascade schema (#49469)
* postgresql_schema: permit to drop cascade schema

* Doc fix

* typo fix
2018-12-13 19:03:48 -05:00
Dag Wieers
a4998cfead
ACI: Add seealso fragments to module documentation (#49844) 2018-12-13 19:40:53 +01:00
Dag Wieers
994ce2126a win_updates Add information/example wrt. reboots (#49834)
This documents two common issues related to rebooting Windows systems.
- Updates can take a long time being applied during reboot
- Reboots can cause the WinRM service to start before system has settled
2018-12-13 09:38:11 -06:00
Trishna Guha
e944dba166
add host key as alias for sysname neighbors facts (#49827)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-12-13 18:11:14 +05:30
Jordan Borean
2adb9f32ae
Revert "replace math round with ceiling for ansible_memtotal_mb + add new variables to display swapfile config (#49611)" (#49876)
This reverts commit b3ac5b637a.
2018-12-13 21:33:55 +10:00
Greg Hellings
af5d84b70b Properly report install failures from dnf module (#49760)
Reporting of install failures was improperly guarded behind a list of
packages to install when the first element changed in a list was found.
This lead to the dnf module silently failing at times when it should not
fail.

Fixes issue 49759
2018-12-13 05:22:53 -05:00
FragmentedPacket
69988cfca0 Netbox Module: netbox_ip_address (#48424)
* Tested netbox_ip_address with several conditions and working as intended
2018-12-13 09:40:15 +00:00
Susant Sahani
59dcf3f277 nmcli: Introduce SIT Tunnel (#45937)
This work enables to add sit tunnel via nmcli module

Signed-off-by: Susant Sahani susant@redhat.com

SUMMARY
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
nmcli

ANSIBLE VERSION
2.8
ADDITIONAL INFORMATION
  - nmcli:
       state: present
       type: sit
       conn_name: sit_test1
       autoconnect: yes
       ip_tunnel_dev: enp0s8
       ip_tunnel_local: 192.168.1.2
       ip_tunnel_remote: 192.168.1.5
2018-12-12 23:06:09 -05:00
Jordan Borean
190d1ed7f1 win become: refactor and add support for passwordless become (#48082)
* win become: refactor and add support for passwordless become

* make tests more stable

* fix up dep message for Load-CommandUtils

* Add further check for System impersonation token

* re-add support for become with accounts that have no password

* doc fixes and slight code improvements

* fix doc sanity issue
2018-12-12 17:15:25 -08:00
Gregory Storme
b3ac5b637a replace math round with ceiling for ansible_memtotal_mb + add new variables to display swapfile config (#49611)
* replace math round with ceiling to report the actually installed RAM for ansible_memtotal_mb

* add new variable ansible_memtotal to display TotalPhysicalMemory in bytes
add new variable ansible_swap_min to display initial pagefile size
add new variable ansible_swap_max to display maximum pagefile size
removed the variable ansible_swaptotal_mb

* output ansible_swap_min & ansible_swap_max value in bytes

* re-add the ansible_swaptotal_mb fact and fix the conversion of the TotalSwapSpaceSize value from kilobytes to MB

* indentation fix, replace tab with spaces
2018-12-13 09:44:40 +10:00
rhydian76
18503e7ed6 Create Windows facts for ansible_virtualization_role and ansible_virt… (#49775)
* Create Windows facts for ansible_virtualization_role and ansible_virtualization_type

* Create Windows facts for ansible_virtualization_role and ansible_virtualization_type
Updated formatting

* Removed executable flag on setup.ps1

* Changed Get-WMIObject to Get-CimInstance as Get-WMIObject has been deprecated and fails testing.

* Changed new variables to snake_case and also changed Get-CimInstance to Get-LazyCimInstance

* removed -class from Get-LazyCimInstance call as failed test.
2018-12-13 09:40:13 +10:00
s-hertel
bf065e853f Lowercase task name and format variable with spaces 2018-12-12 17:05:55 -05:00
ipvsean
2a67ff1a75 adding example for route53_facts using start_record_name
this example shows two things not shown here already->
- dynamically looking up hosted zone id using the route53_zone module (vs knowing the ID we can use the name)
- showing an example of start_record_name which takes an entire record, not just a partial name
2018-12-12 17:05:55 -05:00
Dag Wieers
baf0ad2309 Docs: Add a "seealso" section to the module docs (#45949)
* Docs: Add a separate  "seealso" section to the module docs
to list related modules and/or related references. This clears up the notes
section for things that are actual notes.

So you can add a section in your module documentation and four types of
references are possible.

    seealso:

    # Reference by module name
    - module: aci_tenant

    # Reference by module name, including description
    - module: aci_tenant
      description: ACI module to create tenants on a Cisco ACI fabric.

    # Reference by rST documentation anchor
    - ref: aci_guide
      description: Detailed information on how to manage your ACI infrastructure using Ansible.

    # Reference by Internet resource
    - name: APIC Management Information Model reference
      description: Complete reference of the APIC object model.
      link: https://developer.cisco.com/docs/apic-mim-ref/

This PR also includes:

- Implements ansible-doc support
- Implements schema support for the seealso options
- Updates to the development documentation
- Rename filter convert_symbols_to_format to rst_ify, cfr the existing html_ify and tty_ify filters
  - This makes the existing template a lot easier to read and fixes the confusion I had myself rereading the template (again).
- We fixed the possible suboption types (which was limited to 'bool' only)

* Use latest stable instead of devel docs
2018-12-12 14:19:58 -06:00
Rene Bakkum
6b09e99664 Fix example with spacing error in hostname (#49812)
fix na_ontap_command module examples
2018-12-12 14:15:00 -06:00
Adam Furbee
2dc36bf842 added support for icmp-blocks and icmp-block-inversion (#45705) 2018-12-12 15:01:35 -05:00
Richlv
46d2a3eddc Update rhsm_repository.py (#49480)
typo fixes
2018-12-12 13:37:11 -06:00
cma0
974c45a5f5 itential iap_token module (#46773) 2018-12-12 14:28:20 -05:00
Michael Rose
b422c59ada Amends #47040 - influxdb_user - Prevents potential accidental password changes to blank (#49084)
* Amends #47040 - Prevents potential accidental password changes to blank

* Added changelog fragment
2018-12-12 12:43:37 -05:00
Johann Queuniet
b079070688 Fix grafana_dashboard py2/3 compatibility (#49194)
* Fix grafana_dashboard py2 compatibility

* Convert URL output to a text/unicode string for json.loads
2018-12-12 12:42:55 -05:00
Chris Archibald
920be06670 Fixes #49248 (#49384)
* Fixes #49248

* fix
2018-12-12 12:42:08 -05:00
Pierre-Louis Bonicoli
7e278b23b4 inventory plugin order: update doc
add doc for #44428:
- add changelog fragment
- update porting guide
also:
- update auto inventory plugin doc
- mention toml plugin in examples
2018-12-12 09:35:13 -08:00
Chandra Shekar Rangavajjula
2f8001a7af Fixes 36950. Added support for missing options capabilities and root_device in properties of os_ironic.py ansible module (#37113)
* Fix for 36950. Added support for missing options capabilities and root_device in properties of os_ironic.py ansible module

* Updated docstring to pass documentation validation

* Updated review comments from juliakreger

* version_added: "2.8"
2018-12-12 17:07:44 +00:00
Nilashish Chakraborty
d729614d72
Add support for hashed password (#49464)
* Add support for hashed password

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix Shippable errors

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Make pwd options mutually exclusive

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2018-12-12 22:22:15 +05:30
WhyIsThisOpen
7bdca72713 rhn_register fixes for username and password when unregistering
- Require username and password for unregistering and avoid "cannot marshal None unless allow_none is enabled" error when using an activation key and no channels specified.
- Update test fixtures and add changelog


Co-authored-by: WhyIsThisOpen <WhyIsThisOpen@users.noreply.github.com>
2018-12-12 11:32:48 -05:00
Mariusz Mazur
d8a690952e k8s_service: add new kubernetes module for handling Services (#48872)
* k8s: add k8s_kind arg to KubernetesRawModule

Single–kind k8s modules (e.g. k8s_service) do not have a module
parameter called 'kind' and need to pass a static 'kind' on
KubernetesRawModule class creation. Hence this change.

* k8s: make 'validate' and 'wait' mod params optional

Not all k8s modules utilizing KubernetesRawModule will use these.

* k8s_service: new k8s module for handling Services
2018-12-12 11:18:36 -05:00
Mike Wiebe
0e4a7b0889 Fix nxos_reload timeout and add integration tests (#49632)
* Fix timeout and add tests

* Correct module name
2018-12-12 10:32:27 -05:00
rajaspachipulusu17
b47cde9d4c Pluribus Networks pn access list ip module with unit test cases (#49604)
* Pluribus Networks pn access list ip module with unit test cases

* Changes according to ansibot standards in unit test modules

* Remove unwanted variables

* Removed unwanted super call
2018-12-12 13:33:01 +00:00
Chris Archibald
8ad5035ce6 Bug Fix and rewrite (#49508) 2018-12-12 12:16:12 +00:00
Piotr Olczak
d08604eebc Fixes 45136 and 47641: (#47642)
- each volume in the volume_info should be identified by VOLUME_NAME:OWNING_VSERVER:AGGREGATE
- do not fail if external key management is enabled
2018-12-12 06:47:19 -05:00
Ondra Machacek
9d965906bd ovirt: Return also nested attributes of structs (#49239)
Previously we returned only nested attributes of the lists not of the
structs, this patch fixes it.

Signed-off-by: Ondra Machacek <omachace@redhat.com>
2018-12-12 05:39:31 -05:00
Christian Kotte
1b9b0b85c4 new module vmware_dvswitch_pvlans (#48855) 2018-12-12 09:13:54 +00:00
Dave Bendit
b67719ba1d Docker common consolidation (#49707)
* [docker] Consolidating Python Boolean conversion for Docker API (#49563)

* [docker] Consolidating docker option min version checks (#49564)

* [docker] Moving option min version checks out of docker_swarm (#49564)

Also renaming Boolean cleanup function and fixing docker_container minimum
version check for network interfaces.

* Cleanup from PR feedback
2018-12-12 09:05:12 +00:00
Dave Bendit
8fcf9e1a28 [docker_container] Fixes idempotency checks for network_mode (#49797)
Fixes #49794
2018-12-12 09:04:24 +00:00
Abhijeet Kasurde
d36922064b Add support for hex color in slack module (#49804)
Fixes: #11935

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-12 08:41:49 +00:00
Andrea Scarpino
06099bd116 win_uri: fix body with one item in list (#49484) 2018-12-12 14:06:54 +10:00
Zim Kalinowski
a24cc8b235 fixing updating image reference in vmss (#49758) 2018-12-12 11:01:21 +08:00
Brian Coca
daaca1abd5
fix vbox inventory to correclty unset pwfile (#49774) 2018-12-11 17:45:25 -05:00
Nathaniel Case
02432565cd
Remove cliconf from httpapi connection (#46813)
* Bare minimum rip out cliconf

* nxapi changeover

* Update documentation, move options

* Memoize device_info

* Gratuitous rename to underscore use of local api implementation

Fixup eos module_utils like nxos

* Streamline version and image scans

* Expose get_capabilities through module_utils

* Add load_config to module_utils

* Support rpcs using both args and kwargs

* Add get_config for nxos

* Add get_diff

* module context, pulled from nxapi

We could probably do this correctly later

* Fix eos issues

* Limit connection._sub_plugin to only one plugin
2018-12-11 16:26:59 -05:00
Josue David Hernandez
9202ef60b0 set ansible_os_family from name variable in os-release for clearlinux OS (#49639)
* set ansible_os_family from name variable in os-release for clearlinux system

Signed-off-by: Josue David Hernandez Gutierrez <josue.d.hernandez.gutierrez@intel.com>

* Add os_family for clear linux and clear linux mixes

Signed-off-by: Josue David Hernandez Gutierrez <josue.d.hernandez.gutierrez@intel.com>
2018-12-11 16:12:38 -05:00
David Lassalle
935fa51143 Fix spelling error in Display.banner description (#49790)
wit h -> with
2018-12-11 15:00:15 -06:00
Sam Doran
7c8af3d684 Reboot - Fix VMware ESXi not working by adding appropriate commands (#49637)
* Add commands for VMware ESXi

* Add changelog
2018-12-11 15:30:11 -05:00
Brian Coca
63279823a7
allow caller to deal with timeout (#49449)
* allow caller to deal with timeout

  a start for #43884 and timeout issues in long operations
2018-12-11 15:21:18 -05:00
Pilou
1bad617f29 Inventory plugins move auto before ini (#44428)
* inventory plugins: try auto before ini

auto plugin should run before ini to avoid ini being able to parse
some plugin configuration YAML files successfully.

* Update comment

comment was added by 2ffe3c42bb but
related code was later removed by
506e6a0b2d.
2018-12-11 15:17:05 -05:00
Nathaniel Case
7af405883f
Don't fail on unable to set terminal width on ios (#47290)
* Don't fail if ios can't set terminal width

* Fix display import
2018-12-11 15:09:00 -05:00
Darragh Bailey
4947936176 Remove sleep and switch to pipe for IPC (#28561)
Use a simple multiprocessing pipe to delay exiting the parent process
until after the child has been doubly forked.

Using a simple IPC to allow the forked process to start avoids the
control node waiting unnecessarily for lightly loaded systems.
2018-12-11 14:26:06 -05:00
Sam Doran
c1589c33c4
Reboot - Fix command not found, add Apline support, fix Solaris command (#49272)
* Fix various bugs related in reboot

- Use format strings for consistency and improve debug log messages
- Use local variables instead of class attributes in order to be thread safe
- Run setup module to get distribution and version
- Run find module to get full path of shutdown command
- Use ansible_os_family and ansible_distribution to find commands and args
- Use same command for all Solaris/SunOS distributions
- Move delay calculations to properties
- Reliably check for module run failure
- Fix bug in run_test_command() that accidentally made the method work properly
- Use better exceptions rather than Exception
- Use dict literals rather than constructors
- Correct _check_delay() so it always returns a value, not None
- Don't store and return result in run_test_command() because it's not used anywhere
- add test for post reboot command that fails
- test negative values for delay parameters
2018-12-11 11:05:10 -05:00
Matt Martz
2a469fd959 Consolidate handler tracking (#49338)
* Consolidate handler tracking
  -  Remove unused code. ci_complete
  - unit test fixes. ci_complete
  - Restore previous behavior of matching a single handler
  - when notifying a host for a handler, return True if it was added, False otherwise, to reduce copied logic
  - rename funcitons for clarity. ci_complete
  - Remove handler logic for static includes which was disabled previously
2018-12-11 10:58:19 -05:00
rajeevarakkal
62b2a08cfb Add DellEMC iDRAC Firmware module (#46675)
Co-Authored-By: rajeevarakkal <36444805+rajeevarakkal@users.noreply.github.com>
Co-Authored-By: Sviatoslav Sydorenko <578543+webknjaz@users.noreply.github.com>
2018-12-11 16:38:01 +01:00
Matt Martz
c9040d7579
Don't just raise AnsibleError with the exception message (#49654)
* Don't just raise AnsibleError with the exception message. Fixes #49252

* Add changelog fragment
2018-12-11 09:27:10 -06:00
Brian Coca
8ce4720f44
pear: More info if failure occurs (#49735)
* added cli errors to error msg for pear
2018-12-11 09:38:06 -05:00
Steven Tobias
260512459d stop requiring description. this is not a mandated jira field for all screens (#46023) 2018-12-11 14:24:24 +00:00
Gonéri Le Bouder
e7750768f7 nmcli example: modern way to install packages (#49110)
- use the generic `package` module, this way it will cover dnf and yum
- to not specify the x86_64 arch, the package manager will pull the fine
  version anyway
- with_items with package is deprecated
- libnm-qt-devel is only in Fedora 27 and 28.
2018-12-11 17:37:07 +05:30
Abhijeet Kasurde
e464c543f6
Add support for variable_{start,end}_string (#49711)
Template lookup plugin now support variable_start_string and
variable_end_string, just like template module.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-11 15:22:12 +05:30
Xijun Dai
7186234a84 Fix Unicode-objects must be encoded before hashing (#46608) 2018-12-10 17:09:29 -08:00
Peter Kirby
41a6c1d220 Update rds.py (#49674)
Adds endpoint and port to the instance return values for rds.py.  Partial fix for #37209
2018-12-10 16:47:55 -06:00
Sandra McCann
418c03a686 added dhcp standard options (#49729) 2018-12-10 13:11:42 -06:00
Sandra McCann
62af321909 added jinja2 example (#49740) 2018-12-10 13:10:17 -06:00
Abhijeet Kasurde
be21140384
VMware: update docs and return docs for vmware_host_service_facts (#49736)
Follow up of 45155

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-10 23:57:39 +05:30
Dag Wieers
7b01725bb5 mail: Fix new breakage on python 2.7 (#49197)
* mail: Fix new breakage on python 2.7

* Add changelog fragment

* Add basic SMTP testing

* Add SMTP integration tests using starttls and TLS
2018-12-10 10:25:33 -08:00
Ken Dreyer
eae81e36fd openstack: document RETURNS for os_volume (#49559)
Document the "id" and "volume" return values from the os_volume module.
2018-12-10 11:29:34 -06:00
Brian Coca
758ac1846b
match interpreter on stdout also (#49446)
fixes #46980
2018-12-10 11:43:30 -05:00
Brian Coca
e53a7856f6
simplify vm_guest detection code (#49378)
- remove a lot of repetition
  - change lists to tuples since they are faster to assign
2018-12-10 11:42:51 -05:00
Brian Coca
42a13d15f1
add path info to role list (#49346)
* add path info to role list

 - use same display format for both listing all and specific roles


Co-Authored-By: bcoca <bcoca@users.noreply.github.com>
2018-12-10 11:41:22 -05:00
Brian Coca
0c1f62065c
make adhoc include_role/task work again! (#49247)
* adhoc include_role/task work again!
  - fix task, pass if set
2018-12-10 11:40:44 -05:00
René Moser
e0ad0eb42c Merge pull request #49678 from resmo/fix/cloudstack-tests-unstable
cloudstack: Fixes for unstable tests
2018-12-10 08:39:16 -08:00
Brian Coca
70ba960f6d
More specificity in errors for cfg mgr (#48995)
* More specificity in errors for cfg mgr
2018-12-10 11:38:42 -05:00
Brian Coca
20270680fc
fixes to ansible-doc (#47682)
fixes to ansible-doc
 - change json to always be type dependent
 - change changelog generation to loop over the options
 - warn about ignoring module path
2018-12-10 11:37:15 -05:00
Andreas Krüger
18bf48cec2 Pull documentation of ansible.module_utils.basic from (improved) doc strings. (#48416) 2018-12-10 09:17:15 -06:00
Brian Coca
ba4c2ebeac
ensure ssh retry respects no log (#49569) 2018-12-10 09:55:18 -05:00
Dag Wieers
37820be05b
aci_rest: Fix ignoring custom port (#49715) 2018-12-10 15:08:06 +01:00
Felix Fontein
270b6a2ee2 docker_*: hint at DOCKER_CONFIG environment variable (#49689)
* Hint at DOCKER_CONFIG environment variable directly supported by docker-py.

* Adjust wording.
2018-12-10 13:40:29 +00:00
Dag Wieers
23ae3aa32a read_csv: new module to read CSV files (#49578)
* read_csv: new module to read CSV files

* Add a doc reference to the csvfile lookup plugin

* Enable the use of custom dialect options

* Improve error handling

* Fix PEP8

* Fix more PEP8

* Simplify custom dialect code

* Add integration tests

* Fixes for CI

* Fix for python 2.6
2018-12-10 11:42:47 +00:00
Carsten Koester
e25dac946f openstack: fix parameter handling when cloud provided as dict (#42899)
* openstack: fix parameter handling when cloud provided as dict

If a cloud is provided as dictionary:

 * Do not assert that 'interface' parameter is None. Instead,
   assert that it is 'public'.
 * Assert that 'auth_type' parameter is not set.

Fixes #42858

* os_user: Include domain parameter in user lookup

If a "domain" parameter is provided, use it in looking up
whether the user already exists.

Fixes #42901

* os_user: Include domain parameter in user deletion

If a "domain" parameter is provided, use it in deleting
the user also.

Fixes #42901
2018-12-10 11:41:22 +00:00
Felix Fontein
495a426039 docker_swarm: fix minimal API version (#49691)
* Reduce minimally required docker API version to 1.25, with selective features requiring 1.30.

* Adjust test requirements.

* Forgot some imports.
2018-12-10 14:09:28 +05:30
Dario Zanzico
b183eb4464 docker_swarm_service: ensure idempotency when the user parameter is None (#49235)
* ensure idempotency for user set to None

* Update `user` documentation and add changelog fragment

* clarify changelog fragments and parameters documentation

* use restructuredtext syntax in changelog fragment
2018-12-10 14:09:13 +05:30
Zim Kalinowski
b89eb7a8c9
Support for generalizing VMs (#49704) 2018-12-10 16:21:09 +08:00
Felix Fontein
aec98b6aab Add docker_volume_facts module (#49692)
* Add docker_volume_facts module.

* Fix type confusion.

* Improve tests.
2018-12-10 15:41:46 +10:00
Christian Kotte
36e3edff50 VMware: New module vmware_host_snmp (#47937) 2018-12-10 11:01:41 +05:30
Christian Kotte
4903e42e2f VMware: New module vmware_vcenter_settings (#48083) 2018-12-10 11:01:15 +05:30
Dave Bendit
f545763296 [docker_network_facts] Creating docker_network_facts module (#49644)
Part of #49267
2018-12-10 15:24:05 +10:00
Abhijeet Kasurde
c9325ca247
Override help string version (#49545)
This fix adds additional help message to version command options

Fixes: #20488

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-10 10:40:19 +05:30
Yuwei Zhou
5a59748e6c Fix if the route table changed to none (#49533) 2018-12-10 10:30:23 +08:00
Yuwei Zhou
c0d95a73ff azure_rm_image module's source can accept dict value (#48864) 2018-12-10 10:29:12 +08:00
Dag Wieers
ee0df72e49 PSRP: Move default loglevel of pypsrp to WARNING (#49673) 2018-12-10 09:09:59 +10:00
Alicia Cozine
9142cfc86f
fixes typos in ansible-vault docs (#49671) 2018-12-09 17:05:53 -06:00
jgkirschbaum
87cbce3d90 rabbitmq_vhost_limits: Move to rabbitmq subdirectory (#49650) 2018-12-08 23:41:59 +01:00
Matt Martz
9007dbec2f
Add info about loop based on jinja2 loop var (#42134)
* Add info about loop based on jinja2 loop var

* ansible_loop

* Update test count

* Add extended loop_control that defines whether ansible_loop should be added

* Extended needs to be defaulted

* Revert "Update test count"

This reverts commit f1e93ee469825f4cdcd90fb28667d29aa088275c.

* Add docs about loop_control.extended

* Add revindex and revindex0

* Document ansible_loop in special vars

* Add changelog fragment

* Add tests, change items to allitems so that dot notation works, fix logic error with previtem
2018-12-07 13:49:50 -06:00
Brian Coca
597c258e0e
explain 'bare variables' (#49577) 2018-12-07 14:47:56 -05:00
James Tanner
b6220ce16a rhn_channel lacks sufficient testing and supportability 2018-12-07 11:13:19 -08:00
Andreas Calminder
876b637208 move some of basic into common (#48078)
* move file functions into common.file

* move *_PERM_BITS and mark as private (_*_PERM_BITS)

* move get_{platform, distribution, distribution_version} get_all_subclasses and load_platform_subclass into common.sys_info

* forgot get_distribution_version, properly rename get_all_subclasses

* add common/sys_info.py to recursive finder test

* update module paths in test_platform_distribution.py

* update docstrings, _get_all_subclasses -> get_all_subclasses

* forgot to update names

* remove trailing whitespace
2018-12-07 10:21:11 -08:00
Matt Martz
3a4d476512
Add now() jinja2 global func for getting the date/time (#43792)
* Add now() jinja2 global func for getting the date/time

* Docs and changelog

* now isn't a lookup, it doesn't need disabled
2018-12-07 11:25:53 -06:00
Sam Doran
3d5d0d355f Add purge feature to rhsm_repository (#48123)
This feature makes it easy to enforce exactly which repos are enabled on a managed system without the need for multiple tasks.
2018-12-07 11:53:42 -05:00
Alexander Bethke
27fd8e4dc6 Fix two regressions in flatpak and flatpak_remote modules (#49651)
* Fix python 3 compatibility in flatpak_remote module

* Fix flatpak module for recent versions of flatpak

* Add reminder for contributors to run integration tests manually

There has been several Python version compatibility regressions
introduced into the module which could have been avoided by the
integration tests.
2018-12-07 11:38:42 -05:00
Sorin Sbarnea
cba3290621 Record host specific messages to log files (#28661)
Fixes #28660

Change-Id: I0028f16320fd63c6ee0fa3be942fc88c555e4dcb
Signed-off-by: Sorin Sbarnea <ssbarnea@redhat.com>
2018-12-07 11:11:17 -05:00
Patrick Marques
7aa11c441d Print hostname when fails to generate keyed groups (#49609) 2018-12-07 10:18:25 -05:00
Simon Dodsley
f6b211890a Update purefa_host module (#49157) 2018-12-07 09:42:59 -05:00
Miguel Angel Muñoz González
baf99c8b62 Fortinet's FortiOS firewall ippool IPv6 (#49311)
* Fortinet's FortiOS firewall ippool IPv6

* Update fortios_firewall_ippool6.py
2018-12-07 13:53:02 +00:00
Miguel Angel Muñoz González
0732d4e2cf Fortinet's FortiOS firewall ippool (#49310) 2018-12-07 13:52:46 +00:00
Jose Delarosa
4d77d601ff Add new Redfish command module to handle iDRAC-specific extensions (#49572)
- Module extends the existing RedfishUtils class and leverages its methods
- Acknowlegements to Bill Dodd (@billdodd) for creating original Proof-of-Concept
2018-12-07 13:43:30 +00:00
Miguel Angel Muñoz González
913f6e36f1 Fortinet's FortiOS firewall policy for IPv6-IPv4 (#49309) 2018-12-07 13:42:43 +00:00
Miguel Angel Muñoz González
229013e652 Fortinet's FortiOS firewall vip group for IPv6-IPv4 (#49307) 2018-12-07 13:42:28 +00:00
Miguel Angel Muñoz González
fbf311b094 Fortinet's FortiOS firewall vip group for IPv4-IPv6 (#49306) 2018-12-07 13:42:12 +00:00
Miguel Angel Muñoz González
e1f1e83e77 Fortinet's FortiOS firewall vip group for IPv6 (#49305) 2018-12-07 13:41:12 +00:00
Miguel Angel Muñoz González
c5dbbacce9 Fortinet's FortiOS firewal vip group (#49303) 2018-12-07 13:40:56 +00:00
Miguel Angel Muñoz González
9286763181 Fortinet's FortiOS firewal vip64 (#49302) 2018-12-07 13:35:03 +00:00
Miguel Angel Muñoz González
dfccf5c542 Fortinet's FortiOS firewall vip6 (#49297)
* Fortinet's FortiOS firewall vip6

* Update fortios_firewall_vip6.py
2018-12-07 13:34:40 +00:00
Miguel Angel Muñoz González
877d40cef7 Fortinet's FortiOS firewall addgrp6 (#49295) 2018-12-07 13:31:16 +00:00
Miguel Angel Muñoz González
58711a539b Fortinet's FortiOS firewall address6 template (#49293) 2018-12-07 13:30:58 +00:00
Miguel Angel Muñoz González
ea23681c76 Fortinet's FortiOS firewall address6 module (#49292) 2018-12-07 13:30:41 +00:00
Miguel Angel Muñoz González
d15c221615 Initial commit for fortios_firewall_vip46 (#49106) 2018-12-07 13:29:54 +00:00
Miguel Angel Muñoz González
87905063e2 Initial commit for firewall_vip46 (#49105)
* Initial commit for firewall_vip46

* Initial commit for fortios_policy46

* Revert "Initial commit for fortios_policy46"

This reverts commit dd568b6039.
2018-12-07 13:29:32 +00:00
Miguel Angel Muñoz González
06871d1015 Initial commit for firewall_policy6 (#49091) 2018-12-07 13:29:03 +00:00
John Westcott IV
6469baf460 Added get_certificate module (#41735)
* Added get_certificate module.

* Fixed test against bogus_ca.pem file
2018-12-07 13:27:16 +00:00
Thomas O'Donnell
c802790c90 Update postgresql_ext connection methods (#48538)
Have added some extra arguments to the postgresql_ext module to allow
configuring an SSL connection to the postgresql server and explicit
support for connecting via a unix socket. The arguments and method used
here for the connection are the same as used by the postgresql_database
module.
2018-12-07 08:21:39 -05:00
Pavlos Tzianos
a4eb4b2551 Rabbitmq user permission fixes (#49404)
* Simplify permission changing code for rabbitmq_user module

* Add check for multiple permission dicts for same host to rabbitmq_user module

* Add docstring for _get_permission method of rabbitmq_user

* Fix method that compares vhost permissions in rabbitmq_user

* Add tests for rabbitmq_user module

* Add helper function for simulating collections.Counter functionality
2018-12-07 13:19:08 +00:00
Jordan Borean
198f1e1bea
Revert "Fixes #49362 module dnf: install python3-dnf preferably over python2-dnf. (#49402)" (#49633)
This reverts commit 3247eec97a.
2018-12-07 08:29:12 +10:00
Sean Myers
9434f8608a Add rhsm_repository_release module (#43211)
* Add rhsm_repository_release module

* bump ansible version_added

* Fix imports in rhsm_repository_release unit test
2018-12-06 20:16:18 +00:00
Bill Dodd
303c3494e6 remove non-standard CreateBiosConfigJob command (#48740) 2018-12-06 15:05:31 -05:00
Miguel Angel Muñoz González
4f416597b8 Initial commit for firewall vip (#49003)
* Initial commit for firewall vip

* Limit lines to below 160 chars

* Fix trailing whitespace
2018-12-06 19:04:51 +00:00
Jose Delarosa
d459c2c582 Fix idempotency issues 2 (#49333)
* Fix idempotency issues in set_manager_attributes

* Add changed status in set_bios_default_settings
2018-12-06 18:52:31 +00:00
Dave Bendit
73640a4190 [docker_network] Adding scope and attachable flags (#49562)
Incorporating the abandoned work from PRs #35288 and #45552. Also adding in
the version checking from `docker_container.py`, which should be abstracted
out to `docker_common.py`.
2018-12-06 18:50:45 +00:00
lrrb
4f9f1754b4 fix: ensure than all item of a list of excluded files aren't checked (#45122)
* fix: ensure than list of excluded files aren't checked
* test: exclude a list of files
2018-12-06 10:13:31 -08:00
Jordan Borean
0d7e95b4db Clarify that do until loops are unsupported on include tasks (#49581) 2018-12-06 11:02:47 -05:00
Abhijeet Kasurde
d8859a7352 Update lambda documentation for runtimes (#49595)
There is no API or AWS command to list down latest available
runtimes. Updated documentation with AWS official lambda docs.

Fixes: #49552

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-06 10:58:58 -05:00
Chris St. Pierre
63b7882cbb Deprecate the github_hooks module (#49296)
It was super incomplete, and the interface was pretty strange; it had
built-in features to handle pretty bespoke workflows ("clean504",
e.g.) but was lacking lots of other useful features (like the ability
to create a webhook with a shared secret). Rather than try to update
the interface in a backwards compatible way, I've replaced it with the
more predictable, single-purpose github_webhook and
github_webhook_facts modules.
2018-12-06 15:56:53 +00:00
Matt Martz
69d230f4bf Make squash deprecation messages less misleading (#49551) 2018-12-06 10:49:01 -05:00
Chris St. Pierre
891f1a59cb Add github_webhook module (#35813)
* Add github_webhook module

github_webhook lets you easily create, update and delete Github
webhooks.

This is part of a two-part replacement for github_hooks, which lacks a
number of important features and has a strange interface.
2018-12-06 13:40:17 +00:00
Chris St. Pierre
edaccc58a4 Add github_webhook_facts module (#35814)
* Add github_webhook_facts module

github_webhook_facts gathers information about Github webhooks.

This is part of a two-part replacement for github_hooks, which lacks a
number of important features and has a strange interface.
2018-12-06 13:29:59 +00:00
Thomas Picariello
c8ecac8dc2 Fix google auth scoping for unscoped credentials (#46740)
* Fix google auth scoping for unscoped credentials

* Add changelog fragment
2018-12-06 11:29:57 +00:00
Adam Miller
6f90d62be3 fix py3 scope for unique filter errors, enable filters integration tests on rhel8 beta (#48961)
* fix py3 scope for unique filter errors, enable filters integration tests on rhel8 beta

Signed-off-by: Adam Miller <admiller@redhat.com>

* add changelog

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-12-06 16:13:26 +10:00
uberjew666
b72187cd2c Fixed win_route module (#46395)
* Changed $IpAddress to $Gateway

* Tweaked win_route unit tests

Checks to see if new static route has the correct gateway

* Create win_route.yaml

* Fixed incorrect variable name
2018-12-05 22:39:06 -05:00
Zim Kalinowski
a74449b05f several vmss fixes (#49580) 2018-12-06 10:23:03 +08:00
Tim Rupp
c0520b94b8
Corrects idempotency for f5 parameters (#49576)
Several parameters in the profile modules were not idempotent.
This patch fixes those modules
2018-12-05 16:17:37 -08:00
Tim Rupp
1c3fa2b07f
Deprecate the bigip_asm_policy module (#49574)
Specific import and export modules should be used instead
2018-12-05 16:02:16 -08:00
Sloane Hertel
ae12be6cd9 Add inventory cache options to config base (#46097) 2018-12-05 17:09:49 -05:00
Rhys Campbell
cdc0011333 mongodb_shard module and test exception (#43673)
* mongodb_shard module and test exception

* Update version_added

* Documentation improvements

* Correct yaml errors

* Correct lines over 160 chars

* Correct replicaset

* Minor documentation changes
2018-12-05 16:29:45 -05:00
Toshio Kuratomi
bd7322a3f6 Simplify FactCache.update()
We only need FactCache.update() for the backwards compatibility shim as
MutableMapping.update() will do the right thing.
2018-12-05 12:33:27 -08:00
Toshio Kuratomi
33f0c1ce22 FactCache changes
* Fix FactCache to conform to the dict API
  * update needs to take a dict rather than a key and a value
  * __init__ needs to allow for setting the intial dictionary
* Remove unneeded _display and _cache attributes
* Move ansible.plugins.cache.FactCache to
  ansible.vars.fact_cache.FactCache because this isn't part of the cache
  plugin API.
* Add backwards compatibility when calling update on the new FactCache
* Remove code for calling old FactCache. There's no way to call the old
  FactCache so there's no need for backwards compatible code for calling
  code.  Backwards compatibility is handling things which are calling
  the new FactCache.
* Port our code to the new FactCache location.
2018-12-05 12:33:27 -08:00
Brian Coca
6096f57880 fix cache 'update' method to be 'mapping' compatible
- also simplify the update functions
 - fix methods and allwow backwards compat with plugins overriding 'update'
2018-12-05 12:33:27 -08:00
Ken Dreyer
8e05d8e329 docs: link to openstacksdk (#49521)
We use the openstacksdk library for OpenStack client configuration now.
Update the doc fragment so we point users at the correct place.
2018-12-05 14:06:20 -05:00
Ganesh B Nalawade
329cbcf973 Fix in dict_merge to check for Mapping
*  Based on review comments for PR #49474 change the check
   for isinstance from `dict` to `Mapping`
2018-12-05 10:31:32 -08:00
Matt Martz
77de219836
Support version 3 of the redis python library (#49445)
* Support version 3 of the redis python library. Fixes #49341

* Document 2.4.5 minimum redis-py version
2018-12-05 12:08:53 -06:00
Brian Coca
e17a2b502d updated ff docs to include and deprecate skip (#45167)
* updated ff docs to include and deprecate skip

* fine tuned requires

* deprecate

* fixes
2018-12-05 12:08:30 -05:00
Ryan Conway
aacd22acc6 Fix an issue retrieving some types of 1Password items. (#47213)
* Some types of 1Password items have a 'password' field alongside the 'fields' attribute, not inside it, so we need to search there as well.

* Add changelog fragement for onepassword_facts PR #47213.
2018-12-05 11:49:26 -05:00
Anil Kumar Muraleedharan
dd004321d4 Refactoring code of cnos_portchannel as cnos_linkagg in tune with other vendors. (#49467)
* Refactoring code of cnos_portchannel as cnos_linkagg in tune with other vendors.
2018-12-05 11:03:42 -05:00
Simon Dodsley
29e071d67a Major update for purefa_pg module (#46771) 2018-12-05 08:21:09 -05:00
Josue David Hernandez
6d42c5020a Fix for changes in clearlinux (#49344)
* Fix for changes in clearlinux

clearlinux is now providing /etc/os-release file and ansible is identifying as NA
then this change allow ansible to find it

Signed-off-by: Josue David Hernandez Gutierrez <josue.d.hernandez.gutierrez@intel.com>

* Add changelog fragment for clearlinux changes

Signed-off-by: Josue David Hernandez Gutierrez <josue.d.hernandez.gutierrez@intel.com>
2018-12-05 13:13:40 +00:00
Klaus Frank
cb24ab3014 VMware: Implement wait_for_customization (#46625)
* Implement wait_for_customization
* Add documentation for vmware_guest's wait_for_customization parameter

Fixes #43082
2018-12-05 18:15:30 +05:30
Abhijeet Kasurde
2af4761677 Documentation update for route53_facts (#49525)
Updates details about required parameters.

Fixes: #49450

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-05 10:21:17 +00:00
chris93111
7c8b5a407d VMware: Add option to modify disk type while cloning template (#47859)
* Add parameters to module vmware_guest for conversion of disk to thin or thick when vm is cloned or deployed with template

* unit test for convert clone vm

Co-Authored-By: chris93111 <christopheferreira@ymail.com>
2018-12-05 15:50:23 +05:30
Naval Patel
880390ca0a Added new module lxca_nodes for Lenovo XClarity Administrator (#46767)
* Added new module lxca_nodes
2018-12-05 10:18:36 +00:00
Christian Kotte
f3c4b2fc74 VMware: New module vmware_vcenter_statistics (#48084) 2018-12-05 15:46:42 +05:30
Toshio Kuratomi
c817bef3ae Fix for callback plugins on Python3 when a module returns dictionary keys that aren't strings
This fixes one of the problems reported in https://github.com/ansible/ansible/issues/49343

Upstream Python3 bug for the json traceback:
https://bugs.python.org/issue25457

and PR that may fix it:
https://github.com/python/cpython/pull/8011
2018-12-04 23:03:48 -08:00
Andrey Che
64636d9de0 fix synchronize handling of encrypted hosts on delegation (#49460)
* Fix for #49363

* Replaced str() with to_text() as more python version safe

* Changed to comply to errors stragegy
2018-12-04 22:33:58 -08:00
Tim Rupp
1c644fb042
Adds description param to bigip_data_group (#49527) 2018-12-04 21:54:20 -08:00
Tim Rupp
60b75c2cfd
Adds ASM policy import module (#49526) 2018-12-04 21:34:55 -08:00
Tim Rupp
7a4c7b8c0f
Adds module for gtm topology regions (#49510) 2018-12-04 20:58:52 -08:00
Abhijeet Kasurde
1763c8123b
AWS: Add support for available db types (#48703)
Add several database types which are supported by AWS in valid engine type.

Fixes: #48623

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-05 08:59:36 +05:30
James E. King III
79c0e30c5a azure_rm_image: fix creation of image with data disks (#49394) 2018-12-05 09:36:34 +08:00
mattandes
15c5dbcc20 Fix win_nssm credentials quoting (#48761)
* Fix win_nssm credentials quoting

Fix credential quoting for win_nssm after changes to the way nssm command is invoked in Ansible 2.7.1.

* Updating nssm command to update credentials to use Argv-ToString to properly escape password variable.

* Adding changelog fragment for fix of #48728.
2018-12-05 10:38:28 +10:00
James Cassell
2bd6b1415b become_method: make dzdo more like sudo (#47946)
dzdo is basically a drop-in replacement for sudo and supports the same
command line options.

There is no become_flags set for dzdo like there is for sudo, so users
will have to set that separately to have exactly the same functionality.
2018-12-04 18:24:32 -05:00
Toshio Kuratomi
d06cd869b8 Revert "fix cache 'update' method to be 'mapping' compatible"
This reverts commit 68301f890a.
2018-12-04 14:04:13 -08:00
Wojciech Sciesinski
e4a3e73b15 Add win_psrepository (#48828)
* Add win_psrepository

* Small corrections

* Correct requiqurements - add NuGet

* Extend tests

* Post-review updates

* Post-review - updates 2

* Add empty RETURN section in documentation

* Add empty line at EOF

* Post-review updates 3

* Update tests to run in check_mode too

* Minor updates

* Correct installing/updating NuGet

* a few changes for review

* Remove copyrights

* Revert "Remove copyrights"

This reverts commit 2d687ec6a6.
2018-12-04 22:47:28 +01:00
Robert de Bock
3247eec97a Fixes #49362 module dnf: install python3-dnf preferably over python2-dnf. (#49402)
* Create python3and2

Adding tests to see if dnf still works when python-2 and python-3 are installed.

* Update main.yml

Include the tests that run on python 2 and python 3, based on the package manager.

* Update dnf.py

Use python3-dnf by default, otherwise python2-dnf.

* Rename python3and2 to python3and2.yml

Rename.
2018-12-04 16:43:45 -05:00
Tim Rupp
c7dd13758e
Adds bigip_profile_analytics module (#49499) 2018-12-04 12:53:31 -08:00
Bianca Henderson
5499ee30d4 Change GB to GiB in some AWS modules (#49304) 2018-12-04 15:46:34 -05:00
Sloane Hertel
a3e8917b73 [s3_bucket] Handle error paginating object versions when bucket does not exist (#49396) 2018-12-04 15:42:14 -05:00
Toshio Kuratomi
a8fbfe1844 Warn if empty string is present in synchronize's rsync_opts 2018-12-04 12:05:45 -08:00
Tim Rupp
caa6ed3c66
Adds ASM policy fetch module (#49494) 2018-12-04 11:24:34 -08:00
Tim Rupp
138690519d
Various small fixes for f5 ansible modules (#49492) 2018-12-04 11:15:49 -08:00
Sam Doran
6200d32c0d Use IndexError in exception (#49488) 2018-12-04 14:12:00 -05:00
Tim Rupp
7c15417f62
Fixes for examples in f5 modules (#49490)
So that they use provider instead of deprecated args method
2018-12-04 10:31:25 -08:00
Sam Doran
40a5f7bfdf Add better error when k=v syntax is used with YAML in tasks (#41754)
* Add error message for k=v and YAML in a single task

Find the correct line, column, and position for k=v errors since they are different than the position reported initially.

Document bug in quoting syntax check.

* Change tense or error message

Since the error still exists, switch to present tense rather than past tense.

* Remove double spaces after periods in error messages.

http://www.slate.com/articles/technology/technology/2011/01/space_invaders.html

* Add changelog fragment

* Add tests for new error message

* Fix tests

* Add clarifying comments to unit test
2018-12-04 12:32:02 -05:00
Mikhail
2f8d235ce5 Add apt_repo module (#49187) 2018-12-04 16:37:42 +00:00
linnil1
8de46f5cf7 [Junos] Fix bug of setting user password (#44660)
* Add encrypted_password for junos

* Add readme for Junos user encrypted_password

* encrypted_password added in 2.8
2018-12-04 15:49:13 +00:00
Richard Levenberg
5cb39d0d57 Use System.Xml.XmlDocument.Load rather than Get-Content to avoid (#49206)
encoding errors when writing out XML

removing executable bit

refactor tests to handle sanity checking
2018-12-04 15:19:38 +00:00
Łukasz Tomaszkiewicz
9d62cbc2af Fix TargetDBInstanceIdentifier assignment in wrong place (issue #46689) (#47710) 2018-12-04 12:43:49 +00:00
Jon Bergli Heier
9c02ade536 rabbitmq_binding: Add support for state=absent (#48599)
* rabbitmq_binding: Add support for state=absent

* Add integration tests for rabbitmq_binding

* Update testcases

* Add changelog fragment
2018-12-04 12:42:18 +00:00
Brett Maton
6291efd4ea Add module parameter to control Puppet agent noop switch (#43678)
* Puppet agent noop switch

    Add module parameter to control noop switch

    Current module overrides puppet.conf noop setting by forcing '--no-noop' switch  which may not be expected or desired.

    Add parameter to allow user control.

    noop: Undefined - Use agent configuration
    noop: true - Add --noop switch to cmd
    noop: false - Add --no-noop switch to cmd

Ansible check mode always runs with --noop switch

* Update lib/ansible/modules/system/puppet.py

Co-Authored-By: matonb <matonb@ltresources.co.uk>
Co-Authored-By: matonb <matonb@ltresources.co.uk>
Co-Authored-By: matonb <matonb@ltresources.co.uk>
2018-12-04 12:30:19 +00:00
styks1987
bb6a82d2a9 v2 dnsimple api uses type vs record_type (#39301)
* v2 dnsimple api uses type vs record_type

https://developer.dnsimple.com/v2/zones/records/#listZoneRecords

* replace prio with priority
2018-12-04 12:25:29 +00:00
shateq
895c6eea9e Extend functionality of filesystem module to support swap creation (#49456)
* Extended functionality of filesystem module to support swap creation

* Corrected documentation block

* Add a note to for version added

* was
2018-12-04 12:01:29 +00:00
thyme
8a30ceb347 Fix typo in confirm new vault password message (#49468) 2018-12-04 11:04:29 +00:00
Abhijeet Kasurde
a13d1eba93 Correct usages of custom error class (#48778)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-04 00:56:04 -05:00
Abhijeet Kasurde
1b04571ea0
VMware: Fix module usages in module_utils (#49421)
* VMware: Fix module usages in module_utils
* Skip test for Python 2.6 as SSL context is not available in Python 2.6

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-12-04 10:11:29 +05:30
Mike Wiebe
dd984709f5 Fix issues related to track feature (#49454) 2018-12-04 09:57:35 +05:30
sdirbach
e2f85b3f6c Implement test case prefix to filter test cases (#40174)
* Implement test case prefix to filter test cases

* Cut line to not exceed 160 chars

* Replace tabs with spaces

* Add version_added field

* Include changelog file
2018-12-03 18:41:44 +00:00
Paul Neumann
4c58fbc64d nxos: Make sure config ends with a linefeed (#48465)
The config parser on NX-OS does not deal with configs that do not end
with a linefeed correctly which leads to various issues when the config
is loaded from startup-config upon reboot. Therefore, ensure that the
config returned is terminated by a linefeed.
2018-12-03 19:26:26 +05:30
Ricardo Carrillo Cruz
5ffb863f0b Fix regex on ASA password prompt (#49438)
On Cisco ASAv on AWS, the prompt is 'Password', thus the privilege
elevation fails, we need to check upper and lower p.
2018-12-03 13:00:28 +00:00
Xaroth
a6db7f7abd -Fix: The Ubuntu 14.04 image on Shippable runs an old version of python, causing issues with checking out bitbucket, adjust tests to compensate. (#49433)
-Add: Mention bitbucket dropping TLSv1 and TLSv1.1 support as per 01 Dec 2018, potentially causing issues with older clients.
2018-12-03 12:35:58 +00:00
Akshay Gaikwad
597e449afe Support for pids_limit parameter in docker_container module (#49319)
* Support for pids_limit parameter in docker_container module

This add pids_limit parameter support in docker_container module

Fixes #43337

Signed-off-by: Akshay <akshay@localhost.localdomain>

* Add changelog for pids_limit parameter

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Remove unnecessary lines of code

The map is needed if the names are different.

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>

* Update pids_limit option tests

It also run for docker-py < 1.10.0

Signed-off-by: Akshay Gaikwad <akgaikwad001@gmail.com>
2018-12-03 11:22:43 +00:00
Lukas Pirl
9fd5d01d67 `make` module: check return code (#47861) 2018-12-03 10:29:18 +00:00
Frank Zwart
329922e2dd ec2_instance: add placement_group support (#49286)
* add placement_group support
2018-12-03 10:27:54 +00:00
sdirbach
840ab706ee Implement hide task arguments feature (#40176)
* Implement hide task arguments feature

* Add version_added field

* Include changelog file
2018-12-03 09:22:51 +00:00
John Kerkstra
672acbea68 Adds redshift_cross_region_snapshots module (#35527)
* add redshift_cross_region_snapshots module, unit tests.

* fix errors

* use ec2_argument_spec as the basis for the argument spec. fixed
metadata_version

* follow best practices by naming example tasks.

* code review changes

* fix linting errors

* Update version added
2018-12-03 08:34:53 +00:00
Marcin
8a7d19788c Dont' attempt to remove drive if ID is "None" (#49423) 2018-12-03 15:09:03 +08:00
anasbadaha
7fcd55f3ec Fix Issue:#47076 onyx_l2_interface parameter trunk_allowed_vlans tries to remove all existing vlans on a port (#49418)
Signed-off-by: Anas Badaha <anasb@mellanox.com>
2018-12-03 10:39:39 +05:30
Felix Fontein
b0c7efcc6b ACME: add diff to acme_account, account_public_key to acme_account_facts, and general refactoring (#49410)
* Only one exit point.

* Refactoring account handling.

* Add diff support for acme_account.

* Insert public_account_key into acme_account_facts result and into acme_account diff.

* Add changelog.
2018-12-02 18:40:14 +01:00
Chris Archibald
62dd1fe29e New options of na_ontap_aggregate (#48906)
* add new options for na_ontap_aggregate

* add gpl line

* remove dup option

* Put files in wrong directory

* change unit test to match the request from PR 48941

* Changed for review comments

* pep8
2018-12-02 14:24:27 +00:00
Felix Fontein
34c57b4c42 ACME: fix bug introduced in #49266, work around problem with Pebble (#49407) 2018-12-02 10:07:21 +01:00
Ruben Tsirunyan
d62492e656 zabbix: New zabbix_action module (#49189) 2018-12-02 10:04:45 +01:00
Brian Coca
fc71cde7d3
Yaml inventory more tolerant (#48883)
* make yaml inv more tolerant to comments
* add tests for bad inventory processing

fixes #47254
2018-11-30 22:04:39 -05:00
Bob Vincent
2557373cc8 Do not document buggy behavior. (#49325)
In the pip module, umask should be specified as an octal *string*, not an octal (or decimal) *integer*.
2018-11-30 15:22:15 -06:00
Brian Coca
8c43ce491e unsafe cleanup 2018-11-30 13:07:00 -08:00
Alicia Cozine
031e961c58
removes talk of hardcoded loading from plugin docs (#49383) 2018-11-30 14:37:55 -06:00
Gregor Wegberg
4096d74245 Specify key to use while sorting permissions (#49126)
Without specifying the dictionary key to use while sorting it will fail
in Python 3 environments due to simplifying Python's rules for ordering
comparisons: https://docs.python.org/3.0/whatsnew/3.0.html#ordering-comparisons
2018-11-30 20:18:57 +00:00
Ken Partridge
19035dbcb2 CPM plugcontrol for WTI Power Devices (#47683)
* Add WTI OOB and PDU Device status, control and configuration module

* removed accidental file inclusions

* removed accidental file

* remove unneeded legacy files

* Added the new module cpm_plugcontrol to control the plugs on WTI Power devices
2018-11-30 20:13:48 +00:00
Ken Partridge
837818018d CPM plug configuration for WTI Power Devices (#47989)
* Add WTI OOB and PDU Device status, control and configuration module

* removed accidental file inclusions

* removed accidental file

* remove unneeded legacy files

* added the module cpm_plugconfig
2018-11-30 20:13:05 +00:00
Adam Miller
378cc9668c dnf module load/init dnf pkg mgr plugins properly (#49278)
* dnf module load/init dnf pkg mgr plugins properly

Fixes #45940

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-11-30 10:00:33 -08:00
Jorgen
8ff13db17c Add Windows example of raw command (#47153)
* Add Windows example of raw command

Perform shutdown of Windows OS using Microsoft.PowerShell.Management module

* Capitalized cmdlet, remove quotes and improve description

This commit also cleans up some of the description sections.

* Use another example as suggested by jborean93

I was happy to merge this before I noticed jborean93 objected to the example :-/

* Fix whitespace issue
2018-11-30 17:12:19 +01:00
Martin Krizek
c78c8d389f
Last loaded handler with the same name wins (#49249)
* Last loaded handler with the same name wins

* Add comment explaining reversed
2018-11-30 16:30:27 +01:00
James Cote
aee9209375 Update set_fact doc to reflect updated caching options (#46565)
* Update set_fact doc to reflect updated caching options

* add note about change in precedence caused by caching
2018-11-30 08:42:47 -06:00
Peter Sprygada
2a4be2748f fixes an issue with dict_merge in network utils (#41107)
This change address a problem where the dict_merge function would fail
due to the value being a nested dict.  This will now recursively pass
the value back through the dict_merge function.
2018-11-30 17:52:33 +05:30
Youhua Li
c1a30c743e enable ONE auth file authentication (#49331) 2018-11-30 07:06:05 -05:00
Lars Kellogg-Stedman
b2e5c75131 server.security_groups is a list of dicts (#48798)
os_server was trying to access `[sg.name for sg in
server.security_groups]`, but the items in `server.security_groups`
are dictionaries, so that should be `sg['name']`.
2018-11-30 06:42:50 -05:00
Giovanni Sciortino
95718f7e12 fix archive module can not compress a single file in a tar file (#45117)
fixes #44968
2018-11-30 10:49:35 +00:00
Martin Surovcak
87a9ada188 fix module argument to be boolean (#47134) 2018-11-30 10:43:29 +00:00
Lex Rivera
aa484c0835 Fix GCE and scaleway VM detection (#47193)
* Fix Google cloud engine & Scaleway VM detection
2018-11-30 10:38:43 +00:00
maxstack
0dbac3f3b8 add default nolog param for VPN PreSharedKey (#47788) 2018-11-30 10:37:17 +00:00
Alan Rominger
d536be6530 Avoid duplicated recursive calls in inventory CLI (#48598) 2018-11-30 10:36:19 +00:00
ftntcorecse
b4ce4e1571 Fortinet FortiManager Device Group Module (#46086)
* fmgr_device_group PR candidate

* fgmr_device_group PR candidate

* PR candidate

* PR candidate

* Fixing Edits.

* Fixing Edits.

* Fixing Authors

* Removed State Parameter and replaced with Mode, per request of justjais
2018-11-30 15:54:41 +05:30
bverschueren
5cd31578cc comparing StorageConnection.password breaks idempotency (#48933) 2018-11-30 10:24:04 +00:00
Christian Kotte
68cafbda2b Improve vmware_dvswitch module (#48720) 2018-11-30 03:34:43 -05:00
Matthew Krupcale
93fd323457 Add support for newer FreeIPA SHA256 SSH public key hashes (#40803)
* lib/ansible/modules/identity/ipa/ipa_user.py:
    - Check any existing `ipa_user` SSH public key fingerprints for the hash algorithm to use
    - Generate `module_user` SSH public key fingerprint based on detected or default algorithm
2018-11-30 02:47:58 -05:00
Felix Fontein
2bd8e47247 add acme_inspect module (#48444) 2018-11-30 08:26:18 +01:00
rajaspachipulusu17
fe147289b7 Pluribus Networks pn access list module (#49176)
* Pluribus Networks pn access list module
* Added shlex import which was missing and added correct author
* Added an extra space which is according to pep8
2018-11-30 12:40:43 +05:30
Sofiane Medjkoune
ec73af1d78 Removed the unused argument description from lxd_container module (#31440) 2018-11-30 01:59:34 -05:00
Abhijeet Kasurde
3141fda6b4
Misc typos in ce action plugin (#49348)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-30 11:50:00 +05:30
Yunge Zhu
be28794dfc
fix keyvault key secret not support cloud environment (#49182) 2018-11-30 14:08:31 +08:00
Monty Taylor
824c72da5f Set play context on stdout callback plugin (#35910)
The loop on self._callback_plugins does not include the stdout callback,
so the stdout_callback never has set_play_context called.
2018-11-29 23:15:56 -05:00
Gaël Lambert
ad7798c26a Add the ability to download a specific version of an S3 object (#47867)
Add the ability to download a specific version of a S3 Object

Fixes: #47864
2018-11-30 08:59:12 +05:30
Florian Pracht
eb410a9987 Run patch command with --check option instead of --dry-run to support older BSDs (#42168) 2018-11-29 21:53:53 -05:00
Dag Wieers
bc481c2500 PSRP: Improve default logging to ansible.log (#47645) 2018-11-29 18:18:39 -08:00
Dag Wieers
01d66d4431 WinRM: Improve default logging to ansible.log (#49308) 2018-11-29 18:18:18 -08:00
Tomáš Pospíšek
434c421675 improve usage example of tempfile module (#47933)
* Show in example how to use file created by tempfile module
2018-11-29 16:24:58 -06:00
Chris Archibald
73348ae32d Fixes for na_ontap_cluster_peer (#48329)
* Fixes for na_ontap_cluster_peer, incorporating review comments, version, etc.
2018-11-29 16:22:02 -06:00
Laurent G
655b27f571 VMware: Add a pointer on how to get possible values. (#48658)
* Add a pointer on how to get possible values for VMware host config manager
2018-11-29 16:19:21 -06:00
Felix Fontein
3726d467ec Code style adjustment. (#49329) 2018-11-29 21:57:32 +01:00
martinwangjian
d1816d4908 grafana_datasource: Add CloudWatch as grafana datasource type (#48174) 2018-11-29 20:58:49 +01:00
Matt Martz
77befcf5d7
Do not allow addressing an import from handlers via notify. Fixes #48936 (#49317) 2018-11-29 13:50:07 -06:00
Dusan Matejka
a9aa1053a8 zabbix_template: fixed idempotency issues (#49188) 2018-11-29 20:38:32 +01:00
Paul Neumann
a914f494a8 ios_facts: Gather CDP neighbor data (#49129)
* ios_facts: Gather CDP neighbor data

* ios_facts: Create tests for ansible_net_neighbors
2018-11-29 14:05:17 -05:00
Ryan Brown
a51eca364f New module: AWS EC2 Launch Template (#46972)
* Add launch template integration tests
2018-11-29 13:59:10 -05:00
Isakov Anton
5a7f2b6b08 Update elb_application_lb_facts.py (#48983)
<!--- Added example how to see the facts about specific ALB -->
2018-11-29 11:38:46 -05:00
Brian Coca
24e4d26b72 added missing github id 2018-11-29 10:48:38 -05:00
Amy Buck
392a12589e Update dellos10_command.py (#48167)
<!--- Your description here -->

Updated Dell OS10 to Dell EMC OS10
2018-11-29 10:29:15 -05:00
spike77453
bd35069495 Non-existent RR returns empty string (#40680) 2018-11-29 14:58:16 +00:00
Pilou
62c05033d6 templar: ensure that exceptions are handled, fix 'AttributeError' (#48792)
* templar: ensure that exceptions are handled

* Fix AttributeError: object has no attribute 'message'

'message' attribute is deprecated since Python 2.6 and not available
with Python 3.

Simple reproducer:

    - hosts: localhost
      vars:
        not_json: "{{ 'test str' | from_json }}"
      tasks:
        - command: "echo {{ not_json }}"
2018-11-29 09:56:23 -05:00
jpdasma
37f66ee15b Fix reboot plugin not working in Illumos/Solaris (#48986) 2018-11-29 09:54:51 -05:00
Sam Doran
8f9ced4005 Improve log message (#49004)
This is the only connection plugin that doesn't state explicitly what it is in the log.
2018-11-29 09:53:26 -05:00
Douglas Fraser
d6d16fa619 Extend DMI form factors list to match SMBIOS standard 3.2.0 (2018-04-26) (#42239)
Signed-off-by: Douglas Fraser <doug+git@idmf.net>
2018-11-29 09:16:32 -05:00
fdeschamps
faed1bbd96 ignore empty lines in rabbitmqctl output (#43722)
* ignore empty lines in rabbitmqctl output

this fixes a bug with rabbitmq 3.7.5
rabbitmqctl can return empty lines, breaking the rabbitmq_parameter module
especially in a new vhost, the command rabbitmqctl list_parameters -q -p <vhost> will return an empty line

* Strip empty line in rabbitmqctl output
2018-11-29 13:55:05 +00:00
Ryan Brown
af6427bf40 VPC peer module unhandled exception on bad peering ID (#45306)
* Improve error handling for VPC peer module when a bad peering-id is specified

* changelog
2018-11-29 08:54:16 -05:00
Ryan Brown
7f7c059a04 ec2_asg: Retry Autoscaling Group delete calls when scaling activity is in progress (#46124)
* Retry delete calls when scaling activity is in progress

* changelog
2018-11-29 08:42:55 -05:00
joaocpinto
bbab4c1b49 Cast int for expire field to avoid call failure to sensu API (#33239) 2018-11-29 12:30:59 +00:00
Corey Wanless
6cd321ed8e sets admin_password to no_log (#46604) 2018-11-29 12:17:15 +00:00
John Nelson
571749f3ed ec2_vpc_nacl: Don't default name into Name unless able (#48889)
This fixes ansible/ansible#issues/48832
2018-11-29 09:52:17 +00:00
Felix Fontein
1e0ab16247 Add basic unit tests for module_utils/acme.py. (#49103) 2018-11-29 09:32:15 +00:00
Alan Rominger
729c3a6767 Fix error where pod has error and no containers (#49154)
k8s: Fix error where pod has error and no containers
2018-11-29 09:17:04 +00:00
Dusan Matejka
7190c73d50 zabbix_hostmacro: Fixed support for LLD type user macros and added missing validate_certs attribute (#48730) 2018-11-29 09:15:13 +01:00
Felix Fontein
b842b1b97e ACME: improve error handling (#49266)
* Improve error handling: when parse_json_result is False, still return the error message.

* Remove content body from info dict.

* Add changelog.
2018-11-29 09:00:39 +01:00
Ganesh Nalawade
829fc0feda
Fix iosxr netconf plugin response namespace (#49238)
* Fix iosxr netconf plugin response namespace

*  iosxr netconf plugin removes namespace by default
   for all the responses as parsing of xml is easier
   without namepsace in iosxr module. However to validate
   the response received from device against yang model requires
   namespace to be present in resposne.
*  Add a parameter in iosxr netconf plugin to control if namespace
   should be removed from response or not.

* Fix CI issues

* Fix review comment
2018-11-29 13:21:41 +05:30
Olivier BLIN
c51407c806 Fix nxos modules idempotence issue (#46437)
* nxos_interface vlan and port-channel idempotence fix for mtu

* Fix MTU reconfiguration at each execution

* nxos_interface port-channel idempotence fix for mode (#44248)

* Fix trunk mode idempotence for port-channel
* Gather ethernet and port-channel code for mode management

* nxos_linkagg port-channel idempotence fix for channel-group's mode

The regex to retrieve channel-group's mode is not enough accurate.
Therefore, the swhitchport mode  was matched instead of the
channel-group's mode.

* This fix add accuracy to match the right configuration command

* Add support for switchport mode dot1q-tunnel in nxos_interface

* Fix layer reconfiguration at each execution
2018-11-29 10:23:51 +05:30
Mike Wiebe
af1e6878e9 Fix n3k power supply facts (#49150) 2018-11-29 09:29:21 +05:30
Yunge Zhu
ecd995496c new module: azure_rm_rediscache (#47914)
* add new redis cache module

* fix version

* fix lint
2018-11-28 15:59:55 -08:00
Sandra McCann
13a6b4a856 Gather subset fix (#49264)
*  reword subset description for ios_facts
2018-11-28 15:33:16 -06:00
vmpr
46a3c0cf2e changed documented default value for url (#49097)
the Default Value for url is 3000, so there was a mistake in the documentation
2018-11-28 15:16:36 -06:00
Chris Archibald
6dc6538eef Bug fixes for na_ontap_fcp (#48583) 2018-11-28 20:03:44 +00:00
Selivanov Pavel
0b380b09bf ec2_instance_facts.py: documentation: add example (#49010)
Add an example of using multiple states for instance-state-name in filters. Not obvious how it works until you try.
2018-11-28 19:42:38 +00:00