Stephen Fromm
85f628ae26
Return extra information from service module
...
If _do_enable() is run and returns rc == 0, set changed=True
Add enabled and state to result if they are supplied when the module is
run.
2012-08-01 14:58:32 -07:00
Stephen Fromm
64374ed7f2
Fix service module for issue 755 and another bug
...
Allow use of service module with just enable parameter, per issue #755 .
Also fixed two other issues:
- fixed parameter to be 'enabled' per docs, not 'enable'.
- fixed if block that checks whether to run _do_enable() to check
whether the parameter is set, not the value of the enable value which
may be None or False. If enabled=no, the service would never be
disabled.
2012-08-01 14:44:26 -07:00
Christoph Seitz
f126c77b3b
Tweaked error massages.
2012-08-01 18:45:32 +02:00
Christoph Seitz
db7b11f152
Some optimizations to previous code.
2012-08-01 18:43:39 +02:00
Christoph Seitz
20e8df1a05
Enable apt module to handle multiply packages (comma separated)
2012-08-01 18:09:30 +02:00
Jan-Piet Mens
a81944e32b
Fix exeptions, replace 'as' by ',' as reported on IRC for Python 2.4.3 on Centos5
2012-08-01 15:30:16 +02:00
Michael DeHaan
fe9a05f492
Module consistency and make daisy chaining work with invalid arguments detection.
2012-08-01 00:22:02 -04:00
Michael DeHaan
fe9b0bf38d
Teach the common module code to warn users about typo'd arguments and also set everything to None automatically such
...
that code doesn't have to do a lot of params.get('foo', None) everywhere.
2012-07-31 21:23:34 -04:00
Lorin Hochstein
b3353d8f86
Apt module: add update-cache as alias of update_cache
...
This will ensure users of previous versions of this module don't
have their playbooks break.
2012-07-31 09:56:36 -04:00
Michael DeHaan
dcff6ec4d6
Merge pull request #732 from willthames/fix_git_fail_json
...
Fixes for git module when it fails.
2012-07-31 05:04:47 -07:00
Michael DeHaan
92ab23d0da
Merge pull request #733 from willthames/copy_to_directory
...
Allow copy dest argument to be a directory
2012-07-31 05:03:50 -07:00
Michael DeHaan
db6201de79
Merge pull request #735 from nix85/fix_ohai_mod
...
Changed funtion name to get_ohai_data
2012-07-31 05:02:44 -07:00
Petros Moisiadis
6767accc2d
added extra arguments for database creation
...
mysql_db: added 'encoding' and 'collation' args
postgresql_db: added 'owner', 'template' and 'encoding' args
2012-07-31 12:56:29 +03:00
Nikhil Singh
51a8aaf494
Changed funtion name to get_ohai_data
2012-07-31 13:07:53 +05:30
u348095
f3d7bee8e1
Allow copy dest argument to be a directory
...
Could have used shutil.copy rather than shutil.copyfile, but this
implementation preserves the md5 comparison to avoid unnecessary copies
2012-07-31 14:47:01 +10:00
u348095
f0931b5960
Fixes for git module when it fails.
...
* module.fail_json *must* have msg argument
Using http://github.com/ rather than git://github.com/ as it gets through more
firewalls
2012-07-31 12:59:22 +10:00
Michael DeHaan
4782bc1949
Port the file module over to the new common code infrastructure + cleanup some redundant imports since the module code already imports those things.
2012-07-30 21:50:32 -04:00
Michael DeHaan
dd1072a6e2
Porting the virt module to new module core.
2012-07-30 21:16:29 -04:00
Michael DeHaan
9019f4f292
remove unneeded imports
2012-07-28 17:15:07 -04:00
Michael DeHaan
0b909b103d
Port setup module to use the common module base
2012-07-28 17:14:23 -04:00
Michael DeHaan
2105418b73
Port the ohai module over, while this is actually *longer* now, not transferring the args file makes this much
...
faster.
2012-07-28 17:07:55 -04:00
Michael DeHaan
004c21c913
Convert authorized_key modules to use new common code + misc style things
2012-07-28 17:03:10 -04:00
Michael DeHaan
c450fd7478
Merge pull request #730 from marktheunissen/mysql_change_params
...
Changing the parameter names to be consistent, and adding root user
2012-07-30 15:50:40 -07:00
Mark Theunissen
f0a9902c25
Changing the parameter names to be consistent, and adding root user default with empty password, as per mysql standard
2012-07-30 17:15:24 -05:00
Michael DeHaan
07880e6301
Merge pull request #727 from sfromm/git
...
Git module ported to use module magic
2012-07-30 13:40:36 -07:00
Michael DeHaan
615d180bc8
Merge pull request #723 from skvidal/devel
...
fix trace-creating error in apt module - also make the default setting a...
2012-07-30 10:45:42 -07:00
Seth Vidal
b909b0b603
new patch - adds a 'boolean' function to the module_common class and cleans up
...
the apt module to use it
2012-07-30 13:41:42 -04:00
Seth Vidal
b69ae999ce
fix trace-creating error in apt module - also make the default setting actualy work
2012-07-30 13:07:19 -04:00
Petros Moisiadis
218a63f58f
added a 'chdir' argument to the command module
...
the 'chdir' argument changes the current working directory to the
fullpath supplied as its value, before the execution of the command.
2012-07-30 18:39:45 +03:00
Stephen Fromm
f2c0fd3941
Update git module to use module magic and other changes
...
Convert git module to module magic.
Drop cruft no longer needed.
Standardize indent to 4 spaces in methods switchLocalBranch, reset,
clone, and get_version.
Update is_local_branch to also handle '* branch' format.
Add is_current branch method()
Update pull() method to use is_current_branch()
2012-07-29 22:39:19 -07:00
Lorin Hochstein
ac02b85aad
Use standard argument names in PostgreSQL modules
...
passwd -> password
loginpass -> login_password
loginuser -> login_user
loginhost -> login_host
Add an example playbook that shows how to use the modules.
2012-07-29 12:52:14 -04:00
Lorin Hochstein
481a1916e0
Fix typo in apt error message: update-cache -> update_cache
...
The apt parameter changed from update-cache to update_cache, but
the error message still mentioned update-cache
2012-07-29 12:29:00 -04:00
Michael DeHaan
b7c8b3458b
Further service module tweaks
2012-07-28 16:48:04 -04:00
Michael DeHaan
4e0ca30014
Service tweaks WIP
2012-07-28 16:39:18 -04:00
Nikhil Singh
f24c75ce58
Standardizing the module
2012-07-28 16:39:18 -04:00
Mark Theunissen
12b7b2750c
Fixes for apt module
2012-07-30 17:20:43 -05:00
Michael DeHaan
948e357766
Tweak alias consistency a bit. 'package' has never been documented, but since it works, make it work in both places.
...
'name' is the preferred form. Similarly, take 'name' for the 'guest' argument to the 'virt' module.
2012-07-28 09:22:13 -04:00
Michael DeHaan
069f370bb4
Merge pull request #702 from lorin/postgresql-module
...
Add postgresql_db and postgresql_user module.
2012-07-27 15:32:10 -07:00
Michael DeHaan
d6d59d8976
Merge pull request #704 from lorin/gitfix
...
git module: Don't pass rc as separate arg to fail_json
2012-07-27 05:49:22 -07:00
Lorin Hochstein
b56927874a
git module: Don't pass rc as separate arg to fail_json
2012-07-27 08:40:47 -04:00
Michael DeHaan
95e553e197
Merge pull request #690 from marktheunissen/mysql_default_password
...
Change modules to use credentials in my.cnf if they are available
2012-07-26 17:16:05 -07:00
Michael DeHaan
d284ef2554
Merge pull request #695 from nix85/fix_apt_mod
...
Standardizing the apt module
2012-07-26 17:15:28 -07:00
Lorin Hochstein
ed9227f406
Add postgresql_db and postgresql_user module.
...
These modules are based on the mysql_db and mysql_user modules.
Currently, the postgresql_user module can only grant all permissions
on a database, fine-grained access has not been implemented yet.
2012-07-26 17:05:04 -04:00
Mark Theunissen
7a3f64d4d7
Check file exists instead of relying on the exception. Leave the exception catch in, in case the file is deleted or some other issue crops up
2012-07-26 11:30:22 -05:00
Mark Theunissen
812711d530
Woops, missed the rest of them
2012-07-26 11:13:10 -05:00
Mark Theunissen
b51d6d9fca
Making the passwd parameter consistent
2012-07-26 11:10:22 -05:00
Mark Theunissen
894e4ff78a
Changing to read from a file pointer instead so that an exception is thrown if the file doesn't exist
2012-07-26 08:58:21 -05:00
Nikhil Singh
8d283f8194
Code review changes
...
1. Passing the module to the various functions so that they can use module.fail_json and module.exit_json methods inside.
2. Because of point 1, install and remove methods do not return anything. Instead, they use the module functions itself.
3. Move the import statement (for apt and apt_pkg) inside main function so on import error, we can use module.fail_json to print the error.
2012-07-26 17:29:15 +05:30
Nikhil Singh
4d6b3713a7
Adding dict() for json.dumps
2012-07-26 16:24:10 +05:30
Nikhil Singh
096022acb2
Standardizing the apt module
2012-07-26 16:21:49 +05:30