Commit graph

30294 commits

Author SHA1 Message Date
Pradeep Gorthi
69e31a440c
Updating UCS Platform Emulator Link (#67400) 2020-02-14 11:13:00 -05:00
Abhijeet Kasurde
6cc326dcf1
VMware: Update VMware module defaults (#66486)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-14 10:00:08 -05:00
Bryan Parry
46205594c2
Fix typos in EC2 VPCE module docs (#67426) 2020-02-14 20:28:25 +05:30
Sloane Hertel
97f011cf94
Add verify subcommand to 'ansible-galaxy collection' (#65618)
* [WIP] Add verify subcommand command to 'ansible-galaxy collection'

* Fix pep8 and use consistent display order

* WIP - docs

* Remove some redundancy in verify display messages by using an error queue for each collection

* Share common code and improve output format

* clean up documentation

* typo

* Apply suggestions from code review

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Move ModifiedContent namedtuple to the global scope

Add a public metadata property

Rename function to _get_json_from_tar_file

* Add some unit tests

* fix using common functions after rebase

* changelog

* Improve efficiency finding specific installed collections

Improve efficiency by only downloading the tar.gz from the galaxy server for comparison after checking that the collection has been installed

Handle multiple collection paths

Fix up tests

* pep8

* reword that for accuracy

* use more common code and verify collection name

* Improve error message and add documentation

* Update unit tests and add coverage for both local and remote collections that are unable to be located

* Only validate collections using the format collection_namespace.collection_name

Fix tests to reflect that

Fix documentation

* Fix a bug when a local collection does not contain a file

* pep8

* Fix formatting

Co-authored-by: Sandra McCann <samccann@redhat.com>
2020-02-14 08:57:04 -06:00
Nilashish Chakraborty
5ca7a9ea26
Fix tracebacks with search_obj_in_list (#67389)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2020-02-14 09:46:59 +05:30
Fortinet Core CSE NA
c1d8bdb87a
FortiAnalyzer Network Manager Hotfix (#62919)
* Hotfix for FortiAnalyzer HTTPAPI Plugin in response to connection issues introduced in Ansible 2.9.

* Changed _connect behavior per Mr. Case.

Co-authored-by: Luke Weighall <lweighall@users.noreply.github.com>
Co-authored-by: Nathaniel Case <this.is@nathanielca.se>
2020-02-13 19:36:48 -05:00
Jordan Borean
4881af2e7e
galaxy - Fix collection install dep resolver for bad versions (#67405)
* Also make sure version is a string and not an int/float
2020-02-13 17:23:17 -05:00
Mark Chappell
90898132e4
CloudRetry/AWSRetry : Disable catching of NotFound exceptions (#67281)
* CloudRetry/AWSRetry : Remove default catching of NotFound exceptions

* Add docs

* Changelog updates from review

* Update unit tests after removing 'NotFound' from default retries
2020-02-13 16:59:00 -05:00
Markus Bergholz
69eec1c98f
elb_target_group - try to handle target_type default when state is absent (#65201)
* try to handle default when state is absent

* remove default target_type

* Update lib/ansible/modules/cloud/amazon/elb_target_group.py

Co-authored-by: Mark Chappell <mchappel@redhat.com>
2020-02-13 15:49:24 -05:00
Martin Krizek
a2c620819f
Remove a host from a play after meta: end_host (#66851)
* Remove a host from a play after meta: end_host

* Fix changelog
2020-02-13 15:35:00 -05:00
Mario Lenz
77c19daefa Fix creating IP specific firewall rules with Python 2 2020-02-13 12:32:42 -05:00
AHIL-KANNA-WORK
3b3db88a72
Update vmware_guest.py (#67380)
Incorrect value in example
2020-02-13 12:25:23 -05:00
Jordan Borean
446a0c1b08
win_package - Refactor with msp, appx support (#66931)
* win_package - Refactor with msp, appx support

* Added msi test for ALLUSERS

* Added some msix tests, refactored tests

* Added remaining msix tests

* Enable msix sideloading for tests

* Added remaining exe path tests

* Added basic msp tests

* Remove url options now the util no longer has them

* Fix file version check for older Windows hosts

* Remove no_proxy ansible-test setting

* Use same mechanism of become to copy the file with explicit creds
2020-02-13 16:44:19 +10:00
Jordan Borean
2d9328cb0f
Added Ansible.Service util and win_service_info (#67367)
* Added Ansible.Service util and win_service_info

* Fix up util test

* Sigh forgot to update the test and fix sanity

* Try to make tests more robust

* That didn't work, just check the username

* Betraying Queen and country with this doc fix

* More changes for compat

* More OS compatibility
2020-02-13 14:34:58 +10:00
Felix Fontein
11e75b0af2
Fix broken links in crypto, docker and hetzner modules. (#67360) 2020-02-12 16:41:40 -05:00
tchernomax
53e043b5fe
combine filter: fine list handling (option b) (#57894) 2020-02-12 16:40:36 -05:00
Fortinet Core CSE NA
33f136292b
Hotfix for FortiManager Network Connection Plugin (#62534)
* Hotfix for connection manager persistent connection initialization.

* PEP8 Fixes

* First Round of fixes requested by Qualthos.

* Removed _connection check per Mr. Case.

* Somehow the wrong version got sent... should be all good.

Co-authored-by: Luke Weighall <lweighall@users.noreply.github.com>
Co-authored-by: Nathaniel Case <this.is@nathanielca.se>
2020-02-12 14:30:59 -05:00
Mark Chappell
8d574c3770
AnsibleAWSModule related cleanup - redshift (#66779)
* AnsibleAWSModule related cleanup - redshift

* Apply a backoff on modify_cluster to cope with concurrent operations

* Add AWS 'hacking' policy to allow creation of Redshift ServiceRole

* Adding the retry policies makes the redshift test suite more reliable
2020-02-12 11:17:18 -07:00
Sandra McCann
a6bb3ae291
fix some broken links (#67345) 2020-02-12 10:47:00 -06:00
GomathiselviS
4ec1437212
Fix to - eos_vlans using state parameter replaced is giving odd behavior (#67318)
* Added fix for bug # 54400

* Adding files for RM static_routes

* Added Integration tests

* Revert "Added fix for bug # 54400"

This reverts commit bf42db4269.

* Revert "Adding files for RM static_routes"

This reverts commit dafdd92d43.

* Revert "Added Integration tests"

This reverts commit 129dc87682.

* Adding files for RM static_routes

* Added Integration tests

* Corrected lint errors

* Added fix for bug # 54400

* Revert "Added fix for bug # 54400"

This reverts commit bf42db4269.

* Revert "Adding files for RM static_routes"

This reverts commit dafdd92d43.

* Revert "Added Integration tests"

This reverts commit 129dc87682.

* fix to bug #67313

* fixing rebase issue

* fixing rebase issue

* addressed review comments

* addressed review comments
2020-02-12 11:12:12 -05:00
Derek Winters
bc2419c47c
don't update nios_a_record object when running in check mode (#67145) 2020-02-12 20:10:10 +05:30
Denis Krienbühl
a4ec18d8a3
Cloudscale Regions and Zones Support (#67165) 2020-02-12 14:06:41 +01:00
Felix Fontein
8ff62799c9
AnsibleModule.load_file_common_arguments: allow to override path (#61659)
* Allow to overwrite path in AnsibleModule.load_file_common_arguments

* Use path override.

* Add changelog.
2020-02-12 12:52:36 +01:00
Andrew de Quincey
d1846b96c0
cope with an ASG instance not having a launch config any more (#57737) 2020-02-12 05:54:58 -05:00
petoju
8ac0bbcbf6
mysql_replication: add option to fail on error (#67322) 2020-02-12 12:18:51 +05:30
Felix Fontein
f6815040fd
add_file_common_arguments: fix defaults and tpyes, improve sanity checking (#67243)
* Make validate-modules stop ignore FILE_COMMON_ARGUMENTS.

* Add types to FILE_COMMON_ARGUMENTS and update document fragment to match it.

* Update ignore.txt.

* Add changelog.
2020-02-12 01:44:11 -05:00
Gonéri Le Bouder
08db603262 vmware_host: fix doc syntax error
Adjust the `DOCUMENTATION` section to get a proper rendering of the
`folder` example.
2020-02-11 18:23:13 -05:00
Matt Clay
efc5d62c49 Use a custom test module for module_defaults test.
This avoids a dependency on a module which will not remain in the repo after migration.
2020-02-11 13:59:33 -08:00
Baptiste Mille-Mathias
3be0795ea3
Fix examples to use from_yaml filter with lookup (#65424)
The documentation says to use `from_yaml` filter when using `lookup`  from node executor. Now the examples do too.
2020-02-11 15:36:08 -06:00
Piotr Stawarski
a0247d13d8
New magic var: ansible_config_file (#66085)
* Add `ansible_config_file` magic variable

* Add ansible_config_file to INTERNAL_VARS

* Add changelog fragment

* Update Special Variables docs
2020-02-11 15:49:55 -05:00
Sean Hsu
4967224248
Update digital_ocean_droplet.py (#66794)
* Update digital_ocean_droplet.py

here's new term of `ssh_keys` from `SSH key (numeric) ID` and in fact it's fingerprint. correctly term so people can easily know how to do it.

* Update digital_ocean_droplet.py
2020-02-11 15:14:50 -05:00
Matt Warren
a8a89b7102
Update yum.py (#67252)
Move the simpler name list example to the top of EXAMPLES.
Those with v2.11 loop deprecation warnings will be looking for a solution.
2020-02-11 14:03:28 -05:00
Noboru Iwamatsu
28071daab8
s3_bucket: fix condition checking of requester_pays param. (#64010) 2020-02-11 10:57:09 -07:00
Justin Haefner
1867ff4013
Update mso_schema_site_anp.py (#67099)
Under Examples > Query a specific site ANPs: the example was missing the "anp: ANP1" to query.
2020-02-11 11:52:57 -06:00
Sebastian Thörn
d273e9758e
Update group.py (#67309)
Added example with gid-param
2020-02-11 11:37:21 -06:00
Milutin Jovanović
8a2ac8f76a
Fixing typo in regex escape. (#67236) 2020-02-11 11:23:58 -06:00
Andrew Klychkov
a86524b2bb
Bugfix of 65525: proxysql in check_config TypeError: tuple indices must be integers, not str (#66850) 2020-02-11 10:53:42 -05:00
Sandra McCann
7ef7c1b5d7
add note on write access to socket_path (#67060)
* Change socket_path error messages to not directly refer to socket_path
* Apply suggestions from code review

Co-Authored-By: Nathaniel Case <this.is@nathanielca.se>
2020-02-11 09:49:20 -06:00
Jack Scheible
28543ae208
Update virt.py (#66899)
##### SUMMARY
The info command also does not require the name option, which is completely ignored.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2020-02-11 15:20:25 +00:00
Bryan Black
2c7623c6cc
Update yarn.py (#66973)
##### SUMMARY
To globally install from local node.js library. Prepend "file:" to the path of the node.js library.


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2020-02-11 15:19:30 +00:00
christiangonre
3b67e75562
Update aws_batch_job_definition.py (#67082)
##### SUMMARY
<!--- The example to call the method batch_job_definition is bad, the good method name is aws_batch_job_definition-->


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2020-02-11 15:18:14 +00:00
portos060474
60479d36f6
Update elasticache_parameter_group.py (#67164)
##### SUMMARY
Typo in description :)


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2020-02-11 15:16:52 +00:00
Mario Lenz
808bf02588
Remove options from some vmware modules that are not used in the code (#67282) 2020-02-11 12:30:22 +01:00
Nilashish Chakraborty
88f0c85228
Remove deprecated attributes from nxos_igmp_interface (#67186)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2020-02-11 12:27:07 +01:00
Martin Nečas
120d11a82b
ovirt_disk: update interface docs (#67272) 2020-02-10 13:56:44 -05:00
ksagle77
b9d22b901d
Allow default network mode, as required for windows containers. (#59597)
* Allow default network option for network_mode, required for windows containers.

* Add change fragment and param description

* Update changelogs/fragments/59597-ecs-allow_default_network_mode.yml

Co-Authored-By: Mark Chappell <mchappel@redhat.com>

* Update lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py

Co-Authored-By: Mark Chappell <mchappel@redhat.com>

* Correct descriptions. Remove whitespaces.

* Remove empty line.

* Add single space after comma

* Update lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py

Co-Authored-By: Mark Chappell <mchappel@redhat.com>

* Update lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py

Co-Authored-By: Mark Chappell <mchappel@redhat.com>

* Update lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py

Co-Authored-By: Mark Chappell <mchappel@redhat.com>

Co-authored-by: kevinsagle <44478308+kevinsagle@users.noreply.github.com>
Co-authored-by: Mark Chappell <mchappel@redhat.com>
2020-02-10 11:01:13 -07:00
sky-joker
1b263e77de Add example for retrieve Product, Version, Build, Update info for ESXi 2020-02-10 11:47:29 -05:00
Stefan Horning
fa8c07a33c
Revert "Make cloudfront_info work with Python3 … (#66695)" (#67085)
This reverts commit aad286b403.
2020-02-10 10:22:00 -05:00
Denis Krienbühl
b40bdb7a22 cloudscale: Fixes wrong return value docs in cloudscale_server (#67198) 2020-02-10 11:47:51 +01:00
Dusan Matejka
c80d0c40ce fixed zabbix no longer returning macros as part of the template (#66996) 2020-02-10 02:09:00 -05:00