Commit graph

8921 commits

Author SHA1 Message Date
Adrian Likins
8fdb068d7a Fix default perm for apt_repo files. (#4072)
Change the file mode arg to 'raw' ala file args

Following the file_common_args model, change the
type of the 'mode' arg here to type='raw' with no
default arg value.

The default mode for file creation is the module
constant DEFAULT_SOURCES_PER, and is used if no
mode os specified.

A default mode of 0644 (and not specified as int or str)
would get converted to an octal 420, resulting in the
sources file being created with mode '0420' instead of '0644'

Fixes #16370
2016-07-01 13:10:32 -04:00
Michael LoSapio
e626803882 Showing some of the sysctl settings in proper yaml format per Ansible documentation (#4073) 2016-06-30 19:27:41 -04:00
Lukas Grossar
49bf8de27c also match on tabs in ini_file (fixes #106) (#4067)
also match on tabs in ini_file
2016-06-30 18:15:49 -04:00
Matt Davis
0ee7b9896d Merge pull request #4080 from talonx/devel
Fix for #16518 - added missing regions
2016-06-30 13:23:10 -07:00
Ryan Brown
4845c96b00 Remove double-assignment of EC2 parameters (#4081)
The `source_dest_check` and `termination_protection` variables are being
assigned twice in ec2.py, likely due to an incorrect merge somewhere
along the line.
2016-06-30 09:47:06 -04:00
Hrishikesh Barua
718471e302 Fix for #16518 - added missing regions 2016-06-30 17:53:15 +05:30
nitzmahone
1d0d5db97a fixes to windows setup
coerce multi-socket win32_processor to a single value
WindowsIdentity.Label doesn't exist on .NET 4.0
2016-06-29 17:32:52 -07:00
David Shrewsbury
4e239f6ce0 Use os.rename() in async_wrapper
Because the async_status module will read from the same file that
the async_wrapper module is writing, it's possible that the file
may not be fully synced during a read, causing spurious failures.
Use a temp file to do an atomic operation on the file. We can't
use atomic_move() here as that doesn't work properly under async.

Also, let's not read concurrently from the same file the subprocess
is writing to. Instead, capture stdout/stderr via PIPE and write to
the file to avoid nasty races.
2016-06-29 09:53:47 -04:00
Brian Coca
2f0f04437b made password no_log in htpasswd 2016-06-28 10:21:45 -04:00
Toshio Kuratomi
41adb78cab A few more sanity checks for detecting unzip output that's not a file entry (#3982)
* A few more sanity checks for detecting unzip output that's not a file entry

Also note that there's a rounding error somewhere in the mtime
comparison code.

* Fix reference to sub-array
2016-06-27 13:18:12 -07:00
Matt Davis
3c6f2c2db1 Merge pull request #3777 from dagwieers/win_setup-updates
win_setup: Add missing properties
2016-06-27 08:58:24 -07:00
Brian Coca
77b4a0367c updated docs in pause to reflect 0 value behaviour 2016-06-27 09:36:10 -04:00
Dag Wieers
1e1b5c6597 Comment out $win32_cs.SystemFamily, cfr. @nitzmahone
Since it fails on everything pre-10/2016
2016-06-27 00:29:14 +02:00
Qi Luo
93e502f019 Fix getting actual_stdin_open 2016-06-24 18:58:21 -07:00
Peter Sprygada
530ee87bd3 Merge pull request #4031 from stianvi/devel
Fixed delete statement for juniper_config.py #4007 #3984
2016-06-24 07:34:45 -07:00
Stian Vikan
1e74d4c9a6 Fixed delete statement for juniper_config.py #4007 #3984 2016-06-24 16:06:25 +02:00
Shubham
9443d9b19a Fix broken link for issue template (#3680) 2016-06-23 19:51:45 -04:00
Matt Davis
4fe583e29b Merge pull request #3747 from mixmatch/devel
fixed $source null check, reference to $Params
2016-06-22 11:49:33 -07:00
Brian Coca
5380812b36 removed extra space
as pointed out by @lloydbenson
2016-06-22 12:31:52 -04:00
jctanner
d6a834efa0 Cleanup unused variable in yum.py (#4009) 2016-06-22 09:30:37 -04:00
Erik Nadel
abaaf3e797 apt remove now recognizes the force parameter (#3756) 2016-06-22 07:56:09 +02:00
Graham Goldstein
4f8f0cf66b Change documented options for os_networks_facts (#3970)
* Change documented options for os_networks_facts

os_network_facts currently lists 'network' as an available option, taking the Name or ID. In Ansible 2.0.2 to 2.2.0, this is not valid. Options 'name' and 'id' should be used instead.

* Update os_networks_facts.py

* Update os_networks_facts.py

Set version_added to the only accepted value

* Update os_networks_facts.py

Removed inappropriate 'ID' parameter
2016-06-22 07:52:00 +02:00
mattymo
1f73bef856 Add retries to apt_key with keyserver, fixes #3986 (#3987)
Public SKS gpg servers frequently are unavailable, but a retry
can mitigate frequent failures.
2016-06-22 07:42:44 +02:00
jctanner
71d320ff18 Add local and url support to yum state=latest (#4003)
Fixes #3807
2016-06-21 20:59:17 -04:00
Ryan Brown
47e22248c4 Merge pull request #3091 from jmunhoz/s3-ceph
Add Ceph RGW S3 compatibility
2016-06-21 15:34:59 -04:00
jctanner
780c52d8a4 Add a note about using the script module with pseudo-tty's lack of stderr channel (#4000)
Addresses #3610
2016-06-21 13:09:54 -04:00
Toshio Kuratomi
2ecf9987bf Add comment 2016-06-21 09:25:55 -07:00
Marius Gedminas
0cd9497748 git: fix change testing when version is HEAD (#3025)
When `version` is not specified, it defaults to "HEAD".  "HEAD" is not a
remote tag, and it's not listed in the output of get_branches(), so we'd
keep repo_updated at the default value (None) and then return early with
changed=True in --check mode, even when before == after.

Fixes #3024.
2016-06-21 09:22:53 -07:00
Chris Houseknecht
75d167e34f Merge pull request #3994 from chouseknecht/fix_ulimit
Fix ulimit comparison
2016-06-21 11:35:31 -04:00
Chris Houseknecht
173d1f96eb Merge pull request #3995 from chouseknecht/fix_3978
Fix compose_version error. Check has compose before checking version.
2016-06-21 11:34:37 -04:00
Javier M. Mellid
a88d6d9a53 Add s3_url requirement in doc when rgw support is enabled in s3.py
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
2016-06-21 10:53:47 +02:00
Javier M. Mellid
a52ff221f7 Add proper version_added for rgw option in s3.py
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
2016-06-21 10:53:41 +02:00
Javier M. Mellid
b1724344d5 Add Ceph RGW S3 compatibility
Ceph Object Gateway (Ceph RGW) is an object storage interface built on top of
librados to provide applications with a RESTful gateway to Ceph Storage
Clusters:

http://docs.ceph.com/docs/master/radosgw/

This patch adds the required bits to use the RGW S3 RESTful API properly.

Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
2016-06-21 10:53:36 +02:00
chouseknecht
7f97cf4d04
Fix compose_version error. Check has compose before checking version. 2016-06-21 02:49:22 -04:00
chouseknecht
34305ded28 Fix index 2016-06-21 02:26:03 -04:00
chouseknecht
5f9f1642bc
Fix ulimit comparison 2016-06-21 02:20:50 -04:00
Allen Sanabria
343c3ecfb9 Fixes #1715 Allow authorized_module accept multi. (#3573)
This will allow the authorized_module to accept options that can be
passed multiple times into ssh options. For instance permitopen.
2016-06-20 17:32:44 -04:00
Mario David
ae5ccf29ed add project to os_router (#3869)
* add project to os_router

* version_added fix

* correct place of version_added

* remove extraneous else

* * add shade version dependency check
* option project only on router creation

* * fix shade minimal version
* remove pop of option project

* * fix square brackets
* delete router by router_id
2016-06-20 10:10:59 -04:00
Stanislav Antic
f0f5272f90 Fix wait_for on python < 2.6 (#3790) (#3973) 2016-06-17 10:04:26 -04:00
Brian Coca
a1e6311197 reverted need for module utils imports 2016-06-16 18:12:38 -04:00
Matt Davis
b2b5fceea2 Merge pull request #3965 from ewigkeit1204/fix-copy-module
Do not copy file if running on check mode
2016-06-16 12:58:06 -07:00
Brian Coca
ab4ec24813 added missing import
readded raise
2016-06-16 15:55:45 -04:00
Brian Coca
4a0c483e09 exception ans sys.exit fixes 2016-06-16 15:27:37 -04:00
Toshio Kuratomi
f9b28aaae3 Fix exception handling in async_wrapper 2016-06-16 12:21:57 -07:00
Keisuke Kamada
74864c2d85 Do not copy file if running on check mode 2016-06-17 02:19:52 +09:00
Adam Butler
1c41b6fdb2 Fixes incorrect key name protocols -> protocol (#3963) 2016-06-16 10:04:05 -04:00
nitzmahone
d4eaeac8c9 StrictMode fixes for win_get_url 2016-06-15 14:46:56 -07:00
Brian Coca
949916a155 restored incorrectly removed docs, jinja2 override 2016-06-15 17:01:46 -04:00
Hagen Kuehn
a5fdd8c128 fixed unknown type <type 'list'> error (#3959) 2016-06-15 14:26:00 -04:00
Brano Zarnovican
3456c24b96 Py2.4: SystemExit in async_wrapper is not an error - compatibility fix
Prior to Python 2.5, SystemExit was a subclass of Exception.
In Py2.4, this is causing extra error output on valid sys.exit(0).

(Toshio) Call sys.exit from inside of the SystemExit exception handler so py2.4 and py2.5+ behaviour matches
2016-06-15 10:28:09 -07:00