Commit graph

573 commits

Author SHA1 Message Date
Sébastien Gross
e0f7b3f39c [mount] make sure fstab exists
This is mainly to prevent from failing with no such file or directory
during module execution.
2014-07-21 18:32:02 +02:00
Sébastien Gross
806052a9e5 [mount] Add documentation for fstab option 2014-07-21 18:30:59 +02:00
Hector Acosta
60edb6b04b Add check_mode support to authorized_key. Fixes #7300
Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
2014-07-19 17:55:58 -05:00
Yasser Nabi
8cc894bef2 Enable puppet facts
Currently facter facts omit facts that a distributed via Puppet. This
commit adds the `--puppet` option.

In cases where puppet is not installed, the command sends a warning to
STDERR *but* completes successfully. So should not cause any issues.

The benefit is, filtering can be done based on facts set by Puppet.
2014-07-17 17:53:12 +01:00
Michael DeHaan
96fe275946 Merge pull request #8139 from peterkh/devel
Fix "TypeError: group id must be integer" if groupid passed in for group key
2014-07-16 15:55:14 -04:00
Ruggero Marchei
ae95ebd075 fix LooseVersion exception with empty distribution_version 2014-07-16 07:55:20 +02:00
Peter Hall
ae67002c15 Fix "TypeError: group id must be integer" if groupid passed in for group
key
2014-07-15 11:16:47 +10:00
Ruggero Marchei
8d01986617 fix issue #8102 2014-07-15 01:26:44 +02:00
Cristian Ciupitu
72d6e6d805 Remove useless code 2014-07-09 23:11:15 +03:00
Michael Leer
39b34b008c add interfact documentation #7704 2014-07-01 18:49:07 +01:00
Prune
afb358af77 added missing force flag on mkfs commandline
even if the option ```force=yes``` is used in the playbook, it is not reflected in the mkfs command line.
As force option is dependent of the fs type, a "if-then-else" case have been added. Also, some FS types does not have a force option.
2014-07-01 15:09:39 +02:00
Markus Amalthea Magnuson
a58709ac1d Use correct parameter name in error message.
The parameter is called `cron_file` but the error message uses `file` which is confusing.
2014-06-27 14:53:54 +02:00
James Cammarata
936daf6f63 Updating the other classes in the group module to match #7249 2014-06-24 12:28:43 -05:00
James Cammarata
4ca9ebf084 Merge pull request #7249 from jfchevrette/implement-group-checking-if-state-present
Allow group module to handle check_mode properly when group.state=present and group already exists
2014-06-24 12:27:31 -05:00
James Cammarata
236a2989cc Merge branch 'lvg_dm_names' of https://github.com/ajsalminen/ansible into ajsalminen-lvg_dm_names 2014-06-20 13:24:07 -05:00
James Cammarata
ad4926e090 Update authors for modprobe module 2014-06-20 11:12:49 -05:00
James Cammarata
974693882e Merge branch 'add_name' of https://github.com/stygstra/ansible into stygstra-add_name 2014-06-20 11:12:24 -05:00
James Cammarata
6ad83bb5ce Merge branch 'devel' of https://github.com/tgolly/ansible into tgolly-devel 2014-06-19 22:41:58 -05:00
Michael DeHaan
4fbc2a83e0 Merge pull request #7861 from cchurch/devel
Windows Remote Support
2014-06-19 22:10:41 -05:00
David Stygstra
cae41d0931 Added author and copyright lines to modules I contributed 2014-06-19 20:02:02 -04:00
Michael DeHaan
8b262d775b Slight tweak to windows wording. 2014-06-19 14:24:15 -05:00
Matt Martz
cab68bc579 Mention that with windows target hosts, fact_path and filter are not currently supported 2014-06-19 14:24:14 -05:00
James Cammarata
2c22cf46cf Merge branch '7763' of https://github.com/rmarchei/ansible into rmarchei-7763 2014-06-18 12:16:01 -05:00
James Cammarata
34405ea905 Merge branch 'lvg_fix' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-lvg_fix 2014-06-18 09:00:41 -05:00
Ilya Rusalowski
b1a31ebb84 Set default vg_options to empty string 2014-06-17 20:42:18 +04:00
Ruggero Marchei
f522425415 move get_distribution_version() to basic.py 2014-06-17 10:22:14 +02:00
Ruggero Marchei
bd69e9f265 use different strategy for RHEL >= 7. Fixes 7763 2014-06-14 19:29:04 +02:00
James Cammarata
d35d5ac9d1 Merge pull request #7741 from mgcrea/devel
Add support for Linaro distribution in hostname module
2014-06-12 08:58:56 -05:00
James Cammarata
3e04d8c70c Merge pull request #7737 from toddmowen/zfs-fix-7696
zfs: fix incompatibility - share.nfs vs sharenfs (issue #7696)
2014-06-12 08:53:21 -05:00
Olivier Louvignes
158d6276eb Add support for Linaro distribution in hostname module 2014-06-12 12:06:59 +02:00
Todd Owen
34517b0836 zfs: work around incompatibility by renaming share.nfs to sharenfs
Fixes #7696
2014-06-12 16:21:16 +08:00
rgbkrk
5591e8838d Error checking and reporting on interface ufw rule 2014-06-11 11:10:38 -05:00
Ron Gomes
73246a49dc Fix incorrect argument ordering in error message, which provokes a
printf-related TypeError.
2014-06-09 15:03:51 -04:00
Yann Coleu
f378ed643c Add primary group in the first user module doc example 2014-06-02 14:32:52 +02:00
Nicolas Brisac
ecda1455bf open_iscsi module: support RC 21 when listing logged-in target 2014-05-24 18:14:28 +02:00
Brian Coca
5c87e97a45 now module searches for update-alternatives vs hardcoding it 2014-05-20 22:51:27 -04:00
James Cammarata
3a8ebd4325 Pull the link out of the alternatives output when not specified
Fixes #7414
2014-05-16 14:44:31 -05:00
Adam Chainz
6b10cf756a Fix grammar and value errors in cron documentation 2014-05-09 15:19:42 +01:00
Luca Berruti
eca36953c8 Make alternatives module python 5 compatible 2014-05-08 14:46:49 +02:00
Jean-Francois Chevrette
8756612599 this should return 0 to indicate a non-failure when check_mode is True 2014-05-07 10:20:51 -04:00
Antti Salminen
a6b482c500 Switch to mapper device name if pvs returns the wrong one. 2014-05-03 10:36:22 +03:00
Carlos E. Garcia
4dcaa9d9fb multiple spelling error changes 2014-04-29 10:41:05 -04:00
Michael Scherer
4ed4bfff90 Do not fail if we try to generate a ssh key for a user without being root
If we try to use the user module without being root, it fail on RHEL/Fedora
because usermod --help cannot be run. The root cause is lack of permission
due to EAL4+ certification, as seen in shadow-utils changelo.

So if we cannot run it, assume there is no append. It doesn't matter
much since we will not be able to run usermod at all with or without the
option.
2014-04-28 12:29:57 +02:00
Chris Lamb
b123b648a0 Correct/update debconf examples - need to specify vtype.
Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
2014-04-23 21:51:01 +01:00
Michael Scherer
cf3365b99e Add a better error message for service
While migrating my playbook to a newer ansible version, I faced
the error message "unknown init system, cannot enable service". It turned
out to be caused by a wrong service name that was not expanded anymore.

So by giving the name of the service that cannot be enabled and a more precise
reason, i think people will be able to diagnose their issue more easily.
2014-04-22 09:13:57 +02:00
Hernandes B. de Sousa
780b5e0bbf Add missing info for the append option
Both 'default' and 'choices' options were missing at the documentation.
2014-04-16 01:22:12 -03:00
James Cammarata
0c96e2f33b Check to make sure the firewalld client is connected before proceeding
Fixes #6911
2014-04-15 15:03:52 -05:00
Jonathan Davila
a90aa46ed2 Added example demonstrating other functionality 2014-04-11 11:14:40 -04:00
James Tanner
0025273fca Fixes syntax error in cron module caused by #6870 2014-04-08 12:53:56 -04:00
Eric Lake
58dccfbc29 Adding bold to service doc to call up state and enabled. 2014-04-07 09:37:15 -05:00
MorrisA
ac72d44219 Modified Cron to add AIX Crontab support, changed according to suggestions
from mpdehaan and redone entirely.
2014-04-05 18:10:45 -07:00
Serge van Ginderachter
867702b26a lvg module bugfix on vg_options patch
When no vg_options are passed to the module, 'vg_options' still exists
in the module.params dict with a value of None, so the default empty string in
the get method is never used. None cannot be "splitted", which backtraced.
2014-04-04 15:32:35 +02:00
Michael DeHaan
3d8997d219 Name is not required, update docs. 2014-04-03 18:03:13 -04:00
Michael DeHaan
7258c15ce1 Merge pull request #6831 from aresch/patch-1
Fix _parse_value always returning 0 when not true, false or None.
2014-04-02 20:09:41 -04:00
Andrew Resch
32e5383bef Fix _parse_value always returning 0 when not true, false or None. 2014-04-02 15:59:05 -07:00
Joshua Lund
74962a0e35 Update cron module documentation. The 'name' parameter is required. 2014-04-02 16:41:09 -06:00
Michael DeHaan
5826e1354a Slightly revise wording. 2014-04-02 17:43:40 -04:00
Michael DeHaan
ff2177442b Merge branch 'authorized_key-manage_dir' of git://github.com/tyll/ansible into devel 2014-04-02 17:42:24 -04:00
Michael DeHaan
4917f4a48f Merge pull request #6810 from bob-smith/debconf-text
debconf detail requirements and fix typos
2014-04-02 17:25:22 -04:00
James Cammarata
57adad7097 Fix issue with sysctl parameter parsing introduced by 0e8c7b1
Fixes #6806
2014-04-02 15:26:02 -05:00
Michael DeHaan
05551cfe51 Merge pull request #6826 from bob-smith/debconf-parsing
debconf correctly quote strings
2014-04-02 16:14:17 -04:00
James Cammarata
09c998f104 Fixing some parsing issues in authorized_key module
Also adds an integration test for authorized_key for future validation.

Fixes #6700
2014-04-02 15:02:54 -05:00
John Barker
ed4717a978 debconf correctly quote strings 2014-04-02 20:43:12 +01:00
John Barker
e4a779d4dd debconf detail requirements and fix typos 2014-04-01 21:51:12 +01:00
Tim G
32d48d75e9 Bugfix, fix crontab commands on HP-UX 2014-04-01 21:09:08 +10:00
Michael Scherer
ba9f910ec9 fix typo in the capabilities module description 2014-03-30 22:33:24 +02:00
Adam Nielsen
b35086c7a3 More descriptive error message if init system is unknown 2014-03-30 11:46:13 +10:00
Ahti Kitsik
74fa705e20 Bugfix for ufw to support "logging" properly:
It's a separate parameter so updated docs and set it as mutually exclusive param.
Also due to an array construction typo it was not working in any situation (ufw LOGLEVEL was passed to cmd instead of ufw logging LOGLEVEL).

Also fixed doc and parameters parsing typo ("choises" should be "choices")
2014-03-29 11:06:51 +02:00
Michael DeHaan
85320532d4 Rename vgoptions to vg_options. 2014-03-28 12:53:36 -04:00
Michael DeHaan
07423c1714 Merge branch 'devel' of git://github.com/chamill/ansible into devel
Conflicts:
	library/system/lvg
2014-03-28 12:53:00 -04:00
Michael DeHaan
9fa0ec57fb Scrub choices=BOOLEANS from remaining core module references. Correct form in argument_spec is type='dict'. 2014-03-28 11:41:35 -04:00
Michael DeHaan
073d34b40e Merge pull request #6524 from tyll/update_rc_d_disable
service module: Properly disable Debian services
2014-03-28 11:10:46 -04:00
Michael DeHaan
d3d1c8ce9a Merge pull request #6630 from bigl0af/devel
Modified library/system/user so that password change date is set on Sola...
2014-03-28 10:57:59 -04:00
Michael DeHaan
1e747e00e5 Merge pull request #6296 from jdauphant/devel
Add linux module parameters for the modprobe module
2014-03-27 17:12:21 -04:00
Cristian Ciupitu
7a4270184a Micro-optimization: replace s.find(x)==0 with s.startswith(x)
timeit shows a speedup of ~1.4x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
2014-03-27 20:35:20 +02:00
Ahti Kitsik
c757b6624f Fixed ufw module doc tags, it's reset everywhere, not reseted. 2014-03-27 17:22:39 +02:00
Seth Woodworth
21b7c358ee adds missing ' to debconf examples 2014-03-23 18:52:08 -04:00
Pierre-Louis Bonicoli
9a140881be Fix ValueError when selection contains a colon 2014-03-23 03:35:10 +01:00
David Fox
01acd73e30 Modified library/system/user so that password change date is set on Solaris when updating password 2014-03-22 15:12:56 -04:00
Till Maas
35f9e62422 service module: Properly disable Debian services
Services on Debian need to be disabled with 'disable' instead of 'remove'
to avoid them being enabled again when 'update-rc.d $service defaults' is run,
e.g. as part of a postinst script.
2014-03-20 09:19:42 +01:00
Till Maas
a063987d0e authorized_key: Be more specific about manage_dir
- Explain which properties are managed when manage_dir is True.
2014-03-20 09:15:59 +01:00
Michael DeHaan
7f36630dd5 Add capabilities module. 2014-03-19 17:48:17 -04:00
nate@bx.psu.edu
2daee9ed20 Bugfix for xattrless files and the capabilities module. 2014-03-19 17:48:17 -04:00
nate@bx.psu.edu
c19e4a7d0b Create a capabilities module for managing Linux kernel capabilities(7) with setcap(8). 2014-03-19 17:48:17 -04:00
James Cammarata
9f9c077878 Merge branch 'issues/6341' of https://github.com/threatgrid/ansible into threatgrid-issues/6341 2014-03-18 10:46:39 -05:00
James Tanner
4028f55c04 Fixes #6519 Properly handle state=absent in sysctl module 2014-03-18 09:30:21 -04:00
Michael DeHaan
ba99056948 Version bump for alternatives module, changelog. 2014-03-16 16:54:57 -04:00
Gabe Mulley
4c132c11f7 add a module for update-alternatives 2014-03-16 16:54:57 -04:00
Michael DeHaan
29a3a1d516 Move facts to 'module_utils' so they can be referenced by other modules. Note unlike other module_utils/ dirs this keeps the original
license -- so usage of facts code in modules will be limited to GPLv3 modules.
2014-03-16 16:12:02 -04:00
Michael DeHaan
c914e9e462 Update setup module signature from merge commit. 2014-03-16 14:11:43 -04:00
Michael DeHaan
cac81b1ad9 Merge pull request #6339 from threatgrid/systemd-template-svc-fix
systemd template services must not discard template part
2014-03-16 12:40:44 -05:00
Michael DeHaan
790a38e25d Merge conflict. 2014-03-16 13:36:52 -04:00
Michael DeHaan
201297cbfe Merge pull request #6175 from AdmiralNemo/fix-filesystem
filesystem: Ignore blkid cache
2014-03-16 12:31:53 -05:00
Michael DeHaan
d4de77fd45 Merge pull request #6097 from mattjeffery/bug/modprobe_normalise_name
Normalise the module name when comparing against the module names in /proc/modules
2014-03-16 12:31:17 -05:00
Michael DeHaan
bf33be20e1 Merge pull request #6005 from pgehres/chkconfig
Adding better failure output for chkconfig failures
2014-03-16 12:27:46 -05:00
Cristian Ciupitu
a416dba3d1 hostname module: don't filter hostnamectl with awk
There's no need to filter hostnamectl's output with awk because its man
page says:

    hostnamectl [OPTIONS...] {COMMAND}

       --static, --transient, --pretty
	   If status is used (or no explicit command is given) and one
	   of those fields is given, hostnamectl will print out just
           this selected hostname.

E.g. hostnamectl --static status => ansible.example.org
2014-03-16 13:10:28 -04:00
Cristian Ciupitu
7f681c33a2 Micro-optimization: replace s.find(x)!=-1 with x in s
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
2014-03-16 13:10:28 -04:00
James Tanner
59fb47ae9a Fixes #6482 Check sysctl file path and catch read exceptions 2014-03-14 11:16:45 -04:00
Michael DeHaan
29138b1872 More shell updates 2014-03-12 17:31:00 -04:00
Richard C Isaacson
9e9f43272a setup module: Mark unsafe commands as use_unsafe_shell=True. 2014-03-12 11:13:20 -05:00