Commit graph

184 commits

Author SHA1 Message Date
jctanner
6cebfccd7f Merge pull request #4440 from AndydeCleyre/patch-2
Set default of 'yes' for update_cache, as is in the documentation
2013-11-07 06:46:13 -08:00
jctanner
8b774f27c2 Merge pull request #4786 from SalesSeek/find-correct-easy-install
Fix determination of correct, possibly customized, 'easy_install' executable
2013-11-06 07:39:19 -08:00
James Tanner
65d68bb1b4 Addresses #4735 Verify the virtualenv command supports --no-site-packages before passing it 2013-11-05 18:51:41 -05:00
Pedro Romano
78c616f271 Obsolete attempts at determining the full path to the desired
'easy_install' executable were still left behind and need to be removed
for the customizable 'executable' task argument to correctly work:
'_get_easy_install' should take care of all the functionality related to
determining the correct 'easy_install' executable to use.
2013-11-02 19:25:51 +00:00
chrisalbright
44c2fae805 pip module: fix unexpected behavior when creating virtualenvs
This module supports `virtualenv_site_packages` as an option to control whether or not to include system packages when installing pip packages into a virtual environment. 

The default is no, and when you say yes it explicitly it includes a flag to include site packages, otherwise it doesn't provide a flag. 

Some versions of virtualenv by default include site packages and other versions by default do not. 

This patch just makes both branches explicit, so `virtualenv_site_packages=no` really means no.
2013-10-30 17:27:02 -07:00
Marcus Cobden
414a5b4eab Only remove leading '0x' from key ids, not all 0s 2013-10-30 11:50:34 +00:00
Thomas Omans
c12e2b53e3 Pip module: fixing issue with python 2.4 support
Python 2.4.3 returns:
TypeError: expected character buffer object

startswith is expecting only a string instead of a tuple like newer versions allow.
2013-10-28 15:15:04 -07:00
Michael DeHaan
3722bebb1d Merge pull request #4509 from mremond/gem_executable
Add executable parameter to find gem binary in gem module
2013-10-27 08:59:19 -07:00
Michael DeHaan
21d4400c96 Misc pep8 fixes 2013-10-19 13:03:15 -04:00
Jimmy Tang
0568abeb14 check for ubuntu distribution first 2013-10-19 14:41:00 +01:00
Michael Scherer
19bb44288e fix distribution detection in apt_repository module, so it also work
on Mint as it work on Debian, fix #4587.

PPAs are not supported however, since that's a Ubuntu specific feature
and mint is detected as a generic distribution and use a different
codename than the Ubuntu release it is based on, which mean that apt_repository
cannot add detect and add the proper url without a better heuristic.
2013-10-19 00:57:08 +02:00
Maykel Moya
2592b2c3f9 Do key validation only when key is provided
key_id is optional, the previous code didn't handle the case of key_id
not specified
2013-10-17 12:04:04 +02:00
Maykel Moya
1a79d9ae58 apt_key: Validate key_id and accept a leading '0x' 2013-10-16 20:52:18 +02:00
James Tanner
00f3ec645d Fixes #4532 Send easy_install to get_bin_path instead of None 2013-10-15 18:15:08 -04:00
James Tanner
7061c99049 fix indentation in easy_install module docstring 2013-10-15 12:49:43 -04:00
Mickaël Rémond
007a3fe154 Add executable parameter to find gem binary in gem module
This is especially needed with rvm where gem binary can be in unusual locations
2013-10-15 09:08:33 +02:00
Michael DeHaan
8349c04d06 Merge pull request #4488 from renanivo/devel
create install_options parameter for homebrew module
2013-10-14 16:47:59 -07:00
Pedro Romano
e6062db92f Implement a '_get_easy_install' helper function to find the desired
'easy_install' executable, modeled on '_get_pip'
from the 'pip' module to correctly handle all combinations of explicit
executable and virtualenv.
2013-10-14 11:48:45 -04:00
Pedro Romano
307dd77589 Refactor helper function '_get_pip' to handle the cases where an absolute
path explicit executable is passed to the task and to look for an explicit executable
by basename in a virtualenv if that is specified.
2013-10-14 11:48:28 -04:00
Pedro Romano
57a71043a3 New module argument to specify the executable used for running 'pip'. This allows support for system installation of packages on systems with multiple installations of Python. 2013-10-14 11:48:28 -04:00
Pedro Romano
3c33273071 New module argument to specify the executable used for running 'easy_install'. This allows support for system installation of packages on systems with multiple installations of Python. 2013-10-14 11:48:27 -04:00
Pedro Romano
48e50a9c11 Rename copy/pasted variables more appropriately. 2013-10-14 11:47:59 -04:00
Pedro Romano
5a5d431fa1 Changes examples from using Flask to some other package (Bottle was chosen) as per @mpdehaan's suggestion. 2013-10-14 11:47:59 -04:00
Jurrien Bloemen
55062c69d6 Added full path to rhnreg_ks command for working correctly with sudo. 2013-10-14 16:05:01 +02:00
Renan Ivo
776de30e6d update version_added of homebrew module 2013-10-13 15:32:51 -03:00
Renan Ivo
488fb484b7 set default options value to None in homebrew module 2013-10-13 10:42:12 -03:00
Renan Ivo
dd1b44acd5 create install_options parameter to homebrew module 2013-10-13 10:24:07 -03:00
Jimmy Tang
a4c8d3ee68 This oneliner change allows apt-key to inherit the http_proxy variable.
Before this fix

  TASK: [apt_repository repo='ppa:vbernat/haproxy-1.5'] *************************
  failed: [134.226.115.202] => {"cmd": ["apt-key", "adv", "--recv-keys", "--keyserver", "keyserver.ubuntu.com", "CFFB779AADC995E4F350A060505D97A41C61B9CD"], "failed": true, "rc": 2}
  stderr: gpg: requesting key 1C61B9CD from hkp server keyserver.ubuntu.com
  gpg: no valid OpenPGP data found.
  gpg: Total number processed: 0

After the fix

  TASK: [apt_repository repo='ppa:vbernat/haproxy-1.5'] *************************
  changed: [134.226.115.202]
2013-10-11 15:19:52 +01:00
Michael DeHaan
119b6d73dd Remove examples of module antipattern of setting the choices array for boolean types. 2013-10-11 08:45:13 -04:00
Andy Kluger
5ce29734d2 Set default of 'yes' for update_cache, as is in the documentation 2013-10-10 17:18:06 -04:00
Michael DeHaan
8d16a39af9 Correct typo 2013-10-10 09:15:04 -04:00
Michael DeHaan
0e55bd892d For values that are booleans in the module doc, the value in the doc section should be a boolean or truthiness
is engaged in the documentation formatting.  This fixes the update_cache default in the docs to the proper
value of "no"
2013-10-09 07:52:23 -04:00
Michael DeHaan
203a4f10cd Use explicit boolean defaults in apt module to make the code more clear. 2013-10-09 07:47:24 -04:00
Michael DeHaan
a8902e878c Merge pull request #4347 from sashka/devel
Remove options and protocols in source line with regex.
2013-10-07 05:55:43 -07:00
Michael DeHaan
8dae9fa5e7 Fix module formatting in the pkgutil module. 2013-10-07 08:24:02 -04:00
Alexander Saltanov
2bd6c5e262 Remove options and protocols in source line with regex.
Fixes #4311
2013-10-03 03:31:04 +04:00
Andy Kluger
ee054a491a Fix for Issue #2470 - gem version string processing
This fix assumes that no sane gem version has spaces in it, so when one like that is encountered, it will get truncated at the first space.
2013-10-02 17:55:30 -04:00
Pieter Avonts
60d8f92b3c changed deprecated channel_label attribute 2013-09-20 12:58:43 +02:00
René Moser
ccf4cf1dd8 Fixed missing required package in notes. 2013-09-19 19:34:15 +02:00
James Cammarata
022918e5af Merge branch 'fix/apt_repository_update_cache' of https://github.com/resmo/ansible into resmo-fix/apt_repository_update_cache 2013-09-18 12:40:39 -05:00
René Moser
9fccf96d61 apt_repository: added option update_cache.
The default behavior is to update_cache if changed.

If you add more then one repo, you may not want to update cache for every repo separately.
So you can now disable update_cache with this new option e.g. update_cache=no

Updating cache can also be handled using the apt module.
2013-09-18 19:14:08 +02:00
René Moser
a991b62a51 apt_repository: fix update cache after state=changed. Closes GH-4136 2013-09-18 11:47:39 +02:00
James Cammarata
671eeb65b2 Merge pull request #4138 from resmo/fix/redundant-fail-json
apt: fixed duplicate fail_json
2013-09-17 06:08:51 -07:00
Rene Moser
9449d62fb2 apt: fixed duplicate fail_json 2013-09-17 15:05:20 +02:00
James Cammarata
c6fdb85d88 Merge branch 'issue_3421_apt_pkg_iU' into devel 2013-09-16 06:54:05 -05:00
Michael DeHaan
00c0770f1b Merge pull request #4075 from sayap/easy_install
Locate easy_install path after (optionally) creating virtualenv.
2013-09-15 09:29:51 -07:00
James Cammarata
0d408ff295 Use low-level package objects in the apt module to check installed state
Packages which are half-installed are not adequately represented by
the .is_installed field of the apt.package.Package object. By using the
lower-level apt_pkg.Package object (which provides the .current_state
field), we can check for a partially-installed state more accurately.

Fixes #3421
2013-09-11 23:33:59 -05:00
Hiroaki Nakamura
4d2c2a262a Add an example for installing a group with the yum module. 2013-09-11 02:14:16 +09:00
Hiroaki Nakamura
caa68746ae Fix to getchanged correctly for yum groupinstall. 2013-09-11 02:10:53 +09:00
Yap Sok Ann
498c2665de Locate easy_install path after (optionally) creating virtualenv.
Without this, the first call to the easy_install module with a new virtualenv
will only create the virtualenv without installing the intended package, since
the `_is_package_installed` check will succeed as running /usr/bin/easy_install
as non-root user will return permission denied error with empty stdout.
2013-09-10 11:22:06 +08:00