Commit graph

26950 commits

Author SHA1 Message Date
Anil Kumar Muraleedharan
d9a1c8954f Coverity Bug Fix for cnos_vrf.py (#55954)
* Coverity Bug Fix for cnos_vrf.py

* Update cnos_vrf.py
2019-05-01 10:57:04 -04:00
Todd Bowman
6610d678f8 Add vrf option to static routes (#55298)
* added vrf to static route

* fix pylint errors

* version added 2.9 for vrf

* removed undocmented return values

* Update README.rst
2019-05-01 10:55:09 -04:00
Brian Coca
ea57377ddf correct method docs (#55961) 2019-05-01 09:13:57 -05:00
Matthew Davis
0b002203b4 clarify docs for rel src state hard (#55972) 2019-05-01 07:17:30 -05:00
Jordan Borean
cc3b8b9f72
win_acl - fix network path qualifier parsing (#55970) 2019-05-01 17:21:26 +10:00
Jordan Borean
5228133d74
Ansible.Basic - fix when deserialising a json string of an array (#55691)
* Ansible.Basic - fix when deserialising a json string of an array

* Added changelog fragment
2019-05-01 11:08:23 +10:00
jhawkesworth
0e8a77520c Refactor of win_xml (2nd attempt) to add support for processing multiple nodes and counting nodes matched by xpath (#53362)
* add multi-node manipulation, delete on xpath match only and count capability to win_xml

* fix pep8 and yamllint errors identified by ci tests

* fixed bugs when handling multiple elements, multiple attribute nodes and handling for attribute nodes when using xpaths that only select attributes like //@lang.  Added more tests and tweaked documentation.

* fixed line-too-long error

* fixed trailing space errors

* trailing whitespace expunged

* bump version_added to 2.9 for new changes

* fix PSAvoidUsingPositionalParameters sanity check failure

* refix sanity check as it broke the msg return value
2019-04-30 13:19:56 -07:00
Ondra Machacek
7e3b1da33f kubevirt_vm: Add example how to use davatavolumes (#55906) 2019-04-30 14:41:49 -05:00
Stefan Horning
7cf0626d7b Fixe cloudfront_distribution module issue #45043 (#49434) 2019-04-30 12:28:55 -07:00
Martin Krizek
f37476e247 template lookup: restore variables between calls (#55126)
* template lookup: restore variables between calls

Fixes #55113

* Address issues from the review
2019-04-30 15:22:37 -04:00
Sam Doran
0e8a6e08ce Clarify documentation an reboot delay paramaters (#55934) 2019-04-30 11:28:33 -05:00
Sumit Jaiswal
7e7eced425
Commenting Cliconf support call for IOS-XR modules for Ansible 2.9 version (#55751)
* iosxr cliconf support call

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* iosxr cliconf support call

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* iosxr cliconf support call

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* iosxr cliconf support call

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* iosxr cliconf support call

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-04-30 21:20:28 +05:30
Brian Coca
45d21b6474 Fix and refix help text for CLI (#55831)
fixes #23395 giving clearer information on installed role path
  re-fixes 'home display issue' for module-path
2019-04-30 11:16:26 -04:00
Sloane Hertel
11279a909d fix combine filter using undefined vars (#55840)
* Check variables are defined before using combine filter

* Add tests for the combine filter

* Remove dependencies that should already be installed

* relocate the function to recursively check for undefined vars

add another test

* changelog
2019-04-30 11:10:19 -04:00
Xander Madsen
8cfc9e6d22 Add GetSupportedFirmwareUpdateMethods to redfish_facts/Update commands (#54268)
* Add GetSupportedFirmwareUpdateMethods to update category commands list

* Add condition when command == GetSupportedFirmwareUpdateMethods to call the forthcoming rf_utils function get_supported_firmware_update_methods

* Implement get_supporte_firmware_update_methods() in redfish_utils

* rename command to GetFirmwareUpdateCapabilities

* rename comand get_firmware_update_capabilities()

* Rename command get_firmware_update_capabilities()

* Group update protocols by the type of Action they are associated with.

* remove trailing whitespace

* Use safer method to get 'title' for each action type and its allowablevalues

* Add example to docstring for using GetFirmwareUpdateCapabilities

* fix line too long

* fix line too long and trailing whitespace

* Update redfish_utils.py

* remove trailing whitespace

* fix overindent

* Use self.update_uri instead of hard-coding '/redfish/v1' in get_firmware_update_capabilities()
2019-04-30 13:53:54 +01:00
Xander Madsen
1aec39a2d7 Add GetChassisThermals command to Chassis category of redfish_facts (#54399)
* Add GetChassisThermals command to Chassis list

* Add GetChassisThermals conditional and point to rf_utils.get_chassis_thermals() function

* Implement get_chassis_thermals() in redfish_utils

* Remove trailing whitespace

* Add more properties, including RelatedItem tto distinguish entries' contexts from each other.

* Remove trailing whitespace
2019-04-30 13:46:24 +01:00
Abhijeet Kasurde
216d8b5254
VMware: support check mode in all facts modules (#55689)
* vmware_cluster_facts
* vmware_guest_facts
* vmware_guest_snapshot_facts
* vmware_host_capability_facts
* vmware_host_package_facts
* vmware_target_canonical_facts

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-04-30 16:39:21 +05:30
Ondra Machacek
8328eaee91 ovirt_disk: Fix vm creation (#55910) 2019-04-30 06:32:54 -04:00
Brian Coca
815a375177
allow empty plays again, for now (#55878) 2019-04-29 17:59:10 -04:00
Nabeel Al-Saber
94ef24974a Update vcn module documentation (#55888) 2019-04-29 15:38:50 -05:00
Sam Doran
b3ce3fc5eb
Restore ansible --version output (#55728)
* Add custom action class for version info
* Use args from CLI as prog for ArgumentParser object
* Make prog a required parameter of create_base_parser() and update all uses to pass in the newly required parameter.
* Add unit test for checking ansible --version
* Update other related unit tests
2019-04-29 16:38:31 -04:00
zingyb
c195645575 Remove illegal basic provisioning example (#55892)
The bare minimum example in the docs (i.e. only supplying name, state, and cluster) results in the error `state is present but all of the following are missing: task_definition, desired_count`.
2019-04-29 15:36:50 -05:00
The Magician
164ceb599b Bug fixes for GCP modules (#55358) 2019-04-29 15:51:09 -04:00
The Magician
50b72ec2b5 Bug fixes for GCP modules (#55359) 2019-04-29 15:50:53 -04:00
The Magician
6193658608 Bug fixes for GCP modules (#55360) 2019-04-29 15:50:41 -04:00
The Magician
ef3607f1e7 Bug fixes for GCP modules (#55361) 2019-04-29 15:50:29 -04:00
The Magician
4a371ec84e Bug fixes for GCP modules (#55362) 2019-04-29 15:50:15 -04:00
927589452
c181e567a1 Update setup.py (#55871)
adds a note on privileges needed on BSD systems to use dmidecode
2019-04-29 11:17:50 -05:00
Andrey Klychkov
9b17346d1e PostgreSQL modules: move params mapping from main to connect_to_db() function (#55799)
* PostgreSQL modules: move params mapping from main to connect_to_db() function

* PostgreSQL modules: fix postgresql_db

* PostgreSQL modules: fixes
2019-04-29 11:29:49 +01:00
krisvasudevan
25f485f79d Update nios_member.py (#54419)
* Update nios_member.py

* Update api.py

* Update nios_member.py

* Update nios_member.py

* Update api.py
2019-04-29 14:24:54 +05:30
Martin Krizek
8e82baba4a
zfs: deprecate key=value 'option' (#55699)
* zfs: deprecate key=value 'option'

Fixes #55318

* Not needed to ignore these anymore
2019-04-29 08:07:22 +02:00
Yunge Zhu
fd2ea34444
fix cross subs vnet peering (#55854) 2019-04-28 13:07:25 +08:00
MyronFanQiu
ae7b6739ce a fix by replacing subscription with subscriptions (#55797) 2019-04-28 09:40:51 +08:00
Alexander Todorov
357dafffa4 Update ali_instance_facts examples in documentation (#55760) (#55803) 2019-04-26 11:58:28 -05:00
James Cammarata
7a46fe6693
Be sure to use the active state when checking for any_errors_fatal (#55779)
The current code was not properly checking for the active state when
checking any_errors_fatal, so if the error occurred in a sub-block
or included file it is not properly detected.

Fixes #55515
2019-04-26 10:31:30 -05:00
Brandon Handeland
1e2cbefac0 Update ec2_eip_facts.py (#53040)
Add several additional examples showing how to filter on tag, how to filter on the EIP allocation id, and how to set a fact using the output.
2019-04-26 10:12:32 -05:00
John R Barker
52a1e4a599
Fix some module author names (#55770)
* Fix some module author names

During some data analysis we noticed some typos in author lines.
2019-04-26 16:11:35 +01:00
Ondra Machacek
213501a2cc Add wait of image disk after upload (#55426) 2019-04-26 05:36:54 -04:00
Ondra Machacek
0679fbc1d9 ovirt_disk: Check if disk is attached to vm (#55767) 2019-04-26 05:25:29 -04:00
Brian Coca
05fcb8502f
options not optional for callbacks (#55660)
fixes #55305
2019-04-25 22:22:06 -04:00
Yuwei Zhou
c7bf3e035b Fix the get property (#55745) 2019-04-26 10:07:58 +08:00
John Mahowald
9c038b210b Fix template lookup description (#55557)
Previously, template lookup description was documented  as "mostly a noop".
Now,  describe that it returns template content with substituted variables.
2019-04-25 17:16:53 -05:00
zengchen
1d49313dc4 huawei: use new client (#55368) 2019-04-25 22:29:08 +02:00
Matt Clay
6fe57846d0 Revert "postgres modules: move params mapping from main to connect_to_db (#55549)"
This reverts commit 2250257809.
2019-04-25 09:38:54 -07:00
Matt Martz
2732cde031
Support using importlib on py>=3 to avoid imp deprecation (#54883)
* Support using importlib on py>=3 to avoid imp deprecation

* Add changelog fragment

* importlib coverage for py3

* Ansiballz execute should use importlib too

* recursive module_utils finder should utilize importlib too

* don't be dumb

* Fix up units

* Clean up tests

* Prefer importlib.util in plugin loader when available

* insert the module into sys.modules

* 3 before 2 for consistency

* ci_complete

* Address importlib.util.find_spec returning None
2019-04-25 10:28:18 -05:00
Martin Krizek
1a6df99aa5 apt: strip whitespaces in package names (#55750)
Fixes #55741
2019-04-25 15:29:26 +02:00
Andrey Klychkov
2250257809 postgres modules: move params mapping from main to connect_to_db (#55549)
* params mapping to connect_to_db
2019-04-25 11:38:38 +01:00
Matt Davis
03cac394cc
mark entire module result untrusted as template (#55717)
* prevents accidental templating on intra-action postprocessing of an untrusted module result
* makes the view of a module result within an action consistent with the way it would be stored for future use (eg facts, register)
2019-04-24 15:15:20 -07:00
Kevin Breit
34e9c0f3a5 Migrated path creation to custom parameters (#54278) 2019-04-24 15:14:58 -05:00
Kevin Breit
56da3825c6 meraki_content_filtering - Remove redundant API call with get_nets() (#55531)
* Remove redundant API call with get_nets()

* Add changelog fragment
2019-04-24 14:27:21 -05:00
Todd Bowman
d0ae686525 Fix for Bug#54050 (#54863)
* testing

* Fixed bug #54050

* fixed pylint issues

* removed Reamde.RST changes
2019-04-24 15:14:17 -04:00
Martin Nečas
9b339de7b6 ovirt vm clone from snapshot (#55650)
* ovirt init clone from snapshot

* ovirt snapshot update cluster

* rename srcvm to snashot_vm

* update required together syntax

* update required together sytax
2019-04-24 12:50:20 -04:00
marouim
33374094d1 Added parsing of LLDP remote port description (#54873)
* Added parsing of LLDP remote port description

* Removed whitespace on blank line.
2019-04-24 22:04:59 +05:30
Kevin Breit
7b7d6a1fef meraki_static_route - Remove unnecessary API call (#55528)
* Make module not get all nets every time it's executed with net_id

* Add changelog fragment

* Update changelogs/fragments/meraki_static_route_api_calls.yml

Co-Authored-By: kbreit <kevin.breit@kevinbreit.net>
2019-04-24 12:16:51 -04:00
decentral1se
6e9379fe11 hcloud_server: clarify further for usage of ssh_keys (#55713)
* hcloud_server: clarify further for usage of `ssh_keys`
* Make lowercase and drop plural on ssh_key description
2019-04-24 11:05:38 -05:00
Matt Davis
e38881410f caution tape on makedirs_safe (#55241)
* removed usages in winrm/psrp to be consistent with other connection plugins
2019-04-24 11:37:34 -04:00
thefaftek
3f0900f504 Update win_domain_group_membership.py (#55594)
* Update win_domain_group_membership.py by adding notes regarding a computer object and fixing a typo
2019-04-24 09:30:07 -05:00
Ken Partridge
7805be2449 Add WTI Serial Port Config module (#55102) 2019-04-24 09:53:40 -04:00
Martin Nečas
748af9db74 template add cloud init (#55379)
* template add cloud init

* template add cloud init persist doc

* remove duplicate version

* ovirt_template add sysprep

* update ovirt_template docs

* update ovirt_template examples

* update ovirt_template docs - pep8

* template remove cloud init persist
2019-04-24 09:46:33 -04:00
Martin Nečas
f5b3983aa8 ovirt_permission add group example (#55705) 2019-04-24 08:21:06 -04:00
Martin Krizek
bc9074404e ec2_instance: remove network.ebs_optimized option (#55694)
Fixes #55307
2019-04-24 07:40:48 -04:00
Martin Krizek
43712f81e5 ec2_lc: deprecate device_type option (#55697)
Fixes #55308
2019-04-24 07:00:01 -04:00
Martin Krizek
27b64d6524 ec2: deprecate device_type option (#55692)
Fixes #55306
2019-04-24 06:42:55 -04:00
Abhijeet Kasurde
cce05c1ed2
Remove redundant method (#55566)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-04-24 15:29:55 +05:30
Zim Kalinowski
8de2acb819
adding final functionapp settings (#55693) 2019-04-24 15:02:41 +08:00
Yuwei Zhou
0d3d002505 add resource group test (#55688) 2019-04-24 14:15:13 +08:00
Aaron D
204db4d044 Adding support for Azure MSI user-assigned identity (#54884)
If more than one user-assigned identity is assigned to a host, then an identifier is required to specify which credentials are retrieved.  This change uses the existing support for client_id to retrieve the user-assigned identity by client_id.
2019-04-24 14:13:09 +08:00
Lars Kellogg-Stedman
35fdae7485 spelling: temaplte -> template (#55665)
Correct a common mis-spelling of 'template' including in the return
value of the lib/ansible/modules/cloud/cloudstack/cs_template.py
module.
2019-04-24 07:06:09 +02:00
Yuwei Zhou
e77260a4fb Enable azure manged disk test (#55681) 2019-04-24 12:43:52 +08:00
Lindsay Hill
2cfaf6e80a sensu_subscription very minor docstring typo (#55675) 2019-04-23 16:42:01 -05:00
Matt Martz
863340ee26
--become-method should not be restricted (#55670) 2019-04-23 15:35:11 -05:00
Hilco Prevos
3fd27f0cac Update win_dns_record.py (#55378)
##### SUMMARY
<!--- Your description here -->
The documentation dictates the values are strings. but the examples don't show this.
This can be confusing for new people.

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-04-23 15:13:03 -05:00
René Moser
1705ef5f26
vultr_server: fix idempotency for private network and IPv6 options (#55619)
* vultr_server: fix idempotency for private network and IPv6 options

* add changelog
2019-04-23 21:22:17 +02:00
Matt Martz
db6cc60352
Migrate command line parsing to argparse (#50610)
* Start of migration to argparse

* various fixes and improvements

* Linting fixes

* Test fixes

* Fix vault_password_files

* Add PrependAction for argparse

* A bunch of additional tweak/fixes

* Fix ansible-config tests

* Fix man page generation

* linting fix

* More adhoc pattern fixes

* Add changelog fragment

* Add support for argcomplete

* Enable argcomplete global completion

* Rename PrependAction to PrependListAction to better describe what it does

* Add documentation for installing and configuring argcomplete

* Address rebase issues

* Fix display encoding for vault

* Fix line length

* Address rebase issues

* Handle rebase issues

* Use mutually exclusive group instead of handling manually

* Fix rebase issues

* Address rebase issue

* Update version added for argcomplete support

* -e must be given a value

* ci_complete
2019-04-23 13:54:39 -05:00
Matt Martz
7ee6c136fd
Update bundled copy of six from 1.11.0 to 1.12.0 (#55456)
* Update bundled copy of six from 1.11.0 to 1.12.0. Fixes #55303

* Linting fix

* ci_complete
2019-04-23 11:53:25 -05:00
Matt Martz
acc675e4a8
Update bundled copy of backports.ssl_match_hostname from 3.4.0.2 to 3.7.0.1 (#55461)
* Update bundled copy of backports.ssl_match_hostname from 3.4.0.2 to 3.7.0.1. Fixes #51794

* Address linting issues

* ci_complete
2019-04-23 11:53:11 -05:00
Matt Martz
8f2976dcee
Update bundled copy of distro from 1.3.0 to 1.4.0 (#55459)
* Update bundled copy of distro from 1.3.0 to 1.4.0. Fixes #55302

* ci_complete
2019-04-23 11:52:51 -05:00
Matt Martz
e0f30ed0ee
Update bundled copy of selectors2 from 1.1.0 to 1.1.1 (#55457)
* Update bundled copy of selectors2 from 1.1.0 to 1.1.1. Fixes #55300

* ci_complete
2019-04-23 11:52:24 -05:00
Xaroth
a9f24e097f Add ansible_parent_role_names magic variable (#46687)
-Add: Test cases for ansible_parent_role_names and ansible_parent_role_paths
-Add: ansible_parent_role_names/paths variables for when a role is being included by another role.
2019-04-23 11:55:05 -04:00
Nathaniel Case
b442706b54
Move missing library abort to use rather than import for netconf (#55384) 2019-04-23 09:19:47 -04:00
Brian Coca
780ee45819
ensure inventory plugin loading rel to play (#51177)
Ensure inventory plugin loading rel to play

  fixes #51033

*  clarify paths
* now adding dirs funciton in loader
* better warnings
* each cli should handle adding dirs depending on context
2019-04-22 19:32:50 -04:00
Sam Doran
f27eccabbd
User - Fix shadow file parsing on AIX (#55230)
Implement a new method for shadow file parsing so it can be subclassed.
2019-04-22 15:24:10 -04:00
Ken Partridge
d18beee641 Add WTI OOB and PDU Device info module (#55114) 2019-04-22 14:59:53 -04:00
Matt Clay
5311ee9efa Fix performance_insights_retention_period type. 2019-04-22 09:59:48 -07:00
Aaron Pederson
8c7e38af62 Update gcp_container_cluster_facts.py (#55475)
'state' is not a supported parameter in this module - the example failed with "Unsupported parameters for (gcp_container_cluster_facts) module"
2019-04-22 11:38:28 -05:00
Hannes Ljungberg
14c60e6ec8 docker_swarm_service: Use str type for configs/secrets gid/uid (#55591)
* Change type of secrets gid/uid to str
* Add changelog fragment

Co-Authored-By: hannseman <hannes@5monkeys.se>
2019-04-22 11:29:46 -04:00
Abhijeet Kasurde
a8c3eeaa3d rds_instance: add datatype info in documentation (#55578)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-04-22 11:07:55 -04:00
Gregor Dschung
158452661a Correct link to Thomas' GitHub account (#55587)
Thomas renamed his account from tstringer to trstringer
2019-04-22 09:37:00 -05:00
rajaspachipulusu17
19c87d829f Pluribus Networks modules handling empty output (#54971)
* Handling empty output string
* Change log fragment for PR 54971
2019-04-22 14:57:47 +05:30
Albert Siersema
5f8342bc4c "no macro" command should not be handled by edit_macro(), fixes #55212 (#55218) 2019-04-22 14:54:48 +05:30
Zim Kalinowski
71494c0bd9 fixing lb / ag replacement (#55546) 2019-04-21 22:27:08 -04:00
David Hollenberger
5bda9cbebf Add variable type for performance_insights_retention_period (#49905) 2019-04-21 12:46:42 -04:00
Abhijeet Kasurde
94f295e4a1 k8s: fix API call to _wait_for_response (#53937)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-04-20 02:22:52 -04:00
Abhijeet Kasurde
1e619c44cd
Remove redundant defined variable (#55122)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-04-20 11:34:11 +05:30
Dusan Matejka
5dcc178679 added python3 support to nginx_status_facts module (#55428) 2019-04-18 19:21:09 -04:00
Anatoly Pugachev
701cf25891 [cosmetic] solaris wwn fix (#55154)
* Solaris WWN parsing cosmetic fix (commit 924f5b5467)

* simplify module.run_command by removing use_unsafe_shell and remove calling of external grep

* add changelog fragment
2019-04-18 16:31:40 -04:00
Sloane Hertel
afb5e02c19 preserve same order as inventory manager when using host lookup (#55331)
* preserve same order as inventory manager when using inventory_hostnames lookup

add a test

* move generic code
2019-04-18 15:54:03 -04:00
Felix Fontein
c8a15b9dbc crypto modules: use module_utils.compat.ipaddress when possible (#55278)
* Use module_utils.compat.ipaddress where possible.

* Simplify reverse pointer computation.

* Use dummy for unused variables.

* Remove from ignore list.

* Adjust fix.

* Fix text handling for Python 2.

* Add changelog.
2019-04-18 15:36:53 +01:00
Alex Stephen
e298de0986 GCP deprecations (#53355)
* gcdns_record deprecation

* gcdns_zone deprecation

* gcp_forwarding_rule deprecation

* gcp_url_map deprecation

* gcspanner deprecation

* gcp_healthcheck deprecation

* porting guide

* test failures

* forgot to rename

* deprecating

* porting guide changes

* unit test fixes

* changing ignores
2019-04-18 15:30:27 +01:00
Andrey Klychkov
316d1db29f postgresql modules: move connect_to_db and get_pg_version to module_utils/postgres.py (#55514)
* postgresql modules: move connect_to_db, get_pg_version to module_utils

* postgresql modules: move connect_to_db, get_pg_version to module_utils 2

* postgresql modules: move connect_to_db, get_pg_version to module_utils 3
2019-04-18 14:15:51 +01:00