Commit graph

46978 commits

Author SHA1 Message Date
Joe Clarke
0b284c1431 Cast booleans to strings. (#60544)
This avoids an error when building the API request:

TypeError: Argument must be bytes or unicode, got 'bool'

This would occur when one explicitly sets async_bool or ignore_owners in
a playbook/role.
2019-08-26 11:32:14 -04:00
Milan Zink
7cefef9719 Adding new options to na_ontap_nfs module (#59505)
* Adding new options to na_ontap_nfs module

- nfsv4_fsid_change
- nfsv4_numeric_ids
- nfsv40_referrals
- nfsv41_pnfs
- nfsv41_referrals

* Adding version_added: '2.9' for new options
2019-08-26 10:22:45 -04:00
Josh Edmonds
f62f1ab54c Added comment field to na_ontap_volume module (#59566)
* Added comment field to na_ontap_volume module

* fixed zapi attribute name in create_volume_options(), and fix to ensure comment field can be set back to an empty string
2019-08-26 10:14:39 -04:00
digi
7f06db8211 module_utils/redfish_utils.py: add ForceRestart option (#61104)
The library does not allow you to force a restart via redfish, (unless GracefulRestart
triggered by PowerReboot-command is not supported).
Therefore, I added the option `PowerForceRestart` to be able to force a reboot of an
unresponsive host.
2019-08-26 10:13:09 -04:00
Matt Martz
5941e4c843
Properly JSON encode AnsibleUnsafe, using a pre-processor (#60602)
* Properly JSON encode AnsibleUnsafe, using a pre-processor. Fixes #47295

* Add AnsibleUnsafe json tests

* Require preprocess_unsafe to be enabled for that functionality

* Support older json

* sort keys in tests

* Decouple AnsibleJSONEncoder from isinstance checks in preparation to move to module_utils

* Move AnsibleJSONEncoder to module_utils, consolidate instances

* add missing boilerplate

* remove removed.py from ignore
2019-08-26 09:08:22 -05:00
Sloane Hertel
1d405fdd60
Add module aliases back in hardcoded module_defaults list (#61203) 2019-08-26 10:05:57 -04:00
Chris Archibald
53df4d8186 New options for identity_preserve (#60498)
* new option

* Force ansibot to run again
2019-08-26 10:03:26 -04:00
kvegh
930088da96 Clarifying: no lists in name parameter (#61029)
* Clarifying: no lists in name parameter
2019-08-26 10:02:37 -04:00
Mario Lenz
0ac57941c1 VMware: Add missing HA admission control policies in vmware_cluster_ha (#60233)
* Add missing HA admission control policies
* Add new parameter host_isolation_response
* Bugfix: 'das_vm_config' referenced before assignment
* Implement test cases
2019-08-26 09:40:38 -04:00
Miguel Angel Muñoz González
d95a0f235b Fortinet's new module for fortios_user_local (#61054)
* Fortinet's new module for fortios_user_local

* New version of fortios_user_local

* Update unit tests with removal of attribute
2019-08-26 18:56:30 +05:30
Miguel Angel Muñoz González
69fcd771e0 FortiOS modules for 2.9 - 8 (#61308)
* FortiOS modules for 2.9 - 8

* Add missing files

* Fix trailing spaces
2019-08-26 18:55:53 +05:30
Nathaniel Case
f3f30c146b
Deprecate net_* modules (#60818)
* Deprecate net_ modules

* Move modules to finish deprecation

* Add missing `why`, move net_static_route

* Add changelogs and porting guide
2019-08-26 09:07:54 -04:00
Trishna Guha
5a04b4feb6
Add nxos_l2_interfaces resource module (#61120)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-08-26 16:46:05 +05:30
sushma-alethea
c729f3ba61 icx: new module icx_facts (#61225)
* new cliconf

* cliconf

* icx cliconf

* icx test units module

* icx units module

* icx banner unit test

* added notes

* new changes

* icx .rst

* modified platform_index.rst

* test

* Revert "test"

This reverts commit 99b72c6614.

* new module icx_facts

* fixtures added

* Rebase causing problem on branch-PR4. So created new PR

* new commit

* new changes
2019-08-26 14:00:00 +05:30
Michał Szczepańczyk
8ed3a0b360 fix bug - k8s was crashing when yaml ended with 3 dashes (#61182)
* fix bug - k8s was crashing when yaml ended with 3 dashes

* #61182 - add changelog
2019-08-26 17:28:01 +10:00
sushma-alethea
7e1a347695 icx: new module icx_linkagg (#59967)
* new module

* new module

* new terminal

* new terminal

* new cliconf

* new cliconf

* cliconf

* cliconf

* icx cliconf

* icx cliconf

* icx_cliconf

* icx test units module

* icx test units module

* icx units module

* icx units module

* icx banner unit test

* icx banner unit test

* PR changes resolved

* changes resolved

* Changes Resolved

* check_running_config changes resolved

* added notes

* added notes

* removed icx rst

* new changes

* new changes

* deleted icx rst

* icx .rst

* icx .rst

* modified platform_index.rst

* modified platform_index.rst

* modified platform_index.rst

* modified platform_index.rst

* changes resolved

* changes resolved

* PR comments resolved

* PR comments resolved

* Update platform_index.rst

PR comment resolved

* Update platform_index.rst

PR comment resolved

* new module icx_linkagg

* bug fixes

* Fixing bot errors

* Trying to fix aggregate document error

* Added options under aggregate in documentation

* Fixed bot error

* Fixed documentation error

* Fix bot error

* notes updated
2019-08-26 09:12:59 +05:30
sushma-alethea
20ec927280 icx: new module icx_static_route (#59978)
* new module

* new module

* new terminal

* new terminal

* new cliconf

* new cliconf

* cliconf

* cliconf

* icx cliconf

* icx cliconf

* icx_cliconf

* icx test units module

* icx test units module

* icx units module

* icx units module

* icx banner unit test

* icx banner unit test

* PR changes resolved

* changes resolved

* Changes Resolved

* check_running_config changes resolved

* added notes

* added notes

* removed icx rst

* new changes

* new changes

* deleted icx rst

* icx .rst

* icx .rst

* modified platform_index.rst

* modified platform_index.rst

* modified platform_index.rst

* modified platform_index.rst

* changes resolved

* changes resolved

* PR comments resolved

* PR comments resolved

* Update platform_index.rst

PR comment resolved

* Update platform_index.rst

PR comment resolved

* new module icx_static_route

* new changes

* new changes

* notes updated
2019-08-26 09:12:10 +05:30
PRASOON KARUNAN V
48eed0b6c8 adding group parameter for win_firewall_rule (#55109)
* adding group parameter for win_firewall_rule

* integration test fix

* changing the version add to 2.9

* setting group optional

* fix:setting required to optional
2019-08-25 19:10:31 -04:00
Jordan Borean
9786e2b559
Fix up env config source for Galaxy server list (#61294) 2019-08-26 07:11:35 +10:00
Chris Archibald
265fcaac40 Add Rest API to DNS (#59937)
* add rest to dns

* fix issues with tests

* fixes to netapp.py

* fixes

* fixes

* add updates

* fix issues
2019-08-25 10:52:01 -04:00
Josh Edmonds
25db0c7678 Added NetApp ONTAP Adaptive QoS Policy Module (#58707)
* Added NetApp ONTAP Adaptive QoS Policy Module

* updated documentation to fix validation errors

* Updates to documentation fields and modified logging function to log against the current vserver

* Fixed minor formatting issues

* Documentation update for consistency - author field

* Empty commit to force CI

* fixes
2019-08-25 10:50:34 -04:00
Mark Chappell
4e6298b847 AWS dynamic inventory: fixup RDS integration tests (#61259)
* ec2 inventory/rds: (integration tests) migrate to module_defaults and cope with missing security_token

* ec2 inventory/rds: (integration tests) Avoid hard coding the parameter group name

Generated it based on the information returned when creating the RDS instance.

* ec2 inventory/rds: (integration tests) rename templates to .j2 rather than .yml
- avoids throwing yamllint errors
- makes it clear they're templates not the final yaml files.
2019-08-25 10:32:18 -04:00
Miguel Angel Muñoz González
a6b124cccc FortiOS modules for 2.9 - 7 (#61217) 2019-08-25 12:54:45 +05:30
Paul Belanger
9d4dcc7506
Remove unused imports from netconf_get (#61265)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-24 19:47:56 -04:00
Paul Belanger
2ce091cc86
Remove duplicate imports in iosxr_lldp_interfaces (#61266)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-24 17:59:51 -04:00
Matt Clay
02c38ed4fd
Relocate ansible-test self tests outside package. (#61255)
* Relocate ansible-test self tests outside package.

We don't want to include the tests for verifying ansible-test within the ansible-test package.

* Add `test/ansible_test/` to classification.py.

* Fix test invocation.

* Relocate tests in MANIFEST.in.

* Improve package-data sanity test error checking.

* Only use includes for ansible-test in MANIFEST.in.

* Improve readability of MANIFEST.in.
2019-08-24 11:38:30 -07:00
Paul Belanger
c61dec032c
Remove unsed variable is l2_interfaces.py (#61246)
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-24 12:57:17 -04:00
Felix Fontein
c3b1a0a7e8 Vultr: rename _facts -> _info (#61239) 2019-08-24 17:54:17 +02:00
Matt Clay
1fbb930747 Add out-of-tree check to symlinks sanity test. 2019-08-24 07:25:35 -07:00
Matt Clay
2a9b996bd2 Use .cfg extension for pylint configs. 2019-08-24 07:25:19 -07:00
Paul Belanger
11d82d70eb
Remove duplicate imports from iosxr_lacp_interfaces (#61258)
This cleans up linting for our new iosxr collection.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-08-24 10:12:29 -04:00
Matt Clay
6ec0b4ec86
Sanity test updates for collections support. (#61248)
* Run no-unwanted-files sanity test only on Ansible.

Since collections should be able to use binary modules there is not really any limit on what could exist in a collection `plugins` directory.

* Add support for symlinks in sanity target lists:

- Sanity tests that need to analyze symlinks can do so using the supplied target list.
- Tests that analyze directories will now only look at symlinks if requested.
- Directory symlinks will now be seen as directories instead of files.

* Enable symlinks on filename based sanity tests.

Sanity tests that evalulate filenames instead of content should include symlinks.

* Update symlinks sanity test.

Use the sanity test target list now that it can include symlinks.
2019-08-23 18:08:21 -07:00
Mark Chappell
5434bf74c6 Fix issues with aws_kms when working cross-account and with IDs (#60805)
* aws_kms: (integration tests) Test updating a key by ID rather than just my alias

* aws_kms: (integration tests) Test deletion of non-existent and keys that are already marked for deletion

* aws_kms: Ensure we can perform actions on a specific key_id rather than just aliases

In the process switch over to using get_key_details rather than listing all keys.

* aws_kms: When updating keys use the ARN rather than just the ID.

This is important when working with cross-account trusts.
2019-08-23 16:56:45 -07:00
Felix Fontein
4551965af1 ACME modules: bump test container version (#61192)
* Fix root cert path.

* Bump testing container version.

* Improve check (needed due to letsencrypt/pebble#257).
2019-08-23 15:30:28 -07:00
Søren Kröger
1cf43e5017 Handle multiple Content-Type headers correctly (#31238)
* Handle multiple Content-Type headers correctly

Avoids situations where mulitple Content-Type headers including charset information can result in errors like 
```
LookupError: unknown encoding: UTF-8, text/html
```

* Account for multiple conflicting values for content-type and charset

* Add changelog fragment
2019-08-23 16:48:16 -05:00
Victor Costan
943b4f5a83 os_server: keep optional nic args for nics specified using net-name or port-name. (#20969) 2019-08-23 17:00:31 -04:00
Jay Carman
fabd912fa5 Fix typo in 'Ansible and Python 3' dev guide (#61226)
The underscore does not need to be escaped inside of the RST inline
literal.
2019-08-23 15:53:25 -04:00
Mark Chappell
1f733e2d55 ec2_asg: fix the integration tests (#61212) 2019-08-23 14:53:47 -04:00
Ryan Conway
e4c1c05363 Renaming onepassword_facts to onepassword_info. (#61237)
* Renaming `onepassword_facts` to `onepassword_info`.

* Update module examples.

* Add changelog fragment.

* Add module rename to the 2.9 porting guide.

* Document the parameter types in the module docs.

* Fix incorrect parameter name.

* Update docs/docsite/rst/porting_guides/porting_guide_2.9.rst

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Remove `onepassword_facts` as it has been renamed to `onepassword_info` including fixes for the sanity tests.
2019-08-23 20:45:13 +02:00
The Magician
d3b493020d New Module: gcp_kms_crypto_key (#61096) 2019-08-23 13:27:46 -04:00
The Magician
bf514b5717 New Module: gcp_kms_crypto_key_info (#61097) 2019-08-23 13:27:37 -04:00
The Magician
ba026939bb New Module: gcp_kms_key_ring (#61098) 2019-08-23 13:27:28 -04:00
Nathaniel Case
64312a09c9
Add use_proxy option to httpapi (#59259) 2019-08-23 13:07:52 -04:00
Sumit Jaiswal
c9f0b0fb42
Resource module for ios_l3_interfaces (#60405)
* ios_l3_interfaces

* fix shippable

* fix tests

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix ignore txt file

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix doc

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix shippable n tests

* fix replace test

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix zuul failures

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix shippable n zuul

* fix zuul

* fix zuul

* fix zuul test

* fix zuul

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* code zuul fix

* fix merge

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix merge

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-08-23 22:09:20 +05:30
Wojciech Wypior
a275bf1625 added better description on how aggregate functions (#61069) 2019-08-23 08:05:19 -07:00
Rohit
11ba2a965d
platform guide updates (#61121)
* platform guide updates

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>

* sanity fix

Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2019-08-23 20:23:50 +05:30
Felix Fontein
fa70690e5c
openssl_certificate/csr(_info): add support for SubjectKeyIdentifier and AuthorityKeyIdentifier (#60741)
* Add support for SubjectKeyIdentifier and AuthorityKeyIdentifier to _info modules.

* Adding SubjectKeyIdentifier and AuthorityKeyIdentifier support to openssl_certificate and openssl_csr.

* Fix type of authority_cert_issuer.

* Add basic tests.

* Add changelog.

* Added proper tests for _info modules.

* Fix docs bug.

* Make sure new features are only used when cryptography backend for openssl_csr is available.

* Work around jinja2 being too old on some CI hosts.

* Add tests for openssl_csr.

* Add openssl_certificate tests.

* Fix idempotence test.

* Move one level up.

* Add ownca_create_authority_key_identifier option.

* Add ownca_create_authority_key_identifier option.

* Add idempotency check.

* Apparently the function call expected different args for cryptography < 2.7.

* Fix copy'n'paste errors and typos.

* string -> general name.

* Add disclaimer.

* Implement always_create / create_if_not_provided / never_create for openssl_certificate.

* Update changelog and porting guide.

* Add comments for defaults.
2019-08-23 14:01:42 +02:00
Mark Chappell
77e4371460 aws_kms: Update policy on existing keys (when passed) (#60059)
* aws_kms: (integration tests) Use module_defaults to reduce the copy and paste

* aws_kms: (integration tests) make sure policy option functions.

* aws_kms: (integration tests) Move iam_role creation to start of playbook.

iam_roles aren't fully created when iam_role completes, there's a delay on the Amazon side before they're fully recognised.

* aws_kms: Update policy on existing keys (when passed)
2019-08-23 20:38:38 +10:00
sushma-alethea
25053827a5 icx: new module icx_config (#59914)
* new module

* new terminal

* new terminal

* new cliconf

* cliconf

* icx cliconf

* icx_cliconf

* icx test units module

* icx units module

* icx banner unit test

* PR changes resolved

* changes resolved

* Changes Resolved

* check_running_config changes resolved

* new module

* new cliconf

* cliconf

* icx cliconf

* icx test units module

* icx units module

* icx banner unit test

* added notes

* added notes

* removed icx rst

* new changes

* new changes

* deleted icx rst

* icx .rst

* icx .rst

* modified platform_index.rst

* modified platform_index.rst

* modified platform_index.rst

* modified platform_index.rst

* changes resolved

* changes resolved

* PR comments resolved

* PR comments resolved

* Update platform_index.rst

PR comment resolved

* Update platform_index.rst

PR comment resolved

* new module icx_config

* new changes

* new changes in icx_config

* PR changes

* PR comments resolved

* PR comments resolved

* new changes

* new changes

* Review comments

* updated notes section
2019-08-23 16:02:51 +05:30
Chris Van Heuveln
f1054f575d bfd_global: minor test-only fix (#60965) 2019-08-23 15:12:59 +05:30