Commit graph

28946 commits

Author SHA1 Message Date
Tom De Keyser
6f74fca238 New module for AWS Step Functions state machines ()
* add new module: aws_stepfunctions_state_machine

* add integration tests for new module: aws_stepfunctions_state_machine

* fix sanity checks

* use files/ folder instead for integration test

* rename role name in integration test

* attempt further permissions

* iam states prefix

* iam integration test prefix

* add iam policy for running step functions state machine actions

* slightly increase iam permission scope

* rename integration test folder to proper name

* move main() method to end of file

* move contents of integration-policy.json for state machines to compute-policy.json

* make check_mode return proper changed value + add check_mode integration tests

* rename module to aws_step_functions_state_machine

* fix missed rename in integration test variable

* add purge_tags option

* bump to version 2.10
2019-09-09 10:08:21 -07:00
Gonéri Le Bouder
3ea8e0a144 VMware: not ssl.SSLContext if validate_certs false ()
Python < 2.7.9 does not have the ssl.SSLContext attribute.
ssl.SSLContext is only required when we want to validate the SSL
connection. If `validate_certs` is false, we don't initialize the
`ssl_context` variable.

Add unit-test coverage and a little refactoring:

- avoid the use of `mocker`, when we can push `monkeypatch` which is
  `pytest`'s default.
- use `mock.Mocker()` when possible

closes: 
2019-09-09 21:41:46 +05:30
Mark Chappell
1f38a12057 Fix behaviour of module_utils/ec2 compare_policies when dealing with bare bools and ints. ()
* module_utils/ec2: (unit tests) Move unit tests for module_utils/ec2.py into test/units/module_utils

- compare_policies was refactored from s3_bucket
- "ec2_utils" doesn't seem to have ever existed

* module_utils/ec2: (unit tests) Add unit test for comparing quoted and unquoted bools and numbers within policies

As per https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_grammar.html

"Values are enclosed in quotation marks. Quotation marks are optional for numeric
and Boolean values."

* module_utils/ec2: Explicitly convert bools and ints to strings when comparing policies

See also: https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_grammar.html
2019-09-09 12:08:25 -04:00
Nathaniel Case
9d93076a99
Debug location of ansible-connection when found () 2019-09-09 12:06:54 -04:00
Xu Yuandong
28227c95a4 for capability/exchange/1.0 ()
* for capability/exchange/1.0

* for capability/exchange/1.0

* update for shippable

* Update ce.py

* Update ce.py
2019-09-09 14:33:34 +01:00
Alex White-Robinson
6fa8abf162 fix: adds prefix length error to eos cli plugin () 2019-09-09 09:28:40 -04:00
Satoru SATOH
483e76ee58 Allow junos_config changes the candidate configuration only ()
This allows junos_config to changes the candidate configuration only and
does not commit it as the active configuration at once w/ the
'check_commit' option.
2019-09-09 18:22:57 +05:30
Erwan Quélin
7b28960ebe VMware: Add new module VMware vSAN health infos () 2019-09-09 14:59:31 +05:30
Abhijeet Kasurde
3703c3bb1a
atomic_image: Fix absent state ()
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-09-09 14:38:32 +05:30
Simon Dodsley
df49a9e58c purefa_info: Fix failure due to API version check () 2019-09-09 09:14:46 +02:00
Abhijeet Kasurde
92099d7f2f
Remove unnecessary pass statement ()
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-09-09 10:12:11 +05:30
Paul Belanger
a680ff2ade
Clean up unused imports for nxos related code ()
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-08 22:53:24 -04:00
Felix Fontein
d40ba28fb4
docker_container: improve port range parsing error behavior ()
* Improve port range parsing.

* Add changelog.
2019-09-08 20:30:18 +02:00
Chris Trufan
943888b955 Fixes to ecs_certificate cert chain for ()
* Fixes to ecs_certificate cert chain for 

* Added changelog fragment

* Fixes to ecs_certificate for cleaner join, and better integration test

* Fix integration test formatting

* End cert chain with a \n

* Update changelogs/fragments/61738-ecs-certificate-invalid-chain.yaml

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update main.yml
2019-09-07 07:58:25 +02:00
Andreas Calminder
cac93cbd1f os_port allowed_address_pairs and extra_dhcp_opts list of dicts comparison fix ()
* compare list of dicts

* update example for dhcp_server_opts to include ip_version which is automatically added by openstack

* add note about dhcp_server_opts

* add changelog fragment

* fix forgotten exception+pass

* no need to excplicitly check for None

* fix oops

* fix import error

* missed missing_required_lib

* changelog fragment formatting and grammar fixes

* update requirements in documentation and fix spelling
2019-09-06 22:44:25 +02:00
Mark Chappell
b8650c0a50 aws_asg: Fix idempotency when using tags and metrics ()
* Update AWS hacking policy to enable ASG Tagging management

* aws_asg: Add tests for ASG Tagging (including idempotency)

* aws_asg: ignore sort order when comparing tags on the ASG (fix idempotency)

* ec2_asg: (integration tests) test for idempotency when managing metrics collection

* ec2_asg: sort list of enabled metrics to ensure clean comparisons.
2019-09-06 12:48:40 -07:00
Matt Martz
8331c8fdc3
Properly hide limit and list-hosts args from ansible-inventory ()
* Properly hide limit and list-hosts args from ansible-inventory. Fixes 

* Add changelog fragment

* Consolidate limit

* Fix positional argument with --graph

* Properly error for hidden arguments

* linting issue

* host pattern changelog
2019-09-06 11:43:50 -05:00
Sam Doran
61efffcbe1
User - correct group removal description in docs () 2019-09-06 12:16:33 -04:00
Andrey Klychkov
e4d4e49388 Fix mysql.py logic related to 53326 () 2019-09-06 13:53:54 +01:00
Ganesh Nalawade
4f29b5a76b
Fix ansible-connection persist after playbook run complete issue ()
* Fix ansible-connection persist after playbook run issue

*  PR https://github.com/ansible/ansible/pull/59153 to add support
   for delaying the ansible-connection added an old issue of
   ansible-connection persisting even after playbook run is finished
   till either command timeout or connect timeout is triggered.
   ansible-connection persist after playbook execution is done
   and also delays the connection initilization untill a method
   in invoked from module side on the connection object.

* Add chanegelog
2019-09-06 14:23:18 +05:30
felyl-github
e6fe52bc56 Update os_security_group_rule.py ()
Currently, this module does not support to add 132 SCTP rule in security group rule of openstack. Could we add this support in this module? Thanks~
2019-09-06 02:32:34 -04:00
Matt Davis
7f4328ad12
allow external collections under the ansible NS ()
* fixes 
2019-09-05 18:50:22 -07:00
Toshio Kuratomi
f58899eef7 Update release name for 2.10
Add a list of previously used release names to make it easy to tell what
release names are no longer usable.

Add a test that new release names have been added to the used list.

Fixes 
2019-09-05 18:36:06 -07:00
Mark Chappell
832e03d932 Fixup iam_group integration tests and return value documentation ()
* iam_group: (integration tests) migrate tests to module_defaults

* iam_group: (integration tests) migrate to using temporary user and group with {{ resource_prefix }}

* iam_group: (integration tests) fix test, checking the return values

* iam_group: (integration tests) Add some more tests around the behaviour of 'changed'

* iam_group: (docs) Update documentation of iam_group return value

* Update AWS testing policies to enable group/user management
2019-09-05 19:25:36 -04:00
Kevin Breit
7d303e54f6 meraki_organization - Add warning about organization deletion ()
* meraki_organization - Add warning about organization deletion
The documentation is now more explicit about the ramifications of using `state: absent` in a task.
2019-09-05 16:02:19 -05:00
Sumit Jaiswal
1425d23513 To fix IOSXR L3 Interfaces idempotency failures ()
* fix zuul idemptency failures

* adding eol

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-09-05 16:39:15 -04:00
Yannis Ansermoz
ce8af1c8c5 Typo 'state:' net_lldp ()
'state:' should be "absent" not "lldp"
2019-09-05 14:15:19 -05:00
Nathaniel Case
a365e77cc3
Connect before reading the prompt? () 2019-09-05 14:48:16 -04:00
Travis Burton
394a05108d Update mso_schema_template_deploy.py ()
module names are incorrect in EXAMPLES:  changed module names from 'mso_schema_template' to 'mso_schema_template_deploy'
2019-09-05 10:55:56 -05:00
gen2kes
513bddb44a VMware: Add disk_mode parameter in vmware_guest_disk ()
* Solve issue 58592

Added support to select disk_mode.
2019-09-05 11:52:12 -04:00
Evgeni Golov
1aca1f86b6 don't set default:None in documentation when there is no default ()
otherwise "None" will be rendered as a string on docsite
2019-09-05 10:48:11 -05:00
js-max
70f501d5c8 Update hashi_vault.py documentation with kv V2 example () 2019-09-05 11:42:39 -04:00
Nathaniel Case
cc9adf7f1a
Unify ios_logging documentation with accepted options ()
* Unify ios_logging documentation with accepted options

* Apply suggestions from code review

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>

* Copy suggestion over to eos_logging
2019-09-05 08:58:57 -04:00
Fabian von Feilitzsch
f406b8b4c4 Fix bug preventing wait_condition from being respected when using apply () 2019-09-05 22:49:30 +10:00
Abhijeet Kasurde
223dab99ea
gitlab_hook: Update documentation ()
* Update docs for note_events

Fixes: 

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-09-05 17:09:59 +05:30
Felix Fontein
e06dbe6e4f
Azure _info modules: fix returned ansible_facts when called as _info ()
* Fix Azure _info modules which still returned ansible_facts.

* Adjust PR #.

* Fix wrong assignment.

* Reorganize code for clarity.
2019-09-05 11:51:56 +02:00
Bill Dodd
2a932ad7cf Fix power command ResetType mapping logic ()
* fix power command ResetType mapping logic

* add changelog fragment
2019-09-05 05:39:21 -04:00
Abhijeet Kasurde
823c108fac
ovirt: Fix API calls in ovirt_storage_domain ()
* Fixed argument in _attached_sds_service API
* Fixed argument in _maintenance API

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-09-05 15:00:18 +05:30
Paul Belanger
c723eb2f04
Remove unused import from iosxr facts ()
This is no longer needed and can be removed.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-04 22:16:15 -04:00
Jordan Borean
3a7b77a94c
ansible-galaxy fix --server option for roles () 2019-09-05 11:46:44 +10:00
Paul Belanger
f81b7dd10a
Remove unsed import for eos facts module ()
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-04 19:50:12 -04:00
Matt Martz
8214d188cf Don't truncate the last character from galaxy urls. Fixes () 2019-09-05 07:06:42 +10:00
Paul Belanger
7be672e1c2
Remove unsed import for junos facts ()
This is no longer needed.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-04 15:00:19 -04:00
Sloane Hertel
ff05991265
s3 - improve waiting for the bucket () 2019-09-04 14:50:08 -04:00
Nathan Swartz
4c8407fb83 Fix documentation and facts_from_proxy value in the netapp_e_facts module. () 2019-09-04 14:34:58 -04:00
Paul Belanger
44eaea9f80
Remove unused import for cisco ios facts ()
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-04 14:22:38 -04:00
Paul Belanger
736938625b
Remove unused import for vyos facts ()
This is no longer needed and can be removed.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-09-04 13:54:08 -04:00
Scott Luther
0c73e47a42 fix erroneous failures in docker_compose due to deprecation warnings … ()
* fix erroneous failures in docker_compose due to deprecation warnings from docker ()

* Update error handling to work with new method of capturing output

Co-Authored-By: Felix Fontein <felix@fontein.de>

* update error handling

* fix syntax error

* fix indentation

* fix indentation (again)

* remove erroneous line
2019-09-04 19:34:05 +02:00
kucharskim
1dea661ce8 Allow 13 asterisk characters in password field without warning ()
On OpenBSD, 13 asterisk characters as a password hash, marks the
account as disabled. Otherwise daily(8) script which executes
security(8) will email operator about not properly locked accounts.

Before the diff, we see following warning:

> [WARNING]: The input password appears not to have been hashed. The 'password' argument must be encrypted for this module to work properly.

After the diff, warning is gone.
2019-09-04 11:49:16 -04:00
Strahinja Kustudic
ee4b3b8854 Fix systemd start state with deactivating service state 2019-09-04 08:01:33 -07:00