Commit graph

438 commits

Author SHA1 Message Date
Timur Batyrshin
db173453ba further compatibility with older versions of python-apt (#5853) 2014-02-02 23:15:19 +04:00
Manuel Tiago Pereira
e563f847ec Fixes #5819: Added --executables to gem uninstall command. 2014-01-30 00:09:28 +00:00
Richard C Isaacson
f0c4dace8d If a executable is defined but not found the module should fail. Addresses https://github.com/ansible/ansible/issues/5781. 2014-01-29 13:09:58 -06:00
James Cammarata
1ca6e4bbb1 Adding a check for pending tranasctions to the yum module
Fixes #4649
2014-01-22 15:19:19 -06:00
Jakub Jirutka
88b7dc344c Introduce module layman 2014-01-22 20:10:53 +01:00
jctanner
297a28aa79 Merge pull request #5333 from mvermaes/yum_fix
yum module: Attempt #2 to cause yum to fail on invalid url
2014-01-20 06:45:01 -08:00
Rene Moser
849aab0a12 apt: fixed pkg=<name>=<version> fails if package is not yet installed.
Reported and patch provided by https://github.com/msolo. Closes GH-5625.
2014-01-16 11:05:12 +01:00
Michael DeHaan
6f49642286 All modules should be using /usr/bin/python in the shebang as ansible_python_interpreter processes this (see FAQ).
Fixing for standardization purposes.
2014-01-15 09:52:17 -05:00
Michael Vermaes
c55d144c50 Fail yum on invalid url with .rpm suffix 2014-01-15 12:20:31 +08:00
jctanner
7d09c97621 Merge pull request #5472 from RSpiertz/apt_repository
apt_repository: don't crash if default_file doesn't exist
2014-01-14 14:26:19 -08:00
James Tanner
fbba0bb3fc Fixes #5601 Do not append extra args when checking for pip command options 2014-01-14 14:22:37 -05:00
jctanner
e4d0ce5b08 Merge pull request #5383 from janitha/devel
Fixes #5381 bug when easy_install is used with virtualenv
2014-01-14 08:52:12 -08:00
Michael DeHaan
a7fbafe955 Merge pull request #5616 from resmo/fix/zypper_repo
zypper_repository: claims to support check_mode, but does not.
2014-01-14 06:02:42 -08:00
Rene Moser
62fd0b1269 zypper_repository: claims to support check_mode, but does not. Fixes GH-5614. 2014-01-14 14:20:18 +01:00
Danilo Bargen
7436da08fe apt_key module: Case insensitive presence checking
Right now key_present() is case sensitive, only uppercase key IDs work. By using "grep -i", lowercase IDs should work too.
2014-01-14 01:11:40 +01:00
inetfuture(Aaron Wang)
64acd60d24 Fix npm documentation typo. 2014-01-09 08:53:17 +08:00
lichesser
7201972a56 Remove debugging code
I guess this is left over from testing
2014-01-08 02:34:59 +01:00
James Tanner
c8bd14925d Fixes #5369 Do not pass --force-yes to aptitude 2014-01-07 15:53:28 -05:00
Michael DeHaan
e0cd4a45c6 Merge pull request #5489 from daghoidahl/devel
Use "brew list <name>" instead of grepping the output of "brew list". Fix for #5488
2014-01-04 10:52:03 -08:00
James Tanner
191be7b951 Resolves issues with newer versions of pip not having a --use-mirrors paramater for the install command 2014-01-03 15:29:18 -05:00
Dag Høidahl
279098bd03 Use "brew list <name>" instead of grepping the output of "brew list".
Some brew packages are not listed with their package name, e.g. libjpeg.
2014-01-03 15:15:20 +01:00
Rutger Spiertz
763c0305c1 apt_repository: don't crash if default_file doesn't exist 2014-01-02 15:41:24 +01:00
Evgenii Terechkov
c06cc8c21b Initial version of apt-rpm module 2013-12-29 19:55:18 +08:00
Michael DeHaan
cfcdc3403e Use task names in examples. 2013-12-26 13:46:09 -05:00
Michael DeHaan
4765032fcb Merge branch 'devel' of git://github.com/beefsalad/ansible into devel 2013-12-26 13:41:42 -05:00
beefsalad
5b2fda6fa6 added descriptions for yum options
Updated main description to state that the yum module will handle package groups.  Added descriptions for each example, as it is unclear to (some) users that @Name implies a group install.
2013-12-26 12:25:52 -06:00
Janitha Karunaratne
fd037f5960 Fixes #5381 easy_install bug when used with virtualenv 2013-12-20 16:44:18 -06:00
Michael Vermaes
5671ddcdd3 Attempt #2 to cause yum to fail on invalid url 2013-12-19 00:40:44 +08:00
Michael DeHaan
3f81c3c416 Merge pull request #5162 from JensRantil/fix-corrupt-module-outputs
More don't catch `SystemExit`
2013-12-18 05:13:34 -08:00
jctanner
93c15a41dc Merge pull request #5274 from veeti/easy_install_chdir
Fix permission error when using easy_install through sudo
2013-12-17 10:11:31 -08:00
jctanner
b9cb49e638 Merge pull request #4872 from timurbatyrshin/4869-old-python-apt-fix
#4869 compatibility with older versions of apt
2013-12-13 10:43:47 -08:00
jctanner
53c5b1d934 Merge pull request #4949 from eest/openbsd_pkg-rework-name-parsing
openbsd_pkg: rework package name parsing.
2013-12-13 08:05:25 -08:00
Veeti Paananen
fa90f31cc8 Fix permission error when using easy_install through sudo
Same as b2542bff72.
2013-12-13 00:13:13 +02:00
Rene Moser
2d805ae5da apt: update index before trying to autoinstall python-apt 2013-12-09 10:21:27 +01:00
Leszek Krupiński
4357e6f31e support for apt-key keyserver parameter 2013-12-08 11:53:33 +01:00
jctanner
6b45c4a6ca Merge pull request #5181 from mvo5/bugfix/apt-fnmatch-remove
add fnmatch() support for apt remove too (just like install)
2013-12-05 09:18:04 -08:00
Michael Scherer
3df62f1d8a Fix apt module to be able to install package by giving just a provides and not the full name
The apt module check if a packag eis valid by loking in the cache, checking only for
full name, while it should also check that the name is not just provided.
Fix https://github.com/ansible/ansible/issues/5177
2013-12-05 17:56:54 +01:00
Michael Vogt
559de5c65e add fnmatch() support for apt remove too (just like install) 2013-12-05 17:54:43 +01:00
Jens Rantil
8f2580fc98 module(apt_key): don't catch SystemExit
If we do this, we risk outputting two JSON payloads, which will be
unparsable.
2013-12-04 13:57:50 +01:00
James Tanner
ad837709bd Addresses #5023 Fix import comments 2013-12-02 15:13:49 -05:00
James Tanner
6000d636b3 Fixes #5023 Convert all modules to use new snippet import pattern 2013-12-02 15:11:23 -05:00
jctanner
219f27a594 Merge pull request #4938 from giorgio-v/pkgin_y_default
Added `-y` flag to `query_package`
2013-12-02 11:47:04 -08:00
Michael DeHaan
36effd237c There's a cleaner way to do this, commit to module formatter pending.
Revert "No longer need to reference 'version_added' in docs for these, as this was quite a while ago."

This reverts commit ff0a41d446.
2013-11-27 21:23:03 -05:00
Michael DeHaan
ff0a41d446 No longer need to reference 'version_added' in docs for these, as this was quite a while ago. 2013-11-27 21:19:32 -05:00
jctanner
815b32685b Merge pull request #4985 from zakkie/devel
fix typo in document
2013-11-22 09:25:44 -08:00
Berend de Boer
2222532745 Don't use pkg_glob when guessing name, else we may think the package
is installed when it isn't.
2013-11-22 11:13:21 +13:00
Akihiro YAMAZAKI
97b6e13e46 fix typo in document 2013-11-21 16:09:43 +09:00
James Tanner
9727a4415c Add warning comment to rhn_register module about fixing pep8 errors 2013-11-19 16:41:51 -05:00
jctanner
8277bf29d2 Merge pull request #4898 from stoned/homebrew-install_options-fix
Fix homebrew module's install_options handling
2013-11-19 12:30:32 -08:00
Michael DeHaan
afcda172e1 Merge pull request #4934 from mscherer/fix_urpmi_2
return failed if a package couldn't be installed
2013-11-19 11:35:51 -08:00
Michael DeHaan
f7c3975f21 Add version_added to all modules missing version_added information, the docs formatter will now
raise errors when omitted, updated changelog with new modules.
2013-11-18 18:55:49 -05:00
Patrik Lundin
e66add13d5 openbsd_pkg: rework package name parsing.
Give the module more knowledge of the package name structure.
This makes the handling of version-less flavors (like vim--no_x11)
behave properly.

While here sprinkle debug logging that is helpful when testing the
module.
2013-11-18 20:24:10 +01:00
giorgio-v
0342f432e2 Added -y flag to query_package
* library/packaging/pkgin:

Signed-off-by: giorgio-v <giorgio@refactor.it>
2013-11-18 08:01:10 +01:00
James Tanner
99dfa1afec Revert "Merge pull request #4912 from zehome/openbsd_pkg_flavourfix"
This reverts commit de2f4cf04d, reversing
changes made to 2c33737bfa.
2013-11-18 00:15:33 -05:00
Michael Scherer
d66027ba7a return failed if a package couldn't be installed
For some reason, on my test mandriva, urpmi --force return 0
even when it cannot install a rpm. So we have to explicitely check
if the package was properly installed with a loop
2013-11-18 00:22:54 +01:00
Michael Scherer
0d8b81cd95 optionally use rpm python module instead of calling a
external executable, to avoid the cost of forking.
Since python-rpm is not automatically present, we still fallback
on the slower rpm fork method.
2013-11-17 15:37:30 +01:00
Michael Scherer
9482815b71 Fix behavior of urpmi module where it always return "changed"
even when a package is already installed, since urpmi will
always return 0 wether it install or not.
2013-11-17 15:37:30 +01:00
Michael DeHaan
56e3d31253 Merge pull request #4904 from joemaller/npm-outdated-fix
update npm-module to handle new node.js output
2013-11-16 10:40:51 -08:00
jctanner
c057fe2f5f Merge pull request #4861 from pmakowski/devel
urpmi module
2013-11-15 11:59:23 -08:00
jctanner
45ad8237a6 Merge pull request #4832 from matze/add-zypper-repository
Add zypper_repository module
2013-11-15 11:13:50 -08:00
jctanner
912d43a37d Merge pull request #4913 from arkadijs/devel
Use pkgng glob (-g) feature to allow installation of packages by wildcard
2013-11-15 11:00:49 -08:00
jctanner
de2f4cf04d Merge pull request #4912 from zehome/openbsd_pkg_flavourfix
OpenBSD packages can be installed using 'flavour'
2013-11-15 07:21:37 -08:00
James Tanner
2c33737bfa Fix docstring and remove redundant parameter value in portinstall module 2013-11-15 10:13:19 -05:00
Arkadi Shishlov
78f5c69a88 Use pkgng glob (-g) feature to allow installation of packages by wildcard.
Also solves the particular problem of installing packages that have multiple versions in the repo, but specifying the exact version would be troublesome:

$ pkg install -n dovecot
The following 2 packages will be installed:

	Installing dovecot: 1.2.17
	Reinstalling dovecot-2.2.6 (options changed)

$ pkg install -n dovecot-2.2.6
The following 1 packages will be installed:

	Reinstalling dovecot-2.2.6 (options changed)

$ pkg install -n -g dovecot-2*
The following 1 packages will be installed:

	Reinstalling dovecot-2.2.6 (options changed)
2013-11-15 13:28:14 +02:00
Laurent Coustet
12e7e3b2f6 OpenBSD packages can be installed using 'flavour'. Best example
is vim. It can be installed as vim--no_x11 or vim--gtk2.
2013-11-15 12:20:30 +01:00
Berend de Boer
46b11774c1 Support to install software on FreeBSD using portinstall. 2013-11-15 19:49:04 +13:00
Joe Maller
d95ba87b62 update list_outdated module split to both old and new module delimiter. 2013-11-14 10:25:23 -05:00
James Tanner
8e41480059 Set required=false for answer_file in svr4pkg docstrings 2013-11-13 20:04:54 -05:00
jctanner
065f1edc89 Merge pull request #4420 from Jmainguy/devel
Added resp= option for svr4pkg to enable the -r option in pkgadd for res...
2013-11-13 17:02:58 -08:00
James Tanner
d3128e00c5 Fix parameter typo in swdepot module 2013-11-13 19:57:39 -05:00
jctanner
d32b33f191 Merge pull request #4398 from melodous/module_swdepot
Module swdepot
2013-11-13 16:56:16 -08:00
Stoned Elipot
47072bfb77 Fix homebrew module's install_options handling
...each given option must be a single element in the
arguments list passed as first argument to module.run_command()
2013-11-13 23:20:53 +01:00
James Tanner
f332bb0d7c Fixes #4891 Catch unicodedecode errors from python-apt 2013-11-13 09:48:56 -05:00
Philippe Makowski
4455fea579 Merge remote-tracking branch 'upstream/devel' into devel 2013-11-13 10:09:40 +01:00
James Tanner
710117e4da Addresses #4628 evaluate package check return properly and exit failure if not present 2013-11-12 10:37:27 -05:00
Philippe Makowski
a4ff61748d Merge remote-tracking branch 'upstream/devel' into devel 2013-11-12 15:12:59 +01:00
James Tanner
aafe7f5b37 Fixes #4877 set type to bool for cache parameter in apt module 2013-11-11 23:23:56 -05:00
jctanner
c459347976 Merge pull request #4245 from abelbabel/patch-1
add check mode support to pkgng module
2013-11-11 20:19:21 -08:00
James Tanner
7502e15298 Address #4285 remove redundant stderr output in apt module 2013-11-11 22:27:47 -05:00
jctanner
9faaa2b98b Merge pull request #4285 from blair/apt-module-register-stdout-stderr
apt: pass child process stdout and stdout to m.fail_json() and m.exit_js...
2013-11-11 19:15:10 -08:00
jctanner
a28bcd60d9 Merge pull request #4617 from resmo/feature/python-apt
apt: autoinstall python-apt if apt or apt_pkg is not available
2013-11-11 18:50:43 -08:00
James Tanner
f820e8e719 Merge pull request #4286 from blair/ansible
apt: do not consider not-removed and not-upgraded packages as changes.
2013-11-11 21:39:07 -05:00
Timur Batyrshin
9e7623e9de #4869 compatibility with older versions of apt 2013-11-11 16:56:05 +04:00
Philippe Makowski
38a2ee7751 urpmi module 2013-11-08 21:43:19 +01:00
James Tanner
898de833b0 Merge pull request #4413 from jerm/ansible
Add capability to pass in a PATH prefix to run_command and allow pip module
to utilize that to make virtualenv bin/ available in pip installs
2013-11-07 15:51:27 -05:00
jctanner
015662f5ef Merge pull request #4358 from eslng/apt_add_dpkg_options
apt: allow specifying dpkg options
2013-11-07 08:31:51 -08:00
jctanner
6cebfccd7f Merge pull request #4440 from AndydeCleyre/patch-2
Set default of 'yes' for update_cache, as is in the documentation
2013-11-07 06:46:13 -08:00
Matthias Vogelgesang
2649495fa6 Add zypper_repository module
This change adds the "zypper_repository" module to the packaging library. This
module is used to add and remove additional repositories.
2013-11-07 12:06:55 +01:00
jctanner
8b774f27c2 Merge pull request #4786 from SalesSeek/find-correct-easy-install
Fix determination of correct, possibly customized, 'easy_install' executable
2013-11-06 07:39:19 -08:00
James Tanner
65d68bb1b4 Addresses #4735 Verify the virtualenv command supports --no-site-packages before passing it 2013-11-05 18:51:41 -05:00
Pedro Romano
78c616f271 Obsolete attempts at determining the full path to the desired
'easy_install' executable were still left behind and need to be removed
for the customizable 'executable' task argument to correctly work:
'_get_easy_install' should take care of all the functionality related to
determining the correct 'easy_install' executable to use.
2013-11-02 19:25:51 +00:00
Yegor Minin
df5fd0e0d0 apt: allow specifying dpkg options
This will allow specifying dpkg options as a string passed over to apt
command. dpkg_options expects a comma-separated string of options to be
passed as dpkg options which will be further expanded. For example
dpkg_options='force-confdef,force-confold' will end up as
-o \"Dpkg::Options::=--force-confold\" when passed to apt
Example usage would be:
-m apt -u ubuntu -s \
 -a "upgrade=dist update_cache=yes dpkg_options='force-confold'"
or
apt: upgrade=dist update_cache=yes dpkg_options='force-confold'
2013-11-01 20:11:40 +02:00
chrisalbright
44c2fae805 pip module: fix unexpected behavior when creating virtualenvs
This module supports `virtualenv_site_packages` as an option to control whether or not to include system packages when installing pip packages into a virtual environment. 

The default is no, and when you say yes it explicitly it includes a flag to include site packages, otherwise it doesn't provide a flag. 

Some versions of virtualenv by default include site packages and other versions by default do not. 

This patch just makes both branches explicit, so `virtualenv_site_packages=no` really means no.
2013-10-30 17:27:02 -07:00
Marcus Cobden
414a5b4eab Only remove leading '0x' from key ids, not all 0s 2013-10-30 11:50:34 +00:00
Thomas Omans
c12e2b53e3 Pip module: fixing issue with python 2.4 support
Python 2.4.3 returns:
TypeError: expected character buffer object

startswith is expecting only a string instead of a tuple like newer versions allow.
2013-10-28 15:15:04 -07:00
Michael DeHaan
3722bebb1d Merge pull request #4509 from mremond/gem_executable
Add executable parameter to find gem binary in gem module
2013-10-27 08:59:19 -07:00
Rene Moser
a10e017d6e apt: autoinstall python-apt if not available 2013-10-21 16:39:18 +02:00
Michael DeHaan
21d4400c96 Misc pep8 fixes 2013-10-19 13:03:15 -04:00
Jonathan Mainguy
d58f5a23ae Changed note describing this functionality was added in 1.4 to match what I have seen in other modules 2013-10-19 11:54:36 -04:00
Jimmy Tang
0568abeb14 check for ubuntu distribution first 2013-10-19 14:41:00 +01:00
Michael Scherer
19bb44288e fix distribution detection in apt_repository module, so it also work
on Mint as it work on Debian, fix #4587.

PPAs are not supported however, since that's a Ubuntu specific feature
and mint is detected as a generic distribution and use a different
codename than the Ubuntu release it is based on, which mean that apt_repository
cannot add detect and add the proper url without a better heuristic.
2013-10-19 00:57:08 +02:00
Maykel Moya
2592b2c3f9 Do key validation only when key is provided
key_id is optional, the previous code didn't handle the case of key_id
not specified
2013-10-17 12:04:04 +02:00
Maykel Moya
1a79d9ae58 apt_key: Validate key_id and accept a leading '0x' 2013-10-16 20:52:18 +02:00
James Tanner
00f3ec645d Fixes #4532 Send easy_install to get_bin_path instead of None 2013-10-15 18:15:08 -04:00
James Tanner
7061c99049 fix indentation in easy_install module docstring 2013-10-15 12:49:43 -04:00
Mickaël Rémond
007a3fe154 Add executable parameter to find gem binary in gem module
This is especially needed with rvm where gem binary can be in unusual locations
2013-10-15 09:08:33 +02:00
Jonathan Mainguy
df92881e26 Added note in description explaining this was added in Ansible 1.4 2013-10-14 20:08:44 -04:00
Michael DeHaan
8349c04d06 Merge pull request #4488 from renanivo/devel
create install_options parameter for homebrew module
2013-10-14 16:47:59 -07:00
Pedro Romano
e6062db92f Implement a '_get_easy_install' helper function to find the desired
'easy_install' executable, modeled on '_get_pip'
from the 'pip' module to correctly handle all combinations of explicit
executable and virtualenv.
2013-10-14 11:48:45 -04:00
Pedro Romano
307dd77589 Refactor helper function '_get_pip' to handle the cases where an absolute
path explicit executable is passed to the task and to look for an explicit executable
by basename in a virtualenv if that is specified.
2013-10-14 11:48:28 -04:00
Pedro Romano
57a71043a3 New module argument to specify the executable used for running 'pip'. This allows support for system installation of packages on systems with multiple installations of Python. 2013-10-14 11:48:28 -04:00
Pedro Romano
3c33273071 New module argument to specify the executable used for running 'easy_install'. This allows support for system installation of packages on systems with multiple installations of Python. 2013-10-14 11:48:27 -04:00
Pedro Romano
48e50a9c11 Rename copy/pasted variables more appropriately. 2013-10-14 11:47:59 -04:00
Pedro Romano
5a5d431fa1 Changes examples from using Flask to some other package (Bottle was chosen) as per @mpdehaan's suggestion. 2013-10-14 11:47:59 -04:00
Jurrien Bloemen
55062c69d6 Added full path to rhnreg_ks command for working correctly with sudo. 2013-10-14 16:05:01 +02:00
Yap Sok Ann
812fd22e98 Add packaging module for Gentoo Portage.
This is in no way comprehensive enough to cover all use cases, but hopefully
is sufficient to cover the common ones.
2013-10-14 18:57:48 +08:00
Renan Ivo
776de30e6d update version_added of homebrew module 2013-10-13 15:32:51 -03:00
Renan Ivo
488fb484b7 set default options value to None in homebrew module 2013-10-13 10:42:12 -03:00
Renan Ivo
dd1b44acd5 create install_options parameter to homebrew module 2013-10-13 10:24:07 -03:00
Jonathan Mainguy
9fdf4626ea Changed resp= to response_file= as per mpdehaan's request 2013-10-12 13:28:48 -04:00
Jimmy Tang
a4c8d3ee68 This oneliner change allows apt-key to inherit the http_proxy variable.
Before this fix

  TASK: [apt_repository repo='ppa:vbernat/haproxy-1.5'] *************************
  failed: [134.226.115.202] => {"cmd": ["apt-key", "adv", "--recv-keys", "--keyserver", "keyserver.ubuntu.com", "CFFB779AADC995E4F350A060505D97A41C61B9CD"], "failed": true, "rc": 2}
  stderr: gpg: requesting key 1C61B9CD from hkp server keyserver.ubuntu.com
  gpg: no valid OpenPGP data found.
  gpg: Total number processed: 0

After the fix

  TASK: [apt_repository repo='ppa:vbernat/haproxy-1.5'] *************************
  changed: [134.226.115.202]
2013-10-11 15:19:52 +01:00
Michael DeHaan
119b6d73dd Remove examples of module antipattern of setting the choices array for boolean types. 2013-10-11 08:45:13 -04:00
Andy Kluger
5ce29734d2 Set default of 'yes' for update_cache, as is in the documentation 2013-10-10 17:18:06 -04:00
Michael DeHaan
8d16a39af9 Correct typo 2013-10-10 09:15:04 -04:00
Jonathan Mainguy
e581156dfc Added resp= option for svr4pkg to enable the -r option in pkgadd for response files 2013-10-09 19:57:52 -04:00
Jeremy Price
3955b8e9c2 Adding the bin/ directory of the virtualenv (if you specify a virtualenv) as a path_prefix so that other programs that only exist in the virtualenv will be available to things being installed into said virtualenv. Classic example: installing gevent requires cython binary to be available, but if cython is in the virtualenv only it won't be found without this. 2013-10-09 12:50:29 -04:00
Michael DeHaan
0e55bd892d For values that are booleans in the module doc, the value in the doc section should be a boolean or truthiness
is engaged in the documentation formatting.  This fixes the update_cache default in the docs to the proper
value of "no"
2013-10-09 07:52:23 -04:00
Michael DeHaan
203a4f10cd Use explicit boolean defaults in apt module to make the code more clear. 2013-10-09 07:47:24 -04:00
Raul Melo
c8f9f8825f Changed ansible target version 2013-10-08 00:27:08 +02:00
Raul Melo
59373657fa Change file swdepot perms 2013-10-08 00:24:42 +02:00
Raul Melo
71e52b38f5 Made some code cleanups and use of module.run_command 2013-10-08 00:23:21 +02:00
Raul Melo
a1cdb3110e Module for swdepot (HP-UX package manager) 2013-10-08 00:23:13 +02:00
Michael DeHaan
a8902e878c Merge pull request #4347 from sashka/devel
Remove options and protocols in source line with regex.
2013-10-07 05:55:43 -07:00
Michael DeHaan
8dae9fa5e7 Fix module formatting in the pkgutil module. 2013-10-07 08:24:02 -04:00
Alexander Saltanov
2bd6c5e262 Remove options and protocols in source line with regex.
Fixes #4311
2013-10-03 03:31:04 +04:00
Andy Kluger
ee054a491a Fix for Issue #2470 - gem version string processing
This fix assumes that no sane gem version has spaces in it, so when one like that is encountered, it will get truncated at the first space.
2013-10-02 17:55:30 -04:00
Blair Zajac
3a8c9f04da apt: do not consider not-removed and not-upgraded packages as changes.
If one pins a package and does a 'apt-get dist-upgrade' then the
output looks like:

    # apt-get dist-upgrade
    Reading package lists... Done
    Building dependency tree
    Reading state information... Done
    Calculating upgrade... Done
    The following packages have been kept back:
      cassandra
    0 upgraded, 0 newly installed, 0 to remove and 1 not upgraded.

The check for any changes made should only be on the 'upgraded' and
'newly installed' values and not include the 'to remove' and 'not
upgraded' values.
2013-09-28 16:50:50 -07:00
Blair Zajac
d133c0aeee apt: pass child process stdout and stdout to m.fail_json() and m.exit_json().
Without this, this fails:

    - name: apt-get dist-upgrade
      action: apt upgrade=dist
      register: apt_get_contents

    - name: apt-get clean
      action: command apt-get clean
      when: apt_get_contents.stdout.find("0 upgraded") == -1

TASK: [apt-get clean] *********************************************************

fatal: [192.168.2.2] => error while evaluating conditional: {% if apt_get_contents.stdout.find("0 upgraded") == -1 %} True {% else %} False {% endif %}

FATAL: all hosts have already failed -- aborting
2013-09-28 16:28:18 -07:00
abelbabel
effcb963f6 typo 2013-09-25 18:50:41 +02:00
abelbabel
ee5ab48bec removed typo 2013-09-25 18:38:46 +02:00
abelbabel
e504ff94e6 add check mode support
Could it be that easy or do I have missed something?
2013-09-25 17:51:17 +02:00
Pieter Avonts
60d8f92b3c changed deprecated channel_label attribute 2013-09-20 12:58:43 +02:00
René Moser
ccf4cf1dd8 Fixed missing required package in notes. 2013-09-19 19:34:15 +02:00
James Cammarata
022918e5af Merge branch 'fix/apt_repository_update_cache' of https://github.com/resmo/ansible into resmo-fix/apt_repository_update_cache 2013-09-18 12:40:39 -05:00
René Moser
9fccf96d61 apt_repository: added option update_cache.
The default behavior is to update_cache if changed.

If you add more then one repo, you may not want to update cache for every repo separately.
So you can now disable update_cache with this new option e.g. update_cache=no

Updating cache can also be handled using the apt module.
2013-09-18 19:14:08 +02:00
René Moser
a991b62a51 apt_repository: fix update cache after state=changed. Closes GH-4136 2013-09-18 11:47:39 +02:00
James Cammarata
671eeb65b2 Merge pull request #4138 from resmo/fix/redundant-fail-json
apt: fixed duplicate fail_json
2013-09-17 06:08:51 -07:00
Rene Moser
9449d62fb2 apt: fixed duplicate fail_json 2013-09-17 15:05:20 +02:00
James Cammarata
c6fdb85d88 Merge branch 'issue_3421_apt_pkg_iU' into devel 2013-09-16 06:54:05 -05:00
Michael DeHaan
00c0770f1b Merge pull request #4075 from sayap/easy_install
Locate easy_install path after (optionally) creating virtualenv.
2013-09-15 09:29:51 -07:00
James Cammarata
0d408ff295 Use low-level package objects in the apt module to check installed state
Packages which are half-installed are not adequately represented by
the .is_installed field of the apt.package.Package object. By using the
lower-level apt_pkg.Package object (which provides the .current_state
field), we can check for a partially-installed state more accurately.

Fixes #3421
2013-09-11 23:33:59 -05:00
Hiroaki Nakamura
4d2c2a262a Add an example for installing a group with the yum module. 2013-09-11 02:14:16 +09:00
Hiroaki Nakamura
caa68746ae Fix to getchanged correctly for yum groupinstall. 2013-09-11 02:10:53 +09:00
Yap Sok Ann
498c2665de Locate easy_install path after (optionally) creating virtualenv.
Without this, the first call to the easy_install module with a new virtualenv
will only create the virtualenv without installing the intended package, since
the `_is_package_installed` check will succeed as running /usr/bin/easy_install
as non-root user will return permission denied error with empty stdout.
2013-09-10 11:22:06 +08:00
James Cammarata
808d9596b2 Fixing typos in is_keyid function definition and usage
Fixes #4068
2013-09-09 17:26:44 -05:00
James Cammarata
b3c0e3e45e Revert "Styling: deprecation"
This reverts commit ecc2b6e742.

Fixes #4069
2013-09-09 15:17:43 -05:00
Michael DeHaan
8ec806905d Merge pull request #3942 from jocelynj/gem
Correctly handle option user_install in gem module
2013-08-27 06:00:06 -07:00
James Cammarata
a8984a6b2b Minor text corrections in the yum module documentation 2013-08-24 21:46:41 -05:00
Jocelyn Jaubert
f958a5ac81 Correctly handle option user_install in gem module 2013-08-24 22:49:18 +02:00
Hiroaki Nakamura
aa9e05baa2 Add description and examples for the name parameter accepts a url or a local path to a rpm file. 2013-08-25 02:30:41 +09:00
James Cammarata
1d98e7bc05 Cleaning up some pep8 issues in the pkgutil module 2013-08-22 20:21:02 -05:00
James Cammarata
dfbe1132d2 Merge branch 'allow_wildcard_yum' of https://github.com/mscherer/ansible into mscherer-allow_wildcard_yum 2013-08-22 16:20:10 -05:00
James Cammarata
12f2caeed6 Merge branch 'pacman_local_plus_check' of https://github.com/mivok/ansible into mivok-pacman_support_check_mode 2013-08-22 14:45:54 -05:00
James Cammarata
de4ed11fa6 Merge branch 'pacman_support_check_mode' of https://github.com/mivok/ansible into mivok-pacman_support_check_mode 2013-08-22 14:29:56 -05:00
James Cammarata
ae98a025bb Minor doc fixes for the pkgutil module 2013-08-20 21:08:56 -05:00
Alexander Winkler
59c7ef2afa Added module pkgutil 2013-08-20 21:08:56 -05:00
sjahl
4dd68c07a0 setting 0644 permissions on mkstemp file handles. Fixes issue #3857 2013-08-18 11:03:43 -04:00
Mark Harrison
a347bfa2bb Merge branch 'pacman_local' into pacman_local_plus_check
Conflicts:
	library/packaging/pacman
2013-08-17 17:56:33 -04:00
Mark Harrison
0419fb74bb Support check mode with pacman module 2013-08-17 17:44:41 -04:00
Mark Harrison
f52a1c8f46 Allow installation of local packages with pacman 2013-08-17 14:46:16 -04:00
Michael Scherer
472654447c Allow to use '*test*' in enablerepo for yum action
Yum commandline permit to use a wildcard to enable and disable
repositories in the --enablerepo switch, permitting to enable
a complete set of repository at once ( like all rpmfusion, all
update-testing, etc ).

However, this doesn't work in yum due to more stringent checks
that verify that a exact match is given for the name of the
repository , see commit 5c26805.

This commit enhance the check by permitting to test more than
1 repository at a time, thus permitting to use wildcards.
2013-08-17 18:43:53 +02:00
James Cammarata
10a0f03cdc Cleaning up of apt_repository module and removing wget parts 2013-08-13 16:11:03 -05:00
Michael Vogt
de404eac06 use either pycurl or wget to download from launchpad, also improve error message if neither is installed 2013-08-13 14:39:47 -05:00
Michael Vogt
5e56d42ed1 use pycurl instead of urllib2 when talking to launchpad to actually get SSL cert verification, see https://bugs.launchpad.net/ubuntu/+source/software-properties/+bug/915210 or CVE-2011-4407 for a previous similar issue in software-properties 2013-08-13 14:39:47 -05:00
James Cammarata
0958673574 Reverting version_added field in the apt_repository module 2013-08-13 09:53:49 -05:00
Alexander Saltanov
ded947008a Replacement for apt_repository.
1. Debian Squeeze is supported out of box now.
2. Repository type "deb" or "deb-src" should be explicitly specified.
3. If a source had beed added it must be possible to remove it.
4. PPA can be only used against Ubuntu hosts.
2013-08-13 09:53:49 -05:00
James Cammarata
6feb4e3837 Fail apt package install when nothing is matched by the fnmatch pattern
Related to PR #3823
2013-08-12 11:26:31 -05:00
Michael Vogt
5c39c659e5 add support for fnmatch() style apt filenames
You can write a apt action like "- apt: pkg=apt*" with this package.
2013-08-12 16:11:15 +02:00
Abhijit Menon-Sen
1a90d01ba9 Fix some typos discovered during casual reading 2013-08-11 18:41:23 +05:30
Alan Grosskurth
b950f9456a apt: Run remove commands noninteractively
I'm seeing ansible hang when trying to remove a package, and the hung
process is `whiptail` like in #2763. It looks like we only use
`APT_ENVVARS` and `DPKG_OPTIONS` for the `apt` commands in install()
and upgrade(). This change uses them in remove() as well, which fixes
the hang.
2013-08-05 15:20:45 -07:00
Michael DeHaan
de14995b8c PEP8: fix spacing 2013-08-03 14:55:38 -04:00
Michael DeHaan
40e447fbd4 Merge pull request #3718 from hacosta/rpm_key
Add rpm_key module
2013-08-03 11:39:10 -07:00
Michael DeHaan
caa825b618 Rename option to 'recurse' to make it consistent. Add version_added to docs. 2013-08-03 14:27:11 -04:00
Michael DeHaan
74cde56b60 Merge pull request #3636 from uggedal/pacman-remove-recursive
Pacman module: recursive remove support
2013-08-03 11:26:15 -07:00
Michael DeHaan
4f9d330242 Add version_added to new parameter. 2013-08-03 14:22:38 -04:00
Michael DeHaan
996dbb72eb Merge pull request #3662 from grosskur/apt-key-keyring-param
apt_key: Add 'keyring' parameter
2013-08-03 11:21:52 -07:00
Hector Acosta
c62210ce37 Add rpm_key module
This module can be used to import public keys into your rpm database.

Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
2013-07-31 15:55:38 -05:00
Alan Grosskurth
5ccc7e7277 apt_key: Add 'keyring' parameter
The apt-key command takes an optional --keyring parameter representing
the path to a specific GPG keyring to operate on. If it's not given,
the command operates on all keyring files, i.e., /etc/apt/trusted.gpg
and /etc/apt/trusted.gpg.d/*.gpg.

This change adds a 'keyring' parameter to the apt_key module and
propagates it down to the apt-key command line. The main use case this
supports is organizing keys for third-party repos into individual
keyrings in /etc/apt/trusted.gpg.d, rather than putting them all in
the default keyring.
2013-07-24 18:10:17 -07:00
Andreas Kaiser
f2e3fa9508 Fix pkgin search (yielding wrong results under certain conditions, see inline comments). 2013-07-24 16:18:14 +02:00
Eivind Uggedal
35b918359b Pacman module: recursive remove support 2013-07-23 15:01:13 +02:00
Michael DeHaan
a35370a766 Fix prev feature commit, Do not require aptitude to use apt commands in the apt module, only needed when upgrading. 2013-07-22 15:15:55 -04:00
Michael DeHaan
5e02759570 Merge pull request #3617 from dermute/devel
svr4pkg doesn't work on Sol10
2013-07-22 04:37:10 -07:00
Michael DeHaan
7961a81b3f Update docs to add version_added attribute. 2013-07-21 11:12:04 -04:00
Michael DeHaan
32b3c59bad Merge pull request #3400 from diko4096/patch-1
Update gem
2013-07-21 08:10:27 -07:00
Michael DeHaan
e1167d6977 tweak indentation for 'make pep8' 2013-07-20 12:48:11 -04:00
Patrik Lundin
3f93367579 openbsd_pkg: Use ansible run_command().
This fixes an asterisk glob problem in get_package_state() where a file
in /root/ could cause shell expansion if it matched the package name.
The actual problem is solved by running with shell=False.
2013-07-20 17:45:07 +02:00
Michael DeHaan
f4b1e426ea Merge pull request #3379 from serenecloud/devel
Return a friendly error message if aptitude isn't installed
2013-07-19 07:36:39 -07:00
Michael DeHaan
6aa1ecbc30 Merge pull request #3493 from eest/openbsd_pkg-fixes
openbsd_pkg corner case fixes
2013-07-19 07:30:18 -07:00
Michael DeHaan
0bd8935899 Merge pull request #3515 from neomantra/apt_repository
apt_repository: enhance documentation
2013-07-19 07:06:05 -07:00
Alexander Winkler
52321c1557 fixes ansible/ansible#3547 2013-07-16 09:17:57 +02:00