Commit graph

29520 commits

Author SHA1 Message Date
Michael Shen
70d2750e0a Improve formatting of include_vars doc page (#63482) 2019-11-05 16:48:55 -05:00
Denis
b2939c71b7 Fix modules code quote documentations (#63594) 2019-11-05 16:44:21 -05:00
Major Hayden
fbbf21f771 Add note about spot instances for ec2_instance (#64069)
Signed-off-by: Major Hayden <major@redhat.com>
2019-11-05 16:06:27 -05:00
stevenamelinckx
e704406564 Update firewalld.py (#64153)
+label: docsite_pr
2019-11-05 15:43:23 -05:00
sblondon
2d92ad5736 Admin rights are required (documentation) (#64260) 2019-11-05 15:30:51 -05:00
Jill R
798d622a08 ec2_* Sanity corrections (#64409)
* ec2_* Sanity corrections

Cleanup some typos that were missed in #64230

* Update lib/ansible/modules/cloud/amazon/ec2_launch_template.py

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-11-05 20:58:11 +01:00
Pedro Gomes
de2b29a60f Unlimited CPU credits apply to any T instance (#64372)
+label: docsite_pr
2019-11-05 14:55:05 -05:00
Matthew Davis
4ee9f40e62 Add aws_acm module (#60552)
* convert aws_acm_facts to AnsibleAWSModule

* factor aws_acm_facts into module_utils

* add more filtering options for aws_acm_info

* add aws_acm module and tests

* uncomment aws_acm test

* fix linting for aws_acm

* fix __future__ linting for aws_acm

* fix linting for aws_acm

* fix linting for aws_acm

* fix linting for aws_acm

* fix linting for aws_acm

* fix aws_acm_info arg type

* remove test for old module name aws_acm_facts

* simplify AWS ACM client creation

* fix indent typo in aws_acm test

* catch BotoCoreError in aws_acm

* fix indent typo in aws_acm test

* tighten AWS ACM test policy resource

* move aws acm int test to venv

* remove errant file

* fix AWS ACM int test perms

* undo copyright addition to wrong file

* fix invalid log message in aws_acm

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

* rephrase aws_acm_info doc from facts to information

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

* rename aws_facts var to aws_info

* remove case insensitivity for aws_acm pem compare

* add no_log for aws_acm credential setting

* add per-test prefix to aws_acm test resource names

* make aws_acm use crypto module_util

* clarify copyright for aws_acm

* make aws_acm int test clearer

* add explicit crypto dependency to aws_acm

* change requests for aws_acm pr

* fix wrong copyright owner aws_acm test

* fix wrong copyright owner aws_acm test

* rewrite aws_acm cert chain compare with regex, no dependency

* fix linting for aws_acm unit test

* fix linting for aws_acm unit test

* fix linting and duplicate ignore

* fix failed cert chain split in aws_acm, add more tests

* remove errant file

* more linting fixes for aws_acm

* fix sanity ignore

* rewrite cert compare in aws_acm to use base64 decode

* improve regex for pem cert chain split in aws_acm

* undo changes to crypto module util for aws_acm

* increment ansible version for new aws_acm module

* convert aws_acm return(x) to return x

* increment version added for aws_acm_info new features

* fix linting

* fix bugs with AWS ACM

* fix bad rebase

* disable AWS ACM integration test, due to AWS account limit issue

* remove aws acm integration test from shippable group
2019-11-05 11:57:08 -07:00
Jordan Borean
7acae62fa8 Fix up role version pagination for Galaxy install (#64373)
* Fix up role version pagination for Galaxy install

* Fix sanity issue
2019-11-05 10:34:50 -05:00
Med
a1ab093ddb synchronize - remove unused block (#64344) 2019-11-05 10:34:18 -05:00
Martin Nečas
d9f5be8d0d Ovirt host network dict correct (#64437)
* ovirt_host_network: correct comparing of two dicts

* update mode_number for 4th option
2019-11-05 08:22:17 -05:00
GomathiselviS
4c8d0b1b8d
eos_l2interfaces: Add unit testcases to eos_l2interfaces (#64127)
* Add unit testcases to eos_l2interfaces

* Fixed lint errors

* Corrected lint errors
2019-11-05 07:51:13 -05:00
chkp-orso
3a0c6454a9 Enable logging to any domain in the check point machine (#63976)
* enable using any domain in the check point machine

* Update checkpoint.py

* trying to checge `test_chrckpoint` according to `test_ftd` in order to pass the tests

* Update test_checkpoint.py
2019-11-05 17:44:34 +05:30
Bill Dodd
48e132b9c3 Add GetHealthReport commands (#57494)
* add GetHealthReport commands

* add NetworkInterfaces and SimpleStorage

* convert report uri property keys from plural to singular

* one more plural to sungular uri conversion

* change module name to redfish_info in EXAMPLES docstring
2019-11-05 11:46:58 +00:00
Tomáš Karásek
8f853fef11 Added module for attaching volumes in the Packet host (#27843)
* Added module for attaching volumes in the Packet host

* Fix __future__ import sanity

* removed changed from RETURN doc

* Fix sanity tests, add check mode & few other minor changes
2019-11-05 11:36:59 +00:00
Tomáš Karásek
edf776189d Added module for handling volumes in the Packet Host (#27842)
* Added module for handling volumes in the Packet Host

* fixed CI bot issues

* Fix sanity tests, add check mode & few other minor changes
2019-11-05 11:36:23 +00:00
Tomáš Karásek
a3772e1ac3 New module: Add module for Packet API IP address assignment (cloud/packet/packet_ip_address) (#23133)
* Added module for IP address assignment in the Packet Host

* fixed CI bot issues

* rework of IP address handling to subnets

* fix pep8 in modules/cloud/packet/packet_ip_subnet

* Fix verison added

* Fix sanity tests, rebase, refactor & other improvements
2019-11-05 11:35:25 +00:00
Andrey Klychkov
04c999f0f8 postgresql_idx: add stat mode support (#64138)
* postgresql_idx: add stat mode support

* postgresql_idx: add stat mode support, add changelog

* postgresql_idx: add stat mode support, fix CI
2019-11-05 10:26:51 +00:00
Mark Chappell
9b0d487ce1 Add module_defaults group for ovirt (#64377)
* Add module_defaults group for ovirt

* Update docs to list ovirt module_defaults group
2019-11-05 12:30:41 +05:30
The Magician
0515633189 Bug fixes for GCP modules (#64083) 2019-11-04 14:52:57 -05:00
The Magician
def62163c2 New Module: gcp_compute_reservation_info (#64134) 2019-11-04 14:52:36 -05:00
The Magician
1a726d436e New Module: gcp_compute_target_instance (#64135) 2019-11-04 14:52:28 -05:00
The Magician
14cf1c1197 New Module: gcp_logging_metric (#64339) 2019-11-04 14:51:52 -05:00
The Magician
9517d4c755 New Module: gcp_logging_metric_info (#64340) 2019-11-04 14:51:44 -05:00
The Magician
4569949bcd Bug fixes for GCP modules (#64407) 2019-11-04 14:50:42 -05:00
Mark Chappell
819ba2259d Sanity test fixups for AWS ec2 modules (#64230)
* ec2_ boilerplate

* Deprecate unused options.

* ec2_vol: Perform explicit type checking on volume_size and iops when parsing the args

Boto would through a type exception if the string couldn't be converted to an int.

* ec2_lc_find: remove duplicate definition of region

It's defined in ec2_argument_spec and ec2 doc fragment

* ec2_lc_info: Move responsibility for type checking/conversion of sort_start and sort_end into arg parser

* General sanity test related doc fixups

* Remove EC2 related sanity/ignore.txt entries

* Add changelog fragment
2019-11-04 18:39:31 +00:00
Mark Chappell
8528fbc790 Amazon related Sanity test fixups (remaining batch 2) (#64358)
* Remove sanity/ignore.txt entries

* replace use of "_" as a variable name

* Cleanup boilerplate

* Remove default values from mandatory parameters

* Sanity test documentation updates

* Remove unused imports from iam_role
2019-11-04 16:56:14 +00:00
Sloane Hertel
c1f1b2029c
Support vars plugins in collections (#61078)
* Move var plugins handling to a separate file

* Allow var plugins to require whitelisting

* Add global configuration ('demand', 'start') for users to control when they execute

* Add 'stage' configuration ('all', 'task', 'inventory') for users to control on a per-plugin basis when they execute

* Update ansible-inventory and InventoryManager to the global and stage configuration

* Update host_group_vars to use stage configuration and whitelisting

* Add documentation for using new options and to the developer's guide

* Add integration tests to exercise whitelisting and the new configuration options, using vars plugins in collections, and maintain backward compatibility

* Changelog

Co-Authored-By: Brian Coca <brian.coca+git@gmail.com>
Co-Authored-By: Sandra McCann <samccann@redhat.com>
2019-11-04 11:41:14 -05:00
Mads Jensen
39bf09517a wait_for - remove an obsolete fallback for Python 2.6 (#63988) 2019-11-04 11:39:19 -05:00
Mark Chappell
8c8077b5be Amazon related Sanity test fixups (remaining batch 1) (#64368)
* Remove Sanity test ignore.txt entries

* Fixup boilerplate

* Remove use of blacklisted _ variable name

* cloudformation: Add an explicit removal version for template_format

This option's been ignored since ansible 2.3

* General docs cleanup to clear sanity errors

* elasticache_parameter_group: Add list of choices

- matches documented choices
- other values wouldn't have worked

* data_pipeline: Deprecate 'version' - always ignored

* Add deprecation documentation
2019-11-04 15:13:27 +00:00
Mads Jensen
3126c38f8a Replace import of pycompat24.literal_eval with ast.literal_eval. (#64088) 2019-11-04 09:55:08 -05:00
Sam Doran
c67c23234a
clean_facts - use correct variable when evaluating the string (#64284)
A regexp object has no .startswith() method, which caused an unnecessary
try/except block to be added to handle this.
2019-11-04 09:44:10 -05:00
Martin Nečas
816e194e37 ovirt_vm: update cpu_threads docs (#64380) 2019-11-04 07:19:07 -05:00
Xu Yuandong
9e3b1f3b32 Doc notes 2 (#64347)
* addd

* all  update

* add/fix notes about modules work with connection

* duplication of key "notes"

* Update ce_evpn_bgp_rr.py

* Update ce_evpn_bgp.py
2019-11-03 21:56:57 -05:00
Xu Yuandong
1d40d429a0 Doc notes 5 (#64350)
* addd

* all  update

* add/update notes.

* add/updates notes.
2019-11-03 21:46:18 -05:00
Xu Yuandong
25e03b1e75 Doc notes 6 (#64351)
* addd

* all  update

* update/add notes.
2019-11-03 21:46:07 -05:00
Xu Yuandong
ad0769c095 Doc notes 3 (#64348)
* addd

* all  update

* update/add notes.
2019-11-03 21:35:12 -05:00
Xu Yuandong
703f7a149a Doc notes 4 (#64349)
* addd

* all  update

* add/update notes.
2019-11-03 21:35:03 -05:00
Xu Yuandong
705c014ec3 Doc notes 1 (#64346)
* addd

* all  update

* add notes to set modules works with C(connection)
2019-11-03 21:25:24 -05:00
Ganesh Nalawade
c27e47327f
Refactor CLI prompt mode check for network plugins (#63945)
* Refactor CLI prompt mode check for network plugins

*  Move the CLI prompt mode check logic from action plugin
   to the controller side with the cliconf plugins.

*  This refactor also allows the network modules
   to initialise the persistent connection with remote device
   only when it is required.

* Fix review comments
2019-11-03 04:10:30 +05:30
Andrey Klychkov
73526b9d65 mysql_variables: add mode parameter (#63547)
* mysql_variables: add mode parameter

* mysql_variables: add mode parameter, add changelog fragment

* mysql_variables: add mode parameter, fix

* mysql_variables: add mode parameter, fix

* mysql_variables: add mode parameter, fix

* mysql_variables: add mode parameter, fix sanity

* mysql_variables: add mode parameter, remove warns

* mysql_variables: add mode parameter, refactoring

* mysql_variables: add mode parameter, fix logic
2019-11-02 10:16:28 +01:00
Chris Smart
42b290b781 cloud/openstack: fix os_server_action errors when wait is False (#64330)
Using os_server_action to perform start, stop and pause actions on a
server in OpenStack results in an error when 'wait' is False.

The command is successfully sent to OpenStack, however Ansible fails the
task:

  fatal: [127.0.0.1]: FAILED! => {
    "changed": false,
    "msg": "New-style module did not handle its own exit"
  }

This patch ensures that those actions always exit, whether running with
'wait' set to True or False.

As we are not waiting to confirm the result, this assumes that the
actions were successful.

Fixes #62958

Signed-off-by: Chris Smart <chris.smart@humanservices.gov.au>
2019-11-02 04:42:34 -04:00
willtome
bbbaf0dfe7 VMware Inventory Enhancements (#63938)
* Fixes #63937

* Add the environment variables VMWARE_HOST, VMWARE_USER, and VMWARE_VALIDATE_CERTS for consistency

* Follow the general pattern for config file naming requirements and update the documentation
2019-11-01 16:16:56 -04:00
Sloane Hertel
371d7aae31
Use templating in HostVarsVars __repr__ (#64282)
* Fix HostVarsVars templating

* Add some tests for HostVars and HostVarsVars templating

* changelog
2019-11-01 15:51:34 -04:00
The Magician
5dff5603af New Module: gcp_compute_reservation (#64133) 2019-11-01 13:46:42 -04:00
The Magician
6e63210620 New Module: gcp_compute_target_instance_info (#64136) 2019-11-01 13:46:34 -04:00
Pierre Prinetti
2444fae208 Add a named parameter to the filter to_uuid (#64057)
Let the caller choose a namespace for `to_uuid` and document the
behaviour of both the default case, and the new explicit case.

This PR does not change the existing behaviour of the `to_uuid` UUIDv5
filter.
2019-11-01 13:11:34 -04:00
Geoffrey Blake
7b7f15cb3a Fix ec2_instance module where if placement_group and tenancy are (#63340)
both set in params, the placement_group setting is ignored.
2019-11-01 10:10:07 -07:00
Patrick O'Brien
c76e074e4c Callback: removing args from task_fields from Sumologic and Splunk plugin(#63527)
CVE-2019-14864 Ansible: Splunk and Sumologic callback plugins leak sensitive data in logs

Fixes #63522

Signed-off-by: Patrick O’Brien <patrick.obrien@thetradedesk.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-11-01 19:51:11 +05:30
Ganesh Nalawade
60276d3d8d
Fix network plugin config option load from collection (#64046)
* Fix network plugin config option load from collection

Fixes #63975

* Update the complete sub-plugin name within network
  connection plugins to handle sub-plugin in collection
  scenario.

* Fix review comments
2019-11-01 11:25:28 +05:30