Michael Letterle
b8a41a90b8
Wrap Get-MachineSid's body in a try/catch
...
It's not critical information and there's been a number of issues over
the years with trying to retrieve it. If an exception is thrown just
return null.
Fixes : #47813
2019-07-17 19:11:56 -04:00
Yunge Zhu
42c43a2822
add azure_rm_keyvaultkey_info module ( #55754 )
2019-07-18 06:55:51 +08:00
Matt Clay
13bbfacb04
Show ansible-test --explain errors in CI.
2019-07-17 15:34:00 -07:00
Toshio Kuratomi
5392d8697d
Docs scripts cleanup ( #59169 )
...
* Fix dump_keywords to require attribute docs
* Change the documentation commands to make definition files positional
Since the definition files are mandatory, make them positional
parameters instead of options.
2019-07-17 12:01:07 -07:00
Brian Coca
c2253c8133
Allow for no role_versions to be present ( #56519 )
...
* Allow for no role_versions to be present
fixes #46650
better info on fetch, ensure list return
* use correct to_
2019-07-17 12:35:24 -04:00
Brian Coca
4ef2545eb5
if users are None/empty, dont assume sameness ( #58875 )
2019-07-17 11:17:48 -04:00
Brian Coca
48d4d6ec69
Stop ignoring merge hash behaviour in inventory ( #58460 )
...
* stop ignoring merge hash behaviour in inventory
fixes #58120
* added porting note
Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
2019-07-17 11:16:56 -04:00
Andrey Klychkov
0e09800a9a
Postgresql modules: tidying up of CI tests ( #59099 )
2019-07-17 11:00:40 -04:00
Brian Coca
a39b721db5
fixes to config manager ( #58530 )
...
* skip unreadable ansible.cfg
* all types should check for type
* patch access for tests and fix tests that relied on missing files not being checked
2019-07-17 10:39:30 -04:00
Brian Coca
5ac2c6d4fe
remove unused and obsolete bsd port makefile ( #58633 )
...
freebsd itself has maintained and up to date version of port
2019-07-17 10:36:44 -04:00
dx0xm
b8eba8e1f0
VMware: Add testcase for vmware_dvs_portgroup_facts ( #59088 )
...
* Tests for choosing specific DVS while gathering facts
Signed-off-by: dx0xm <52723266+dx0xm@users.noreply.github.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-17 18:31:52 +05:30
Phillipe Smith
ce907c8b90
New module os_group_info ( #57120 )
...
* Added domain_id param to get_group
* Added module os_group_facts based on os_project_facts
* Fix pep8 alarms and version_added to 2.9
* Update lib/ansible/modules/cloud/openstack/os_group_facts.py
Co-Authored-By: Raimund Hook <1150270+StingRayZA@users.noreply.github.com>
* Update lib/ansible/modules/cloud/openstack/os_group_facts.py
Co-Authored-By: Raimund Hook <1150270+StingRayZA@users.noreply.github.com>
* Update lib/ansible/modules/cloud/openstack/os_group_facts.py
Co-Authored-By: Raimund Hook <1150270+StingRayZA@users.noreply.github.com>
* Update lib/ansible/modules/cloud/openstack/os_group_facts.py
Co-Authored-By: Raimund Hook <1150270+StingRayZA@users.noreply.github.com>
* Fixes based on https://github.com/ansible/ansible/pull/57120#issuecomment-511338588
* Update lib/ansible/modules/cloud/openstack/os_group_info.py
Co-Authored-By: Felix Fontein <felix@fontein.de>
* Update lib/ansible/modules/cloud/openstack/os_group_info.py
Co-Authored-By: Felix Fontein <felix@fontein.de>
* Update lib/ansible/modules/cloud/openstack/os_group_info.py
Co-Authored-By: Felix Fontein <felix@fontein.de>
* Removed availability_zone option
* Revert "Removed availability_zone option"
This reverts commit 20155c0b0f
.
* Reverted to the original code to open a new Pull Request
2019-07-17 13:55:53 +02:00
Jordan Borean
edfdf30bcb
Improve docs for win_service for custom account rights ( #59155 )
2019-07-17 08:03:47 +01:00
dx0xm
09aa98bf43
VMware: Gather facts about vlan id from DVS Portgroup in vmware_dvs_portgroup_facts ( #59085 )
2019-07-17 11:39:44 +05:30
Hannes Ljungberg
6f94995b52
npm: Validate all option types ( #58965 )
...
* Add type validation for name, version and registry
* Add changelog fragment
* Remove ignore of E337 and E338
2019-07-17 09:34:58 +05:30
Eugene Narciso
fbb4eaaba9
Update net_static_route document ( #59168 )
...
Update net_static_route examples section document, the missing colon can potentially cause confusion.
2019-07-17 09:08:34 +05:30
Sumit Jaiswal
0bde145b1f
PR to fix minor issues with Checkpoint module ( #58049 )
...
* minor checkpoint module fix
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
* state default value set
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-07-16 18:51:32 -04:00
Fred-sun
6430205d39
Update azure_rm_virtualmachine related document ( #58861 )
...
* Update azure_rm_virtualmachine_facts module's documentation with nitzmahone feedback, CI fixes
* 'remove_on_absent' does not define choices
2019-07-16 15:58:14 -05:00
Matt Clay
493785ccef
Remove extra blank line from galaxy .travis.yml.
...
This fixes the last yamllint error on the file.
The file is currently ignored by CI, but that will be changing soon.
2019-07-16 13:50:19 -07:00
Matt Davis
d28f25d118
patch ansible-connection collection plugin loading ( #59119 )
2019-07-16 13:46:15 -07:00
Matt Clay
d4dec59cb0
Fix collection loader builtin handling. ( #58897 )
...
- Support more import statements:
from ansible_collections.ansible.builtin.plugins.module_utils import basic
from ansible_collections.ansible.builtin.plugins.module_utils.basic import AnsibleModule
- Add unit tests for more import statements.
- Raise ImportError instead of returning None if load_module fails.
2019-07-16 13:40:22 -07:00
Shachaf92
681ab6515a
win_domain_group_membership - Fix to a fix in extra_args ( #58943 )
...
* win_domain_group_membership - Fix to a fix in extra_args
* addig missing l on the fly
2019-07-17 05:38:42 +10:00
Alicia Cozine
e5e3486be6
clarifies how ASK works for Tower credentials ( #59050 )
...
* clarifies how ASK works for credentials
2019-07-16 15:37:47 -04:00
Toshio Kuratomi
019d078a5a
Move common build code from _build_helpers ( #55986 )
...
We have some common code used by several docs scripts. Migrate that
into the build-only shared code repository.
* Move lib/ansible/utils/_build_helpers.py to the directory for common
build code
* Migrate docs/bin/dump_config.py to a build-ansible subcommand
* Migrate dump_keywords to the build-ansible framework
* Make the script more maintainable by using functions and good
variable names
* Port to Python3 idioms
* Fix bug so that private attributes will be undocumented
* Move generate_man to a build-ansible subcommand
* Port plugin_formatter to a build-ansible subcommand
* Rework command_plugins so that docs scripts can target Python-3.4+ and
releng-only subcommands can use more recent versions of Python.
The architecture is now that command_plugins/* need to be importable
on Python-3.4. The init_parsers() method needs to run on Python-3.4.
But the main() method can utilize features of more recent Python as
long as it fits within those parameters.
* Update docs build requirements
Port the plugin_formatter to build-ansible framework
2019-07-16 12:19:01 -07:00
Fred-sun
65e0f37fc0
Update azure_rm_virtualnetwork related document ( #59023 )
...
* Update azure_rm_virtualnetwork related documentation
2019-07-16 14:18:20 -05:00
Kyle Sferrazza
b376c91749
win_hotfix: fix docs typo ( #59124 )
2019-07-16 14:09:13 -05:00
Fred-sun
c7387549a4
Update azure_rm_virtualnetworkpeering related document ( #59025 )
...
* Update azure_rm_virtualnetworkpeering related documentation
2019-07-16 14:04:32 -05:00
Matt Clay
cb0dfc9793
Prepare pylint test for collections support.
2019-07-16 11:24:16 -07:00
Chris Archibald
8bf069114f
New Module: Vscan Enable ( #57953 )
...
* new module
* fix netapp.py
* updates
* fixes
2019-07-16 13:40:56 -04:00
Sam Doran
d17e7a91b1
Add test for meta: end_play ( #59118 )
...
- Set ansible_python_interpreter for hosts using local connection
2019-07-16 12:41:48 -04:00
Wojciech Sciesinski
e8a7d89180
Correct a documentation of the jenkins_plugin module ( #59139 )
2019-07-16 11:46:18 -04:00
Dara Poon
b16c264dca
chroot connection plugin: defer get_option() call ( #59065 )
...
* The chroot connection plugin crashes because its constructor calls
self.get_option(...) before the plugin loader has established its
self._load_name. Therefore, we should defer the self.get_option(...)
call so that it happens in connect().
Fixes #59063
2019-07-16 11:31:06 -04:00
Kiyo Nagamine
88c4cf28ea
Modified blockinfile module's exmple using loop keyword ( #59022 )
2019-07-16 11:13:04 -04:00
Ewoud Kohl van Wijngaarden
9c5b3401ff
Close file after using it ( #59000 )
2019-07-16 10:07:27 -05:00
Matt Clay
2ed78b650f
Update to ansible-test to prepare for collections.
...
Changes to simplify merging of collections support.
2019-07-16 08:04:07 -07:00
Jonathan
f0eaf1fb39
Module mail : Add Date header ( #59080 )
...
* Mail module : add date header (#58808 )
2019-07-16 10:55:59 -04:00
Abhijeet Kasurde
de66abe521
VMware: Add support for storagePod ( #58627 )
...
* User now can be specify datastore cluster for deploying OVF
* Added find_resource_pool_by_cluster API
Fixes : #57849
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-16 13:14:21 +05:30
Gonéri Le Bouder
a63e17cd63
vmware_vmkernel: simplify the code ( #55176 )
...
- drop a dead branch in a condition tree
- simplify the look-up of the vnic
2019-07-16 09:28:22 +05:30
Matt Clay
4b9391f32a
Clean up ansible-test target handling.
2019-07-15 20:33:23 -07:00
A Codeweavers Infrastructure Bod
e2adb37789
crypttab: 'NoneType' object is not callable when password is NoneType ( #56790 )
...
This looks to have been broken in commit 8bd5757720
where a fields.append was replaced with a call to self.password
2019-07-16 07:58:19 +05:30
Matt Clay
4255ee8e5a
Prepare ansible-test for collections support.
...
Another round of changes to prepare ansible-test for supporting collections to help keep later PRs a manageable size.
2019-07-15 17:46:29 -07:00
Matt Clay
f81238012b
Clean up pylint issues in test infra.
2019-07-15 14:45:30 -07:00
Fred-sun
9e6399f74c
Update azure_rm_virtualmachinescalesetextension related document ( #58908 )
...
* Update azure_rm_virtualmachinescalesetextension documentation
2019-07-15 16:02:42 -05:00
d-little
ee71a7df74
timezone - Add AIX support using chtz
( #58838 )
...
* init AIX support
* fix pylint whitespace issues
* Switch chtz from required=False to True
* Refactor AIX to include _get_timezone()
* More Pylint...
2019-07-15 15:52:50 -04:00
Milan Zink
7cbd06f3a3
Adding vserver/SVM NFS info to na_ontap_gather_facts ( #58826 )
2019-07-15 14:35:09 -04:00
Xu Yuandong
7a0a21ea7a
ce_file_copy : update ce_file_copy to fix a bug. ( #59071 )
...
* update ce_file_copy to fix a bug.
* Update ce_file_copy.py
* Update ce_file_copy.py
2019-07-15 14:18:46 -04:00
Elijah DeLee
a6d32eda84
Remove extra print statement ( #59104 )
...
Let ansible-inventory handle all output
Fixes #59101
2019-07-15 13:26:19 -04:00
Martin Krizek
4898b0a4a2
group: detect duplicate GIDs when local=yes ( #58469 )
2019-07-15 12:52:15 -04:00
Alvaro Olmedo Rodriguez
a1dcba63b3
java_keystore - Prefer SHA256 and solve SHA256 keytool in java11 version ( #57302 )
2019-07-15 12:44:30 -04:00
Andrey Klychkov
2a07123fdd
jboss module: add check mode support and integration tests ( #58959 )
...
* git war file and wildfly archive from S3
* create setup_wildfly_server role for integration tests
2019-07-15 12:17:08 -04:00